This patch removes the warnings reported by checkpatch.pl on the line
over 80 characters.
Signed-off-by: Sunghoon Cho
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h
b/driv
This patch adds a blank line right after a struct declaration.
Signed-off-by: Sunghoon Cho
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h
b/drivers/staging/wilc1000/wilc_wfi_netdevice.h
index 22
This patch removes the warnings reported by checkpatch.pl regarding
prohibited spaces between function name and open parenthesis.
Signed-off-by: Sunghoon Cho
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/
On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee
wrote:
> Usually I use the checkpatch which is in linux-next. That will be the
> latest version. If you compare, last commit on checkpatch of staging
> tree was on April 16th, where as last commit in linux-next is on
> June 19th. And if you use this
linux/ieee80211.h already defines constants for capability bits.
Include it where needed, resolve discrepancies in naming, and remove the
duplicated definitions.
Also, make use of WLAN_CAPABILITY_IS_STA_BSS() macro to check if neither
ESS nor IBSS capability bits are set.
Signed-off-by: Jakub Sit
Use eth_zero_addr to assign the zero address to the given address
array instead of memset when second argument is address of zero.
Note that the 6 in the third argument of memset appears to represent
an ethernet address size (ETH_ALEN).
The Coccinelle semantic patch that makes this change is as fo
On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee
wrote:
> Usually I use the checkpatch which is in linux-next. That will be the
> latest version. If you compare, last commit on checkpatch of staging
> tree was on April 16th, where as last commit in linux-next is on
> June 19th. And if you use this
Use eth_zero_addr to assign the zero address to the given address
array instead of memset when second argument is address of zero.
Note that the 6 in the third argument of memset appears to represent
an ethernet address size (ETH_ALEN).
The Coccinelle semantic patch that makes this change is as fo
On Thu, Jun 25, 2015 at 09:26:00AM -0700, Juston Li wrote:
> On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee
> wrote:
> > On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote:
>
> > 2) Considering that you are giving consitent space around operators, then
> > i think you have misse
On Thu, Jun 25, 2015 at 02:27:02PM -0700, Juston Li wrote:
> On Thu, Jun 25, 2015 at 1:31 PM, Dan Carpenter
> wrote:
> Patchset was responded by Greg's patch bot, I'll resend when I figure out
> why.
Greg will not apply any patch since the merge window is open. That
patchbot will respond when
I am a high school student trying to become familiar with linux kernel
development. This is my first patch.
checkpatch.pl throws a warning that config WIMAX_GDM72XX_QOS, config
WIMAX_GDM72XX_K_MODE, and config WIMAX_GDM72XX_USB do not have enough
of a description. By splitting the current descript
On 25/06/15 17:53, Gujulan Elango, Hari Prasath (H.) wrote:
From: Hari Prasath Gujulan Elango
Prefer using the BIT macro for shifting operation
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/comedi/comedi.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
On Thu, Jun 25, 2015 at 1:31 PM, Dan Carpenter wrote:
> Once you add the else statement, then that kind of doesn't make sense.
> Sudip is right. It should be:
>
> } else {
> /* commentary about else side */
Yeah, that does make more sense. I'll change it, thanks.
Patchse
The header socklnd.h includes irq.h which is not need
and doesn't exist in the OpenSFS lustre branch. Having
irq.h in socklnd.h does break the build on the m68k
platform. So we can safely remove it.
Signed-off-by: James Simmons
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.h|1 -
1 f
On Thu, Jun 25, 2015 at 08:49:30AM -0700, Juston Li wrote:
> I placed it above the else to make it consistent with the if statement with
> similar comment that the else corresponds to:
>
> /* Set the primary display control */
> - if (!ctrl)+ if (!ctrl) {
Once you add the else statement, then tha
Convert a Microsoft compiler specific directive "#pragma pack(1)" to a
GCC equivalent __packed. Also, by doing this we save
ourselves from trouble if any other struct definitions are added after
the #pragma because it will be applied to all of the definitions
following it.
Signed-off-by: Giedrius
> On 25 Jun 2015, at 15:05, Dmitry Kalinkin wrote:
>
>
>> On 25 Jun 2015, at 14:27, Sudip Mukherjee wrote:
>>
>> On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote:
>>> Signed-off-by: Dmitry Kalinkin
>>> ---
>>> drivers/staging/vme/devices/vme_user.c | 47
>>> --
From: Jake Oshins
This patch series changes the way that hv_vmbus searches for ranges of
memory-mapped I/O space (MMIO) which can be used by its children. The old
way just found the one and only range above 4GB. This one makes all ranges
exposed in the VM's firmware potential candidates. It a
From: Jake Oshins
This patch deletes the logic from hyperv_fb which picked a range of MMIO space
for the frame buffer and adds new logic to hv_vmbus which picks ranges for
child drivers. The new logic isn't quite the same as the old, as it considers
more possible ranges.
Signed-off-by: Jake Osh
From: Jake Oshins
This patch changes the logic in hv_vmbus to record all of the ranges in the
VM's firmware (BIOS or UEFI) that offer regions of memory-mapped I/O space for
use by paravirtual front-end drivers. The old logic just found one range
above 4GB and called it good. This logic will fin
From: Hari Prasath Gujulan Elango
Prefer using the BIT macro for shifting operation
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/comedi/comedi.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/co
On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee
wrote:
> On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote:
>> fixes checkpatch.pl error:
>> ERROR: need consistent spacing around ''
> little bit confused.
> 1) Your subject says consistent space around operators but here it says
>
Under the 'default' case in scmnd->sc_data_direction we have 3 options:
- DMA_NONE which we handle correctly.
- DMA_BIDIRECTIONAL which is never supposed to be set by SCSI stack.
- Garbage value.
Do WARN() and return -EINVAL in the last two cases. virtio_scsi does
BUG_ON() here but it looks like a
On Thu, Jun 25, 2015 at 5:17 AM, Sudip Mukherjee
wrote:
> On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote:
>> Fix brace placement errors caught by checkpatch.pl
>> ERROR: that open brace { should be on the previous line
>>
>> Signed-off-by: Juston Li
>> ---
>
>> @@ -71,14 +66,11 @@ sta
>> > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
>> > b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
>> > index 53275f9..7125eb9 100644
>> > --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
>> > +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
>> > @@
>On Thu, Jun 25, 2015 at 3:33 AM, Guenter Roeck wrote:
>> I have not tested it, but I think the following may fix the problem
>> while avoiding any include problems. Since pt_regs is used in the file,
>> one could argue that it should be declared.
>
>Indeed. I tried that, but...
>
>> --
>> diff --
On Thu, 25 Jun 2015, Vitaly Kuznetsov wrote:
> Loaded Hyper-V module will use these functions to disable CPU hotplug
> under certain circumstances. Convert cpu_hotplug_disabled to a counter
> (protected by cpu_add_remove_lock) to support e.g. disable -> disable ->
> enable call sequences.
This ch
Commit 5a75d733 ("Drivers: hv: hv_balloon: don't lose memory when
onlining order is not natural") made hv_hotadd_state description a bit
ambiguous. Fix this and a typo.
Reported-by: Jason Wang
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_balloon.c | 4 ++--
1 file changed, 2 insertions
On 25/06/15 12:14, Maninder Singh wrote:
pci_dev_put checks for NULL pointer itself,
reported by coccinelle
Signed-off-by: Maninder Singh
Reviewed-by: Yogesh Gaur
---
v2: changelog typo cehcks -> checks
drivers/staging/comedi/drivers/adl_pci9118.c |3 +--
1 file changed, 1 insertion(+)
On 25/06/15 12:21, Dan Carpenter wrote:
On Thu, Jun 25, 2015 at 04:20:26PM +0530, Maninder Singh wrote:
pci_dev_put cehcks for NULL pointer itself,
reported by coccinelle
This patch is correct but the motivation is wrong.
The check in pci_dev_put() is like a sanity check. There are many
fun
David Decotigny writes:
> The code shows a couple inconsistencies (described in commit
> descriptions) which would not be an issue on little-endian cpus, but
> could cause breakage on non-LE cpus. Note: I could not test on real
> hardware, these patches created based on sparse reports.
>
> Hostory
From: Erik Arfvidson
This driver provides mouse and keyboard input to Unisys s-Par
Partition Desktop application. This device is created by the
visorbus device.
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/Kconfig | 1 +
drivers/
Commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer
hypervisors") was altering smp_ops.cpu_disable to prevent CPU offlining.
We can bo better by using cpu_hotplug_enable/disable functions instead of
such hard-coding.
Reported-by: Radim Krčmář
Signed-off-by: Vitaly Kuznetsov
Loaded Hyper-V module will use these functions to disable CPU hotplug
under certain circumstances. Convert cpu_hotplug_disabled to a counter
(protected by cpu_add_remove_lock) to support e.g. disable -> disable ->
enable call sequences.
Signed-off-by: Vitaly Kuznetsov
---
Documentation/power/sus
Changes since v4:
- In disable_nonboot_cpus() do cpu_hotplug_disabled++ unconditionally as
its users are doing enable_nonboot_cpus() on their failure paths.
Changes since v3:
- add WARN_ON when decreasing cpu_hotplug_disabled [Peter Zijlstra]
Changes since v2:
- Rebase on top of current Greg's
Correct a checkpatch.pl warning regarding
WARNING: else is not generally useful after a break or return
drivers/staging/speakup/keyhelp.c:185:
Changing the order of the if blocks, but not the logic, to avoid this
warning. The block after else will run if the blocks KT_CUR or KT_LATIN
set cur_item
Signed-off-by: Luis de Bethencourt
---
drivers/staging/speakup/keyhelp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/keyhelp.c
b/drivers/staging/speakup/keyhelp.c
index 9475674..02d5c70 100644
--- a/drivers/staging/speakup/keyhelp.c
+++ b/drivers/s
current_pt_regs() sometimes returns regs of the userspace process and in
case of a kernel crash this is not what we need to report. E.g. when we
trigger crash with sysrq we see the following:
...
RIP: 0010:[] []
sysrq_handle_crash+0x16/0x20
RSP: 0018:8800db0a7d88 EFLAGS: 00010246
RAX: 000
On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote:
> Fix brace placement errors caught by checkpatch.pl
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Juston Li
> ---
> @@ -71,14 +66,11 @@ static void setDisplayControl(int ctrl, int dispState)
>
On Wednesday 24 June 2015 13:34:58 Gaston Gonzalez wrote:
> On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote:
> > On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote:
> > > /* WMM spec P.11: The minimum value for AIFSN shall be 2
> > > */
> > > qos_pa
> On 25 Jun 2015, at 14:27, Sudip Mukherjee wrote:
>
> On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote:
>> Signed-off-by: Dmitry Kalinkin
>> ---
>> drivers/staging/vme/devices/vme_user.c | 47
>> --
>> 1 file changed, 11 insertions(+), 36 deletion
On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote:
> fixes checkpatch.pl error:
> ERROR: need consistent spacing around ''
little bit confused.
1) Your subject says consistent space around operators but here it says
around ''
2) Considering that you are giving consitent space around
"K. Y. Srinivasan" writes:
> From: Vitaly Kuznetsov
>
> current_pt_regs() returns regs of the userspace process and in case of
> kernel crash this is not what we need to report. E.g. when we trigger
> crash with sysrq we see the following:
> ...
> RIP: 0010:[] []
> sysrq_handle_crash+0x16/0x2
Hi,
>This patch is correct but the motivation is wrong.
>
>The check in pci_dev_put() is like a sanity check. There are many
>functions which have a sanity check and many which do not, it is
>impossible for a human to remember the complete list of each. When we
>remove explicit checks for NULL a
On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote:
> Signed-off-by: Dmitry Kalinkin
> ---
> drivers/staging/vme/devices/vme_user.c | 47
> --
> 1 file changed, 11 insertions(+), 36 deletions(-)
>
> @@ -178,38 +167,24 @@ static ssize_t buffer_to_use
On Thu, Jun 25, 2015 at 04:20:26PM +0530, Maninder Singh wrote:
> pci_dev_put cehcks for NULL pointer itself,
> reported by coccinelle
>
This patch is correct but the motivation is wrong.
The check in pci_dev_put() is like a sanity check. There are many
functions which have a sanity check and m
pci_dev_put checks for NULL pointer itself,
reported by coccinelle
Signed-off-by: Maninder Singh
Reviewed-by: Yogesh Gaur
---
v2: changelog typo cehcks -> checks
drivers/staging/comedi/drivers/adl_pci9118.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/stagin
>> pci_dev_put cehcks for NULL pointer itself,
>did you mean checks?
Yes did some typo, send v2 of the patch.
Thanks
--
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Jun 25, 2015 at 04:20:26PM +0530, Maninder Singh wrote:
> pci_dev_put cehcks for NULL pointer itself,
did you mean checks?
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/
pci_dev_put cehcks for NULL pointer itself,
reported by coccinelle
Signed-off-by: Maninder Singh
Reviewed-by: Yogesh Gaur
---
drivers/staging/comedi/drivers/adl_pci9118.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/dri
Vitaly Kuznetsov writes:
> Loaded Hyper-V module will use these functions to disable CPU hotplug
> under certain circumstances. Convert cpu_hotplug_disabled to a counter
> (protected by cpu_add_remove_lock) to support e.g. disable -> disable ->
> enable call sequences.
>
> Signed-off-by: Vitaly K
Full kernel hang is observed when kdump kernel starts after a crash. This
hang happens in vmbus_negotiate_version() function on
wait_for_completion() as Hyper-V host (Win2012R2 in my testing) never
responds to CHANNELMSG_INITIATE_CONTACT as it thinks the connection is
already established. We need t
When general-purpose kexec (not kdump) is being performed in Hyper-V guest
the newly booted kernel fails with an MCE error coming from the host. It
is the same error which was fixed in the "Drivers: hv: vmbus: Implement
the protocol for tearing down vmbus state" commit - monitor pages remain
specia
Changes since v2:
- Get rid of #ifdefs in mshyperv.c [Olaf Hering, Greg KH]
PATCH 2/5 is added to support the change.
- Fix (also broken) kdump [K. Y. Srinivasan]
PATCH 5/5 added.
Changes since v1:
- rebased on top of current Greg's char-misc-next tree.
To make general-purpose kexec (not just
At the very late stage of kexec a driver (which are not being unloaded) can
try to post a message or signal an event. This will crash the kernel as we
already did hv_cleanup() and the hypercall page is NULL.
Move all common (between 32 and 64 bit code) declarations to the beginning
of the do_hyper
If some piece of code wants to check kexec_in_progress it has to be put
in #ifdef CONFIG_KEXEC block to not break the build in !CONFIG_KEXEC
case. Overcome this limitation by defining kexec_in_progress to false.
Signed-off-by: Vitaly Kuznetsov
---
include/linux/kexec.h | 1 +
1 file changed, 1 i
We already have hv_synic_free() which frees all per-cpu pages for all
CPUs, let's remove the hv_synic_free_cpu() call from hv_synic_cleanup()
so it will be possible to do separate cleanup (writing to MSRs) and final
freeing. This is going to be used to assist kexec.
Signed-off-by: Vitaly Kuznetsov
On 25/06/15 05:40, Sudip Mukherjee wrote:
On Wed, Jun 24, 2015 at 11:22:24PM +0530, Santosh wrote:
try_module_get fails when the reference count of the module is not
allowed to be incremented ,and hence -ENXIO is returned indicating
no device or address.
1) this patch is 2/2, but then
On Thu, Jun 25, 2015 at 10:04:59AM +0530, Sudip Mukherjee wrote:
> On Wed, Jun 24, 2015 at 12:12:01PM +0200, Luis de Bethencourt wrote:
> > On Wed, Jun 24, 2015 at 11:05:16AM +0530, Sudip Mukherjee wrote:
> > > On Tue, Jun 23, 2015 at 03:10:56PM +0200, Luis de Bethencourt wrote:
> >
> > I based th
Probably once you start writing a patch you will figure it out. :)
keymap_store() is a crap function. We have the cp1 pointer that points
to the end of two back to back 3 char arrays. The name cp1 is because
it is the second copy of the cp buffer which is a copy of the buf
buffer. Since it is
On Wed, Jun 24, 2015 at 04:32:38PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Mon, Jun 22, 2015 at 06:15:06PM +0300, Dan Carpenter wrote:
> > On Thu, Jun 18, 2015 at 12:56:54PM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > From: Hari Prasath Gujulan Elango
> > >
> > > This
61 matches
Mail list logo
