On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote:
> Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com>
> ---
>  drivers/staging/vme/devices/vme_user.c | 47 
> ++++++++--------------------------
>  1 file changed, 11 insertions(+), 36 deletions(-)
> 
<snip>
> @@ -178,38 +167,24 @@ static ssize_t buffer_to_user(unsigned int minor, char 
> __user *buf,
>                             size_t count, loff_t *ppos)
>  {
>       void *image_ptr;
> -     ssize_t retval;
>  
>       image_ptr = image[minor].kern_buf + *ppos;
> +     if (__copy_to_user(buf, image_ptr, (unsigned long)count))
> +             return -EFAULT;
>  
> -     retval = __copy_to_user(buf, image_ptr, (unsigned long)count);
> -     if (retval != 0) {
> -             retval = (count - retval);
> -             pr_warn("Partial copy to userspace\n");
> -     } else
> -             retval = count;
> -
> -     /* Return number of bytes successfully read */
> -     return retval;
> +     return count;
will it not affect the userspace code?
previously number of bytes successfully read was returned, now incase of
partial read -EFAULT is being returned.

regards
sudip
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to