On Sat, May 30, 2015 at 12:45:22AM +0300, Vladimirs Ambrosovs wrote:
> The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and
> iio_dummy_evgen_release_irq() were changed to return void instead of int,
> because these functions always return 0.
>
> Signed-off-by: Vladimirs Amb
On Fri, May 29, 2015 at 10:52:25PM +0200, Arnd Bergmann wrote:
> The various semaphore functions all directly translate into
> sema_init(), down() and up(), so we can just remove the API.
>
> This is a mostly automated conversion using simple sed scripts,
> plus some manual changes to account for
On Fri, May 29, 2015 at 10:52:16PM +0200, Arnd Bergmann wrote:
> The abstraction for time in this driver is completely
> unused, so remove it.
>
> Signed-off-by: Arnd Bergmann
> ---
> drivers/staging/wilc1000/wilc_osconfig.h | 1 -
> drivers/staging/wilc1000/wilc_oswrapper.h | 5 -
> driver
On Fri, May 29, 2015 at 08:16:21AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> Remove the unwanted else block
something is wrong. This patch is also not applying.
I am on staging-testing.
regards
sudip
___
devel mailing list
de...@linuxdriverproj
ies which handles all
> corner-cases correctly, was used.
>
> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> CONFIG_PARPORT=m, CONFIG_PANEL=m
>
> Signed-off-by: Nicholas Mc Guire
Acked-by: Willy Tarreau
> ---
> Patch is against 4.1-rc5 (localversion-nex
On Fri, May 29, 2015 at 07:17:37AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> This patch deletes all references to 'flipbuf'.Memory is allocated and
> freed but never used anywhere in the driver.Also deleted an ununsed
> Macro defined in the header file.
after your patch MYFLIPLEN becomes u
On Thu, May 28, 2015 at 12:35:22PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> Check the return value of kcalloc first and then use the pointer.
>
> Signed-off-by: Gujulan Elango Hari Prasath
> ---
> -
> - if (!brd->msgbuf) {
> + if (!brd->msgbuf_head) {
> kfree(brd)
On Wed, May 27, 2015 at 05:05:26PM +0800, Simon Guo wrote:
> Delare request_cache variable as static.
Is it Declare?
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-dev
Looks nice. :)
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Fixed a few spelling errors in commented code, helpline text, and a TODO list
Files changed:
drivers/staging/dgnc/TODO
drivers/staging/dgnc/dgnc_driver.h
drivers/staging/dgnc/dgnc_tty.c
drivers/staging/emxx_udc/emxx_udc.c
drivers/staging/fbtft/Kconfig
Signed
From: Oleg Drokin
lustre_dlm_flags.h was autogenerated with a wrong script that
mistakenly stated it is GPLv3 when in fact it should be GPLv2.
Also since we are no longer autogenerating this header, drop
all such mentionings.
Reported by: George G. Davis
Signed-off-by: Oleg Drokin
Intel-bug-
Fix the module_param "instances" type to uint, since the variable type
holding the value is unsigned.
Signed-off-by: Vladimirs Ambrosovs
---
drivers/staging/iio/iio_simple_dummy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/iio_simple_dummy.c
b/driver
The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and
iio_dummy_evgen_release_irq() were changed to return void instead of int,
because these functions always return 0.
Signed-off-by: Vladimirs Ambrosovs
---
drivers/staging/iio/iio_dummy_evgen.c | 4 +---
drivers/s
v2 Fixed the code as per the comments from version 1:
* Removed unnecessary comments
* Fixed the label name to address label location
* Changed the type of functions, which always return 0 to void
Vladimirs Ambrosovs (3):
staging: iio_simple_dummy: fix init function
sta
This patch fixes the init function for the iio_simple_dummy driver.
The main issues were absence of kfree for the allocated array, and no
devices being removed in case the probe function fails, running in a loop.
Signed-off-by: Vladimirs Ambrosovs
---
drivers/staging/iio/iio_simple_dummy.c | 9 +
On Thu, May 28, 2015 at 03:43:42PM +0300, Dan Carpenter wrote:
> On Thu, May 28, 2015 at 12:08:56PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > remove redundant code in this function.remove return value check for
> > function that always return success
> >
> > Signed-off-by: Gujulan Ela
For code that is integrated into mainline Linux, checks for
the kernel version make no sense, because we know which version
we are compiling against.
This removes all checks and the associated dead code.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 88 +-
All the remaining features from the OS abstraction layer
are not used at all in the driver, so we can just remove
the remaining references to them.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wilc_errorsupport.h | 17
drivers/staging/wilc1000/wilc_event.h| 123 ---
The driver contains its own abstraction for memory allocation,
most of it unused. This removes the unused parts, but the
rest should also be removed later.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wilc_memory.c| 5 --
drivers/staging/wilc1000/wilc_memory.h| 93 -
The various semaphore functions all directly translate into
sema_init(), down() and up(), so we can just remove the API.
This is a mostly automated conversion using simple sed scripts,
plus some manual changes to account for down() returning no
error.
As a positive side-effect, down() no longer h
Hi Greg,
This turned out to be more work than the first version, but I
think I've split it up enough sensibly to allow review, and
I've added a few more patches at the end.
Arnd
Arnd Bergmann (16):
staging: wilc1000: remove linux version checks
staging: wilc1000: remove platform vers
The wilc_thread code is a very thin wrapper around kthread,
so just remove it and use kthread directly.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 2 +-
drivers/staging/wilc1000/host_interface.c | 16 ++--
drivers/staging/wilc1000/wilc_osconfig.h | 3 -
dr
The driver contains an abstraction for message queues, with
optional unused features, while the driver requires the main
feature.
This makes the msgqueue code unconditional as it's required
but removes the unused parts.
A later cleanup should remove the entire msgqueue code
and replace it with so
The driver provides wrappers for a lot of string operations.
Some of them are unused, while others should be replaced
with normal kernel functions.
This replaces the unused ones for now, and leaves the other
ones for a later cleanup.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wil
The driver has a simple wrapper around timer_list, and an
optional but unused feature to make the timer periodic.
This removes support for the periodic timer and simplifies
the code around timers.
A follow-up should replace the remaining wrapper with
open-coded timers.
Signed-off-by: Arnd Bergma
The driver has a simple wrapper around msleep, as well as
a more advanced sleep function that is unused. This removes
the unused code and the options to turn the feature on or
off.
A follow-up should rework the code to use msleep directly.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc10
The EXPORT_SYMTAB symbol has not been used in Linux for a very
long time, the driver does not need to set it.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/Makefile
b/drivers/stagin
The driver has its own API for semaphores. This should
be replaced with mutexes and completions, but for the moment
we can start by removing the obviously unused parts.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wilc_osconfig.h | 1 -
drivers/staging/wilc1000/wilc_oswrapper.h |
The abstraction for time in this driver is completely
unused, so remove it.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wilc_osconfig.h | 1 -
drivers/staging/wilc1000/wilc_oswrapper.h | 5 -
drivers/staging/wilc1000/wilc_platform.h | 12 --
drivers/staging/wilc1000/wilc_tim
The driver version is meaningless, and in particular does not
have to be passed from the Makefile. This removes the macros,
but leaves the behavior of printing the 10.2 version untouched
for the moment.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 6 --
drivers/st
This avoids the remaining warnings that one gets on a normal
build: unused variables, unused labels, and invalid printk
format strings.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 8 ++--
drivers/staging/wilc1000/linux_wlan_spi.c | 3 ---
drivers/staging/wilc
The wilc1000 driver produces a lot of warnings about invalid
casts between const and non-const variables. This reworks
the code to avoid all those warnings, by marking variables
and function arguments const.
A lot of the types use WILC_Uint8, I change them to const u8
for style reasons, as I'm tou
For code that is integrated into mainline Linux, checks for
the OS platform make no sense, because we know that we
are on Linux.
This removes all checks and the associated dead code.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 3 +--
drivers/staging/wilc1000/
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Friday, May 29, 2015 1:29 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com; jbottom...@para
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Friday, May 29, 2015 1:29 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com; jbottom...@para
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Friday, May 29, 2015 1:29 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com; jbottom...@para
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Friday, May 29, 2015 1:29 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com; jbottom...@para
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Friday, May 29, 2015 1:29 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com; jbottom...@para
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Friday, May 29, 2015 1:29 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com; jbottom...@para
On Thu, May 28, 2015 at 11:16:27PM +0200, Xavier Roche wrote:
> Hi Greg & mailing-list members,
>
> On Thu, 28 May 2015, Greg KH wrote:
> >In the future, always use scripts/get_maintainer.pl to determine who to
> >send patches to please.
>
> Sorry, I did use the get_maintainer.pl script, but I di
On Thu, May 28, 2015 at 09:59:34AM +0300, Dan Carpenter wrote:
> On Thu, May 28, 2015 at 01:12:40AM +0300, Vladimirs Ambrosovs wrote:
> > On Wed, May 27, 2015 at 11:25:07AM +0300, Dan Carpenter wrote:
> > > On Wed, May 27, 2015 at 01:19:58AM +0300, Vladimirs Ambrosovs wrote:
> > > > Check for zero
On Fri, 29 May 2015, Dan Carpenter wrote:
> On Fri, May 29, 2015 at 07:21:26PM +0200, Nicholas Mc Guire wrote:
> > On Fri, 29 May 2015, Dan Carpenter wrote:
> >
> > > On Fri, May 29, 2015 at 06:41:28PM +0200, Nicholas Mc Guire wrote:
> > > > The schedule_timeout*() helpers take the timeout as sig
Cleanup version handling as well as base feature detection on storage
version as opposed to host version.
keith.ma...@microsoft.com (6):
scsi: storvsc: Rather than look for sets of specific protocol
versions, make decisions based on ranges.
scsi: storvsc: Use a single value to track protoc
From: keith.ma...@microsoft.com
Use correct defaults for values determined by protocol negotiation,
instead of resetting them with every scsi controller.
Tested-by: Alex Ng
Signed-off-by: Keith Mange
Signed-off-by: K. Y. Srinivasan
---
drivers/scsi/storvsc_drv.c | 33 +++---
From: keith.ma...@microsoft.com
Rather than look for sets of specific protocol versions,
make decisions based on ranges. This will be safer and require fewer changes
going forward as we add more storage protocol versions.
Tested-by: Alex Ng
Signed-off-by: Keith Mange
Signed-off-by: K. Y. Srini
From: keith.ma...@microsoft.com
Use storage protocol version instead of vmbus protocol
version when determining storage capabilities.
Tested-by: Alex Ng
Signed-off-by: Keith Mange
Signed-off-by: K. Y. Srinivasan
---
drivers/scsi/storvsc_drv.c |8
1 files changed, 4 insertions(+)
From: keith.ma...@microsoft.com
Currently we are making decisions based on vmbus protocol versions
that have been negotiated; use storage potocol versions instead.
Tested-by: Alex Ng
Signed-off-by: Keith Mange
Signed-off-by: K. Y. Srinivasan
---
drivers/scsi/storvsc_drv.c | 109
From: keith.ma...@microsoft.com
Allow WRITE_SAME for Windows10 and above hosts.
Tested-by: Alex Ng
Signed-off-by: Keith Mange
Signed-off-by: K. Y. Srinivasan
---
drivers/scsi/storvsc_drv.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.
From: keith.ma...@microsoft.com
Use a single value to track protocol versions to simplify
comparisons and to be consistent with vmbus version tracking.
Tested-by: Alex Ng
Signed-off-by: Keith Mange
Signed-off-by: K. Y. Srinivasan
---
drivers/scsi/storvsc_drv.c | 35 +---
On Fri, May 29, 2015 at 07:21:26PM +0200, Nicholas Mc Guire wrote:
> On Fri, 29 May 2015, Dan Carpenter wrote:
>
> > On Fri, May 29, 2015 at 06:41:28PM +0200, Nicholas Mc Guire wrote:
> > > The schedule_timeout*() helpers take the timeout as signed long, as
> > > ch_close_delay in struct channel_t
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Friday, May 29, 2015 10:00 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...@redhat.com;
On Fri, 29 May 2015, Dan Carpenter wrote:
> On Fri, May 29, 2015 at 06:41:28PM +0200, Nicholas Mc Guire wrote:
> > The schedule_timeout*() helpers take the timeout as signed long, as
> > ch_close_delay in struct channel_t was not used for other purposes its
> > type was switched to signed long and
_PARPORT=m, CONFIG_PANEL=m
Signed-off-by: Nicholas Mc Guire
---
Patch is against 4.1-rc5 (localversion-next is -next-20150529)
not really clear what the intent of (ms * HZ + 999) / 1000 was - this
is HZ dependent and does not really make sense - the comment states
"sleeps that many mill
On Fri, May 29, 2015 at 06:41:28PM +0200, Nicholas Mc Guire wrote:
> The schedule_timeout*() helpers take the timeout as signed long, as
> ch_close_delay in struct channel_t was not used for other purposes its
> type was switched to signed long and the declarations fixed up.
Uh, we never pass it t
On Fri, May 29, 2015 at 11:09:02AM -0700, K. Y. Srinivasan wrote:
> Map target_cpu to target_vcpu using the mapping table.
>
It's really hard to tell from this changelog what the user visible
effects of this patch are.
regards,
dan carpenter
___
devel
From: Vitaly Kuznetsov
Memory notifiers are being executed in a sequential order and when one of
them fails returning something different from NOTIFY_OK the remainder of
the notification chain is not being executed. When a memory block is being
onlined in online_pages() we do memory_notify(MEM_GO
against 4.1-rc5 (localversion-next is -next-20150529)
Signed-off-by: Nicholas Mc Guire
---
Note that there is a "over 80 char" warning here that was not fixed as
there are quite a few in dgnc_driver.h.
drivers/staging/dgnc/dgnc_driver.h |2 +-
drivers/staging/dgnc/dgnc_utils
correctly.
Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
CONFIG_DGNC=m
Patch is against 4.1-rc5 (localversion-next is -next-20150529)
Signed-off-by: Nicholas Mc Guire
---
drivers/staging/dgnc/dgnc_utils.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
Map target_cpu to target_vcpu using the mapping table.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index 1f1417d..c3eba37 100644
--- a/drivers/hv/chan
Channels/sub-channels can be affinitized to VCPUs in the guest. Implement
this affinity in a way that is NUMA aware. The current protocol distributed
the primary channels uniformly across all available CPUs. The new protocol
is NUMA aware: primary channels are distributed across the available NUMA
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel.c | 14 --
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 7a1c2db..603ce97 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -73,6 +73,7 @@ int vm
s a 1:1 conversion of the current calls to an available helper
>> only - so only an API consolidation to improve readability.
>>
>> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
>> CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m
>>
&
Implement CPU affinity for channels based on NUMA topology. Also, allocate all
channel specific memory from the appropriate NUMA node.
K. Y. Srinivasan (3):
Drivers: hv: vmbus: Use the vp_index map even for channels bound to
CPU 0
Drivers: hv: vmbus: Implement NUMA aware CPU affinity for c
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Thursday, May 21, 2015 9:22 AM
> To: de...@linuxdriverproject.org
> Cc: KY Srinivasan; Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui;
> Ingo Molnar; Paul E. McKenney; Rafael J. Wysocki; Peter Zijl
consolidation to improve readability.
Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m
Patch is against 4.1-rc5 (localversion-next is -next-20150529)
Minor niggle: you don't really need to say what version the
compile tested with x86_64_defconfig + CONFIG_STAGING=y,
CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m
Patch is against 4.1-rc5 (localversion-next is -next-20150529)
Signed-off-by: Nicholas Mc Guire
---
drivers/staging/comedi/drivers/me_daq.c |3 +--
1 file changed, 1
Modified the if-else statements to remove unnecessary comparisons in rxtx.c.
This change was detected with the help of coccinelle tool
Signed-off-by: Harisangam Sharvari
---
drivers/staging/vt6655/rxtx.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/stagi
(localversion-next is -next-20150529)
Signed-off-by: Nicholas Mc Guire
---
As the actually intended timeout is not documented and msecs_to_jiffies
timeouts can be a factor 10 different from the current effective timeout
this needs to be checked by someone who knows the details of this driver
in any case
On Fri, May 29, 2015 at 05:20:52PM +0200, Jason A. Donenfeld wrote:
> On Fri, May 29, 2015 at 2:41 PM, Dan Carpenter
> wrote:
> > Acked-by: Dan Carpenter
>
> Acked for the rest of the set too?
Yes. Thanks.
regards,
dan carpenter
___
devel mailing
Hi Takashi,
On Fri, 29 May 2015 14:43:14 +0200 Takashi Iwai wrote:
>
> For the sound bits,
> Acked-by: Takashi Iwai
Thanks, noted.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpcAWfsHc9aM.pgp
Description: OpenPGP digital signature
On 29/05/15 15:29, Sharma, Abhishek (A.) wrote:
Replace unnecessary conditional checks for variable 'ret' and replace
by single return statement.
Signed-off-by: Abhishek Sharma
diff --git a/drivers/staging/comedi/drivers/adv_pci1724.c
b/drivers/staging/comedi/drivers/adv_pci1724.c
index f7a7d
On Fri, May 29, 2015 at 2:36 PM, Frans Klaver wrote:
>
> I would say that it is because part of the expression has been placed
> inside parentheses:
>
> a - b + 1 == a - (b - 1)
>
> Guess it makes the decision logic slightly more readable.
Yes, exactly this. It's so that the bounding check co
On Fri, May 29, 2015 at 2:41 PM, Dan Carpenter wrote:
> Acked-by: Dan Carpenter
Acked for the rest of the set too?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
We don't catch this allocation failure because there is a typo and we
check the wrong variable.
Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport
abstraction')
Signed-off-by: Dan Carpenter
diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c
index e
Hello Vitaly Kuznetsov,
The patch 11bc3a5fa91f: "Drivers: hv: kvp: convert to
hv_utils_transport" from Apr 11, 2015, leads to the following static
checker warning:
drivers/hv/hv_kvp.c:356 kvp_send_key()
error: potential null dereference 'message'. (kzalloc returns null)
drivers/
Replace unnecessary conditional checks for variable 'ret' and replace
by single return statement.
Signed-off-by: Abhishek Sharma
diff --git a/drivers/staging/comedi/drivers/adv_pci1724.c
b/drivers/staging/comedi/drivers/adv_pci1724.c
index f7a7dab..9677111 100644
--- a/drivers/staging/comedi/dr
On 29/05/15 14:01, Sharma, Abhishek (A.) wrote:
---
drivers/staging/comedi/drivers/adv_pci1724.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1724.c
b/drivers/staging/comedi/drivers/adv_pci1724.c
index f7a7dab..9677111 100644
-
---
drivers/staging/comedi/drivers/adv_pci1724.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1724.c
b/drivers/staging/comedi/drivers/adv_pci1724.c
index f7a7dab..9677111 100644
--- a/drivers/staging/comedi/drivers/adv_pci1724.c
++
At Fri, 29 May 2015 19:18:47 +1000,
Stephen Rothwell wrote:
>
> Nothing in asm/io.h uses anything from vmalloc.h, so remove the include
> and fix up the build problems in an allmodconfig (64 bit and 32 bit)
> build.
>
> This may be the place where x86 builds get vmalloc.h implicitly included
> an
Oh. Duh. Of course.
Acked-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Ingo,
On Fri, 29 May 2015 11:21:05 +0200 Ingo Molnar wrote:
>
> Good idea.
>
> Acked-by: Ingo Molnar
Thanks.
> Please also test x86 allnoconfig and defconfig 32/64, that tends to unearth
> the
> remaining places. People doing randconfig testing will find the rest.
Good idea. the allnoc
Hi,
On Fri, May 29, 2015 at 2:00 PM, Dan Carpenter wrote:
> On Fri, May 29, 2015 at 01:06:58PM +0200, Jason A. Donenfeld wrote:
>> --- a/drivers/staging/ozwpan/ozusbsvc1.c
>> +++ b/drivers/staging/ozwpan/ozusbsvc1.c
>> @@ -390,10 +390,15 @@ void oz_usb_rx(struct oz_pd *pd, struct oz_elt *elt)
>>
On Fri, May 29, 2015 at 01:06:58PM +0200, Jason A. Donenfeld wrote:
> --- a/drivers/staging/ozwpan/ozusbsvc1.c
> +++ b/drivers/staging/ozwpan/ozusbsvc1.c
> @@ -390,10 +390,15 @@ void oz_usb_rx(struct oz_pd *pd, struct oz_elt *elt)
> case OZ_GET_DESC_RSP: {
> struct oz_ge
On Thu, May 28, 2015 at 04:08:31PM -0700, Riley Andrews wrote:
> -done:
> +static int binder_thread_read(struct binder_proc *proc,
> + struct binder_thread *thread,
> + binder_uintptr_t binder_buffer, size_t size,
> + bin
On Fri, May 29, 2015 at 01:52:28PM +0300, Dan Carpenter wrote:
> On Fri, May 29, 2015 at 10:06:48AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote:
> > > On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath
> >
A network supplied parameter was not checked before division, leading to
a divide-by-zero. Since this happens in the softirq path, it leads to a
crash. A PoC follows below, which requires the ozprotocol.h file from
this module.
=-=-=-=-=-=
#include
#include
#include
#include
#include
#
Using signed integers, the subtraction between required_size and offset
could wind up being negative, resulting in a memcpy into a heap buffer
with a negative length, resulting in huge amounts of network-supplied
data being copied into the heap, which could potentially lead to remote
code execution
The subtraction here was using a signed integer and did not have any
bounds checking at all. This commit adds proper bounds checking, made
easy by use of an unsigned integer. This way, a single packet won't be
able to remotely trigger a massive loop, locking up the system for a
considerable amount
This is v3 for this patch series, enhancing readability.
The ozwpan driver accepts network packets, parses them, and converts
them into various USB functionality. There are numerous security
vulnerabilities in the handling of these packets. Two of them result in
a memcpy(kernel_buffer, network_pac
Since elt->length is a u8, we can make this variable a u8. Then we can
do proper bounds checking more easily. Without this, a potentially
negative value is passed to the memcpy inside oz_hcd_get_desc_cnf,
resulting in a remotely exploitable heap overflow with network
supplied data.
This could resu
On Fri, May 29, 2015 at 10:06:48AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote:
> > On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > check return value of kzalloc and return error if it
On Thu, May 28, 2015 at 04:08:23PM -0700, Riley Andrews wrote:
> +static int binder_transaction_buffer_acquire(
> + struct binder_transaction *t, struct binder_transaction_data *tr,
> + struct binder_thread *thread, struct binder_transaction *in_reply_to)
> +{
> + struct binder_proc *pr
On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote:
> On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > check return value of kzalloc and return error if it fails.
> >
>
> There is a problem with your patch. See if you can spot it. Also can
> y
This patch is ok.
Reviewed-by: Dan Carpenter
On Thu, May 28, 2015 at 04:08:21PM -0700, Riley Andrews wrote:
> +static void binder_call_inc_dec_ref(struct binder_thread *thread,
> + uint32_t target, uint32_t cmd)
> +{
> + struct binder_proc *proc = thread->proc
Nothing in asm/io.h uses anything from vmalloc.h, so remove the include
and fix up the build problems in an allmodconfig (64 bit and 32 bit)
build.
This may be the place where x86 builds get vmalloc.h implicitly included
and that tends to hide places where vmalloc() et al are added to files
but th
On Thu, May 28, 2015 at 04:08:19PM -0700, Riley Andrews wrote:
> From: Lisa Du
>
> There's one point was missed in the patch commit da49889deb34 ("staging:
> binder: Support concurrent 32 bit and 64 bit processes."). When configure
> BINDER_IPC_32BIT, the size of binder_uintptr_t was 32bits, but
* Stephen Rothwell wrote:
> Nothing in asm/io.h uses anything from vmalloc.h, so remove the include
> and fix up the build problems in an allmodconfig (64 bit and 32 bit)
> build.
>
> This may be the place where x86 builds get vmalloc.h implicitly included
> and that tends to hide places where
On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> check return value of kzalloc and return error if it fails.
>
There is a problem with your patch. See if you can spot it. Also can
you add to the changelog what are the user visible effects of not
checking for
Originally when I was reviewing Hari's patch I had no idea you wrote
this code so I was not as polite as I could have been. Sorry.
On Thu, May 28, 2015 at 12:03:26PM -0700, insop.s...@gainspeed.com wrote:
> > poorly thought out error messages.
> which one are you exactly refering?
>
err
Remove the unwanted else block
Signed-off-by: Gujulan Elango Hari Prasath
---
drivers/staging/dgnc/dgnc_tty.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 2397c66..ca07b7f 100644
--- a/drivers/staging/dgnc/dgnc_tty
1 - 100 of 105 matches
Mail list logo
