Originally when I was reviewing Hari's patch I had no idea you wrote
this code so I was not as polite as I could have been.  Sorry.

On Thu, May 28, 2015 at 12:03:26PM -0700, insop.s...@gainspeed.com wrote:
> > poorly thought out error messages.
> which one are you exactly refering?
> 

        err = gs_load_image(fimage, file);
        if (err) {
                pr_err("gs_load_image error\n");
                goto err_out1;
        }

Not a lot of love went into crafting the error message.  Plus it
duplicates a better error message in gs_load_image() and an even better
set of error messages in request_firmware().

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to