On Wed, Mar 25, 2015 at 12:25:59AM +0100, Willy Tarreau wrote:
> On Tue, Mar 24, 2015 at 02:56:33PM +0530, Sudip Mukherjee wrote:
> > with reference to the previous patch of the series, fixed the
> > lcd type in module parameters.
>
> Sudip, it's better to avoid fragmenting patches like you did, b
On Tue, 2015-03-24 at 20:28 -0400, Jes Sorensen wrote:
> Joe Perches writes:
> > Create an rt_trace function using %pV to reduce overall code size.
> > Update the macro uses to remove unnecessary and now harmful parentheses.
[]
> This could be further improved by fixing up all the places where the
Joe Perches writes:
> Create an rt_trace function using %pV to reduce overall code size.
> Update the macro uses to remove unnecessary and now harmful parentheses.
>
> Miscellanea around these changes:
>
> o Coalesce formats
> o Realign arguments
> o Remove commented-out RT_TRACE uses
> o Spelling
On Tue, Mar 24, 2015 at 04:29:32PM +0530, Sudip Mukherjee wrote:
> the lcd type as defined in the Kconfig is not matching in the code.
> as a result the rs, rw and en pins were getting interchanged.
> Kconfig defines the value of PANEL_LCD to be 1 if we select custom
> configuration but in the code
On Tue, Mar 24, 2015 at 02:56:33PM +0530, Sudip Mukherjee wrote:
> with reference to the previous patch of the series, fixed the
> lcd type in module parameters.
Sudip, it's better to avoid fragmenting patches like you did, because
it will result in a kernel state where there is an inconsistency b
On Fri, Mar 20, 2015 at 04:19:36PM +0100, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Fri, Mar 20, 2015 at 1:54 PM, Greg Kroah-Hartman
> wrote:
> > On Tue, Mar 10, 2015 at 10:34:43PM +0100, Geert Uytterhoeven wrote:
> >> Gcc < 4.3 doesn't understand binary constants (0b*):
> >>
> >> drivers/stagi
Hi,
On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote:
> On March 24, 2015 3:08:09 AM EDT, Dan Carpenter
> wrote:
> >On Mon, Mar 23, 2015 at 05:08:52PM -0400, Nicholas Krause wrote:
> >> On March 23, 2015 9:06:26 AM EDT, Dan Carpenter
> > wrote:
> >> >On Mon, Mar 23, 2015 at 08:53:
On Tue, 2015-03-24 at 23:14 +0300, Dan Carpenter wrote:
> On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote:
> > The following files had coding style issues that I tried to address.
> > It was mostly about lines spanning more than 80 characters.
[]
> > diff --git a/drivers/staging/slic
On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote:
> The following files had coding style issues that I tried to address.
> It was mostly about lines spanning more than 80 characters.
>
> Signed-off-by: Niranjan Dighe
>
> diff --git a/drivers/staging/slicoss/slicoss.c
> b/drivers/s
Removed unused block of code guarded by #ifdef SLIC_TRACE_DUMP_ENABLED
And removed redundant static char *slic_banner and replaced actual string in
place of format string.
Signed-off-by: Niranjan Dighe
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss/slicoss.c
index 3104
The function 'ieee80211_check_auth_response' is used only in this
file, so make it static. This patch fixes the following sparse
warning.
'ieee80211_check_auth_response' was not declared. Should it be static?
Signed-off-by: Cihangir Akturk
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softma
On Wed, 2015-03-25 at 00:39 +0530, Niranjan Dighe wrote:
> The following files had coding style issues that I tried to address.
> It was mostly about lines spanning more than 80 characters.
[]
> diff --git a/drivers/staging/slicoss/slicoss.c
> b/drivers/staging/slicoss/slicoss.c
[]
> @@ -98,7 +98,
This was generated by 'make coccicheck' using scripts at
scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Niranjan Dighe
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
index 86d955f..be9e34a 100644
--- a/drivers/staging/rtl8188eu/co
The following files had coding style issues that I tried to address.
It was mostly about lines spanning more than 80 characters.
Signed-off-by: Niranjan Dighe
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss/slicoss.c
index 3104cb0..2161bdb 100644
--- a/drivers/staging/s
Joe Perches writes:
> Use the standard vsprintf kernel extension to format
> mac addresses.
>
> This reduces object code size a bit.
>
> Miscellanea:
>
> o Coalesce formats
> o Realign arguments
> o Remove the now unused MAC_FMT and MAC_ARG #defines
>
> Signed-off-by: Joe Perches
> ---
> drivers
Use the standard vsprintf kernel extension to format
mac addresses.
This reduces object code size a bit.
Miscellanea:
o Coalesce formats
o Realign arguments
o Remove the now unused MAC_FMT and MAC_ARG #defines
Signed-off-by: Joe Perches
---
drivers/staging/rtl8723au/core/rtw_ap.c |
Hi,
Please refer :
http://lxr.linux.no/#linux+v3.19.1/Documentation/CodingStyle
for reference on kernel coding conventions. These are also the
basis for various checkpatch.pl errors.
You can also refer to :
http://kernelnewbies.org/CheckpatchTips
for reference on things to look out for while re
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Tuesday, March 24, 2015 1:56 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; jbottom...@parallels.com;
> h...@infradead.org; linux-s...@vger.kern
Great. :)
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
the global variable majordev is no longer required, as it is not being
used anywhere.
Signed-off-by: Sudip Mukherjee
---
v5: reordered the patch series
v4: messed up the subject in v3
v3: broke the previous patch in series
drivers/staging/unisys/visorchipset/file.c | 3 ---
1 file changed, 3 d
the dev_t was being stored in visorchipset_platform_device.dev.devt
while initializing the module. so pass that value as an argument to
cleanup() so that it can use this local variable instead of the global
variable.
Signed-off-by: Sudip Mukherjee
---
v5: reordered the patch series
v4: messed up
we are getting dev_t as an argument in the function, so use the local
variable instead of the global variable "majordev".
this global variable will be removed in one of the next patch of the
series.
Signed-off-by: Sudip Mukherjee
---
v5: reordered the patch series
v4: messed up the subject in v3
remove the variable "registered", which was used in the cleanup() to
detect if the driver has successfully initialized. the cleanup()
is called from module_exit, so its obvious that the module has
successfully initialized. if the initialization had failed, then
we will never be in the cleanup().
S
the comparison is always true as the dev_t has been initialized in the
init function and we are sending that initialized dev_t to the
cleanup().
Signed-off-by: Sudip Mukherjee
---
v5: reordered the patch series
v4: messed up the subject in v3
v3: broke the previous patch in series
drivers/stag
On Tue, 2015-03-24 at 11:00 +0300, Dan Carpenter wrote:
> None of these are correct. :(
True. Please run your proposed patches through checkpatch
before sending them.
I think it would be an improvement to rework the flow-hiding
TRACE_RET and TRACE_GOTO macros into two separate lines.
It would
On Tue, Mar 24, 2015 at 9:20 AM, Joe Perches wrote:
> On Tue, 2015-03-24 at 16:00 +0300, Dan Carpenter wrote:
>> On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote:
>> > Just one more question, is that patch going to be merged or should I
>> > resubmit
>> > it as a series of one patc
On Tue, 2015-03-24 at 16:00 +0300, Dan Carpenter wrote:
> On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote:
> > Just one more question, is that patch going to be merged or should I
> > resubmit
> > it as a series of one patch?
> Don't resubmit. Wait for Greg to mail you. It can t
On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote:
> Dan,
> Just one more question, is that patch going to be merged or should I resubmit
> it as a series of one patch?
Don't resubmit. Wait for Greg to mail you. It can take a several weeks
because he is busy.
regards,
dan carpe
I don't like how these are broken up at all. It's random grab bag of
renaming and deleting.
Do it like this, perhaps:
[patch 1] delete registered
Leave the if (MAJOR(majordev) >= 0) for now, because it just
confuses issues to mix it in. Delete all references to registered.
[patch 1] use local
On Tue, Mar 24, 2015 at 03:30:21PM +0300, Dan Carpenter wrote:
> On Tue, Mar 24, 2015 at 05:47:34PM +0530, Sudip Mukherjee wrote:
> > visorchipset_file_cleanup() is called from visorchipset_exit() which
> > is the module_exit function and this function is executing means
> > module_init succeeded,
On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote:
> An of_device_id should be const (checkpatch.pl warning).
>
> Signed-off-by: Mateusz Kulikowski
> Acked-by: Aaro Koskinen
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On Tue, Mar 24, 2015 at 05:47:34PM +0530, Sudip Mukherjee wrote:
> visorchipset_file_cleanup() is called from visorchipset_exit() which
> is the module_exit function and this function is executing means
> module_init succeeded, so registered will always be true at this time.
> and majordev has also
the dev_t is stored in visorchipset_platform_device.dev.devt, so we
can pass that value as an argument to visorchipset_file_cleanup()
instead of using the global variable in file.c
Signed-off-by: Sudip Mukherjee
---
v4: messed up the subject in v3
v3: broke the previous patch in this series
dr
after the first patch of this series the registered variable was
no longer required.
Signed-off-by: Sudip Mukherjee
---
v4: messed up the subject in v3
v3: broke the previous patch in this series
drivers/staging/unisys/visorchipset/file.c | 4
1 file changed, 4 deletions(-)
diff --git a/
dev_t was passed as an argument to visorchipset_file_init() which was
storing that value in a global variable so that it can be used while
cleanup. now we are no longer using the global variable in the cleanup
so we donot need to keep the global variable anymore.
Signed-off-by: Sudip Mukherjee
--
visorchipset_file_cleanup() is called from visorchipset_exit() which
is the module_exit function and this function is executing means
module_init succeeded, so registered will always be true at this time.
and majordev has also been initialized in the init function. hence
these comparisons will alwa
On Tue, Mar 24, 2015 at 05:36:09PM +0530, Sudip Mukherjee wrote:
please scrap this series, I messed up the subject line and missed
mentioning "staging: unisys"
i am sending a corrected copies as v4.
sorry for the noise.
regards
sudip
___
devel mailing
On March 24, 2015 3:08:09 AM EDT, Dan Carpenter
wrote:
>On Mon, Mar 23, 2015 at 05:08:52PM -0400, Nicholas Krause wrote:
>>
>>
>> On March 23, 2015 9:06:26 AM EDT, Dan Carpenter
> wrote:
>> >On Mon, Mar 23, 2015 at 08:53:19AM -0400, Nicholas Krause wrote:
>> >>
>> >>
>> >> On March 23, 2015
after the first patch of this series the registered variable was
no longer required.
Signed-off-by: Sudip Mukherjee
---
v3: broke the previous patch in this series
drivers/staging/unisys/visorchipset/file.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/unisys/visorchip
the dev_t is stored in visorchipset_platform_device.dev.devt, so we
can pass that value as an argument to visorchipset_file_cleanup()
instead of using the global variable in file.c
Signed-off-by: Sudip Mukherjee
---
v3: broke the previous patch in this series
drivers/staging/unisys/visorchipse
dev_t was passed as an argument to visorchipset_file_init() which was
storing that value in a global variable so that it can be used while
cleanup. now we are no longer using the global variable in the cleanup
so we donot need to keep the global variable anymore.
Signed-off-by: Sudip Mukherjee
--
visorchipset_file_cleanup() is called from visorchipset_exit() which
is the module_exit function and this function is executing means
module_init succeeded, so registered will always be true at this time.
and majordev has also been initialized in the init function. hence
these comparisons will alwa
the lcd type as defined in the Kconfig is not matching in the code.
as a result the rs, rw and en pins were getting interchanged.
Kconfig defines the value of PANEL_LCD to be 1 if we select custom
configuration but in the code LCD_TYPE_CUSTOM is defined as 5.
my hardware is LCD_TYPE_CUSTOM, but th
add MODULE_DEVICE_TABLE to support hot-plugging.
Signed-off-by: Sudip Mukherjee
---
resending as discussed with Greg K-H
drivers/staging/sm7xxfb/sm7xxfb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index abdb021.
On Tue, Mar 24, 2015 at 01:05:20PM +0300, Dan Carpenter wrote:
> On Tue, Mar 24, 2015 at 02:56:33PM +0530, Sudip Mukherjee wrote:
> > with reference to the previous patch of the series, fixed the
> > lcd type in module parameters.
> >
> > Cc: # 2.6.32+
> > Signed-off-by: Sudip Mukherjee
> > ---
On Tue, Mar 24, 2015 at 03:58:35PM +0530, Sudip Mukherjee wrote:
> On Tue, Mar 24, 2015 at 10:48:26AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Mar 24, 2015 at 10:20:08AM +0530, Sudip Mukherjee wrote:
> > > + "\t\t0x31B = 1280x1024-24\n"
> > > + "\t\tUsual example:\n"
> > > +
On Tue, Mar 24, 2015 at 10:48:26AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 24, 2015 at 10:20:08AM +0530, Sudip Mukherjee wrote:
> > +"\t\t0x31B = 1280x1024-24\n"
> > +"\t\tUsual example:\n"
> > +"\t\tinsmod ./sm7xxfb.ko mode_option=\"0x301\"\n");
> > +
>
On Tue, Mar 24, 2015 at 02:56:33PM +0530, Sudip Mukherjee wrote:
> with reference to the previous patch of the series, fixed the
> lcd type in module parameters.
>
> Cc: # 2.6.32+
> Signed-off-by: Sudip Mukherjee
> ---
This should have been folded into the other patch because now if we
just app
On Tue, Mar 24, 2015 at 10:20:08AM +0530, Sudip Mukherjee wrote:
> add module parameters so that we can configure X and Y resolutions
> and bpp when using this driver as a module.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/sm7xxfb/sm7xxfb.c | 18 ++
> 1 file chang
with reference to the previous patch of the series, fixed the
lcd type in module parameters.
Cc: # 2.6.32+
Signed-off-by: Sudip Mukherjee
---
v2: it was not in v1.
might not apply properly to old versions, some reordering was done
in commit <98e0e762e>
drivers/staging/panel/panel.c | 2 +-
1
the lcd type as defined in the Kconfig is not matching in the code.
as a result the rs, rw and en pins were getting interchanged.
Kconfig defines the value of PANEL_LCD to be 1 if we select custom
configuration but in the code LCD_TYPE_CUSTOM is defined as 5.
my hardware is LCD_TYPE_CUSTOM, but th
On Tue, Mar 24, 2015 at 02:13:16PM +0530, Sudip Mukherjee wrote:
> On Tue, Mar 24, 2015 at 11:32:47AM +0300, Dan Carpenter wrote:
>
> > > }
> > > - rc = cdev_add(&file_cdev, MKDEV(MAJOR(majordev), 0), 1);
> > > + rc = cdev_add(&file_cdev, MKDEV(major, 0), 1);
> >
> > This should just be:
> >
>
On Mon, Mar 23, K. Y. Srinivasan wrote:
> @@ -653,32 +640,39 @@ static unsigned int copy_from_bounce_buffer(struct
> scatterlist *orig_sgl,
> unsigned long bounce_addr = 0;
> unsigned long dest_addr = 0;
> unsigned long flags;
> + struct scatterlist *cur_dest_sgl;
> + st
On Tue, Mar 24, 2015 at 11:32:47AM +0300, Dan Carpenter wrote:
> > }
> > - rc = cdev_add(&file_cdev, MKDEV(MAJOR(majordev), 0), 1);
> > + rc = cdev_add(&file_cdev, MKDEV(major, 0), 1);
>
> This should just be:
>
> rc = cdev_add(&file_cdev, majordev, 1);
>
> So here is my suggestio
On Tue, Mar 24, 2015 at 01:22:16PM +0530, Sudip Mukherjee wrote:
> On Tue, Mar 24, 2015 at 08:04:11AM +0100, Willy Tarreau wrote:
> > Hi Sudip!
> >
> > On Tue, Mar 24, 2015 at 10:18:10AM +0530, Sudip Mukherjee wrote:
> > > the lcd type as defined in the Kconfig is not matching in the code.
> > > a
This patch also doesn't introduce bugs but it's sort of whacky and hard
to understand. Also the subject and description imply or say "fix" but
it's just a cleanup. The original code was also proper but just messy.
On Tue, Mar 17, 2015 at 08:31:24PM +0530, Sudip Mukherjee wrote:
> fixed the handl
On Mon, Mar 16, 2015 at 04:36:13PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 12, 2015 at 11:00:10PM +0530, Sudip Mukherjee wrote:
> > dev_t is defined to be of unsigned int type, no use initializing
> > it to -1.
> >
> > Signed-off-by: Sudip Mukherjee
> > ---
> > v2: it was not in v1
> >
>
None of these are correct. :(
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Mar 23, 2015 at 09:51:54PM -0700, Ragavendra Nagraj wrote:
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c
> b/drivers/staging/sm750fb/ddk750_chip.c
> index 02f9326..1fb00a4 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -17,7 +
On Tue, Mar 24, 2015 at 08:04:11AM +0100, Willy Tarreau wrote:
> Hi Sudip!
>
> On Tue, Mar 24, 2015 at 10:18:10AM +0530, Sudip Mukherjee wrote:
> > the lcd type as defined in the Kconfig is not matching in the code.
> > as a result the rs, rw and en pins were getting interchanged.
> > Kconfig defi
How are you? Are you interested in photo retouching or other photo editing
solutions?
We specialize in providing below photo retouching services:
Photoshop photos editing/retouching
Jewelry photos retouching
Ecommerce products photo editing
Photo cutting out/clipping path
Beauty/skin retouching,
On Mon, Mar 23, 2015 at 05:08:52PM -0400, Nicholas Krause wrote:
>
>
> On March 23, 2015 9:06:26 AM EDT, Dan Carpenter
> wrote:
> >On Mon, Mar 23, 2015 at 08:53:19AM -0400, Nicholas Krause wrote:
> >>
> >>
> >> On March 23, 2015 6:40:06 AM EDT, Dan Carpenter
> > wrote:
> >> >On Sun, Mar 22, 2
Hi Sudip!
On Tue, Mar 24, 2015 at 10:18:10AM +0530, Sudip Mukherjee wrote:
> the lcd type as defined in the Kconfig is not matching in the code.
> as a result the rs, rw and en pins were getting interchanged.
> Kconfig defines the value of PANEL_LCD to be 1 if we select custom
> configuration but
63 matches
Mail list logo
