On Tue, 2015-03-24 at 23:14 +0300, Dan Carpenter wrote:
> On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote:
> > The following files had coding style issues that I tried to address.
> > It was mostly about lines spanning more than 80 characters.
[]
> > diff --git a/drivers/staging/slicoss/slicoss.c
> > b/drivers/staging/slicoss/slicoss.c
[]
> > @@ -755,10 +756,10 @@ static bool slic_mac_filter(struct adapter *adapter,
> >
> > while (mcaddr) {
> > if (ether_addr_equal(mcaddr->address,
> > - ether_frame->ether_dhost))
> > {
> > - adapter->rcv_multicasts++;
> > - netdev->stats.multicast++;
> > - return true;
> > + ether_frame->ether_dhost)) {
> > + adapter->rcv_multicasts++;
> > + netdev->stats.multicast++;
> > + return true;
> > }
> > mcaddr = mcaddr->next;
> > }
>
> Check patch likes the new code but the original is better for human
> beings. Sorry.
The indentation isn't correct in the new code either.
That's actually a checkpatch defect because it's not
able to track deletion/insertion alignment well enough.
Niranjan, checkpatch is a brainless little tool.
Always use yours whenever using checkpatch.
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
