On March 24, 2015 3:08:09 AM EDT, Dan Carpenter <dan.carpen...@oracle.com>
wrote:
>On Mon, Mar 23, 2015 at 05:08:52PM -0400, Nicholas Krause wrote:
>>
>>
>> On March 23, 2015 9:06:26 AM EDT, Dan Carpenter
><dan.carpen...@oracle.com> wrote:
>> >On Mon, Mar 23, 2015 at 08:53:19AM -0400, Nicholas Krause wrote:
>> >>
>> >>
>> >> On March 23, 2015 6:40:06 AM EDT, Dan Carpenter
>> ><dan.carpen...@oracle.com> wrote:
>> >> >On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote:
>> >> >> Fixes the checkpath.pl error where the opening bracket has a
>> >unneeded
>> >> >space between
>> >> >> it and the function name for a if statement in the
>> >> >marco,VMX_WAIT_FOR_FIELD32.
>> >> >>
>> >> >> Signed-off-by: Nicholas Krause <xerofo...@gmail.com>
>> >> >> ---
>> >> >> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
>> >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >> >>
>> >> >> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
>> >> >b/drivers/staging/octeon-usb/octeon-hcd.c
>> >> >> index 1daeb31..0408a12 100644
>> >> >> --- a/drivers/staging/octeon-usb/octeon-hcd.c
>> >> >> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
>> >> >> @@ -412,7 +412,7 @@ struct octeon_hcd {
>> >> >> type c;
>> >> >> \
>> >> >> while (1) {
>> >> >> \
>> >> >> c.u32 = __cvmx_usb_read_csr32(usb, address);
>> >> >> \
>> >> >> - if (c.s.field op (value)) {
>> >> >> \
>> >> >> + if (c.s.field op(value)) {
>> >> >> \
>> >> >
>> >> >"op" is not a function here. This is macro and top is an
>operation
>> >> >like
>> >> >"+" or "*". So checkpatch.pl is wrong.
>> >> >
>> >> >regards,
>> >> >dan carpenter
>> >> Very well then, I wasn't sure if we did the same spacing style
>for
>> >marcos.
>> >
>> >We do but this is a very unusual case.
>> >
>> >regards,
>> >dan carpenter
>> Dan,
>> Sorry about that my mistake. In addition, have you looked at my
>second patch to see if that one is correct.
>
>Yes. That one is fine.
>
>regards,
>dan carpenter
Dan,
Just one more question, is that patch going to be merged or should I resubmit
it as a series of one patch?
Thanks,
Nick
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
