Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Hi, 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey : > Fixed the following: > > ERROR: do not use C99 // comments > ERROR: else should follow close brace '}' > ERROR: need consistent spacing around '*' (ctx:WxV) > ERROR: need consistent spacing around '|' (ctx:VxW) > ERROR: space prohibited after th

[PATCH] This is my first commit

From: kevin --- gtserio.c | 188 ++ 1 file changed, 188 insertions(+) create mode 100755 gtserio.c diff --git a/gtserio.c b/gtserio.c new file mode 100755 index 000..24f1e00 --- /dev/null +++ b/gtserio.c @@ -0,0 +1,188 @@ +/* + *

[PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Fixed the following: ERROR: do not use C99 // comments ERROR: else should follow close brace '}' ERROR: need consistent spacing around '*' (ctx:WxV) ERROR: need consistent spacing around '|' (ctx:VxW) ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that '--'

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Please ignore this. Chaitanya On Mon, May 26, 2014 at 10:32 PM, Chaitanya Hazarey wrote: > Fixed the following: > > WARNING: line over 80 characters > ERROR: do not use C99 // comments > ERROR: else should follow close brace '}' > ERROR: space required after that ',' (ctx:VxV) > ERROR: space req

[PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Fixed the following: WARNING: line over 80 characters ERROR: do not use C99 // comments ERROR: else should follow close brace '}' ERROR: space required after that ',' (ctx:VxV) ERROR: space required after that ';' (ctx:VxV) WARNING: missing space after struct definition ERROR: space required befor

[PATCH] This is my first commit

From: kevin --- gtserio.c | 188 ++ 1 file changed, 188 insertions(+) create mode 100755 gtserio.c diff --git a/gtserio.c b/gtserio.c new file mode 100755 index 000..24f1e00 --- /dev/null +++ b/gtserio.c @@ -0,0 +1,188 @@ +/* + *

Re: [PATCH 1/9] staging: ion: tidy up a bit

Hello Carpenter, On 05/26/2014 07:36 PM, Dan Carpenter wrote: On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote: @@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct ion_system_heap *heap, info->page = page; info->order = orders

Re: [PATCH 4/9] staging: ion: remove struct ion_page_pool_item

Hello, On 05/26/2014 07:04 PM, Heesub Shin wrote: Now that the order information is held on struct page itself, we do not need to use extra data structure. This commit reduces unnecessary slab usage for allocating small objects. Oops. I need to amend changelog above and resend this patchset.

Re: [PATCH 2/4] staging: dgap: implement proper error handling in dgap_firmware_load()

Hi, Dan 2014-05-26 19:50 GMT+09:00 Dan Carpenter : > On Mon, May 26, 2014 at 07:23:47PM +0900, Daeseok Youn wrote: >> When dgap_tty_init() and dgap_tty_register_ports() are failed, >> these are needed to free some memory properly. >> >> It can be handled by calling dgap_tty_uninit() and dgap_clean

Re: [PATCH] staging: vt6655: refactor iwctl_giwaplist() to avoid -Wframe-larger-than warn.

On Mon, May 26, 2014 at 09:53:56PM +0200, Konrad Zapalowicz wrote: > - DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO " SIOCGIWAPLIST \n"); > - // Only super-user can see AP list > + DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO " SIOCGIWAPLIST\n"); > > + /* Can we even enter the game? > + * 1. onl

[PATCH] staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP

dated. Use CONFIG_LIB80211_CRYPT_TKIP instead, as was clearly intended. Signed-off-by: Paul Bolle --- Compile tested only. Done on top of next-20140526. drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletion

[PATCH] staging: vt6655: refactor iwctl_giwaplist() to avoid -Wframe-larger-than warn.

This commit refactors the iwctl_giwaplist() function so that the sparse warning "the frame size of 1292 bytes is larger than 1024 bytes [-Wframe-larger-than=]" is no more. The root cause of this warning were two arrays allocated on the stack and this commit changes this - these arrays are now kmal

[PATCH] staging: tidspbridge: check for CONFIG_SND_OMAP_SOC_MCBSP

ven't been built for a while. Done on top of next-20140526. drivers/staging/tidspbridge/core/dsp-clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/tidspbridge/core/dsp-clock.c b/drivers/staging/tidspbridge/core/dsp-clock.c index 2f084e181d39..

[PATCH] staging: rtl8192u: remove checks for CONFIG_RTL8192_PM

ere are also no functions rtl8192_suspend and rtl8192_resume. Done on top of next-20140526. drivers/staging/rtl8192u/r8192U_core.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 97af38f9f281..2427

Re: [PATCH] staging: octeon-usb: prevent memory corruption

On Fri, May 23, 2014 at 11:17:18AM +0400, Sergey Popov wrote: > >> On Sat, Mar 22, 2014 at 01:13:52PM +0400, Sergey Popov wrote: > >>> scsi 0:0:0:0: Direct-Access SanDisk Cruzer Facet 1.26 PQ: 0 > >>> ANSI: 5 > >>> sd 0:0:0:0: [sda] 15633408 512-byte logical blocks: (8.00 GB/7.45 GiB) > >

[PATCH] staging: lirc: remove checks for CONFIG_LIRC_SERIAL_NSLU2

When support for homebrew serial port receivers was added in v2.6.36 its code contained checks for CONFIG_LIRC_SERIAL_NSLU2. The related Kconfig symbol didn't exist then. It still doesn't exist now. Remove these checks. Signed-off-by: Paul Bolle --- Untested. Done on top of next-20

[PATCH] staging: ctx1e1: remove checks for three macros

ing up and remove the unused V7() macro too. Signed-off-by: Paul Bolle --- Untested. Done op top of next-20140526. drivers/staging/cxt1e1/functions.c | 18 -- drivers/staging/cxt1e1/linux.c | 17 - drivers/staging/cxt1e1/musycc

[PATCH] staging: comedi: remove check for CONFIG_KMOD

ntless anyhow, but that's a different issue. Signed-off-by: Paul Bolle --- Untested. Done on top of next-20140526. drivers/staging/comedi/comedi_fops.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fo

[PATCH 1/3] staging: r8192ee: Fix kernel WARN splat associated with rate control

The 0day kernel testing robot got the kernel warning caused by trying to register a particular rate-control algorithm more than once. I believe that the core already protects against a particular driver doing the registration more than once, but an analysis of the code reveals that the identical na

[PATCH 2/3] staging: r8192ee: Fix build errors when PCI is not available

A build of this driver fails when PCI is not selected. It would also fail if MAC80211 is not selected. Kconfig is fixed to handle these conditions, and to select additional necessary components. Reported-by: Randy Dunlap Reported-by: Ben Hutchings Signed-off-by: Larry Finger --- drivers/stagin

[PATCH 3/3] staging: r8821ae: Fix potential problem with rate control registration

The zero day testing facility reported a problem with duplicate registration of the rate-control algorithm. Although not yet reported, this driver needs the same fix. Signed-off-by: Larry Finger --- drivers/staging/rtl8821ae/rc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/3] Some fixes for r8192ee and r8821ae

Initial testing of r8192ee builds has found two problems. The first of them is caused by using the same rate-control algorithm as is used by driver rtlwifi in the main wireless tree. As r8821ae also has the same (not yet reported) problem, a fix for it is also included. Signed-off-by: Larry Finge

Re: [PATCH v2 0/5] Move IPUv3 core out of staging, add CSI support

On Mon, May 26, 2014 at 4:19 PM, Philipp Zabel wrote: [...] > Cc: drm-de...@vger.kernel.org Sorry about this unfortunate combination of me misremembering dri-devel, noticing something is wrong, looking up and inserting the correct address, and then, after a context switch, failing to remove the

Re: [PATCH 10/27] Staging: bcm: Shortened lines in StoreCmControlResponseMessage()

On Mon, May 26, 2014 at 04:03:51PM +0200, Matthias Beyer wrote: > On 26-05-2014 16:08:42, Dan Carpenter wrote: > > On Fri, May 23, 2014 at 10:23:48PM +0200, Matthias Beyer wrote: > > > - pstAddIndication = kmalloc(sizeof(struct bcm_add_indication), > > > GFP_KERNEL); > > > + pstAddIndication = kma

Re: [PATCH 4/4] staging: r8192ee: Turn on build of the new driver

On 05/26/2014 01:06 PM, Ben Hutchings wrote: On Wed, 2014-05-21 at 16:25 -0500, Larry Finger wrote: [...] --- /dev/null +++ b/drivers/staging/rtl8192ee/Kconfig @@ -0,0 +1,8 @@ +config R8192EE + tristate "Realtek RTL8192EE Wireless Network Adapter" depends on MAC80211 && PCI (at least)

Re: [staging: r8192ee] WARNING: CPU: 0 PID: 1 at net/mac80211/rate.c:43 ieee80211_rate_control_register()

On 05/27/2014 01:07 AM, Larry Finger wrote: > On 05/26/2014 09:55 AM, Jet Chen wrote: > > Jet, > >> 0day kernel testing robot got the below dmesg and the first bad commit is >> >> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next >> commit 0629f3b8c33899140b48d5897259e

Re: [PATCH 4/4] staging: r8192ee: Turn on build of the new driver

On Wed, 2014-05-21 at 16:25 -0500, Larry Finger wrote: [...] > --- /dev/null > +++ b/drivers/staging/rtl8192ee/Kconfig > @@ -0,0 +1,8 @@ > +config R8192EE > + tristate "Realtek RTL8192EE Wireless Network Adapter" depends on MAC80211 && PCI (at least) > + select FW_LOADER > + ---help--

Re: linux-next: Tree for May 26 (staging/rtl8192ee)

On 05/26/2014 02:38 AM, Stephen Rothwell wrote: > Hi all, > > The powerpc allyesconfig is again broken more than usual. > > Changes since 20140523: > on x86_64: when CONFIG_PCI is not enabled: CC drivers/staging/rtl8192ee/pci.o ../drivers/staging/rtl8192ee/pci.c: In function 'rtl_pci_i

Re: [PATCH 1/1] staging: imx-drm: Remove unused variable

On Mon, May 26, 2014 at 02:28:44PM +0530, Sachin Kamat wrote: > 'ret' is not used in the function. Remove it. > > Signed-off-by: Sachin Kamat > --- > drivers/staging/imx-drm/imx-tve.c |1 - > 1 file changed, 1 deletion(-) This doesn't apply properly to my tree, can you refresh it against th

Re: [staging: r8192ee] WARNING: CPU: 0 PID: 1 at net/mac80211/rate.c:43 ieee80211_rate_control_register()

On 05/26/2014 09:55 AM, Jet Chen wrote: Jet, 0day kernel testing robot got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next commit 0629f3b8c33899140b48d5897259eab8ebae78ca Author: Larry Finger AuthorDate: Wed May 21

[PATCH] staging: silicom/bypasslib/bp_ioctl.h: Fix erroneous global variable definitions

Originally, this header was defining two new typedefs, CMND_TYPE and CMND_TYPE_SD, following this type of declaration: typedef enum { ... } CMND_TYPE; A previous commit (785086556a573f07747b3633732a9dbd7e45728f) tried to fix warnings that were pointed out by checkpatch.pl, concerning not

[PATCH 23/24] staging: rtl8188eu: Remove unused enum odm_h2c_cmd.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index e29ac79..dc6b1c2 100644 --- a/drivers/staging

[PATCH 24/24] staging: rtl8188eu: Remove empty file odm_interface.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h | 24 - drivers/staging/rtl8188eu/include/odm_precomp.h |1 - 2 files changed, 25 deletions(-) delete mode 100644 drivers/staging/rtl8188eu/include/odm_interface.h diff --git a/drivers

[PATCH 22/24] staging: rtl8188eu: Remove unused function declaration.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 2c2991e..e29ac79 100644 --- a/drivers/staging

[PATCH 20/24] staging: rtl8188eu: Use ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N in ODM_Write_DIG()

ODM_REG(IGI_A, pDM_Odm) and ODM_BIT(IGI, pDM_Odm) macros produce ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N respectively after preprocessing. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl

[PATCH 19/24] staging: rtl8188eu: Remove unnecessary debugging message from ODM_Write_DIG()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 2bd68aa..205ba7f 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c +++ b/drivers/stag

[PATCH 18/24] staging: rtl8188eu: Use ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N in odm_DIGInit()

ODM_REG(IGI_A, pDM_Odm) and ODM_BIT(IGI, pDM_Odm) macros produce ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N respectively after preprocessing. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl

[PATCH 21/24] staging: rtl8188eu: Remove unused macros defined in odm_interface.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h | 30 - 1 file changed, 30 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index ba58a67..2c2991e 100644 --- a

[PATCH 17/24] staging: rtl8188eu: Use "ODM_REG_CCK_CCA_11N" in ODM_Write_CCK_CCA_Thres()

Use "ODM_REG_CCK_CCA_11N" directly instead of using ODM_REG(CCK_CCA, pDM_Odm) which produces same after preprocessing. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c

[PATCH 16/24] staging: rtl8188eu: Remove unused function declaration.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 5338290..ba58a67 100644 --- a/drivers/staging/r

[PATCH 15/24] staging: rtl8188eu: Remove unused function pointer declaration.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 3fc3e3c..5338290 100644 --- a/drivers/st

[PATCH 13/24] staging: rtl8188eu: Remove unused structure "rtl8192cd_priv"

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm.h |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm.h b/drivers/staging/rtl8188eu/include/odm.h index 9d1a79c..e83812f 100644 --- a/drivers/staging/rtl8188eu/include/odm.h +++

[PATCH 12/24] staging: rtl8188eu: Remove unused macros and enum defined in odm_types.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_types.h | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_types.h b/drivers/staging/rtl8188eu/include/odm_types.h index 78ee2ba..c1355b9 100644 --- a/drivers

[PATCH 14/24] staging: rtl8188eu: Remove unused macros in odm_interface.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 548a309..3fc3e3c 100644 --- a/drivers/s

[PATCH 11/24] staging: rtl8188eu: remove unused header inclusion from rtw_mp.c

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mp.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mp.c b/drivers/staging/rtl8188eu/core/rtw_mp.c index 705f666..17427a6 100644 --- a/drivers/staging/rtl8188eu/core/rtw_mp.c +++ b/drive

[PATCH 09/24] staging: rtl8188eu: Remove unused function pointer ->dm_init

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/include/hal_intf.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_in

[PATCH 10/24] staging: rtl8188eu: Remove unused function rtl8188e_deinit_dm_priv()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c |4 drivers/staging/rtl8188eu/include/rtl8188e_dm.h |1 - 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index 4e

[PATCH 07/24] staging: rtl8188eu: Remove function with empty defination dm_CheckStatistics()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index cf88bf2..4e9f797 100644 --- a/drivers/staging/rtl8188eu/ha

[PATCH 06/24] staging: rtl8188eu: Remove unused function odm_Init_RSSIForDM()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_HWConfig.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c index 0145a11..f2e1d02 100644 --- a/drivers/staging/rtl8188eu/hal/od

[PATCH 05/24] staging: rtl8188eu: Remove unused function ODM_MacStatusQuery()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_HWConfig.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c index a755df3..0145a11 100644 --- a/drivers/staging/rtl8188eu/ha

[PATCH 08/24] staging: rtl8188eu: Remove function rtw_hal_dm_deinit()

rtw_hal_dm_deinit() calls rtl8188e_deinit_dm_priv() using funtion pointer. rtl8188e_deinit_dm_priv() has empty defination, so we can remove rtw_hal_dm_deinit() and later rtl8188e_deinit_dm_priv() also will be removed. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c

[PATCH 04/24] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 9020129..141f85a 100644 --- a/drivers/staging/rtl8188eu/hal/usb

[PATCH 02/24] staging: rtl8188eu: Remove unused function rtw_hal_intf_ps_func()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c |9 - drivers/staging/rtl8188eu/include/hal_intf.h |3 --- 2 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c index d75ca7

[PATCH 03/24] staging: rtl8188eu: Remove unused function pointer ->interface_ps_func

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |2 -- drivers/staging/rtl8188eu/include/hal_intf.h |3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 0cb84ae.

[PATCH 01/24] staging: rtl8188eu: Remove unused function rtw_interface_ps_func()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c|9 - drivers/staging/rtl8188eu/include/rtw_pwrctrl.h |2 -- 2 files changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c

Re: [PATCH 9/18] staging: rtl8723au: Use kmemdup instead of kmalloc + memcpy

On 26/05/2014 17:43, Jes Sorensen wrote: > Benoit Taine writes: > > This issue was reported by coccicheck using the semantic patch > > at scripts/coccinelle/api/memdup.cocci > > > > Signed-off-by: Benoit Taine > > --- > > Tested by compilation without errors. > > > > drivers/staging/rtl8723au/h

Re: [PATCH 9/18] staging: rtl8723au: Use kmemdup instead of kmalloc + memcpy

Benoit Taine writes: > This issue was reported by coccicheck using the semantic patch > at scripts/coccinelle/api/memdup.cocci > > Signed-off-by: Benoit Taine > --- > Tested by compilation without errors. > > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c |3 +-- > drivers/staging/rtl872

[PATCH 0/18] Use kmemdup instead of kmalloc + memcpy

These patches enhance kernel style usage, and allows smaller code while preventing accidental code edits to produce overflows. The semantic patch at scripts/coccinelle/api/memdup.cocci was used to detect and edit this situation. ___ devel mailing list de

[PATCH 9/18] staging: rtl8723au: Use kmemdup instead of kmalloc + memcpy

This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/memdup.cocci Signed-off-by: Benoit Taine --- Tested by compilation without errors. drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c |3 +-- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 16 +++

[PATCH] [next-20140526] rtl8192ee: btcoexist: remove undefined Kconfig macros

There are references to four undefined Kconfig macros in the code. Commit 8542373dccd2 ("Staging: rtl8812ae: remove undefined Kconfig macros") removed identical references from another staging driver, but they resurfaced in rtl8192ee. Remove these again as the checks for them still will always eval

[PATCH v2 1/5] gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging

The i.MX Image Processing Unit (IPU) contains a number of image processing blocks that sit right in the middle between DRM and V4L2. Some of the modules, such as Display Controller, Processor, and Interface (DC, DP, DI) or CMOS Sensor Interface (CSI) and their FIFOs could be assigned to either fram

[PATCH v2 4/5] gpu: ipu-v3: Add CSI and SMFC module enable wrappers

IPU_CONF_..._EN bits are implementation details, not to be made public. Add wrappers around ipu_module_enable/disable, so the CSI V4L2 driver can enable/disable the CSI and SMFC modules. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-common.c | 24 include/video

[PATCH v2 3/5] gpu: ipu-v3: Add ipu_idmac_get_current_buffer function

This function returns the currently active buffer (0 or 1) of a double buffered IDMAC channel. It is to be used by the CSI driver. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-common.c | 9 + include/video/imx-ipu-v3.h | 1 + 2 files changed, 10 insertions(+) diff --git

[PATCH v2 0/5] Move IPUv3 core out of staging, add CSI support

Hi, This is a rebased version of the earlier RFC series. It is mostly about the first patch, which moves the IPUv3 core code (drivers/staging/imx-drm/ipu-v3) to drivers/gpu. host1x, which serves a similar purpose, already sits there. I'd like to move the IPUv3 core code out of staging so that we

[PATCH v2 2/5] gpu: ipu-v3: Add SMFC code

The Sensor Multi Fifo Controller (SMFC) is used as a buffer between the two CSIs (writing simultaneously) and up to four IDMAC channels. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/Makefile | 2 +- drivers/gpu/ipu-v3/ipu-common.c | 10 + drivers/gpu/ipu-v3/ipu-prv.h| 6 +++

[PATCH v2 5/5] gpu: ipu-v3: Register the CSI modules

This patch registers the two CSI platform devices per IPU. Signed-off-by: Lucas Stach Signed-off-by: Philipp Zabel --- Changes since RFC: - Rebased onto current staging-next --- drivers/gpu/ipu-v3/ipu-common.c | 37 - include/video/imx-ipu-v3.h | 1 +

[PATCH V3] drivers/staging: drivers/staging: Remove useless return variables

This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // @@ type T; constant C; identif

Re: [PATCH 10/27] Staging: bcm: Shortened lines in StoreCmControlResponseMessage()

On 26-05-2014 16:08:42, Dan Carpenter wrote: > On Fri, May 23, 2014 at 10:23:48PM +0200, Matthias Beyer wrote: > > - pstAddIndication = kmalloc(sizeof(struct bcm_add_indication), > > GFP_KERNEL); > > + pstAddIndication = kmalloc(sizeof(struct bcm_add_indication), > > + GFP_KE

Re: [PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

On Mon, May 26, 2014 at 11:47:51AM +0200, Matthias Beyer wrote: > On 26-05-2014 11:38:25, Dan Carpenter wrote: > > On Fri, May 23, 2014 at 10:23:45PM +0200, Matthias Beyer wrote: > > > Signed-off-by: Matthias Beyer > > > --- > > > drivers/staging/bcm/CmHost.c | 14 ++ > > > 1 file cha

Re: [PATCH 10/27] Staging: bcm: Shortened lines in StoreCmControlResponseMessage()

On Fri, May 23, 2014 at 10:23:48PM +0200, Matthias Beyer wrote: > - pstAddIndication = kmalloc(sizeof(struct bcm_add_indication), > GFP_KERNEL); > + pstAddIndication = kmalloc(sizeof(struct bcm_add_indication), > + GFP_KERNEL); Line these up like this: pstAdd

Re: [PATCH 27/48] staging: rtl8723au: Rename BTDM_Coexist() to rtl8723a_BT_do_coexist()

On Mon, May 26, 2014 at 01:24:20PM +0200, Jes Sorensen wrote: > Let me ask this another way, does every patch submission have to end up > in a nit-picking session over non-issues? I get the distinct impression > you simply want to comment just to have the last word. You feel like I am singling you

Re: [PATCH 27/48] staging: rtl8723au: Rename BTDM_Coexist() to rtl8723a_BT_do_coexist()

Dan Carpenter writes: > On Mon, May 26, 2014 at 12:46:09PM +0200, Jes Sorensen wrote: >> If you look at the patches, you'll notice that I made them functions >> when there were return values, only the ones returning void were done >> like this. If you can point out an actual problem with this appr

Re: [PATCH 27/48] staging: rtl8723au: Rename BTDM_Coexist() to rtl8723a_BT_do_coexist()

On Mon, May 26, 2014 at 12:46:09PM +0200, Jes Sorensen wrote: > Dan Carpenter writes: > > On Sun, May 25, 2014 at 10:43:27PM +0200, jes.soren...@redhat.com wrote: > >> --- a/drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h > >> +++ b/drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h > >> @@

Re: [PATCH 2/4] staging: dgap: implement proper error handling in dgap_firmware_load()

On Mon, May 26, 2014 at 07:23:47PM +0900, Daeseok Youn wrote: > When dgap_tty_init() and dgap_tty_register_ports() are failed, > these are needed to free some memory properly. > > It can be handled by calling dgap_tty_uninit() and dgap_cleanup_board(). > But tty's ports are not registered yet when

Re: [PATCH 27/48] staging: rtl8723au: Rename BTDM_Coexist() to rtl8723a_BT_do_coexist()

Dan Carpenter writes: > On Sun, May 25, 2014 at 10:43:27PM +0200, jes.soren...@redhat.com wrote: >> --- a/drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h >> +++ b/drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h >> @@ -22,6 +22,7 @@ >> bool rtl8723a_BT_using_antenna_1(struct rtw_adapter

Re: [PATCH 1/9] staging: ion: tidy up a bit

On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote: > @@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct > ion_system_heap *heap, > > info->page = page; > info->order = orders[i]; > - INIT_LIST_HEAD(&info->list); >

[PATCH 4/4] staging: dgap: move tty_port_init() for serial_ports.

If printer_ports which is allocated after serial_ports is failed to allocate, tty_port_init for serial_ports doesn't need anymore. So move this after allocating memory for printer_ports. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+),

[PATCH 3/4] staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()

When it failed to allocate for printer_ports, serial_ports can be freed in dgap_tty_uninit(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index d

[PATCH 2/4] staging: dgap: implement proper error handling in dgap_firmware_load()

When dgap_tty_init() and dgap_tty_register_ports() are failed, these are needed to free some memory properly. It can be handled by calling dgap_tty_uninit() and dgap_cleanup_board(). But tty's ports are not registered yet when these function are failed, so brd->nasync set to zero. Signed-off-by:

[PATCH 1/4] staging: dgap: remove unneeded kfree() for ttys in tty_driver

In destruct_tty_driver() from put_tty_driver() will free the ttys in tty_driver. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 1475532..60b7d7

[PATCH 9/9] staging: ion: optimize struct ion_system_heap

struct ion_system_heap has an array for storing pointers to page pools and it is allocated separately from the containing structure. There is no point in allocating those two small objects individually, bothering slab allocator. Using a variable length array simplifies code lines and reduces overhe

[PATCH 8/9] staging: ion: shrink highmem pages on kswapd

ION system heap keeps pages in its pool for better performance. When the system is under memory pressure, slab shrinker calls the callback registered and then the pages pooled get freed. When the shrinker is called, it checks gfp_mask and determines whether the pages from highmem need to be freed

[PATCH 7/9] staging: ion: remove order argument from free_buffer_page()

Not that the pages returned from the pool are compound pages, we do not need to pass the order information to free_buffer_page(). Signed-off-by: Heesub Shin --- drivers/staging/android/ion/ion_system_heap.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/stag

[PATCH 1/9] staging: ion: tidy up a bit

For aesthetics and readability, rename goto labels, remove useless code lines, and clarify function return type. Signed-off-by: Heesub Shin --- drivers/staging/android/ion/ion_page_pool.c | 2 +- drivers/staging/android/ion/ion_priv.h| 2 +- drivers/staging/android/ion/ion_system_hea

[PATCH 3/9] staging: ion: use compound pages on high order pages for system heap

Using compound pages relieves burden on tracking the meta information which are currently stored in page_info. Signed-off-by: Heesub Shin --- drivers/staging/android/ion/ion_page_pool.c | 4 +++- drivers/staging/android/ion/ion_system_heap.c | 2 +- 2 files changed, 4 insertions(+), 2 deletion

[PATCH 6/9] staging: ion: remove struct page_info

ION system heap uses a temporary list holding meta data on pages allocated to build scatter/gather table. Now that the pages are compound pages, we do not need to introduce a new data type redundantly. Signed-off-by: Heesub Shin --- drivers/staging/android/ion/ion_system_heap.c | 47 +---

[PATCH 4/9] staging: ion: remove struct ion_page_pool_item

Now that the order information is held on struct page itself, we do not need to use extra data structure. This commit reduces unnecessary slab usage for allocating small objects. Signed-off-by: Heesub Shin --- drivers/staging/android/ion/ion_page_pool.c | 27 +-- 1 file c

[PATCH 5/9] staging: ion: remove order from struct page_info

ION system heap uses an internal data structure, struct page_info, for tracking down the meta information of the pages allocated from the pool. Now that the pool returns compound pages, we don't need to store page order in struct page_info. Signed-off-by: Heesub Shin --- drivers/staging/android/

[PATCH 2/9] staging: ion: simplify ion_page_pool_total()

ion_page_pool_total() returns the total number of pages in the pool. Depending on the argument passed, it counts pages from highmem zone in or not. This commit simplifies the code lines for better readability. Signed-off-by: Heesub Shin --- drivers/staging/android/ion/ion_page_pool.c | 10 +-

Re: [PATCH 27/48] staging: rtl8723au: Rename BTDM_Coexist() to rtl8723a_BT_do_coexist()

On Sun, May 25, 2014 at 10:43:27PM +0200, jes.soren...@redhat.com wrote: > --- a/drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h > +++ b/drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h > @@ -22,6 +22,7 @@ > bool rtl8723a_BT_using_antenna_1(struct rtw_adapter *padapter); > bool rtl8723a_

Re: [PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

On 26-05-2014 11:38:25, Dan Carpenter wrote: > On Fri, May 23, 2014 at 10:23:45PM +0200, Matthias Beyer wrote: > > Signed-off-by: Matthias Beyer > > --- > > drivers/staging/bcm/CmHost.c | 14 ++ > > 1 file changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging

[PATCH] staging/lustre/llite: Remove unnecessary check for NULL before iput()

iput() already checks for the inode being NULL, thus it's unnecessary to check before calling. Signed-off-by: Tobias Klauser --- drivers/staging/lustre/lustre/llite/llite_lib.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.

[PATCH 1/1] staging: imx-drm: Remove unused variable

'ret' is not used in the function. Remove it. Signed-off-by: Sachin Kamat --- drivers/staging/imx-drm/imx-tve.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c index 3e8b0a1a457f..4caef2b1653d 100644 --- a/drivers/stagi

Re: [PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

On Fri, May 23, 2014 at 10:23:45PM +0200, Matthias Beyer wrote: > Signed-off-by: Matthias Beyer > --- > drivers/staging/bcm/CmHost.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c > index 3f29de

Re: [PATCH 06/27] Staging: bcm: Shortened line

On Fri, May 23, 2014 at 10:23:44PM +0200, Matthias Beyer wrote: > Signed-off-by: Matthias Beyer > --- > drivers/staging/bcm/CmHost.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c > index 181c4e9..3f29dea 100

Re: [PATCH 05/27] Staging: bcm: Simplified by using variables

On Fri, May 23, 2014 at 10:23:43PM +0200, Matthias Beyer wrote: > Signed-off-by: Matthias Beyer > --- > drivers/staging/bcm/CmHost.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c > index 59a3eb9..1

Re: [PATCH 04/27] Staging: bcm: Outsourced restoring of endianess for ip adresses

Style issues. No need to resend, but please read them. On Fri, May 23, 2014 at 10:23:42PM +0200, Matthias Beyer wrote: > Signed-off-by: Matthias Beyer > --- > drivers/staging/bcm/CmHost.c | 32 +++- > 1 file changed, 23 insertions(+), 9 deletions(-) > > diff --git a

Re: [PATCH] Staging: rtl8192u: r819xU_firmware_img.c Fixed checkpatch.pl ERRORs

On Sun, May 25, 2014 at 09:15:06AM -0700, Chaitanya Hazarey wrote: > Fixed a lot of errors of the type "ERROR: space required after that ',' > (ctx:VxV)" > > Added tabs at the beginning of line. > > Signed-off-by: Chaitanya Hazarey > --- Great. :) Thanks. regards, dan carpenter ___