On Mon, May 26, 2014 at 11:47:51AM +0200, Matthias Beyer wrote:
> On 26-05-2014 11:38:25, Dan Carpenter wrote:
> > On Fri, May 23, 2014 at 10:23:45PM +0200, Matthias Beyer wrote:
> > > Signed-off-by: Matthias Beyer <m...@beyermatthias.de>
> > > ---
> > > drivers/staging/bcm/CmHost.c | 14 ++++++++++----
> > > 1 file changed, 10 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
> > > index 3f29dea..9fea9a8 100644
> > > --- a/drivers/staging/bcm/CmHost.c
> > > +++ b/drivers/staging/bcm/CmHost.c
> > > @@ -1531,12 +1531,14 @@ ULONG SetUpTargetDsxBuffers(struct
> > > bcm_mini_adapter *Adapter)
> > > return 1;
> > > }
> > >
> > > -static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter
> > > *Adapter, B_UINT16 tid)
> > > +static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter
> > > *Adapter,
> > > + B_UINT16 tid)
> > > {
> > > ULONG dsx_buf;
> > > ULONG idx, max_try;
> > >
> > > - if ((Adapter->ulTotalTargetBuffersAvailable == 0) ||
> > > (Adapter->ulFreeTargetBufferCnt == 0)) {
> > > + if ((Adapter->ulTotalTargetBuffersAvailable == 0)
> > > + || (Adapter->ulFreeTargetBufferCnt == 0)) {
> >
> > Haven't we had this discussion? The "||" goes on the first line and the
> > indenting needs to be lined up.
>
> I think no, we had not.
Sorry, about that then.
I'm done reviewing the patchset and it looks good to me. Thanks for
your work on this.
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
