Hello Carpenter,

On 05/26/2014 07:36 PM, Dan Carpenter wrote:
On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
@@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct 
ion_system_heap *heap,

                info->page = page;
                info->order = orders[i];
-               INIT_LIST_HEAD(&info->list);
                return info;
        }
        kfree(info);

Wait.  How does this code work without that INIT_LIST_HEAD()?  What am
I missing here...

No problem. As the object info is just a node, not a head, it is completely useless to initialize it as a list head.

regards,
Heesub


regards,
dan carpenter



_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to