Pointer 'ni' checked for NULL at line 1569 may be passed to
function and may be dereferenced there by passing argument 1 to
function 'lnet_ni_notify_locked' at line 1621.
found by Klocwork Insight tool
Signed-off-by: Oleg Drokin
CC: Dmitry Eremin
CC: Liang Zhen
---
drivers/staging/lustre/lnet/
This is just splitting big lnet fixes patch from Klocwork static
analysis tool into smaller bits.
Reworked according to previous comments.
Also, this time with correct CC list.
Dmitry Eremin (2):
staging/lustre/lnet: remove unused variable in
lnet_destroy_remote_nets_table
staging/lustre/l
It should never be NULL because our interface list is up to date,
and even if it does, we'll just crash anyway so we are no better off.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/lustre
From: Dmitry Eremin
Null pointer 'cp' that comes from line 2544 may be dereferenced
at line 2618.
found by Klocwork Insight tool
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9386
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-by: John L. Hammond
Revi
From: Dmitry Eremin
Local variable 'hash' is never used
found by Klocwork Insight tool
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9386
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-by: John L. Hammond
Reviewed-by: Isaac Huang
Signed-off-by: Oleg
Insted of meddling directly in process environment variables
(which is also not possible on certain platforms due to not exported
symbols), create jobid_name proc file to represent this info
(to be filled by job scheduler epilogue).
Signed-off-by: Oleg Drokin
CC: Andreas Dilger
---
.../staging/
Hi,
2014-04-27 0:53 GMT+09:00 Sami Laine :
> From: Sami Laine
do not include this line on your patch. it is not necessary.
>
> Corrected sparse static declaration warnings.
>
> Signed-off-by: Sami Laine
> ---
> diff --git a/drivers/staging/cxt1e1/hwprobe.c
> b/drivers/staging/cxt1e1/hwprobe.c
>
Hello!
On Apr 27, 2014, at 6:39 PM, Greg Kroah-Hartman wrote:
>>
>> -lnet_ni_notify_locked(ni, lp);
>> +if (ni != NULL)
>> +lnet_ni_notify_locked(ni, lp);
>
> Why can't lnet_ni_notify_locked() accept NULL as an input?
It makes no sense, because then there is nowhere to send
OK. I'll make my patch based on Mark's patch.
Thanks.
Daeseok Youn.
2014-04-27 3:48 GMT+09:00 Dan Carpenter :
> On Sat, Apr 26, 2014 at 11:39:38AM +0900, DaeSeok Youn wrote:
>> Hi,
>>
>> please check below my comments.
>>
>> 2014-04-25 23:41 GMT+09:00 Mark Hounschell :
>> > On 04/25/2014 08:59 AM
On Sun, Apr 27, 2014 at 10:00:43PM +0200, Mateusz Guzik wrote:
> > > and a WARN_ON + -EINVAL in line6_init_audio to catch future
> > > offenders.
> >
> > Returning -EINVAL is a bad idea because it would break the driver
> > completely and make it unusable.
> >
>
> Well I would vote for returni
On Sun, Apr 27, 2014 at 05:17:24PM -0400, Oleg Drokin wrote:
> From: Dmitry Eremin
>
> Pointer 'tsc' returned from call to function 'sfw_find_test_case'
> at line 571 may be NULL and will be dereferenced at line 572.
> found by Klocwork Insight tool
>
> Signed-off-by: Dmitry Eremin
> Reviewed-o
On Sun, Apr 27, 2014 at 05:17:26PM -0400, Oleg Drokin wrote:
> From: Dmitry Eremin
>
> Pointer 'ni' checked for NULL at line 1569 may be passed to
> function and may be dereferenced there by passing argument 1 to
> function 'lnet_ni_notify_locked' at line 1621.
> found by Klocwork Insight tool
>
On Sun, Apr 27, 2014 at 06:19:59PM -0400, Oleg Drokin wrote:
> On Apr 27, 2014, at 6:05 PM, One Thousand Gnomes wrote:
>
> >> Reviewed-by: John L. Hammond
> >> Reviewed-by: Isaac Huang
> >> Signed-off-by: Oleg Drokin
> >> ---
> >> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++--
> >
On Sun, Apr 27, 2014 at 05:17:21PM -0400, Oleg Drokin wrote:
> This is just splitting big lnet fixes patch from Klocwork static
> analysis tool into smaller bits.
>
> Dmitry Eremin (5):
> staging/lustre/lnet: fix potential null pointer dereference
> staging/lustre/lnet: remove unused variable
On Apr 27, 2014, at 6:05 PM, One Thousand Gnomes wrote:
>> Reviewed-by: John L. Hammond
>> Reviewed-by: Isaac Huang
>> Signed-off-by: Oleg Drokin
>> ---
>> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers
> Reviewed-by: John L. Hammond
> Reviewed-by: Isaac Huang
> Signed-off-by: Oleg Drokin
> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> b/drivers/stagi
From: Dmitry Eremin
Local variable 'hash' is never used
found by Klocwork Insight tool
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9386
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-by: John L. Hammond
Reviewed-by: Isaac Huang
Signed-off-by: Oleg
From: Dmitry Eremin
Pointer 'ni' checked for NULL at line 1569 may be passed to
function and may be dereferenced there by passing argument 1 to
function 'lnet_ni_notify_locked' at line 1621.
found by Klocwork Insight tool
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/938
From: Dmitry Eremin
Pointer 'tsc' returned from call to function 'sfw_find_test_case'
at line 571 may be NULL and will be dereferenced at line 572.
found by Klocwork Insight tool
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9386
Intel-bug-id: https://jira.hpdd.intel.com
This is just splitting big lnet fixes patch from Klocwork static
analysis tool into smaller bits.
Dmitry Eremin (5):
staging/lustre/lnet: fix potential null pointer dereference
staging/lustre/lnet: remove unused variable
staging/lustre/lnet: fix potential null pointer dereference
staging/l
From: Dmitry Eremin
Null pointer 'cp' that comes from line 2544 may be dereferenced
at line 2618.
found by Klocwork Insight tool
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9386
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-by: John L. Hammond
Revi
From: Dmitry Eremin
Null pointer 'best_iface' that comes from line 802 may be
dereferenced at line 832.
found by Klocwork Insight tool
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9386
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-by: John L. Hammond
On Sun, Apr 27, 2014 at 02:34:48PM +0200, Daniele Forsi wrote:
> It was added by commit e0349d5ba (staging: et131x: Remove unused
> rcv_pend_lock spinlock)
>
> Signed-off-by: Daniele Forsi
Acked-by: Mark Einon
___
devel mailing list
de...@linuxdriver
Greg,
Please incorporate the latest imx-drm non-urgent fixes, which can be found at:
git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-fixes
with SHA1 1e6d486be4ea3f17c99c933703f53a6d566292a9.
These are the less urgent fixes, but nevertheless, I think they should
be submitted for an -rc k
Greg,
Please incorporate the latest imx-drm urgent fixes, which can be found at:
git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-fixes-urgent
with SHA1 a3fe964135d0e4b925eaf4a5891c84daa7885c86.
These are the urgent fixes which should be required. arm-soc people have
acked the change to
On Sun, Apr 27, 2014 at 08:39:32PM +0300, Dan Carpenter wrote:
> On Sat, Apr 26, 2014 at 11:59:46PM +0200, Mateusz Guzik wrote:
> > > And sadly enough some of those ->id strings are more than 15 characters
> > > and a NUL which will fit in card->id. So this overflow is real. The
> > > card->short
Thank's for your answers,
will try to look deeper,
>> >
>> > If we want to sovle the truncation issue then we need to think of
>> > shorter names for BassPODxtLive, BassPODxtPro, PODStudioUX1, and
>> > PODStudioUX2.
>> >
>>
>> In that case I suggest compile time assertions that ids and names fit
>
Quiet the warning below in Lustre code.
Actually the warning is invalid since we either always assign
the symname in ll_readlink_internal or return an error there and
then the following rc check would assign symlink variable explicitly.
In file included from
/home/green/bk/linux/drivers/staging/l
Thanks!
Liang, any comments about this?
On Apr 27, 2014, at 2:26 PM, Dan Carpenter wrote:
> Hello Peng Tao,
>
> The patch d7e09d0397e8: "staging: add Lustre file system client
> support" from May 2, 2013, leads to the following static checker
> warning:
>
> drivers/staging/lustre/lnet/kl
Hello!
On Apr 27, 2014, at 1:33 PM, Greg Kroah-Hartman wrote:
> I've applied these, except for the 3 gss patches.
Thanks.
gss stuff was kind of totally separate, tso I thought it was not so bad idea
to include them,
but they are definitely not required.
> Also, there is now a build warning in
Hello Peng Tao,
The patch d7e09d0397e8: "staging: add Lustre file system client
support" from May 2, 2013, leads to the following static checker
warning:
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:1904 ksocknal_push()
info: ignoring unreachable code.
drivers/staging/lust
On Sat, Apr 26, 2014 at 11:59:46PM +0200, Mateusz Guzik wrote:
> > And sadly enough some of those ->id strings are more than 15 characters
> > and a NUL which will fit in card->id. So this overflow is real. The
> > card->shortname is a 32 char array so none of those overflow.
> >
> > If we want
On Sun, Apr 27, 2014 at 01:06:24PM -0400, Oleg Drokin wrote:
> Hello!
>
>This pile of patches brings in most of the recent fixes from
>current Lustre development tree, also code cleanups, junk removal
>and such.
>A relatively unsynced area remaining is in client io stack
>that
On Sun, Apr 27, 2014 at 01:07:10PM -0400, Oleg Drokin wrote:
> Apparently we are pretty bad about verifying our buffers passed
> from userspace.
Understatement of the day...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriver
On Sun, Apr 27, 2014 at 01:06:53PM -0400, Oleg Drokin wrote:
> From: Dmitry Eremin
>
> Null pointer 'cp' that comes from line 2544 may be dereferenced
> at line 2618.
>
> Pointer 'ni' checked for NULL at line 1569 may be passed to
> function and may be dereferenced there by passing argument 1 to
On Sun, Apr 27, 2014 at 01:06:28PM -0400, Oleg Drokin wrote:
> From: Andrew Korty
>
> Implement security flavors and GSSAPI mechanism to perform shared key
> authentication (ski) and encryption (skpi).
>
> Signed-off-by: Andrew Korty
> Reviewed-on: http://review.whamcloud.com/8629
> Intel-bug-i
From: Andreas Dilger
Locate the loh_flags and loh_ref fields together in lu_object_header
to avoid holes and shrink the structure by 8 bytes.
Signed-off-by: Andreas Dilger
Reviewed-on: http://review.whamcloud.com/9185
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3059
Reviewed-by: Alex Zh
From: Li Xi
spin_is_locked() is always false when the platform is
uniprocessor and CONFIG_DEBUG_SPINLOCK is not enabled.
This patch replaces its assertion by assert_spin_locked().
Signed-off-by: Li Xi
Signed-off-by: James Simmons
Reviewed-on: http://review.whamcloud.com/8144
Intel-bug-id: http
From: Bobi Jam
lov_fiemap() does not take consider its @vallen parameter, which is
the max buffer size the caller can hold for the fiemap extents.
This patch fixes this and limits the max mapped fiemap extent count
to fit in the preallocted buffer.
This patch also fixes a memory out of bound wr
From: Swapnil Pimpale
Removed the checks for oi_lockless from osc_io_read_start() and
osc_io_write_start(). This patch also removes the unnecessary call to
cl_object_attr_get() in osc_io_write_start() before calling
cl_object_attr_set()
Signed-off-by: Swapnil Pimpale
Reviewed-on: http://review.
From: Jinshan Xiong
Otherwise, it will cause deadlock because it essentially holds
some sub locks and then to request others in an arbitrary order.
Signed-off-by: Jinshan Xiong
Reviewed-on: http://review.whamcloud.com/9152
Reviewed-by: Lai Siyao
Reviewed-by: Bobi Jam
Signed-off-by: Oleg Droki
From: Dmitry Eremin
Null pointer 'cp' that comes from line 2544 may be dereferenced
at line 2618.
Pointer 'ni' checked for NULL at line 1569 may be passed to
function and may be dereferenced there by passing argument 1 to
function 'lnet_ni_notify_locked' at line 1621.
Null pointer 'best_iface'
From: wang di
In some cases, cl_default_mds_easize might be zero, especially for
MDC connected to non-MDT0, then mdc might pack getattr RPC with
zero eadatasize.
If client is trying to access remote striped directory with
zero eadatasize, MDT will not return layout information of the
striped dir
From: Andreas Dilger
The Linux VFS and Lustre OST_SYNC RPC are both capable of specifying
fsync() on a sub-extent of the file {start, end} instead of the full
file. This allows less than the full amount of data to be flushed,
reducing or possibly eliminating the work needed before the syscall
ca
From: Dmitry Eremin
Pointer 'mod' checked for NULL at line 160 may be dereferenced at line 208.
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9387
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-by: Lai Siyao
Reviewed-by: John L. Hammond
Reviewed-by:
From: Ryan Haasken
In libcfs_debug_vmsg2, cdls_delay is only clamped between the minimum
and the maximum when it is increased by multiplying by the backoff
factor. It is not clamped when it is decreased by dividing by the
backoff factor. This allows it to achieve values less than the
minimum, w
From: Dmitry Eremin
sscanf format specification '%u' expects type 'unsigned int *'
for 'u', but parameter 3 has a different type 'int*'.
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9400
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-by: John L. Hammo
Apparently we are pretty bad about verifying our buffers passed
from userspace.
Signed-off-by: Oleg Drokin
Reviewed-on: http://review.whamcloud.com/9059
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4563
Reviewed-by: Dmitry Eremin
Reviewed-by: James Simmons
---
drivers/staging/lustre/lus
From: "John L. Hammond"
In llite remove unused declarations, parameters, types, and unused,
get-only, or set-only structure members. Add static and const
qualifiers to declarations where possible.
Signed-off-by: John L. Hammond
Reviewed-on: http://review.whamcloud.com/9767
Intel-bug-id: https:/
From: Li Xi
Setxattr does not check the permission when setting ACL xattrs. This
will cause security problem because any user can walk around
permission checking by changing ACL rules.
Signed-off-by: Li Xi
Reviewed-on: http://review.whamcloud.com/9473
Intel-bug-id: https://jira.hpdd.intel.com/b
From: Dmitry Eremin
It's just optimization. The mutex subsystem is slightly faster
and has better scalability for contended workloads.
Remove the lustre_lock and it's accessor functions l_lock(),
l_unlock(), l_lock_init(), and l_has_lock() since they have
not been used by the code since Lustre 1
From: "John L. Hammond"
Remove the unused function llog_obd_add(). Remove the unused count and
parameters from llog_cancel(). Move dump_lsm() from obdclass to
the only module that uses it (lov). Remove obd_lov.h.
Signed-off-by: John L. Hammond
Reviewed-on: http://review.whamcloud.com/8545
Intel
From: "John L. Hammond"
Remove the nowhere included header lustre/include/ioctl.h.
Signed-off-by: John L. Hammond
Reviewed-on: http://review.whamcloud.com/9757
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675
Reviewed-by: Bob Glossman
Reviewed-by: Dmitry Eremin
Signed-off-by: Oleg Dro
From: Dmitry Eremin
According https://www.kernel.org/doc/Documentation/mutex-design.txt:
- the mutex subsystem is slightly faster and has better scalability
for contended workloads. In terms of 'ops per CPU cycle', the
semaphore kernel performed 551 ops/sec per 1% of CPU time used,
while th
From: Li Xi
Some CPU table functions for uniprocessor architecture is
missing.
Signed-off-by: Li Xi
Signed-off-by: James Simmons
Reviewed-on: http://review.whamcloud.com/8873
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4199
Reviewed-by: Bob Glossman
Reviewed-by: Dmitry Eremin
Reviewe
From: Bob Glossman
Change the LL_IOC_LLOOP_INFO ioctl in the lustre lloop
device driver to return an error instead of causing
panics with LASSERT().
Signed-off-by: Bob Glossman
Reviewed-on: http://review.whamcloud.com/9888
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4863
Reviewed-by: Na
From: Ryan Haasken
Messages which are printed by ll_dirty_page_discard_warn() should not
be rate limited. If they are rate limited, some files which may be
corrupted on client eviction will not be reported to the user.
This patch changes the CWARN to a CDEBUG to disable console message
rate lim
From: Jinshan Xiong
It's not atomic to check the last reference and state of cl_lock
in cl_lock_put(). This can cause a problem that an using lock is
freed, if the process is preempted between atomic_dec_and_test()
and (lock->cll_state == CLS_FREEING).
This problem can be solved by holding a ref
From: Brian Behlendorf
When allocating a reply buffer for the striping information don't
assume the unlikely worst case. Instead, assume the common case
and size the buffer based on the observed default ea/cookie size.
The default size is initialized to a single stripe and allowed to
grow up to
From: Jinshan Xiong
We used to access layout version under the protection of ldlm
lock, this introduces extra overhead for dlm lock matching.
In this patch, lli_layout_lock is introduced to access the layout
version. Also, when a layout lock is losing, we should tear down
mmap of the correspodin
From: "Christopher J. Morrone"
The statahead debug messages include the pid of the current
process in their body. This is both redudant (because all
lustre log messages contain the pid), and sometimes downright
misleading. For instance the messages would say something like
"stopping statahead t
From: Dmitry Eremin
Pointer '*exp' returned from call to function 'class_conn2export'
at line 523 may be NULL and may be dereferenced at line 543.
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9323
ntel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-by: John
From: Liang Zhen
lnet_shutdown_lndnis() may enter endless loop if there is a busy NI,
this is injected by LNet SMP improvements. It's fixed in this patch.
Signed-off-by: Liang Zhen
Reviewed-on: http://review.whamcloud.com/9706
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4780
Reviewed-by
From: "Christopher J. Morrone"
The statahead and statahead agl threads blindly set their
thread state to SVC_RUNNING without checking the state first. If, for
instance, another thread sets the state to SVC_STOPPING that
stop signal will now have been lost. Deadlock ensues.
We also partly impro
From: Bobi Jam
File write before io loop will take lli_trun_sem read semaphore to
protect osc_extent, while after generic_file_aio_write() done, it
could possible need to kill suid or sgid, which will call
ll_setattr_raw() to change the inode's attribute, and it does not
involve size.
So the ll_
From: Dmitry Eremin
Array 'message_buf' of size 500 may use index value(s) -1
Object 'enc_key.data' was freed at line 164 after being freed
by calling 'free' at line 150. Also there are 3 similar errors
on line(s) 164.
Suspicious dereference of pointer 'vmsg' before NULL check at
line 187. Also
From: Bobi Jam
The last parameter @datasync of fsync() has following indication:
* if datasync=0, we'd always flush data and metadata
* if datasync=1, we'd always flush data while does not flush modifed
metadata unless that metadata is needed in order to allow a
subsequent data retrieval to b
From: James Nunez
The total size of an HSM archive request may exceed the
desired (LNET) message. When this happens, it can hang
the client and not allow the archive request to succeed.
Before we know the total size of the hsm_action_items, we
need to limit the size of the reguest. Doing this li
From: Andriy Skulysh
Add rpc_cache for allocating ptlrpc_requests.
Xyratex-bug-id: MRP-689
Signed-off-by: Andriy Skulysh
Signed-off-by: Niu Yawei
Reviewed-on: http://review.whamcloud.com/6874
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2424
Reviewed-by: Andreas Dilger
Reviewed-by: Lai
From: Li Xi
This patch moves lock's skip flag clearing from lru-delete to
lru-add code to prevent clearing lock's flag without resource lock
protection.
Signed-off-by: Li Xi
Signed-off-by: Bobi Jam
Reviewed-on: http://review.whamcloud.com/8772
Intel-bug-id: https://jira.hpdd.intel.com/browse/L
From: Andreas Dilger
Quiet some common console error messages for permission errors
that can be hit in common cases.
Signed-off-by: Andreas Dilger
Reviewed-on: http://review.whamcloud.com/8988
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4522
Reviewed-by: Jinshan Xiong
Reviewed-by: Facc
From: Peng Tao
If fsname is 8-byte aligned, hai_zero fails to count the ending NULL
terminator causing hai to directly attached after fsname and future
hai_zero will return a different position for first hai.
Signed-off-by: Peng Tao
Reviewed-on: http://review.whamcloud.com/9431
Intel-bug-id: ht
From: Ann Koehler
In Lustre 2.4, the flags passed to the memory allocation functions are
translated from CFS enumeration values types to the kernel GFP
values by calling cfs_alloc_flags_to_gfp(). This function adds
__GFP_WAIT to all flags except CFS_ALLOC_ATOMIC. In 2.5, when
the cfs wrappers wer
From: Dmitry Eremin
'sg->page_link' is used uninitialized in many functions.
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9325
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-by: James Simmons
Reviewed-by: John L. Hammond
Signed-off-by: Oleg Drokin
From: "John L. Hammond"
Remove the unused functions lov_llog_init(), lov_llog_finish(),
their supporting functions, and the file lov_log.c.
Signed-off-by: John L. Hammond
Reviewed-on: http://review.whamcloud.com/8539
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675
Reviewed-by: Andreas
From: Andrew Korty
This change implements the gssnull security flavor for the purpose of
testing the Lustre GSS code. It provides and uses a null GSS
mechanism so this testing doesn't have to involve any code related to
Kerberos or any other authentication method.
Signed-off-by: Andrew Korty
I
From: Hongchao Zhang
In ptlrpc_activate_import(), obd_import->imp_deactive should
be checked if it is deactivated, otherwise it will trigger an
LBUG in ptlrpc_invalidate_import():
ptlrpc_invalidate_import() ASSERTION(imp->imp_invalid) failed
Signed-off-by: Hongchao Zhang
Reviewed-on: http://
Hello!
This pile of patches brings in most of the recent fixes from
current Lustre development tree, also code cleanups, junk removal
and such.
A relatively unsynced area remaining is in client io stack
that is undergoing some major shakeups now, I'll try to tackle
it later once
From: Patrick Farrell
lustre_get_emerg_rs() set the size of the reply buffer to zero
by mistake, which will cause LBUG in null_alloc_rs() when memory
pressure is high. This patch fix this problem and adds a size
check to avoid the problem of insufficient buffer size.
Signed-off-by: Li Xi
Signed
From: Andreas Dilger
If a connection has been stopped with ptlrpc_pinger_del_import() and
marked obd_no_recov, don't reconnect in ptlrpc_disconnect_import() if
the import is already disconnected. Otherwise, without the pinger it
will just wait there indefinitely for the reconnection that will ne
From: Andrew Korty
Implement security flavors and GSSAPI mechanism to perform shared key
authentication (ski) and encryption (skpi).
Signed-off-by: Andrew Korty
Reviewed-on: http://review.whamcloud.com/8629
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3289
Reviewed-by: Andreas Dilger
Re
From: Niu Yawei
The LDLM_FL_BLOCK_NOWAIT flag should be cleared when re-enqueue
the agl lock as normal glimpse, otherwise, it won't get size back
if there is conflicting locks on other client.
Signed-off-by: Niu Yawei
Reviewed-on: http://review.whamcloud.com/9249
Intel-bug-id: https://jira.hpdd
From: Matt Ezell
LNET messages that are dropped are not accounted for correctly in
/proc/sys/lnet/stats. What I assume to be a simple typo is causing
drop_length to be double-counted and drop_count to never be
incremented.
Signed-off-by: Matt Ezell
Reviewed-on: http://review.whamcloud.com/9096
From: Cheng Shao
Function ptlrpc_update_export_timer generates lots of D_HA level log
messages whenever the export timer gets updated. Those log messages
are found little use for issue investigations, and it will take space
in the Lustre log buffer. We are removing it now.
Xyratex-bug-id: MRP-73
On Sun, Apr 27, 2014 at 02:51:30PM +0200, Daniel Vetter wrote:
> On Sun, Apr 27, 2014 at 1:00 AM, Russell King - ARM Linux
> wrote:
> > A while back, Laurent raised some comments about the component helper,
> > which this patch set starts to address.
> >
> > The first point it addresses is the rep
On Sun, Apr 27, 2014 at 1:00 AM, Russell King - ARM Linux
wrote:
> A while back, Laurent raised some comments about the component helper,
> which this patch set starts to address.
>
> The first point it addresses is the repeated parsing inefficiency when
> deferred probing occurs. When DT is used
It was added by commit e0349d5ba (staging: et131x: Remove unused rcv_pend_lock
spinlock)
Signed-off-by: Daniele Forsi
---
drivers/staging/et131x/Module.symvers | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 drivers/staging/et131x/Module.symvers
diff --git a/drivers/st
87 matches
Mail list logo
