> Reviewed-by: John L. Hammond <john.hamm...@intel.com>
> Reviewed-by: Isaac Huang <he.hu...@intel.com>
> Signed-off-by: Oleg Drokin <oleg.dro...@intel.com>
> ---
>  drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c 
> b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> index 21d36ee..516f623 100644
> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> @@ -829,14 +829,14 @@ ksocknal_select_ips(ksock_peer_t *peer, __u32 *peerips, 
> int n_peerips)
>                               best_npeers = iface->ksni_npeers;
>                       }
>  
> +                     LASSERT(best_iface != NULL);
> +

And this solves the problem how ???

These dont' appear that helpful. If we dereference a NULL point we'll
already get a suitably spectacular oops and call trace dump.

Alan
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to