On Fri, 2014-04-25 at 10:50 +0300, Dan Carpenter wrote:
> On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote:
> > diff --git a/drivers/staging/comedi/drivers.c
> > b/drivers/staging/comedi/drivers.c
[]
> > @@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver
> > *
Do checksum offload only if the client of the driver wants checksum to be
offloaded.
In this version of the patch, I have addressed comments from
Stephen Hemminger and
Eric Dumazet .
This patch fixes a bug that is exposed in gateway scenarios.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiy
> -Original Message-
> From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev-
> devel-boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan
> Sent: Friday, April 25, 2014 7:24 PM
> To: Eric Dumazet; Stephen Hemminger
> Cc: o...@aepfle.de; net...@vger.kernel.org; jaso
Hi,
please check below my comments.
2014-04-25 23:41 GMT+09:00 Mark Hounschell :
> On 04/25/2014 08:59 AM, Dan Carpenter wrote:
>> On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote:
>>> On 04/25/2014 07:02 AM, DaeSeok Youn wrote:
Hi, Dan.
2014-04-25 18:26 GMT+09:00 Da
> -Original Message-
> From: Eric Dumazet [mailto:eric.duma...@gmail.com]
> Sent: Friday, April 25, 2014 6:15 PM
> To: Stephen Hemminger
> Cc: KY Srinivasan; da...@davemloft.net; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Friday, April 25, 2014 5:43 PM
> To: KY Srinivasan
> Cc: da...@davemloft.net; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.
On Fri, 2014-04-25 at 17:43 -0700, Stephen Hemminger wrote:
> On Fri, 25 Apr 2014 11:45:14 -0700
> "K. Y. Srinivasan" wrote:
>
> > @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff *skb,
> > struct net_device *net)
> > csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)pp
On Fri, 25 Apr 2014 11:45:14 -0700
"K. Y. Srinivasan" wrote:
> @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct
> net_device *net)
> csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)ppi +
> ppi->ppi_offset);
>
> + ip_hdr(skb)-
2014-04-26 7:33 GMT+09:00, Greg KH :
> On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote:
>>
>> The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> drivers/staging/silicom/bpctl_mod.c |5 +
>> 1 files changed, 5 insertio
On Wed, Apr 02, 2014 at 11:25:19AM +0200, Martin Berglund wrote:
> Added newlines after declarations.
>
> Signed-off-by: Martin Berglund
> ---
> drivers/staging/xgifb/XGI_main_26.c | 2 ++
> drivers/staging/xgifb/vb_init.c | 2 ++
> drivers/staging/xgifb/vb_setmode.c | 2 ++
> 3 files chang
On Fri, Apr 18, 2014 at 11:18:44PM +0200, Antoine Schweitzer-Chaput wrote:
> >From 73eb48f2b376c56f0a354ea0e6c2c71972aaffae Mon Sep 17 00:00:00 2001
> From: Antoine Schweitzer-Chaput
> Date: Wed, 16 Apr 2014 09:59:26 +0200
> Subject: [PATCH 1/1] Fix some lines over 80 characters in imx-drm
> stagi
On Sat, Apr 05, 2014 at 12:50:22PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Fix the following checkpatch warnings:
>
> WARNING: Missing a blank line after declarations
> #162: FILE: drivers/staging/imx-drm/imx-hdmi.c:162:
> + u8 val = hdmi_readb(hdmi, reg) & ~mask;
> + val |
On Wed, Mar 26, 2014 at 01:08:23AM +, Rui Miguel Silva wrote:
> fix some code style related to the use of braces in a one statement block
>
> Signed-off-by: Rui Miguel Silva
> ---
> drivers/staging/rtl8192u/r8192U_dm.c | 7 +++
> drivers/staging/rtl8192u/r8192U_wx.c | 3 +--
>
On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote:
>
> The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
>
> Signed-off-by: Daeseok Youn
> ---
> drivers/staging/silicom/bpctl_mod.c |5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/driv
On Thu, Apr 24, 2014 at 01:57:12PM -0500, Ken Cox wrote:
> The visorutil module was lacking license info.
>
> Signed-off-by: Ken Cox
> ---
> drivers/staging/unisys/visorutil/visorkmodutils.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/unisys/visorutil/visorkmoduti
On Thu, Apr 24, 2014 at 01:57:09PM -0500, Ken Cox wrote:
> From: Benjamin Romer
>
> This patch adds support for detection of s-Par firmware by checking for the
> hypervisor bit in the CPU capabilities, and then querying the hypervisor ID
> cpuid leaf.
No linewrap?
>
> This functionality will
On Thu, Apr 24, 2014 at 01:57:10PM -0500, Ken Cox wrote:
> This fixes a problem reported from upstream where a panic occurs if the
> unisys drivers are loaded on a non s-Par system.
>
> Reported-by: Fengguang Wu
> Signed-off-by: Ken Cox
> Tested by: Ken Cox
> ---
> drivers/staging/unisys/chann
On Tue, Apr 08, 2014 at 05:32:45PM +0100, Paul McQuade wrote:
> WARNING: do {} while (0) macros should not be semicolon terminated
>
> Signed-off-by: Paul McQuade
> ---
> drivers/staging/keucr/scsiglue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ke
On Sun, Apr 20, 2014 at 11:10:57AM +0200, Camille Bordignon wrote:
> Fix sparse warning "cast removes address space of expression"
> Add lost flag "__user" due to cast
>
> Signed-off-by: Camille Bordignon
> ---
> diff --git a/drivers/staging/android/binder.c
> b/drivers/staging/android/binder.c
On Fri, Apr 25, 2014 at 11:18:55PM +0530, RAGHAVENDRA GANIGA wrote:
> >From 7bdc654b12895889a539450528b52328901e6dc0 Mon Sep 17 00:00:00 2001
> From: Raghavendra Ganiga
> Date: Fri, 25 Apr 2014 23:11:22 +0530
> Subject: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
Why is all
This patch gets rid of the obvious CamelCases
from both dgap.c and dgap.h
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Suggested-by: Dan Carpenter
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 228 ++--
drivers/staging/dgap/dgap.
I get the sparse warning:
drivers/staging/dgap/dgap.c:367:25: warning: too long initializer-string
for array of char
It's referring to INIT_C_CC in the following code segment.
static struct ktermios DgapDefaultTermios = {
.c_iflag = (DEFAULT_IFLAGS), /* iflags */
.c_of
Add Mark Hounschell to the MAINTAINERs list for the dgap driver
Signed-off-by: Mark Hounschell
Suggested-by: Dan Carpenter
Cc: Greg Kroah-Hartman
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e67ea24..1bf556a 100644
--- a/MAINTAINERS
+++ b/
This patch just cleans up the ugly dgap_init_one function
Signed-off-by: Mark Hounschell
Suggested-by: Dan Carpenter
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b
> -Original Message-
> From: Tobias Klauser [mailto:tklau...@distanz.ch]
> Sent: Friday, April 25, 2014 8:04 AM
> To: KY Srinivasan; Haiyang Zhang
> Cc: de...@linuxdriverproject.org
> Subject: [PATCH] hv: Remove unnecessary comparison of unsigned against 0
>
> pfncount is of type u32 and
Do checksum offload only if the client of the driver wants checksum to be
offloaded. Also Windows hosts support ip header checksum offload as well -
take advantage of that.
This patch fixes a bug that is exposed in gateway scenarios.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
C
>From 7bdc654b12895889a539450528b52328901e6dc0 Mon Sep 17 00:00:00 2001
From: Raghavendra Ganiga
Date: Fri, 25 Apr 2014 23:11:22 +0530
Subject: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
This is a patch to fix coding style
warnings found by the checkpatch.pl tool
Signed-of
Fixed a coding style issue.
Signed-off-by: Nicolas Del Piano
---
drivers/staging/vt6655/tether.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6655/tether.c b/drivers/staging/vt6655/tether.c
index a5dc3c09..1e7d3e2 100644
--- a/drivers/staging/vt665
patch 1: check return values of dgap_tty_register and dgap_finalize_board_init
patch 2: removes 2 unnecessary conditionals
patch 3: only allow driver to configure MAXBOARDS (32)
--
1.8.1.4
___
devel mailing list
de...@linuxdriverproject.org
http://dr
Remove 2 unnessessary conditionals. They are always
false in this code path.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 32 ++--
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b
Check the return values of dgap_tty_register and
dgap_finalize_board_init. If they fail for a
particular board we should not be able to try
to use that board. IE. no device entries shall
be created for that board.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dg
Insure we don't allow configuring more than MAXBOARDS (32).
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index b834c83..f597432 100644
--- a/
On 04/25/2014 07:21 AM, Greg KH wrote:
On Fri, Apr 25, 2014 at 10:48:22AM -0300, Nicolas Del Piano wrote:
Fixed a coding style error, macros with complex values should be enclosed in
parentheses.
Signed-off-by: Nicolas Del Piano
---
drivers/staging/octeon-usb/octeon-hcd.c |2 +-
1 file
On Friday, April 25, 2014 1:18 AM, Chase Southwood wrote:
> The board supported by this driver does not have analog outputs. Remove
> the subdevice init for it.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
Looks good.
Reviewed-by: H Hartley Sweeten
___
On Friday, April 25, 2014 1:17 AM, Chase Southwood wrote:
> This board does not have analog inputs. Remove the subdevice init for
> them.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
Looks good.
Reviewed-by: H Hartley Sweeten
As Ian mentioned, after you have r
pfncount is of type u32 and thus can never be smaller than 0.
Found by the coverity scanner, CID 143213.
Signed-off-by: Tobias Klauser
---
drivers/hv/channel.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 602ca86..17c
On 04/25/2014 08:59 AM, Dan Carpenter wrote:
> On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote:
>> On 04/25/2014 07:02 AM, DaeSeok Youn wrote:
>>> Hi, Dan.
>>>
>>> 2014-04-25 18:26 GMT+09:00 Dan Carpenter :
Mark, maybe you should add yourself to the MAINTAINERS entry for this
>
On Fri, Apr 25, 2014 at 10:48:22AM -0300, Nicolas Del Piano wrote:
> Fixed a coding style error, macros with complex values should be enclosed in
> parentheses.
>
> Signed-off-by: Nicolas Del Piano
> ---
> drivers/staging/octeon-usb/octeon-hcd.c |2 +-
> 1 file changed, 1 insertion(+), 1 de
This patch fixes a few more sparse warnings related to __iomem
version 2 excludes a change that actually caused a new sparse
warning.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 37 +++--
1 file changed, 19 insertions(+
On 04/25/2014 09:44 AM, Dan Carpenter wrote:
> On Fri, Apr 25, 2014 at 09:38:48AM -0400, Mark Hounschell wrote:
>> This patch just backs out a change in a previous patch
>> that generated a new sparse warning.
>>
>
> Could you redo the previous change instead? Or has it already been
> applied?
>
Fixed a coding style error, macros with complex values should be enclosed in
parentheses.
Signed-off-by: Nicolas Del Piano
---
drivers/staging/octeon-usb/octeon-hcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/stagin
On Fri, Apr 25, 2014 at 09:38:48AM -0400, Mark Hounschell wrote:
> This patch just backs out a change in a previous patch
> that generated a new sparse warning.
>
Could you redo the previous change instead? Or has it already been
applied?
regards,
dan carpenter
Hi,
On 04/25/2014 03:40 PM, Nicolas Del Piano wrote:
> Fixed a coding style error, macros with comples values should be enclosed in
> parenthesis.
>
> Signed-off-by: Nicolas Del Piano
> ---
> drivers/staging/octeon-usb/octeon-hcd.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Fixed a coding style error, macros with comples values should be enclosed in
parenthesis.
Signed-off-by: Nicolas Del Piano
---
drivers/staging/octeon-usb/octeon-hcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/stagin
pFifoHead points to tx_buffer->fifo_head which can never be NULL.
We also don't need to check for tx_buffer being NULL instead, since it
always points to ->Data of struct vnt_usb_send_context - the pointer to
which was checked before calling s_vGenerateTxParameter().
Silences a dereference before
This patch just backs out a change in a previous patch
that generated a new sparse warning.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dga
On 2014-04-25 at 15:11:05 +0200, Dan Carpenter wrote:
> On Fri, Apr 25, 2014 at 01:54:51PM +0200, Tobias Klauser wrote:
> > pFifoHead is dereferenced before it is checked for NULL which implies it
> > can potentially be NULL. Thus move the check before the dereference.
> >
> > Found by the coveri
On Fri, Apr 25, 2014 at 01:54:51PM +0200, Tobias Klauser wrote:
> pFifoHead is dereferenced before it is checked for NULL which implies it
> can potentially be NULL. Thus move the check before the dereference.
>
> Found by the coverity scanner, CID 1127221.
>
pFifoHead is this:
struct vnt_tx_fi
On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote:
> On 04/25/2014 07:02 AM, DaeSeok Youn wrote:
> > Hi, Dan.
> >
> > 2014-04-25 18:26 GMT+09:00 Dan Carpenter :
> >> Mark, maybe you should add yourself to the MAINTAINERS entry for this
> >> driver?
> >>
>
> I'll look into this. I am
On 04/25/2014 07:02 AM, DaeSeok Youn wrote:
> Hi, Dan.
>
> 2014-04-25 18:26 GMT+09:00 Dan Carpenter :
>> Mark, maybe you should add yourself to the MAINTAINERS entry for this
>> driver?
>>
I'll look into this. I am clueless on what that would actually mean.
>> On Fri, Apr 25, 2014 at 04:04:59PM
pFifoHead is dereferenced before it is checked for NULL which implies it
can potentially be NULL. Thus move the check before the dereference.
Found by the coverity scanner, CID 1127221.
Reported-by:
Signed-off-by: Tobias Klauser
---
drivers/staging/vt6656/rxtx.c |6 +++---
1 file changed,
Hi, Dan.
2014-04-25 18:26 GMT+09:00 Dan Carpenter :
> Mark, maybe you should add yourself to the MAINTAINERS entry for this
> driver?
>
> On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote:
>> @@ -1263,7 +1277,8 @@ static int dgap_tty_register(struct board_t *brd)
>> /* Reg
On 2014-04-25 09:18, Chase Southwood wrote:
The board supported by this driver does not have analog outputs. Remove
the subdevice init for it.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Compile tested only.
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.
On 2014-04-25 09:17, Chase Southwood wrote:
This board does not have analog inputs. Remove the subdevice init for
them.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Compile tested only. To be applied on top of
[PATCH] staging: comedi: addi_apci_1564: separate from
The coverity scanner marked these two memcpy()'s as causing a buffer
overflow in CIDs 142743 and 142744. This is due the h_dest member of
struct ethhdr being used as a target (size ETH_ALEN) in memcpy, but the
copy is of size ETH_HLEN. However, the intention here seems to be to
copy the entire ethe
On Wed, Apr 16, 2014 at 09:13:52AM +0100, Lee Jones wrote:
> It seems Max and Alex are less than interested in this patch, so I'm
> going to apply it anyway. In your last review you mentioned that it
> looked good to your inexpert eye. Can I apply your Ack to that effect?
>
Just apply it... He s
Fixed the following sparse complaints:
drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:1039:61:
warning: restricted gfp_t degrades to integer
drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:1092:61:
warning: restricted gfp_t degrades to integer
Fixed the following sparse complaints:
drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:549:22:
warning: symbol 'ldlm_srv_pool_ops' was not declared. Should it be
static?
drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:555:22:
warning: symbol '
This patchset fixes the following sparse complaints:
[1/3]: use of a plain integer as NULL pointer
[2/3]: symbols that should declared as static
[3/3]: use of an unsigned int as gfp_t
Fabio Falzoi (3):
Staging: lustre: Avoid using 0 instead of NULL
Staging: lustre: ops structs should be declar
Fixed the following sparse complaints:
drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:755:9:
warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:757:9:
warning: Using plain integer as NULL pointer
drive
Mark, maybe you should add yourself to the MAINTAINERS entry for this
driver?
On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote:
> @@ -1263,7 +1277,8 @@ static int dgap_tty_register(struct board_t *brd)
> /* Register tty devices */
> rc = tty_register_driver(
Joe Perches (5):
qlge: Convert /n to \n
iwlegacy: Convert /n to \n
staging: rtl: Convert /n to \n
appledisplay: Convert /n to \n
sound: tlv320aic31xx: Convert /n to \n
drivers/net/ethernet/qlogic/qlge/qlge_main.c | 2 +-
drivers/net/wireless/iwlegacy/3945.c | 2 +-
drivers/net
The board supported by this driver does not have analog outputs. Remove
the subdevice init for it.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Compile tested only.
drivers/staging/comedi/drivers/addi_apci_1564.c | 13 ++---
1 file changed, 2 insertions(+),
This board does not have analog inputs. Remove the subdevice init for
them.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Compile tested only. To be applied on top of
[PATCH] staging: comedi: addi_apci_1564: separate from addi_common.c
drivers/staging/comedi/driver
Patches need to be sent inline. Perhaps use git send-email.
On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote:
>
> >From 38e0d5778bd97062115e7d8a8ca40d18f3d71707 Mon Sep 17 00:00:00 2001
> From: Nicolas Del Piano
> Date: Thu, 24 Apr 2014 18:46:49 -0300
> Subject: [PATCH] Stagin
On Fri, Apr 25, 2014 at 09:13:21AM +0200, walter harms wrote:
>
>
> Am 24.04.2014 23:49, schrieb Dan Carpenter:
> > The obd_ioctl_getdata() function caps "data->ioc_len" at
> > OBD_MAX_IOCTL_BUFFER and then calls this obd_ioctl_is_invalid() to check
> > that the other values inside data are valid
Am 24.04.2014 23:49, schrieb Dan Carpenter:
> The obd_ioctl_getdata() function caps "data->ioc_len" at
> OBD_MAX_IOCTL_BUFFER and then calls this obd_ioctl_is_invalid() to check
> that the other values inside data are valid.
>
> There are several lengths inside data but when they are added toget
On 04/16/2014 04:13 PM, Lee Jones wrote:
Hi Andrew,
From: Roger Tseng
Realtek USB memstick host driver provides memstick host support based on the
Realtek USB card reader MFD driver.
Signed-off-by: Roger Tseng
---
drivers/memstick/host/Kconfig | 10 +
drivers/memstick/host/Makefi
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers which are allocated by alloc_tty_driver() and kzalloc()
can be NULL so it need to check NULL for them.
- If one of those is failed, it need to add proper handler for
avoiding memory leak.
Signed-off-by: Daeseok Yo
69 matches
Mail list logo
