> -----Original Message----- > From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev- > devel-boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan > Sent: Friday, April 25, 2014 7:24 PM > To: Eric Dumazet; Stephen Hemminger > Cc: o...@aepfle.de; net...@vger.kernel.org; jasow...@redhat.com; linux- > ker...@vger.kernel.org; sta...@kernel.org; a...@canonical.com; > de...@linuxdriverproject.org; da...@davemloft.net > Subject: RE: [PATCH net-next 1/1] hyperv: Properly handle checksum offload > > > > > -----Original Message----- > > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > > Sent: Friday, April 25, 2014 6:15 PM > > To: Stephen Hemminger > > Cc: KY Srinivasan; da...@davemloft.net; net...@vger.kernel.org; linux- > > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > > a...@canonical.com; jasow...@redhat.com; sta...@kernel.org > > Subject: Re: [PATCH net-next 1/1] hyperv: Properly handle checksum > > offload > > > > On Fri, 2014-04-25 at 17:43 -0700, Stephen Hemminger wrote: > > > On Fri, 25 Apr 2014 11:45:14 -0700 > > > "K. Y. Srinivasan" <k...@microsoft.com> wrote: > > > > > > > @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff > > > > *skb, > > struct net_device *net) > > > > csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)ppi + > > > > ppi->ppi_offset); > > > > > > > > + ip_hdr(skb)->check = 0; > > > > + csum_info->transmit.ip_header_checksum = 1; > > > > + > > > > if (net_trans_info & (INFO_IPV4 << 16)) > > > > csum_info->transmit.is_ipv4 = 1; > > > > else > > > > > > Linux doesn't need or want IP checksum offload. > > > It will not have any performance gain. > > > > > > BTW, was this patch even tested with IPv6 packets ??? > > No; I only tested this on ipv4. Oops; this would not work on ipv6. I am going to resend this patch.
K. Y > > K. Y > > > > _______________________________________________ > devel mailing list > de...@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
