On Tue, Apr 08, 2014 at 05:32:45PM +0100, Paul McQuade wrote:
> WARNING: do {} while (0) macros should not be semicolon terminated
> 
> Signed-off-by: Paul McQuade <paulmcq...@gmail.com>
> ---
>  drivers/staging/keucr/scsiglue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/keucr/scsiglue.c 
> b/drivers/staging/keucr/scsiglue.c
> index ac3d34d..fce19a4 100644
> --- a/drivers/staging/keucr/scsiglue.c
> +++ b/drivers/staging/keucr/scsiglue.c
> @@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host 
> *host)
>       do { \
>               if (us->fflags & value) \
>                       SPRINTF(" " #name); \
> -     } while (0);
> +     } while (0)
>  US_DO_ALL_FLAGS
>  #undef US_FLAG
>       seq_putc(m, '\n');

Why would you send a patch that you obviously have not at least compile
tested?

Hint, this breaks the build :(

ALWAYS test build your patches, to not do so is rude to others, don't
you agree?

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to