Re: [PATCH 4/7 RESEND] staging: et131x: reduce split lines in nic_return_rfd

2013-12-06 Thread Dan Carpenter
On Sat, Dec 07, 2013 at 09:39:07AM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang > --- > drivers/staging/et131x/et131x.c | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c > ind

[PATCH 03/10] Staging: bcm: DDRInit: added space after commas.

2013-12-06 Thread Gary Rookard
This is the third patch of a series. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 1332 - 1 file changed, 666 insertions(+), 666 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/

[PATCH 10/10] Staging: bcm: DDRInit: tidy up comments.

2013-12-06 Thread Gary Rookard
This is the tenth patch of a series. Signed-off-by:Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 231 +- 1 file changed, 116 insertions(+), 115 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DD

Re: [PATCH 1/7 RESEND] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

2013-12-06 Thread Dan Carpenter
On Sat, Dec 07, 2013 at 09:19:04AM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang > --- > drivers/staging/et131x/et131x.c | 25 +++-- > 1 file changed, 11 insertions(+), 14 deletions(-) > > diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c > i

Re: [PATCH] staging: rtl8192u: fix some type confusion

2013-12-06 Thread Dan Carpenter
On Fri, Dec 06, 2013 at 11:59:26PM -0500, Ilia Mirkin wrote: > The first 8 bytes of skb->cb are used to store a struct net_device *. > Adjust the memcpy's src/dst types to reflect that. > > Signed-off-by: Ilia Mirkin This isn't right. The correct fix is just to remove all the casting.

[PATCH] staging: rtl8192u: fix some type confusion

2013-12-06 Thread Ilia Mirkin
The first 8 bytes of skb->cb are used to store a struct net_device *. Adjust the memcpy's src/dst types to reflect that. Signed-off-by: Ilia Mirkin --- Noticed this with spatch looking for sizes in memcpy's inconsistent with the arguments. drivers/staging/rtl8192u/r8192U_core.c | 6 +++--- 1 f

[PATCH 5/9] Staging: bcm: DDRInit: replaced C99 comments.

2013-12-06 Thread Gary Rookard
This is the fifth patch of a series. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 270 +- 1 file changed, 135 insertions(+), 135 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/D

Re: [PATCH] staging: dwc2: don't issue traffic to LS devices in FS mode

2013-12-06 Thread Stephen Warren
On 12/06/2013 03:01 PM, Paul Zimmerman wrote: > From: Nick Hudson > > I fell over the problem reported in > https://github.com/raspberrypi/linux/pull/390: > > "Issuing low-speed packets when the root port is in full-speed mode > causes the root port to stop responding. Explicitly fail when > e

[PATCH 9/9] Staging: bcm: DDRInit: removed space from front of semicolon.

2013-12-06 Thread Gary Rookard
This is the ninth patch of a series. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index

[PATCH 8/9] Staging: bcm: DDRInit: tidy up indentation.

2013-12-06 Thread Gary Rookard
This is the eighth patch of a series. Signed-off-by: Gary Alan Rookard --- On branch stanging-next drivers/staging/bcm/DDRInit.c | 394 +- 1 file changed, 195 insertions(+), 199 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm

[PATCH 7/9] Staging: bcm: DDRInit: removed extra lines

2013-12-06 Thread Gary Rookard
This is the seventh patch of a series. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 163 +++--- 1 file changed, 43 insertions(+), 120 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/

[PATCH 6/9] Staging: bcm: DDRInit: tidy up bracing issues.

2013-12-06 Thread Gary Rookard
This is the sixth patch of a series. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 174 +++--- 1 file changed, 63 insertions(+), 111 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DD

[PATCH 4/9] Staging: bcm: DDRInit: added spaces around operators.

2013-12-06 Thread Gary Rookard
This is the fourth patch of a series. Signed-off-by: Gary Alan Rookard --- On branch-staging-next drivers/staging/bcm/DDRInit.c | 86 +-- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DD

[PATCH 3/9] Staging: bcm: DDRInit: added space after commas.

2013-12-06 Thread Gary Rookard
Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 1332 - 1 file changed, 666 insertions(+), 666 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index e014759..ed4dfe9 100644

[PATCH 1/9] Staging: bcm: DDRInit: Replaced spaces with tabs.

2013-12-06 Thread Gary Rookard
This is the first patch of a series. Signed:off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 398 +- 1 file changed, 199 insertions(+), 199 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/D

[PATCH 2/9] Staging: bcm: DDRInit: replaced multiple tabs with tab.

2013-12-06 Thread Gary Rookard
This is second in a series of patches. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 910 +- 1 file changed, 455 insertions(+), 455 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm

[PATCH 4/7 RESEND] staging: et131x: reduce split lines in nic_return_rfd

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 881ae4f..90ef45b 100644 --- a/drivers/staging/et131x/et131x.c +++ b/dr

[PATCH 3/7 RESEND] staging: et131x: reduce split lines in et131x_rx_dma_memory_free

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 63d28ae..881ae4f 100644 --- a/drivers/staging/et131x/et131x.c

[PATCH 1/7 RESEND] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index e3a71d3..0372f23 100644 --- a/drivers/staging/et131x/et131x.c +++ b/

[PATCH] staging: dwc2: don't issue traffic to LS devices in FS mode

2013-12-06 Thread Paul Zimmerman
From: Nick Hudson I fell over the problem reported in https://github.com/raspberrypi/linux/pull/390: "Issuing low-speed packets when the root port is in full-speed mode causes the root port to stop responding. Explicitly fail when enqueuing URBs to a LS endpoint on a FS bus." with my dwc2 tes

Re: [PATCH 7/7] staging: et131x: remove unnecessary pointer typecast

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 09:35:06PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang Thanks. Acked-by: Mark Einon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 03/13] staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt()

2013-12-06 Thread Greg KH
Minor nit, can you name your "v2" patches like: [PATCH 03/13 v2] ... so that when I sort them in mutt, they show up in the proper order with the other patches in the series? Don't worry about this one, I got it, but in the future it would be great. thanks, greg k-h __

Re: [PATCH 4/7] staging: et131x: reduce split lines in nic_return_rfd

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 08:40:17PM +, Mark Einon wrote: > On Fri, Dec 06, 2013 at 09:35:03PM +0800, ZHAO Gang wrote: > > Signed-off-by: ZHAO Gang > > --- > > drivers/staging/et131x/et131x.c | 20 +++- > > 1 file changed, 11 insertions(+), 9 deletions(-) > > > > diff --git a/d

Re: [PATCH 5/7] staging: et131x: reduce split lines in nic_rx_pkts

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 09:35:04PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang This is good, thanks. Acked-by: Mark Einon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-dev

Re: [PATCH 3/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_free

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 09:35:02PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang > --- > drivers/staging/et131x/et131x.c | 33 + > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et13

Re: [PATCH 4/7] staging: et131x: reduce split lines in nic_return_rfd

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 09:35:03PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang > --- > drivers/staging/et131x/et131x.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c > index b

Re: [PATCH 2/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_alloc

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 09:35:01PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang Acked-by: Mark Einon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 09:35:00PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang > --- > drivers/staging/et131x/et131x.c | 26 -- > 1 file changed, 12 insertions(+), 14 deletions(-) > > diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c >

[PATCHv2] iio: mxs-lradc: compute temperature from channel 8 and 9

2013-12-06 Thread Alexandre Belloni
The mxs LRADC is able to read an internal die temperature sensor. The temperature has to be calculated from the value read on channel 8 and channel 9. To be able to expose the result to hwmon, implement iio channel 8 as (channel 9 - channel 8). Then, implement IIO_CHAN_INFO_SCALE and IIO_CHAN_INFO_

[GIT PULL] Staging driver fixes for 3.13-rc3

2013-12-06 Thread Greg KH
The following changes since commit dc1ccc48159d63eca5089e507c82c7d22ef60839: Linux 3.13-rc2 (2013-11-29 12:57:14 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.13-rc3 for you to fetch changes up to 55ef003e4ae

[PATCH v3 30/31] staging: comedi: ni_pcidio: request_irq() before setting up subdevices

2013-12-06 Thread H Hartley Sweeten
Do the request_irq() before setting up the subdevices. Only hook up the command support of the irq was sucessfully requested. Note that, because of the IRQF_SHARED flag, nidio_interrupt() _may_ be called before the device is ready and the subdevices are setup. This condition is handled by the (!de

[PATCH v2 03/13] staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt()

2013-12-06 Thread H Hartley Sweeten
Unfortunatly, since there could be two asics, we can't use dev->read_subdev to get the subdevice. But, the comedi_subdevice associated with the 'asic' can easily be calculated. This allows removing the for () loop that searched for the correct subdevice. Tidy up the function. Signed-off-by: H Har

Re: [PATCH v3 30/31] staging: comedi: ni_pcidio: request_irq() before setting up subdevices

2013-12-06 Thread Ian Abbott
On 2013-12-06 16:57, H Hartley Sweeten wrote: Do the request_irq() before setting up the subdevices. Only hook up the command support of the irq was sucessfully requested. Note that, because of the IRQF_SHARED flag, nidio_interrupt() _may_ be called before the device is ready and the subdevices

RE: [PATCH v2 30/31] staging: comedi: ni_pcidio: request_irq() before seting up subdevices

2013-12-06 Thread Hartley Sweeten
On Friday, December 06, 2013 3:34 AM, Ian Abbott wrote: > On 2013-12-05 20:43, H Hartley Sweeten wrote: [snip] >> +irq = mite_irq(devpriv->mite); >> +if (irq) { >> +ret = request_irq(irq, nidio_interrupt, IRQF_SHARED, >> + dev->board_name, dev); >>

RE: [PATCH 03/13] staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt()

2013-12-06 Thread Hartley Sweeten
On Friday, December 06, 2013 1:19 AM, Dan Carpenter wrote: > > Signed-off-by is missing. Oops... Just reposted that patch with the sign off. Sorry about that, Hartley ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproje

Re: [PATCH] staging: crystalhd: Fix typo in crystalhd

2013-12-06 Thread Randy Dunlap
On 12/06/13 06:27, Masanari Iida wrote: > Correct spelling typo. > > Signed-off-by: Masanari Iida Acked-by: Randy Dunlap Thanks. > --- > drivers/staging/crystalhd/bc_dts_glob_lnx.h | 2 +- > drivers/staging/crystalhd/crystalhd_cmds.c | 2 +- > drivers/staging/crystalhd/crystalhd_cmds.h | 2

Re: [PATCH 00/13] staging: comedi: pcmuio: cleanup driver

2013-12-06 Thread Ian Abbott
On 2013-12-05 23:54, H Hartley Sweeten wrote: I orignally posted this series on 07/24/2013. At that time Ian Abbott had some comments on it. I finally got around to addressing them. This series cleans up the interrupt support and private data usage. It also does a bit of cleanup to clarify the d

Re: [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper

2013-12-06 Thread gre...@linuxfoundation.org
On Fri, Dec 06, 2013 at 08:05:38AM +0200, Ivajlo Dimitrov wrote: > Hi Greg, > > On 01.12.2013 19:07, Ivaylo DImitrov wrote: > > From: Ivaylo Dimitrov > > > > Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't > > need to be exported. It can also be made way simpler by using ss

[PATCH] staging: crystalhd: Fix typo in crystalhd

2013-12-06 Thread Masanari Iida
Correct spelling typo. Signed-off-by: Masanari Iida --- drivers/staging/crystalhd/bc_dts_glob_lnx.h | 2 +- drivers/staging/crystalhd/crystalhd_cmds.c | 2 +- drivers/staging/crystalhd/crystalhd_cmds.h | 2 +- drivers/staging/crystalhd/crystalhd_fw_if.h | 2 +- drivers/staging/crystalhd/crysta

Re: [PATCHv5][ 2/8] staging: imx-drm: Add RGB666 support for parallel display.

2013-12-06 Thread Thierry Reding
On Fri, Dec 06, 2013 at 02:29:22PM +0100, Lucas Stach wrote: > Am Freitag, den 06.12.2013, 14:14 +0100 schrieb Thierry Reding: > > On Thu, Dec 05, 2013 at 07:28:06PM +0100, Denis Carikli wrote: > > [...] > > > diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c > > > b/drivers/staging/imx-drm/ipu

[PATCH 7/7] staging: et131x: remove unnecessary pointer typecast

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 8d75a3f..1abea42 100644 --- a/drivers/staging/et131x/et131x.c +++ b/dri

[PATCH 4/7] staging: et131x: reduce split lines in nic_return_rfd

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index b6ce68e..3e34c2e 100644 --- a/drivers/staging/et131x/et131x.c +++ b/driver

[PATCH 6/7] staging: et131x: remove item that have been done in TODO file

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/README | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README index 8da96a6..3befc45 100644 --- a/drivers/staging/et131x/README +++ b/drivers/staging/et131x/README @@ -13,10 +13,6 @@

[PATCH 5/7] staging: et131x: reduce split lines in nic_rx_pkts

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 3e34c2e..8d75a3f 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/

[PATCH 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index e3a71d3..ee231f2 100644 --- a/drivers/staging/et131x/et131x.c +++ b

[PATCH 3/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_free

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 17ac711..b6ce68e 100644 --- a/drivers/staging/et131x/et131x.

[PATCH 2/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_alloc

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 48 - 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index ee231f2..17ac711 100644 --- a/drivers/staging/et131x

Re: [PATCHv5][ 2/8] staging: imx-drm: Add RGB666 support for parallel display.

2013-12-06 Thread Lucas Stach
Am Freitag, den 06.12.2013, 14:14 +0100 schrieb Thierry Reding: > On Thu, Dec 05, 2013 at 07:28:06PM +0100, Denis Carikli wrote: > [...] > > diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c > > b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c > [...] > > @@ -155,6 +156,8 @@ static int ipu_pixfmt_to_m

Re: [PATCHv5][ 5/8] staging: imx-drm: parallel display: add regulator support.

2013-12-06 Thread Thierry Reding
On Thu, Dec 05, 2013 at 07:28:09PM +0100, Denis Carikli wrote: [...] > diff --git a/drivers/staging/imx-drm/parallel-display.c > b/drivers/staging/imx-drm/parallel-display.c [...] > @@ -260,6 +275,13 @@ static int imx_pd_probe(struct platform_device *pdev) > if (ret) > return r

Re: [PATCHv5][ 2/8] staging: imx-drm: Add RGB666 support for parallel display.

2013-12-06 Thread Thierry Reding
On Thu, Dec 05, 2013 at 07:28:06PM +0100, Denis Carikli wrote: [...] > diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c > b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c [...] > @@ -155,6 +156,8 @@ static int ipu_pixfmt_to_map(u32 fmt) > return IPU_DC_MAP_BGR666; > case V4L2_PIX_

Re: [PATCHv5][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2013-12-06 Thread Thierry Reding
On Thu, Dec 05, 2013 at 07:28:07PM +0100, Denis Carikli wrote: [...] > diff --git a/arch/arm/boot/dts/imx51-apf51dev.dts > b/arch/arm/boot/dts/imx51-apf51dev.dts > index f36a3aa..3b6de6a 100644 > --- a/arch/arm/boot/dts/imx51-apf51dev.dts > +++ b/arch/arm/boot/dts/imx51-apf51dev.dts > @@ -19,7 +19

Re: [PATCH v2 00/31] staging: comedi: cleanup irq requests

2013-12-06 Thread Ian Abbott
On 2013-12-05 20:43, H Hartley Sweeten wrote: The comedi subsystem only requires the drivers to support interrupts if one or more of the subdevices support async commands. Since this is optional: 1) don't fail the attach if the irq is not available 2) only hookup the async command support if the

Re: [PATCH v2 30/31] staging: comedi: ni_pcidio: request_irq() before seting up subdevices

2013-12-06 Thread Ian Abbott
On 2013-12-05 20:43, H Hartley Sweeten wrote: Do the request_irq() before setting up the subdevices. Only hook up the command support of the irq was sucessfully requested. Note that, because of the IRQF_SHARED flag, nidio_interrupt() _may_ be called before the device is ready and the subdevices

Re: [PATCH v2 01/31] staging: comedi: ni_at_2150: tidy up irq/dma request

2013-12-06 Thread Ian Abbott
On 2013-12-05 20:43, H Hartley Sweeten wrote: This driver needs both an irq and dma in order to support async commands. If the irq and dma are not available the driver will still function for single analog input reads. Tidy up the code that does the irq and dma requests so that the driver will s

Re: [PATCH 03/13] staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt()

2013-12-06 Thread Dan Carpenter
On Thu, Dec 05, 2013 at 04:54:05PM -0700, H Hartley Sweeten wrote: > Unfortunatly, since there could be two asics, we can't use dev->read_subdev > to get the subdevice. But, the comedi_subdevice associated with the 'asic' > can easily be calculated. This allows removing the for () loop that searche