On 2013-12-05 23:54, H Hartley Sweeten wrote:
I orignally posted this series on 07/24/2013. At that time Ian Abbott had some comments on it. I finally got around to addressing them.This series cleans up the interrupt support and private data usage. It also does a bit of cleanup to clarify the driver. H Hartley Sweeten (13): staging: comedi: pcmuio: fix interrupt requests staging: comedi: pcmuio: spinlock protect pcmuio_{write,read}() staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt() staging: comedi: pcmuio: remove 'asic' member from subdevice private data staging: comedi: pcmuio: remove subdevice private data staging: comedi: pcmuio: fix pcmuio_dio_insn_bits() staging: comedi: pcmuio: remove unnecessary mask of triggered channels staging: comedi: pcmuio: add inline helpers to get the 'iobase', 'asic', and 'port' staging: comedi: pcmuio: document the spinlock_t variables staging: comedi: pcmuio: fix types of some private data variables staging: comedi: pcmuio: remove unneeded include staging: comedi: pcmuio: tidy up pcmuio_attach() staging: comedi: pcmuio: tidy up pcmuio_start_intr() drivers/staging/comedi/drivers/pcmuio.c | 428 ++++++++++++++++---------------- 1 file changed, 213 insertions(+), 215 deletions(-)
Looks good! Just needs the Signed-off-by line on patch 03, as spotted by Dan Carpenter.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
