Return negative error codes as is followed in the rest of the
kernel.
Signed-off-by: Sachin Kamat
---
drivers/staging/cxt1e1/linux.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index 598e6ba..9b48373 10064
Pointers should be assigned NULL instead of 0.
Signed-off-by: Sachin Kamat
---
drivers/staging/cxt1e1/sbecrc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cxt1e1/sbecrc.c b/drivers/staging/cxt1e1/sbecrc.c
index 87512a5..81fa8a3 100644
--- a/drivers/
Pointers should be assigned NULL instead of 0.
Signed-off-by: Sachin Kamat
---
drivers/staging/cxt1e1/sbeid.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/cxt1e1/sbeid.c b/drivers/staging/cxt1e1/sbeid.c
index 791993f..6ec51bc 100644
--- a/drivers/staging
Return negative error codes as is followed in the rest of the
kernel.
Signed-off-by: Sachin Kamat
---
drivers/staging/cxt1e1/musycc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cxt1e1/musycc.c b/drivers/staging/cxt1e1/musycc.c
index a2a2af1..0ba8c3
Pointers should be assigned NULL instead of 0.
Signed-off-by: Sachin Kamat
---
drivers/staging/cxt1e1/hwprobe.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index 53e9237..2f4f051 100644
--- a/drive
Pointers should be assigned NULL instead of 0.
Signed-off-by: Sachin Kamat
---
Most of the patches in this series will give checkpatch errors related
to spacing and indentation. This is because the driver does not follow
the spacing/indentation guidelines provided for the kernel. Fixing the
white
Pointers should be assigned NULL instead of 0.
Signed-off-by: Sachin Kamat
---
drivers/staging/cxt1e1/linux.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index 142691c..598e6ba
Return negative error codes as is followed in the rest of the
kernel.
Signed-off-by: Sachin Kamat
---
drivers/staging/cxt1e1/hwprobe.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index 2f4f05
Functions returning pointer should return NULL instead of 0.
Signed-off-by: Sachin Kamat
---
drivers/staging/cxt1e1/sbecom_inline_linux.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cxt1e1/sbecom_inline_linux.h
b/drivers/staging/cxt1e1/sbecom_inlin
Pointers should be assigned NULL instead of 0.
Signed-off-by: Sachin Kamat
---
drivers/staging/cxt1e1/sbeproc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/cxt1e1/sbeproc.c b/drivers/staging/cxt1e1/sbeproc.c
index 9361dd8..353c001 100644
--- a/drivers/s
Pointers should be assigned NULL instead of 0.
Signed-off-by: Sachin Kamat
---
drivers/staging/cxt1e1/pmcc4_drv.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/cxt1e1/pmcc4_drv.c
b/drivers/staging/cxt1e1/pmcc4_drv.c
index 2383c60..4028ea1
Hi Russell,
Thank you for the patch.
On Thursday 19 September 2013 22:56:02 Russell King wrote:
> The code sequence:
> isp->raw_dmamask = DMA_BIT_MASK(32);
> isp->dev->dma_mask = &isp->raw_dmamask;
> isp->dev->coherent_dma_mask = DMA_BIT_MASK(32);
> bypasses the architectures ch
Your Email Id Have Won 1,000,000.00 GBP From Chevrolet Company Promo Award
2013.Details required:Full Name,Address,Country/Nationality,Occupation,
Age/Sex,Tel,Identity Proof.(Winning SERIAL NO: 81809/co/npo/uk)
___
devel mailing list
de...@linuxdriverpro
On Thu, Sep 26, 2013 at 6:22 AM, Dan Carpenter wrote:
> On Wed, Sep 25, 2013 at 07:08:54PM -0400, Lidza Louina wrote:
>> This patch removes this smatch warning:
>> unsigned '--un->un_open_count' is never less than zero
>>
>> The code decremented the un_open_count variable
>> and tested to see if i
On Thu, Sep 26, 2013 at 6:19 AM, Dan Carpenter wrote:
> This one is not right.
>
> On Wed, Sep 25, 2013 at 07:08:53PM -0400, Lidza Louina wrote:
>> This patch changes error handling to the
>> tty_driver allocations in dgap_tty_register.
>>
>> Before, it didn't handle the possibility of an
>> alloc
Greg,
I am currently travelling; when I get back I will take a look.
K. Y
> -Original Message-
> From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, September 26, 2013 9:00 AM
> To: KY Srinivasan
> Cc: Haiyang Zhang; de...@linuxdriverproject.org; linux-ker...@v
2013/9/19 Russell King - ARM Linux :
> This email is only being sent to the mailing lists in question, not to
> anyone personally. The list of individuals is far to great to do that.
> I'm hoping no mailing lists reject the patches based on the number of
> recipients.
Huh, I think it was enough t
Introduce a couple defines for the common 8254 oscillator base values
used in the comedi drivers and remove the custom defines and open
coded values.
Change the i8253_cascade_ns_to_timer_2div() calls in the drivers to
the more generic i8253_cascade_ns_to_timer(). They are identical due
to the #def
Rename these functions so they have namespace associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl726.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/stag
As pointed out by the kbuild test robot, the ni_atmio driver includes
ni_mio_common.c which uses the helper functions in the comedi_fc module.
Select the COMEDI_FC module when COMEDI_NI_ATMIO is enabled to fix the
following build error:
ERROR: "cfc_write_array_to_buffer" [drivers/staging/comedi/d
As pointed out by Fengguang Wu, the calls to dt2801_readdata() return the
data read thru a pointer (the address of a local variable) passed as a
parameter. If this local variable is not initialized it produces a warning
during the build of the form:
drivers/staging/comedi/drivers/dt2801.c: In func
On Wed, Sep 25, 2013 at 07:08:50PM -0400, Lidza Louina wrote:
> This patch removes these smatch warnings from dgap_driver.c:
>
> redundant null check on dgap_config_buf calling kfree()
> redundant null check on brd->flipbuf calling kfree()
> redundant null check on brd->flipflagbuf calling kfree()
On Wed, Sep 25, 2013 at 07:08:52PM -0400, Lidza Louina wrote:
> This patch removes these smatch warnings:
> redundant null check on dgap_TmpWriteBuf calling kfree()
> redundant null check on brd->SerialDriver->ttys calling kfree()
> redundant null check on brd->PrintDriver->ttys calling kfree()
>
On Wed, Sep 25, 2013 at 07:08:51PM -0400, Lidza Louina wrote:
> This patch removes this smatch warning:
> info: ignoring unreachable code.
>
> There were instances where there was extra code after
> the default action in switch statements. These default
> actions ended with a break so the code was
On Thu, Sep 26, 2013 at 04:19:49PM +, Hartley Sweeten wrote:
> On Thursday, September 26, 2013 2:45 AM, Ian Abbott wrote:
> > On 2013-09-25 23:34, H Hartley Sweeten wrote:
> >> Cleanup another comedi driver.
> >>
> >> Add support for the external interrupt on the ACL-6126 board.
> >>
> >> H Har
On Thursday, September 26, 2013 2:17 AM, Ian Abbott wrote:
> As noted by Hartley in
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-September/041560.html
> async command support (for the AI subdevice) is broken. This small
> series of patches should get it working.
>
> 1)
On Thursday, September 26, 2013 2:45 AM, Ian Abbott wrote:
> On 2013-09-25 23:34, H Hartley Sweeten wrote:
>> Cleanup another comedi driver.
>>
>> Add support for the external interrupt on the ACL-6126 board.
>>
>> H Hartley Sweeten (19):
>>staging: comedi: pcl726: convert boardinfo declaration
Fix spelling typo in comments.
Masanari Iida (4):
staging: rtl8188eu: Fix typo in rtl8188eu/include
staging: rtl8188eu: Fix typo in rtl8188eu/core
staging: rtl8188eu: Fix typo in rtl8188eu/hal
staging: rtl8188eu: Fix typo in rtl8188eu/os_dep
drivers/staging/rtl8188eu/core/rtw_ap.c
On Tue, Sep 17, 2013 at 06:42:30PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org]
> > Sent: Friday, September 13, 2013 11:33 AM
> > To: KY Srinivasan; Haiyang Zhang
> > Cc: de...@linuxdriverproject.org; linux-ker...@
Correct spelling typo in rtl8188eu/hal
Signed-off-by: Masanari Iida
---
drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c | 2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 8
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 4 ++--
drivers/staging/rtl8188eu/hal/rtl8188e_
Correct spelling typo in rtl8188eu/os_dep
Signed-off-by: Masanari Iida
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 12 ++--
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +-
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 2 +-
3 files changed, 8 insertions(+), 8 d
Correct spelling typo in rtl8188eu/core
Signed-off-by: Masanari Iida
# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
# On branch rtl8188eu-typo2
# Changes to be committe
Correct spelling typo in rtl8188eu/include
Signed-off-by: Masanari Iida
---
drivers/staging/rtl8188eu/include/Hal8188EPhyReg.h| 2 +-
drivers/staging/rtl8188eu/include/odm_debug.h | 2 +-
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
drivers/staging/rtl8188eu/inclu
On Thu, Sep 26, 2013 at 12:18:34PM +0200, Dominik Paulus wrote:
> > I think a return of zero should mean total = -EBADMSG;. In other words
> > this check should be "if (ret < 0) {" and we hit the next else if.
> > Same below again.
>
> As we are wrapping kernel_recvmsg here, we wanted to leave th
On Thu, Sep 26, 2013 at 12:48:35PM +0200, Alexander Holler wrote:
> Am 26.09.2013 12:41, schrieb Dan Carpenter:
> >Anton, I already told you politely in a private email that you are being
> >offtopic. This is professional email list for programmers. Most of us
> >are forbidden to discuss laws exc
Hi,
On Friday 20 September 2013 04:41 AM, Russell King wrote:
The correct way for a driver to specify the coherent DMA mask is
not to directly access the field in the struct device, but to use
dma_set_coherent_mask(). Only arch and bus code should access this
member directly.
Convert all direc
Am 26.09.2013 12:41, schrieb Dan Carpenter:
Anton, I already told you politely in a private email that you are being
offtopic. This is professional email list for programmers. Most of us
are forbidden to discuss laws except with our corporate legal dept.
None of us are lawyers. We're not quali
Anton, I already told you politely in a private email that you are being
offtopic. This is professional email list for programmers. Most of us
are forbidden to discuss laws except with our corporate legal dept.
None of us are lawyers. We're not qualified to read any of your links
or interpret ho
On Wed, Sep 25, 2013 at 07:08:54PM -0400, Lidza Louina wrote:
> This patch removes this smatch warning:
> unsigned '--un->un_open_count' is never less than zero
>
> The code decremented the un_open_count variable
> and tested to see if it was less than zero. Because
> un_open_count is unsigned and
This one is not right.
On Wed, Sep 25, 2013 at 07:08:53PM -0400, Lidza Louina wrote:
> This patch changes error handling to the
> tty_driver allocations in dgap_tty_register.
>
> Before, it didn't handle the possibility of an
> alloc_tty_driver failure. This patch makes
> dgap_register_driver ret
Hi,
thank you very much for your feedback!
On Mon, Sep 23, 2013 at 12:59:29PM +0300, Dan Carpenter wrote:
> > + while (total < size) {
> > + uint32_t packetsize;
> > + struct kvec recvvec;
> > +
> > + /*
> > +* We use a global kfifo to buffer unrequeste
On 2013-09-25 23:34, H Hartley Sweeten wrote:
Cleanup another comedi driver.
Add support for the external interrupt on the ACL-6126 board.
H Hartley Sweeten (19):
staging: comedi: pcl726: convert boardinfo declaration to C99 format
staging: comedi: core: introduce comedi_chan_range_is_{bi
The interrupt handler used to support asynchronous commands on the AI
subdevice currently marks the command as finished (setting the "end of
acquisition" event flag and returning to software-triggered acquisition
mode) once it has decremented `devpriv->ntrig` to 0. However, nothing
sets `devpriv->
The asynchronous command support for the AI subdevice is still missing
one crucial element, it doesn't actually put the acquired data in the
buffer so it can be read()! Call `comedi_buf_put()` from the interrupt
handler to perform this function. A return value of 0 from
`comedi_buf_put()` means t
As noted by Hartley in
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-September/041560.html
async command support (for the AI subdevice) is broken. This small
series of patches should get it working.
1) staging: comedi: pcl711: add AI cancel handler
2) staging: comedi: pcl
Comedi subdevices that support asynchronous commands should have a
'cancel' handler to stop an in-progress command. Add such a handler to
the pcl711 driver module. I think merely setting the acquisition mode
to "software-triggered" would be sufficient, but also clear the
interrupt status for good
At Thu, 26 Sep 2013 10:25:13 +0200,
Takashi Iwai wrote:
>
> At Thu, 26 Sep 2013 08:54:25 +0100,
> Russell King - ARM Linux wrote:
> >
> > On Thu, Sep 26, 2013 at 09:51:23AM +0200, Takashi Iwai wrote:
> > > Hi,
> > >
> > > sorry for the lat response, as I've been traveling in the last weeks.
> >
At Thu, 26 Sep 2013 08:54:25 +0100,
Russell King - ARM Linux wrote:
>
> On Thu, Sep 26, 2013 at 09:51:23AM +0200, Takashi Iwai wrote:
> > Hi,
> >
> > sorry for the lat response, as I've been traveling in the last weeks.
> >
> > At Thu, 19 Sep 2013 22:53:02 +0100,
> > Russell King wrote:
> > >
>
On Thu, Sep 26, 2013 at 09:51:23AM +0200, Takashi Iwai wrote:
> Hi,
>
> sorry for the lat response, as I've been traveling in the last weeks.
>
> At Thu, 19 Sep 2013 22:53:02 +0100,
> Russell King wrote:
> >
> > This code sequence is unsafe in modules:
> >
> > static u64 mask = DMA_BIT_MASK(som
Hi,
On 25 Sep 2013, at 23:29, Alexander Holler wrote:
> Am 26.09.2013 00:10, schrieb Greg Kroah-Hartman:
>> Please stick to technical discussions about the code on the kernel
>> mailing lists. Legal discussions can be left up to the lawyers, of
>> which we are not.
>
> Hmm, but I would like to
Hi,
sorry for the lat response, as I've been traveling in the last weeks.
At Thu, 19 Sep 2013 22:53:02 +0100,
Russell King wrote:
>
> This code sequence is unsafe in modules:
>
> static u64 mask = DMA_BIT_MASK(something);
> ...
> if (!dev->dma_mask)
> dev->dma_mask = &mask;
Hi,
On 25 Sep 2013, at 23:10, Greg Kroah-Hartman wrote:
> On Wed, Sep 25, 2013 at 10:44:15PM +0100, Anton Altaparmakov wrote:
>> On 25 Sep 2013, at 21:21, Greg Kroah-Hartman
>> wrote:
>>> On Wed, Sep 25, 2013 at 09:28:56PM +0200, Alexander Holler wrote:
Maybe a silly question, but is
52 matches
Mail list logo
