On 2013-09-25 23:34, H Hartley Sweeten wrote:
Cleanup another comedi driver.Add support for the external interrupt on the ACL-6126 board. H Hartley Sweeten (19): staging: comedi: pcl726: convert boardinfo declaration to C99 format staging: comedi: core: introduce comedi_chan_range_is_{bi,uni}polar() staging: comedi: pcl726: remove 'bipolar' from the private data staging: comedi: pcl726: tidy up pcl726_ao_insn() staging: comedi: pcl726: tidy up pcl726_ao_insn_read() staging: comedi: pcl726: remove all '= 0' boardinfo staging: comedi: pcl726: enable the interrupt support code staging: comedi: pcl726: fix the analog output range_table_list initialization staging: comedi: pcl726: tidy up pcl726_attach() staging: comedi: pcl726: remove digital i/o register offsets from boardinfo staging: comedi: pcl726: tidy up the comedi_lrange code staging: comedi: pcl726: rename boardinfo 'IRQbits' staging: comedi: pcl726: remove unnecessary comments in boardinfo definition staging: comedi: pcl726: remove the *_SIZE defines staging: comedi: pcl726: final tidy up of boardinfo staging: comedi: pcl726: add support for the external interrupt signal staging: comedi: pcl726: tidy up multi-line comments staging: comedi: pcl726: update MODULE_DESCRIPTION staging: comedi: pcl726: rename 'boardtypes' drivers/staging/comedi/comedidev.h | 14 + drivers/staging/comedi/drivers/pcl726.c | 581 +++++++++++++++++++------------- 2 files changed, 359 insertions(+), 236 deletions(-)
Looks okay. The various identifiers prefixed with "pcl818_" (patches 07 and 16) seems a poor choice though.
Reviewed-by: Ian Abbott <abbo...@mev.co.uk> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
