[PATCH v3 01/12] gpu: ipu-cpmem: Add ipu_cpmem_set_uv_offset()

2016-08-01 Thread Steve Longerbeam
On 08/01/2016 02:13 AM, Philipp Zabel wrote: > Am Sonntag, den 31.07.2016, 12:42 -0700 schrieb Steve Longerbeam: >> Adds ipu_cpmem_set_uv_offset(), to set planar U/V offsets. >> >> Signed-off-by: Steve Longerbeam > There is no need to resend already applied patches. >

[PATCH v3 10/12] gpu: ipu-v3: Add FSU channel linking support

2016-08-01 Thread Steve Longerbeam
On 08/01/2016 02:13 AM, Philipp Zabel wrote: > Am Sonntag, den 31.07.2016, 12:42 -0700 schrieb Steve Longerbeam: >> Adds functions to link and unlink source channels to sink >> channels in the FSU: >> >> int ipu_fsu_link(struct ipu_soc *ipu, int src_ch, int sink_ch); &

[PATCH v3 09/12] gpu: ipu-v3: Add Video Deinterlacer unit

2016-08-01 Thread Steve Longerbeam
On 08/01/2016 02:13 AM, Philipp Zabel wrote: > > Please remove the unused headers. I think you can remove all but > export.h, types.h, errno.h, and io.h. > Other than that, the patch now looks fine to me. > I was able to prune all but io.h, the rest is provided by ipu-prv.h. Steve

[PATCH v2 11/13] gpu: ipu-ic: Add complete image conversion support with tiling

2016-08-03 Thread Steve Longerbeam
On 08/01/2016 02:29 AM, Philipp Zabel wrote: > Am Donnerstag, den 28.07.2016, 16:09 -0700 schrieb Steve Longerbeam: >>> Now split the frame in half and suddenly pixel x' = 640 is the start of >>> a new tile, so it is sampled at x = 160, and pixel x' = 1279 will be

[PATCH v4 0/4] IPUv3 prep for i.MX5/6 v4l2 staging drivers, v4

2016-08-17 Thread Steve Longerbeam
. Steve Longerbeam (4): gpu: ipu-v3: Add Video Deinterlacer unit gpu: ipu-v3: Add FSU channel linking support gpu: ipu-ic: Add complete image conversion support with tiling gpu: ipu-ic: allow multiple handles to ic drivers/gpu/ipu-v3/Makefile |2 +- drivers/gpu/ipu-v3/ipu-common.c

[PATCH v4 1/4] gpu: ipu-v3: Add Video Deinterlacer unit

2016-08-17 Thread Steve Longerbeam
Adds the Video Deinterlacer (VDIC) unit. Signed-off-by: Steve Longerbeam --- v4: - pruned included headers. v3: - renamed and exported ipu_vdi_set_top_field_man() to ipu_vdi_set_field_order(). Args include std and field to determine correct field order. - exported ipu_vdi_set_motion

[PATCH v4 3/4] gpu: ipu-ic: Add complete image conversion support with tiling

2016-08-17 Thread Steve Longerbeam
void ipu_image_convert_unprepare(struct image_converter_ctx *ctx); Unprepares the conversion context. Any active or pending runs will be aborted by calling image_convert_abort(). Signed-off-by: Steve Longerbeam --- v4: - do away with struct ipu_ic_tile_off, and move tile offsets into struct ipu_ic

[PATCH v4 4/4] gpu: ipu-ic: allow multiple handles to ic

2016-08-17 Thread Steve Longerbeam
handle to the IC at a time, so we should be ok there. Signed-off-by: Steve Longerbeam --- v4: no changes v3: no changes v2: no changes --- drivers/gpu/ipu-v3/ipu-ic.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b/drivers

[PATCH v4 2/4] gpu: ipu-v3: Add FSU channel linking support

2016-08-17 Thread Steve Longerbeam
SI_DIRECT -> IPUV3_CHANNEL_CSI_VDI_PREV More links can be added to the fsu_link_info[] array. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-common.c | 131 drivers/gpu/ipu-v3/ipu-prv.h| 27 + include/video/imx-ipu-v3.h | 13 3 files changed, 17

[PATCH v8 4/5] gpu: ipu-v3: ipu-ic-csc: Add support for Rec.709 encoding

2019-05-21 Thread Steve Longerbeam
Add support for Rec.709 encoding and inverse encoding. Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam --- Changes in v7: - moved CSC tables to new module ipu-ic-csc.c. - express negative coefficients as true signed int's, for better readability. Changes in v5: - moved API chang

[PATCH v8 1/5] gpu: ipu-v3: ipu-ic: Fix saturation bit offset in TPMEM

2019-05-21 Thread Steve Longerbeam
The saturation bit was being set at bit 9 in the second 32-bit word of the TPMEM CSC. This isn't correct, the saturation bit is bit 42, which is bit 10 of the second word. Fixes: 1aa8ea0d2bd5d ("gpu: ipu-v3: Add Image Converter unit") Signed-off-by: Steve Longerbeam Reviewed-by

[PATCH v8 2/5] gpu: ipu-v3: ipu-ic: Fully describe colorspace conversions

2019-05-21 Thread Steve Longerbeam
mments are expanded in ipu-ic-csc.c. The ic_csc_rgb2rgb table was just an identity matrix, so it is renamed 'identity' in ipu-ic-csc.c. Signed-off-by: Steve Longerbeam --- Changes in v8: - remove Fixes: and cc: stable. This patch is too difficult to backport to stable trees. Changes i

[PATCH v8 3/5] gpu: ipu-v3: ipu-ic-csc: Add support for limited range encoding

2019-05-21 Thread Steve Longerbeam
Add support for encodings to or from limited range quantization. Signed-off-by: Steve Longerbeam --- Changes in v7: - hard-code the coefficients instead of deriving the limited range coefficients from the full2full coefficients on the fly with fixed-point math. - add support for RGB limited

[PATCH v7 3/5] gpu: ipu-v3: ipu-ic-csc: Add support for limited range encoding

2019-04-06 Thread Steve Longerbeam
Add support for encodings to or from limited range quantization. Signed-off-by: Steve Longerbeam --- Changes in v7: - hard-code the coefficients instead of deriving the limited range coefficients from the full2full coefficients on the fly with fixed-point math. - add support for RGB limited

[PATCH v7 4/5] gpu: ipu-v3: ipu-ic-csc: Add support for Rec.709 encoding

2019-04-06 Thread Steve Longerbeam
Add support for Rec.709 encoding and inverse encoding. Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam --- Changes in v7: - moved CSC tables to new module ipu-ic-csc.c. - express negative coefficients as true signed int's, for better readability. Changes in v5: - moved API chang

[PATCH v7 1/5] gpu: ipu-v3: ipu-ic: Fix saturation bit offset in TPMEM

2019-04-06 Thread Steve Longerbeam
The saturation bit was being set at bit 9 in the second 32-bit word of the TPMEM CSC. This isn't correct, the saturation bit is bit 42, which is bit 10 of the second word. Fixes: 1aa8ea0d2bd5d ("gpu: ipu-v3: Add Image Converter unit") Signed-off-by: Steve Longerbeam Reviewed-by

[PATCH v7 2/5] gpu: ipu-v3: ipu-ic: Fully describe colorspace conversions

2019-04-06 Thread Steve Longerbeam
mments are expanded in ipu-ic-csc.c. The ic_csc_rgb2rgb table was just an identity matrix, so it is renamed 'identity' in ipu-ic-csc.c. Fixes: 1aa8ea0d2bd5d ("gpu: ipu-v3: Add Image Converter unit") Signed-off-by: Steve Longerbeam Cc: sta...@vger.kernel.org --- Cha

[PATCH 2/3] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-04 Thread Steve Longerbeam
Pass v4l2 encoding enum to the ipu_ic task init functions, and add support for the BT.709 encoding and inverse encoding matrices. Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 67 ++--- drivers/gpu/ipu-v3/ipu-image

[PATCH 1/3] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices

2019-02-04 Thread Steve Longerbeam
The ycbcr2rgb and inverse rgb2ycbcr matrices define the BT.601 encoding coefficients, so rename them to indicate that. And add some comments to make clear these are BT.601 coefficients encoding between YUV limited range and RGB full range. No functional changes. Signed-off-by: Steve Longerbeam

[PATCH v2 2/4] gpu: ipu-v3: ipu-ic: Simplify selection of encoding matrix

2019-02-09 Thread Steve Longerbeam
Simplify the selection of the Y'CbCr encoding matrices in init_csc(). A side-effect of this change is that init_csc() now allows YUV->YUV using the identity matrix, intead of returning error. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 12 1 file ch

[PATCH v3 1/4] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices

2019-02-09 Thread Steve Longerbeam
rename to ic_csc_identity. No functional changes. Signed-off-by: Steve Longerbeam --- Changes in v2: - rename ic_csc_rgb2rgb matrix to ic_csc_identity. --- drivers/gpu/ipu-v3/ipu-ic.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu

[PATCH v4 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-09 Thread Steve Longerbeam
Pass v4l2 encoding enum to the ipu_ic task init functions, and add support for the BT.709 encoding and inverse encoding matrices. Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam --- Changes in v4: - fix compile error. Chnges in v3: - none. Changes in v2: - only return "Unsupported

Re: [PATCH 2/3] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-09 Thread Steve Longerbeam
On 2/8/19 8:24 AM, Tim Harvey wrote: On Sun, Feb 3, 2019 at 11:48 AM Steve Longerbeam wrote: Pass v4l2 encoding enum to the ipu_ic task init functions, and add support for the BT.709 encoding and inverse encoding matrices. Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam

[PATCH v2 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-09 Thread Steve Longerbeam
From: Steve Longerbeam Pass v4l2 encoding enum to the ipu_ic task init functions, and add support for the BT.709 encoding and inverse encoding matrices. Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam --- Changes in v2: - only return "Unsupported YCbCr encoding" error if i

[PATCH v2 1/4] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices

2019-02-09 Thread Steve Longerbeam
From: Steve Longerbeam The ycbcr2rgb and inverse rgb2ycbcr matrices define the BT.601 encoding coefficients, so rename them to indicate that. And add some comments to make clear these are BT.601 coefficients encoding between YUV limited range and RGB full range. The ic_csc_rgb2rgb matrix is just

[PATCH v4 1/4] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices

2019-02-09 Thread Steve Longerbeam
rename to ic_csc_identity. No functional changes. Signed-off-by: Steve Longerbeam --- Changes in v2: - rename ic_csc_rgb2rgb matrix to ic_csc_identity. --- drivers/gpu/ipu-v3/ipu-ic.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu

[PATCH v3 2/4] gpu: ipu-v3: ipu-ic: Simplify selection of encoding matrix

2019-02-09 Thread Steve Longerbeam
Simplify the selection of the Y'CbCr encoding matrices in init_csc(). A side-effect of this change is that init_csc() now allows YUV->YUV using the identity matrix, intead of returning error. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 12 1 file ch

[PATCH v3 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-09 Thread Steve Longerbeam
Pass v4l2 encoding enum to the ipu_ic task init functions, and add support for the BT.709 encoding and inverse encoding matrices. Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam --- Changes in v2: - only return "Unsupported YCbCr encoding" error if inf != outf, since if i

[PATCH v4 2/4] gpu: ipu-v3: ipu-ic: Simplify selection of encoding matrix

2019-02-09 Thread Steve Longerbeam
Simplify the selection of the Y'CbCr encoding matrices in init_csc(). A side-effect of this change is that init_csc() now allows YUV->YUV using the identity matrix, intead of returning error. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 12 1 file ch

Re: [PATCH v3 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-09 Thread Steve Longerbeam
On 2/8/19 4:20 PM, Tim Harvey wrote: On Fri, Feb 8, 2019 at 11:28 AM Steve Longerbeam wrote: if (inf == outf) params = &ic_csc_identity; else if (inf == IPUV3_COLORSPACE_YUV) - params = &ic_csc_ycbcr2rgb_bt601; +

Re: [PATCH v4 1/4] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices

2019-02-12 Thread Steve Longerbeam
Hi Philipp, On 2/11/19 1:58 AM, Philipp Zabel wrote: On Fri, 2019-02-08 at 17:47 -0800, Steve Longerbeam wrote: The ycbcr2rgb and inverse rgb2ycbcr matrices define the BT.601 encoding coefficients, so rename them to indicate that. And add some comments to make clear these are BT.601

Re: [PATCH v6] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-09 Thread Steve Longerbeam
Please disregard. This patch can't be submitted stand-alone, I will re-submit as part of a v6 of "imx-media: Fixes for interlaced capture" patchset. Steve On 12/14/18 3:46 PM, Steve Longerbeam wrote: The function ipu_csi_init_interface() was inverting the F-bit for NT

[PATCH v6 03/12] gpu: ipu-v3: Add planar support to interlaced scan

2019-01-09 Thread Steve Longerbeam
doubled, since a single chroma line is shared by two luma lines. Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel Acked-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-cpmem.c | 26 +++-- drivers/staging/media/imx/imx-ic-prpencvf.c | 3 ++- drivers/staging/media

[PATCH v6 02/12] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-09 Thread Steve Longerbeam
lines for one field. Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel --- Changes since v5: - Convert to const the infmt, outfmt, and mbus_cfg pointer args to ipu_csi_init_interface(), suggested by Philipp Zabel. - Bring back if_fmt local var and don't copy outfmt to local sta

[PATCH v8 02/11] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-10 Thread Steve Longerbeam
lines for one field. Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel Acked-by: Philipp Zabel --- Changes since v5: - Convert to const the infmt, outfmt, and mbus_cfg pointer args to ipu_csi_init_interface(), suggested by Philipp Zabel. - Bring back if_fmt local var and don't

[PATCH v7 02/11] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-10 Thread Steve Longerbeam
lines for one field. Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel --- Changes since v5: - Convert to const the infmt, outfmt, and mbus_cfg pointer args to ipu_csi_init_interface(), suggested by Philipp Zabel. - Bring back if_fmt local var and don't copy outfmt to local sta

[PATCH v7 03/11] gpu: ipu-v3: Add planar support to interlaced scan

2019-01-10 Thread Steve Longerbeam
doubled, since a single chroma line is shared by two luma lines. Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel Acked-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-cpmem.c | 26 +++-- drivers/staging/media/imx/imx-ic-prpencvf.c | 3 ++- drivers/staging/media

[PATCH v8 03/11] gpu: ipu-v3: Add planar support to interlaced scan

2019-01-10 Thread Steve Longerbeam
doubled, since a single chroma line is shared by two luma lines. Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel Acked-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-cpmem.c | 26 +++-- drivers/staging/media/imx/imx-ic-prpencvf.c | 3 ++- drivers/staging/media

[PATCH v5 4/7] gpu: ipu-v3: ipu-ic: Add support for Rec.709 encoding

2019-02-19 Thread Steve Longerbeam
Add support for Rec.709 encoding and inverse encoding. The determination of the CSC coefficients based on the input/output colorspace parameters are moved to a new function calc_csc_coeffs(). Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam --- Changes in v5: - moved API changes to a

[PATCH v5 1/7] gpu: ipu-v3: ipu-ic: Fix saturation bit offset in TPMEM

2019-02-19 Thread Steve Longerbeam
The saturation bit was being set at bit 9 in the second 32-bit word of the TPMEM CSC. This isn't correct, the saturation bit is bit 42, which is bit 10 of the second word. Fixes: 1aa8ea0d2bd5d ("gpu: ipu-v3: Add Image Converter unit") Signed-off-by: Steve Longerbeam Cc: sta...@

[PATCH v5 3/7] gpu: ipu-v3: ipu-ic: Fully describe colorspace conversions

2019-02-19 Thread Steve Longerbeam
nge. - can only encode using BT.601 standard (follow-up patch will add Rec.709 encoding support). - cannot convert colorspaces from input to output, the input and output colorspace chromaticities must be the same. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c

[PATCH v5 5/7] gpu: ipu-v3: ipu-ic: Add support for limited range encoding

2019-02-19 Thread Steve Longerbeam
RGB limited-range coefficients. [M_b, O_b] = YUV limited-range to YUV full-range coefficients. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 281 +--- 1 file changed, 263 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b

[PATCH v5 2/7] gpu: ipu-v3: ipu-ic: Fix BT.601 coefficients

2019-02-19 Thread Steve Longerbeam
Converter unit") Suggested-by: Philipp Zabel Signed-off-by: Steve Longerbeam Cc: sta...@vger.kernel.org --- drivers/gpu/ipu-v3/ipu-ic.c | 63 ++--- 1 file changed, 38 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b/drivers/gpu/ipu-v3

[PATCH v6 4/7] gpu: ipu-v3: ipu-ic: Add support for Rec.709 encoding

2019-03-07 Thread Steve Longerbeam
Add support for Rec.709 encoding and inverse encoding. Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam --- Changes in v5: - moved API changes to a previous patch. - moved CSC coeff calc to new function calc_csc_coeffs(). Changes in v4: - fix compile error. Chnges in v3: - none. Changes

[PATCH v6 3/7] gpu: ipu-v3: ipu-ic: Fully describe colorspace conversions

2019-03-07 Thread Steve Longerbeam
eters are moved to a new function calc_csc_coeffs(), called by init_csc(). Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 136 +--- drivers/gpu/ipu-v3/ipu-image-convert.c | 27 ++-- drivers/staging/media/imx/imx-ic-prpencvf.c | 22 +++- in

[PATCH v6 2/7] gpu: ipu-v3: ipu-ic: Fix BT.601 coefficients

2019-03-07 Thread Steve Longerbeam
Converter unit") Suggested-by: Philipp Zabel Signed-off-by: Steve Longerbeam Cc: sta...@vger.kernel.org --- drivers/gpu/ipu-v3/ipu-ic.c | 61 ++--- 1 file changed, 37 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b/drivers/gpu/ipu-v3

[PATCH v6 1/7] gpu: ipu-v3: ipu-ic: Fix saturation bit offset in TPMEM

2019-03-07 Thread Steve Longerbeam
The saturation bit was being set at bit 9 in the second 32-bit word of the TPMEM CSC. This isn't correct, the saturation bit is bit 42, which is bit 10 of the second word. Fixes: 1aa8ea0d2bd5d ("gpu: ipu-v3: Add Image Converter unit") Signed-off-by: Steve Longerbeam Cc: sta...@

[PATCH v6 5/7] gpu: ipu-v3: ipu-ic: Add support for limited range encoding

2019-03-07 Thread Steve Longerbeam
RGB limited-range coefficients. [M_b, O_b] = YUV limited-range to YUV full-range coefficients. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 281 +--- 1 file changed, 263 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b

Re: [PATCH v6 2/7] gpu: ipu-v3: ipu-ic: Fix BT.601 coefficients

2019-03-08 Thread Steve Longerbeam
On 3/8/19 2:23 AM, Philipp Zabel wrote: Hi Steve, On Thu, 2019-03-07 at 15:33 -0800, Steve Longerbeam wrote: The ycbcr2rgb and inverse rgb2ycbcr tables define the BT.601 Y'CbCr encoding coefficients. The rgb2ycbcr table specifically describes the BT.601 encoding from full range RGB to

Re: [PATCH v6 3/7] gpu: ipu-v3: ipu-ic: Fully describe colorspace conversions

2019-03-08 Thread Steve Longerbeam
On 3/8/19 3:46 AM, Philipp Zabel wrote: On Thu, 2019-03-07 at 15:33 -0800, Steve Longerbeam wrote: Only providing the input and output RGB/YUV space to the IC task init functions is not sufficient. To fully characterize a colorspace conversion, the colorspace (chromaticities), Y'CbCr enc

Re: [PATCH v6 5/7] gpu: ipu-v3: ipu-ic: Add support for limited range encoding

2019-03-08 Thread Steve Longerbeam
On 3/8/19 3:57 AM, Philipp Zabel wrote: On Thu, 2019-03-07 at 15:33 -0800, Steve Longerbeam wrote: Add support for the following conversions: - YUV full-range to YUV limited-range - YUV limited-range to YUV full-range - YUV limited-range to RGB full-range - RGB full-range to YUV limited

[PATCH 1/3] gpu: ipu-v3: image-convert: Fix input bytesperline width/height align

2019-06-11 Thread Steve Longerbeam
;) Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-image-convert.c | 32 +- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c index 36e88434513a..36eb4c77ad91 10

[PATCH 2/3] gpu: ipu-v3: image-convert: Fix input bytesperline for packed formats

2019-06-11 Thread Steve Longerbeam
t;gpu: ipu-v3: image-convert: fix bytesperline adjustment") Reported-by: Harsha Manjula Mallikarjun Suggested-by: Harsha Manjula Mallikarjun Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-image-convert.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 3/3] gpu: ipu-v3: image-convert: Fix image downsize coefficients

2019-06-11 Thread Steve Longerbeam
80 -> 1280x1080. Fixes: 70b9b6b3bcb21 ("gpu: ipu-v3: image-convert: calculate per-tile resize coefficients") Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-image-convert.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-image-

[PATCH] gpu: ipu-v3: image-convert: Enable double write reduction

2019-06-13 Thread Steve Longerbeam
For the write channels with 4:2:0 subsampled YUV formats, avoid chroma overdraw by only writing chroma for even lines (skip odd chroma rows). This reduces necessary write memory bandwidth by at least 25% (more with rotation enabled). Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu

Re: [PATCH] gpu: ipu-v3: Stop overwriting pdev->dev.of_node of child devices

2017-02-16 Thread Steve Longerbeam
therwise -* the platform:imx-ipuv3-crtc modalias won't be used. -*/ - pdev->dev.of_node = of_node; } return 0; Acked-by: Steve Longerbeam ___ dri-devel mailing list dri-devel@lists.freed

Re: [PATCH] gpu: ipu-v3: export ipu_csi_set_downsize

2017-02-16 Thread Steve Longerbeam
ize(struct ipu_csi *csi, bool horiz, bool vert) spin_unlock_irqrestore(&csi->lock, flags); } +EXPORT_SYMBOL_GPL(ipu_csi_set_downsize); void ipu_csi_set_test_generator(struct ipu_csi *csi, bool active, u32 r_value, u32 g_value, u32 b_value, Acked-by:

[PATCH] gpu: ipu-v3: vdic: include AUTO field order bit in ipu_vdi_set_field_order

2017-05-21 Thread Steve Longerbeam
ases. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-vdi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-vdi.c b/drivers/gpu/ipu-v3/ipu-vdi.c index f27bf5a..a663893 100644 --- a/drivers/gpu/ipu-v3/ipu-vdi.c +++ b/drivers/gpu/ipu-v3/ipu-

[PATCH] gpu: ipu-v3: Fix CSI selection for VDIC

2017-06-04 Thread Steve Longerbeam
SI_SEL bit selects which CSI is input to _both_ the VDIC _and_ the IC. If the IC_INPUT bit is set so that the IC is receiving from the VDIC, the IC ignores the CSI_SEL bit, but CSI_SEL still selects which CSI the VDIC receives from in that case. Signed-off-by: Marek Vasut Signed-off-by: Steve

[PATCH v4 3/4] gpu: ipu-ic: Add complete image conversion support with tiling

2016-09-14 Thread Steve Longerbeam
Hi Philipp, On 09/06/2016 02:26 AM, Philipp Zabel wrote: > Hi Steve, > > Am Mittwoch, den 17.08.2016, 17:50 -0700 schrieb Steve Longerbeam: >> This patch implements complete image conversion support to ipu-ic, >> with tiling to support scaling to and from images up t

[PATCH v5 2/2] gpu: ipu-v3: Add queued image conversion support

2016-09-15 Thread Steve Longerbeam
runs belonging to this context are returned via the completion callback with an error status. void ipu_image_convert_unprepare(struct ipu_image_converter_ctx *ctx); Unprepares the conversion context. Any active or pending runs will be aborted by calling ipu_image_convert_abort(). Signed-off-by:

[PATCH v6 2/3] gpu: ipu-v3: Add ipu_rot_mode_is_irt()

2016-09-15 Thread Steve Longerbeam
Add a macro that returns boolean true if the given ipu_rotate_mode requires the use of the Image Rotator. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 2 +- include/video/imx-ipu-v3.h | 22 +++--- 2 files changed, 16 insertions(+), 8 deletions(-) diff

[PATCH v5 0/2] IPUv3 prep for i.MX5/6 v4l2 staging drivers, v5

2016-09-15 Thread Steve Longerbeam
This now contains only the queued image conversion support, along with a split-out patch that adds macro ipu_rot_mode_is_irt(). Steve Longerbeam (2): gpu: ipu-v3: Add ipu_rot_mode_is_irt() gpu: ipu-v3: Add queued image conversion support drivers/gpu/ipu-v3/Makefile|3

[PATCH v5 1/2] gpu: ipu-v3: Add ipu_rot_mode_is_irt()

2016-09-15 Thread Steve Longerbeam
Add a macro that returns boolean true if the given ipu_rotate_mode requires the use of the Image Rotator. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 2 +- include/video/imx-ipu-v3.h | 22 +++--- 2 files changed, 16 insertions(+), 8 deletions(-) diff

[PATCH v6 0/3] IPUv3 prep for i.MX5/6 v4l2 staging drivers, v6

2016-09-15 Thread Steve Longerbeam
Fixed a missed compile error from v5. Also, although "gpu: ipu-v3: Add FSU channel linking support" has already been accepted, need to inlcude it again here only to allow ipu-image-convert.c to compile. Steve Longerbeam (3): gpu: ipu-v3: Add FSU channel linking support gpu: i

[PATCH v6 1/3] gpu: ipu-v3: Add FSU channel linking support

2016-09-15 Thread Steve Longerbeam
SI_DIRECT -> IPUV3_CHANNEL_CSI_VDI_PREV More links can be added to the fsu_link_info[] array. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-common.c | 131 drivers/gpu/ipu-v3/ipu-prv.h| 27 + include/video/imx-ipu-v3.h | 13 3 files changed, 17

[PATCH v6 3/3] gpu: ipu-v3: Add queued image conversion support

2016-09-15 Thread Steve Longerbeam
runs belonging to this context are returned via the completion callback with an error status. void ipu_image_convert_unprepare(struct ipu_image_converter_ctx *ctx); Unprepares the conversion context. Any active or pending runs will be aborted by calling ipu_image_convert_abort(). Signed-off-by:

[PATCH v4 3/4] gpu: ipu-ic: Add complete image conversion support with tiling

2016-09-17 Thread Steve Longerbeam
On 09/16/2016 07:16 AM, Philipp Zabel wrote: > Hi Steve, > > thanks for the update. > > Am Mittwoch, den 14.09.2016, 18:45 -0700 schrieb Steve Longerbeam: >> I added comment headers for all the image conversion prototypes. >> It caused bloat in imx-ipu-v3.h, so

[PATCH] gpu: ipu-v3: image-convert: Wait for channels before disabling

2020-06-09 Thread Steve Longerbeam
tile") Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-image-convert.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c index eeca50d9a1ee..f0938015d2fd 10

Re: [PATCH] gpu: ipu-v3: image-convert: Wait for channels before disabling

2020-06-17 Thread Steve Longerbeam
Hi Philpp, Please disregard this patch. A better solution to a busy wait with a spin lock held is to wait for all required EOF interrupts before doing tile completion processing. I will submit a new patch series. Steve On 6/9/20 5:51 PM, Steve Longerbeam wrote: Call ipu_idmac_wait_busy

[PATCH 3/3] gpu: ipu-v3: image-convert: Wait for all EOFs before completing a tile

2020-06-17 Thread Steve Longerbeam
next tile, because the input/read idmac channel had not completed and entered idle state, thus locking up the channel when attempting to re-start it for the next tile. Fixes: 0537db801bb01 ("gpu: ipu-v3: image-convert: reconfigure IC per tile") Signed-off-by: Steve Longerbeam --- drive

[PATCH 2/3] gpu: ipu-v3: image-convert: Combine rotate/no-rotate irq handlers

2020-06-17 Thread Steve Longerbeam
Combine the rotate_irq() and norotate_irq() handlers into a single eof_irq() handler. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-image-convert.c | 58 +- 1 file changed, 20 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-image

[PATCH 1/3] gpu: ipu-v3: Restore RGB32, BGR32

2020-06-17 Thread Steve Longerbeam
RGB32 and BGR32 formats were inadvertently removed from the switch statement in ipu_pixelformat_to_colorspace(). Restore them. Fixes: a59957172b0c ("gpu: ipu-v3: enable remaining 32-bit RGB V4L2 pixel formats") Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-common.c | 2

[PATCH v2 3/3] gpu: ipu-v3: image-convert: Wait for all EOFs before completing a tile

2020-06-25 Thread Steve Longerbeam
next tile, because the input/read idmac channel had not completed and entered idle state, thus locking up the channel when attempting to re-start it for the next tile. Fixes: 0537db801bb01 ("gpu: ipu-v3: image-convert: reconfigure IC per tile") Signed-off-by: Steve Longerbeam --- Cha

Re: [PATCH v2 3/3] gpu: ipu-v3: image-convert: Wait for all EOFs before completing a tile

2020-06-26 Thread Steve Longerbeam
Hi Philipp, On 6/26/20 2:38 AM, Philipp Zabel wrote: Hi Steve, On Thu, 2020-06-25 at 11:13 -0700, Steve Longerbeam wrote: Use a bit-mask of EOF irqs to determine when all required idmac channel EOFs have been received for a tile conversion, and only do tile completion processing after all

[PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit

2016-07-07 Thread Steve Longerbeam
Adds the Video Deinterlacer (VDIC) unit. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/Makefile | 2 +- drivers/gpu/ipu-v3/ipu-common.c | 11 ++ drivers/gpu/ipu-v3/ipu-prv.h| 6 + drivers/gpu/ipu-v3/ipu-vdi.c| 266 include/video

[PATCH 02/16] gpu: ipu-cpmem: Add ipu_cpmem_set_uv_offset()

2016-07-07 Thread Steve Longerbeam
Adds ipu_cpmem_set_uv_offset(), to set planar U/V offsets. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-cpmem.c | 7 +++ include/video/imx-ipu-v3.h | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-cpmem.c b/drivers/gpu/ipu-v3/ipu-cpmem.c index

[PATCH 03/16] gpu: ipu-cpmem: Add ipu_cpmem_get_burstsize()

2016-07-07 Thread Steve Longerbeam
Adds ipu_cpmem_get_burstsize(). Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-cpmem.c | 6 ++ include/video/imx-ipu-v3.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-cpmem.c b/drivers/gpu/ipu-v3/ipu-cpmem.c index a36c35e..fcb7dc8 100644 --- a

[PATCH 04/16] gpu: ipu-v3: Add ipu_get_num()

2016-07-07 Thread Steve Longerbeam
Adds of-alias id to ipu_soc and retrieve with ipu_get_num(). Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-common.c | 8 drivers/gpu/ipu-v3/ipu-prv.h| 1 + include/video/imx-ipu-v3.h | 1 + 3 files changed, 10 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu

[PATCH 00/16] IPUv3 prep for i.MX5/6 v4l2 staging drivers

2016-07-07 Thread Steve Longerbeam
These updates to IPUv3 are needed for media staging drivers for i.MX5/6 video capture and mem2mem. Steve Longerbeam (15): gpu: ipu-v3: Add Video Deinterlacer unit gpu: ipu-cpmem: Add ipu_cpmem_set_uv_offset() gpu: ipu-cpmem: Add ipu_cpmem_get_burstsize() gpu: ipu-v3: Add ipu_get_num

[PATCH 06/16] gpu: ipu-v3: Add ipu_set_vdi_src_mux()

2016-07-07 Thread Steve Longerbeam
Adds ipu_set_vdi_src_mux() that selects the VDIC input (from CSI or memory). Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-common.c | 20 include/video/imx-ipu-v3.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-common.c b

[PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src()

2016-07-07 Thread Steve Longerbeam
Adds ipu_csi_set_src() which is just a wrapper around ipu_set_csi_src_mux(). Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-csi.c | 8 include/video/imx-ipu-v3.h | 1 + 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu

[PATCH 09/16] gpu: ipu-v3: Add ipu_ic_set_src()

2016-07-07 Thread Steve Longerbeam
Adds ipu_ic_set_src() which is just aa wrapper around ipu_set_ic_src_mux(). Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 10 ++ include/video/imx-ipu-v3.h | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b/drivers/gpu/ipu-v3/ipu

[PATCH 10/16] gpu: ipu-v3: set correct full sensor frame for PAL/NTSC

2016-07-07 Thread Steve Longerbeam
Set the sensor full frame based on whether the passed in mbus_fmt is 720x480 (NTSC) or 720x576 (PAL). Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-csi.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers

[PATCH 11/16] gpu: ipu-v3: Fix CSI data format for 16-bit media bus formats

2016-07-07 Thread Steve Longerbeam
The CSI data format was being programmed incorrectly for the 1x16 media bus formats. The CSI data format for 16-bit must be bayer/generic (CSI_SENS_CONF_DATA_FMT_BAYER). Suggested-by: Carsten Resch Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-csi.c | 6 +- 1 file changed, 1

[PATCH 12/16] gpu: ipu-v3: Fix CSI0 blur in NTSC format

2016-07-07 Thread Steve Longerbeam
From: Suresh Dhandapani This patch will change the register IPU_CSI0_CCIR_CODE_2 value from 0x40596 to 0x405A6. The change is related to the Start of field 1 first blanking line command bit[5-3] for NTSC format only. This change is dependent with ADV chip where the NEWAVMODE is set to 0 in regist

[PATCH 05/16] gpu: ipu-v3: Add IDMA channel linking support

2016-07-07 Thread Steve Longerbeam
_PP More links can be added to the idmac_link_info[] array. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-common.c | 112 include/video/imx-ipu-v3.h | 3 ++ 2 files changed, 115 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-common.c

[PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels

2016-07-07 Thread Steve Longerbeam
Adds the VDIC field input IDMAC channels. These channels transfer fields F(n-1), F(n), and F(N+1) from memory to the VDIC (channels 8, 9, 10 respectively). Signed-off-by: Steve Longerbeam --- include/video/imx-ipu-v3.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/video/imx-ipu

[PATCH 13/16] gpu: ipu-v3: Fix IRT usage

2016-07-07 Thread Steve Longerbeam
There can be multiple IC tasks using the IRT, so the IRT needs a separate use counter. Create a private ipu_irt_enable() to enable the IRT module when any IC task requires rotation, and ipu_irt_disable() when a task no longer needs the IRT. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3

[PATCH 15/16] gpu: ipu-ic: allow multiple handles to ic

2016-07-07 Thread Steve Longerbeam
handle to the IC at a time, so we should be ok there. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-ic.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b/drivers/gpu/ipu-v3/ipu-ic.c index f6a1125..51e34a1 100644

[PATCH 14/16] gpu: ipu-ic: Add complete image conversion support with tiling

2016-07-07 Thread Steve Longerbeam
This patch implements complete image conversion support to ipu-ic, with tiling to support scaling to and from images up to 4096x4096. Image rotation is also supported. The internal API is subsystem agnostic (no V4L2 dependency except for the use of V4L2 fourcc pixel formats). Callers prepare for

[PATCH 16/16] gpu: ipu-v3: rename CSI client device

2016-07-07 Thread Steve Longerbeam
Rename the CSI client device in the client_reg[] table to "imx-ipuv3-csi". Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c ind

[PATCH 12/16] gpu: ipu-v3: Fix CSI0 blur in NTSC format

2016-07-10 Thread Steve Longerbeam
On 07/08/2016 10:34 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >> From: Suresh Dhandapani >> >> This patch will change the register IPU_CSI0_CCIR_CODE_2 value from >> 0x40596 to 0x405A6. The change is related to th

[PATCH 05/16] gpu: ipu-v3: Add IDMA channel linking support

2016-07-13 Thread Steve Longerbeam
Hi Philipp, On 07/08/2016 10:34 AM, Philipp Zabel wrote: > > Please use the defines here: > IPUV3_CHANNEL_IC_PRP_ENC_MEM > IPUV3_CHANNEL_MEM_ROT_ENC > Right, I will fix in next version. Steve

[PATCH 12/16] gpu: ipu-v3: Fix CSI0 blur in NTSC format

2016-07-13 Thread Steve Longerbeam
On 07/10/2016 09:33 AM, Steve Longerbeam wrote: > > > On 07/08/2016 10:34 AM, Philipp Zabel wrote: >> Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >>> From: Suresh Dhandapani >>> >>> This patch will change the register IPU_CSI0_CCI

[PATCH 02/16] gpu: ipu-cpmem: Add ipu_cpmem_set_uv_offset()

2016-07-13 Thread Steve Longerbeam
Hi Philipp, On 07/08/2016 10:34 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >> Adds ipu_cpmem_set_uv_offset(), to set planar U/V offsets. >> >> Signed-off-by: Steve Longerbeam >> --- >> drivers/gpu/ipu-v3/ip

[PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src()

2016-07-15 Thread Steve Longerbeam
On 07/15/2016 05:49 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > >> +{ >> +ipu_set_csi_src_mux(csi->ipu, csi->id, select_mipi_csi2); >> + >> +return 0; >> +} >> +EXPORT_SYMBOL_GPL(ip

[PATCH 06/16] gpu: ipu-v3: Add ipu_set_vdi_src_mux()

2016-07-15 Thread Steve Longerbeam
On 07/15/2016 05:48 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >> Adds ipu_set_vdi_src_mux() that selects the VDIC input >> (from CSI or memory). >> >> Signed-off-by: Steve Longerbeam >> --- >>

[PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels

2016-07-15 Thread Steve Longerbeam
On 07/15/2016 05:45 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >> Adds the VDIC field input IDMAC channels. These channels >> transfer fields F(n-1), F(n), and F(N+1) from memory to >> the VDIC (channels 8, 9, 10 respec

[PATCH 09/16] gpu: ipu-v3: Add ipu_ic_set_src()

2016-07-15 Thread Steve Longerbeam
On 07/15/2016 05:45 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >> +int ipu_ic_set_src(struct ipu_ic *ic, int csi_id, bool vdi) >> +{ >> +struct ipu_ic_priv *priv = ic->priv; >> + >> +ipu_s

  1   2   3   >