Hello Uma,
My comments inline.
On 10/31/2018 5:35 PM, Uma Shankar wrote:
This patch series creates a new connector property to program
colorspace to sink devices. Modern sink devices support more
than 1 type of colorspace like 601, 709, BT2020 etc. This helps
to switch based on content type wh
Regards
Shashank
On 10/31/2018 5:35 PM, Uma Shankar wrote:
This patch adds a colorspace property enabling
userspace to switch to various supported colorspaces.
This will help enable BT2020 along with other colorspaces.
v2: Addressed Maarten and Ville's review comments. Enhanced
the colorspace
Regards
Shashank
On 10/31/2018 5:35 PM, Uma Shankar wrote:
This patch attaches the colorspace connector property to the
hdmi connector. Based on colorspace change, modeset will be
triggered to switch to new colorspace.
Based on colorspace property value create an infoframe
with appropriate co
Regards
Shashank
On 11/27/2018 10:10 PM, Uma Shankar wrote:
This patch adds a HDMI colorspace property, enabling
userspace to switch to various supported colorspaces.
This will help enable BT2020 along with other colorspaces.
v2: Addressed Maarten and Ville's review comments. Enhanced
the col
Regards
Shashank
On 11/27/2018 10:10 PM, Uma Shankar wrote:
This patch adds a DP colorspace property, enabling
userspace to switch to various supported colorspaces.
This will help enable BT2020 along with other colorspaces.
v2: Addressed Maarten and Ville's review comments. Enhanced
the
Hey Christian,
On 19/08/2024 13:21, Christian König wrote:
Am 19.08.24 um 09:21 schrieb Friedrich Vock:
In Vulkan, it is the application's responsibility to perform adequate
synchronization before a sparse unmap, replace or BO destroy operation.
This adds an option to AMDGPU_VA_OPs to disable r
[AMD Official Use Only - General]
Hey Christian,
Will do that.
Regards
Shashank
-Original Message-
From: Koenig, Christian
Sent: Monday, September 11, 2023 1:15 PM
To: André Almeida ; dri-devel@lists.freedesktop.org;
amd-...@lists.freedesktop.org; linux-ker...@vger.kernel.org; Sharma
+ /*
+* Copy to local buffer to avoid put_user(), which might fault
+* and acquire mmap_sem, under reservation_ww_class_mutex.
+*/
+ for (i = 0; i < ring->mqd_size/sizeof(u32); i++)
+ kbuf[i] = mqd[i];
memcpy is safe to use here.
With that change, please feel free
On 14/03/2024 06:58, Khatri, Sunil wrote:
On 3/14/2024 2:06 AM, Alex Deucher wrote:
On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri
wrote:
Add firmware version information of each
IP and each instance where applicable.
Is there a way we can share some common code with devcoredump,
debugfs, a
+ Johannes
Regards
Shashank
On 13/03/2024 18:22, Sharma, Shashank wrote:
Hello Johannes,
On 07/03/2024 23:07, Johannes Weiner wrote:
An errant disk backup on my desktop got into debugfs and triggered the
following deadlock scenario in the amdgpu debugfs files. The machine
also hard-resets
On 23/03/2024 15:52, Johannes Weiner wrote:
On Thu, Mar 14, 2024 at 01:09:57PM -0400, Johannes Weiner wrote:
Hello,
On Fri, Mar 08, 2024 at 12:32:33PM +0100, Christian König wrote:
Am 07.03.24 um 23:07 schrieb Johannes Weiner:
Lastly I went with an open loop instead of a memcpy() as I wasn'
[AMD Official Use Only - General]
Hey Alex,
Sure, I will pick it up and push it to staging.
Regards
Shashank
From: Alex Deucher
Sent: Monday, March 25, 2024 12:23 AM
To: Sharma, Shashank
Cc: Johannes Weiner ; Christian König
; Deucher, Alexander
; Koenig
Thanks for the patch,
Patch pushed for staging.
Regards
Shashank
On 25/03/2024 00:23, Alex Deucher wrote:
On Sat, Mar 23, 2024 at 4:47 PM Sharma, Shashank
wrote:
On 23/03/2024 15:52, Johannes Weiner wrote:
On Thu, Mar 14, 2024 at 01:09:57PM -0400, Johannes Weiner wrote:
Hello,
On Fri
[AMD Official Use Only - General]
Reviewed-by: Shashank Sharma
Regards
Shashank
-Original Message-
From: Icenowy Zheng
Sent: Sunday, October 8, 2023 8:47 AM
To: Deucher, Alexander ; Koenig, Christian
; Pan, Xinhui ; David Airlie
; Daniel Vetter ; Sharma, Shashank
; Yadav, Arvind
Cc
-...@lists.freedesktop.org; linux-ker...@vger.kernel.org; Sharma, Shashank
Cc: kernel-...@igalia.com; Deucher, Alexander ;
Pelloux-Prayer, Pierre-Eric
Subject: Re: [PATCH v6 1/5] drm/amdgpu: Allocate coredump memory in a
nonblocking way
Am 11.09.23 um 05:00 schrieb André Almeida:
> During a GPU reset, a normal mem
Reviewed-by: Shashank Sharma
Regards
Shashank
On 3/23/2018 11:55 PM, Ville Syrjala wrote:
From: Ville Syrjälä
Since we may attempt to reconfigure SCDC when the sink has already been
disconnected we probably shouldn't scare the user with errors in dmesg
that are 100% expected in that case. Jus
Regards
Shashank
On 9/1/2017 8:14 PM, Thierry Reding wrote:
From: Thierry Reding
It's unusual to separate kerneldoc comments from the functions that they
describe by a blank line. Remove them.
Signed-off-by: Thierry Reding
---
drivers/gpu/drm/drm_scdc_helper.c | 2 --
1 file changed, 2
Regards
Shashank
On 9/1/2017 8:14 PM, Thierry Reding wrote:
From: Thierry Reding
The error messages generated by the SCDC helpers are somewhat
inconsistent with other DRM errors and even with other errors in the
same file. Fix them all up to use a common format.
Signed-off-by: Thierry Reding
Reviewed-by: Shashank Sharma
Regards
Shashank
On 9/1/2017 8:14 PM, Thierry Reding wrote:
From: Thierry Reding
The file uses inconsistent capitalization for TMDS. Since it is an
abbreviation, all uppercase is correct.
Signed-off-by: Thierry Reding
---
drivers/gpu/drm/drm_scdc_helper.c | 4
for I915: Acked-by: Shashank Sharma
Regards
Shashank
On 2/27/2018 6:26 PM, Ville Syrjala wrote:
From: Ville Syrjälä
Currently we have a mix of static and dynamic information stored in
the display info structure. That makes it rather difficult to repopulate
the dynamic parts when a new EDID ap
Regards
Shashank
On 2/27/2018 6:26 PM, Ville Syrjala wrote:
From: Ville Syrjälä
Now that we have split the display info into static and dynamic parts,
we can just zero out the entire dynamic part with memset(). Previously
we were just clearing parts of it, leaving stale data in other parts
(
Regards
Shashank
On 2/24/2018 12:55 AM, Ville Syrjala wrote:
From: Ville Syrjälä
Using a flexible array for the blob data was a mistake by me. It
forces all users of the blob data to cast blob->data to something
else. void* is clearly superior so let's go back to the original
scheme.
Not a
Regards
Shashank
On 2/24/2018 12:55 AM, Ville Syrjala wrote:
From: Ville Syrjälä
Now that blob->data is void* again we don't need the casts anymore.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_atomic.c| 3 +--
drivers/gpu/drm/drm_atomic_helper.c | 2 +-
drivers/gpu/drm
Regards
Shashank
On 2/24/2018 12:55 AM, Ville Syrjala wrote:
From: Ville Syrjälä
While we want to potentially support multiple different gamma/degamma
LUT sizes we can (and should) at least check that the blob length
is a multiple of the LUT entry size.
I dint understand the exact idea behin
Regards
Shashank
On 3/1/2018 6:54 PM, Ville Syrjälä wrote:
On Thu, Mar 01, 2018 at 06:43:21PM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 2/24/2018 12:55 AM, Ville Syrjala wrote:
From: Ville Syrjälä
While we want to potentially support multiple different gamma/degamma
LUT sizes
On 1/12/2018 11:51 AM, Nautiyal, Ankit K wrote:
From: Ville Syrjälä
Make mode matching less confusing by allowing the caller to specify
which parts of the modes should match via some flags.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_modes.c | 134
Regards
Shashank
On 1/12/2018 11:51 AM, Nautiyal, Ankit K wrote:
From: Ville Syrjälä
Use drm_mode_equal_no_clocks_no_stereo() in
drm_match_hdmi_mode_clock_tolerance() for consistency as we
also use it in drm_match_hdmi_mode() and the cea mode matching
functions.
This doesn't actually change a
Regards
Shashank
On 1/12/2018 11:51 AM, Nautiyal, Ankit K wrote:
From: Ville Syrjälä
commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer")
cause us to not send out any VICs in the AVI infoframes. That commit
was since reverted, but if and when we add aspect ratio handing back
we
Regards
Shashank
On 1/12/2018 11:51 AM, Nautiyal, Ankit K wrote:
From: Ankit Nautiyal
A new drm client cap is required to enable user-space to advertise
if it supports modes with aspect-ratio. Based on this cap value, the
kernel will take a call on exposing the aspect ratio information in
mo
Regards
Shashank
On 1/17/2018 8:51 PM, Ville Syrjälä wrote:
On Wed, Jan 17, 2018 at 02:11:55PM +0530, Sharma, Shashank wrote:
On 1/12/2018 11:51 AM, Nautiyal, Ankit K wrote:
From: Ville Syrjälä
Make mode matching less confusing by allowing the caller to specify
which parts of the modes
Regards
Shashank
On 1/17/2018 8:59 PM, Ville Syrjälä wrote:
On Wed, Jan 17, 2018 at 02:35:40PM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 1/12/2018 11:51 AM, Nautiyal, Ankit K wrote:
From: Ville Syrjälä
commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer"
On 7/13/2017 7:40 PM, Ville Syrjälä wrote:
What I mean is
for_each() {
...
+ if (420) {
+ if (!420_dc)
+ return false;
+ } else {
if (!444_dc)
return false;
+ }
}
Got it, Thanks !
Regards
Shashank
On 7/13/2017 9:51 PM, Ville Syrjälä wrote:
On Thu, Jul 13, 2017 at 09:03:12PM +0530, Shashank Sharma wrote:
HDMI 2.0 spec adds support for YCBCR420 sub-sampled output.
CEA-861-F adds two new blocks in EDID's CEA extension blocks,
to provide information about sink's YCBCR420 o
Regards
Shashank
On 7/15/2017 12:00 AM, Ville Syrjälä wrote:
On Thu, Jul 13, 2017 at 09:03:15PM +0530, Shashank Sharma wrote:
This patch checks encoder level support for YCBCR420 outputs.
The logic goes as simple as this:
If the input mode is YCBCR420-only mode: prepare HDMI for
YCBCR420 outp
Regards
Shahank
On 7/15/2017 12:00 AM, Ville Syrjälä wrote:
On Thu, Jul 13, 2017 at 09:03:16PM +0530, Shashank Sharma wrote:
To get a YCBCR420 output from intel platforms, we need one
scaler to scale down YCBCR444 samples to YCBCR420 samples.
This patch:
- Does scaler allocation for HDMI ycb
Regards
Shashank
On 7/15/2017 12:03 AM, Ville Syrjälä wrote:
On Thu, Jul 13, 2017 at 09:03:17PM +0530, Shashank Sharma wrote:
To get HDMI YCBCR420 output, the PIPEMISC register should be
programmed to:
- Generate YCBCR output (bit 11)
- In case of YCBCR420 outputs, it should be programmed in
Regards
Shashank
On 7/15/2017 12:06 AM, Ville Syrjälä wrote:
On Thu, Jul 13, 2017 at 09:03:18PM +0530, Shashank Sharma wrote:
To support ycbcr output, we need a pipe CSC block to do
RGB->YCBCR conversion.
Current Intel platforms have only one pipe CSC unit, so
we can either do color correcti
Regards
Shashank
On 7/15/2017 12:32 AM, Ville Syrjälä wrote:
On Thu, Jul 13, 2017 at 09:03:06PM +0530, Shashank Sharma wrote:
Following YCBCR 4:4:4 and 4:2:2, YCBCR 4:2:0 is a new output format,
which is currently supported on HDMI 2.0 sources/sinks. Due to lower
chroma sub-sampling rate, YCB
Thanks for adding this fix , Sean, and sorry about missing this
alignment in doc.
Regards
Shashank
On 7/24/2017 9:01 PM, Sharma, Shashank wrote:
-Original Message-
From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of
Sean Paul
Sent: Friday, July 21, 2017 1:39
Reviewed-by: Shashank Sharma
Regards
Shashank
-Original Message-
From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of
Sean Paul
Sent: Thursday, July 20, 2017 11:18 PM
To: dri-devel@lists.freedesktop.org
Cc: Vetter, Daniel
Subject: [PATCH 1/4] drm/modes: Fix drm
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
HDMI 2.0 Appendix F suggest that we should keep sending the infoframe
when switching from 3D to 2D mode, even if the infoframe isn't strictly
necessary (ie. not needed to transmit the VIC or stereo information)
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
Appedix F of HDMI 2.0 says that some HDMI sink may fail to switch from
3D to 2D mode in a timely fashion if the source simply stops sending the
HDMI infoframe. The suggested workaround is to keep sending the
in
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer")
cause us to not send out any VICs in the AVI infoframes. That commit
was since reverted, but if and when we add aspect ratio handing back
we ne
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
If the user mode would specify an aspect ratio other than 4:3 or 16:9
we now silently ignore it. Maybe a better apporoach is to return an
error? Let's try that.
Also we must be careful that we don't try to sen
Regards
Shashank
On 11/16/2017 9:46 PM, Ville Syrjälä wrote:
On Thu, Nov 16, 2017 at 08:06:18PM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
HDMI 2.0 Appendix F suggest that we should keep sending the infoframe
when
Regards
Shashank
On 11/16/2017 9:51 PM, Ville Syrjälä wrote:
On Thu, Nov 16, 2017 at 08:10:55PM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
Appedix F of HDMI 2.0 says that some HDMI sink may fail to switch from
3D to
Regards
Shashank
On 11/16/2017 9:53 PM, Ville Syrjälä wrote:
On Thu, Nov 16, 2017 at 08:21:44PM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer"
Regards
Shashank
On 11/16/2017 9:56 PM, Ville Syrjälä wrote:
On Thu, Nov 16, 2017 at 08:31:36PM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
If the user mode would specify an aspect ratio other than 4:3 or 16:9
we now
Regards
Shashank
On 11/17/2017 5:05 PM, Ville Syrjälä wrote:
On Fri, Nov 17, 2017 at 08:49:49AM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/16/2017 9:53 PM, Ville Syrjälä wrote:
On Thu, Nov 16, 2017 at 08:21:44PM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/13/2017
Regards
Shashank
On 11/17/2017 5:08 PM, Ville Syrjälä wrote:
On Fri, Nov 17, 2017 at 08:53:54AM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/16/2017 9:56 PM, Ville Syrjälä wrote:
On Thu, Nov 16, 2017 at 08:31:36PM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/13/2017
Regards
Shashank
On 11/17/2017 6:19 PM, Ville Syrjälä wrote:
On Fri, Nov 17, 2017 at 05:50:11PM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/17/2017 5:05 PM, Ville Syrjälä wrote:
On Fri, Nov 17, 2017 at 08:49:49AM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/16/2017
Regards
Shashank
On 11/21/2017 10:41 PM, Ville Syrjälä wrote:
On Fri, Nov 17, 2017 at 03:00:30PM +0530, Shashank Sharma wrote:
From: aknautiy
We parse the EDID and add all the modes in the connector's
modelist. This adds CEA modes with aspect ratio information
too, regadless of if user spac
undant to all the properties we already have.
>
> What's the technical reasons for adding this interface? Your proposal
> is only describing how it works, so is lacking this crucial
> information.
> -Daniel
>
> On Wed, May 7, 2014 at 4:22 PM, Sharma, Shashank
> wro
Thanks for your time and the comments David.
please find mine inline.
Regards
Shashank
On 5/12/2014 5:20 PM, David Herrmann wrote:
> Hi
>
> On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank
> wrote:
>> Benefits of using color manager:
>> ===
Daniel,
Please find my comments inline.
Regards
Shashank
On 5/12/2014 8:58 PM, Daniel Vetter wrote:
> On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote:
>> Thanks for your time and the comments David.
>> please find mine inline.
>>
>> Regards
>>
Thanks for the review and comments David.
Please find my comments inline.
Regards
Shashank
-Original Message-
From: David Herrmann [mailto:dh.herrm...@gmail.com]
Sent: Tuesday, April 22, 2014 3:08 PM
To: Sharma, Shashank
Cc: intel-gfx at lists.freedesktop.org; dri-devel at
Thanks again David,
Comments inline.
Regards
Shashank
-Original Message-
From: David Herrmann [mailto:dh.herrm...@gmail.com]
Sent: Tuesday, April 22, 2014 5:10 PM
To: Sharma, Shashank
Cc: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org;
Ville Syrj?l?; Thierry
:12 PM
To: Alex Deucher
Cc: Ville Syrj?l?; intel-gfx at lists.freedesktop.org; Shankar, Uma; dri-devel
at lists.freedesktop.org; Sharma, Shashank
Subject: Re: [Intel-gfx] [PATCH 0/6] Intel Color Manager Framework
On Fri, Feb 21, 2014 at 10:41:14AM -0500, Alex Deucher wrote:
> On Fri, Feb 21, 2
Gentle reminder
Regards
Shashank
-Original Message-
From: Sharma, Shashank
Sent: Friday, April 18, 2014 12:01 PM
To: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org;
Ville Syrj?l?; Thierry Reding; Alex Deucher; Sean Paul; robdclark at gmail.com
Cc: Shankar, Uma
in any UI framework or property.
Regards
Shashank
-Original Message-
From: Ville Syrj?l? [mailto:ville.syrj...@linux.intel.com]
Sent: Thursday, February 20, 2014 6:41 PM
To: Sharma, Shashank
Cc: intel-gfx at lists.freedesktop.org; Shankar, Uma; dri-devel at
lists.freedesktop.org
S
harma, Shashank
Cc: intel-gfx at lists.freedesktop.org; Shankar, Uma; dri-devel at
lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/6] Intel Color Manager Framework
On Fri, Feb 21, 2014 at 03:34:43AM +0000, Sharma, Shashank wrote:
> Hi Ville/All,
>
> We gave a presentation on
On Thu, Feb 20, 2014 at 5:11 AM, Ville Syrj?l? mailto:ville.syrjala at linux.intel.com>> wrote:
On Thu, Feb 20, 2014 at 06:07:21PM +0530, Shashank Sharma wrote:
>> Color manager is a new framework in i915 driver, which provides
>> a unified interface for various color correction methods supported
>
will spend some more time in how can I club this framework in DRM
property, and re-implement the patch accordingly, and come back.
At that time, as you suggested, I can take inputs from dri-devel for the actual
implementation.
Regards
Shashank
> -Original Message-
> From: Ville Syrj?l? [mail
modified patches.
Regards
Shashank
From: St?phane Marchesin [mailto:stephane.marche...@gmail.com]
Sent: Monday, February 24, 2014 9:35 AM
To: Sharma, Shashank
Cc: Ville Syrj?l?; Intel Graphics Development; Shankar, Uma; dri-devel at
lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/6] Intel Color
Thanks for the review comments, Emil.
Regards
Shashank
On 10/10/2015 3:53 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:28, Shashank Sharma
> wrote:
>> This patch adds new variables in CRTC state, to hold respective color
>> correction blobs. These blobs will be required dur
Regards
Shashank
On 10/10/2015 3:55 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:28, Shashank Sharma
> wrote:
>> As per DRM color manager design, if a userspace wants to set a correction
>> blob, it prepares it and sends the blob_id to kernel via set_property
>> call. DRM f
Regards
Shashank
On 10/10/2015 4:17 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:28, Shashank Sharma
> wrote:
> [snip]
>> +
>> +/* Color management bit utilities */
>> +#define GET_BIT_MASK(n) ((1 << n) - 1)
>> +
>> +/* Read bits of a word from bit no. 'start'(lsb) till 'n'
Regards
Shashank
On 10/10/2015 3:51 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> From DRM color management:
>>
>> DRM color manager supports these color properties:
>> 1. "ctm": Color transformation matrix proper
Regards
Shashank
On 10/10/2015 4:37 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> CHV/BSW platform supports two different pipe level gamma
>> correction modes, which are:
>> 1. Legacy 8-bit mode
>> 2. 10-bit CGM (Color Gamut Mapping) mode
>>
>
Regards
Shashank
On 10/10/2015 4:41 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> CHV/BSW supports Degamma color correction, which linearizes all
>> the non-linear color values. This will be applied before Color
>> Transformation.
>>
>> This p
Regards
Shashank
On 10/10/2015 4:54 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> The color correction blob values are loaded during set_property
>> calls. This patch adds a function to find the blob and apply the
>> correction values to the d
Regards
Shashank
On 10/10/2015 5:09 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
> [snip]
>> diff --git a/drivers/gpu/drm/i915/intel_color_manager.c
>> b/drivers/gpu/drm/i915/intel_color_manager.c
>> index d5315b2..74f8fc3 100644
>> --- a/drive
Regards
Shashank
On 10/10/2015 5:13 AM, Emil Velikov wrote:
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> CHV/BSW supports Color Space Conversion (CSC) using a 3x3 matrix
>> that needs to be programmed into CGM (Color Gamut Mapping) registers.
>>
>> This patch does the following:
>>
Regards
Shashank
On 10/10/2015 5:15 AM, Emil Velikov wrote:
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> Function intel_attach_color_properties_to_crtc attaches a
>> color property to its CRTC object. This patch calls this
>> function from crtc initialization sequence.
>>
>> Signed-
Regards
Shashank
On 10/10/2015 5:19 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> BDW/SKL/BXT supports Degamma color correction feature, which
>> linearizes the non-linearity due to gamma encoded color values.
>> This will be applied before Co
Regards
Shashank
On 10/10/2015 5:24 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> BDW/SKL/BXT support Color Space Conversion (CSC) using a 3x3 matrix
>> that needs to be programmed into respective CSC registers.
>>
>> This patch does the follo
Thanks for the review Rob.
Regards
Shashank
On 10/12/2015 11:38 PM, Rob Bradford wrote:
> On Sat, 2015-10-10 at 00:59 +0530, Shashank Sharma wrote:
>> BDW/SKL/BXT supports Degamma color correction feature, which
>> linearizes the non-linearity due to gamma encoded color values.
>> This will be app
Regards
Shashank
On 10/12/2015 11:39 PM, Rob Bradford wrote:
> On Sat, 2015-10-10 at 00:59 +0530, Shashank Sharma wrote:
>> BDW/SKL/BXT platforms support various Gamma correction modes
>> which are:
>> 1. Legacy 8-bit mode
>> 2. 10-bit Split Gamma mode
>> 3. 12-bit mode
>>
>> This patch does the f
Regards
Shashank
On 10/12/2015 11:43 PM, Rob Bradford wrote:
> On Sat, 2015-10-10 at 00:59 +0530, Shashank Sharma wrote:
>> I915 color manager registers pipe degamma correction as palette
>> correction before CTM, DRM property.
>>
>> This patch adds the no of coefficients(65) for degamma correctio
Thanks for the review Emil.
Please find my comments inline
Regards
Shashank
On 10/13/2015 6:29 PM, Emil Velikov wrote:
> On 10 October 2015 at 05:55, Sharma, Shashank
> wrote:
>> On 10/10/2015 4:17 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>
Regards
Shashank
On 10/13/2015 6:33 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:01, Sharma, Shashank
> wrote:
>> On 10/10/2015 3:51 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma
Regards
Shashank
On 10/13/2015 6:38 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:09, Sharma, Shashank
> wrote:
>> On 10/10/2015 4:37 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma
&g
Regards
Shashank
On 10/13/2015 6:47 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:20, Sharma, Shashank
> wrote:
>> On 10/10/2015 4:54 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma
>>&
Regards
Shashank
On 10/13/2015 6:53 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:21, Sharma, Shashank
> wrote:
>> On 10/10/2015 5:09 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank S
Regards
Shashank
On 10/13/2015 7:03 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:26, Sharma, Shashank
> wrote:
>> On 10/10/2015 5:13 AM, Emil Velikov wrote:
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma
>>> wrote:
>>>>
>>>
Regards
Shashank
On 10/13/2015 7:15 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:34, Sharma, Shashank
> wrote:
>> On 10/10/2015 5:24 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma
>
l Velikov [mailto:emil.l.veli...@gmail.com]
Sent: Tuesday, October 13, 2015 7:24 PM
To: Sharma, Shashank
Cc: Matheson, Annie J; Bradford, Robert; Palleti, Avinash Reddy; intel-gfx at
lists.freedesktop.org; ML dri-devel; Mukherjee, Indranil; Bish, Jim; Barnes,
Jesse; Smith, Gary K; Kausal Malladi; Vette
Regards
Shashank
On 10/13/2015 7:29 PM, Emil Velikov wrote:
> On 13 October 2015 at 14:40, Sharma, Shashank
> wrote:
>
>> I am not sure if I915 follows a general rule of using for(...) over while(),
>> coz I see many instances of using a while in i915_gem, i915_drv, i
From: Lespiau, Damien
Sent: Tuesday, June 02, 2015 5:31 PM
To: Malladi, Kausal
Cc: Roper, Matthew D; Barnes, Jesse; Jindal, Sonika; R, Durgadoss;
Purushothaman, Vijay A; intel-gfx at lists.freedesktop.org; dri-devel at
lists.freedesktop.org; Vetter, Daniel; Sharma, Shashank; Kamath, Sunil;
Mukh
; Purushothaman, Vijay A; intel-gfx at lists.freedesktop.org;
dri-devel at lists.freedesktop.org
Cc: Vetter, Daniel; Sharma, Shashank; Kamath, Sunil; Mukherjee, Indranil;
annie.j.matherson at intel.com; R, Dhanya p; Palleti, Avinash Reddy
Subject: Re: [PATCH 5/7] drm/i915: Add pipe level Gamma
Hi Daniel,
Thanks for the review.
Please find my comments inline.
Regards
Shashank
On 6/2/2015 5:23 PM, Daniel Stone wrote:
> Hi,
>
> On 2 June 2015 at 12:38, Jindal, Sonika wrote:
>> On 6/2/2015 1:22 AM, Kausal Malladi wrote:
>>> +int drm_mode_crtc_update_color_property(struct drm_device *dev,
Thanks for your time and review Matt.
Please find my comments inline
Regards
Shashank
On 6/6/2015 6:30 AM, Matt Roper wrote:
> On Thu, Jun 04, 2015 at 07:12:32PM +0530, Kausal Malladi wrote:
>> From: Kausal Malladi
>>
>> Color Manager is an extension in i915 driver to handle color correction
>> a
Regards
Shashank
On 6/6/2015 6:30 AM, Matt Roper wrote:
> On Thu, Jun 04, 2015 at 07:12:35PM +0530, Kausal Malladi wrote:
>> From: Kausal Malladi
>>
>> This patch adds a new structure in DRM layer for Gamma color correction.
>> This structure will be used by all user space agents to configure
>>
Regards
Shashank
On 6/6/2015 6:30 AM, Matt Roper wrote:
> On Thu, Jun 04, 2015 at 07:12:36PM +0530, Kausal Malladi wrote:
>> From: Kausal Malladi
>>
>> This patch adds a new function to update color blob properties
>> and exports it.
>>
>> v2: Addressing Sonika's comment,
>> 1. Moved this functio
Regards
Shashank
On 6/6/2015 6:31 AM, Matt Roper wrote:
> On Thu, Jun 04, 2015 at 07:12:37PM +0530, Kausal Malladi wrote:
>> From: Kausal Malladi
>>
>> The atomic CRTC set infrastructure is not available yet. So, the atomic
>> check path throws error for any non-plane property.
>>
>> This patch a
Regards
Shashank
On 6/6/2015 11:03 AM, Jindal, Sonika wrote:
>
>
> On 6/4/2015 7:12 PM, Kausal Malladi wrote:
>> From: Kausal Malladi
>>
>> This patch does the following:
>> 1. Adds the core function to program Gamma correction values for CHV/BSW
>> platform
>> 2. Adds Gamma correction macros
; Vetter, Daniel; Sharma, Shashank
Subject: Re: [PATCH v2 04/10] drm: Add Gamma correction structure
Hi Kausal Malladi,
On 5 June 2015 at 13:00, Jindal, Sonika wrote:
> On 6/4/2015 7:12 PM, Kausal Malladi wrote:
>>
>> From: Kausal Malladi
>>
...
>> v2: Addressing Dani
ne 16, 2015 2:00 AM
To: Daniel Vetter; Lespiau, Damien; Sharma, Shashank; Bhattacharjee, Susanta
Cc: Malladi, Kausal; R, Dhanya p; intel-gfx at lists.freedesktop.org; dri-devel
at lists.freedesktop.org; Purushothaman, Vijay A; Barnes, Jesse; Vetter, Daniel
Subject: RE: [Intel-gfx] [PATCH v2 00/10]
Hi Rob, Alex, Ben, All :)
I am Shashank Sharma, from Linux display team Intel, Bangalore.
We are planning to add a color management extension in the existing I915
driver, for Intel HWs.
Plan was to provide a color correction and enhancement interface for any Linux
based userspace, based on vario
Gentle reminder for the review and comments.
For those who prefer having the design available with the mail, I am attaching
a PDF copy of the design document with this mail.
It would be great for us to hear from you guys, on this.
Regards
Shashank
From: Sharma, Shashank
Sent: Monday, June 22
301 - 400 of 417 matches
Mail list logo
