Regards Shashank
On 10/10/2015 3:55 AM, Emil Velikov wrote: > Hi Shashank, > > On 9 October 2015 at 20:28, Shashank Sharma <shashank.sharma at intel.com> > wrote: >> As per DRM color manager design, if a userspace wants to set a correction >> blob, it prepares it and sends the blob_id to kernel via set_property >> call. DRM framework takes this blob_id, gets the blob, and saves it >> in the CRTC state, so that, during the atomic_commit, the color correction >> values from the blob can referred and applied on display controller >> registers. >> >> This patch adds this set_property support for color correction blobs >> in drm framework. >> >> Signed-off-by: Shashank Sharma <shashank.sharma at intel.com> >> Signed-off-by: Kausal malladi <kausalmalladi at gmail.com> >> --- >> drivers/gpu/drm/drm_atomic.c | 53 >> ++++++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 51 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c >> index 7bb3845..0b286d2 100644 >> --- a/drivers/gpu/drm/drm_atomic.c >> +++ b/drivers/gpu/drm/drm_atomic.c >> @@ -390,6 +390,38 @@ int drm_atomic_set_mode_prop_for_crtc(struct >> drm_crtc_state *state, >> EXPORT_SYMBOL(drm_atomic_set_mode_prop_for_crtc); >> >> /** >> + * drm_atomic_crtc_set_blob - find and set a blob >> + * @state_blob: reference pointer to the color blob in the crtc_state >> + * @blob_id: blob_id coming from set_property() call >> + * >> + * Set a color correction blob (originating from a set blob property) on the >> + * desired CRTC state. This function will take reference of the blob >> property >> + * in the CRTC state, finds the blob based on blob_id (which comes from >> + * set_property call) and set the blob at the proper place. >> + * >> + * RETURNS: >> + * Zero on success, error code on failure. >> + */ >> +int drm_atomic_crtc_set_blob(struct drm_device *dev, >> + struct drm_property_blob **state_blob, uint32_t blob_id) > You are missing the function declaration. Set it as static perhaps ? > Yes, This was meant to be used internally, I can make it static. > Regards, > Emil >
