On Wed, Jul 4, 2012 at 6:15 PM, Alan Cox wrote:
> From: Alan Cox
>
> We set up the lid timer before we set up the backlight. On some devices
> that causes a crash as we do a backlight change before or during the setup.
>
> As this fixes a crash on boot on some setups it ought to go in ASAP.
>
> S
On Sun, Jun 17, 2012 at 12:03 PM, Mattia Dongili wrote:
> 3.5-rc2 is not quite usable, I get a pile of warnings for
> DRM_OBJECT_MAX_PROPERTY being too small and in the end I don't get
> neither a console nor X.
Give 3.5-rc3 a try. There is a patch that at least silences the
DRM_OBJECT_MAX_PROPE
On Fri, Sep 26, 2014 at 10:40 AM, Jan Safrata
wrote:
> add gpio bitbanging i2c adapter on LPC device of atom e6xx
> gpu chipset to access lvds EDID
> tested on SECO QuadMo747-E6xx-EXTREME Qseven platform
>
> Cc: Patrik Jakobsson
> Signed-off-by: Jan Safrata
> ---
>
re them.
>
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Patrik Jakobsson
> Cc: Rob Clark
> Cc: Tomi Valkeinen
> Cc: Alex Deucher
> Cc: Christian König
> Cc: Ben Skeggs
> Signed-off-by: Thierry Reding
Looks good
Reviewed-by: Patrik Jakobsson
> ---
On Sat, Dec 27, 2014 at 4:37 PM, Fabian Frederick wrote:
> Fix sparse warning:
> drivers/gpu/drm/gma500/psb_drv.c:
> 328:56: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Fabian Frederick
Reviewed-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/
On Wed, Jan 29, 2014 at 2:39 PM, David Herrmann
wrote:
> These are unused and can safely be dropped. DRM core verifies they're
> non-NULL before it calls them.
>
> Cc: Patrik Jakobsson
> Signed-off-by: David Herrmann
> ---
> drivers/gpu/drm/gma500/psb_drv.c | 11 ---
On Fri, Feb 8, 2013 at 2:51 PM, "David M?ller (ELSOFT AG)"
wrote:
>
> Hello
>
> I have a problem using a 1024x768 Eizo Monitor attached by DVI-D to a
> system with GMA500 based graphics and running under Linux-3.7.
>
> As soon as the GMA500 driver is taking over control, the refresh
> rate raises
On Mon, Feb 11, 2013 at 2:15 PM, "David M?ller (ELSOFT AG)"
wrote:
> Hi Patrik
>
> Patrik Jakobsson wrote:
>> The value of VCO_MIN comes from the Intel PRM for similar GPUs.
>>
>> Instead of changing VCO_MIN, could you try setting N_MIN=1, N_MAX=6 and
>>
The Intel PRM says the M1 and M2 divisors must be in the range of 10-20 and 5-9.
Since we do all calculations based on them being register values (which are
subtracted by 2) we need to specify them accordingly.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/i915/intel_display.c |4
The Intel PRM says the M1 and M2 divisors must be in the range of 10-20 and 5-9.
Since we do all calculations based on them being register values (which are
subtracted by 2) we need to specify them accordingly.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/i915/intel_display.c |4
On Fri, Feb 15, 2013 at 1:51 PM, Chris Wilson
wrote:
> On Fri, Feb 15, 2013 at 12:18:49AM +, Chris Wilson wrote:
>> On Wed, Feb 13, 2013 at 10:20:21PM +0100, Patrik Jakobsson wrote:
>> > The Intel PRM says the M1 and M2 divisors must be in the range of 10-20
>> >
On Fri, Feb 15, 2013 at 2:30 PM, Patrik Jakobsson
wrote:
> On Fri, Feb 15, 2013 at 1:51 PM, Chris Wilson
> wrote:
>> On Fri, Feb 15, 2013 at 12:18:49AM +, Chris Wilson wrote:
>>> On Wed, Feb 13, 2013 at 10:20:21PM +0100, Patrik Jakobsson wrote:
>>> >
The values of n, m1 and m2 needs to be subtracted by 2 before writing them to
the FP register. The dot clock calculation already thinks of these values in
register form so we must also specify them as such.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_intel_display.c | 12
On Mon, Feb 11, 2013 at 11:18 PM, Patrik Jakobsson
wrote:
> On Mon, Feb 11, 2013 at 2:15 PM, "David M?ller (ELSOFT AG)"
> wrote:
>> Hi Patrik
>>
>> Patrik Jakobsson wrote:
>>> The value of VCO_MIN comes from the Intel PRM for similar GPUs.
>>
On Sat, Feb 16, 2013 at 1:04 PM, Patrik Jakobsson
wrote:
> The values of n, m1 and m2 needs to be subtracted by 2 before writing them to
> the FP register. The dot clock calculation already thinks of these values in
> register form so we must also specify them as such.
>
> Signed
}
>
> + dev = sender->dev;
> + dev_priv = dev->dev_private;
> +
> /* Set default display backlight value to 85% (0xd8)*/
> mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1,
> true);
Reviewed-by: Patrik Jakobsson
On Mon, Jan 6, 2014 at 4:02 PM, Rashika Kheria
wrote:
> Mark function cdv_intel_fixed_panel_mode() as static in
> drm/gma500/cdv_intel_dp.c because it is not used outside this file.
>
> This eliminates the following warning in drm/gma500/cdv_intel_dp.c:
> drivers/gpu/drm/gma500/cdv_intel_dp.c:680
interrupts. The old ioctls can go since nothing ever used
them and they don't do what we need. These patches should be totally
transparent to users.
Patrik Jakobsson (8):
drm/gma500: Make SGX MMU driver actually do something
drm/gma500: Add support for SGX interrupts
drm/gma500: Give MMU
Old MMU code never wrote PDs or PTEs to any registers. Now we do, and
that's a good start.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/mmu.c | 258 ---
drivers/gpu/drm/gma500/psb_drv.c | 4 +-
drivers/gpu/drm/gma500/psb_drv.h | 10
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_drv.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 89804fd..99e8f78 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers
All of these ioctls are unused and most of them just duplicate what drm
already provides.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/gem.c | 44 ---
drivers/gpu/drm/gma500/psb_drv.c | 196 -
drivers/gpu/drm/gma500
We'll need this for our gem create ioctl in a later patch.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/framebuffer.c | 2 +-
drivers/gpu/drm/gma500/gem.c | 9 +
drivers/gpu/drm/gma500/gem.h | 21 +
drivers/gp
Properly init the MMU and add MMU entries when adding GTT entries
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/gtt.c | 41
drivers/gpu/drm/gma500/psb_drv.c | 27 +-
2 files changed, 55 insertions(+), 13 deletions
Add 2D blit status and MMU fault interrupts to the IRQ handler.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_irq.c | 80 ++--
1 file changed, 68 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/mmu.c | 45 +--
drivers/gpu/drm/gma500/mmu.h | 93
drivers/gpu/drm/gma500/psb_drv.h | 45 +--
3 files changed, 95 insertions(+), 88 deletions(-)
create
Right now, all we need to know about the blitter is that it's not doing
anything that can be messed up when fiddling with MMU mappings.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/Makefile | 1 +
drivers/gpu/drm/gma500/blitter.c
in the git repository at:
git://github.com/patjak/drm-gma500 gma500-fixes
for you to fetch changes up to d0dc4d2448c16a316a69a77bbaa7fd1348924958:
drm/gma500: Lock struct_mutex around cursor updates (2014-01-22
14:07:18 +0100)
--------
Patrik
)
Patrik Jakobsson (1):
drm/gma500: Lock struct_mutex around cursor updates
Rashika Kheria (1):
drivers: gpu: Mark function as static in cdv_intel_dp.c
drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +-
drivers/gpu/drm/gma500/gma_display.c | 12 ++--
2 files changed, 11 insertions(+), 3
Some devices don't have a panel connected to LVDS and thus will never power up.
This patch checks the power sequence progress bits in PP_STATUS to prevent an
endless loop on such devices.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_lid.c | 12 +---
1 file chang
On Sun, May 13, 2012 at 2:17 PM, Patrik Jakobsson
wrote:
> Some devices don't have a panel connected to LVDS and thus will never power
> up.
> This patch checks the power sequence progress bits in PP_STATUS to prevent an
> endless loop on such devices.
"gma500: address
devices that has this
requirement.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_device.c|1 +
drivers/gpu/drm/gma500/mdfld_device.c |1 +
drivers/gpu/drm/gma500/oaktrail_device.c |1 +
drivers/gpu/drm/gma500/psb_device.c|1 +
drivers/gpu/drm
On Sun, May 13, 2012 at 3:59 PM, Alan Cox wrote:
> We should never get there. In fact we don't want to because if there is
> np panel the backlight is not initialised either.
>
> I'll take a look. I've just fixed a related problem where we wrongly
> invoked the lid code on non Pouslbo devices.
Ok
On Sun, May 13, 2012 at 3:53 PM, Paul Menzel
wrote:
>> The patch also adds a mark in chip ops so we can identify devices that has
>> this
>
> s,has,have,
Noted...
> How can it be verified, that the hardware cursor is working?
As Alan says, use the modesetting driver from:
git://anongit.freedes
On Wed, May 16, 2012 at 11:01 PM, Guillaume Cl?ment
wrote:
> It looks like on others parts of the kernel, kunmap is fed the same input as
> kmap and not the return value of kmap.
Good catch and thank you for testing, I blindly assumed the alloc /
free semantics.
Alan, I'll send you a new versio
On Thu, May 2, 2013 at 2:39 PM, Anisse Astier wrote:
> On Wed, 24 Apr 2013 23:39:58 +0200, Patrik Jakobsson gmail.com> wrote :
>
>> On Wed, Apr 24, 2013 at 5:36 PM, Anisse Astier wrote:
>> > Backlight hotkeys weren't working before on certain cedartrail laptops.
On Mon, May 13, 2013 at 3:02 PM, Holger Schurig
wrote:
> I installed xserver-xorg-video-modesettings (from Debian Wheezy) and also
> updated xserver-core, -evdev, -vesa and -fbdev. The I started X11. Seems
> that Debian doesn't yet contain the addition of the modesettings driver to
> the auto-pro
On Tue, May 14, 2013 at 2:13 PM, Holger Schurig
wrote:
> Okay, I found the patch that produces my regression:
>
>
> From bc794829141f28e14fe7d0e07e35870bd9aee78c Mon Sep 17 00:00:00 2001
> From: Patrik Ja
On Tue, May 14, 2013 at 3:07 PM, Holger Schurig
wrote:
> Patrick, have a
>
> Tested-by: Holger Schurig
>
> for this.
I'll add that.
> As for your suggestion:
>
>> though I recommend you use the modesetting driver because you get
>> a hardware accelerated cursor.
>
> The current Debian Wheezy x
Old code assumed framebuffer starts at base of stolen memory. Since the
addition of hardware cursors, this might not be true anymore so add the
gtt offset to the calculation.
Reported-by: Holger Schurig
Tested-by: Holger Schurig
CC: Holger Schurig
Signed-off-by: Patrik Jakobsson
---
drivers
://bugzilla.novell.com/show_bug.cgi?id=812113
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/gem.c | 44 ++
drivers/gpu/drm/gma500/gtt.c | 5
drivers/gpu/drm/gma500/psb_intel_display.c | 17
3 files changed, 45
All dumb allocated buffers are now automatically pinned so no extra
pinning is needed. Also properly unreference gem objects so they can be
freed up properly. This only affects Poulsbo chips.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_intel_display.c | 49
All dumb allocated buffers are now automatically pinned so no extra
pinning is needed. Also properly unreference gem objects so they can be
freed up properly. This only affects Cedarview chips.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_display.c | 39
failure.
This patch only affects Poulsbo chips.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_intel_display.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c
b/drivers/gpu/drm/gma500
failure.
This patch only affects Cedarview chips.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_display.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c
b/drivers/gpu/drm/gma500
?id=889511
Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=812113
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/framebuffer.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c
b/drivers/gpu/drm/gma500/framebuffer.c
index 8b1b6d9..1a11b69 10
On Sun, May 26, 2013 at 9:07 PM, Daniel Vetter wrote:
> On Sun, May 26, 2013 at 08:03:53PM +0200, Patrik Jakobsson wrote:
>> A framebuffer is pinned when it's set as pipe base, so we also need to
>> unpin it when it's destroyed. Some framebuffers are never used as
>&g
blems. Oaktrail on the other hand might be affected
by LVDS and watermark changes.
Patrik Jakobsson (11):
drm/gma500: Add chip specific sdvo masks
drm/gma500: Add support for aux pci vdc device
drm/gma500: Add aux device support for gmbus
drm/gma500/mrst: Add SDVO clock calculation
drm/g
We start off by adding SDVO limits and converting all limits to the
generic gma_limit_t stuct. Then we separate clock calculations for
LVDS and SDVO. This will be cleaned up later but keep it simple for now.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/oaktrail_crtc.c | 175
On SDVO pipes (always Pipe B on mrst) we have to sequentially write the
aux vdc. We might be able to skip programming the primary vdc in
some/most places but we don't care about that now.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/oaktrail_crtc.c
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_drv.c | 32 +++-
drivers/gpu/drm/gma500/psb_drv.h | 21 -
2 files changed, 51 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500
Since we can have SDVO on Pipe B we better check the output type instead
of pipe number for Oaktrail HDMI.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/oaktrail_crtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c
b
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_device.c | 1 +
drivers/gpu/drm/gma500/framebuffer.c | 2 +-
drivers/gpu/drm/gma500/oaktrail_device.c | 1 +
drivers/gpu/drm/gma500/psb_device.c | 1 +
drivers/gpu/drm/gma500/psb_drv.h | 1 +
5 files changed, 5
For the minnowboard to work the values found in EMGD are required.
This might break Oaktrail but without hardware to test with I cannot
really tell (and do not really care).
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/oaktrail_crtc.c | 13 ++---
1 file changed, 6
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/oaktrail_device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/gma500/oaktrail_device.c
b/drivers/gpu/drm/gma500/oaktrail_device.c
index d7c54b2..27d3875 100644
--- a/drivers/gpu/drm/gma500/oaktrail_device.c
Previously we always had something hooked up to LVDS so we tried very
hard to get a mode. With the Minnowboard this is no longer the case.
If no mode can be found over DDC or the firmware we just ignore LVDS.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/oaktrail_lvds.c | 30
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/oaktrail_device.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/gma500/oaktrail_device.c
b/drivers/gpu/drm/gma500/oaktrail_device.c
index 8079851..d7c54b2 100644
--- a/drivers/gpu/drm/gma500/oaktrail_device.c
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/intel_gmbus.c | 90
1 file changed, 49 insertions(+), 41 deletions(-)
diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c
b/drivers/gpu/drm/gma500/intel_gmbus.c
index 62cd42e..566d330 100644
--- a
This turned out to be tricky. Writing to SDVOB on the primary vdc also
writes to SDVOB on the aux vdc, but reading it back on the primary vdc
always fails. Basically we never read from the primary vdc since we
will end up trashing the aux vdc.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm
1000)
are available in the git repository at:
git://github.com/patjak/drm-gma500 gma500-next
for you to fetch changes up to cd3fdbe853c47c5890d5362363b59504c2e5fb5f:
drm/gma500/mrst: Add SDVO to output init (2013-11-08 16:23:19 +0100)
-----
On Wed, Nov 13, 2013 at 4:49 PM, Holger Schurig
wrote:
> Kernel: 3.10.19
>
> From time to time, when I booted, I had a completely dark screen (with
> kernel command line quiet) and a non-blinking cursor. I wondered if
> that was perhaps gma500. So I turned on various debug checks. Then
> I've got
_funcs *
> + const struct drm_connector_helper_funcs *
> )
>
> @@
> @@
> (
> const struct drm_plane_helper_funcs *
> |
> - struct drm_plane_helper_funcs *
> + const struct drm_plane_helper_funcs *
> )
>
> Signed-off-by: Jani Nikula
Reviewed-by: Patrik Jak
On Tue, May 5, 2015 at 12:29 AM, Nicholas Krause wrote:
> This removes the deprecated functions,i2c_dp_aux_add_bus and
> i2c_dp_aux_prepare_bus and the only call in the function,
> cdv_intel_dp_i2c_init to i2c_dp_aux_add_bus respectfully.
> The call and use of these functions is now replaced along
om wrote:
>>> > On Sun, May 10, 2015 at 01:48:14PM -0400, nick wrote:
>>> >>
>>> >>
>>> >> On 2015-05-10 01:04 PM, patrik.r.jakobsson at gmail.com wrote:
>>> >>> On Tue, May 05, 2015 at 11:17:07AM -0400, nick wrote:
>>&
On Tue, Nov 17, 2015 at 10:23 PM, David Binderman wrote:
> Hello there,
>
> [linux-4.4-rc1/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c:206]: (error)
> Array 'dsi_errors[31]' accessed at index 31, which is out of bounds.
>
> I looks to me like array dsi_errors is badly laid out:
>
> "LP Gene
On Wed, Sep 30, 2015 at 8:12 AM, Sudip Mukherjee
wrote:
> On Tue, Sep 29, 2015 at 03:20:35PM +0200, Patrik Jakobsson wrote:
>> On Thu, Sep 24, 2015 at 5:57 PM, Sudip Mukherjee
>> wrote:
>> > On Wed, Sep 09, 2015 at 06:20:40PM +0530, Sudip Mukherjee wrote:
>> >>
On Fri, Oct 2, 2015 at 5:56 PM, Sudip Mukherjee
wrote:
> On Thu, Oct 01, 2015 at 07:07:33PM +0200, Patrik Jakobsson wrote:
>> On Wed, Sep 30, 2015 at 8:12 AM, Sudip Mukherjee
>> wrote:
>> > On Tue, Sep 29, 2015 at 03:20:35PM +0200, Patrik Jakobsson wrote:
>> >
ased the helper. So remove the one which frees
> backing before the helper is released.
> While at it the error labels are also renamed to give a meaningful
> name.
>
> Cc: Patrik Jakobsson
> Signed-off-by: Sudip Mukherjee
> ---
>
> Hi Patrik,
> If you donot like the la
Signed-off-by: Patrik Jakobsson
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0e1abe8..c7decf7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3368,6 +3368,14 @@ S: Maintained
F: drivers/gpu/drm/imx/
F: Documentation
On Wed, Jul 22, 2015 at 11:28 AM, Archit Taneja
wrote:
> Use the newly created wrapper drm_fb_helper functions instead of calling
> core fbdev functions directly. They also simplify the fb_info creation.
>
> v2:
> - removed unused variable 'device' in psbfb_create
>
On Wed, Jun 24, 2015 at 9:10 AM, Maninder Singh
wrote:
> sender is dereferrenced before NULL check
> struct drm_device *dev = sender->dev;
>
> and due to this we get warning during static analysis:
> warn: variable dereferenced before check 'sender'
>
> __read_panel_data Function is called by mdf
On Wed, Jun 24, 2015 at 10:54 AM, Maninder Singh
wrote:
> Hi,
>
>>> - if (!sender || !data_out || !len_out) {
>>> - DRM_ERROR("Invalid parameters\n");
>>> - return -EINVAL;
>>> - }
>>> -
>>
>>I would prefer to have these kind of checks where it actually matt
g_sender *sender, u8 cmd,
> u32 *data, u16 len, bool hs)
> {
> - if (!sender || !data || !len) {
> - DRM_ERROR("Invalid parameters\n");
> - return -EINVAL;
> - }
> -
> return __read_panel_data(sender, MIPI_DSI_DCS_READ, &cmd, 1,
> data, len, hs);
> }
> --
> 1.7.9.5
>
Reviewed-by: Patrik Jakobsson
5d f4 8b 7d fc 89 ec 5d c3
> 55 8d 2c 24 8d 64 24 f8 89 75 f8 89 7d fc 89 c6 89 d7 ac 75 08 84 c0 75
> f8 31 c0 eb 04 19 c
> EIP: [] strcmp+0x13/0x30 SS:ESP 0068:f6d55b50
> CR2: f858cf08
> ---[ end trace ec712b3b117c8e34 ]---
>
> Signed-off-by: Jan Safrata
> Cc: Patrik J
seven platform.
>
> Signed-off-by: Jan Safrata
> Cc: Patrik Jakobsson
Reviewed-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/oaktrail_lvds.c | 4 +++-
> drivers/gpu/drm/gma500/psb_intel_lvds.c | 6 +-
> 2 files changed, 8 insertions(+), 2 deletions(-)
&g
t; variant (since the drm core still cares).
>
> v2: Finally get rid of the copypasta from another commit in this
> commit message. And convert to _unlocked like we need to (Patrik).
>
> Cc: Patrik Jakobsson
> Cc: Thierry Reding
> Signed-off-by: Daniel Vetter
Reviewed-by: Patr
t;
> Signed-off-by: Daniel Vetter
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
> index c707fa6fca85..e3bdc8b1c
with modeset locks already.
>
> The only important bit is to switch all gem_obj_unref calls to the
> _unlocked variant.
>
> Signed-off-by: Daniel Vetter
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/gma_display.c | 13 +++--
> 1 file changed, 3 insertio
witch obj_unref to _unlocked variants.
>
> Signed-off-by: Daniel Vetter
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 12 ++--
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/framebuffer.c
: Daniel Vetter
+1 for removing that stale comment as well
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/gem.c | 13 +++--
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
On Thu, Jan 1, 2015 at 5:55 PM, Rickard Strandqvist
wrote:
> Remove the function psb_get_default_pd_addr() that is not used anywhere.
>
> This was partially found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist
Hej Rickard
I'd like to keep that
6 +1730,10 @@ void drm_gem_free_mmap_offset(struct drm_gem_object
> *obj);
> int drm_gem_create_mmap_offset(struct drm_gem_object *obj);
> int drm_gem_create_mmap_offset_size(struct drm_gem_object *obj, size_t size);
>
> +struct page **drm_gem_get_pages(struct drm_gem_object *obj, gfp_t gfpmask);
> +void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> + bool dirty, bool accessed);
> +
> struct drm_gem_object *drm_gem_object_lookup(struct drm_device *dev,
> struct drm_file *filp,
> u32 handle);
> --
> 1.8.1.4
Looks good otherwise, so for all 5 patches:
Reviewed-by: Patrik Jakobsson
On Tue, Jul 9, 2013 at 1:07 AM, Rob Clark wrote:
> On Mon, Jul 8, 2013 at 4:18 PM, Daniel Vetter wrote:
>> On Mon, Jul 08, 2013 at 02:56:31PM -0400, Rob Clark wrote:
>>> On Mon, Jul 8, 2013 at 4:45 AM, Patrik Jakobsson
>>> wrote:
>>> > On Sun, J
_init().
> That isn't actually necessary for now, but might be in the future.
>
> Cc: Patrik Jakobsson
> Signed-off-by: David Herrmann
> ---
> drivers/gpu/drm/drm_gem.c | 20
> drivers/gpu/drm/gma500/framebuffer.c | 6 ++
> dri
nd Poulsbo specific things. To differentiate between these we now use gma_* for
generic stuff and keep psb_intel_* for the chip specifics. Eventually we'll just
use gma_*, psb_*, cdv_*, etc... for everything.
Patrik Jakobsson (30):
drm/gma500: Add generic code for clock calculation
drm/gma50
This patch aims to unify the bits and pieces that are common (or similar
enough) for pll clock calculations. Nothing makes use of this code yet
That will come in later patches.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/Makefile| 1 +
drivers/gpu/drm/gma500
Add chip specific callbacks for the generic and non-generic clock
calculation code. Also remove as much dupilicated code as possible.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_device.c| 1 +
drivers/gpu/drm/gma500/cdv_device.h| 1 +
drivers/gpu/drm
Replace any use of xxx_intel_pipe_has_type() with the generic
gma_pipe_has_type() function. Poulsbo still use it but that will be
removed when we rip out psb_intel_pipe_has_type().
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_display.c | 8
drivers/gpu/drm
Add chip specific callbacks for the generic and non-generic clock
calculation code. Also remove as much dupilicated code as possible.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_device.c| 3 +-
drivers/gpu/drm/gma500/psb_device.h| 24
drivers/gpu/drm
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_intel_display.h | 23 ---
1 file changed, 23 deletions(-)
delete mode 100644 drivers/gpu/drm/gma500/psb_intel_display.h
diff --git a/drivers/gpu/drm/gma500/psb_intel_display.h
b/drivers/gpu/drm/gma500
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/gma_display.c | 326 +++
drivers/gpu/drm/gma500/gma_display.h | 14 ++
2 files changed, 340 insertions(+)
diff --git a/drivers/gpu/drm/gma500/gma_display.c
b/drivers/gpu/drm/gma500/gma_display.c
index
This patch makes cdv use the gma_xxx counterparts that are identical. I
took them in one sweep as they should not cause any regressions.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_device.h| 9
drivers/gpu/drm/gma500/cdv_intel_display.c | 74
Also remove the duplicated oaktrail function.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_dp.c| 3 ++-
drivers/gpu/drm/gma500/mdfld_intel_display.c | 6 +++---
drivers/gpu/drm/gma500/oaktrail_crtc.c | 6 +++---
drivers/gpu/drm/gma500/oaktrail_hdmi.c
This patch makes psb use the gma_xxx counterparts that are identical. I
took them in one sweep as they should not cause any regressions.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_intel_display.c | 41 +++---
1 file changed, 4 insertions(+), 37
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_display.c | 77 +-
1 file changed, 1 insertion(+), 76 deletions(-)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c
b/drivers/gpu/drm/gma500/cdv_intel_display.c
index ae57b93..9eee57b 100644
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_display.c | 137 +
drivers/gpu/drm/gma500/gma_display.c | 4 -
drivers/gpu/drm/gma500/gma_display.h | 5 ++
3 files changed, 8 insertions(+), 138 deletions(-)
diff --git a/drivers
This macro is needed for Cedarview specific stuff in the generic gma
functions.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_drv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
index eeed88c..ed1e567
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_intel_display.c | 73 +-
1 file changed, 1 insertion(+), 72 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c
b/drivers/gpu/drm/gma500/psb_intel_display.c
index 0642e7d..ca041c6 100644
There is a slight difference in how we pick the palette register in the
generic function but we should be ok as long as psb_intel_crtc->pipe and
the register map is sane.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_display.c | 70 +-
1 f
This takes care of the remaining chips using the old generic code.
We don't check if the pipe number is valid but the old code peeked in
the register map before checking anyways so just ignore it.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/mdfld_intel_display.c | 2 +-
dr
Use the generic gma functions instead of the medfield functions where
they are identical.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/mdfld_intel_display.c | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/gma500
501 - 600 of 644 matches
Mail list logo
