Re: [PATCH v4 0/3] Generic USB Display driver

2021-01-24 Thread Lubomir Rintel
ONFIG_DEBUG_SPINLOCK turned on): [ 42.064362] usb 1-1.2: new full-speed USB device number 6 using mv-ehci [ 42.228048] usb 1-1.2: New USB device found, idVendor=1d50, idProduct=614d, bcdDevice= 1.00 [ 42.236812] usb 1-1.2: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [

Re: [PATCH v4 0/3] Generic USB Display driver

2021-01-25 Thread Lubomir Rintel
rotocol. This has made the protocol > easier to understand just from reading the header file. > > Noralf. > > [1] https://github.com/notro/gud/wiki The patch set: Tested-by: Lubomir Rintel Works like a charm with this board [1], though it didn't impress the girls as much as I hope

[PATCH v7 1/2] dt-bindings: display: himax, hx8837: Add Himax HX8837 bindings

2021-01-28 Thread Lubomir Rintel
Himax HX8837 is a secondary display controller used to drive the panel on OLPC platforms. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v6: (All based on feedback from Laurent Pinchart) - Add power supplies - Make load/stat-gpios optional - Fix whitespace errors

[PATCH v7 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2021-01-28 Thread Lubomir Rintel
Controller Driver + * + * Datasheet: http://wiki.laptop.org/images/0/09/DCON_datasheet_HX8837-A.pdf + * + * Copyright (C) 2020 Lubomir Rintel + */ + +#include +#include +#include +#include +#include + +#include +#include +#include + +#define bridge_to_hx8837_priv(x) \ + conta

[PATCH v7 0/2] Add a Himax HX8837 display controller driver

2021-01-28 Thread Lubomir Rintel
Hi, please take a look at the patches chained to this messages and consider applying them. They add support for the controller that drives the panel on the OLPC XO laptops. Compared to v7, points risen in review by Laurent Pinchart have been addressed. Details in change log of patch 1/2. Tested

[PATCH libdrm 3/3] tests/etnaviv_2d_test: check whether the rendering is correct

2020-12-02 Thread Lubomir Rintel
writable directory, which is an unsafe thing to do anyway. Signed-off-by: Lubomir Rintel --- tests/etnaviv/etnaviv_2d_test.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/tests/etnaviv/etnaviv_2d_test.c b/tests/etnaviv/etnaviv_2d_test.c index

[PATCH libdrm 2/3] tests/etnaviv_2d_test: pick the 2D core

2020-12-02 Thread Lubomir Rintel
Run the test on a core capable of 2D rendering instead of hardcoding to core zero. Signed-off-by: Lubomir Rintel --- tests/etnaviv/etnaviv_2d_test.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/tests/etnaviv/etnaviv_2d_test.c b/tests

[PATCH libdrm 1/3] tests/etnaviv_2d_test: explain the errors

2020-12-02 Thread Lubomir Rintel
Just so that it's obvious what failed and why. Signed-off-by: Lubomir Rintel --- tests/etnaviv/etnaviv_2d_test.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tests/etnaviv/etnaviv_2d_test.c b/tests/etnaviv/etnaviv_2d_test.c index 8dd77b66..eb9

[PATCH libdrm 0/3] tests/etnaviv_2d_test: some test improvements

2020-12-02 Thread Lubomir Rintel
Hi, patches chained to this message contains changes I've found useful when testing whether 2d rendering works well with the etnaviv driver on my platform. Perhaps they're useful enough for merging upstream. Thanks Lubo ___ dri-devel mailing list dri-

Re: [PATCH v6 1/2] dt-bindings: display: himax,hx8837: Add Himax HX8837 bindings

2020-11-19 Thread Lubomir Rintel
On Sun, Nov 01, 2020 at 06:39:22PM +0200, Laurent Pinchart wrote: > Hi Lubomir, > > Thank you for the patch. Thanks for the message. Some responses inline below. > On Fri, Oct 30, 2020 at 04:07:59AM +0100, Lubomir Rintel wrote: > > Himax HX8837 is a secondary display contro

Re: [PATCH] etnaviv: allow building on MMP

2019-04-17 Thread Lubomir Rintel
On Tue, 2019-04-16 at 18:01 +0200, Lubomir Rintel wrote: > MMP2 has a GC860 core. > > Signed-off-by: Lubomir Rintel > --- > drivers/gpu/drm/etnaviv/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers

[PATCH] etnaviv: allow building on MMP

2019-04-17 Thread Lubomir Rintel
MMP2 has a GC860 core. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig index 041a77e400d4..7616f695270f 100644 --- a/drivers/gpu/drm/etnaviv

[PATCH 5/6] dt-bindings: display: armada: Add mmp2 compatible strings

2019-01-21 Thread Lubomir Rintel
The driver will work on a MMP2 as well. Signed-off-by: Lubomir Rintel --- .../bindings/display/armada/marvell-armada-drm.txt | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt b

[PATCH 3/6] dt-bindings: display: armada: Add framebuffer reserved-mem binding

2019-01-21 Thread Lubomir Rintel
This is the binding for memory that is set aside for allocation of Marvell Armada framebuffer objects. Signed-off-by: Lubomir Rintel --- .../display/armada/marvell-armada-drm.txt | 25 +++ 1 file changed, 25 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH] drm/armada: replace the simple-framebuffer

2019-01-21 Thread Lubomir Rintel
If there's a simple-framebuffer carried over from boot firmware, it's going to stop working once we setup the LCDC for use via DRM. Kick it off from the hardware. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/armada/armada_drv.c | 11 +++ 1 file changed, 11 insertions(+)

[PATCH 2/6] dt-bindings: display: armada: Improve the LCDC documentation

2019-01-21 Thread Lubomir Rintel
The port is a child, not a property. And it deserves an example. Also, make the title a bit more visually distinguishable -- this will look better when the documentation of other Adrmada DRM nodes will be present. Signed-off-by: Lubomir Rintel --- .../display/armada/marvell-armada-drm.txt

[PATCH 6/6] dt-bindings: display: armada: Document bus-width property

2019-01-21 Thread Lubomir Rintel
This makes it possible to choose a different pixel format for the endpoint. Modelled after what other LCD controllers use, including marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more. Signed-off-by: Lubomir Rintel --- .../bindings/display/armada/marvell-armada-drm.txt

[PATCH 0/6] Bindings for Armada display subsystem

2019-01-21 Thread Lubomir Rintel
Hi, this patch set extends the bindings documentation of Armada LCDC to cover the rest of the display subsystem. It is based on what was implemented by Russel's patch set that implements the dt bindings for armada-drm [1]. [1] https://lists.freedesktop.org/archives/dri-devel/2018-July/182893.htm

[PATCH] drm/armada: add mmp2 support

2019-01-21 Thread Lubomir Rintel
ink: https://lists.freedesktop.org/archives/dri-devel/2018-December/201021.html Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/armada/Makefile | 1 + drivers/gpu/drm/armada/armada_610.c | 93 drivers/gpu/drm/armada/armada_crtc.c | 4 ++ drivers/gpu/drm/armada/armada_drm.h | 1

[PATCH 1/6] dt-bindings: display: armada: Rename the binding doc file

2019-01-21 Thread Lubomir Rintel
It's going to document more than just marvell,dove-lcd: more components of the display subsystems with more compatible strings. It seems to make sense to organize this the way it is done in Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt Signed-off-by: Lubomir R

[PATCH 4/6] dt-bindings: display: armada: Add display subsystem binding

2019-01-21 Thread Lubomir Rintel
The Marvell Armada DRM master device is a virtual device needed to list all nodes that comprise the graphics subsystem. Signed-off-by: Lubomir Rintel --- .../display/armada/marvell-armada-drm.txt | 24 +++ 1 file changed, 24 insertions(+) diff --git a/Documentation

Re: [PATCH 4/6] dt-bindings: display: armada: Add display subsystem binding

2019-01-22 Thread Lubomir Rintel
On Mon, 2019-01-21 at 17:53 +, Russell King - ARM Linux admin wrote: > On Mon, Jan 21, 2019 at 10:07:11AM -0600, Rob Herring wrote: > > On Mon, Jan 21, 2019 at 9:46 AM Lubomir Rintel wrote: > > > On Mon, 2019-01-21 at 09:35 -0600, Rob Herring wrote: > > > > On

Re: [PATCH 4/6] dt-bindings: display: armada: Add display subsystem binding

2019-01-22 Thread Lubomir Rintel
On Mon, 2019-01-21 at 09:35 -0600, Rob Herring wrote: > On Sun, Jan 20, 2019 at 11:26 AM Lubomir Rintel wrote: > > The Marvell Armada DRM master device is a virtual device needed to list all > > nodes that comprise the graphics subsystem. > > > > Si

Re: [PATCH] drm/armada: add mmp2 support

2019-01-26 Thread Lubomir Rintel
On Tue, 2019-01-22 at 19:10 +, Russell King - ARM Linux admin wrote: > On Mon, Jan 21, 2019 at 07:03:49AM +0100, Lubomir Rintel wrote: > > Heavily based on the Armada 510 (Dove) support. Like with 510 support, this > > also just supports a single source clock -- the "

[PATCH v2] drm/armada: add mmp2 support

2019-01-31 Thread Lubomir Rintel
of OLPC kindly provided some details about the LCD_SCLK_DIV register. Link: https://lists.freedesktop.org/archives/dri-devel/2018-December/201021.html Signed-off-by: Lubomir Rintel --- Applies on top of "drm-armada-devel" branch of git://git.armlinux.org.uk/~rmk/linux-arm.git Change

Re: [PATCH 4/6] dt-bindings: display: armada: Add display subsystem binding

2019-02-14 Thread Lubomir Rintel
On Mon, 2019-01-21 at 09:35 -0600, Rob Herring wrote: > On Sun, Jan 20, 2019 at 11:26 AM Lubomir Rintel wrote: > > The Marvell Armada DRM master device is a virtual device needed to list all > > nodes that comprise the graphics subsystem. > > > > Si

[RFC 09/16] drm/panel: simple: Add support for Innolux LS075AT011

2018-12-19 Thread Lubomir Rintel
t number. It seems to work. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/panel/panel-simple.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index a04ffb3b2174..d084132c3010 10064

[RFC 10/16] drm/armada: fix compare_of() for LCD controllers

2018-12-19 Thread Lubomir Rintel
From: Russell King The DT node passed for LCD controllers is the "port" node within the parent device. Detect this and compare the parent node. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/

[RFC 05/16] dt-bindings: display: armada: Add mmp2 compatible strings

2018-12-19 Thread Lubomir Rintel
The driver will work on a MMP2 as well. Signed-off-by: Lubomir Rintel --- Note that perhaps "marvell,armada-display-subsystem" and "marvell,armada-framebuffer" would be a good idea in addition of dove/mmp2 specific strings since (at least for now) the driver code is the sam

[RFC 00/16] Armada DRM support for OLPC XO-1.75 laptop

2018-12-19 Thread Lubomir Rintel
Hi, here are patches that make the Armada DRM work on an OLPC XO-1.75. They build on patches previously submitted by Russel King (included here for completeness as well). They certainly need some more love, but I'm not able to improve them until I get to understand some things first. I'm posting

[RFC 07/16] dt-bindings: display: himax, hx8837: Add Himax HX8837 bindings

2018-12-19 Thread Lubomir Rintel
Himax HX8837 is a secondary display controller used to drive the panel on OLPC platforms. Signed-off-by: Lubomir Rintel --- Changes since v3: - Moved to bindings/display/ - Added the ports - Removed Pavel's Ack, because the changes are substantial Changes since v2: - s/betweend/be

[RFC 11/16] drm/armada: add OF reserved memory support

2018-12-19 Thread Lubomir Rintel
From: Russell King Existing Armada DRM makes use of reserved memory for allocating contiguous screen buffers, which currently prevents its use with DT systems. Add support for this for DT systems. Signed-off-by: Russell King --- drivers/gpu/drm/armada/Makefile | 3 ++ drivers/gpu/drm/a

Re: [PATCH 2/3] drm/armada: add OF reserved memory support

2018-12-19 Thread Lubomir Rintel
On Tue, 2018-07-10 at 11:24 +0100, Russell King wrote: > Existing Armada DRM makes use of reserved memory for allocating > contiguous screen buffers, which currently prevents its use with > DT systems. Add support for this for DT systems. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/

[RFC 04/16] dt-bindings: display: armada: Add display subsystem binding

2018-12-19 Thread Lubomir Rintel
The Marvell Armada DRM master device is a virtual device needed to list all nodes that comprise the graphics subsystem. Signed-off-by: Lubomir Rintel --- .../display/armada/marvell-armada-drm.txt | 22 +++ 1 file changed, 22 insertions(+) diff --git a/Documentation

[RFC 12/16] drm/armada: add bus-width property to the output endpoint

2018-12-19 Thread Lubomir Rintel
This makes it possible to choose a different pixel format for the endpoint. Modelled after what other LCD controllers use, including marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/armada/armada_crtc.c | 26

[RFC 16/16] drm/i2c: hx8837: add a Himax HX8837 display controller driver

2018-12-19 Thread Lubomir Rintel
;ve also renamed the driver to use the actual chip name instead of the original name that I found too generic. This way the staging driver can be used on XO 1 and XO 1.5 for the time being, while my XO 1.75 can utilize this one. Signed-off-by: Lubomir Rintel --- FIXME: there are checkpatch compla

[RFC 02/16] dt-bindings: display: armada: Improve the LCDC documentation

2018-12-19 Thread Lubomir Rintel
The port is a child, not a property. And it deserves an example. Also, make the title a bit more visually distinguishable -- this will look better when the documentation of other Adrmada DRM nodes will be present. Signed-off-by: Lubomir Rintel --- .../display/armada/marvell-armada-drm.txt

[RFC 14/16] drm/armada: optionally enable the AXI clock

2018-12-19 Thread Lubomir Rintel
It needs to be enabled (at least on MMP2) in order for the register writes to LCDC to work. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/armada/armada_crtc.c | 7 +++ drivers/gpu/drm/armada/armada_crtc.h | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/armada

[RFC 06/16] dt-bindings: display: armada: Document bus-width property

2018-12-19 Thread Lubomir Rintel
This makes it possible to choose a different pixel format for the endpoint. Modelled after what other LCD controllers use, including marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more. Signed-off-by: Lubomir Rintel --- .../bindings/display/armada/marvell-armada-drm.txt

[RFC 03/16] dt-bindings: display: armada: Add framebuffer reserved-mem binding

2018-12-19 Thread Lubomir Rintel
This is the binding for memory that is set aside for allocation of Marvell Armada framebuffer objects. Signed-off-by: Lubomir Rintel --- .../display/armada/marvell-armada-drm.txt | 23 +++ 1 file changed, 23 insertions(+) diff --git a/Documentation/devicetree/bindings

[RFC 15/16] drm/armada: add mmp2 support

2018-12-19 Thread Lubomir Rintel
y the bit 30 selects the AXI bus clock as base clock for the pixel clock. It is not known to me what other options are there. Signed-off-by: Lubomir Rintel --- Notes; perhaps James or someone else with a datasheet could help me with this. I'm somewhat confused about the clock selection. Th

[RFC 01/16] dt-bindings: display: armada: Rename the binding doc file

2018-12-19 Thread Lubomir Rintel
It's going to document more than just marvell,dove-lcd: more components of the display subsystems with more compatible strings. It seems to make sense to organize this the way it is done in Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt Signed-off-by: Lubomir R

[RFC 13/16] drm/armada: replace the simple-framebuffer

2018-12-19 Thread Lubomir Rintel
If there's a simple-framebuffer carried over from boot firmware, it's going to stop working once we setup the LCDC for use via DRM. Kick it off from the hardware. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/armada/armada_drv.c | 11 +++ 1 file changed, 11 insertions(+)

Re: [PATCH 0/3] Finish Armada DRM DT support

2018-12-19 Thread Lubomir Rintel
uring out how to make the Armada DRM driver work on an OLPC XO-1.75. Seems like they slipped through the cracks and were never applied. With a little more work they indeed seem to work well on my laptop. Feel free to slap in my Tested-by tag (and Reviewed-by, if one from me is any worth in the DRM l

[RFC 08/16] dt-bindings: drm/panel: simple: Add Innolux LS075AT011 bindings

2018-12-19 Thread Lubomir Rintel
Innolux LS075AT011 panels are used on on OLPC laptops. Signed-off-by: Lubomir Rintel --- .../bindings/display/panel/innolux,ls075at011.txt | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/innolux,ls075at011.txt diff

Re: [RFC 00/16] Armada DRM support for OLPC XO-1.75 laptop

2018-12-20 Thread Lubomir Rintel
On Wed, 2018-12-19 at 10:13 +0100, Daniel Vetter wrote: > On Wed, Dec 19, 2018 at 9:40 AM Lubomir Rintel wrote: > > Hi, > > > > here are patches that make the Armada DRM work on an OLPC XO-1.75. > > They build on patches previously submitted by Russel King (included h

Re: [PATCH] drm/doc: Move bridge link target to the right place

2018-12-21 Thread Lubomir Rintel
On Thu, 2018-12-20 at 08:08 +0100, Daniel Vetter wrote: > I screwed up a rebase somehow. > > v2: Drop bogus hunk. > > Cc: Lubomir Rintel > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/drm-kms-helpers.rst | 4 ++-- > drivers/gpu/drm

Armada DRM: bridge with componentized devices

2019-01-04 Thread Lubomir Rintel
Hello, lately I've been trying to make the Himax HX8837 chip that drives the OLPC LCD display work with Armada DRM driver. I've been advised to create a bridge driver and not an encoder driver since the silicon is separate from the LCDC. The Armada DRM driver (and, I think, the i.MX one) creates

Re: [RFC 00/16] Armada DRM support for OLPC XO-1.75 laptop

2019-01-04 Thread Lubomir Rintel
Hi, On Wed, 2018-12-19 at 10:13 +0100, Daniel Vetter wrote: > On Wed, Dec 19, 2018 at 9:40 AM Lubomir Rintel wrote: > > Hi, > > > > here are patches that make the Armada DRM work on an OLPC XO-1.75. > > They build on patches previously submitted by Rus

Re: [RFC 12/16] drm/armada: add bus-width property to the output endpoint

2019-01-04 Thread Lubomir Rintel
On Thu, 2019-01-03 at 13:15 +, Russell King - ARM Linux wrote: > On Tue, Dec 18, 2018 at 04:37:38PM +0100, Lubomir Rintel wrote: > > This makes it possible to choose a different pixel format for the > > endpoint. Modelled after what other LCD controllers use, including > >

Re: [RFC 14/16] drm/armada: optionally enable the AXI clock

2019-01-18 Thread Lubomir Rintel
On Thu, 2019-01-17 at 11:09 +, Russell King - ARM Linux admin wrote: > On Tue, Dec 18, 2018 at 04:37:40PM +0100, Lubomir Rintel wrote: > > It needs to be enabled (at least on MMP2) in order for the register > > writes to LCDC to work. > > Dove also has an AXI clock inpu

Re: [RFC 00/16] Armada DRM support for OLPC XO-1.75 laptop

2019-01-18 Thread Lubomir Rintel
On Thu, 2019-01-17 at 10:55 +, Russell King - ARM Linux admin wrote: > On Tue, Dec 18, 2018 at 04:37:26PM +0100, Lubomir Rintel wrote: > > here are patches that make the Armada DRM work on an OLPC XO-1.75. > > They build on patches previously submitted by Russel King (in

Re: [PATCH 4/6] dt-bindings: display: armada: Add display subsystem binding

2019-02-25 Thread Lubomir Rintel
On Fri, 2019-02-22 at 14:23 -0600, Rob Herring wrote: > On Wed, Feb 13, 2019 at 4:37 PM Lubomir Rintel wrote: > > On Mon, 2019-01-21 at 09:35 -0600, Rob Herring wrote: > > > On Sun, Jan 20, 2019 at 11:26 AM Lubomir Rintel wrote: > > > > The Marvell Armada DRM mas

[PATCH v2 0/5] dt-bindings: improve the Armada DRM bindings

2019-03-05 Thread Lubomir Rintel
Hi, this is the second spin of a patch set that aims to complete the Armada DRM binding documentation. Compared to the first version it omits the display-subsystem node and thus is somewhat simpler. Also, the reserved-mem property has been moved to a separate documentation file. The he individual

[PATCH v2 5/5] dt-bindings: display: armada: Document bus-width property

2019-03-05 Thread Lubomir Rintel
This makes it possible to choose a different pixel format for the endpoint. Modelled after what other LCD controllers use, including marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more. Signed-off-by: Lubomir Rintel --- .../devicetree/bindings/display/marvell,armada-lcdc.txt

[PATCH v2 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer

2019-03-05 Thread Lubomir Rintel
This is the binding for memory that is set aside for allocation of Marvell Armada framebuffer objects. Signed-off-by: Lubomir Rintel --- Changes since v1: - Moved from bindings/display/armada/ - Removed the marvell,dove-framebuffer string - Added to the MAINTAINERS entry .../marvell,armada

[PATCH v2 3/5] dt-bindings: display: armada: Improve the LCDC documentation

2019-03-05 Thread Lubomir Rintel
The port is a child, not a property. And should be accompanied by an example. Plus a pair of cosmetic changes that don't seem to deserve a separate commit. Signed-off-by: Lubomir Rintel --- Changes since v1: - Minor adjustments to the commit message wording. .../bindings/display/ma

[PATCH v2 2/5] dt-bindings: display: armada: Rename the binding doc file

2019-03-05 Thread Lubomir Rintel
Use a more generic name, since it will document more compatible LCD controllers than just that of Dove. Also, there's no point putting it in a separate directory. Signed-off-by: Lubomir Rintel --- Changes since v1: - Choose a better name than armada/marvell-armada-drm.txt, since there wi

[PATCH v2 4/5] dt-bindings: display: armada: Add more compatible strings

2019-03-05 Thread Lubomir Rintel
There's a generic compatible string and the driver will work on a MMP2 as well, using the same binding. Signed-off-by: Lubomir Rintel --- Changes since v1: - Added marvell,armada-lcdc compatible string. .../devicetree/bindings/display/marvell,armada-lcdc.txt | 4 +++- 1 file chang

[PATCH] backlight: tdo24m: Switch to SPDX header

2019-06-11 Thread Lubomir Rintel
The original license text had a typo ("publishhed") which would be likely to confuse automated licensing auditing tools. Let's just switch to SPDX instead of fixing the wording. Signed-off-by: Lubomir Rintel --- drivers/video/backlight/tdo24m.c | 5 + 1 file changed, 1

[PATCH v3 2/5] dt-bindings: display: armada: Rename the binding doc file

2019-03-21 Thread Lubomir Rintel
Use a more generic name, since it will document more compatible LCD controllers than just that of Dove. Also, there's no point putting it in a separate directory. Signed-off-by: Lubomir Rintel --- Changes since v1: - Choose a better name than armada/marvell-armada-drm.txt, since there wi

[PATCH v3 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer

2019-03-21 Thread Lubomir Rintel
This is the binding for memory that is set aside for allocation of Marvell Armada framebuffer objects. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v2: - Collected the Reviewed-by tag Changes since v1: - Moved from bindings/display/armada/ - Removed the marvell

[PATCH v3 5/5] dt-bindings: display: armada: Document bus-width property

2019-03-21 Thread Lubomir Rintel
This makes it possible to choose a different pixel format for the endpoint. Modelled after what other LCD controllers use, including marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v2: - Collected

[PATCH v3 4/5] dt-bindings: display: armada: Add more compatible strings

2019-03-21 Thread Lubomir Rintel
There's a generic compatible string and the driver will work on a MMP2 as well, using the same binding. Signed-off-by: Lubomir Rintel --- Changes since v2: - Order marvell,armada-lcdc after the model-specific strings. Changes since v1: - Added marvell,armada-lcdc compatible s

[PATCH v3 0/5] dt-bindings: improve the Armada DRM bindings

2019-03-21 Thread Lubomir Rintel
Hi, this is the third spin of a patch set that aims to complete the Armada DRM binding documentation. Apart from collecting the Review-by tags, the only change is the order of the compatible strings for the LCDC node. What is documented corresponds to the armada-devel branch of git://git.armlinux

[PATCH v3 3/5] dt-bindings: display: armada: Improve the LCDC documentation

2019-03-21 Thread Lubomir Rintel
The port is a child, not a property. And should be accompanied by an example. Plus a pair of cosmetic changes that don't seem to deserve a separate commit. Signed-off-by: Lubomir Rintel --- Changes since v2: - Collected the Reviewed-by tag Changes since v1: - Minor adjustments to the c

[PATCH libdrm] tests/util: Add armada-drm driver

2019-03-24 Thread Lubomir Rintel
This makes the test utilities work with the Armada driver without the necessity of using the -M argument. Signed-off-by: Lubomir Rintel --- tests/util/kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/kms.c b/tests/util/kms.c index 5af8bf20..dd1bbee3 100644 --- a/tests/util

[PATCH 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2019-12-23 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor

[PATCH 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2019-12-23 Thread Lubomir Rintel
ork and adds an encoder on component bind, so that it works with the Armada DRM driver. Tested with a handful of monitors ranging from 1024x768@75 to 1400x1050@60, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/bridge/Kconfig | 10 + drivers/gpu/drm/

Add support for Chrontel CH7033 VGA/DVI Encoder

2019-12-23 Thread Lubomir Rintel
Hi, chained to this message is a driver for CH7033 along with device tree binding docs. Tested to work well on MMP3-based Dell Wyse 3020, some tweaks might be needed for other configurations. There's not datasheet or programming manual available. Thanks, Lubo __

[PATCH 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2019-12-23 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel --- .../display/bridge/chrontel,ch7033.yaml | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/chrontel,ch7033

[PATCH v2 0/3] Add support for Chrontel CH7033 VGA/DVI Encoder

2020-02-24 Thread Lubomir Rintel
Hi, chained to this message is a driver for CH7033 along with device tree binding docs. Since the initial submission, issues pointed out in Laurent Pinchart's review [1] were addressed. Details in individual patches' change log. At his suggestion, the driver has been made to use bridge/display-co

[PATCH v2 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-02-24 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/bridge/chrontel,ch7033.yaml | 86 +++ 1

[PATCH v2 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2020-02-24 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Collect Rob's ack Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file chang

[PATCH v2 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-02-24 Thread Lubomir Rintel
ork and adds an encoder on component bind, so that it works with the Armada DRM driver. Tested with a handful of monitors ranging from 1024x768@75 to 1400x1050@60, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- Changes since v1: - Sort the includes - Drop a useless model id read - Chai

[RESEND PATCH v2 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-03-09 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/bridge/chrontel,ch7033.yaml | 86 +++ 1

[RESEND PATCH v2 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-03-09 Thread Lubomir Rintel
ork and adds an encoder on component bind, so that it works with the Armada DRM driver. Tested with a handful of monitors ranging from 1024x768@75 to 1400x1050@60, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- Changes since v1: - Sort the includes - Drop a useless model id read - Chai

[RESEND PATCH v2 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2020-03-09 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Collect Rob's ack Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file chang

[RESEND PATCH v2 0/3] Add support for Chrontel CH7033 VGA/DVI Encoder

2020-03-09 Thread Lubomir Rintel
Hi, chained to this message is a driver for CH7033 along with device tree binding docs. I'm hoping that it could perhaps make it into 5.7. Please take a look. Previous submission [1] contained the exact same patches as this one, but at that time they relied on Laurent's omapdrm/bridge/devel branc

[PATCH v3 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-03-15 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Fixed the example so that it validates Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/b

[PATCH v3 0/3] drm: Add support for Chrontel CH7033 VGA/DVI Encoder

2020-03-15 Thread Lubomir Rintel
Hi, chained to this message is a driver for CH7033 along with device tree binding docs. I'm hoping that it could perhaps make it into 5.7. Please take a look. The only change compared to the previous submission [1] is the fix in the DT bindings example discovered by the validation tool. [1] h

[PATCH v3 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2020-03-15 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Collect Rob's ack Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file chang

[PATCH v3 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-03-15 Thread Lubomir Rintel
ork and adds an encoder on component bind, so that it works with the Armada DRM driver. Tested with a handful of monitors ranging from 1024x768@75 to 1400x1050@60, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- Changes since v1: - Sort the includes - Drop a useless model id read - Chai

Re: [PATCH 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-01-12 Thread Lubomir Rintel
Hello Laurent, On Wed, 2020-01-08 at 17:20 +0200, Laurent Pinchart wrote: > Hi Lubomir, > > Thank you for the patch. > > On Fri, Dec 20, 2019 at 08:49:14AM +0100, Lubomir Rintel wrote: > > This is a driver for video encoder with VGA and DVI/HDMI outputs. > > > &

[PATCH v3 1/3] drm/armada: add bus-width property to the output endpoint

2020-01-12 Thread Lubomir Rintel
This makes it possible to choose a different pixel format for the endpoint. Modelled after what other LCD controllers use, including marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/armada/armada_crtc.c | 27

[PATCH v3 3/3] drm/armada: add mmp2 and mmp3 support

2020-01-12 Thread Lubomir Rintel
index 0..2053da32abea6 --- /dev/null +++ b/drivers/gpu/drm/armada/armada_6x0.c @@ -0,0 +1,178 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2012 Russell King + * Copyright (C) 2018,2019,2020 Lubomir Rintel + * Largely based on Armada 510 support + * + * This program is

[PATCH v3 2/3] drm/armada: optionally enable the peripheral clock

2020-01-12 Thread Lubomir Rintel
It needs to be enabled (at least on MMP2) in order for the register writes to LCDC to work. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/armada/armada_crtc.c | 7 +++ drivers/gpu/drm/armada/armada_crtc.h | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/armada

[PATCH v3 0/3] drm/armada: make it work on MMP2 and MMP3

2020-01-12 Thread Lubomir Rintel
Hi, chained to this message are patches that are necessary to make the Armada DRM driver useful on MMP2 and MMP3. They apply on top of drm-armada-devel. The first two patches were previously sent separately, around a year ago or so. The v2 of the third one previosly only implemented only MMP2 sup

[PATCH v4 4/5] dt-bindings: display: armada: Add more compatible strings

2019-08-28 Thread Lubomir Rintel
There's a generic compatible string and the driver will work on a MMP2 as well, using the same binding. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Collected Rob's Reviewed-by tag Changes since v2: - Order marvell,armada-lcdc after the model-specif

[PATCH v4 3/5] dt-bindings: display: armada: Improve the LCDC documentation

2019-08-28 Thread Lubomir Rintel
The port is a child, not a property. And should be accompanied by an example. Plus a pair of cosmetic changes that don't seem to deserve a separate commit. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Actually collected the Reviewed-by tag Changes sin

[PATCH v4 2/5] dt-bindings: display: armada: Rename the binding doc file

2019-08-28 Thread Lubomir Rintel
Use a more generic name, since it will document more compatible LCD controllers than just that of Dove. Also, there's no point putting it in a separate directory. Signed-off-by: Lubomir Rintel --- Changes since v1: - Choose a better name than armada/marvell-armada-drm.txt, since there wi

[PATCH v4 0/5] dt-bindings: improve the Armada DRM bindings

2019-08-28 Thread Lubomir Rintel
Hi, this is the fourth spin of a patch set that aims to complete the Armada DRM binding documentation. The only change from the last version is the addition of Reviewed-by tags. What is documented corresponds to the armada-devel branch of git://git.armlinux.org.uk/~rmk/linux-arm.git with these di

[PATCH v4 5/5] dt-bindings: display: armada: Document bus-width property

2019-08-28 Thread Lubomir Rintel
This makes it possible to choose a different pixel format for the endpoint. Modelled after what other LCD controllers use, including marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v2: - Collected

[PATCH v4 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer

2019-08-28 Thread Lubomir Rintel
This is the binding for memory that is set aside for allocation of Marvell Armada framebuffer objects. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v2: - Collected the Reviewed-by tag Changes since v1: - Moved from bindings/display/armada/ - Removed the marvell

Re: [PATCH] pxa168fb: Fix the function used to release some memory in an error handling path

2019-09-02 Thread Lubomir Rintel
#x27; in the remove function, but not in the > error handling path of the probe function. > > Also, remove a useless 'PAGE_ALIGN()'. 'info->fix.smem_len' is already > PAGE_ALIGNed. > > Fixes: 638772c7553f ("fb: add support of LCD display controller

Re: [PATCH v3 0/6] Generic USB Display driver

2020-07-10 Thread Lubomir Rintel
xpansion is USB with a little help from a microcontroller. I've actually had some success doing just that [1]. [1] https://assets.octodon.social/media_attachments/files/009/983/960/original/64ad8ea46c1b06c5.jpg I suppose you can add: Tested-by: Lubomir Rintel I've had to jump throug

Re: [PATCH v3 0/6] Generic USB Display driver

2020-07-16 Thread Lubomir Rintel
On Tue, Jul 14, 2020 at 09:03:14PM +0200, Noralf Trønnes wrote: > > > Den 14.07.2020 19.40, skrev Peter Stuge: > > Hi Noralf, > > > > Noralf Trønnes wrote: > >> I would like to keep the SET_BUFFER request since it will serve as a > >> syncing point between the host and the device. I'm no USB exp

Re: [PATCH v4 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-04-23 Thread Lubomir Rintel
On Tue, Apr 21, 2020 at 02:54:12PM +0200, Daniel Vetter wrote: > On Tue, Mar 24, 2020 at 04:19:31PM +0100, Lubomir Rintel wrote: > > This is a driver for video encoder with VGA and DVI/HDMI outputs. > > > > There is no documentation for the chip -- the operation was gues

[PATCH v5 0/3] drm: Add support for Chrontel CH7033 VGA/DVI Encoder

2020-04-25 Thread Lubomir Rintel
Hi, chained to this message is another spin of a driver for CH7033. Compared to the previous submission, the integration with device component framework and creation of an encoder on component bind has been removed. This means that until the Armada driver won't work with this driver until it's a

[PATCH v5 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-04-25 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Fixed the example so that it validates Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/b

  1   2   >