Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Liu Ying
gt; Cc: Sascha Hauer > > > > Cc: Pengutronix Kernel Team > > > > Cc: Fabio Estevam > > > > Cc: NXP Linux Team > > > > Cc: linux-arm-ker...@lists.infradead.org > > > > --- > > > > drivers/gpu/drm/imx/dcss/dcss-kms.c

[PATCH] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-16 Thread Liu Ying
n Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: Guido Günther Cc: Robert Chiras Cc: NXP Linux Team Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/nwl-dsi.c | 86 +--- 1 file changed, 46 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/dr

[PATCH] drm/panel: lvds: Drop unnecessary NULL pointer checks for lvds->enable_gpio

2021-04-20 Thread Liu Ying
Airlie Cc: Daniel Vetter Signed-off-by: Liu Ying --- drivers/gpu/drm/panel/panel-lvds.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index 59a8d99..19f11fa 100644 --- a/drivers/gpu/drm/panel/pa

[PATCH v2] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-21 Thread Liu Ying
rlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: Guido Günther Cc: Robert Chiras Cc: NXP Linux Team Signed-off-by: Liu Ying --- v1->v2: * Fix commit message typo - s/unchange/unchanged/ drivers/gpu/drm/bridge/nwl-dsi.c | 86 +--- 1 file ch

Re: [PATCH v2] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-22 Thread Liu Ying
Hi Neil, On Thu, 2021-04-22 at 10:48 +0200, Neil Armstrong wrote: > Hi, > > On 22/04/2021 07:14, Liu Ying wrote: > > Some MIPI DSI panel drivers like 'raydium,rm68200' send > > MIPI_DCS_SET_DISPLAY_ON commands in panel_funcs->prepare(), which > > requir

[PATCH v3 1/3] drm/bridge: nwl-dsi: Force a full modeset when crtc_state->active is changed to be true

2021-04-23 Thread Liu Ying
strong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: Guido Günther Cc: Robert Chiras Cc: NXP Linux Team Signed-off-by: Liu Ying --- v2->v3: * Split from the single patch in v2 to clarify changes. (Neil)

[PATCH v3 0/3] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-23 Thread Liu Ying
DSI controller and PHY are brought up and taken down in pairs. 3) Patch 3/3 shifts the bridge operation as the last step. v2->v3: * Split the single patch in v2 into 3 patches. (Neil) v1->v2: * Fix a typo in commit message - s/unchange/unchanged/ Liu Ying (3): drm/bridge: nwl-dsi: Force a

[PATCH v3 3/3] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-23 Thread Liu Ying
rmstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: Guido Günther Cc: Robert Chiras Cc: NXP Linux Team Signed-off-by: Liu Ying --- v2->v3: * Split some changes to patch 1/3 and 2/3, to clarify changes. (Neil) v1

[PATCH v3 2/3] drm/bridge: nwl-dsi: Remove a check on unchanged HS clock rate from ->mode_set()

2021-04-23 Thread Liu Ying
nther Cc: Robert Chiras Cc: NXP Linux Team Signed-off-by: Liu Ying --- v2->v3: * Split from the single patch in v2 to clarify changes. (Neil) drivers/gpu/drm/bridge/nwl-dsi.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/br

Re: [PATCH v2] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-23 Thread Liu Ying
Hi Neil, On Thu, 2021-04-22 at 14:07 +0200, Neil Armstrong wrote: > Hi, > > On 22/04/2021 11:31, Liu Ying wrote: > > Hi Neil, > > > > On Thu, 2021-04-22 at 10:48 +0200, Neil Armstrong wrote: > > > Hi, > > > > > > On 22/04/2021 07:14, Li

Re: [PATCH v3 1/3] drm/bridge: nwl-dsi: Force a full modeset when crtc_state->active is changed to be true

2021-04-30 Thread Liu Ying
rm-misc-next. https://cgit.freedesktop.org/drm/drm-misc/commit/?id=885811372fe101c4299c53eecc9fee72cf927a0c I also see Guido's R-b and T-b tags on this series, though they comes after Neil's push perhaps. Thanks, Liu Ying > > On Fri, 23 Apr 2021 at 11:42, Liu Ying wrote: > &

Re: [PATCH v5 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2021-03-16 Thread Liu Ying
On Tue, 2021-03-16 at 16:38 -0600, Rob Herring wrote: > On Wed, Mar 10, 2021 at 05:55:31PM +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp Control and Status Registers > > module. > > > > Signed-off-by: Liu Ying > > --- > > v4-

[PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-16 Thread Liu Ying
egs() and of_graph_get_remote_endpoint() to get the input remote endpoint in imx8qxp_ldb_set_di_id() of i.MX8qxp LDB bridge driver. * Avoid using companion_port OF node after putting it in imx8qxp_ldb_parse_dt_companion() of i.MX8qxp LDB bridge driver. * Drop unnecessary check for maximum availa

[PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-16 Thread Liu Ying
bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- v5->v6: * Add Laurent's R-b tag. v4->v5: * Add Robert's R-b tag. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. include/uapi

[PATCH v6 02/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-16 Thread Liu Ying
or a 36-bit output bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v6 contains a fix. v5->v6: * Fix data organizations

[PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-16 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp pixel combiner. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use graph schema. (Laurent) * Use enum instead of oneOf

[PATCH v6 04/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support

2021-03-16 Thread Liu Ying
screens, or virtual screens. The pixel combiner is also responsible for generating some of the control signals for the pixel link output channel. For now, the driver only supports the bypass mode. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * Dr

[PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-16 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp display pixel link. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use graph schema. (Laurent) * Require all four pix

[PATCH v6 06/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2021-03-16 Thread Liu Ying
control interface. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * Make a comment occupy a line. (Robert) * Add Robert's R-b tag. v3->v4: * No change. v2->v3: * Drop two macros which help define functions and define them directly. * Pro

[PATCH v6 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2021-03-16 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp Control and Status Registers module. Signed-off-by: Liu Ying --- v5->v6: * Drop 'select' schema. (Rob) v4->v5: * Newly introduced in v5. (Rob) .../devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml | 192 + 1 f

[PATCH v6 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding

2021-03-16 Thread Liu Ying
This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * Add Rob's R-b tag. v4->v5: * No change. v3->v4: * Add 'fsl,sc-resource' property. (Rob) v2->v3: * Drop 'fsl,syscon' pro

[PATCH v6 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2021-03-16 Thread Liu Ying
codings between those modules. The PXL2DPI is purely combinatorial. Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Use 'fsl,sc-resource' DT property to get the SCU resource ID associated with the PXL2DPI instance instead of using alias ID. (R

[PATCH v6 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-16 Thread Liu Ying
This patch adds a helper to support LDB drm bridge drivers for i.MX SoCs. Helper functions supported by this helper should implement common logics for all LDB modules embedded in i.MX SoCs. Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * Make imx-ldb-helper be a pure object

[PATCH v6 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2021-03-16 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Rob's R-b tag. v2->v3: * Drop 'fsl,syscon' property. (Rob) * Mention the CSR module c

[PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-16 Thread Liu Ying
supports the LDB single mode and split mode. Signed-off-by: Liu Ying --- Note that this patch depends on the patch 'phy: Add LVDS configuration options', which has already been sent with the following series to add Mixel combo PHY found in i.MX8qxp: https://www.spinics.net/lists/arm-kernel

[PATCH v6 13/14] drm/bridge: imx: Add LDB support for i.MX8qm

2021-03-16 Thread Liu Ying
simultaneously, either in dual mode or split mode. In dual mode, the two channels output identical data. In split mode, channel0 outputs odd pixels and channel1 outputs even pixels. This patch supports the LDB single mode and split mode. Signed-off-by: Liu Ying --- Note that this patch depends on the patch

[PATCH v6 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs

2021-03-16 Thread Liu Ying
Add myself as the maintainer of DRM bridge drivers for i.MX SoCs. Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-17 Thread Liu Ying
Hi Vinod, On Wed, 2021-03-17 at 15:52 +0530, Vinod Koul wrote: > On 08-03-21, 11:52, Liu Ying wrote: > > This patch allows LVDS PHYs to be configured through > > the generic functions and through a custom structure > > added to the generic union. > > > > The p

[PATCH] drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used

2021-03-21 Thread Liu Ying
-off-by: Liu Ying --- This patch fixes an issue introduced in v5.12-rc1. It would be good to fix sooner than later. drivers/gpu/drm/imx/imx-ldb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index dbfe39e

[PATCH] drm/imx: ipuv3-plane: Remove two unnecessary export symbols

2021-03-21 Thread Liu Ying
: merge imx-drm-core and ipuv3-crtc in one module) Signed-off-by: Liu Ying --- drivers/gpu/drm/imx/ipuv3-plane.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 0755080..4bd39bb 100644 --- a/drivers/gpu/drm/imx/ipuv3

Re: [PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:23 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, RGB666_1X36_CPADLO > > and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp pixel combiner. >

Re: [PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:34 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Liu Ying > > --- > &g

Re: [PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:38 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp display pixel link. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Liu Ying > >

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-23 Thread Liu Ying
i > failed with error -12 > [1.840547] imx8qxp-lpcg-clk 5958.clock-controller: deferred probe > timeout, ignoring dependency > [1.840571] imx8qxp-lpcg-clk: probe of 5958.clock-controller failed > with error -110 > > Any suggestions welcome. Thanks! Please reference th

Re: [PATCH] drm/imx: fix out of bounds array access warning

2021-03-23 Thread Liu Ying
dev_warn(ldb->dev, > > +"%s: invalid mux\n", __func__); > > trivia: > > Any real reason to make this 2 lines? It fits nicely in 80 chars. Maybe: > > dev_warn(ldb->dev, "%s: invalid mux: %d\n", __func__, mux); > >

Re: [PATCH] drm/imx: fix out of bounds array access warning

2021-03-23 Thread Liu Ying
x86_64 It doesn't look like DRM_IMX_LDB is in the same case. Moreover, even if OF is enabled, drm_of_encoder_active_endpoint() is likely to return -EINVAL. So, it looks ok to add an error check. Regards, Liu Ying > > --- a/drivers/gpu/drm/imx/Kconfig > +++ b/drivers/gpu/drm/imx/Kconfig

Re: [PATCH] drm/imx: fix out of bounds array access warning

2021-03-23 Thread Liu Ying
Hi Arnd, Thanks for your patch. It would be good to improve the patch's head line to something like: drm/imx: imx-ldb: fix out of bounds array access warning Regards, Liu Ying On Tue, 2021-03-23 at 14:05 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_

Re: [PATCH] [v3] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread Liu Ying
n that may be > triggered at runtime. > > The warning could be fixed by adding a Kconfig depedency on CONFIG_OF, > but Liu Ying points out that the driver may hit the out-of-bounds > problem at runtime anyway. Almost impossible to hit the out-of-bounds problem at runtime, unless s

[PATCH v5 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2021-03-25 Thread Liu Ying
v1->v2: * Convert mixel,mipi-dsi-phy plain text dt binding to json-schema. (Guido) * Print invalid PHY mode in dmesg from the Mixel PHY driver. (Guido) * Add Guido's R-b tag on the patch for the nwl-dsi drm bridge driver. Liu Ying (5): drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable

[PATCH v5 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()

2021-03-25 Thread Liu Ying
Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * No change.

[PATCH v5 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Liu Ying
I Cc: Vinod Koul Cc: NXP Linux Team Signed-off-by: Liu Ying --- v4->v5: * Align kernel-doc style to include/linux/phy/phy.h. (Vinod) * Trivial tweaks. * Drop Robert's R-b tag. v3->v4: * Add Robert's R-b tag. v2->v3: * No change. v1->v2: * No change. include/lin

[PATCH v5 3/5] dt-bindings: phy: Convert mixel, mipi-dsi-phy to json-schema

2021-03-25 Thread Liu Ying
ido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * Add Rob's and Guido's R-b tags. v2->v3: * Improve the 'clock-names&

[PATCH v5 4/5] dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp

2021-03-25 Thread Liu Ying
Add support for Mixel MIPI DPHY + LVDS PHY combo IP as found on Freescale i.MX8qxp SoC. Cc: Guido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v4->v5: * No change.

[PATCH v5 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2021-03-25 Thread Liu Ying
-by: Guido Günther Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * Add Guido's R-b tag. v2->v3: * Improve readability of mixel_dphy_set_mode(). (Guido) v1->v2: * Print invalid PHY mode in dmesg. (Guido) drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 269

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Liu Ying
Hi Vinod, On Thu, 2021-03-25 at 12:58 +0530, Vinod Koul wrote: > On 18-03-21, 10:22, Liu Ying wrote: > > > > Can we have these in kernel-doc style please, similar to style in > > > linux/phy/phy.h > > > > I take this way of in-line member documentation

[PATCH v2] drm/imx: ipuv3-plane: Remove two unnecessary export symbols

2021-03-25 Thread Liu Ying
: merge imx-drm-core and ipuv3-crtc in one module) Signed-off-by: Liu Ying --- v2: * Fix commit message typo - s/ipu_plane_assign_pre/ipu_planes_assign_pre/ drivers/gpu/drm/imx/ipuv3-plane.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx

[PATCH v9 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-03-28 Thread Liu Ying
ded patch set to do basic conversions for the platforms. * Fix dt binding yamllint warnings. * Require bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's dt binding documentation. * Use new dt binding way to add clocks in the dt binding examples. * Address several comments from

[PATCH v9 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2021-03-28 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * Add Rob's R-b tag back. v5->v6: * Use graph schema. So, drop Rob's R-b tag as review is needed. v4

[PATCH v9 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2021-03-28 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Improve compatible prop

[PATCH v9 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2021-03-28 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * N

[PATCH v9 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2021-03-28 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Signed-off-by: Liu Ying --- v8->v9: * Reference 'interrupts-extended' schema instead of 'interrupts' to require an additional interrupt(r_rtram_stall) because the reference manual does mentio

[PATCH v9 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2021-03-28 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAIN

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-29 Thread Liu Ying
Hi Marcel, On Mon, 2021-03-29 at 00:49 +, Marcel Ziswiler wrote: > Hi Liu > > On Tue, 2021-03-23 at 17:09 +0800, Liu Ying wrote: > > On Tue, 2021-03-23 at 01:03 +, Marcel Ziswiler wrote: > > > Hi Liu > > > > > > Some further discrepancy wit

Re: [PATCH v6 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2021-03-30 Thread Liu Ying
nts from 'checkpatch.pl --strict' for the pixel combiner driver(patch 4/16) and pixel link driver(patch 6/16). If no objections, I'll keep your R-b tags on them. > > On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qxp pixel

Re: [PATCH v6 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-30 Thread Liu Ying
Hi Robert, On Tue, 2021-03-30 at 11:46 +0200, Robert Foss wrote: > Hey Liu, > > checkpatch --strict is listing some nits for this patch, with those > fixed feel free to add my r-b. > > Reviewed-by: Robert Foss Thanks for your review. Will fix those nits in the next

Re: [PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-30 Thread Liu Ying
w. Will fix those nits and that warning in the next version. Liu Ying ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-30 Thread Liu Ying
On Tue, 2021-03-30 at 11:54 +0200, Robert Foss wrote: > Hey Liu, > > checkpatch --strict lists some nit and a warning. With those fixed > feel free to add my r-b. > > On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qxp

Re: [PATCH v6 13/14] drm/bridge: imx: Add LDB support for i.MX8qm

2021-03-30 Thread Liu Ying
warning you mentioned, is it the Kconfig warning? I'm asssuming it can also be ignored just like the one for patch 12/14? Liu Ying > > On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qm LVDS display bridge(LDB) > > which is off

[PATCH v7 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-30 Thread Liu Ying
i.MX8qxp LDB bridge driver. * Drop unnecessary check for maximum available LDB channels from i.MX8qm LDB bridge driver. * Mention i.MX8qm/qxp LDB official name 'pixel mapper' in i.MX8qm/qxp LDB bridge drivers and Kconfig help messages. Liu Ying (14): media: uapi: Add some RGB bu

[PATCH v7 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-30 Thread Liu Ying
bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * Add Laurent's R-b tag. v4->v5: * Add Robert's R-b tag. v3->v4: * No change. v2->v3: * No change. v1->v2:

[PATCH v7 02/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-30 Thread Liu Ying
or a 36-bit output bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v6 contains a fix. v6->v7: * No change. v5->v6: * Fi

[PATCH v7 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-30 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp pixel combiner. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use graph schema. (Laurent) * Us

[PATCH v7 04/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support

2021-03-30 Thread Liu Ying
-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v7 contains a fix for checkpatch complaints. Marcel, as the fix is trivial, I add your T-b tag. Let me know if you want me to drop it. v6->v7: * Fix 'Alignment should match open par

[PATCH v7 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-30 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp display pixel link. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use graph schema. (Laurent) *

[PATCH v7 06/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2021-03-30 Thread Liu Ying
control interface. Reviewed-by: Robert Foss Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Signed-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v7 contains a fix for checkpatch complaints. Marcel, as the fix is trivial

[PATCH v7 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2021-03-30 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp Control and Status Registers module. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * Add Rob's R-b tag. v5->v6: * Drop 'select' schema. (Rob) v4->v5: * Newly introduced in v5. (Rob) .../devicetree/bindings/

[PATCH v7 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding

2021-03-30 Thread Liu Ying
This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * Add Rob's R-b tag. v4->v5: * No change. v3->v4: * Add 'fsl,sc-resource' property. (Rob) v2->v3: * Drop 'fs

[PATCH v7 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2021-03-30 Thread Liu Ying
codings between those modules. The PXL2DPI is purely combinatorial. Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix and

[PATCH v7 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-30 Thread Liu Ying
-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix in v7 is trivial. v6->v7: * Fix below complaints from 'checkpatch.pl --strict'. (Robert) - 'Alignment should match open parenthesis' - 'Prefe

[PATCH v7 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2021-03-30 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Rob's R-b tag. v2->v3: * Drop 'fsl,syscon' property. (Rob) * M

[PATCH v7 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-30 Thread Liu Ying
supports the LDB single mode and split mode. Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Note that this patch depends on the patch 'phy: Add LVDS configuration options', which has already been sent with the follow

[PATCH v7 13/14] drm/bridge: imx: Add LDB support for i.MX8qm

2021-03-30 Thread Liu Ying
Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Note that this patch depends on the patch 'phy: Add LVDS configuration options', which has already been sent with the following series to add Mixel combo PHY found in i.MX8qxp: https://www.spinics.net/lists/devicetree/msg414149.html

[PATCH v7 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs

2021-03-30 Thread Liu Ying
Add myself as the maintainer of DRM bridge drivers for i.MX SoCs. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v6->v7: * Add Robert's R-b tag. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAINTAI

Re: [PATCH v5 2/5] phy: Add LVDS configuration options

2021-04-01 Thread Liu Ying
Hi Kishon, First of all, thanks for your review. On Wed, 2021-03-31 at 19:02 +0530, Kishon Vijay Abraham I wrote: > Hi, > > On 25/03/21 2:30 pm, Liu Ying wrote: > > This patch allows LVDS PHYs to be configured through > > the generic functions and through a custom struc

Re: [PATCH v7 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2021-04-01 Thread Liu Ying
On Wed, 2021-03-31 at 08:40 -0500, Rob Herring wrote: > On Wed, 31 Mar 2021 14:33:18 +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp Control and Status Registers > > module. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Liu Ying > &

[PATCH v2 05/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support

2021-01-15 Thread Liu Ying
screens, or virtual screens. The pixel combiner is also responsible for generating some of the control signals for the pixel link output channel. For now, the driver only supports the bypass mode. Signed-off-by: Liu Ying --- v1->v2: * No change. drivers/gpu/drm/bridge/Kcon

[PATCH v2 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-01-15 Thread Liu Ying
supports the LDB single mode and split mode. Signed-off-by: Liu Ying --- v1->v2: * Drop unnecessary DT validation. * Use of_graph_get_endpoint_by_regs() and of_graph_get_remote_endpoint() to get the input remote endpoint in imx8qxp_ldb_set_di_id(). * Avoid using companion_port OF node after putting

[PATCH v2 01/14] phy: Add LVDS configuration options

2021-01-15 Thread Liu Ying
I Cc: Vinod Koul Cc: NXP Linux Team Signed-off-by: Liu Ying --- v1->v2: * No change. include/linux/phy/phy-lvds.h | 48 include/linux/phy/phy.h | 4 2 files changed, 52 insertions(+) create mode 100644 include/linux/phy/phy-lvds.h d

[PATCH v2 07/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2021-01-15 Thread Liu Ying
control interface. Signed-off-by: Liu Ying --- v1->v2: * Rewrite the function to find the next bridge by properly using OF APIs and dropping unnecessary DT validation. (Rob) drivers/gpu/drm/bridge/imx/Kconfig | 8 + drivers/gpu/drm/bridge/imx/Makefile |

[PATCH v2 13/14] drm/bridge: imx: Add LDB support for i.MX8qm

2021-01-15 Thread Liu Ying
simultaneously, either in dual mode or split mode. In dual mode, the two channels output identical data. In split mode, channel0 outputs odd pixels and channel1 outputs even pixels. This patch supports the LDB single mode and split mode. Signed-off-by: Liu Ying --- v1->v2: * Drop unnecessary check

[PATCH v2 04/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-01-15 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp pixel combiner. Signed-off-by: Liu Ying --- v1->v2: * Use graph schema. (Laurent) * Use enum instead of oneOf + const for the reg property of pixel combiner channels. (Rob) .../display/bridge/fsl,imx8qxp-pixel-combiner.yaml |

[PATCH v2 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2021-01-15 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). Signed-off-by: Liu Ying --- v1->v2: * Use graph schema. (Laurent) * Side note i.MX8qxp LDB official name 'pixel mapper'. (Laurent) .../bindings/display/bridge/fsl,imx8qxp-ldb.yaml | 176 + 1

[PATCH v2 02/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-01-15 Thread Liu Ying
bus(12-bit per component) to a pixel link. Signed-off-by: Liu Ying --- v1->v2: * No change. include/uapi/linux/media-bus-format.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h index 0dfc

[PATCH v2 03/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-01-15 Thread Liu Ying
or a 36-bit output bus(12-bit per component) to a pixel link. Signed-off-by: Liu Ying --- v1->v2: * No change. .../userspace-api/media/v4l/subdev-formats.rst | 156 + 1 file changed, 156 insertions(+) diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.

[PATCH v2 10/14] drm/bridge: imx: Add LDB driver helper support

2021-01-15 Thread Liu Ying
This patch adds a helper to support LDB drm bridge drivers for i.MX SoCs. Helper functions exported from this driver should implement common logics for all LDB modules embedded in i.MX SoCs. Signed-off-by: Liu Ying --- v1->v2: * No change. drivers/gpu/drm/bridge/imx/Kconfig |

[PATCH v2 06/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-01-15 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp display pixel link. Signed-off-by: Liu Ying --- v1->v2: * Use graph schema. (Laurent) * Require all four pixel link output ports. (Laurent) * Mention pixel link is accessed via SCU firmware. (Rob) .../display/bridge/fsl,imx8qxp-pixel-link.yaml |

[PATCH v2 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding

2021-01-15 Thread Liu Ying
This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). Signed-off-by: Liu Ying --- v1->v2: * Use graph schema. (Laurent) .../display/bridge/fsl,imx8qxp-pxl2dpi.yaml| 105 + 1 file changed, 105 insertions(+) create mode 100644 Documentation/devicet

[PATCH v2 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-01-15 Thread Liu Ying
i.MX8qm LDB bridge driver. * Mention i.MX8qm/qxp LDB official name 'pixel mapper' in i.MX8qm/qxp LDB bridge drivers and Kconfig help messages. Liu Ying (14): phy: Add LVDS configuration options media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner media: docs: Add s

[PATCH v2 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs

2021-01-15 Thread Liu Ying
Add myself as the maintainer of DRM bridge drivers for i.MX SoCs. Signed-off-by: Liu Ying --- v1->v2: * No change. MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 389abcf..539dc58 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -589

[PATCH v2 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2021-01-15 Thread Liu Ying
codings between those modules. The PXL2DPI is purely combinatorial. Signed-off-by: Liu Ying --- v1->v2: * Drop unnecessary port availability check. drivers/gpu/drm/bridge/imx/Kconfig | 8 + drivers/gpu/drm/bridge/imx/Makefile | 1 + drivers/gpu/drm/bridge/imx/imx8

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-21 Thread Liu Ying
Hi Laurentiu, On Fri, 2021-01-15 at 19:27 +0200, Laurentiu Palcu wrote: > Hi Liu Ying, > > I promised I would have a second, more in-depth, look at this and I finally > managed to do it. Thanks. > > I have to admit it was a challenge. Partially because I'm not very

[PATCH v6 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2021-01-21 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Signed-off-by: Liu Ying --- v5->v6: * Use graph schema. So, drop Rob's R-b tag as review is needed. v4->v5: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob) * Add Rob&

[PATCH v6 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2021-01-21 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v6 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-21 Thread Liu Ying
y to add clocks in the dt binding examples. * Address several comments from Laurentiu on the DPU DRM patch. Liu Ying (6): dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding dt-bindings: display: imx: Add i.MX8qxp/qm

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-21 Thread Liu Ying
On Wed, 2021-01-20 at 11:27 +0200, Laurentiu Palcu wrote: > Hi Liu Ying, > > On Wed, Jan 20, 2021 at 04:42:50PM +0800, Liu Ying wrote: > > Hi Laurentiu, > > > > On Fri, 2021-01-15 at 19:27 +0200, Laurentiu Palcu wrote: > > > Hi Liu Ying, > > > &g

[PATCH v6 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2021-01-21 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob) * Add Rob's R-b tag. v2-&g

[PATCH v6 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2021-01-21 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v5->v6: * Fix commit message typo - s/Artifically/Artificial

[PATCH v6 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2021-01-21 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob) * Add Rob's R-b tag. v2-&g

[PATCH v7 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2021-01-26 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob) * Add R

[PATCH v7 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2021-01-26 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * Fix commit message typo -

  1   2   3   4   5   6   7   8   9   10   >