[PATCH 3/3] drm/cma: remove GEM CMA specific dma_buf functionality

2013-06-12 Thread Joonyoung Shim
We can use prime helpers instead. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_gem_cma_helper.c | 283 --- include/drm/drm_gem_cma_helper.h | 6 - 2 files changed, 289 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu

Re: [PATCH 1/3] drm: add mmap function to prime helpers

2013-06-16 Thread Joonyoung Shim
On 06/15/2013 02:16 AM, Aaron Plattner wrote: On 06/12/2013 06:16 AM, Joonyoung Shim wrote: This adds to call low-level mmap() from prime helpers. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_prime.c | 5 - include/drm/drmP.h | 2 ++ 2 files changed, 6 insertions

Re: [PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality

2013-06-18 Thread Joonyoung Shim
On 06/19/2013 08:02 AM, Laurent Pinchart wrote: Hi Joonyoung, On Wednesday 12 June 2013 22:16:14 Joonyoung Shim wrote: Hi, GEM CMA supports dma_buf but it needs GEM CMA specific functionality for dma_buf. We can use prime helpers for dma_buf by commit 89177644a7b6306e6084a89eab7e290f4bfef397

[PATCH] drm/prime: support to cache mapping

2013-06-18 Thread Joonyoung Shim
The drm prime also can support it like GEM CMA supports to cache mapping. It doesn't allow multiple mappings for one attachment. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_prime.c | 54 + 1 file changed, 50 insertions(+), 4 dele

[PATCH v2 0/3] drm/cma: use prime helpers instead GEM CMA specific dma_buf functionality

2013-06-27 Thread Joonyoung Shim
ULL from "drm: add mmap function to prime helpers" commit Joonyoung Shim (3): drm: add mmap function to prime helpers drm/cma: add low-level hook functions to use prime helpers drm/cma: remove GEM CMA specific dma_buf functionality drivers/gpu/drm/drm_ge

[PATCH v2 2/3] drm/cma: add low-level hook functions to use prime helpers

2013-06-27 Thread Joonyoung Shim
Instead of using the dma_buf functionality for GEM CMA, we can use prime helpers if we can provide low-level hook functions for GEM CMA. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_gem_cma_helper.c | 79 include/drm/drm_gem_cma_helper.h | 9

[PATCH v2 1/3] drm: add mmap function to prime helpers

2013-06-27 Thread Joonyoung Shim
This adds to call low-level mmap() from prime helpers. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_prime.c | 8 +++- include/drm/drmP.h | 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index

[PATCH v2 3/3] drm/cma: remove GEM CMA specific dma_buf functionality

2013-06-27 Thread Joonyoung Shim
We can use prime helpers instead. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_gem_cma_helper.c | 286 --- include/drm/drm_gem_cma_helper.h | 6 - 2 files changed, 292 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu

Re: [PATCH v2 0/3] drm/cma: use prime helpers instead GEM CMA specific dma_buf functionality

2013-07-04 Thread Joonyoung Shim
On 07/04/2013 07:11 AM, Laurent Pinchart wrote: Hi Joonyoung, Thank you for the patches. On Friday 28 June 2013 14:24:43 Joonyoung Shim wrote: Hello, This is the second version patchset. GEM CMA supports dma_buf but it needs GEM CMA specific functionality for dma_buf. We can use prime

[PATCH] drm/prime: fix sgt NULL checking

2013-07-04 Thread Joonyoung Shim
The drm_gem_map_detach() can be called with sgt is NULL. Change-Id: I3b2f5878dfac6e1e77aebeeb7be781113dec59a7 Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_prime.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu

[PATCH RESEND] drm/prime: fix sgt NULL checking

2013-07-04 Thread Joonyoung Shim
The drm_gem_map_detach() can be called with sgt is NULL. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_prime.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index 1e0de41..ff5fece 100644 --- a

Re: [PATCH v2 0/3] drm/cma: use prime helpers instead GEM CMA specific dma_buf functionality

2013-07-04 Thread Joonyoung Shim
On 07/05/2013 02:38 PM, Dave Airlie wrote: On Thu, Jul 4, 2013 at 5:14 PM, Joonyoung Shim wrote: On 07/04/2013 07:11 AM, Laurent Pinchart wrote: Hi Joonyoung, Thank you for the patches. On Friday 28 June 2013 14:24:43 Joonyoung Shim wrote: Hello, This is the second version patchset. GEM

[PATCH] drm: cma: fix refcounting on the dmabuf import error path

2013-07-04 Thread Joonyoung Shim
>From drm gem CMA helper, it wasn't fixed dma_buf refcount problem fixed by commit 011c228. This patch solves it. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_gem_cma_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_cma_hel

Re: [PATCH] drm: cma: fix refcounting on the dmabuf import error path

2013-07-08 Thread Joonyoung Shim
On 07/05/2013 06:46 PM, Laurent Pinchart wrote: Hi Joonyoung, Thank you for the patch. On Friday 05 July 2013 15:32:35 Joonyoung Shim wrote: From drm gem CMA helper, it wasn't fixed dma_buf refcount problem fixed by commit 011c228. This patch solves it. Please add a &q

Re: [PATCH v2 0/3] drm/cma: use prime helpers instead GEM CMA specific dma_buf functionality

2013-07-08 Thread Joonyoung Shim
On 07/05/2013 10:03 PM, Laurent Pinchart wrote: Hi Joonyoung, On Friday 05 July 2013 15:30:25 Joonyoung Shim wrote: On 07/05/2013 02:38 PM, Dave Airlie wrote: On Thu, Jul 4, 2013 at 5:14 PM, Joonyoung Shim wrote: On 07/04/2013 07:11 AM, Laurent Pinchart wrote: On Friday 28 June 2013 14:24

Re: [RFC] Updated DRM plane handling patches

2011-07-21 Thread Joonyoung Shim
lanes, controlling attributes, etc) but it's enough to get bits on the > screen at least. > Could you share libdrm patch for drm plane? -- - Joonyoung Shim ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/4] drm: add plane support

2011-07-21 Thread Joonyoung Shim
 0 >  #define DRM_MODE_ENCODER_DAC   1 >  #define DRM_MODE_ENCODER_TMDS  2 > -- > 1.7.4.1 > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > -- - Joonyoung Shim ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/4] drm: add plane support

2011-07-25 Thread Joonyoung Shim
2011/7/22 Jesse Barnes : > On Thu, 21 Jul 2011 19:30:00 +0900 > Joonyoung Shim wrote: > >> Hi, >> >> simple questions :) >> >> 2011/6/21 Jesse Barnes : >> > Planes are a bit like half-CRTCs.  They have a location and fb, but >> > don't

Re: [PATCH 1/4] drm: add plane support

2011-07-25 Thread Joonyoung Shim
2011/7/25 Rob Clark : > On Mon, Jul 25, 2011 at 3:18 AM, Joonyoung Shim wrote: >> 2011/7/22 Jesse Barnes : >>> On Thu, 21 Jul 2011 19:30:00 +0900 >>> Joonyoung Shim wrote: >>> >>>> Hi, >>>> >>>> simple questions :) >>&

[RFC PATCH] DRM: Add drm backlight dpms interface

2011-07-27 Thread Joonyoung Shim
The backlight devices have the ability to control their power levels and it is supported by backlight framework or lcd framework. This helps use to drm the functions to control power levels of the existing backlight framework or lcd framework. Signed-off-by: Joonyoung Shim Signed-off-by

[PATCH 1/2] drm: Fix irq install error handling

2011-08-03 Thread Joonyoung Shim
The registered irq should be unregistered by free_irq() if irq_postinstall() returns the error after request_irq() is called successfully. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_irq.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

[PATCH 2/2] drm: Add NULL check about irq functions

2011-08-03 Thread Joonyoung Shim
The struct drm_driver has some function pointers for irq. They are gpu specific and some functions aren't essential things. This can prevents creation of unnecessary dummy function for irq. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_irq.c |

[PATCH] drm: Fix the number of connector and encoder to cleanup functions

2011-08-26 Thread Joonyoung Shim
It is left out the code to decrease the number of connector and encoder to the cleanup functions. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_crtc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-30 Thread Joonyoung Shim
+static void samsung_drm_connector_destroy(struct drm_connector *connector) +{ + struct samsung_drm_connector *samsung_connector = + to_samsung_connector(connector); + + DRM_DEBUG_KMS("%s\n", __FILE__); + + drm_sysfs_connector_remove(connector); + drm_connecto

Re: [RFC] Updated plane support v3

2011-09-19 Thread Joonyoung Shim
2011/6/21 Jesse Barnes : > This version adds both source and dest rect params to the set_plane > ioctl, and makes the source fixed point to support hardware that needs > it. > > I haven't changed the name of the SNB implementation yet (per Chris's > suggestions) but will before it gets upstream. >

[PATCH 01/11] drm: add plane support

2011-10-25 Thread Joonyoung Shim
10/25/2011 06:46 PM, Jesse Barnes ? ?: > Planes are a bit like half-CRTCs. They have a location and fb, but > don't drive outputs directly. Add support for handling them to the core > KMS code. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/drm_crtc.c | 236 >

DRM planes and new fb creation ioctl

2011-10-25 Thread Joonyoung Shim
Hi, Jesse. Thanks for posting. 10/25/2011 06:46 PM, Jesse Barnes ? ?: > I've given up waiting for someone to implement support for these ioctls > on another platform before they're merged, but I have received a lot of > feedback on the interfaces, and it sounds like they're ok. I've also > fixed

[PATCH 01/11] drm: add plane support

2011-10-26 Thread Joonyoung Shim
10/25/2011 08:18 PM, Jesse Barnes ? ?: > On Tue, 25 Oct 2011 19:53:02 +0900 > Joonyoung Shim wrote: >>> +/** >>> + * drm_plane - central DRM plane control structure >>> + * @dev: DRM device this plane belongs to >>> + * @kdev: kernel device >>>

DRM planes and new fb creation ioctl

2011-10-26 Thread Joonyoung Shim
10/25/2011 08:13 PM, Jesse Barnes ? ?: > On Tue, 25 Oct 2011 19:47:13 +0900 > Joonyoung Shim wrote: >> 10/25/2011 06:46 PM, Jesse Barnes ? ?: >>> I've given up waiting for someone to implement support for these >>> ioctls on another platform before they're

[PATCH 01/11] drm: add plane support

2011-10-26 Thread Joonyoung Shim
10/25/2011 06:46 PM, Jesse Barnes ? ?: [snip] > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index 8020798..d7f03aa 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -44,6 +44,7 @@ struct drm_framebuffer; > #define DRM_MODE_OBJECT_PROPERTY 0xb0b0b0b0 >

[RFC] Updated plane support v3

2011-09-19 Thread Joonyoung Shim
2011/6/21 Jesse Barnes : > This version adds both source and dest rect params to the set_plane > ioctl, and makes the source fixed point to support hardware that needs > it. > > I haven't changed the name of the SNB implementation yet (per Chris's > suggestions) but will before it gets upstream. >

[PATCH 0/4] code cleanup patchset of drm/exynos

2012-04-05 Thread Joonyoung Shim
branch. Thanks. Joonyoung Shim (4): drm/exynos: remove unnecessary type conversion of hdmi and mixer drm/exynos: remove unused codes in hdmi and mixer driver drm/exynos: fix struct for operation callback functions to driver name drm/exynos: fix to pointer manager member of

[PATCH 1/4] drm/exynos: remove unnecessary type conversion of hdmi and mixer

2012-04-05 Thread Joonyoung Shim
When the void pointer type variable is assigned to the specific pointer type variable, don't need to do type conversion. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 22 +++--- drivers/gpu/drm/exynos/exynos_mi

[PATCH 2/4] drm/exynos: remove unused codes in hdmi and mixer driver

2012-04-05 Thread Joonyoung Shim
Some defines and members in struct mixer_context aren't used, remove them. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c |1 - drivers/gpu/drm/exynos/exynos_mixer.c | 21 + 2 files changed, 9 insertions(+

[PATCH 3/4] drm/exynos: fix struct for operation callback functions to driver name

2012-04-05 Thread Joonyoung Shim
functions at the same time. Use their struct names to driver name. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 92 +- drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 23 +++- drivers/gpu/drm/exynos/exynos_hdmi.c

[PATCH 4/4] drm/exynos: fix to pointer manager member of struct exynos_drm_subdrv

2012-04-05 Thread Joonyoung Shim
The struct exynos_drm_manager has to exist for exynos drm sub driver using encoder and connector. If it isn't NULL to member of struct exynos_drm_subdrv, will create encoder and connector else will not. And the is_local member also doesn't need. Signed-off-by: Joonyoung Shim Sig

[PATCH 2/4] drm/exynos: remove unused codes in hdmi and mixer driver

2012-04-05 Thread Joonyoung Shim
On 04/05/2012 07:38 PM, Semwal, Sumit wrote: > Hi Joonyoung, > > On Thu, Apr 5, 2012 at 3:53 PM, Joonyoung Shim > wrote: >> Some defines and members in struct mixer_context aren't used, remove >> them. >> >> Signed-off-by: Joonyoung Shim >> Signe

[PATCH 2/4] drm/exynos: remove unused codes in hdmi and mixer driver

2012-04-05 Thread Joonyoung Shim
On 04/05/2012 08:00 PM, Daniel Vetter wrote: > On Thu, Apr 05, 2012 at 07:53:43PM +0900, Joonyoung Shim wrote: >> On 04/05/2012 07:38 PM, Semwal, Sumit wrote: >>> Hi Joonyoung, >>> >>> On Thu, Apr 5, 2012 at 3:53 PM, Joonyoung Shim >>> w

[PATCH v2 0/6] code cleanup patchset of drm/exynos

2012-04-05 Thread Joonyoung Shim
-fixes branch. Thanks. v2: Split "[PATCH 2/4] drm/exynos: remove unused codes in hdmi and mixer driver" patch of patchset v1. Joonyoung Shim (6): drm/exynos: remove unnecessary type conversion of hdmi and mixer drm/exynos: remove unused codes in hdmi and mixer drm/exyn

[PATCH 1/6] drm/exynos: remove unnecessary type conversion of hdmi and mixer

2012-04-05 Thread Joonyoung Shim
When the void pointer type variable is assigned to the specific pointer type variable, don't need to do type conversion. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 22 +++--- drivers/gpu/drm/exynos/exynos_mi

[PATCH 2/6] drm/exynos: remove unused codes in hdmi and mixer

2012-04-05 Thread Joonyoung Shim
Some members in struct mixer_context aren't used and the define HDMI_OVERLAY_NUMBER is unused in hdmi driver, remove them. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c |1 - drivers/gpu/drm/exynos/exynos_mixer.c |3 --- 2

[PATCH 3/6] drm/exynos: rename s/HDMI_OVERLAY_NUMBER/MIXER_WIN_NR

2012-04-05 Thread Joonyoung Shim
HDMI_OVERLAY_NUMBER is specific of mixer driver and be used "windows layer" term in exynos user manaual, so rename it. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_mixer.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/

[PATCH 4/6] drm/exynos: use define instead of default_win member in struct mixer_context

2012-04-05 Thread Joonyoung Shim
The default_win member in struct mixer_context isn't change its value after initialized to 0, so it's better using to define. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_mixer.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH 5/6] drm/exynos: fix struct for operation callback functions to driver name

2012-04-05 Thread Joonyoung Shim
functions at the same time. Use their struct names to driver name. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 92 +- drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 23 +++- drivers/gpu/drm/exynos/exynos_hdmi.c

[PATCH 6/6] drm/exynos: fix to pointer manager member of struct exynos_drm_subdrv

2012-04-05 Thread Joonyoung Shim
The struct exynos_drm_manager has to exist for exynos drm sub driver using encoder and connector. If it isn't NULL to member of struct exynos_drm_subdrv, will create encoder and connector else will not. And the is_local member also doesn't need. Signed-off-by: Joonyoung Shim Sig

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Joonyoung Shim
g the framebuffer of plane via event. If DRM_MODE_PLANE_EVENT is added, we can also do pageflip of a plane. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_crtc.c | 45 --- include/drm/drm.h |1 + include/drm/drm_c

[PATCH] drm: fix page_flip error handling

2012-04-18 Thread Joonyoung Shim
Free event and restore event_space only when page_flip->flags has DRM_MODE_PAGE_FLIP_EVENT if page_flip() is failed. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_crtc.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --gi

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Joonyoung Shim
On 04/18/2012 05:46 PM, Daniel Vetter wrote: > On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: >> DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is >> for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to >> prov

[PATCH 5/5] drm/exynos: add PM functions for hdmi and mixer

2012-04-23 Thread Joonyoung Shim
This patch supports the PM for hdmi and mixer. Turn off hdmi and mixer when suspended, and when resume, will turn on them by hdmi hotplug detection if hdmi is attached. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 32

[PATCH 0/5] Update dpms and PM for hdmi of exynos drm

2012-04-23 Thread Joonyoung Shim
This patchset is to support dpms and PM for hdmi of exynos drm. The exynos hdmi has internal and externel interrupt handler for hotplug detection. We can select whether use which interrupt handler by power state of hdmi. The base of this patchset is Linux 3.4-rc4. Joonyoung Shim (5): drm

[PATCH 1/5] drm/exynos: cleanup for hdmi platform data

2012-04-23 Thread Joonyoung Shim
The exynos_drm_hdmi_pdata struct have owned unnessary members. Remove them and add a function pointer to configure hdmi hotplug detection pin. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 13 ++--- include/drm/exynos_drm.h

[PATCH 2/5] drm/exynos: use platform_get_irq_byname for hdmi

2012-04-23 Thread Joonyoung Shim
The exynos hdmi supports two hdmi interrupts - external and internal, so use platform_get_irq_byname to distinguish their resources. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 11 +-- 1 files changed, 5 insertions(+), 6

[PATCH 3/5] drm/exynos: use threaded irq for hdmi hotplug

2012-04-23 Thread Joonyoung Shim
We can use irq thread instead of workqueue Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 40 - 1 files changed, 5 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b

[PATCH 4/5] drm/exynos: add dpms for hdmi

2012-04-23 Thread Joonyoung Shim
: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 77 + drivers/gpu/drm/exynos/exynos_drm_hdmi.h |6 +- drivers/gpu/drm/exynos/exynos_hdmi.c | 276 +++- drivers/gpu/drm/exynos/exynos_mixer.c| 288

[PATCH v2] drm/exynos: add G2D driver

2012-04-26 Thread Joonyoung Shim
DRM_EXYNOS_G2D_EVENT: event to give notification completion of the command list to user Signed-off-by: Joonyoung Shim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- The validation check codes are added to this patch v2 to prevent security problem from patch v1.

[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-08-17 Thread Joonyoung Shim
; .probe = fimd_probe, > .remove = __devexit_p(fimd_remove), > + .id_table = exynos_drm_fimd_driver_ids, > .driver = { > - .name = "exynos4-fb", > + .name = "exynos-drm-fimd", > .owner = THIS_MODULE, > .pm = &fimd_pm_ops, > }, > -- > 1.7.0.4 > > ___ > devicetree-discuss mailing list > devicetree-discuss at lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss Thanks. -- - Joonyoung Shim

[PATCH V3 2/2] video: drm: exynos: Add device tree support

2012-08-17 Thread Joonyoung Shim
eturn PTR_ERR(pdata); > + } > if (!pdata) { > dev_err(dev, "no platform data specified\n"); > return -EINVAL; > @@ -1027,6 +1108,15 @@ static struct platform_device_id > exynos_drm_fimd_driver_ids[] = { > }; > MODULE_DEVICE_TABLE(platform, exynos_drm_fimd_driver_ids); > > +#ifdef CONFIG_OF > +static const struct of_device_id drm_fimd_dt_match[] = { > + { .compatible = "samsung,exynos5-drm", > + .data = &exynos5_drm_fimd_driver_data }, Add also samsung,exynos4-fb. > + {}, > +}; > +MODULE_DEVICE_TABLE(of, drm_fimd_dt_match); > +#endif > + > static const struct dev_pm_ops fimd_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(fimd_suspend, fimd_resume) > SET_RUNTIME_PM_OPS(fimd_runtime_suspend, fimd_runtime_resume, NULL) > @@ -1040,5 +1130,6 @@ struct platform_driver fimd_driver = { > .name = "exynos-drm-fimd", > .owner = THIS_MODULE, > .pm = &fimd_pm_ops, > + .of_match_table = of_match_ptr(drm_fimd_dt_match), > }, > }; > -- > 1.7.0.4 > > ___ > devicetree-discuss mailing list > devicetree-discuss at lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss Thanks. -- - Joonyoung Shim

[PATCH 02/13] drm/exynos: separated subdrv->probe call and encoder/connector creation.

2012-08-20 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: > this patch separates sub driver's probe call and encoder/connector creation > so that exynos drm core module can take exception when some operation was > failed properly. Which exceptions? I don't know this patch gives any benefit to us. > > Signed-off-by

[PATCH 04/13] drm/exynos: use empty function instead of drm_helper_connector_dpms

2012-08-20 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: > crtc and encoder's dpms callback will be called before connector's dpms > is called so drm_helper_connector_dpms doesn't need to be called. I can't understand this description. I know crtc and encoder dpms are called by drm_helper_connector_dpms. > Signed

[PATCH 05/13] drm/exynos: removed exynos_drm_encoder_dpms call

2012-08-20 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: > encoder's mode_set callback isn't specific to hardware so it doesn't > need to call exynos_drm_encoder_dpms(). Then, where is exynos_drm_encoder_dpms() called? > > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- > drivers/gpu/drm/exynos/e

[PATCH 09/13] drm/exynos: check NV12M format specific to Exynos properly

2012-08-20 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: > this patch adds buf_cnt variable in exynos_drm_fb structure and > that means a buffer count to drm framebuffer and also adds two > functions to get/set the buffer count from/to exynos_drm_fb structure. > if pixel format is not DRM_FORMAT_NV12MT then it gets

[PATCH 10/13] drm/exynos: update crtc to plane safely

2012-08-20 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: > if old_crtc isn't same as encoder->crtc then it means that > user changed crtc id to another one so a plane to old_crtc > should be disabled so that current plane can be updated safely > and plane->crtc should be set to new crtc(encoder->crtc) > > Signed-of

[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer

2012-08-20 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: > this patch changes ctx variable name in exynos_drm_hdmi_context > structure to client because the use of ctx variable makes it confused. I don't prefer "client" name. This is not client and server relationship. > > Signed-off-by: Inki Dae > Signed-off-by

[PATCH V3 2/2] video: drm: exynos: Add device tree support

2012-08-20 Thread Joonyoung Shim
On 08/17/2012 06:37 PM, Leela Krishna Amudala wrote: > Hello, > > On Fri, Aug 17, 2012 at 6:55 AM, Joonyoung Shim wrote: >> Hi, >> >> 2012/8/16 Leela Krishna Amudala : >>> Add device tree based discovery support for DRM-FIMD driver. >>

[PATCH 02/13] drm/exynos: separated subdrv->probe call and encoder/connector creation.

2012-08-20 Thread Joonyoung Shim
On 08/20/2012 10:52 AM, InKi Dae wrote: > 2012/8/20 Joonyoung Shim : >> On 08/17/2012 06:50 PM, Inki Dae wrote: >>> this patch separates sub driver's probe call and encoder/connector >>> creation >>> so that exynos drm core module can take exception wh

[PATCH 08/13] drm/exynos: make sure that hardware overlay for fimd is disabled

2012-08-20 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: > the values set to registers will be updated into real registers > at vsync so dma operation could be malfunctioned when accessed > to memory after gem buffer was released. this patch makes sure > that hw overlay is disabled before the gem buffer is released

[PATCH 02/13] drm/exynos: separated subdrv->probe call and encoder/connector creation.

2012-08-20 Thread Joonyoung Shim
On 08/20/2012 01:31 PM, InKi Dae wrote: > 2012/8/20 Joonyoung Shim : >> On 08/20/2012 10:52 AM, InKi Dae wrote: >>> 2012/8/20 Joonyoung Shim : >>>> On 08/17/2012 06:50 PM, Inki Dae wrote: >>>>> this patch separates sub driver's probe call and enc

[PATCH 09/13] drm/exynos: check NV12M format specific to Exynos properly

2012-08-20 Thread Joonyoung Shim
On 08/20/2012 11:23 AM, InKi Dae wrote: > 2012/8/20 Joonyoung Shim : >> On 08/17/2012 06:50 PM, Inki Dae wrote: >>> this patch adds buf_cnt variable in exynos_drm_fb structure and >>> that means a buffer count to drm framebuffer and also adds two >>> functions

[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer

2012-08-20 Thread Joonyoung Shim
On 08/20/2012 11:29 AM, InKi Dae wrote: > 2012/8/20 Joonyoung Shim : >> On 08/17/2012 06:50 PM, Inki Dae wrote: >>> this patch changes ctx variable name in exynos_drm_hdmi_context >>> structure to client because the use of ctx variable makes it confused. >> >>

[PATCH 09/13] drm/exynos: check NV12M format specific to Exynos properly

2012-08-20 Thread Joonyoung Shim
On 08/20/2012 02:15 PM, InKi Dae wrote: > sorry, again. > > 2012/8/20 InKi Dae : >> 2012/8/20 Joonyoung Shim : >>> On 08/20/2012 11:23 AM, InKi Dae wrote: >>>> 2012/8/20 Joonyoung Shim : >>>>> On 08/17/2012 06:50 PM, Inki Dae wrote: >&

[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer

2012-08-20 Thread Joonyoung Shim
On 08/20/2012 03:17 PM, InKi Dae wrote: > 2012/8/20 Joonyoung Shim : >> On 08/20/2012 11:29 AM, InKi Dae wrote: >>> 2012/8/20 Joonyoung Shim : >>>> On 08/17/2012 06:50 PM, Inki Dae wrote: >>>>> this patch changes ctx variable name in exynos_drm_hdmi_

[PATCH] drm/exynos: Make g2d_pm_ops static

2012-08-29 Thread Joonyoung Shim
On 08/28/2012 05:41 PM, Sachin Kamat wrote: > Fixes the following warning: > drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning: > symbol 'g2d_pm_ops' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +- > 1 files

[RFC v2 5/5] drm/exynos: add gsc ipp driver

2012-12-11 Thread Joonyoung Shim
Hi, On 12/10/2012 10:45 PM, Eunchul Kim wrote: > GSC is stand for General SCaler and supports supports > image scaler/rotator/crop/flip/csc and input/output DMA operations. > input DMA reads image data from the memory. > output DMA writes image data to memory. > GSC supports image rotation and ima

[RFC v2 5/5] drm/exynos: add gsc ipp driver

2012-12-11 Thread Joonyoung Shim
Hi, I want to see only just current codes, not for future. On 12/11/2012 04:47 PM, Eunchul Kim wrote: > Thank's your comments > > I answer your comments. please check that. > > Thank's > > BR > > Eunchul Kim > > On 12/11/2012 02:49 PM, Joonyoung Shim

[RFC v3 5/5] drm/exynos: add gsc ipp driver

2012-12-13 Thread Joonyoung Shim
Hi, I can't review about logic of driver because i don't know well but i feel there are too many checking codes and unused or big size defines. Please refer v4l2 exynos gsc driver in drivers/media/platform/exynos-gsc/. This v3 patch seems to add many codes than v2. Please write changelog in fut

[PATCH 1/4] drm/exynos: fix fb offset calculation for plane

2012-12-14 Thread Joonyoung Shim
There is no any reason to change fb offset when CRTC is out of screen. Also, this fixes a typing error. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_plane.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers

[PATCH 0/4] drm/exynos: update plane and fimd

2012-12-14 Thread Joonyoung Shim
This patchset is to update plane and fimd of exynos-drm. it includes modification about coordinates calculation of plane and fimd and device tree support of fimd. The patchset is based exynos-drm-next branch on of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git Joonyoung

[PATCH 2/4] drm/exynos: fix x, y coordinates for right bottom pixel

2012-12-14 Thread Joonyoung Shim
The x, y coordinates of right bottom pixel cannot be negative numbers. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 3/4] drm/exynos: support extended screen coordinate of fimd

2012-12-14 Thread Joonyoung Shim
The fimd of exynos5 SoC supports extended screen coordinate. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c

[PATCH 4/4] drm/exynos: support device tree for fimd

2012-12-14 Thread Joonyoung Shim
This adds the of_match_table to exynos-drm fimd driver to be probed from the device tree. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/exynos

[PATCH 1/2] drm: Fix irq install error handling

2011-08-04 Thread Joonyoung Shim
The registered irq should be unregistered by free_irq() if irq_postinstall() returns the error after request_irq() is called successfully. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_irq.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

[PATCH 2/2] drm: Add NULL check about irq functions

2011-08-04 Thread Joonyoung Shim
The struct drm_driver has some function pointers for irq. They are gpu specific and some functions aren't essential things. This can prevents creation of unnecessary dummy function for irq. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_irq.c |

[PATCH] drm: Fix the number of connector and encoder to cleanup functions

2011-08-27 Thread Joonyoung Shim
It is left out the code to decrease the number of connector and encoder to the cleanup functions. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_crtc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Joonyoung Shim
>> +static void samsung_drm_connector_destroy(struct drm_connector *connector) >> +{ >> + struct samsung_drm_connector *samsung_connector = >> + to_samsung_connector(connector); >> + >> + DRM_DEBUG_KMS("%s\n", __FILE__); >> + >> + drm_sysfs_connector_remove(connector

[PATCH] drm: Change order to turn off the crtc and plane with fb cleanup

2011-12-09 Thread Joonyoung Shim
Ths plane is enabled after the crtc is setted first, so first turn off the plane than the crtc. If not, it can occur some side effects because it may have to use any information of crtc when turns off the plane. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm

[PATCH 5/5] drm/exynos: Add plane support with fimd

2011-12-13 Thread Joonyoung Shim
On 12/13/2011 07:48 AM, Rob Clark wrote: > On Fri, Dec 9, 2011 at 4:59 AM, Inki Dae wrote: >> +static int >> +exynos_update_plane(struct drm_plane *plane, struct drm_crtc *crtc, >> +struct drm_framebuffer *fb, int crtc_x, int crtc_y, >> +unsigned int crtc_w,

[PATCH 5/5] drm/exynos: Add plane support with fimd

2011-12-13 Thread Joonyoung Shim
On 12/13/2011 06:59 AM, Rob Clark wrote: > On Fri, Dec 9, 2011 at 4:59 AM, Inki Dae wrote: >> From: Joonyoung Shim >> >> The exynos fimd supports 5 window overlays. Only one window overlay of >> fimd is used by the crtc, so we need plane feature to use the rest >

[PATCH] libdrm: fix sizes of memcpy to the drmModeAddFB2()

2011-12-14 Thread Joonyoung Shim
The variables(bo_handles, pitches and offsets) are the array having 4 elementary of uint32_t type. The their memcpy size is sizeof(uint32_t) * 4. Signed-off-by: Joonyoung Shim --- xf86drmMode.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xf86drmMode.c b

[PATCH v2 5/5] drm/exynos: Add plane support with fimd

2011-12-14 Thread Joonyoung Shim
-off-by: Joonyoung Shim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- v2: consider fixed point about src_x/src_y drivers/gpu/drm/exynos/Makefile |3 +- drivers/gpu/drm/exynos/exynos_drm_crtc.c|1 + drivers/gpu/drm/exynos/exynos_drm_drv.c |9 ++ drivers

[PATCH v2 5/5] drm/exynos: Add plane support with fimd

2011-12-15 Thread Joonyoung Shim
On 12/15/2011 02:26 AM, Jesse Barnes wrote: > On Wed, 14 Dec 2011 19:00:15 +0900 > Joonyoung Shim wrote: > >> The exynos fimd supports 5 window overlays. Only one window overlay of >> fimd is used by the crtc, so we need plane feature to use the rest >> window overl

[PATCH v3 5/5] drm/exynos: Add plane support with fimd

2011-12-15 Thread Joonyoung Shim
-off-by: Joonyoung Shim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- v2: consider fixed point about src_x/src_y v3: check to be validating the zpos ioctl parameter drivers/gpu/drm/exynos/Makefile |3 +- drivers/gpu/drm/exynos/exynos_drm_crtc.c|1 + drivers

[PATCH 1/5] drm: add plane support

2011-11-04 Thread Joonyoung Shim
11/03/2011 05:03 AM, Jesse Barnes ? ?: > Planes are a bit like half-CRTCs. They have a location and fb, but > don't drive outputs directly. Add support for handling them to the core > KMS code. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/drm_crtc.c | 236 >

[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-04 Thread Joonyoung Shim
11/03/2011 05:03 AM, Jesse Barnes ? ?: > To properly support the various plane formats supported by different > hardware, the kernel must know the pixel format of a framebuffer object. > So add a new ioctl taking a format argument corresponding to a fourcc > name from videodev2.h. > > Signed-off-by

[PATCH 1/5] drm: add plane support

2011-11-09 Thread Joonyoung Shim
er > Signed-off-by: Jesse Barnes Reviewed-by: Joonyoung Shim Thanks. > --- > drivers/gpu/drm/drm_crtc.c | 257 +++- > drivers/gpu/drm/drm_drv.c |3 + > include/drm/drm.h |3 + > include/drm/drm_crtc.h |

[PATCH] drm: Fix missed parenthesis

2011-11-19 Thread Joonyoung Shim
This adds a missed parenthesis in drm_mode.h header file. Signed-off-by: Joonyoung Shim --- include/drm/drm_mode.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 094da8a..27d7faf 100644 --- a/include/drm/drm_mode.h

Re: [PATCH] drm/exynos/decon5433: set STANDALONE_UPDATE_F also if planes are disabled

2017-01-13 Thread Joonyoung Shim
Hi Andrzej, On 01/13/2017 05:10 PM, Andrzej Hajda wrote: > STANDALONE_UPDATE_F should be set if something changed in plane > configurations, > including plane disable. > The patch fixes page-faults bugs, caused by decon still using framebuffers > of disabled planes. > > Signed-off-by: Andrzej Ha

Re: [PATCH v2] drm/exynos/decon5433: set STANDALONE_UPDATE_F also if planes are disabled

2017-01-13 Thread Joonyoung Shim
> + } > > if (ctx->out_type & IFTYPE_I80) > set_bit(BIT_WIN_UPDATED, &ctx->flags); > I tested on TM2E board, Tested-by: Joonyoung Shim Thanks. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[RFC] Updated DRM plane handling patches

2011-07-21 Thread Joonyoung Shim
lanes, controlling attributes, etc) but it's enough to get bits on the > screen at least. > Could you share libdrm patch for drm plane? -- - Joonyoung Shim

[PATCH 1/4] drm: add plane support

2011-07-21 Thread Joonyoung Shim
> ?#define DRM_MODE_ENCODER_DAC ? 1 > ?#define DRM_MODE_ENCODER_TMDS ?2 > -- > 1.7.4.1 > > ___ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > -- - Joonyoung Shim

[PATCH 1/4] drm: add plane support

2011-07-25 Thread Joonyoung Shim
2011/7/22 Jesse Barnes : > On Thu, 21 Jul 2011 19:30:00 +0900 > Joonyoung Shim wrote: > >> Hi, >> >> simple questions :) >> >> 2011/6/21 Jesse Barnes : >> > Planes are a bit like half-CRTCs. ?They have a location and fb, but >> > don't

<    1   2   3   4   5   6   >