On 12/15/2011 02:26 AM, Jesse Barnes wrote: > On Wed, 14 Dec 2011 19:00:15 +0900 > Joonyoung Shim<jy0922.shim at samsung.com> wrote: > >> The exynos fimd supports 5 window overlays. Only one window overlay of >> fimd is used by the crtc, so we need plane feature to use the rest >> window overlays. >> >> This creates one ioctl exynos specific - DRM_EXYNOS_PLANE_SET_ZPOS, it >> is the ioctl to decide for user to assign which window overlay. >> >> Signed-off-by: Joonyoung Shim<jy0922.shim at samsung.com> >> Signed-off-by: Inki Dae<inki.dae at samsung.com> >> Signed-off-by: Kyungmin Park<kyungmin.park at samsung.com> >> --- >> v2: consider fixed point about src_x/src_y > Looks pretty good; the only thing that jumped out was that you don't > seem to be validating the zpos ioctl parameters for sanity. Not sure > if there's much to do, but it may be worth checking for a max zpos or > something... >
OK, i added to check to be validating the zpos ioctl parameter. Thanks.
