On 04/05/2012 08:00 PM, Daniel Vetter wrote: > On Thu, Apr 05, 2012 at 07:53:43PM +0900, Joonyoung Shim wrote: >> On 04/05/2012 07:38 PM, Semwal, Sumit wrote: >>> Hi Joonyoung, >>> >>> On Thu, Apr 5, 2012 at 3:53 PM, Joonyoung Shim<jy0922.shim at samsung.com> >>> wrote: >>>> Some defines and members in struct mixer_context aren't used, remove >>>> them. >>>> >>>> Signed-off-by: Joonyoung Shim<jy0922.shim at samsung.com> >>>> Signed-off-by: Kyungmin Park<kyungmin.park at samsung.com> >>>> --- >>>> drivers/gpu/drm/exynos/exynos_hdmi.c | 1 - >>>> drivers/gpu/drm/exynos/exynos_mixer.c | 21 +++++++++------------ >>>> 2 files changed, 9 insertions(+), 13 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c >>>> b/drivers/gpu/drm/exynos/exynos_hdmi.c >>>> index 0a71317..340424f 100644 >>>> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c >>>> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c >>>> @@ -40,7 +40,6 @@ >>>> >>>> #include "exynos_hdmi.h" >>>> >>>> -#define HDMI_OVERLAY_NUMBER 3 >>>> #define MAX_WIDTH 1920 >>>> #define MAX_HEIGHT 1080 >>>> #define get_hdmi_context(dev) >>>> platform_get_drvdata(to_platform_device(dev)) >>>> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c >>>> b/drivers/gpu/drm/exynos/exynos_mixer.c >>>> index 495a7af..563092e 100644 >>>> --- a/drivers/gpu/drm/exynos/exynos_mixer.c >>>> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c >>>> @@ -37,7 +37,8 @@ >>>> #include "exynos_drm_drv.h" >>>> #include "exynos_drm_hdmi.h" >>>> >>>> -#define HDMI_OVERLAY_NUMBER 3 >>>> +#define MIXER_WIN_NR 3 >>>> +#define MIXER_DEFAULT_WIN 0 >>> Patch description says 'remove unused codes...', but looks like you're >>> adding more codes here? I think you should do the addition / deletion >>> in separate patches. >> "remove unused codes" is incorrect a bit, but please think this is just code >> cleanup to remove unnecessary codes. > Commit messages that flat-out lie in this way are bad. You need to at > least mention what additional stuff you're doing in the commit message, > besides removing unused code. Or split the patch up as Sumit suggested. >
OK, i will do it. Thanks.
