Re: [PATCH v1 07/10] drm/mediatek: add pseudo ovl support for MT8195

2021-07-19 Thread CK Hu
Hi, Nancy: On Sat, 2021-07-17 at 17:04 +0800, Nancy.Lin wrote: > Add pseudo ovl module files: > Pseudo ovl is an encapsulated module and designed for simplified > DRM control flow. This module is composed of 8 RDMAs and 4 MERGEs. > Two RDMAs merge into one layer, so this module support 4 > layers

Re: [PATCH v1 06/10] drm/mediatek: add ETHDR support for MT8195

2021-07-21 Thread CK Hu
Hi, Nancy: On Thu, 2021-07-22 at 09:32 +0800, Nancy.Lin wrote: > Hi Chun-Kuang, > > On Mon, 2021-07-19 at 07:56 +0800, Chun-Kuang Hu wrote: > > Hi, Nancy: > > > > Nancy.Lin 於 2021年7月17日 週六 下午5:04寫道: > > > > > > Add ETHDR module files: > > > ETHDR is designed for HDR video and graphics conversi

Re: [PATCH v3 2/2] dt-bindings: mediatek: add force_dsi_end_without_null for dsi

2021-07-25 Thread CK Hu
Hi, Jitao: On Mon, 2021-07-26 at 10:11 +0800, Jitao Shi wrote: > Some bridge chip will shift screen when the dsi data does't ent at > the same time in line. > > Signed-off-by: Jitao Shi > --- > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt | 4 > 1 file changed, 4 insertion

Re: [PATCH v2 14/14] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

2021-08-01 Thread CK Hu
Hi, Nancy: On Thu, 2021-07-22 at 17:45 +0800, Nancy.Lin wrote: > Add driver data of mt8195 vdosys1 to mediatek-drm and modify drm for > multi-mmsys support. The two mmsys (vdosys0 and vdosys1) will bring > up two drm drivers, only one drm driver register as the drm device. > Each drm driver binds

Re: [PATCH v1, 1/3] drm/mediatek: Separate aal module

2021-04-12 Thread CK Hu
Hi, Yongqiang: On Mon, 2021-04-12 at 14:35 +0800, Yongqiang Niu wrote: > mt8183 aal has no gamma function Separate this patch to two patch: one is add has_gamma config in aal. another one is add mt8183 aal support. Regards, CK > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek

Re: [PATCH v1, 3/3] drm/mediatek: gamma set with cmdq

2021-04-12 Thread CK Hu
Hi, Yongqiang: On Mon, 2021-04-12 at 14:35 +0800, Yongqiang Niu wrote: > gamma lut set in vsync active will caused display flash issue > set gamma lut with cmdq In MT8173, it's ok to set gammma out of vblank period. Why do you setting gamma in vblank in this patch? Regards, CK > > Signed-off-

Re: [PATCH v1] drm/mediatek: adjust rdma fifo threshold calculate formula

2021-04-12 Thread CK Hu
Hi, Yongqiang: On Mon, 2021-04-12 at 15:25 +0800, Yongqiang Niu wrote: > the orginal formula will caused rdma fifo threshold config overflow > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v1, 3/3] drm/mediatek: gamma set with cmdq

2021-04-12 Thread CK Hu
Hi, Yongqiang: On Mon, 2021-04-12 at 16:45 +0800, Yongqiang Niu wrote: > On Mon, 2021-04-12 at 16:28 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Mon, 2021-04-12 at 14:35 +0800, Yongqiang Niu wrote: > > > gamma lut set in vsync active will caused display flash

Re: [PATCH] drm/mediatek: clear pending flag when cmdq packet is done.

2021-04-22 Thread CK Hu
Hi, Hsin-yi: On Thu, 2021-04-22 at 19:10 +0800, Hsin-Yi Wang wrote: > From: CK Hu > > In cmdq mode, packet may be flushed before it is executed, so > the pending flag should be cleared after cmdq packet is done. > > Signed-off-by: CK Hu > Signed-off-by: Hsin-Yi Wang >

Re: [RFC PATCH 5/5] drm/mediatek: Add mt8195 DisplayPort driver

2021-08-16 Thread CK Hu
Hi, Markus: On Mon, 2021-08-16 at 21:25 +0200, Markus Schneider-Pargmann wrote: > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > It supports both functional units on the mt8195, the embedded > DisplayPort as well as the external DisplayPort units. It offers > hot-plug-detec

Re: [RFC PATCH 2/5] drm/mediatek: dpi: Add dpintf support

2021-08-17 Thread CK Hu
Hi, Markus: On Mon, 2021-08-16 at 21:25 +0200, Markus Schneider-Pargmann wrote: > dpintf is the displayport interface hardware unit. This unit is similar > to dpi and can reuse most of the code. > > This patch adds support for mt8195-dpintf to this dpi driver. Main > differences are: > - Some fe

Re: [RFC PATCH 5/5] drm/mediatek: Add mt8195 DisplayPort driver

2021-08-17 Thread CK Hu
Hi, Markus: On Mon, 2021-08-16 at 21:25 +0200, Markus Schneider-Pargmann wrote: > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > It supports both functional units on the mt8195, the embedded > DisplayPort as well as the external DisplayPort units. It offers > hot-plug-detec

Re: [RFC PATCH 1/5] dt-bindings: mediatek,dpi: Add mt8195 dpintf

2021-08-17 Thread CK Hu
cOHigUMlikjhtJMFrEQqemcjQZa4NaXBE9tzMnAjuBCxsg$ > > > -title: mediatek DPI Controller Device Tree Bindings > +title: mediatek DPI/DP_INTF Controller Device Tree Bindings > > maintainers: >- CK Hu > @@ -13,7 +13,8 @@ maintainers: > description: | >The Mediate

Re: [PATCH v8 12/13] drm/mediatek: add MERGE support for mediatek-drm

2021-08-20 Thread CK Hu
Hi, Jason: On Thu, 2021-08-19 at 10:23 +0800, jason-jh.lin wrote: > Add MERGE engine file: > MERGE module is used to merge two slice-per-line inputs > into one side-by-side output. > > Signed-off-by: jason-jh.lin > --- [snip] > + > +int mtk_merge_clk_enable(struct device *dev) > +{ > + int

Re: [PATCH v3 12/15] drm/mediatek: add display MDP RDMA support for MT8195

2021-08-20 Thread CK Hu
Hi, Nancy: On Wed, 2021-08-18 at 17:18 +0800, Nancy.Lin wrote: > Add MDP_RDMA driver for MT8195. MDP_RDMA is the DMA engine of > the ovl_adaptor component. > > Signed-off-by: Nancy.Lin > --- [snip] > + > +#define MDP_RDMA_EN0x000 > +#define FLD_ROT_

Re: [PATCH 3/3] drm/mediatek: dpi: add bus format negociation

2021-03-31 Thread CK Hu
Hi, Jitao: On Tue, 2021-03-30 at 23:53 +0800, Jitao Shi wrote: > Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate > the possible output and input formats for the current mode and monitor, > and use the negotiated formats in a basic atomic_check callback. > > Signed-off-b

Re: [PATCH v10 3/9] drm/mediatek: add RDMA fifo size error handle

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > This patch add RDMA fifo size error handle > rdma fifo size will not always bigger than the calculated threshold > if that case happened, we need set fifo size as the threshold > > Signed-off-by: Yongq

Re: [PATCH v10 4/9] drm/mediatek: generalize mtk_dither_set() function

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > There may be data structure other than mtk_ddp_comp_dev that would call > mtk_dither_set(), so use regs as parameter instead of device. You does not change the interface of mtk_dither_set(). You move the common part in mtk_dith

Re: [PATCH v10 4/9] drm/mediatek: generalize mtk_dither_set() function

2021-01-27 Thread CK Hu
On Thu, 2021-01-28 at 13:09 +0800, Hsin-Yi Wang wrote: > On Thu, Jan 28, 2021 at 12:39 PM CK Hu wrote: > > > > Hi, Hsin-Yi: > > > > On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > > > There may be data structure other than mtk_ddp_comp_dev that would

Re: [PATCH v10 5/9] drm/mediatek: separate gamma module

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > mt8183 gamma module will different with mt8173 > separate gamma for add private data Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang >

Re: [PATCH v10 6/9] drm/mediatek: add has_dither private data for gamma

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Not all SoC has dither function in gamma module. > Add private data to control this function setting. Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > Signed

Re: [PATCH v10 7/9] drm/mediatek: enable dither function

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > for 5 or 6 bpc panel, we need enable dither function > to improve the display quality > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp

Re: [PATCH v10 8/9] drm/mediatek: add DDP support for MT8183

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: Modify the title's prefix to 'soc: mediatek:' On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Add DDP support for MT8183 SoC. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/soc/mediatek/mtk-mutex.c | 50 ++

Re: [PATCH v10 9/9] drm/mediatek: add support for mediatek SOC MT8183

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > 1. add ovl private data > 2. add rdma private data > 3. add gamma privte data > 4. add main and external path module for crtc create Reviewed-by: CK Hu > > Signed-off-by:

Re: [PATCH v10 8/9] drm/mediatek: add DDP support for MT8183

2021-01-27 Thread CK Hu
On Thu, 2021-01-28 at 14:13 +0800, CK Hu wrote: > Hi, Hsin-Yi: > > Modify the title's prefix to 'soc: mediatek:' Modify more, the title should be 'soc: mediatek: add mtk mutex support for MT8183' > > On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrot

Re: [PATCH v10 8/9] drm/mediatek: add DDP support for MT8183

2021-01-27 Thread CK Hu
On Thu, 2021-01-28 at 14:15 +0800, Hsin-Yi Wang wrote: > On Thu, Jan 28, 2021 at 2:13 PM CK Hu wrote: > > > > Hi, Hsin-Yi: > > > > Modify the title's prefix to 'soc: mediatek:' > > > > On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote:

Re: [PATCH v11 4/9] drm/mediatek: add mtk_dither_set_common() function

2021-01-27 Thread CK Hu
ponents (dither, > gamma) can call this function. Reviewed-by: CK Hu > > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 4 > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 25 + > 2 files changed, 20 insertions(+), 9 de

Re: [PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Thu, 2021-01-28 at 15:28 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > for 5 or 6 bpc panel, we need enable dither function > to improve the display quality > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp

Re: [PATCH v11 8/9] soc: mediatek: add mtk mutex support for MT8183

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Thu, 2021-01-28 at 15:28 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Add mtk mutex support for MT8183 SoC. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/soc/mediatek/mtk-mutex.c | 50 > 1 file changed,

Re: [PATCH v11 3/9] drm/mediatek: add RDMA fifo size error handle

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Thu, 2021-01-28 at 15:27 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > This patch add RDMA fifo size error handle > rdma fifo size will not always bigger than the calculated threshold > if that case happened, we need set fifo size as the threshold > > Signed-off-by: Yongq

Re: [PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-28 Thread CK Hu
On Thu, 2021-01-28 at 15:59 +0800, Yongqiang Niu wrote: > On Thu, 2021-01-28 at 15:42 +0800, CK Hu wrote: > > Hi, Hsin-Yi: > > > > On Thu, 2021-01-28 at 15:28 +0800, Hsin-Yi Wang wrote: > > > From: Yongqiang Niu > > > > > > for 5 or 6 bpc panel,

Re: [PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-28 Thread CK Hu
On Thu, 2021-01-28 at 16:18 +0800, Hsin-Yi Wang wrote: > On Thu, Jan 28, 2021 at 4:10 PM Yongqiang Niu > wrote: > > > > On Thu, 2021-01-28 at 16:07 +0800, CK Hu wrote: > > > On Thu, 2021-01-28 at 15:59 +0800, Yongqiang Niu wrote: > > > > On Thu,

Re: [PATCH v12 7/8] soc: mediatek: add mtk mutex support for MT8183

2021-01-28 Thread CK Hu
Hi, Hsin-Yi: On Thu, 2021-01-28 at 19:23 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Add mtk mutex support for MT8183 SoC. Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/soc/m

Re: [PATCH v12 6/8] drm/mediatek: enable dither function

2021-01-28 Thread CK Hu
Hi, Hsin-Yi: On Thu, 2021-01-28 at 19:23 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > for 5 or 6 bpc panel, we need enable dither function > to improve the display quality > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp

Re: [PATCH v4 2/8] drm/mediatek: add component POSTMASK

2021-01-29 Thread CK Hu
Hi, Hsin-Yi: On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > This patch add component POSTMASK, > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/Makefile| 1 + > drivers/gpu/drm/mediatek/mtk_disp_dr

Re: [PATCH v4 4/8] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-29 Thread CK Hu
Hi, Hsin-Yi: On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase, without this patch, > ovl will hang up when more than 1 layer enabled. Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu >

Re: [PATCH v4 2/8] drm/mediatek: add component POSTMASK

2021-01-29 Thread CK Hu
On Fri, 2021-01-29 at 16:32 +0800, Yongqiang Niu wrote: > On Fri, 2021-01-29 at 16:18 +0800, CK Hu wrote: > > Hi, Hsin-Yi: > > > > On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > > > From: Yongqiang Niu > > > > > > This patch ad

Re: [PATCH v4 6/8] drm/mediatek: add matrix bits private data for ccorr

2021-01-29 Thread CK Hu
Hi, Hsin-Yi: On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > matrix bits of mt8183 is 12 > matrix bits of mt8192 is 13 > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 22 +++---

Re: [PATCH v4 7/8] soc: mediatek: add mtk mutex support for MT8192

2021-01-29 Thread CK Hu
Hi, Hsin-Yi: On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Add mtk mutex support for MT8192 SoC. Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/soc/m

Re: [PATCH v5 2/8] drm/mediatek: add component POSTMASK

2021-02-01 Thread CK Hu
Hi, Hsin-Yi: It looks like that postmask driver could be placed in mtk_drm_ddp_comp.c and this patch would much smaller. Regards, CK On Mon, 2021-02-01 at 18:37 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > This patch add component POSTMASK. > > Signed-off-by: Yongqiang Niu > Signed-o

Re: [PATCH v5 4/8] drm/mediatek: separate ccorr module

2021-02-01 Thread CK Hu
Hi, Hsin-Yi: On Mon, 2021-02-01 at 18:37 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > ccorr ctm matrix bits will be different in mt8192 Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/

Re: [PATCH v5 5/8] drm/mediatek: Fix ccorr size config

2021-02-01 Thread CK Hu
Hi, Hsin-Yi: On Mon, 2021-02-01 at 18:37 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Fix setting to follow hardware datasheet. The original error setting > affects mt8192 display. Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi W

Re: [PATCH v5 6/8] drm/mediatek: add matrix_bits private data for ccorr

2021-02-01 Thread CK Hu
Hi, Hsin-Yi: On Mon, 2021-02-01 at 18:37 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Add matrix_bits and coeffs_precision to ccorr private data: > - matrix bits of mt8183 is 10 > - matrix bits of mt8192 is 11 > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > dri

Re: [PATCH v6 2/8] drm/mediatek: add component POSTMASK

2021-02-02 Thread CK Hu
Hi, Hsin-Yi: On Tue, 2021-02-02 at 16:12 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > This patch add component POSTMASK. Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/

Re: [PATCH v6 6/8] drm/mediatek: add matrix_bits private data for ccorr

2021-02-02 Thread CK Hu
Hi, Hsin-Yi: On Tue, 2021-02-02 at 16:12 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Add matrix_bits and coeffs_precision to ccorr private data: > - matrix bits of mt8183 is 10 > - matrix bits of mt8192 is 11 > Reviewed-by: CK Hu > Signed-off-by: Yongqiang

Re: [PATCH v6 8/8] drm/mediatek: add support for mediatek SOC MT8192

2021-02-02 Thread CK Hu
Hi, Hsin-Yi: On Tue, 2021-02-02 at 16:12 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > add support for mediatek SOC MT8192 Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c

Re: [PATCH] drm/mediatek: dpi: fix NULL dereference in mtk_dpi_bridge_atomic_check

2021-07-15 Thread CK Hu
Hi, Frank: On Mon, 2021-07-12 at 10:07 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > bridge->driver_private is not set (NULL) so use bridge_to_dpi(bridge) > like it's done in bridge_atomic_get_output_bus_fmts Reviewed-by: CK Hu > > Fixes: ec8747c5243

Re: [PATCH] drm/mediatek: mtk-dpi: Set out_fmt from config if not the last bridge

2021-07-15 Thread CK Hu
ual_edge() will fail to write correct > value to regs. Reviewed-by: CK Hu > > Fixes: ec8747c52434 ("drm/mediatek: dpi: Add bus format negotiation") > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 4 > 1 file changed, 4 insertions

Re: [PATCH v7 5/8] drm/mediatek: dpi: Add dpintf support

2022-01-19 Thread CK Hu
Hi, Guillaume: On Fri, 2021-12-17 at 16:08 +0100, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann > > dpintf is the displayport interface hardware unit. This unit is > similar > to dpi and can reuse most of the code. > > This patch adds support for mt8195-dpintf to this dpi driver. M

Re: [PATCH v1, 1/1] soc: mediatek: cmdq: add cmdq_pkt_poll_addr function

2022-01-20 Thread CK Hu
Hi, Yongqiang: On Thu, 2022-01-20 at 15:43 +0800, Yongqiang Niu wrote: > From: mtk18742 > > add cmdq_pkt_poll_addr function in cmdq helper functions > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 39 > > include/linux/mailbox/mtk-c

Re: [PATCH v11 21/22] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

2022-01-23 Thread CK Hu
Hi, Nancy: On Mon, 2022-01-10 at 16:46 +0800, Nancy.Lin wrote: > Add driver data of mt8195 vdosys1 to mediatek-drm. > > Signed-off-by: Nancy.Lin > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/

Re: [RFC PATCH 2/2] drm/mediatek: add mtk8195 hdmi display driver

2022-01-27 Thread CK Hu
Hi, Guillaume: On Mon, 2021-11-08 at 01:08 +0100, Guillaume Ranquet wrote: > Signed-off-by: Guillaume Ranquet > Change-Id: I6399dec26cfe56a338c2ca96989cb7cbd14e292b > --- > drivers/gpu/drm/mediatek/Kconfig |9 + > drivers/gpu/drm/mediatek/Makefile |2 + > drivers

Re: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind

2022-01-27 Thread CK Hu
Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei@mediatek.com wrote: > From: xinlei lee > > The order of probe function for bridge drivers and dsi drivers is > uncertain. > To avoid the dsi probe cannot be executed, we place getting bridge > node function in > mtk_dsi_bind. It seems th

Re: [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC

2022-01-27 Thread CK Hu
Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei@mediatek.com wrote: > From: xinlei lee > > Add binding documentation for the MT8186 SoC. DPI has a yaml format document, so I would like DSI also has a yaml format document. Please send a patch to transfer DSI document to yaml, and then

Re: [v1,2/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c

2022-01-27 Thread CK Hu
Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei@mediatek.com wrote: > From: xinlei lee > > Add the compatible of mt8186-dsi because we use different cmdq > addresses in mt8186. Reviewed-by: CK Hu > > Signed-off-by: Xinlei Lee > --- > drivers/gpu/dr

Re: [RFC PATCH 2/2] drm/mediatek: add mtk8195 hdmi display driver

2022-01-27 Thread CK Hu
Hi, Guillaume: On Mon, 2021-11-08 at 01:08 +0100, Guillaume Ranquet wrote: > Signed-off-by: Guillaume Ranquet > Change-Id: I6399dec26cfe56a338c2ca96989cb7cbd14e292b > --- > drivers/gpu/drm/mediatek/Kconfig |9 + > drivers/gpu/drm/mediatek/Makefile |2 + > drivers

Re: [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type

2020-12-24 Thread CK Hu
+ Chun-Kuang, Philipp: This mail has been sent to dri devel and linux mediatek, but why it does not exist in mail lists? Regards, CK On Thu, 2020-12-24 at 17:54 +0800, Huijuan Xie wrote: > The interrupt trigger is already set by OF. When do devm_request_irq() > in driver, please use IRQF_TRIGG

Re: [PATCH v7 7/8] drm/mediatek: Add mt8195 DisplayPort driver

2022-01-02 Thread CK Hu
Hi, Guillaume: This is a big patch, so I give you some comment first, and I would continue to review this patch. On Fri, 2021-12-17 at 16:08 +0100, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann > > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > It supports t

Re: [PATCH v10 15/22] drm/mediatek: add display merge async reset control

2022-01-02 Thread CK Hu
Hi, Nancy: On Wed, 2021-12-08 at 10:44 +0800, Nancy.Lin wrote: > Add merge async reset control in mtk_merge_stop. Async hw doesn't do > self > reset on each sof signal(start of frame), so need to reset the async > to > clear the hw status for the next merge start.

Re: [PATCH v10 19/22] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support

2022-01-03 Thread CK Hu
Hi, Nancy: On Wed, 2021-12-08 at 10:44 +0800, Nancy.Lin wrote: > MT8195 have two mmsys. Modify drm for MT8195 multi-mmsys support. > The two mmsys (vdosys0 and vdosys1) will bring up two drm drivers, > only one drm driver register as the drm device. > Each drm driver binds its own component. The l

Re: [PATCH v2] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-05 Thread CK Hu
Hi, Angelo: On Tue, 2022-01-04 at 10:59 +0100, AngeloGioacchino Del Regno wrote: > DRM bridge drivers are now attaching their DSI device at probe time, > which requires us to register our DSI host in order to let the bridge > to probe: this recently started producing an endless -EPROBE_DEFER > loo

Re: [PATCH v11 20/22] drm/mediatek: add drm ovl_adaptor sub driver for MT8195

2022-01-13 Thread CK Hu
Hi, Nancy: On Mon, 2022-01-10 at 16:46 +0800, Nancy.Lin wrote: > Add drm ovl_adaptor sub driver. Bring up ovl_adaptor sub driver if > the component exists in the path. > > Signed-off-by: Nancy.Lin > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 16 > drivers/gpu/drm/mediatek/mtk_

Re: [RFC PATCH 2/2] drm/mediatek: add mtk8195 hdmi display driver

2022-01-14 Thread CK Hu
Hi, Guillaume: On Mon, 2021-11-08 at 01:08 +0100, Guillaume Ranquet wrote: > Signed-off-by: Guillaume Ranquet > Change-Id: I6399dec26cfe56a338c2ca96989cb7cbd14e292b > --- > drivers/gpu/drm/mediatek/Kconfig |9 + > drivers/gpu/drm/mediatek/Makefile |2 + > drivers

[PATCH 8/9] drm/mediatek: Use drm_plane_helper_check_state()

2016-08-02 Thread CK Hu
r did the driver > respect any user configured src coordinates, so panning and such would > have been totally broken. It should be all good now. > > Cc: CK Hu > Cc: linux-mediatek at lists.infradead.org > Signed-off-by: Ville Syrjälä > --- Acked-by:

[PATCH v5 06/10] drm/mediatek: add dsi interrupt control

2016-08-02 Thread CK Hu
Hi, YT: On Thu, 2016-07-28 at 17:28 +0800, YT Shen wrote: > From: shaoming chen > > add dsi interrupt control > > Signed-off-by: shaoming chen > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 92 > > 1 file changed, 92 insertions(+) > > diff --git a/driver

[PATCH v5 07/10] drm/mediatek: add dsi transfer function

2016-08-02 Thread CK Hu
Hi, YT: On Thu, 2016-07-28 at 17:28 +0800, YT Shen wrote: > From: shaoming chen > > add dsi read/write commands for transfer function > > Signed-off-by: shaoming chen > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 286 > > 1 file changed, 286 insertions(+)

[PATCH v6 10/10] arm: dts: mt2701: Add display subsystem related nodes for MT2701

2016-08-05 Thread CK Hu
Hi, YT: On Thu, 2016-08-04 at 19:07 +0800, YT Shen wrote: > This patch adds the device nodes for the DISP function blocks for MT2701 > > Signed-off-by: YT Shen > --- > arch/arm/boot/dts/mt2701.dtsi | 86 > + > 1 file changed, 86 insertions(+) > > diff

[PATCH v6 09/10] drm/mediatek: add support for Mediatek SoC MT2701

2016-08-05 Thread CK Hu
Hi, YT: On Thu, 2016-08-04 at 19:07 +0800, YT Shen wrote: > This patch add support for the Mediatek MT2701 DISP subsystem. > There is only one OVL engine in MT2701. > > Signed-off-by: YT Shen > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c |6 ++ > drivers/gpu/drm/mediatek/mtk_disp_

[PATCH v6 07/10] drm/mediatek: add dsi transfer function

2016-08-05 Thread CK Hu
Hi, YT: On Thu, 2016-08-04 at 19:07 +0800, YT Shen wrote: > From: shaoming chen > > add dsi read/write commands for transfer function > > Signed-off-by: shaoming chen > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 261 > > 1 file changed, 261 insertions(+)

[PATCH v6 06/10] drm/mediatek: add dsi interrupt control

2016-08-05 Thread CK Hu
Hi, YT: On Thu, 2016-08-04 at 19:07 +0800, YT Shen wrote: > From: shaoming chen > > add dsi interrupt control > > Signed-off-by: shaoming chen > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 76 > > 1 file changed, 76 insertions(+) > > diff --git a/driver

[PATCH v6 07/10] drm/mediatek: add dsi transfer function

2016-08-11 Thread CK Hu
Hi, YT: On Wed, 2016-08-10 at 15:24 +0800, YT Shen wrote: > Hi CK, > > On Fri, 2016-08-05 at 18:08 +0800, CK Hu wrote: > > Hi, YT: > > > > On Thu, 2016-08-04 at 19:07 +0800, YT Shen wrote: > > > From: shaoming chen > > > > >

Re: [v2 3/3] drm/mediatek: add mipi_tx driver for mt8183

2019-05-06 Thread CK Hu
Hi, Jitao: On Tue, 2019-04-16 at 13:42 +0800, Jitao Shi wrote: > This patch add mt8183 mipi_tx driver. > And also support other chips that use the same binding and driver. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/Makefile | 1 + > drivers/gpu/drm/mediatek/mtk_

Re: [v3 3/3] drm/mediatek: add mt8183 dpi support

2019-05-07 Thread CK Hu
Hi, Jitao: On Tue, 2019-04-16 at 13:52 +0800, Jitao Shi wrote: I need the commit message. Even though the code is easy to understand, words for this patch is still necessary. Regards, CK > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 19 +++ > 1 file c

Re: [v3 2/3] drm/mediatek: dpi dual edge support

2019-05-07 Thread CK Hu
Hi, Jitao: On Tue, 2019-04-16 at 13:52 +0800, Jitao Shi wrote: Where is the commit message? I think you could introduce what is dual edge (Maybe it's trivial for you, but not for me) Regards, CK > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 10 ++ > 1 file ch

Re: [v2 1/5] drm/mediatek: move mipi_dsi_host_register to probe

2019-05-07 Thread CK Hu
Hi, Jitao: On Tue, 2019-04-16 at 14:04 +0800, Jitao Shi wrote: > DSI panel driver need attach function which is inculde in > mipi_dsi_host_ops. > > If mipi_dsi_host_register is not in probe, dsi panel will > probe fail or more delay. I think this patch just prevent delay, not to prevent dsi pane

Re: [v2 2/5] drm/mediatek: CMDQ reg address of mt8173 is different with mt2701

2019-05-07 Thread CK Hu
On Tue, 2019-04-16 at 14:04 +0800, Jitao Shi wrote: > Config the different CMDQ reg address in driver data. > For MT8173, you change reg_cmd_off from 0x180 to 0x200, so this patch is a bug fix. You should add a 'Fixes' tag. > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c |

Re: [v2 3/5] drm/mediatek: add dsi reg commit control

2019-05-07 Thread CK Hu
Hi, Jitao: On Tue, 2019-04-16 at 14:04 +0800, Jitao Shi wrote: > New DSI IP has shadow register and working reg. The register > values are writen to shadow register. And then trigger with > commit reg, the register values will be moved working register. This patch looks good, but the message is n

Re: [v2 4/5] drm/mediatek: add frame size control

2019-05-07 Thread CK Hu
Hi, Jitao: On Tue, 2019-04-16 at 14:05 +0800, Jitao Shi wrote: > Our new DSI chip has frame size control. > So add the driver data to control for different chips. > Reviewed-by: CK Hu > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 5 + &g

Re: [v2 5/5] drm/mediatek: add mt8183 dsi driver support

2019-05-07 Thread CK Hu
Hi, Jitao: On Tue, 2019-04-16 at 14:05 +0800, Jitao Shi wrote: > Add mt8183 dsi driver data. Enable size control and > reg commit control. > Reviewed-by: CK Hu > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 8 > 1 file changed, 8 in

Re: [v3 2/3] drm/mediatek: separate mipi_tx to different file

2019-05-19 Thread CK Hu
Reviewed-by: CK Hu > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/Makefile | 1 + > drivers/gpu/drm/mediatek/mtk_mipi_tx.c| 342 ++ > drivers/gpu/drm/mediatek/mtk_mipi_tx.h| 49 +++ > drivers/gpu/drm/med

Re: [v2 3/3] drm/mediatek: add mipi_tx driver for mt8183

2019-05-19 Thread CK Hu
On Sat, 2019-05-18 at 15:51 +0800, Jitao Shi wrote: > On Mon, 2019-05-06 at 17:17 +0800, CK Hu wrote: > > Hi, Jitao: > > > > On Tue, 2019-04-16 at 13:42 +0800, Jitao Shi wrote: > > > This patch add mt8183 mipi_tx driver. > > > And also support other chi

Re: [v4 2/5] drm/mediatek: dpi dual edge support

2019-05-19 Thread CK Hu
Hi, Jitao: On Sat, 2019-05-18 at 17:56 +0800, Jitao Shi wrote: > DPI sample the data both rising and falling edge. > It can reduce half data io pins. All the registers which you control in this patch exist in MT8173. So I think this is not a SoC-level feature. This feature depends on how much io

Re: [v4 4/5] drm/mediatek: control dpi pins dpi or gpio mode in on or off

2019-05-19 Thread CK Hu
Hi, Jitao: On Sat, 2019-05-18 at 17:56 +0800, Jitao Shi wrote: > Pull dpi pins low when dpi has nothing to display. Aovid leakage > current from some dpi pins (Hsync Vsync DE ... ). > > Some chips have dpi pins, but there are some chip don't have pins. > So this function is controlled by chips dr

Re: [v2 1/5] drm/mediatek: move mipi_dsi_host_register to probe

2019-05-20 Thread CK Hu
On Sun, 2019-05-19 at 17:36 +0800, Jitao Shi wrote: > On Tue, 2019-05-07 at 17:52 +0800, CK Hu wrote: > > Hi, Jitao: > > > > On Tue, 2019-04-16 at 14:04 +0800, Jitao Shi wrote: > > > DSI panel driver need attach function which is inculde in > >

Re: [v3 1/7] drm/mediatek: move mipi_dsi_host_register to probe

2019-05-20 Thread CK Hu
Hi, Jitao: On Sun, 2019-05-19 at 17:25 +0800, Jitao Shi wrote: > DSI panel driver need attach function which is inculde in > mipi_dsi_host_ops. > > If mipi_dsi_host_register is not in probe, dsi panel will > probe fail or more delay. In [1], you have agreed this patch just for delay not for prob

Re: [v2 2/5] drm/mediatek: CMDQ reg address of mt8173 is different with mt2701

2019-05-20 Thread CK Hu
Hi, Jitao: On Sun, 2019-05-19 at 17:33 +0800, Jitao Shi wrote: > On Wed, 2019-05-08 at 10:39 +0800, CK Hu wrote: > > On Tue, 2019-04-16 at 14:04 +0800, Jitao Shi wrote: > > > Config the different CMDQ reg address in driver data. > > > > > For MT8173, you chang

Re: [PATCH] drm/mediatek: Fix warning about unhandled enum value

2019-05-22 Thread CK Hu
with the addition of HDMI_INFOFRAME_TYPE_DRM in the commit > below, but the code really should have been future-proofed from the > start. Acked-by: CK Hu > > Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support") I think "drm: Enable HDR infoframe support" exist o

Re: [PATCH v2 22/25] drm/mediatek: adjust ddp clock control flow

2019-05-27 Thread CK Hu
Hi, Yongqiang: On Tue, 2019-04-16 at 16:24 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Wed, 2019-03-27 at 14:19 +0800, yongqiang@mediatek.com wrote: > > From: Yongqiang Niu > > > > display hardware clock will not unprepare when > > crtc is disable, until

Re: [PATCH v2 24/25] drm/mediatek: respect page offset for PRIME mmap calls

2019-05-27 Thread CK Hu
Hi, Yongqiang: On Tue, 2019-04-16 at 16:33 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Wed, 2019-03-27 at 14:19 +0800, yongqiang@mediatek.com wrote: > > From: Yongqiang Niu > > > > Respect page offset for PRIME mmap calls > > Reviewed-by: CK Hu This

Re: [PATCH v3] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable()

2019-05-28 Thread CK Hu
Hi, Hsin-Yi: On Tue, 2019-05-28 at 15:39 +0800, Hsin-Yi Wang wrote: > mtk_dsi_stop() should be called after mtk_drm_crtc_atomic_disable(), which > needs > ovl irq for drm_crtc_wait_one_vblank(), since after mtk_dsi_stop() is called, > ovl irq will be disabled. If drm_crtc_wait_one_vblank() is cal

Re: [PATCH 1/3] drm: mediatek: fix unbind functions

2019-05-28 Thread CK Hu
Hi, Hsin-yi: On Mon, 2019-05-27 at 12:50 +0800, Hsin-Yi Wang wrote: > move mipi_dsi_host_unregister() to .remove since mipi_dsi_host_register() > is called in .probe. In the latest kernel [1], mipi_dsi_host_register() is called in mtk_dsi_bind(), I think we don't need this part. [1] https://git.

Re: [PATCH 2/3] drm: mediatek: remove clk_unprepare() in mtk_drm_crtc_destroy()

2019-05-28 Thread CK Hu
Hi, Hsin-Yi: On Mon, 2019-05-27 at 12:50 +0800, Hsin-Yi Wang wrote: > There is no clk_prepare() called in mtk_drm_crtc_reset(), when unbinding > drm device, mtk_drm_crtc_destroy() will be triggered, and the clocks will > be disabled and unprepared in mtk_crtc_ddp_clk_disable. If clk_unprepare() >

Re: [PATCH 2/3] drm: mediatek: remove clk_unprepare() in mtk_drm_crtc_destroy()

2019-05-29 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2019-05-29 at 14:08 +0800, Hsin-Yi Wang wrote: > On Wed, May 29, 2019 at 1:58 PM CK Hu wrote: > > > > Hi, Hsin-Yi: > > > > On Mon, 2019-05-27 at 12:50 +0800, Hsin-Yi Wang wrote: > > > There is no clk_prepare() called in mtk_drm_crtc_rese

Re: [PATCH 1/3] drm: mediatek: fix unbind functions

2019-05-29 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2019-05-29 at 15:06 +0800, Hsin-Yi Wang wrote: > On Wed, May 29, 2019 at 9:35 AM CK Hu wrote: > > > > > I think mtk_dsi_destroy_conn_enc() has much thing to do and I would like > > you to do more. You could refer to [2] for complete implementatio

Re: [PATCH 3/3] drm: mediatek: unbind components in mtk_drm_unbind()

2019-05-29 Thread CK Hu
Hi, Hsin-Yi: On Mon, 2019-05-27 at 12:50 +0800, Hsin-Yi Wang wrote: > Unbinding components (i.e. mtk_dsi and mtk_disp_ovl/rdma/color) will > trigger master(mtk_drm)'s .unbind(), and currently mtk_drm's unbind > won't actually unbind components. During the next bind, > mtk_drm_kms_init() is called,

Re: [PATCH V8 1/5] drm/mediatek: remove flag CLK_SET_RATE_PARENT for mt2701 hdmi phy to not propagate rate change to parent

2019-04-07 Thread CK Hu
Hi, Wangyan: On Tue, 2019-04-02 at 17:36 +0800, wangyan wang wrote: > From: Wangyan Wang > > This is the first step to make MT2701 hdmi stable. > The parent rate of hdmi phy had set by DPI driver. > We should not set or change the parent rate of MT2701 hdmi phy, > as a result we should remove th

Re: [PATCH V8 3/5] drm/mediatek: using new factor for tvdpll in MT2701

2019-04-07 Thread CK Hu
Hi, Wangyan: On Tue, 2019-04-02 at 17:36 +0800, wangyan wang wrote: > From: Wangyan Wang > > This is the second step to make MT2701 HDMI stable. > The factor depends on the divider of DPI in MT2701, therefore, > we should fix this factor to the right and new one. Rev

Re: [PATCH V8 4/5] drm/mediatek: no change parent rate in round_rate() for mt2701 hdmi phy

2019-04-07 Thread CK Hu
Hi, Wangyan: On Tue, 2019-04-02 at 17:36 +0800, wangyan wang wrote: > From: Wangyan Wang > > This is the third step to make MT2701 HDMI stable. > We should not change the rate of parent for hdmi phy when > doing round_rate for this clock. The parent clock of hdmi > phy must be the same as it. We

Re: [PATCH V8 5/5] drm/mediatek: make implementation of recalc_rate() to match the definition

2019-04-07 Thread CK Hu
Hi, Wangyan: On Tue, 2019-04-02 at 17:36 +0800, wangyan wang wrote: > From: Wangyan Wang > > Recalculate the rate of this clock, by querying hardware to > make implementation of recalc_rate() to match the definition. > > Signed-off-by: Wangyan Wang > --- > drivers/gpu/drm/mediatek/mtk_hdmi_ph

Re: [PATCH 1/7] drm/mediatek: fix possible object reference leak

2019-04-08 Thread CK Hu
d a node pointer with refcount incremented on line 1509, but without a > corresponding object release within this function. For this patch, applied to mediatek-drm-fixes-5.1 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-5.1 Regards, CK > > Sig

  1   2   3   4   5   6   7   8   >