Hi, Jitao:

On Tue, 2019-04-16 at 13:52 +0800, Jitao Shi wrote:

Where is the commit message? I think you could introduce what is dual
edge (Maybe it's trivial for you, but not for me)

Regards,
CK

> Signed-off-by: Jitao Shi <jitao....@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dpi.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c 
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 22e68a100e7b..66405159141a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -117,6 +117,7 @@ struct mtk_dpi_conf {
>       unsigned int (*cal_factor)(int clock);
>       u32 reg_h_fre_con;
>       bool edge_sel_en;
> +     bool dual_edge;
>  };
>  
>  static void mtk_dpi_mask(struct mtk_dpi *dpi, u32 offset, u32 val, u32 mask)
> @@ -353,6 +354,13 @@ static void mtk_dpi_config_disable_edge(struct mtk_dpi 
> *dpi)
>               mtk_dpi_mask(dpi, dpi->conf->reg_h_fre_con, 0, EDGE_SEL_EN);
>  }
>  
> +static void mtk_dpi_enable_dual_edge(struct mtk_dpi *dpi)
> +{
> +     mtk_dpi_mask(dpi, DPI_DDR_SETTING, DDR_EN | DDR_4PHASE,
> +                  DDR_EN | DDR_4PHASE);
> +     mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, EDGE_SEL, EDGE_SEL);
> +}
> +
>  static void mtk_dpi_config_color_format(struct mtk_dpi *dpi,
>                                       enum mtk_dpi_out_color_format format)
>  {
> @@ -509,6 +517,8 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
>       mtk_dpi_config_color_format(dpi, dpi->color_format);
>       mtk_dpi_config_2n_h_fre(dpi);
>       mtk_dpi_config_disable_edge(dpi);
> +     if (dpi->conf->dual_edge)
> +             mtk_dpi_enable_dual_edge(dpi);
>       mtk_dpi_sw_reset(dpi, false);
>  
>       return 0;


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to