Re: [PATCH v2 1/2] device: rust: rename Device::as_ref() to Device::from_raw()

2025-07-16 Thread Greg Kroah-Hartman
On Fri, Jul 11, 2025 at 08:04:37AM +, Alice Ryhl wrote: > The prefix as_* should not be used for a constructor. Constructors > usually use the prefix from_* instead. > > Some prior art in the stdlib: Box::from_raw, CString::from_raw, > Rc::from_raw, Arc::from_raw, Waker::from_raw, File::from_r

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Philipp Stanner
On Wed, 2025-07-16 at 09:43 +, cao, lin wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > > > Hi Philipp, > > > Thank you for the review. I found that this optimization was > introduced 9 years ago in commit > 777dbd458c89d4ca74a659f85ffb5bc817f29a35 ("drm/amdgpu: dr

Re: [PATCH] drm/msm/kms: move snapshot init earlier in KMS init

2025-07-16 Thread Konrad Dybcio
On 7/15/25 5:50 PM, Dmitry Baryshkov wrote: > Various parts of the display driver can be triggering the display > snapshot (including the IOMMU fault handlers). Move the call to > msm_disp_snapshot_init() before KMS initialization, otherwise it is > possible to ocassionally trigger the kernel fault

linux-next: build warning after merge of the drm-misc tree

2025-07-16 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: drivers/gpu/drm/drm_bridge.c:1242: warning: Function parameter or struct member 'connector' not described in 'drm_bridge_detect' Introduced by commit 5d156a9c3d5e ("drm/bridge: Pass down conne

Re: linux-next: manual merge of the rust tree with the drm-misc tree

2025-07-16 Thread Danilo Krummrich
On Wed Jul 16, 2025 at 12:16 PM CEST, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rust tree got a conflict in: > > rust/kernel/drm/gem/mod.rs > > between commit: > > 917b10d90990 ("drm: rust: rename as_ref() to from_raw() for drm > constructors") > > from the drm-misc

Re: [PATCH 2/9] mei: late_bind: add late binding component driver

2025-07-16 Thread Greg KH
On Thu, Jul 10, 2025 at 11:08:33AM -0400, Rodrigo Vivi wrote: > From: Alexander Usyskin > > Introduce a new MEI client driver to support Late Binding firmware > upload/update for Intel discrete graphics platforms. > > Late Binding is a runtime firmware upload/update mechanism that allows > paylo

RE: [PATCH 2/9] mei: late_bind: add late binding component driver

2025-07-16 Thread Usyskin, Alexander
> Subject: Re: [PATCH 2/9] mei: late_bind: add late binding component driver > > On Thu, Jul 10, 2025 at 11:08:33AM -0400, Rodrigo Vivi wrote: > > From: Alexander Usyskin > > > > Introduce a new MEI client driver to support Late Binding firmware > > upload/update for Intel discrete graphics platf

Re: [PATCH v2 01/10] clk: imx95-blk-ctl: Save platform data in imx95_blk_ctl structure

2025-07-16 Thread Abel Vesa
On 25-07-16 11:15:05, Laurentiu Palcu wrote: > Currently, besides probe(), the platform data is read in both suspend() > and resume(). Let's avoid this by making pdata a member of imx95_blk_ctl > structure. > > Signed-off-by: Laurentiu Palcu Reviewed-by: Abel Vesa

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Greg Kroah-Hartman
On Wed, Jul 16, 2025 at 01:32:42PM +0200, Philipp Stanner wrote: > On Wed, 2025-07-16 at 13:15 +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 16, 2025 at 12:58:28PM +0200, Christian König wrote: > > > On 16.07.25 12:46, Philipp Stanner wrote: > > > > +Cc Greg, Sasha > > > > > > > > On Wed, 2025-

Re: [PATCH v2 02/10] clk: imx95-blk-ctl: Save/restore registers when RPM routines are called

2025-07-16 Thread Abel Vesa
On 25-07-16 11:15:06, Laurentiu Palcu wrote: > If runtime PM is used for the clock providers and they're part of a > power domain, then the power domain supply will be cut off when runtime > suspended. That means all BLK CTL registers belonging to that power > domain will be reset. Save the registe

Re: [PATCH 2/9] mei: late_bind: add late binding component driver

2025-07-16 Thread Greg KH
On Wed, Jul 16, 2025 at 11:58:19AM +, Usyskin, Alexander wrote: > > Subject: Re: [PATCH 2/9] mei: late_bind: add late binding component driver > > > > On Thu, Jul 10, 2025 at 11:08:33AM -0400, Rodrigo Vivi wrote: > > > From: Alexander Usyskin > > > > > > Introduce a new MEI client driver to s

Re: [PATCH] drm/sched: Fix a race in DRM_GPU_SCHED_STAT_NO_HANG test

2025-07-16 Thread Maíra Canal
Hi Tvrtko, On 16/07/25 05:48, Tvrtko Ursulin wrote: The "skip reset" test waits for the timeout handler to run for the duration of 2 * MOCK_TIMEOUT, and because the mock scheduler opted to Would it make any sense to wait for 1.5 * MOCK_TIMEOUT? This way we would guarantee that only one timeout

[PATCH] drm/bridge: Describe the newly introduced drm_connector parameter for drm_bridge_detect

2025-07-16 Thread Andy Yan
This fix the make htmldocs warnings: drivers/gpu/drm/drm_bridge.c:1242: warning: Function parameter or struct member 'connector' not described in 'drm_bridge_detect' Fixes: 5d156a9c3d5e ("drm/bridge: Pass down connector to drm bridge detect hook") Signed-off-by: Andy Yan --- drivers/gpu/drm/dr

Re:linux-next: build warning after merge of the drm-misc tree

2025-07-16 Thread Andy Yan
Hi all, At 2025-07-16 18:31:15, "Stephen Rothwell" wrote: >Hi all, > >After merging the drm-misc tree, today's linux-next build (htmldocs) >produced this warning: > >drivers/gpu/drm/drm_bridge.c:1242: warning: Function parameter or struct >member 'connector' not described in 'drm_bridge_detect

Re: [PATCH v6 0/5] fs: refactor write_begin/write_end and add ext4 IOCB_DONTCACHE support

2025-07-16 Thread Christian Brauner
On Wed, 16 Jul 2025 09:36:01 +, 陈涛涛 Taotao Chen wrote: > From: Taotao Chen > > This patch series refactors the address_space_operations write_begin() > and write_end() callbacks to take const struct kiocb * as their first > argument, allowing IOCB flags such as IOCB_DONTCACHE to propagate to

[PATCH v6 3/5] fs: change write_begin/write_end interface to take struct kiocb *

2025-07-16 Thread 陈涛涛 Taotao Chen
From: Taotao Chen Change the address_space_operations callbacks write_begin() and write_end() to take struct kiocb * as the first argument instead of struct file *. Update all affected function prototypes, implementations, call sites, and related documentation across VFS, filesystems, and block

[PATCH v6 0/5] fs: refactor write_begin/write_end and add ext4 IOCB_DONTCACHE support

2025-07-16 Thread 陈涛涛 Taotao Chen
From: Taotao Chen This patch series refactors the address_space_operations write_begin() and write_end() callbacks to take const struct kiocb * as their first argument, allowing IOCB flags such as IOCB_DONTCACHE to propagate to the filesystem's buffered I/O path. Ext4 is updated to implement han

[PATCH v6 4/5] mm/pagemap: add write_begin_get_folio() helper function

2025-07-16 Thread 陈涛涛 Taotao Chen
From: Taotao Chen Add write_begin_get_folio() to simplify the common folio lookup logic used by filesystem ->write_begin() implementations. This helper wraps __filemap_get_folio() with common flags such as FGP_WRITEBEGIN, conditional FGP_DONTCACHE, and set folio order based on the write length.

[PATCH v6 1/5] drm/i915: Use kernel_write() in shmem object create

2025-07-16 Thread 陈涛涛 Taotao Chen
From: Taotao Chen Replace the write_begin/write_end loop in i915_gem_object_create_shmem_from_data() with call to kernel_write(). This function initializes shmem-backed GEM objects. kernel_write() simplifies the code by removing manual folio handling. Part of a series refactoring address_space_

[PATCH v6 2/5] drm/i915: Refactor shmem_pwrite() to use kiocb and write_iter

2025-07-16 Thread 陈涛涛 Taotao Chen
From: Taotao Chen Refactors shmem_pwrite() to replace the ->write_begin/end logic with a write_iter-based implementation using kiocb and iov_iter. While kernel_write() was considered, it caused about 50% performance regression. vfs_write() is not exported for kernel use. Therefore, file->f_op->w

[PATCH v6 5/5] ext4: support uncached buffered I/O

2025-07-16 Thread 陈涛涛 Taotao Chen
From: Taotao Chen Set FOP_DONTCACHE in ext4_file_operations to declare support for uncached buffered I/O. To handle this flag, update ext4_write_begin() and ext4_da_write_begin() to use write_begin_get_folio(), which encapsulates FGP_DONTCACHE logic based on iocb->ki_flags. Part of a series ref

[PATCH] drm/sched: Avoid double re-lock on the job free path

2025-07-16 Thread Tvrtko Ursulin
Currently the job free work item will lock sched->job_list_lock first time to see if there are any jobs, free a single job, and then lock again to decide whether to re-queue itself if there are more finished jobs. Since drm_sched_get_finished_job() already looks at the second job in the queue we c

[PATCH] drm/sched: Fix a race in DRM_GPU_SCHED_STAT_NO_HANG test

2025-07-16 Thread Tvrtko Ursulin
The "skip reset" test waits for the timeout handler to run for the duration of 2 * MOCK_TIMEOUT, and because the mock scheduler opted to remove the "skip reset" flag once it fires, this gives opportunity for the timeout handler to run twice. Second time the job will be removed from the mock schedul

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread cao, lin
[AMD Official Use Only - AMD Internal Distribution Only] Hi Philipp, Thank you for the review. I found that this optimization was introduced 9 years ago in commit 777dbd458c89d4ca74a659f85ffb5bc817f29a35 ("drm/amdgpu: drop a dummy wakeup scheduler"). Given that the codebase has undergone signi

[PATCH v5 02/10] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-07-16 Thread Andy Yan
From: Andy Yan The DW DP TX Controller is compliant with the DisplayPort Specification Version 1.4 with the following features: * DisplayPort 1.4a * Main Link: 1/2/4 lanes * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps * AUX channel 1Mbps * Single Stream Transport(SST) * Multistream

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread cao, lin
[AMD Official Use Only - AMD Internal Distribution Only] Hi Philipp, Christian, I modified the commit msg as: drm/sched: Remove optimization that causes hang when killing dependent jobs When application A submits jobs and application B submits a job with a dependency on A's fence, the normal fl

[PATCH v5 03/10] drm/rockchip: Add RK3588 DPTX output support

2025-07-16 Thread Andy Yan
From: Andy Yan Add driver extension for Synopsys DesignWare DPTX IP used on Rockchip RK3588 SoC. Signed-off-by: Andy Yan Acked-by: Dmitry Baryshkov Tested-by: Nicolas Frattaroli --- (no changes since v4) Changes in v4: - Drop unused function - Add platform_set_drvdata Changes in v2: - no

[PATCH v5 08/10] arm64: dts: rockchip: Add DP1 for rk3588

2025-07-16 Thread Andy Yan
From: Andy Yan The DP1 is compliant with the DisplayPort Specification Version 1.4, and share the USBDP combo PHY1 with USB 3.1 HOST1 controller. Signed-off-by: Andy Yan --- (no changes since v1) .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 30 +++ 1 file changed, 30 inser

[PATCH v5 01/10] dt-bindings: display: rockchip: Add schema for RK3588 DPTX Controller

2025-07-16 Thread Andy Yan
From: Andy Yan The Rockchip RK3588 SoC integrates the Synopsys DesignWare DPTX controller. And this DPTX controller need share a USBDP PHY with the USB 3.0 OTG controller during operation. Signed-off-by: Andy Yan Reviewed-by: Rob Herring (Arm) --- (no changes since v2) Changes in v2: - Link

[PATCH v5 09/10] arm64: dts: rockchip: Enable DisplayPort for rk3588s Cool Pi 4B

2025-07-16 Thread Andy Yan
From: Andy Yan Enable the Mini DisplayPort on this board. Note that ROCKCHIP_VOP2_EP_DP0 is defined as 10 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, expected "a"" if we use it directly after endpoint, so we use "a" instead here. Signed-off-by: An

[PATCH v5 05/10] dt-bindings: display: simple-bridge: Add ra620 compatible

2025-07-16 Thread Andy Yan
From: Andy Yan RA620 is a DP to HDMI bridge converter from RADXA, which first found be used on ROCK 5 ITX. This chip can be used without involving software. Signed-off-by: Andy Yan Acked-by: Krzysztof Kozlowski --- (no changes since v3) Changes in v3: - First introduced in this version.

[PATCH v5 10/10] arm64: dts: rockchip: Enable DP2HDMI for ROCK 5 ITX

2025-07-16 Thread Andy Yan
From: Andy Yan The HDMI0(Port next to Headphone Jack) is drived by DP1 on rk3588 via RA620(a dp2hdmi converter). Add related dt nodes to enable it. Note: ROCKCHIP_VOP2_EP_DP1 is defined as 11 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, expected "

[PATCH v5 07/10] arm64: dts: rockchip: Add DP0 for rk3588

2025-07-16 Thread Andy Yan
From: Andy Yan The DP0 is compliant with the DisplayPort Specification Version 1.4, and share the USBDP combo PHY0 with USB 3.1 HOST0 controller. Signed-off-by: Andy Yan --- (no changes since v1) arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 30 +++ 1 file changed, 30 inser

[PATCH v5 00/10] Add support for RK3588 DisplayPort Controller

2025-07-16 Thread Andy Yan
From: Andy Yan There are two DW DPTX based DisplayPort Controller on rk3588 which are compliant with the DisplayPort Specification Version 1.4 with the following features: * DisplayPort 1.4a * Main Link: 1/2/4 lanes * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps * AUX channel 1Mbps

[PATCH v5 04/10] MAINTAINERS: Add entry for DW DPTX Controller bridge

2025-07-16 Thread Andy Yan
From: Andy Yan Add an entry for the DW DPTX Controller bridge driver. Signed-off-by: Andy Yan --- Changes in v5: - First included in this version. MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ee2ef9d9db2ab..f0552f7075c62 100644 ---

[PATCH v5 06/10] drm/birdge: simple-bridge: Add support for radxa ra620

2025-07-16 Thread Andy Yan
From: Andy Yan The RA620 is an active DP to HDMI converter chip, basically no software is involved to drive it. Add it to simple bridge to make it can be find by the drm bridge chain. Signed-off-by: Andy Yan Reviewed-by: Dmitry Baryshkov --- (no changes since v3) Changes in v3: - First int

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Philipp Stanner
On Wed, 2025-07-16 at 13:15 +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 16, 2025 at 12:58:28PM +0200, Christian König wrote: > > On 16.07.25 12:46, Philipp Stanner wrote: > > > +Cc Greg, Sasha > > > > > > On Wed, 2025-07-16 at 12:40 +0200, Michel Dänzer wrote: > > > > On 16.07.25 11:57, Philipp

Re: [PATCH v5 2/3] drm/amdgpu: Reset the clear flag in buddy during resume

2025-07-16 Thread Arunpravin Paneer Selvam
On 7/16/2025 4:31 PM, Christian König wrote: On 16.07.25 12:47, Christian König wrote: On 16.07.25 12:28, Arunpravin Paneer Selvam wrote: Hi Dave, I am trying to push this series into drm-misc-fixes, but I get the below error when dim push-branch drm-misc-fixes. dim:ERROR:e24c180b4300("drm

[PATCH v9 4/5] misc: fastrpc: Cleanup the domain names

2025-07-16 Thread Ling Xu
Currently the domain ids are added for each instance of domains, this is totally not scalable approach. Clean this mess and create domain ids for only domains not its instances. Co-developed-by: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla Signed-off-by: Ling Xu --- drivers/misc/fast

[PATCH v9 5/5] misc: fastrpc: add support for gdsp remoteproc

2025-07-16 Thread Ling Xu
Some platforms (like sa8775p) feature one or more GPDSPs (General Purpose DSPs). Similar to other kinds of Hexagon DSPs, they provide a FastRPC implementation, allowing code execution in both signed and unsigned protection domains. Extend the checks to allow domain names starting with "gdsp" (possi

[PATCH v9 2/5] arm64: dts: qcom: sa8775p: add GDSP fastrpc-compute-cb nodes

2025-07-16 Thread Ling Xu
Add GDSP0 and GDSP1 fastrpc compute-cb nodes for sa8775p SoC. Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Ling Xu --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 57 +++ 1 file changed, 57 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa87

[PATCH v9 3/5] misc: fastrpc: Remove kernel-side domain checks from capability ioctl

2025-07-16 Thread Ling Xu
Domain ID in the uAPI is misleading. Remove checks and log messages related to 'domain' field in capability structure. Update UAPI to mark the field as unused. Signed-off-by: Ling Xu --- drivers/misc/fastrpc.c | 14 +- include/uapi/misc/fastrpc.h | 2 +- 2 files changed, 2 inse

[PATCH v9 0/5] Add support for gdsp remoteproc on sa8775p

2025-07-16 Thread Ling Xu
The fastrpc driver has support for 5 types of remoteprocs. There are some products which support GDSP remoteprocs. GDSP is General Purpose DSP where tasks can be offloaded. Add fastrpc nodes and task offload support for GDSP. Also strict domain IDs for domain. Patch [v9]: https://lore.kernel.org/l

[PATCH v9 1/5] dt-bindings: misc: qcom,fastrpc: Add GDSP label

2025-07-16 Thread Ling Xu
There are some products which support GDSP remoteprocs. GDSP is General Purpose DSP where tasks can be offloaded. There are 2 GDSPs named gdsp0 and gdsp1. Add "gdsp0" and "gdsp1" as the new supported labels for GDSP fastrpc domains. Acked-by: Krzysztof Kozlowski Signed-off-by: Ling Xu --- Docum

Re: [PATCH] drm/sched: Avoid double re-lock on the job free path

2025-07-16 Thread Maíra Canal
Hi Tvrtko, On 16/07/25 05:51, Tvrtko Ursulin wrote: Currently the job free work item will lock sched->job_list_lock first time to see if there are any jobs, free a single job, and then lock again to decide whether to re-queue itself if there are more finished jobs. Since drm_sched_get_finished_

[PATCH] drm/tidss: encoder: convert to devm_drm_bridge_alloc()

2025-07-16 Thread Michael Walle
Convert the tidss encoder to use devm_drm_bridge_alloc(). Instead of allocating the memory by drmm_simple_encoder_alloc() use devm_drm_bridge_alloc() and initialize the encoder afterwards. Fixes: a7748dd127ea ("drm/bridge: get/put the bridge reference in drm_bridge_add/remove()") Signed-off-by: M

Re: [PATCH] drm/sched: Avoid double re-lock on the job free path

2025-07-16 Thread Tvrtko Ursulin
On 16/07/2025 14:31, Maíra Canal wrote: Hi Tvrtko, On 16/07/25 05:51, Tvrtko Ursulin wrote: Currently the job free work item will lock sched->job_list_lock first time to see if there are any jobs, free a single job, and then lock again to decide whether to re-queue itself if there are more f

Re: [PATCH] drm/sched: Fix a race in DRM_GPU_SCHED_STAT_NO_HANG test

2025-07-16 Thread Philipp Stanner
On Wed, 2025-07-16 at 11:05 -0300, Maíra Canal wrote: > Hi Tvrtko, > > On 16/07/25 10:41, Tvrtko Ursulin wrote: > > > > On 16/07/2025 13:47, Maíra Canal wrote: > > > Hi Tvrtko, > > > > > > On 16/07/25 05:48, Tvrtko Ursulin wrote: > > > > The "skip reset" test waits for the timeout handler to run

Re: [PATCH] drm/sched: Fix a race in DRM_GPU_SCHED_STAT_NO_HANG test

2025-07-16 Thread Maíra Canal
Hi Tvrtko, On 16/07/25 11:13, Tvrtko Ursulin wrote: On 16/07/2025 15:05, Maíra Canal wrote: Hi Tvrtko, On 16/07/25 10:41, Tvrtko Ursulin wrote: On 16/07/2025 13:47, Maíra Canal wrote: Hi Tvrtko, On 16/07/25 05:48, Tvrtko Ursulin wrote: The "skip reset" test waits for the timeout handler

Re: [PATCH 2/9] mei: late_bind: add late binding component driver

2025-07-16 Thread Greg KH
On Wed, Jul 16, 2025 at 02:26:26PM +, Usyskin, Alexander wrote: > > > > > + if (bytes < sizeof(rsp)) { > > > > > + dev_err(dev, "bad response from the firmware: size %zd < > > > > %zu\n", > > > > > + bytes, sizeof(rsp)); > > > > > + ret = -EPROTO;

Re: [PATCH] drm/sched: Avoid double re-lock on the job free path

2025-07-16 Thread Tvrtko Ursulin
On 16/07/2025 15:30, Maíra Canal wrote: Hi Tvrtko, On 16/07/25 10:49, Tvrtko Ursulin wrote: On 16/07/2025 14:31, Maíra Canal wrote: Hi Tvrtko, On 16/07/25 05:51, Tvrtko Ursulin wrote: Currently the job free work item will lock sched->job_list_lock first time to see if there are any jobs,

[PATCH] drm/sched: Consolidate drm_sched_job_timedout

2025-07-16 Thread Tvrtko Ursulin
Reduce to one spin_unlock for hopefully a little bit clearer flow in the function. It may appear that there is a behavioural change with the drm_sched_start_timeout_unlocked() now not being called if there were initially no jobs on the pending list, and then some appeared after unlock, however if t

Re: [PATCH next] drm/xe: Fix a NULL vs IS_ERR() bug in xe_i2c_register_adapter()

2025-07-16 Thread Rodrigo Vivi
On Tue, Jul 15, 2025 at 05:59:44PM -0500, Dan Carpenter wrote: > The fwnode_create_software_node() function returns error pointers. It > never returns NULL. Update the checks to match. > > Fixes: f0e53aadd702 ("drm/xe: Support for I2C attached MCUs") Reviewed-by: Rodrigo Vivi and pushing soon

Re: [PATCH v9 3/5] misc: fastrpc: Remove kernel-side domain checks from capability ioctl

2025-07-16 Thread Konrad Dybcio
On 7/16/25 5:00 PM, Dmitry Baryshkov wrote: > On Wed, Jul 16, 2025 at 06:58:34PM +0530, Ling Xu wrote: >> Domain ID in the uAPI is misleading. Remove checks and log messages >> related to 'domain' field in capability structure. Update UAPI to >> mark the field as unused. >> >> Signed-off-by: Ling X

Re: [PATCH v8 9/9] PCI: Add a new 'boot_display' attribute

2025-07-16 Thread Mario Limonciello
On 7/16/25 3:22 AM, Maxime Ripard wrote: Hi Mario, On Mon, Jul 14, 2025 at 04:21:46PM -0500, Mario Limonciello wrote: From: Mario Limonciello On systems with multiple GPUs there can be uncertainty which GPU is the primary one used to drive the display at bootup. In order to disambiguate this

Re: [PATCH v9 3/5] misc: fastrpc: Remove kernel-side domain checks from capability ioctl

2025-07-16 Thread Dmitry Baryshkov
On Wed, Jul 16, 2025 at 05:21:20PM +0200, Konrad Dybcio wrote: > On 7/16/25 5:00 PM, Dmitry Baryshkov wrote: > > On Wed, Jul 16, 2025 at 06:58:34PM +0530, Ling Xu wrote: > >> Domain ID in the uAPI is misleading. Remove checks and log messages > >> related to 'domain' field in capability structure.

Re: [PATCH 2/3] drm/tests: edid: Update CTA-861 HDMI Vendor Specific Data Block

2025-07-16 Thread Thomas Zimmermann
Hi Am 16.07.25 um 17:06 schrieb Maxime Ripard: Hi Thomas, On Mon, Jul 14, 2025 at 01:02:33PM +0200, Thomas Zimmermann wrote: Hi Am 25.06.25 um 17:14 schrieb Maxime Ripard: For some reason, the HDMI VSDBs in our kunit EDIDs had a length longer than expected. While this was harmless, we shoul

Re: [PATCH 00/14] drm/panel: Use refcounted allocation in place of devm_kzalloc() - Part5

2025-07-16 Thread Maxime Ripard
On Thu, 10 Jul 2025 23:31:11 -0500, Anusha Srivatsa wrote: > Use the new API devm_drm_panel_alloc() for panel allocations. > A major chunk of driver conversion was sent in a 3 part series > which is already merged. The coccinelle patch that was used to > identify unsafe panel allocations didnt flag

[RFC PATCH 0/3] drm/imagination: add AM62P/AM67A/J722S support

2025-07-16 Thread Michael Walle
The AM62P and AM67A/J722S feature the same BXS-4 GPU as the J721S2. In theory, one have to just add the DT node. But it turns out, that the clock handling is not working. If I understood Nishan Menon correct, it is working on the J721S2 because there, the clock is shared, while on the AM62P the GPU

[RFC PATCH 1/3] dt-bindings: gpu: img: Add AM62P SoC specific compatible

2025-07-16 Thread Michael Walle
The AM62P and the J722S features the same BXS-4 GPU as the J721S2. Add a new SoC specific compatible. Signed-off-by: Michael Walle --- Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpu/img,powerv

[RFC PATCH 2/3] drm/imagination: fix clock control on the J722S

2025-07-16 Thread Michael Walle
The J722S won't let you set the clock frequency if there is no device using it. Thus, the assigned-clocks property won't work per se. As a workaround, set the clock again during the probing of the driver. Signed-off-by: Michael Walle --- drivers/gpu/drm/imagination/pvr_device.c | 9 + 1

[RFC PATCH 3/3] arm64: dts: ti: add GPU node

2025-07-16 Thread Michael Walle
The J722S features a BXS-4 GPU. Add the node for it. Signed-off-by: Michael Walle --- .../boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j

Re: [PATCH] drm/sched: Fix a race in DRM_GPU_SCHED_STAT_NO_HANG test

2025-07-16 Thread Tvrtko Ursulin
On 16/07/2025 13:47, Maíra Canal wrote: Hi Tvrtko, On 16/07/25 05:48, Tvrtko Ursulin wrote: The "skip reset" test waits for the timeout handler to run for the duration of 2 * MOCK_TIMEOUT, and because the mock scheduler opted to Would it make any sense to wait for 1.5 * MOCK_TIMEOUT? This w

Re: [PATCH] drm/sched: Fix a race in DRM_GPU_SCHED_STAT_NO_HANG test

2025-07-16 Thread Maíra Canal
Hi Tvrtko, On 16/07/25 10:41, Tvrtko Ursulin wrote: On 16/07/2025 13:47, Maíra Canal wrote: Hi Tvrtko, On 16/07/25 05:48, Tvrtko Ursulin wrote: The "skip reset" test waits for the timeout handler to run for the duration of 2 * MOCK_TIMEOUT, and because the mock scheduler opted to Would it

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Greg Kroah-Hartman
On Wed, Jul 16, 2025 at 04:11:27PM +0200, Philipp Stanner wrote: > On Wed, 2025-07-16 at 14:05 +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 16, 2025 at 01:32:42PM +0200, Philipp Stanner wrote: > > > On Wed, 2025-07-16 at 13:15 +0200, Greg Kroah-Hartman wrote: > > > > On Wed, Jul 16, 2025 at 12:

RE: [PATCH 2/9] mei: late_bind: add late binding component driver

2025-07-16 Thread Usyskin, Alexander
> Subject: Re: [PATCH 2/9] mei: late_bind: add late binding component driver > > On Wed, Jul 16, 2025 at 11:58:19AM +, Usyskin, Alexander wrote: > > > Subject: Re: [PATCH 2/9] mei: late_bind: add late binding component driver > > > > > > On Thu, Jul 10, 2025 at 11:08:33AM -0400, Rodrigo Vivi w

Re: [PATCH v2] virtio: Update kerneldoc in drivers/virtio/virtio_dma_buf.c

2025-07-16 Thread Michael S. Tsirkin
On Sat, Jul 05, 2025 at 10:58:03AM +0800, jiang.pe...@zte.com.cn wrote: > From: Peng Jiang > > Fix kernel-doc descriptions in virtio_dma_buf.c to fix W=1 warnings: > > drivers/virtio/virtio_dma_buf.c:41 function parameter 'dma_buf' not described > in 'virtio_dma_buf_attach' > drivers/virtio/vir

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Philipp Stanner
On Wed, 2025-07-16 at 14:05 +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 16, 2025 at 01:32:42PM +0200, Philipp Stanner wrote: > > On Wed, 2025-07-16 at 13:15 +0200, Greg Kroah-Hartman wrote: > > > On Wed, Jul 16, 2025 at 12:58:28PM +0200, Christian König wrote: > > > > On 16.07.25 12:46, Philipp

Re: [PATCH] drm/sched: Fix a race in DRM_GPU_SCHED_STAT_NO_HANG test

2025-07-16 Thread Tvrtko Ursulin
On 16/07/2025 15:05, Maíra Canal wrote: Hi Tvrtko, On 16/07/25 10:41, Tvrtko Ursulin wrote: On 16/07/2025 13:47, Maíra Canal wrote: Hi Tvrtko, On 16/07/25 05:48, Tvrtko Ursulin wrote: The "skip reset" test waits for the timeout handler to run for the duration of 2 * MOCK_TIMEOUT, and beca

Re: [PATCH] drm/sched: Avoid double re-lock on the job free path

2025-07-16 Thread Maíra Canal
Hi Tvrtko, On 16/07/25 10:49, Tvrtko Ursulin wrote: On 16/07/2025 14:31, Maíra Canal wrote: Hi Tvrtko, On 16/07/25 05:51, Tvrtko Ursulin wrote: Currently the job free work item will lock sched->job_list_lock first time to see if there are any jobs, free a single job, and then lock again to

Re: [PATCH v8 08/10] arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588-base

2025-07-16 Thread Heiko Stübner
Am Sonntag, 13. Juli 2025, 10:38:58 Mitteleuropäische Sommerzeit schrieb Tomeu Vizoso: > See Chapter 36 "RKNN" from the RK3588 TRM (Part 1). > > The IP is divided in three cores, programmed independently. The first > core though is special, being able to delegate work to the other cores. > > The

Re: [PATCH v9 3/5] misc: fastrpc: Remove kernel-side domain checks from capability ioctl

2025-07-16 Thread Dmitry Baryshkov
On Wed, Jul 16, 2025 at 06:58:34PM +0530, Ling Xu wrote: > Domain ID in the uAPI is misleading. Remove checks and log messages > related to 'domain' field in capability structure. Update UAPI to > mark the field as unused. > > Signed-off-by: Ling Xu > --- > drivers/misc/fastrpc.c | 14 +

Re: [PATCH 2/3] drm/tests: edid: Update CTA-861 HDMI Vendor Specific Data Block

2025-07-16 Thread Maxime Ripard
Hi Thomas, On Mon, Jul 14, 2025 at 01:02:33PM +0200, Thomas Zimmermann wrote: > Hi > > Am 25.06.25 um 17:14 schrieb Maxime Ripard: > > For some reason, the HDMI VSDBs in our kunit EDIDs had a length longer > > than expected. > > > > While this was harmless, we should get rid of it to make it som

Re: [PATCH v9 4/5] misc: fastrpc: Cleanup the domain names

2025-07-16 Thread Dmitry Baryshkov
On Wed, Jul 16, 2025 at 06:58:35PM +0530, Ling Xu wrote: > Currently the domain ids are added for each instance of domains, this is > totally not scalable approach. Clean this mess and create domain ids for > only domains not its instances. > > Co-developed-by: Srinivas Kandagatla > Signed-off-by

Re: [PATCH v2 1/3] drm/panel: jdi-lpm102a188a: Update deprecated MIPI function calls

2025-07-16 Thread Doug Anderson
Hi, On Tue, Jul 15, 2025 at 10:32 PM Brigham Campbell wrote: > > On Mon Jul 14, 2025 at 3:46 PM MDT, Doug Anderson wrote: > > Hi, > > > > On Tue, Jul 8, 2025 at 12:39 AM Brigham Campbell > > wrote: > >> > >> Update jdi-lpm102a188a panel driver to use the "multi" variant of MIPI > >> functions i

Re: [PATCH v4 1/7] drm/panthor: Add support for atomic page table updates

2025-07-16 Thread Steven Price
On 15/07/2025 16:33, Caterina Shablia wrote: > El martes, 15 de julio de 2025 17:08:09 (hora de verano de Europa central), > Caterina Shablia escribió: >> El viernes, 11 de julio de 2025 15:30:21 (hora de verano de Europa central), >> Steven Price escribió: >>> On 07/07/2025 18:04, Caterina Shabli

Re: [PATCH v4 1/7] drm/panthor: Add support for atomic page table updates

2025-07-16 Thread Steven Price
On 15/07/2025 17:09, Caterina Shablia wrote: > El martes, 15 de julio de 2025 17:08:09 (hora de verano de Europa central), > Caterina Shablia escribió: >> El viernes, 11 de julio de 2025 15:30:21 (hora de verano de Europa central), >> Steven Price escribió: >>> On 07/07/2025 18:04, Caterina Shabli

Re: [PATCH v4 7/7] drm/panthor: Add support for repeated mappings

2025-07-16 Thread Steven Price
On 15/07/2025 16:17, Caterina Shablia wrote: > El viernes, 11 de julio de 2025 16:03:26 (hora de verano de Europa central), > Steven Price escribió: >> On 07/07/2025 18:04, Caterina Shablia wrote: >>> From: Boris Brezillon >>> >>> This allows us to optimize mapping of a relatively small >>> porti

Re: [PATCH v3 3/3] drm/panel: ilitek-ili9881c: Add Tianxianwei TWX700100S0 support

2025-07-16 Thread Richard Yao
On Tue, Jul 15, 2025 at 4:07 AM Krzysztof Kozlowski wrote: > On Mon, Jul 14, 2025 at 06:18:01PM -0400, Richard Yao wrote: > > +static const struct ili9881c_desc txw700100s0_desc = { > > + .init = txw700100s0_init, > > + .init_length = ARRAY_SIZE(txw700100s0_init), > > + .mode = &txw70

[PATCH v1] drm/xe: Support Intel Xe GPU dirver Porting on RISC-V Architecture

2025-07-16 Thread zhangzhijie
inb/outb speccial wire not support on other ARCH. Should detect whether arch platform support or not. Signed-off-by: zhangzhijie --- drivers/gpu/drm/i915/display/intel_vga.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i9

Re: [PATCH 6/9] drm/msm/dp: Work around bogus maximum link rate

2025-07-16 Thread Jérôme de Bretagne
On Mon, Jul 14, 2025 at 21:51, Rob Clark wrote: > > On Mon, Jul 14, 2025 at 10:36 AM Dale Whinham wrote: > > > > From: Jérôme de Bretagne > > > > The OLED display in the Surface Pro 11 reports a maximum link rate of > > zero in its DPCD, causing it to fail to probe correctly. > > > > The Surface

Re: [PATCH] scsi:bfa: Double-free vulnerability fix

2025-07-16 Thread jackysliu
On Tue, Jul 15 2025 12:45:00 +0200 Krzysztof Kozlowski wrote: >You should disclose that you used some AI tool for that... and that >other report(s) was really fake finding. People should know you >generated it with AI, so they could make informed decision whether to >even allocate time here. Alth

Re: [PATCH v2] drm/amd/display:fix a Null pointer dereference vulnerability

2025-07-16 Thread jackysliu
On Tue, Jul 15 2025 12:44:40 +0200 Krzysztof Kozlowski wrote: >You should disclose that you used some AI tool for that... and that >other report(s) was really fake finding. People should know you >generated it with AI, so they could make informed decision whether to >even allocate time here. Alt

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Danilo Krummrich
On Wed Jul 16, 2025 at 12:05 PM CEST, lin cao wrote: > [AMD Official Use Only - AMD Internal Distribution Only] Two small off-topic remarks from my side. :) Can you please remove "AMD Official Use Only" header when sending to public mailing lists? Otherwise people may have to delete your mails un

Re: [PATCH v3 0/5] drm/sitronix/st7571-i2c: Add support for the ST7567 Controller

2025-07-16 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > This patch-series adds support for the Sitronix ST7567 Controller, which is a > monochrome Dot Matrix LCD Controller that has SPI, I2C and parallel > interfaces. > > The st7571-i2c driver only has support for I2C so displays using other > transport > interface

linux-next: manual merge of the rust tree with the drm-misc tree

2025-07-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the rust tree got a conflict in: rust/kernel/drm/gem/mod.rs between commit: 917b10d90990 ("drm: rust: rename as_ref() to from_raw() for drm constructors") from the drm-misc tree and commit: 8802e1684378 ("rust: types: add Opaque::cast_from") from the

Re: [PATCH v5 2/3] drm/amdgpu: Reset the clear flag in buddy during resume

2025-07-16 Thread Arunpravin Paneer Selvam
Hi Dave, I am trying to push this series into drm-misc-fixes, but I get the below error when dim push-branch drm-misc-fixes. dim:ERROR:e24c180b4300("drm/amdgpu:Reset the clear flag in buddy during resume"): Mandatory Maintainer Acked-by missing., aborting Looks like maintainers Acked-by is

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Christian König
On 16.07.25 11:43, cao, lin wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > > Hi Philipp, > > Thank you for the review. I found that this optimization was introduced 9 > years ago in commit 777dbd458c89d4ca74a659f85ffb5bc817f29a35 ("drm/amdgpu: > drop a dummy wakeup sched

Re: [PATCH] drm/msm/dpu: correct dpu_plane_virtual_atomic_check()

2025-07-16 Thread Konrad Dybcio
On 7/15/25 7:28 PM, Dmitry Baryshkov wrote: > Fix c&p error in dpu_plane_virtual_atomic_check(), compare CRTC width > too, in addition to CRTC height. > > Fixes: 8c62a31607f6 ("drm/msm/dpu: allow using two SSPP blocks for a single > plane") > Reported-by: kernel test robot > Closes: > https://l

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Michel Dänzer
On 16.07.25 11:57, Philipp Stanner wrote: > On Wed, 2025-07-16 at 09:43 +, cao, lin wrote: >> >> Hi Philipp, >> >> >> Thank you for the review. I found that this optimization was >> introduced 9 years ago in commit >> 777dbd458c89d4ca74a659f85ffb5bc817f29a35 ("drm/amdgpu: drop a dummy >> wakeup

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Christian König
On 16.07.25 12:13, Danilo Krummrich wrote: > On Wed Jul 16, 2025 at 12:05 PM CEST, lin cao wrote: >> [AMD Official Use Only - AMD Internal Distribution Only] > > Two small off-topic remarks from my side. :) > > Can you please remove "AMD Official Use Only" header when sending to public > mailing

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Philipp Stanner
+Cc Greg, Sasha On Wed, 2025-07-16 at 12:40 +0200, Michel Dänzer wrote: > On 16.07.25 11:57, Philipp Stanner wrote: > > On Wed, 2025-07-16 at 09:43 +, cao, lin wrote: > > > > > > Hi Philipp, > > > > > > > > > Thank you for the review. I found that this optimization was > > > introduced 9 ye

Re: [PATCH v5 2/3] drm/amdgpu: Reset the clear flag in buddy during resume

2025-07-16 Thread Christian König
On 16.07.25 12:28, Arunpravin Paneer Selvam wrote: > Hi Dave, > > I am trying to push this series into drm-misc-fixes, but I get the below > error when dim push-branch drm-misc-fixes. > > dim:ERROR:e24c180b4300("drm/amdgpu:Reset the clear flag in buddy during > resume"): Mandatory Maintainer Ac

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Christian König
On 16.07.25 12:46, Philipp Stanner wrote: > +Cc Greg, Sasha > > On Wed, 2025-07-16 at 12:40 +0200, Michel Dänzer wrote: >> On 16.07.25 11:57, Philipp Stanner wrote: >>> On Wed, 2025-07-16 at 09:43 +, cao, lin wrote: Hi Philipp, Thank you for the review. I found that th

Re: [PATCH v5 2/3] drm/amdgpu: Reset the clear flag in buddy during resume

2025-07-16 Thread Christian König
On 16.07.25 12:47, Christian König wrote: > On 16.07.25 12:28, Arunpravin Paneer Selvam wrote: >> Hi Dave, >> >> I am trying to push this series into drm-misc-fixes, but I get the below >> error when dim push-branch drm-misc-fixes. >> >> dim:ERROR:e24c180b4300("drm/amdgpu:Reset the clear flag in b

Re: [PATCH v5 2/3] drm/amdgpu: Reset the clear flag in buddy during resume

2025-07-16 Thread Arunpravin Paneer Selvam
Hi Christian, On 7/16/2025 4:17 PM, Christian König wrote: On 16.07.25 12:28, Arunpravin Paneer Selvam wrote: Hi Dave, I am trying to push this series into drm-misc-fixes, but I get the below error when dim push-branch drm-misc-fixes. dim:ERROR:e24c180b4300("drm/amdgpu:Reset the clear flag i

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Greg Kroah-Hartman
On Wed, Jul 16, 2025 at 12:58:28PM +0200, Christian König wrote: > On 16.07.25 12:46, Philipp Stanner wrote: > > +Cc Greg, Sasha > > > > On Wed, 2025-07-16 at 12:40 +0200, Michel Dänzer wrote: > >> On 16.07.25 11:57, Philipp Stanner wrote: > >>> On Wed, 2025-07-16 at 09:43 +, cao, lin wrote: >

Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs

2025-07-16 Thread Greg Kroah-Hartman
On Wed, Jul 16, 2025 at 12:46:21PM +0200, Philipp Stanner wrote: > +Cc Greg, Sasha > > On Wed, 2025-07-16 at 12:40 +0200, Michel Dänzer wrote: > > On 16.07.25 11:57, Philipp Stanner wrote: > > > On Wed, 2025-07-16 at 09:43 +, cao, lin wrote: > > > > > > > > Hi Philipp, > > > > > > > > > > >

[PATCH] drm/ttm: rename ttm_bo_put to _fini v2

2025-07-16 Thread Christian König
Give TTM BOs a separate cleanup function. No funktional change, but the next step in removing the TTM BO reference counting and replacing it with the GEM object reference counting. v2: move the code around a bit to make it clearer what's happening Signed-off-by: Christian König --- drivers/gpu

Re: [PATCH] misc: fastrpc: Use of_reserved_mem_region_to_resource() for "memory-region"

2025-07-16 Thread Greg Kroah-Hartman
On Sat, Jul 12, 2025 at 07:27:42PM +0100, Srinivas Kandagatla wrote: > > > On 7/3/25 7:34 PM, Rob Herring (Arm) wrote: > > Use the newly added of_reserved_mem_region_to_resource() function to > > handle "memory-region" properties. > > > > The error handling is a bit different. "memory-region" is

  1   2   >