Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

2025-04-04 Thread Danilo Krummrich
On Thu, Apr 03, 2025 at 12:17:29PM +0200, Philipp Stanner wrote: > On Thu, 2025-04-03 at 12:13 +0200, Philipp Stanner wrote: > > -static int > > -nouveau_fence_signal(struct nouveau_fence *fence) > > +static void > > +nouveau_fence_cleanup_cb(struct dma_fence *dfence, struct > > dma_fence_cb *cb) >

[PATCH v2 14/18] drm/bridge: cdns-dsi: Use videomode internally

2025-04-04 Thread Tomi Valkeinen
The drm_display_mode is a bit difficult one to use (we need hfp, hbp, ... instead of hsync_start, hsync_end, ...) and understand (when to use crtc_* fields). To simplify the code, use struct videomode internally which cleans up the code. If in the future we want to use crtc_* fields in some code p

[PATCH v4 00/18] Imagination BXS-4-64 MC1 GPU support

2025-04-04 Thread Matt Coster
This GPU is found in the TI AM68 family of SoCs, with initial support added to the k3-j721s2 devicetree and tested on a TI SK-AM68 board. A suitable firmware binary can currently be found in the IMG linux-firmware repository[1] as powervr/rogue_36.53.104.796_v1.fw. No new UAPI will be necessary f

[PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-04-04 Thread Alex Hung
cursor plane does not need to have color pipeline. Signed-off-by: Alex Hung --- v7: - Add a commit messages drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/

[PATCH v7 6/6] drm/xe/pf: Set VF LMEM BAR size

2025-04-04 Thread Michał Winiarski
LMEM is partitioned between multiple VFs and we expect that the more VFs we have, the less LMEM is assigned to each VF. This means that we can achieve full LMEM BAR access without the need to attempt full VF LMEM BAR resize via pci_resize_resource(). Always try to set the largest possible BAR size

Re: [PATCH v3] backlight: pm8941: Add NULL check in wled_configure()

2025-04-04 Thread Daniel Thompson
On Tue, Apr 01, 2025 at 04:29:50PM +0800, Henry Martin wrote: > The function wled_configure() uses devm_kasprintf() without checking for > allocation failures, which could lead to NULL pointer dereferences. > > Add proper error handling when devm_kasprintf() fails by: > - Returning -ENOMEM immediat

[PATCH 0/3] drm/panthor: Misc fixes

2025-04-04 Thread Boris Brezillon
Hello, This is a collection of fixes for bugs found while working on adding JM support to panthor. Those are not particularly tied to JM support and are worth having regardless. Note that the last one doesn't have a Fixes tag because all MMU faults are considered fatal right now, so unblocking th

[PATCH v2 08/30] panel/panel-ili9805: Use refcounted allocation in place of devm_kzalloc()

2025-04-04 Thread Anusha Srivatsa
Start using the new helper that does the refcounted allocations Signed-off-by: Anusha Srivatsa --- v2: none. --- drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/g

Re: [PATCH v6 09/10] optee: FF-A: dynamic restricted memory allocation

2025-04-04 Thread Sumit Garg
+ MM folks to seek guidance here. On Thu, Mar 27, 2025 at 09:07:34AM +0100, Jens Wiklander wrote: > Hi Sumit, > > On Tue, Mar 25, 2025 at 8:42 AM Sumit Garg wrote: > > > > On Wed, Mar 05, 2025 at 02:04:15PM +0100, Jens Wiklander wrote: > > > Add support in the OP-TEE backend driver dynamic restr

[PATCH v2 17/18] drm/bridge: cdns-dsi: Drop cdns_dsi_adjust_phy_config()

2025-04-04 Thread Tomi Valkeinen
cdns_dsi_adjust_phy_config() is called from cdns_dsi_adjust_phy_config(), which is called from .atomic_check(). It checks the DSI htotal and adjusts it to align on the DSI lane boundary by changing hfp and then recalculating htotal and HS clock rate. This has a few problems. First is the fact tha

Re: [PATCH v2 2/5] drm/panthor: Call panthor_gpu_coherency_init() after PM resume()

2025-04-04 Thread Steven Price
On 01/04/2025 19:23, Boris Brezillon wrote: > When the device is coherent, panthor_gpu_coherency_init() will read > GPU_COHERENCY_FEATURES to make sure the GPU supports the ACE-Lite > coherency protocol, which will fail if the clocks/power-domains are > not enabled when the read is done. Move the >

[PATCH RESEND] (drm/rockchip): Consistently use rk3399 registers consts

2025-04-04 Thread Konstantin Shabanov
As rk3399 has its own registers definitions, update related structs to use them. There are no changes in behaviour as updated constants values are the for rk3288/rk3368/rk3399 chips. Signed-off-by: Konstantin Shabanov --- Apologies for resend. The first email hadn't reached the mailing list for

[PATCH v3 30/54] drm: use correct ccflags-y spelling

2025-04-04 Thread Jim Cromie
Incorrectly spelled CFLAGS- failed to add -DDYNAMIC_DEBUG_MODULE, which disabled dynamic-debug in modules built with: CONFIG_DYNAMIC_DEBUG=n # 1 CONFIG_DYNAMIC_DEBUG_CORE=y # 2 CONFIG_DRM_USE_DYNAMIC_DEBUG=y # 3 NB: this adds the flag (when 3) more often than strictly needed; module

[PATCH v2 1/9] drm/panthor: Add 64-bit and poll register accessors

2025-04-04 Thread Karunika Choo
This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_regs.h | 55 ++ 1 file changed, 55 insertions(+) diff --git a

[PATCH v3 7/8] drm/panthor: Make heap chunk allocation non-blocking

2025-04-04 Thread Boris Brezillon
Make heap chunk allocation non-blocking when we are in the growing path. This way, we can fail the job and signal its fence instead of blocking on memory reclaim, which will become problematic once we throw a memory shrinker into the mix. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/pantho

[PATCH 04/10] drm/i915/display: Add filter lut values

2025-04-04 Thread Nemesa Garg
Add the register bits related to filter lut values. These values are golden values and these value has to be loaded one time while enabling the casf. v2: update commit message[Ankit] Signed-off-by: Nemesa Garg Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_casf.c | 22 +

[PATCH v3 9/9] arm64: dts: rockchip: Enable DP2HDMI for ROCK 5 ITX

2025-04-04 Thread Andy Yan
From: Andy Yan The HDMI0(Port next to Headphone Jack) is drived by DP1 on rk3588 via RA620(a dp2hdmi converter). Add related dt nodes to enable it. Note: ROCKCHIP_VOP2_EP_DP1 is defined as 11 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, expected "

[PATCH v3 1/7] dt-bindings: display: rockchip, inno-hdmi: Fix Document of RK3036 compatible

2025-04-04 Thread Andy Yan
From: Andy Yan The RK3036 HDMI DDC bus requires it's PHY's reference clock to be enabled first before normal DDC communication can be carried out. Therefore, both RK3036 and RK3128 HDMI require two identical clocks. Signed-off-by: Andy Yan Reviewed-by: Rob Herring (Arm) --- (no changes sinc

[PATCH 0/7] drm/panel: make prepare / enable / disable / unprepare return void

2025-04-04 Thread Dmitry Baryshkov
While it makes sense for panel callbacks to be able to return an error, the state-management functions from drm_panel API are usually called from atomic callbacks, which can not fails and must return void. Make drm_panel_prepare(), drm_panel_enable(), drm_panel_disable() and drm_panel_unprepare() f

[PATCH 27/46] panel/sitronix-st7703: Use refcounted allocation in place of devm_kzalloc()

2025-04-04 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/dr

Re: [PATCH v5 0/3] drm/i915: Fix harmful driver register/unregister asymmetry

2025-04-04 Thread Andi Shyti
Hi Janusz, > Janusz Krzysztofik (3): > drm/i915: Downgrade device register error if injected > drm/i915: Fix PXP cleanup missing from probe error rewind > drm/i915: Fix harmful driver register/unregister asymmetry merged to drm-intel-next. Thanks, Andi

[PATCH v2 30/34] drm/msm: Crashdump prep for sparse mappings

2025-04-04 Thread Rob Clark
From: Rob Clark In this case, userspace could request dumping partial GEM obj mappings. Also drop use of should_dump() helper, which really only makes sense in the old submit->bos[] table world. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 17 ++--- 1 file changed,

Re: [PATCH v4 3/8] bits: introduce fixed-type genmasks

2025-04-04 Thread Vincent Mailhol
On 22/03/2025 at 02:05, Yury Norov wrote: > On Wed, Mar 19, 2025 at 09:43:06AM +0530, Anshuman Khandual wrote: >> >> >> On 3/19/25 09:04, Anshuman Khandual wrote: >>> On 3/19/25 07:16, Yury Norov wrote: + Catalin Marinas, ARM maillist (...) >>> These were moved into uapi subsequently via t

[PATCH AUTOSEL 5.4 6/9] drm/amdkfd: Fix pqm_destroy_queue race with GPU reset

2025-04-04 Thread Sasha Levin
From: Philip Yang [ Upstream commit 7919b4cad5545ed93778f11881ceee72e4dbed66 ] If GPU in reset, destroy_queue return -EIO, pqm_destroy_queue should delete the queue from process_queue_list and free the resource. Signed-off-by: Philip Yang Reviewed-by: Felix Kuehling Signed-off-by: Alex Deuche

[PATCH v4 11/11] fbdev: Remove constants of unused events

2025-04-04 Thread Thomas Zimmermann
The constants FB_EVENT_MODE_CHANGE and FB_EVENT_BLANK are unused. Remove them from the header file. Signed-off-by: Thomas Zimmermann Acked-by: Simona Vetter --- include/linux/fb.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index d45bd220cb8f

[PATCH v1 0/5] drm/mediatek: Cleanups and sanitization

2025-04-04 Thread AngeloGioacchino Del Regno
During probe, the mediatek-drm drivers take a bunch of kobject references for the various component sub-drivers and for the mmsys/mutex handles. Unfortunately, the refcount is not correctly decremented in some cases, and not correctly incremented in some others, leading to refcount_t overflows *or

Re: [PATCH v6 00/16] drm/bridge: Various quality of life improvements

2025-04-04 Thread Maxime Ripard
On Thu, 13 Mar 2025 12:59:54 +0100, Maxime Ripard wrote: > Here's a series of changes after to the KMS helpers and bridge API > following a bunch of reviews I did. > > It's mostly centered across providing an easier time to deal with bridge > states, and a somewhat consistent with the other entiti

Re: [PATCH 11/18] drm/sysfb: Merge primary-plane functions

2025-04-04 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Merge the primary plane code of ofdrm and simpledrm. Replace the > plane implementation in each driver with the shared helpers. Set > up driver callbacks and format modifiers with initializer macros. > > The plane code in ofdrm and simpledrm is very similar. Ofdrm has

Re: [PATCH v2 1/3] dt-bindings: display: Add Sitronix ST7571 panel

2025-04-04 Thread Marcus Folkesson
Hi Krzysztof, On Fri, Apr 04, 2025 at 07:36:12PM +0200, Krzysztof Kozlowski wrote: > On 04/04/2025 19:30, Krzysztof Kozlowski wrote: > >> + > >> +examples: > >> + - | > >> +#include > >> + > >> +i2c { > >> +#address-cells = <1>; > >> +#size-cells = <0>; > >> + > >> +

[PATCH 40/46] panel/visionox-vtdr6130: Use refcounted allocation in place of devm_kzalloc()

2025-04-04 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gp

Re: [PATCH v3 1/9] dt-bindings: display: rockchip: Add schema for RK3588 DPTX Controller

2025-04-04 Thread Diederik de Haas
On Thu Apr 3, 2025 at 5:37 AM CEST, Andy Yan wrote: > From: Andy Yan > > The Rockchip RK3588 SoC integrates the Synopsys DesignWare DPTX > controller. And this DPTX controller need share a USBDP PHY with > the USB 3.0 OTG controller during operation. > > Signed-off-by: Andy Yan > Reviewed-by: Rob

[PATCH v2 44/59] drm-dyndbg: add DRM_CLASSMAP_USE to Xe driver

2025-04-04 Thread Jim Cromie
Invoke DRM_CLASSMAP_USE from xe_drm_client.c. When built with CONFIG_DRM_USE_DYNAMIC_DEBUG=y, this tells dydnbg that Xe uses has drm.debug calls. Signed-off-by: Jim Cromie --- drivers/gpu/drm/xe/xe_drm_client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_drm_clie

Re: [PATCH RFC 00/12] dma: Enable dmem cgroup tracking

2025-04-04 Thread Christian König
Hi Maxime, Am 03.04.25 um 17:47 schrieb Maxime Ripard: > On Thu, Apr 03, 2025 at 09:39:52AM +0200, Christian König wrote: >>> For the UMA GPU case where there is no device memory or eviction >>> problem, perhaps a configurable option to just say account memory in >>> memcg for all allocations done

[PATCH v4 06/11] backlight: Replace fb events with a dedicated function call

2025-04-04 Thread Thomas Zimmermann
Remove support for fb events from backlight subsystem. Provide the helper backlight_notify_blank_all() instead. Also export the existing helper backlight_notify_blank() to update a single backlight device. In fbdev, call either helper to inform the backlight subsystem of changes to a display's bla

[PATCH v2 22/30] panel/newvision-nv3052c: Use refcounted allocation in place of devm_kzalloc()

2025-04-04 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- v2: none. --- drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c

[PATCH v2 1/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2025-04-04 Thread Sergio Lopez
Introduce a new feature, HOST_PAGE_SIZE, that indicates the host provides its page size as a value in virtio_gpu_config. Signed-off-by: Sergio Lopez --- drivers/gpu/drm/virtio/virtgpu_drv.c | 1 + drivers/gpu/drm/virtio/virtgpu_drv.h | 2 ++ drivers/gpu/drm/virtio/virtgpu_kms.c | 13 ++

Re: [PATCH] drm: renesas: Add zpos, alpha and blend properties to RZ/G2L DU

2025-04-04 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Fri, Apr 04, 2025 at 02:30:45PM +0100, Biju Das wrote: > Add support for zpos, alpha and blend properties to RZ/G2L DU > driver as the IP supports all these properties. > > It is tested by the below modetest commands: > > modetest -M rzg2l-du -s 44@42:1920x1

[PATCH v2 3/4] tests/intel/xe_vm: Add DRM_IOCTL_XE_VM_GET_PROPERTY validation tests

2025-04-04 Thread Jonathan Cavitt
Add tests to xe_vm that exercise the new DRM_IOCTL_XE_VM_GET_PROPERTY ioctl. Specifically, add input validation tests that exercise the return values for improperly formatted ioctl structures. Signed-off-by: Jonathan Cavitt --- tests/intel/xe_vm.c | 82 ++

[PATCH v3 35/54] drm-dyndbg: DRM_CLASSMAP_USE in i915 driver

2025-04-04 Thread Jim Cromie
Following the dyndbg-api-fix, replace DECLARE_DYNDBG_CLASSMAP with DRM_CLASSMAP_USE. This refs the defined & exported classmap, rather than re-declaring it redundantly, and error-prone-ly. This resolves the appearance of "class:_UNKNOWN_" in the control file for the driver's drm_dbg()s. Fixes: f

Re: [PATCH 2/2] accel/ivpu: Show NPU frequency in sysfs

2025-04-04 Thread Jeff Hugo
On 4/1/2025 9:59 AM, Maciej Falkowski wrote: From: Andrzej Kacprowski Add sysfs files that show maximum and current frequency of the NPU's data processing unit. New sysfs entries: - npu_max_frequency_mhz Don't you have an ioctl to get this, which is fixed in patch 1 of the series? Why dupli

[PATCH AUTOSEL 6.14 16/44] drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)

2025-04-04 Thread Sasha Levin
From: Andrew Wyatt [ Upstream commit b24dcc183583fc360ae0f0899e286a68f46abbd0 ] The Intel model of the OneXPlayer Mini uses a 1200x1920 portrait LCD panel. The DMI strings are the same as the OneXPlayer, which already has a DMI quirk, but the panel is different. Add a DMI match to correctly rot

[git pull] drm fixes for 6.15-rc1

2025-04-04 Thread Dave Airlie
Hi Linus, Weekly fixes, mostly from the end of last week, this week was very quiet, maybe you scared everyone away. I probably should have highlighted Jani's work more closely, but it never occured that anyone would willingingly build a kernel without O=../toilet-builddir. This doesn't contain any

Re: [PATCH] accel/ivpu: Flush pending jobs of device's workqueues

2025-04-04 Thread Jeff Hugo
On 4/1/2025 9:57 AM, Maciej Falkowski wrote: Use flush_work() instead of cancel_work_sync() for driver workqueues to guarantee that remaining pending work will be handled. Fixes: bc3e5f48b7ee ("accel/ivpu: Use workqueue for IRQ handling") Signed-off-by: Maciej Falkowski The fixes tag suggests

Re: [PATCH] drm/vc4: release firmware on error paths in vc4_hvs_bind()

2025-04-04 Thread Dave Stevenson
Hi Dan On Wed, 2 Apr 2025 at 12:00, Dan Carpenter wrote: > > Call rpi_firmware_put() on these two error paths before returning. Ack that there is an issue here, but it seems easier to me to move the block max_rate = rpi_firmware_clk_get_max_rate(firmware, RP

[PATCH AUTOSEL 6.13 12/37] drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)

2025-04-04 Thread Sasha Levin
From: Andrew Wyatt [ Upstream commit b24dcc183583fc360ae0f0899e286a68f46abbd0 ] The Intel model of the OneXPlayer Mini uses a 1200x1920 portrait LCD panel. The DMI strings are the same as the OneXPlayer, which already has a DMI quirk, but the panel is different. Add a DMI match to correctly rot

[PATCH v3 3/8] drm/panfrost: Switch to sparse gem shmem to implement our alloc-on-fault

2025-04-04 Thread Boris Brezillon
Use the new gem_shmem helpers providing sparse GEM backing so we can simplify the code, and finally have a non-blocking allocation scheme in the fault handler path. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- drivers/gpu/drm/panfrost/panfrost_gem.c | 37 ++

[PATCH 08/12] drm/i915/display: Compare the sharpness state

2025-04-04 Thread Nemesa Garg
Compare the sharpness win_size, strength and enable bits Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 4ffe738ad

[PATCH 6.6 08/26] drm/dp_mst: Factor out function to queue a topology probe work

2025-04-04 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Imre Deak commit e9b36c5be2e7fdef2cc933c1dac50bd81881e9b8 upstream. Factor out a function to queue a work for probing the topology, also used by the next patch. Cc: Lyude Paul Cc: dri-devel@l

[PATCH] dt-bindings: display: rockchip,vop: Drop assigned-clocks

2025-04-04 Thread Rob Herring (Arm)
assigned-clock properties are implicitly allowed in any node with 'clocks' and don't have to be specified. The max here also appears to be wrong as there's a case with 4 entries. Signed-off-by: Rob Herring (Arm) --- .../devicetree/bindings/display/rockchip/rockchip-vop.yaml | 6 -- 1 file c

[PATCH] drm/amd/display: do not copy invalid CRTC timing info

2025-04-04 Thread Gergo Koteles
Since b255ce4388e0, it is possible that the CRTC timing information for the preferred mode has not yet been calculated while amdgpu_dm_connector_mode_valid() is running. In this case use the CRTC timing information of the actual mode. Fixes: b255ce4388e0 ("drm/amdgpu: don't change mode in amdgpu

[PATCH v2 53/59] drm-dyndbg: add DRM_CLASSMAP_USE to udl driver

2025-04-04 Thread Jim Cromie
The udl driver has a number of DRM_UT_* debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module uses them. Signed-off-by: Jim Cromie --- drivers/gpu/drm/udl/udl_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/udl/udl_main.

Re: [git pull] drm for 6.15-rc1

2025-04-04 Thread Jason Gunthorpe
On Mon, Mar 31, 2025 at 01:03:38PM +0200, Simona Vetter wrote: > Hi Linus, > > On Mon, Mar 31, 2025 at 01:17:28PM +0300, Jani Nikula wrote: > > On Fri, 28 Mar 2025, Linus Torvalds wrote: > > > If you want to do that hdrtest thing, do it as part of your *own* > > > checks. Don't make everybody els

Re: [PATCH v3 06/10] arm64: dts: qcom: sa8775p: add Display Serial Interface device nodes

2025-04-04 Thread Konrad Dybcio
On 4/4/25 1:55 PM, Ayushi Makhija wrote: > Add device tree nodes for the DSI0 and DSI1 controllers > with their corresponding PHYs found on Qualcomm SA8775P SoC. > > Signed-off-by: Ayushi Makhija > Reviewed-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

[PATCH v2 26/30] panel/novatek-nt36523: Use refcounted allocation in place of devm_kzalloc()

2025-04-04 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- v2: none. --- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/dri

<    1   2   3