Re: [PATCH v6 34/42] drm/mediatek: mtk_hdmi: Add HDMI IP version configuration to pdata

2025-02-13 Thread 胡俊光

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-02-13 Thread Jens Wiklander
Hi, On Thu, Feb 13, 2025 at 7:42 AM Sumit Garg wrote: > > Hi Boris, > > On Thu, 13 Feb 2025 at 01:26, Boris Brezillon > wrote: > > > > +Florent, who's working on protected-mode support in Panthor. > > > > Hi Jens, > > > > On Tue, 17 Dec 2024 11:07:36 +0100 > > Jens Wiklander wrote: > > > > > Hi

Re: [PATCH v6 35/42] drm/mediatek: mtk_hdmi: Split driver and add common probe function

2025-02-13 Thread 胡俊光

Re: [PATCH next] drm/tests: Fix a test in drm_test_check_valid_clones()

2025-02-13 Thread Maxime Ripard
On Wed, 12 Feb 2025 18:24:09 +0300, Dan Carpenter wrote: > The drm_atomic_get_crtc_state() function returns error pointers and not > NULL. Update the check to check for error pointers as well as NULL. > > Applied to misc/kernel.git (drm-misc-next). Thanks! Maxime

Re: [PATCH next] drm: writeback: Fix use after free in drm_writeback_connector_cleanup()

2025-02-13 Thread Maxime Ripard
On Wed, 12 Feb 2025 18:23:48 +0300, Dan Carpenter wrote: > The drm_writeback_cleanup_job() function frees "pos" so call > list_del(&pos->list_entry) first to avoid a use after free. > > Applied to misc/kernel.git (drm-misc-next). Thanks! Maxime

[PATCH 03/12] drm/hisilicon: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH 05/12] drm/mxsfb: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH 07/12] drm/sti: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource/_byname + devm_ioremap with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule@ identifier res; expression ioremap; identifier pdev; constant mem; expression name; @@ -struct resource *res; ... -res = platform_get_resource_byna

[PATCH 06/12] drm/sprd: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_2@ identifier res; expression ioremap; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); <... -if (!res) { -... -} ...>

[PATCH 08/12] drm/stm: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH 09/12] drm/tegra: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

Re: [PATCH v6 14/42] drm/mediatek: mtk_hdmi_ddc: Switch to register as module_platform_driver

2025-02-13 Thread 胡俊光

Re: [PATCH v6 13/42] drm/mediatek: mtk_cec: Switch to register as module_platform_driver

2025-02-13 Thread 胡俊光

[PATCH 04/12] drm/mediatek: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH 00/12] drm: Move to using devm_platform_ioremap_resource

2025-02-13 Thread Anusha Srivatsa
-- 28 files changed, 51 insertions(+), 172 deletions(-) --- base-commit: 68763b29e0a6441f57f9ee652bbf8e7bc59183e5 change-id: 20250213-mem-cocci-v3-5c10e2152e8f Best regards, -- Anusha Srivatsa

[PATCH 01/12] drm/aspeed: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH 02/12] drm/fsl-dcu: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH v2 2/2] drm/edid: Refactor DisplayID timing block structs

2025-02-13 Thread Egor Vorontsov
Using le16 instead of u8[2]. Replaced an error with a printed warning as well. Suggested-by: Jani Nikula Signed-off-by: Egor Vorontsov --- drivers/gpu/drm/drm_displayid_internal.h | 22 drivers/gpu/drm/drm_edid.c | 32 2 files changed, 27

Re: [PATCH v6 08/42] drm/mediatek: mtk_dpi: Support AFIFO 1T1P output and conversion

2025-02-13 Thread 胡俊光

[PATCH 12/12] Documentation: Update the todo

2025-02-13 Thread Anusha Srivatsa
Update the Documentation to be more precise. v2: Update for clarity v3: Further details in Todo Cc: Thomas Zimmermann Signed-off-by: Anusha Srivatsa --- Documentation/gpu/todo.rst | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Doc

[PATCH 10/12] drm/tiny: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH 11/12] drm/vc4: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Anusha Srivatsa
Replace platform_get_resource_byname + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: //rule s/(devm_)platform_get_resource_byname + //(devm_)ioremap/devm_platform_ioremap_resource. @rule_3@ identifier res; expression ioremap; identi

[PATCH v2] drm/i915/gt: Replace kmap with its safer kmap_local_page counterpart

2025-02-13 Thread Andi Shyti
kmap_local_page(), unlike kmap(), performs a contextualized mapping of pages. This means the pages are mapped locally to the thread that created them, making them invisible outside the thread and safer to use. Replace kmap() and kunmap() with kmap_local_page() and kunmap_local() counterparts for i

Re: [PATCH 06/12] drm/sprd: move to devm_platform_ioremap_resource() usage

2025-02-13 Thread Chunyan Zhang
On Fri, 14 Feb 2025 at 08:20, Anusha Srivatsa wrote: > > Replace platform_get_resource + devm_ioremap > with just devm_platform_ioremap_resource() > > Used Coccinelle to do this change. SmPl patch: > @rule_2@ > identifier res; > expression ioremap; > identifier pdev; > @@ > -struct resource *res;

Re: [PATCH v1 1/2] dt-bindings: mfd: Document TI LM3533 MFD

2025-02-13 Thread Svyatoslav Ryhel
чт, 13 лют. 2025 р. о 23:32 Daniel Thompson пише: > > On Wed, Feb 12, 2025 at 09:58:41AM +0200, Svyatoslav Ryhel wrote: > > Add bindings for the LM3533 - a complete power source for > > backlight, keypad, and indicator LEDs in smartphone handsets. > > The high-voltage inductive boost converter pro

Re: [PATCH v6 37/42] drm/mediatek: mtk_hdmi_common: Assign DDC adapter pointer to bridge

2025-02-13 Thread 胡俊光

Re: [PATCH v6 40/42] drm/mediatek: mtk_hdmi_common: Add var to enable interlaced modes

2025-02-13 Thread 胡俊光

Re: [PATCH v1 1/2] dt-bindings: display: bridge: Document Solomon SSD2825

2025-02-13 Thread Svyatoslav Ryhel
чт, 13 лют. 2025 р. о 22:34 Conor Dooley пише: > > On Thu, Feb 13, 2025 at 03:56:04PM +0200, Svyatoslav Ryhel wrote: > > Add bindings for Solomon SSD2825 MIPI master bridge chip that connects an > > application processor with traditional parallel LCD interface and an LCD > > driver with MIPI slave

Re: [PATCH v1 1/2] dt-bindings: mfd: Document TI LM3533 MFD

2025-02-13 Thread Daniel Thompson
On Wed, Feb 12, 2025 at 09:58:41AM +0200, Svyatoslav Ryhel wrote: > Add bindings for the LM3533 - a complete power source for > backlight, keypad, and indicator LEDs in smartphone handsets. > The high-voltage inductive boost converter provides the > power for two series LED strings display backligh

Re: [PATCH] vgaarbiter: documentation grammar correction

2025-02-13 Thread Pranav Tyagi
Hi, Just a gentle follow-up on this patch. It has been reviewed by Bagas Sanjaya but hasn't been applied yet. Regards, Pranav Tyagi On Sat, Feb 8, 2025 at 8:36 AM Bagas Sanjaya wrote: > On Fri, Feb 07, 2025 at 10:23:25PM +0530, Pranav Tyagi wrote: > > Corrects the following grammatical issues

Re: On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-13 Thread Ronja Meyer
On 08.02.2025 21:44, Theodore Ts'o wrote: I'll let you in a secret. The maintainers are not "all-powerfui". We are the "thin blue line" that is trying to keep the code to be maintainable and high quality. Like most leaders of volunteer organization, whether it is the Internet Engineerint Task

Re: [PATCH v6 0/4] Add support for errors recovery in the TI SN65DSI83 bridge driver

2025-02-13 Thread Alexander Stein
Hi, Am Montag, 10. Februar 2025, 14:26:15 CET schrieb Herve Codina: > Hi, > > Usually the TI SN65DSI83 recovers from error by itself but during ESD > tests, we have some cases where the TI SN65DSI83 didn't recover. > > In order to handle those cases, this series adds support for a recovery > mec

Re: [PATCH v2 1/3] drm/display: bridge-connector: add DisplayPort bridges

2025-02-13 Thread Dmitry Baryshkov
On Fri, Feb 14, 2025 at 01:57:45AM +0200, Laurent Pinchart wrote: > Hi Dmitry, > > Thank you for the patch. > > On Sun, Feb 09, 2025 at 03:41:18PM +0200, Dmitry Baryshkov wrote: > > DRM HDMI Codec framework is useful not only for the HDMI bridges, but > > also for the DisplayPort bridges. Add new

Re: On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-13 Thread 33KK
Honestly, how about you accept the fact that maybe the problem is you? You're not doing any good by just scolding Hector for "social media brigading" and not addressing the core issue, especially considering that LKML drama always ends up on social media and on reaction content farms anyway, w

Re: [PATCH v2 3/3] drm/ci: enable lockdep detection

2025-02-13 Thread Helen Mae Koike Fornazier
Hi Vignesh, thanks for your patch. Em ter., 11 de fev. de 2025 às 12:29, Vignesh Raman escreveu: > > We have enabled PROVE_LOCKING (which enables LOCKDEP) in drm-ci. > This will output warnings when kernel locking errors are encountered > and will continue executing tests. To detect if lockdep h

[PATCH v2] gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines

2025-02-13 Thread Vitalii Mordan
If the clock mhdp->clk was not enabled in cdns_mhdp_probe(), it should not be disabled in any path. Use the devm_clk_get_enabled() helper function to ensure proper call balance for mhdp->clk. Found by Linux Verification Center (linuxtesting.org) with Klever. Fixes: fb43aa0acdfd ("drm: bridge: Ad

Re: [PATCH v6 41/42] drm/mediatek: mtk_hdmi_v2: Add debugfs ops and implement ABIST

2025-02-13 Thread 胡俊光

RE: [PATCH v8 01/14] drm: Define histogram structures exposed to user

2025-02-13 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Tuesday, January 28, 2025 9:21 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Kandpal, Suraj ; dmitry.barysh...@linaro.org; > Murthy, Arun R > Subject: [PATCH v8 01/14

Re: [PATCH] drm: Fix DSC BPP increment decoding

2025-02-13 Thread Imre Deak
On Wed, Feb 12, 2025 at 06:46:40PM +0200, Jani Nikula wrote: > On Wed, 12 Feb 2025, Imre Deak wrote: > > Starting with DPCD version 2.0 bits 6:3 of the DP_DSC_BITS_PER_PIXEL_INC > > DPCD register contains the NativeYCbCr422_MAX_bpp_DELTA field, which can > > be non-zero as opposed to earlier DPCD

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-02-13 Thread Boris Brezillon
On Thu, 13 Feb 2025 12:11:52 +0530 Sumit Garg wrote: > Hi Boris, > > On Thu, 13 Feb 2025 at 01:26, Boris Brezillon > wrote: > > > > +Florent, who's working on protected-mode support in Panthor. > > > > Hi Jens, > > > > On Tue, 17 Dec 2024 11:07:36 +0100 > > Jens Wiklander wrote: > > > > > Hi

Re: [PATCH v4 1/6] tee: add restricted memory allocation

2025-02-13 Thread Boris Brezillon
Hi Jens, On Tue, 17 Dec 2024 11:07:37 +0100 Jens Wiklander wrote: > Add restricted memory allocation to the TEE subsystem. > > Restricted memory refers to memory buffers behind a hardware enforced > firewall. It is not accessible to the kernel during normal circumstances > but rather only acces

[PATCH v4 7/8] drm/i915/display: Add drm_panic support for Y-tiling with DPT

2025-02-13 Thread Jocelyn Falempe
On Alderlake and later, it's not possible to disable tiling when DPT is enabled. So this commit implements Y-Tiling support, to still be able to draw the panic screen. Signed-off-by: Jocelyn Falempe --- .../gpu/drm/i915/display/intel_atomic_plane.c | 70 +-- .../drm/i915/display/

Re: On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-13 Thread Icenowy Zheng
于 2025年2月13日 GMT+08:00 19:34:16,Danilo Krummrich 写道: >On Thu, Feb 13, 2025 at 11:49:20AM +0800, Icenowy Zheng wrote: >> 在 2025-02-10星期一的 11:24 +0100,Danilo Krummrich写道: >> > >> > (Additionally, in this particular case even one of the reviewers of >> > DMA MAPPING HELPERS offered to be a review

[PATCH] drm/bridge:anx7625: Enable DSC feature

2025-02-13 Thread Xin Ji
As anx7625 MIPI RX bandwidth(maximum 1.5Gbps per lane) and internal pixel clock(maximum 300M) limitation. Anx7625 must enable DSC feature while MIPI source want to output 4K30 resolution. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 300 ++ drivers/gp

Re: [PATCH v3 7/7] clk: amlogic: axg-audio: use the auxiliary reset driver - take 2

2025-02-13 Thread Arnd Bergmann
On Tue, Feb 11, 2025, at 18:28, Jerome Brunet wrote: > > I also think this is more readeable and maintainable than a bunch of > 'default CONFIG_FOO if CONFIG_FOO' for CONFIG_RESET_MESON_AUX. This approach > also would have several pitfall, such as picking the value of the first > config > set

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-02-13 Thread Boris Brezillon
On Thu, 13 Feb 2025 14:46:01 +0530 Sumit Garg wrote: > On Thu, 13 Feb 2025 at 14:06, Boris Brezillon > wrote: > > > > On Thu, 13 Feb 2025 12:11:52 +0530 > > Sumit Garg wrote: > > > > > Hi Boris, > > > > > > On Thu, 13 Feb 2025 at 01:26, Boris Brezillon > > > wrote: > > > > > > > > +Florent

Re: [PATCH v5 2/3] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter

2025-02-13 Thread Aradhya Bhatia
Hi Tomi, Thank you for reviewing the patches! On 11/02/25 17:54, Tomi Valkeinen wrote: > Hi, > > On 09/02/2025 18:09, Aradhya Bhatia wrote: >> From: Aradhya Bhatia >> >> The OLDI transmitters (TXes) do not have registers of their own, and are >> dependent on the source video-ports (VPs) from th

Re: [PATCH v3 4/7] platform: arm64: lenovo-yoga-c630: use the auxiliary device creation helper

2025-02-13 Thread Ilpo Järvinen
On Tue, 11 Feb 2025, Jerome Brunet wrote: > The auxiliary device creation of this driver is simple enough to > use the available auxiliary device creation helper. > > Use it and remove some boilerplate code. > > Signed-off-by: Jerome Brunet > --- > drivers/platform/arm64/lenovo-yoga-c630.c | 4

Re: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-02-13 Thread Dmitry Baryshkov
On Thu, Feb 13, 2025 at 08:33:30PM +0800, Xin Ji wrote: > As anx7625 MIPI RX bandwidth(maximum 1.5Gbps per lane) and internal > pixel clock(maximum 300M) limitation. Anx7625 must enable DSC feature > while MIPI source want to output 4K30 resolution. This commit message is pretty hard to read and u

Re: [RFC 2/5] drm/scheduler: Add scheduler unit testing infrastructure and some basic tests

2025-02-13 Thread Philipp Stanner
I'm in principle OK with this series. We'll have to discuss a few more things, but from my POV you could send the next revision as a v1. Some more input below.. On Fri, 2025-02-07 at 14:33 +, Tvrtko Ursulin wrote: > Implement a mock scheduler backend and add some basic test to > exercise the

Re: [PATCH v6 38/42] drm/mediatek: mtk_hdmi_common: Add OP_HDMI if helper funcs assigned

2025-02-13 Thread 胡俊光

Re: [PATCH v6 42/42] drm/mediatek/hdmi: Use syscon_regmap_lookup_by_phandle_args

2025-02-13 Thread 胡俊光

Re: On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-13 Thread David Airlie
On Sun, Feb 9, 2025 at 6:48 AM Theodore Ts'o wrote: > > On Fri, Feb 07, 2025 at 06:16:38AM -0600, Dr. Greg wrote: > > > > The all powerful sub-system maintainer model works well if the big > > technology companies can employ omniscient individuals in these roles, > > but those types are a bit hard

Re: [PATCH v5 15/32] drm/xe: Add SVM garbage collector

2025-02-13 Thread Ghimiray, Himal Prasad
On 13-02-2025 07:40, Matthew Brost wrote: Add basic SVM garbage collector which destroy a SVM range upon a MMU UNMAP event. The garbage collector runs on worker or in GPU fault handler and is required as locks in the path of reclaim are required and cannot be taken the notifier. v2: - Flush

Re: [PATCH v5 12/32] drm/xe: Add SVM range invalidation and page fault

2025-02-13 Thread Ghimiray, Himal Prasad
On 13-02-2025 07:40, Matthew Brost wrote: Add SVM range invalidation vfunc which invalidates PTEs. A new PT layer function which accepts a SVM range is added to support this. In addition, add the basic page fault handler which allocates a SVM range which is used by SVM range invalidation vfunc

Re: [PATCH v2 00/17] mm: fixes for device-exclusive entries (hmm)

2025-02-13 Thread David Hildenbrand
On 13.02.25 12:03, Alistair Popple wrote: On Mon, Feb 10, 2025 at 08:37:42PM +0100, David Hildenbrand wrote: Against mm-hotfixes-stable for now. Discussing the PageTail() call in make_device_exclusive_range() with Willy, I recently discovered [1] that device-exclusive handling does not properly

Re: [PATCH v6 25/42] drm/mediatek: mtk_hdmi: Move CEC device parsing in new function

2025-02-13 Thread 胡俊光

[PATCH v4 8/8] drm/i915: Add drm_panic support for 4-tiling with DPT

2025-02-13 Thread Jocelyn Falempe
On Alderlake and later, it's not possible to disable tiling when DPT is enabled. So this commit implements 4-Tiling support, to still be able to draw the panic screen. Signed-off-by: Jocelyn Falempe --- .../gpu/drm/i915/display/intel_atomic_plane.c | 22 ++- 1 file changed, 21 in

Re: [PATCH v5 18/32] drm/xe: Enable CPU address mirror uAPI

2025-02-13 Thread Ghimiray, Himal Prasad
On 13-02-2025 07:40, Matthew Brost wrote: Support for CPU address mirror bindings in SRAM fully in place, enable the implementation. v3: - s/system allocator/CPU address mirror (Thomas) Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström --- drivers/gpu/drm/xe/xe_vm.c | 6 --

[PATCH v4 6/8] drm/i915/display: Flush the front buffer in panic handler

2025-02-13 Thread Jocelyn Falempe
On Lunar Lake, if the panic occurs when fbcon is active, the panic screen is only partially visible on the screen. Adding this intel_frontbuffer_flush() call solves the issue. It's probably not safe to do that in the panic handler, but that's still better than nothing. Signed-off-by: Jocelyn Falem

[PATCH v4 4/8] drm/i915/gem: Add i915_gem_object_panic_map()

2025-02-13 Thread Jocelyn Falempe
Prepare the work for drm_panic support. This is used to map the current framebuffer, so the CPU can overwrite it with the panic message. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/i915/display/intel_bo.c| 10 + drivers/gpu/drm/i915/display/intel_bo.h| 2 ++ drivers/gpu/d

[PATCH v4 1/8] drm/i915/fbdev: Add intel_fbdev_get_map()

2025-02-13 Thread Jocelyn Falempe
The vaddr of the fbdev framebuffer is private to the struct intel_fbdev, so this function is needed to access it for drm_panic. Also the struct i915_vma is different between i915 and xe, so it requires a few functions to access fbdev->vma->iomap. Signed-off-by: Jocelyn Falempe --- v2: * Add in

[PATCH v4 3/8] drm/i915/display: Add a disable_tiling() for skl planes

2025-02-13 Thread Jocelyn Falempe
drm_panic draws in linear framebuffer, so it's easier to re-use the current framebuffer, and disable tiling in the panic handler, to show the panic screen. Signed-off-by: Jocelyn Falempe --- .../drm/i915/display/skl_universal_plane.c| 20 +++ 1 file changed, 20 insertions(+)

[PATCH v4 2/8] drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes

2025-02-13 Thread Jocelyn Falempe
drm_panic draws in linear framebuffer, so it's easier to re-use the current framebuffer, and disable tiling in the panic handler, to show the panic screen. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/i915/display/i9xx_plane.c | 23 +++ .../drm/i915/display/intel_displa

[RFC PATCH v4 0/8] drm/i915: Add drm_panic support

2025-02-13 Thread Jocelyn Falempe
This is a draft of drm_panic support for i915. I've tested it on the 4 intel laptops I have at my disposal. * Haswell with 128MB of eDRAM. * Comet Lake. * Alder Lake (with DPT, and Y-tiling). * Lunar Lake (with DPT, and 4-tiling, and using the Xe driver. I tested panic in both fbdev console a

Re: [PATCH v5 21/32] drm/xe: Add SVM device memory mirroring

2025-02-13 Thread Ghimiray, Himal Prasad
On 13-02-2025 07:41, Matthew Brost wrote: Add SVM device memory mirroring which enables device pages for migration. Enabled via CONFIG_XE_DEVMEM_MIRROR Kconfig. Kconfig option defaults to enabled. If not enabled, SVM will work sans migration and KMD memory footprint will be less. v3: - Add

Re: [PATCH v5 22/32] drm/xe: Add drm_gpusvm_devmem to xe_bo

2025-02-13 Thread Ghimiray, Himal Prasad
On 13-02-2025 07:41, Matthew Brost wrote: Add drm_gpusvm_devmem to xe_bo. Required to enable SVM migrations. Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström --- drivers/gpu/drm/xe/xe_bo_types.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_bo_ty

Re: [PATCH v5 29/32] drm/xe: Add SVM debug

2025-02-13 Thread Ghimiray, Himal Prasad
On 13-02-2025 07:41, Matthew Brost wrote: Add some useful SVM debug logging fro SVM range which prints the range's state. v2: - Update logging with latest structure layout v3: - Better commit message (Thomas) - New range structure (Thomas) - s/COLLECTOT/s/COLLECTOR (Thomas) v4: - Dr

Re: [PATCH v5 30/32] drm/xe: Add modparam for SVM notifier size

2025-02-13 Thread Ghimiray, Himal Prasad
On 13-02-2025 07:41, Matthew Brost wrote: Useful to experiment with notifier size and how it affects performance. v3: - Pull missing changes including in following patch (Thomas) v5: - Spell out power of 2 (Thomas) Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström --- driver

Re: [PATCH v5 31/32] drm/xe: Add always_migrate_to_vram modparam

2025-02-13 Thread Ghimiray, Himal Prasad
On 13-02-2025 07:41, Matthew Brost wrote: Used to show we can bounce memory multiple times which will happen once a real migration policy is implemented. Can be removed once migration policy is implemented. v3: - Pull some changes into the previous patch (Thomas) - Better commit message (

Re: On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-13 Thread Danilo Krummrich
On Thu, Feb 13, 2025 at 11:49:20AM +0800, Icenowy Zheng wrote: > 在 2025-02-10星期一的 11:24 +0100,Danilo Krummrich写道: > > > > (Additionally, in this particular case even one of the reviewers of > > DMA MAPPING HELPERS offered to be a reviewer of the Rust abstractions > > too, in > > order to keep eye

Re: [RFC 5/5] drm/scheduler: Add a basic test for modifying entities scheduler list

2025-02-13 Thread Philipp Stanner
On Fri, 2025-02-07 at 14:33 +, Tvrtko Ursulin wrote: > Add a basic test for exercising modifying the entities scheduler list > at > runtime. > > Signed-off-by: Tvrtko Ursulin > Cc: Christian König > Cc: Danilo Krummrich > Cc: Matthew Brost > Cc: Philipp Stanner > --- >  .../scheduler/test

Re: [PATCH v5 2/3] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter

2025-02-13 Thread Tomi Valkeinen
Hi, On 13/02/2025 14:33, Aradhya Bhatia wrote: +  ti,companion-oldi: +    $ref: /schemas/types.yaml#/definitions/phandle +    description: +  phandle to companion OLDI transmitter. This property is mandatory for the +  primarty OLDI TX if the OLDI TXes are expected to work either in dua

Re: [PATCH v3 7/7] clk: amlogic: axg-audio: use the auxiliary reset driver - take 2

2025-02-13 Thread Jerome Brunet
On Thu 13 Feb 2025 at 13:26, "Arnd Bergmann" wrote: > On Tue, Feb 11, 2025, at 18:28, Jerome Brunet wrote: >> >> I also think this is more readeable and maintainable than a bunch of >> 'default CONFIG_FOO if CONFIG_FOO' for CONFIG_RESET_MESON_AUX. This approach >> also would have several pitfa

[PATCH v8 4/7] drm/i915/fbc: introduce HAS_FBC_DIRTY_RECT() for FBC dirty rect support

2025-02-13 Thread Vinod Govindapillai
Introduce a macro to check if the platform supports FBC dirty rect capability. v2: - update to the patch subject Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_device.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_disp

[PATCH v8 5/7] drm/i915/fbc: avoid calling fbc activate if fbc is active

2025-02-13 Thread Vinod Govindapillai
If FBC is already active, we don't need to call FBC activate routine again unless there are changes to the fences. So skip this on all platforms that don't have fences. Any FBC register updates done after enabling the dirty rect support in xe3 will trigger nuke by FBC which is counter productive to

[PATCH v8 0/7] drm/i915/fbc: FBC Dirty rect feature support

2025-02-13 Thread Vinod Govindapillai
Dirty rect support for FBC in xe3 onwards based on the comments after the initial RFC series. v2: Dirty rect related compute and storage moved to fbc state (Ville) V3: Dont call fbc activate if FBC is already active v4: Dirty rect compute and programming moved within DSB scope New changes ar

[PATCH v8 7/7] drm/i915/fbc: disable FBC if PSR2 selective fetch is enabled

2025-02-13 Thread Vinod Govindapillai
It is not recommended to have both FBC dirty rect and PSR2 selective fetch be enabled at the same time. Mark FBC as not possible, if PSR2 selective fetch is enabled. v2: fix the condition to disable FBC if PSR2 enabled (Jani) v3: use HAS_FBC_DIRTY_RECT() v4: Update to patch description Bspec: 6

drm/ast regression, when upgrading from v6.3 to v6.6

2025-02-13 Thread Jocelyn Falempe
Hi Thomas and Jammy, I've got a regression report, and it's caused by https://patchwork.freedesktop.org/patch/540015/ On this ast2600 server, the firmware says it has a DP output, but physically, there is only one VGA output. Before this commit, "ast->tx_chip_types |= BIT(AST_TX_ASTDP)" means i

Re: [RFC 5/5] drm/scheduler: Add a basic test for modifying entities scheduler list

2025-02-13 Thread Tvrtko Ursulin
On 13/02/2025 13:12, Philipp Stanner wrote: On Fri, 2025-02-07 at 14:33 +, Tvrtko Ursulin wrote: Add a basic test for exercising modifying the entities scheduler list at runtime. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stann

Re: [PATCH v2 09/15] drm/vkms: Allow to configure multiple planes

2025-02-13 Thread Louis Chauvet
On 11/02/25 - 12:09, José Expósito wrote: > Add a list of planes to vkms_config and create as many planes as > configured during output initialization. > > For backwards compatibility, add one primary plane and, if configured, > one cursor plane and NUM_OVERLAY_PLANES planes to the default > confi

Re: [PATCH v2 13/15] drm/vkms: Allow to attach encoders and CRTCs

2025-02-13 Thread Louis Chauvet
On 11/02/25 - 12:09, José Expósito wrote: > Add a list of possible CRTCs to the encoder configuration and helpers to > attach and detach them. > > Now that the default configuration has its encoder and CRTC correctly > attached, configure the output following the configuration. > > Co-developed-b

Re: [PATCH v2 15/15] drm/vkms: Allow to attach connectors and encoders

2025-02-13 Thread Louis Chauvet
On 11/02/25 - 12:09, José Expósito wrote: > Add a list of possible encoders to the connector configuration and > helpers to attach and detach them. > > Now that the default configuration has its connector and encoder > correctly, configure the output following the configuration. > > Co-developed-

Re: [PATCH v2 12/15] drm/vkms: Allow to configure multiple encoders

2025-02-13 Thread Louis Chauvet
On 11/02/25 - 12:09, José Expósito wrote: > Add a list of encoders to vkms_config and helper functions to add and > remove as many encoders as wanted. > > For backwards compatibility, add one encoder to the default > configuration. > > A future patch will allow to attach encoders and CRTCs, but f

Re: [PATCH v2 05/15] drm/vkms: Extract vkms_config header

2025-02-13 Thread Louis Chauvet
On 11/02/25 - 12:09, José Expósito wrote: > Creating a new vkms_config structure will be more complex once we > start adding more options. > > Extract the vkms_config structure to its own header and source files > and add functions to create and delete a vkms_config and to initialize > debugfs. >

Re: [PATCH v2 06/15] drm/vkms: Move default_config creation to its own function

2025-02-13 Thread Louis Chauvet
On 11/02/25 - 12:09, José Expósito wrote: > Extract the initialization of the default configuration to a function. > Refactor, no functional changes. > > Reviewed-by: Louis Chauvet > Co-developed-by: Louis Chauvet > Signed-off-by: Louis Chauvet > Signed-off-by: José Expósito I just tested to

Re: [PATCH v2 14/15] drm/vkms: Allow to configure multiple connectors

2025-02-13 Thread Louis Chauvet
On 11/02/25 - 12:09, José Expósito wrote: > Add a list of connectors to vkms_config and helper functions to add and > remove as many connectors as wanted. > > For backwards compatibility, add one enabled connector to the default > configuration. > > A future patch will allow to attach connectors

Re: [PATCH v2 10/15] drm/vkms: Allow to configure multiple CRTCs

2025-02-13 Thread Louis Chauvet
On 11/02/25 - 12:09, José Expósito wrote: > Add a list of CRTCs to vkms_config and helper functions to add and > remove as many CRTCs as wanted. > > For backwards compatibility, add one CRTC to the default configuration. > > A future patch will allow to attach planes and CRTCs, but for the > mome

Re: [PATCH v2 04/15] drm/vkms: Add KUnit test scaffolding

2025-02-13 Thread Louis Chauvet
On 11/02/25 - 12:09, José Expósito wrote: > Add the required boilerplate to start creating KUnit test. > > To run the tests: > > $ ./tools/testing/kunit/kunit.py run \ > --kunitconfig=drivers/gpu/drm/vkms/tests > > Co-developed-by: Arthur Grillo > Signed-off-by: Arthur Grillo > Co-de

Re: [PATCH v2 08/15] drm/vkms: Add a validation function for VKMS configuration

2025-02-13 Thread Louis Chauvet
On 11/02/25 - 12:09, José Expósito wrote: > From: Louis Chauvet > > As the configuration will be used by userspace, add a validator to avoid > creating a broken DRM device. > > For the moment, the function always returns true, but rules will be > added in future patches. > > Reviewed-by: Louis

Re: drm/ast regression, when upgrading from v6.3 to v6.6

2025-02-13 Thread Thomas Zimmermann
Hi Am 13.02.25 um 14:33 schrieb Jocelyn Falempe: Hi Thomas and Jammy, I've got a regression report, and it's caused by https://patchwork.freedesktop.org/patch/540015/ On this ast2600 server, the firmware says it has a DP output, but physically, there is only one VGA output. Before this commit

[PATCH v8 6/7] drm/i915/fbc: dirty rect support for FBC

2025-02-13 Thread Vinod Govindapillai
Dirty rectangle feature allows FBC to recompress a subsection of a frame. When this feature is enabled, display will read the scan lines between dirty rectangle start line and dirty rectangle end line in subsequent frames. Use the merged damage clip stored in the plane state to configure the FBC d

[PATCH v8 1/7] drm/damage-helper: add const qualifier in drm_atomic_helper_damage_merged()

2025-02-13 Thread Vinod Govindapillai
Add a const qualifier for the "state" parameter as well as we could use this helper to get the combined damage in cases of const drm_plane_state as well. Needed mainly for xe driver big joiner cases where we need to track the damage from immutable plane state. Signed-off-by: Vinod Govindapillai -

[PATCH v8 2/7] drm/i915/display: update and store the plane damage clips

2025-02-13 Thread Vinod Govindapillai
Userspace can pass damage area clips per plane to track changes in a plane and some display components can utilze these damage clips for efficiently handling use cases like FBC, PSR etc. A merged damage area is generated and its coordinates are updated relative to viewport and HW and stored in the

[PATCH v8 3/7] drm/i915/fbc: add register definitions for fbc dirty rect support

2025-02-13 Thread Vinod Govindapillai
Register definitions for FBC dirty rect support v2: - update to the patch subject Bspec: 71675, 73424 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc_regs.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_fbc_regs.h

[PATCH v1 2/2] drm: bridge: Add support for Solomon SSD2825 RGB/DSI bridge

2025-02-13 Thread Svyatoslav Ryhel
SSD2825 is an innovative and cost-effective MIPI Bridge Chip solution targeting high resolution smartphones. It can convert 24bit RGB interface into 4-lane MIPI-DSI interface to drive extremely high resolution display modules of up to 800 x 1366, while supporting AMOLED, a-si LCD or LTPS advanced p

[PATCH v1 0/2] drm: bridge: add ssd2825 RGB/DSI bridge support

2025-02-13 Thread Svyatoslav Ryhel
Solomon SSD2825 is a RGB to MIPI DSI bridge used in LG Optimus 4D P880 and LG Optimus Vu P895 Svyatoslav Ryhel (2): dt-bindings: display: bridge: Document Solomon SSD2825 drm: bridge: Add support for Solomon SSD2825 RGB/DSI bridge .../display/bridge/solomon,ssd2825.yaml | 140 dri

[PATCH v1 1/2] dt-bindings: display: bridge: Document Solomon SSD2825

2025-02-13 Thread Svyatoslav Ryhel
Add bindings for Solomon SSD2825 MIPI master bridge chip that connects an application processor with traditional parallel LCD interface and an LCD driver with MIPI slave interface. The SSD2825 supports both parallel RGB interface and serial SPI interface. Signed-off-by: Svyatoslav Ryhel --- .../

Re: [PATCH 0/6] accel/ivpu: Changes for 6.15 2025-02-04

2025-02-13 Thread Thomas Zimmermann
Hi Am 12.02.25 um 16:52 schrieb Jeffrey Hugo: On 2/12/2025 6:27 AM, Jacek Lawrynowicz wrote: Hi, Thanks for your detailed feedback and constructive suggestions. I appreciate this as it is not easy to learn all process details otherwise. I echo this.  At times, accel feels a bit isolated fr

Re: [RFC 2/5] drm/scheduler: Add scheduler unit testing infrastructure and some basic tests

2025-02-13 Thread Tvrtko Ursulin
On 13/02/2025 13:05, Philipp Stanner wrote: I'm in principle OK with this series. We'll have to discuss a few more things, but from my POV you could send the next revision as a v1. Some more input below.. On Fri, 2025-02-07 at 14:33 +, Tvrtko Ursulin wrote: Implement a mock scheduler bac

  1   2   3   4   >