Re: [PATCH v5 18/32] drm/xe: Enable CPU address mirror uAPI

[Ghimiray, Himal Prasad]

On 13-02-2025 07:40, Matthew Brost wrote:

Support for CPU address mirror bindings in SRAM fully in place, enable the
implementation.

v3:
  - s/system allocator/CPU address mirror (Thomas)

Signed-off-by: Matthew Brost <matthew.br...@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellst...@linux.intel.com>
---
  drivers/gpu/drm/xe/xe_vm.c | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 06b013d1f533..6c9c3f9e307d 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -3040,12 +3040,6 @@ static int vm_bind_ioctl_check_args(struct xe_device 
*xe, struct xe_vm *vm,
                u16 pat_index = (*bind_ops)[i].pat_index;
                u16 coh_mode;

- /* FIXME: Disabling CPU address mirror for now */

-               if (XE_IOCTL_DBG(xe, is_cpu_addr_mirror)) {
-                       err = -EOPNOTSUPP;
-                       goto free_bind_ops;
-               }

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimi...@intel.com>

-
                if (XE_IOCTL_DBG(xe, is_cpu_addr_mirror &&
                                 !xe_vm_in_fault_mode(vm))) {
                        err = -EINVAL;