Re: linux-next: manual merge of the drm-intel tree with the mm tree

2025-01-23 Thread Jani Nikula
On Thu, 23 Jan 2025, Stephen Rothwell wrote: > Hi all, > > On Wed, 8 Jan 2025 12:16:50 +1100 Stephen Rothwell > wrote: >> >> On Mon, 6 Jan 2025 13:03:48 +1100 Stephen Rothwell >> wrote: >> > >> > Today's linux-next merge of the drm-intel tree got a conflict in: >> > >> > drivers/gpu/drm/i91

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Boris Brezillon
On Thu, 23 Jan 2025 08:33:01 +0100 Philipp Stanner wrote: > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > > On Wed, 22 Jan 2025 15:08:20 +0100 > > Philipp Stanner wrote: > > > > >  int drm_sched_init(struct drm_gpu_scheduler *sched, > > > -    const struct drm_sched_backend_ops

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Thu, 2025-01-23 at 09:10 +0100, Philipp Stanner wrote: > On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: > > Hi Philipp, > > > > On 22/01/25 11:08, Philipp Stanner wrote: > > > drm_sched_init() has a great many parameters and upcoming new > > > functionality for the scheduler might add ev

Re: [PATCH] drm/v3d: Assign job pointer to NULL before signaling the fence

2025-01-23 Thread Phil Elwell
Thanks for this, Maíra. Tested-by: Phil Elwell On Thu, 23 Jan 2025 at 07:12, Iago Toral wrote: > > Looks good to me: > > Reviewed-by: Iago Toral Quiroga > > El mié, 22-01-2025 a las 22:24 -0300, Maíra Canal escribió: > > In commit e4b5ccd392b9 ("drm/v3d: Ensure job pointer is set to NULL > > a

Re: [PATCH RFC 0/7] drm/display: dp: add new DPCD access functions

2025-01-23 Thread Jani Nikula
On Thu, 23 Jan 2025, Dmitry Baryshkov wrote: > On Fri, Jan 17, 2025 at 10:56:35AM +0200, Dmitry Baryshkov wrote: >> Existing DPCD access functions return an error code or the number of >> bytes being read / write in case of partial access. However a lot of >> drivers either (incorrectly) ignore pa

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Tvrtko Ursulin
On 23/01/2025 09:35, Philipp Stanner wrote: On Thu, 2025-01-23 at 10:29 +0100, Danilo Krummrich wrote: On Thu, Jan 23, 2025 at 08:33:01AM +0100, Philipp Stanner wrote: On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: On Wed, 22 Jan 2025 15:08:20 +0100 Philipp Stanner wrote:  int

dri-devel@lists.freedesktop.org

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 06:07:39PM +0800, Damon Ding wrote: > Add two new functions: one to find &analogix_dp_device.plat_data via > &drm_dp_aux, and the other to get &analogix_dp_device.aux. Both of them > serve for the function of getting panel from DP AUX bus, which is why > they are included in

[PATCH] drm/panel-edp: Add STA 116QHD024002

2025-01-23 Thread Langyan Ye
Add support for the STA 116QHD024002, pleace the EDID here for subsequent reference. 00 ff ff ff ff ff ff 00 4e 81 09 00 00 00 00 00 26 21 01 04 a5 1a 0e 78 02 1e b5 9a 5f 57 94 26 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 8e 1c 56 a0 50 00 1e 30 28 20 55 00 00 90 10 00 00

Re: [PATCH v6 09/14] dt-bindings: display: rockchip: analogix-dp: Add support for RK3588

2025-01-23 Thread Rob Herring (Arm)
On Thu, 23 Jan 2025 18:07:42 +0800, Damon Ding wrote: > Compared with RK3288/RK3399, the HBR2 link rate support is the main > improvement of RK3588 eDP TX controller, and there are also two > independent eDP display interfaces on RK3588 Soc. > > The newly added 'apb' reset is to ensure the APB b

Re: [PATCH v6 07/14] drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 06:07:40PM +0800, Damon Ding wrote: > The main modification is moving the DP AUX initialization from function > analogix_dp_bind() to analogix_dp_probe(). In order to get the EDID of > eDP panel during probing, it is also needed to advance PM operaions to > ensure that eDP c

Re: [PATCH v6 08/14] drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 06:07:41PM +0800, Damon Ding wrote: > Move drm_of_find_panel_or_bridge() a little later and combine it with > component_add() into a new function rockchip_dp_link_panel(). The function > will serve as done_probing() callback of devm_of_dp_aux_populate_bus(), > aiding to supp

Re: [PATCH v6 12/14] drm/edp-panel: Add LG Display panel model LP079QX1-SP0V

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 06:07:45PM +0800, Damon Ding wrote: > The raw edid for LP079QX1-SP0V panel model is: > > 00 ff ff ff ff ff ff 00 16 83 00 00 00 00 00 00 > 04 17 01 00 a5 10 0c 78 06 ef 05 a3 54 4c 99 26 > 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > 01 01 01 01 01 01 ea 4e 00 4c 60 00

Re: [PATCH v6 14/14] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 06:07:47PM +0800, Damon Ding wrote: > Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: > - Set pinctrl of pwm12 for backlight > - Enable edp0/hdptxphy0/vp2 > - Assign the parent of DCLK_VOP2_SRC to PLL_V0PLL > - Add aux-bus/panel nodes > > For RK3588, the

Re: [PATCH RFC 08/11] drm/msm/dsi: Add support for SM8750

2025-01-23 Thread Krzysztof Kozlowski
On 13/01/2025 13:13, Dmitry Baryshkov wrote: > On Mon, Jan 13, 2025 at 12:02:54PM +0100, Krzysztof Kozlowski wrote: >> On 13/01/2025 09:29, Dmitry Baryshkov wrote: >>> On Fri, Jan 10, 2025 at 01:43:28PM +0100, Krzysztof Kozlowski wrote: On 10/01/2025 10:17, Dmitry Baryshkov wrote: > On Fri

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Danilo Krummrich
On Thu, Jan 23, 2025 at 08:33:01AM +0100, Philipp Stanner wrote: > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > > On Wed, 22 Jan 2025 15:08:20 +0100 > > Philipp Stanner wrote: > > > > >  int drm_sched_init(struct drm_gpu_scheduler *sched, > > > -    const struct drm_sched_backend_o

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Danilo Krummrich
On Thu, Jan 23, 2025 at 10:35:43AM +0100, Philipp Stanner wrote: > On Thu, 2025-01-23 at 10:29 +0100, Danilo Krummrich wrote: > > On Thu, Jan 23, 2025 at 08:33:01AM +0100, Philipp Stanner wrote: > > > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > > > > On Wed, 22 Jan 2025 15:08:20 +01

Re: [PATCH v2] drm/msm/dpu: Fall back to a single DSC encoder (1:1:1) on small SoCs

2025-01-23 Thread Luca Weiss
On Wed Jan 22, 2025 at 5:23 PM CET, Marijn Suijten wrote: > Some SoCs such as SC7280 (used in the Fairphone 5) have only a single > DSC "hard slice" encoder. The current hardcoded use of 2:2:1 topology > (2 LM and 2 DSC for a single interface) make it impossible to use > Display Stream Compression

Re: [PATCH 00/11] Subject: [PATCH 00/11] Add DRM support for Amlogic S4

2025-01-23 Thread Ao Xu
On 2025/1/15 1:50, Jerome Brunet wrote: [ EXTERNAL EMAIL ] On Sun 12 Jan 2025 at 23:44, Martin Blumenstingl wrote: Hello, On Fri, Jan 10, 2025 at 6:39 AM Ao Xu via B4 Relay wrote: This patch series adds DRM support for the Amlogic S4-series SoCs. Compared to the Amlogic G12-series, the S4

Re: [PATCH 0/4] Handheld gaming PC panel orientation quirks

2025-01-23 Thread John Edwards
Hello. My sincerest apologies. I used get_maintainer to populate the recipients for this patch series, but I must have made an error somewhere. John Edwards On Wed, Jan 22, 2025 at 1:55 AM Thomas Zimmermann wrote: > > (cc'ing Hans) > > Hi Hans, > > I think this is for you. > > Best regards >

Re: [PATCH v2] drm/bridge: adv7511: Switch to atomic operations

2025-01-23 Thread Jesse Van Gavere
Hello, This patch seems to have been archived but I can't seem to find it in the drm-misc git, is there anything else I should be doing to get this patch approved and included? Best regards, Jesse

Re: [PATCH RFC 2/7] drm/display: dp: implement new access helpers

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 12:26:25PM +0200, Jani Nikula wrote: > On Fri, 17 Jan 2025, Dmitry Baryshkov wrote: > > Existing DPCD access functions return an error code or the number of > > bytes being read / write in case of partial access. However a lot of > > drivers either (incorrectly) ignore part

Re: [PATCH RFC 4/7] drm/display: dp-aux-dev: use new DCPD access helpers

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 12:05:29PM +0200, Jani Nikula wrote: > On Fri, 17 Jan 2025, Dmitry Baryshkov wrote: > > Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. > > This might be one of the few places where the old functions and the old > return value was used in a sensible ma

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Maíra Canal
Hi Philipp, On 23/01/25 05:10, Philipp Stanner wrote: On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: Hi Philipp, On 22/01/25 11:08, Philipp Stanner wrote: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the g

Re: [PATCH] drm/v3d: Assign job pointer to NULL before signaling the fence

2025-01-23 Thread Chema Casanova
Reviewed-by: Jose Maria Casanova Crespo El 23/1/25 a las 2:24, Maíra Canal escribió: In commit e4b5ccd392b9 ("drm/v3d: Ensure job pointer is set to NULL after job completion"), we introduced a change to assign the job pointer to NULL after completing a job, indicating job completion. However,

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: > > > > On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > > On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: > >> > >> > >> On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: > >>> On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh

Re: [PATCH RFC 08/11] drm/msm/dsi: Add support for SM8750

2025-01-23 Thread Krzysztof Kozlowski
On 23/01/2025 12:42, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 12:34:28PM +0100, Krzysztof Kozlowski wrote: >> On 13/01/2025 13:13, Dmitry Baryshkov wrote: >>> On Mon, Jan 13, 2025 at 12:02:54PM +0100, Krzysztof Kozlowski wrote: On 13/01/2025 09:29, Dmitry Baryshkov wrote: > On Fri

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Ekansh Gupta
On 1/23/2025 4:43 PM, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: >> >> >> On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: >>> On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: > On

Re: [PATCH 0/6] drm: enforce rules for drm_atomic_helper_check_modeset()

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 09, 2025 at 02:53:16PM +0100, Thomas Zimmermann wrote: > Hi > > > Am 22.12.24 um 06:00 schrieb Dmitry Baryshkov: > > As pointed out by Simona, the drm_atomic_helper_check_modeset() and > > drm_atomic_helper_check() require the former function is rerun if the > > driver's callbacks mod

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Thu, 2025-01-23 at 08:10 -0300, Maíra Canal wrote: > Hi Philipp, > > On 23/01/25 05:10, Philipp Stanner wrote: > > On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: > > > Hi Philipp, > > > > > > On 22/01/25 11:08, Philipp Stanner wrote: > > > > drm_sched_init() has a great many parameters

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Thu, 2025-01-23 at 10:29 +0100, Danilo Krummrich wrote: > On Thu, Jan 23, 2025 at 08:33:01AM +0100, Philipp Stanner wrote: > > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > > > On Wed, 22 Jan 2025 15:08:20 +0100 > > > Philipp Stanner wrote: > > > > > > >  int drm_sched_init(struc

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Ekansh Gupta
On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: >> >> >> On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: >>> On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh Gupta wrote: InvokeV2 request is intended to support multiple enhanced inv

Re: [PATCH 3/3] drm/i915/lttpr: Enable Extended Wake Timeout

2025-01-23 Thread Jani Nikula
On Wed, 22 Jan 2025, Suraj Kandpal wrote: > Usually retimers take around 30 to 40ms to exit all devices from > sleep state. Extended wake timeout mechanism helps to give > that additional time. > > --v2 > -Grant the requested time only if greater than 1ms [Arun/Jani] > -Reframe commit message [Aru

Re: [PATCH RFC 4/7] drm/display: dp-aux-dev: use new DCPD access helpers

2025-01-23 Thread Jani Nikula
On Fri, 17 Jan 2025, Dmitry Baryshkov wrote: > Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. This might be one of the few places where the old functions and the old return value was used in a sensible manner. BR, Jani. > > Signed-off-by: Dmitry Baryshkov > --- > drivers

[PATCH v6 01/14] drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...()

2025-01-23 Thread Damon Ding
According to the comments in include/drm/drm_print.h, the DRM_...() functions are deprecated in favor of drm_...() or dev_...() functions. Use drm_err()/drm_dbg_core()/drm_dbg_kms() instead of DRM_DEV_ERROR()/DRM_ERROR()/DRM_DEV_DEBUG()/DRM_DEBUG_KMS(). Signed-off-by: Damon Ding --- Changes in

[PATCH v6 03/14] drm/rockchip: analogix_dp: Expand device data to support multiple edp display

2025-01-23 Thread Damon Ding
There are two main modifications: one is expanding struct rockchip_dp_chip_data to an array, and the other is adding &rockchip_dp_chip_data.reg to separate different edp devices. Signed-off-by: Damon Ding --- Changes in v6: - Add the description of &rockchip_dp_chip_data.reg - Use drm_...() uni

[PATCH v6 04/14] drm/bridge: analogix_dp: Add support for phy configuration.

2025-01-23 Thread Damon Ding
Add support to configurate link rate, lane count, voltage swing and pre-emphasis with phy_configure(). It is helpful in application scenarios where analogix controller is mixed with the phy of other vendors. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov --- Changes in v2: - remove ne

[PATCH v6 07/14] drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus

2025-01-23 Thread Damon Ding
The main modification is moving the DP AUX initialization from function analogix_dp_bind() to analogix_dp_probe(). In order to get the EDID of eDP panel during probing, it is also needed to advance PM operaions to ensure that eDP controller and phy are prepared for AUX transmission. In addtion, ad

[PATCH v6 05/14] dt-bindings: display: rockchip: analogix-dp: Add support to get panel from the DP AUX bus

2025-01-23 Thread Damon Ding
According to Documentation/devicetree/bindings/display/dp-aux-bus.yaml, it is a good way to get panel through the DP AUX bus. Acked-by: Krzysztof Kozlowski Signed-off-by: Damon Ding --- Changes in v4: - Move the dt-bindings commit before related driver commits Changes in v5: - Remove the unex

[PATCH v6 11/14] drm/rockchip: analogix_dp: Add support for RK3588

2025-01-23 Thread Damon Ding
RK3588 integrates the Analogix eDP 1.3 TX controller IP and the HDMI/eDP TX Combo PHY based on a Samsung IP block. There are also two independent eDP display interface with different address on RK3588 Soc. The patch currently adds only the basic support, specifically RGB output up to 4K@60Hz, with

[PATCH v6 14/14] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board

2025-01-23 Thread Damon Ding
Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: - Set pinctrl of pwm12 for backlight - Enable edp0/hdptxphy0/vp2 - Assign the parent of DCLK_VOP2_SRC to PLL_V0PLL - Add aux-bus/panel nodes For RK3588, the PLL_V0PLL is specifically designed for the VOP2. This means the clock rate

[PATCH v6 10/14] drm/bridge: analogix_dp: Add support for RK3588

2025-01-23 Thread Damon Ding
Expand enum analogix_dp_devtype with RK3588_EDP, and add max_link_rate and max_lane_count configs for it. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov --- Changes in v5: - Add the RK3588_EDP related modification in analogix_dp.h - Move this commit above related commit on the Rockchi

[PATCH v6 00/14] Add eDP support for RK3588

2025-01-23 Thread Damon Ding
Picked from: https://patchwork.kernel.org/project/linux-rockchip/list/?series=923593 These patchs have been tested with a 1536x2048p60 eDP panel on RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified on RK3588 EVB1 board. Furthermore, the eDP display has been rechecked on RK3399 s

[PATCH v6 08/14] drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus

2025-01-23 Thread Damon Ding
Move drm_of_find_panel_or_bridge() a little later and combine it with component_add() into a new function rockchip_dp_link_panel(). The function will serve as done_probing() callback of devm_of_dp_aux_populate_bus(), aiding to support for obtaining the eDP panel via the DP AUX bus. If failed to ge

[PATCH v6 12/14] drm/edp-panel: Add LG Display panel model LP079QX1-SP0V

2025-01-23 Thread Damon Ding
The raw edid for LP079QX1-SP0V panel model is: 00 ff ff ff ff ff ff 00 16 83 00 00 00 00 00 00 04 17 01 00 a5 10 0c 78 06 ef 05 a3 54 4c 99 26 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 ea 4e 00 4c 60 00 14 80 0c 10 84 00 78 a0 00 00 00 18 00 00 00 10 00 00 00 00 00 00 00 00

[PATCH v6 13/14] arm64: dts: rockchip: Add eDP0 node for RK3588

2025-01-23 Thread Damon Ding
Add support for the eDP0 output on RK3588 SoC. Signed-off-by: Damon Ding --- Changes in v3: - Remove currently unsupported property '#sound-dai-cells' Changes in v4: - Remove currently unsupported clock 'spdif' --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 28 +++ 1 file

[PATCH v6 09/14] dt-bindings: display: rockchip: analogix-dp: Add support for RK3588

2025-01-23 Thread Damon Ding
Compared with RK3288/RK3399, the HBR2 link rate support is the main improvement of RK3588 eDP TX controller, and there are also two independent eDP display interfaces on RK3588 Soc. The newly added 'apb' reset is to ensure the APB bus of eDP controller works well on the RK3588 SoC. Signed-off-by:

[PATCH v6 02/14] drm/rockchip: analogix_dp: Use formalized struct definition for grf field

2025-01-23 Thread Damon Ding
The formalized struct definition will makes grf field operations more concise and easier to extend. Signed-off-by: Damon Ding --- Changes in v2: - Initialize struct rockchip_dp_chip_data rk3399_edp/rk3288_dp in order of its members Changes in v6: - Pass 'dp' in drm_...() rather than 'dp->drm

dri-devel@lists.freedesktop.org

2025-01-23 Thread Damon Ding
Add two new functions: one to find &analogix_dp_device.plat_data via &drm_dp_aux, and the other to get &analogix_dp_device.aux. Both of them serve for the function of getting panel from DP AUX bus, which is why they are included in a single commit. Signed-off-by: Damon Ding Reviewed-by: Dmitry Ba

[Question] Are "device exclusive non-swap entries" / "SVM atomics in Nouveau" still getting used in practice?

2025-01-23 Thread David Hildenbrand
Hi, I keep finding issues in our implementation of "device exclusive non-swap entries", and the way it messes with mapcounts is disgusting. As a reminder, what we do here is to replace a PTE pointing to an anonymous page by a "device exclusive non-swap entry". As long as the original PTE is

Re: [PATCH RFC 2/7] drm/display: dp: implement new access helpers

2025-01-23 Thread Jani Nikula
On Fri, 17 Jan 2025, Dmitry Baryshkov wrote: > Existing DPCD access functions return an error code or the number of > bytes being read / write in case of partial access. However a lot of > drivers either (incorrectly) ignore partial access or mishandle error > codes. In other cases this results in

Re: [PATCH RFC 08/11] drm/msm/dsi: Add support for SM8750

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 12:34:28PM +0100, Krzysztof Kozlowski wrote: > On 13/01/2025 13:13, Dmitry Baryshkov wrote: > > On Mon, Jan 13, 2025 at 12:02:54PM +0100, Krzysztof Kozlowski wrote: > >> On 13/01/2025 09:29, Dmitry Baryshkov wrote: > >>> On Fri, Jan 10, 2025 at 01:43:28PM +0100, Krzysztof Ko

Re: [PATCH v6 11/14] drm/rockchip: analogix_dp: Add support for RK3588

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 06:07:44PM +0800, Damon Ding wrote: > RK3588 integrates the Analogix eDP 1.3 TX controller IP and the HDMI/eDP > TX Combo PHY based on a Samsung IP block. There are also two independent > eDP display interface with different address on RK3588 Soc. > > The patch currently ad

Re: [PATCH v2] drm/bridge: adv7511: Switch to atomic operations

2025-01-23 Thread Dmitry Baryshkov
On Mon, 06 Jan 2025 13:10:54 +0100, Jesse Van Gavere wrote: > Use the atomic version of enable/disable. > > To support bridges where bus format negotiation is needed such as TIDSS we > need to implement atomic_get_input_bus_fmts, prepare the driver for this by > switching the existing operations t

Re: [PATCH v6 01/14] drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...()

2025-01-23 Thread Jani Nikula
On Thu, 23 Jan 2025, Damon Ding wrote: > According to the comments in include/drm/drm_print.h, the DRM_...() > functions are deprecated in favor of drm_...() or dev_...() functions. > > Use drm_err()/drm_dbg_core()/drm_dbg_kms() instead of > DRM_DEV_ERROR()/DRM_ERROR()/DRM_DEV_DEBUG()/DRM_DEBUG_KM

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 05:34:00PM +0530, Ekansh Gupta wrote: > > > > On 1/23/2025 4:43 PM, Dmitry Baryshkov wrote: > > On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: > >> > >> > >> On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > >>> On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekans

Re: (subset) [PATCH 0/6] drm: enforce rules for drm_atomic_helper_check_modeset()

2025-01-23 Thread Dmitry Baryshkov
On Sun, 22 Dec 2024 07:00:40 +0200, Dmitry Baryshkov wrote: > As pointed out by Simona, the drm_atomic_helper_check_modeset() and > drm_atomic_helper_check() require the former function is rerun if the > driver's callbacks modify crtc_state->mode_changed. MSM is one of the > drivers which failed to

Re: [PATCH v5 05/20] drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...() or dev_...()

2025-01-23 Thread Jani Nikula
On Wed, 22 Jan 2025, Damon Ding wrote: > Hi Andy, > > On 2025/1/9 14:28, Andy Yan wrote: >> >> Hi Damon, >> >> At 2025-01-09 11:27:10, "Damon Ding" wrote: >>> According to the comments in include/drm/drm_print.h, the DRM_...() >>> functions are deprecated in favor of drm_...() or dev_...() func

Re: [PATCH] drm/print: Include drm_device.h

2025-01-23 Thread Simona Vetter
On Wed, Jan 22, 2025 at 04:49:21PM +0200, Jani Nikula wrote: > On Wed, 22 Jan 2025, Gustavo Sousa wrote: > > Quoting Jani Nikula (2025-01-22 11:02:31-03:00) > >>On Wed, 22 Jan 2025, Gustavo Sousa wrote: > >>> Quoting Simona Vetter (2025-01-22 08:11:53-03:00) > On Tue, Jan 21, 2025 at 06:09:25

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Maíra Canal
Hi Philipp, On 23/01/25 09:13, Philipp Stanner wrote: On Thu, 2025-01-23 at 08:10 -0300, Maíra Canal wrote: Hi Philipp, On 23/01/25 05:10, Philipp Stanner wrote: On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: Hi Philipp, On 22/01/25 11:08, Philipp Stanner wrote: drm_sched_init() has

[PATCH v2 4/4] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2025-01-23 Thread Dmitry Baryshkov
The MSM driver uses drm_atomic_helper_check() which mandates that none of the atomic_check() callbacks toggles crtc_state->mode_changed. Perform corresponding check before calling the drm_atomic_helper_check() function. Fixes: 8b45a26f2ba9 ("drm/msm/dpu: reserve cdm blocks for writeback in case of

[PATCH v2 2/4] drm/msm/dpu: move needs_cdm setting to dpu_encoder_get_topology()

2025-01-23 Thread Dmitry Baryshkov
As a preparation for calling dpu_encoder_get_topology() from different places, move the code setting topology->needs_cdm to that function (instead of patching topology separately). Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 41 ++

[PATCH v2 3/4] drm/msm/dpu: simplify dpu_encoder_get_topology() interface

2025-01-23 Thread Dmitry Baryshkov
As a preparation for calling dpu_encoder_get_topology() from different code paths, simplify its calling interface, obtaining some data pointers internally instead passing them via arguments. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder

[PATCH v2 0/4] drm/msm/dpu: follow rules for drm_atomic_helper_check_modeset()

2025-01-23 Thread Dmitry Baryshkov
As pointed out by Simona, the drm_atomic_helper_check_modeset() and drm_atomic_helper_check() require the former function is rerun if the driver's callbacks modify crtc_state->mode_changed. MSM is one of the drivers which failed to follow this requirement. Rework the MSM / DPU driver to follow the

Re: [RFC PATCH 08/12] vfio/pci: Create host unaccessible dma-buf for private device

2025-01-23 Thread Jason Gunthorpe
On Thu, Jan 23, 2025 at 03:41:58PM +0800, Xu Yilun wrote: > I don't have a complete idea yet. But the goal is not to make any > existing driver seamlessly work with secure device. It is to provide a > generic way for bind/attestation/accept, and may save driver's effort > if they don't care about

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: > Hi Philipp, > > On 22/01/25 11:08, Philipp Stanner wrote: > > drm_sched_init() has a great many parameters and upcoming new > > functionality for the scheduler might add even more. Generally, the > > great number of parameters reduces readabi

Re:Re: [PATCH v12 12/13] dt-bindings: display: vop2: Add rk3576 support

2025-01-23 Thread Andy Yan
Hi Krzysztof, At 2025-01-22 17:55:34, "Krzysztof Kozlowski" wrote: >On 22/01/2025 10:46, Andy Yan wrote: - The VOP interrupt is shared by several interrupt sources, such as - frame start (VSYNC), line flag and other status interrupts. + For VOP version under rk3576,

Re: [PATCH 4/5] drm/print: Include drm_device.h

2025-01-23 Thread Jani Nikula
On Thu, 23 Jan 2025, Jani Nikula wrote: > From: Gustavo Sousa > > The header drm_print.h uses members of struct drm_device pointers, as > such, it should include drm_device.h to let the compiler know the full > type definition. > > Without such include, users of drm_print.h that don't explicitly

Re: [PATCH 4/5] drm/print: Include drm_device.h

2025-01-23 Thread Gustavo Sousa
Quoting Jani Nikula (2025-01-23 12:14:31-03:00) >On Thu, 23 Jan 2025, Jani Nikula wrote: >> From: Gustavo Sousa >> >> The header drm_print.h uses members of struct drm_device pointers, as >> such, it should include drm_device.h to let the compiler know the full >> type definition. >> >> Without s

[PATCH 5/5] drm/print: require struct drm_device for drm_err() and friends

2025-01-23 Thread Jani Nikula
The expectation is that the struct drm_device based logging helpers get passed an actual struct drm_device pointer rather than some random struct pointer where you can dereference the ->dev member. Add a static inline helper to convert struct drm_device to struct device, with the main benefit bein

[PATCH 2/5] drm/rockchip: stop passing non struct drm_device to drm_err() and friends

2025-01-23 Thread Jani Nikula
The expectation is that the struct drm_device based logging helpers get passed an actual struct drm_device pointer rather than some random struct pointer where you can dereference the ->dev member. Convert drm_err(hdmi, ...) to dev_err(hdmi->dev, ...). This matches current usage, but drops "[drm]

[PATCH 3/5] drm/sched: stop passing non struct drm_device to drm_err() and friends

2025-01-23 Thread Jani Nikula
The expectation is that the struct drm_device based logging helpers get passed an actual struct drm_device pointer rather than some random struct pointer where you can dereference the ->dev member. Convert drm_err(sched, ...) to dev_err(sched->dev, ...) and similar. This matches current usage, as

[PATCH 4/5] drm/print: Include drm_device.h

2025-01-23 Thread Jani Nikula
From: Gustavo Sousa The header drm_print.h uses members of struct drm_device pointers, as such, it should include drm_device.h to let the compiler know the full type definition. Without such include, users of drm_print.h that don't explicitly need drm_device.h would bump into build errors and be

[PATCH 0/5] drm: strict type checking for drm_device based logging helpers

2025-01-23 Thread Jani Nikula
Fix all cases that pass something other than struct drm_device to the drm_device based logging helpers, and add strict type checking. Gustavo Sousa (1): drm/print: Include drm_device.h Jani Nikula (4): drm/mipi-dsi: stop passing non struct drm_device to drm_err() and friends drm/rockchi

[PATCH 1/5] drm/mipi-dsi: stop passing non struct drm_device to drm_err() and friends

2025-01-23 Thread Jani Nikula
The expectation is that the struct drm_device based logging helpers get passed an actual struct drm_device pointer rather than some random struct pointer where you can dereference the ->dev member. Convert drm_err(host, ...) to dev_err(host->dev, ...). This matches current usage, as struct drm_dev

Re: [Question] Are "device exclusive non-swap entries" / "SVM atomics in Nouveau" still getting used in practice?

2025-01-23 Thread Simona Vetter
On Thu, Jan 23, 2025 at 11:20:37AM +0100, David Hildenbrand wrote: > Hi, > > I keep finding issues in our implementation of "device exclusive non-swap > entries", and the way it messes with mapcounts is disgusting. > > As a reminder, what we do here is to replace a PTE pointing to an anonymous >

Re: [PATCH] drm/v3d: Assign job pointer to NULL before signaling the fence

2025-01-23 Thread Maíra Canal
On 22/01/25 22:24, Maíra Canal wrote: In commit e4b5ccd392b9 ("drm/v3d: Ensure job pointer is set to NULL after job completion"), we introduced a change to assign the job pointer to NULL after completing a job, indicating job completion. However, this approach created a race condition between th

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-23 Thread Jason Gunthorpe
On Thu, Jan 23, 2025 at 03:35:21PM +0100, Christian König wrote: > Sending it as text mail once more. > > Am 23.01.25 um 15:32 schrieb Christian König: > > Am 23.01.25 um 14:59 schrieb Jason Gunthorpe: > > > On Wed, Jan 22, 2025 at 03:59:11PM +0100, Christian König wrote: > > > > > > For example w

Re: [PATCH v6 01/14] drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...()

2025-01-23 Thread Jani Nikula
On Thu, 23 Jan 2025, Jani Nikula wrote: > On Thu, 23 Jan 2025, Damon Ding wrote: >> According to the comments in include/drm/drm_print.h, the DRM_...() >> functions are deprecated in favor of drm_...() or dev_...() functions. >> >> Use drm_err()/drm_dbg_core()/drm_dbg_kms() instead of >> DRM_DEV_

Re: [PATCH 0/2] drm: add header tests

2025-01-23 Thread Simona Vetter
On Wed, Jan 22, 2025 at 04:41:32PM +0200, Jani Nikula wrote: > Add CONFIG_DRM_HEADER_TEST to ensure drm headers are self-contained and > pass kernel-doc. And for starters, fix one header that this catches. > > Jani Nikula (2): > drm/client: include types.h to make drm_client_event.h self-contain

Re: [PATCH v2 3/5] kci-gitlab: Add drm scenario

2025-01-23 Thread Simona Vetter
On Thu, Jan 23, 2025 at 07:23:33PM +0530, Vignesh Raman wrote: > Add a drm scenario that includes a job to run IGT tests for vkms. > It also includes helper scripts to build deqp-runner and IGT, > which are based on the mesa-ci project. > > The xfails are added from drm-ci (drivers/gpu/drm/ci/xfai

Re: [V7 29/45] drm/colorop: Add PQ 125 EOTF and its inverse

2025-01-23 Thread Harry Wentland
On 2025-01-15 03:00, Simon Ser wrote: > Is this 125 magic number something we can expect other hardware to > implement as well? > It's based on MS's CCCS interpretation of 80 nits as 1.0f [1]. Based on this definition one needs to use 125.0f to represent 10,000 nits, the maximum value PQ can r

Re: [V7 29/45] drm/colorop: Add PQ 125 EOTF and its inverse

2025-01-23 Thread Harry Wentland
On 2025-01-17 04:04, Pekka Paalanen wrote: > On Thu, 19 Dec 2024 21:33:35 -0700 > Alex Hung wrote: > >> From: Harry Wentland >> >> The PQ function defines a mapping of code values to nits (cd/m^2). >> The max code value maps to 10,000 nits. >> >> Windows DWM's canonical composition color spac

Re: [V7 31/45] drm/colorop: add BT2020/BT709 OETF and Inverse OETF

2025-01-23 Thread Harry Wentland
On 2025-01-17 04:06, Pekka Paalanen wrote: > On Thu, 16 Jan 2025 10:56:22 +0200 > Pekka Paalanen wrote: > >> On Thu, 19 Dec 2024 21:33:37 -0700 >> Alex Hung wrote: >> >>> From: Harry Wentland >>> >>> The BT.709 and BT.2020 OETFs are the same, the only difference >>> being that the BT.2020 va

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-23 Thread Christian König
Sending it as text mail once more. Am 23.01.25 um 15:32 schrieb Christian König: Am 23.01.25 um 14:59 schrieb Jason Gunthorpe: On Wed, Jan 22, 2025 at 03:59:11PM +0100, Christian König wrote: For example we have cases with multiple devices are in the same IOMMU domain and re-using their DMA ad

Re: [PATCH] drm/i915: replace in_atomic() with manually set flag

2025-01-23 Thread Maciej Patelczyk
On 10.01.2025 16:46, Krzysztof Karas wrote: GuC code uses in_atomic() function to determine if the current context is atomic. As noted by the function's description it should not be used in driver code, as it is not guaranteed to determine atomicity correctly in every instance. This is also poin

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-23 Thread Christian König
Am 23.01.25 um 14:59 schrieb Jason Gunthorpe: On Wed, Jan 22, 2025 at 03:59:11PM +0100, Christian König wrote: For example we have cases with multiple devices are in the same IOMMU domain and re-using their DMA address mappings. IMHO this is just another flavour of "private" address flow betwee

Re: [PATCH v2 5/5] kci-gitlab: docs: Add images

2025-01-23 Thread Linus Torvalds
On Thu, 23 Jan 2025 at 05:56, Vignesh Raman wrote: > > Documentation/ci/gitlab-ci/images/drm-vkms.png | Bin 0 -> 73810 bytes > .../ci/gitlab-ci/images/job-matrix.png | Bin 0 -> 2 bytes > .../ci/gitlab-ci/images/new-project-runner.png | Bin 0 -> 607737 bytes > .../ci/gitlab-ci/image

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-23 Thread Christian König
Am 23.01.25 um 16:02 schrieb Jason Gunthorpe: On Thu, Jan 23, 2025 at 03:35:21PM +0100, Christian König wrote: Sending it as text mail once more. Am 23.01.25 um 15:32 schrieb Christian König: Am 23.01.25 um 14:59 schrieb Jason Gunthorpe: On Wed, Jan 22, 2025 at 03:59:11PM +0100, Christian Kön

Re: [PATCH 3/5] drm/sched: stop passing non struct drm_device to drm_err() and friends

2025-01-23 Thread Simona Vetter
On Thu, Jan 23, 2025 at 05:09:10PM +0200, Jani Nikula wrote: > The expectation is that the struct drm_device based logging helpers get > passed an actual struct drm_device pointer rather than some random > struct pointer where you can dereference the ->dev member. > > Convert drm_err(sched, ...) t

Re: [PATCH] drm/panel-edp: Add STA 116QHD024002

2025-01-23 Thread Doug Anderson
Hi, On Thu, Jan 23, 2025 at 3:21 AM Langyan Ye wrote: > > Add support for the STA 116QHD024002, pleace the EDID here for > subsequent reference. > > 00 ff ff ff ff ff ff 00 4e 81 09 00 00 00 00 00 > 26 21 01 04 a5 1a 0e 78 02 1e b5 9a 5f 57 94 26 > 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01

Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

2025-01-23 Thread 陳柏霖

Re: [RFC PATCH] drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference

2025-01-23 Thread Tomi Valkeinen
Hi, On 16/01/2025 13:16, Jayesh Choudhary wrote: For the cases we have DRM_BRIDGE_ATTACH_NO_CONNECTOR flag set, Any idea if any other platform than K3 is using this driver? tidss supports DRM_BRIDGE_ATTACH_NO_CONNECTOR, so if K3 is the only user, we could drop the legacy !DRM_BRIDGE_ATTACH_N

Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

2025-01-23 Thread Chen-Yu Tsai
On Fri, Jan 24, 2025 at 12:14 AM Paul-pl Chen (陳柏霖) wrote: > > On Thu, 2025-01-23 at 08:21 +0100, Krzysztof Kozlowski wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > > > > > On 23/01/2025 07:11, Paul-pl Chen (

[PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-01-23 Thread Zhanjun Dong
The purpose of synchronize_irq is to wait for any pending IRQ handlers for the interrupt to complete, if synchronize_irq called before interrupt disabled, an tiny timing window created, where no more pending IRQ, but interrupt not disabled yet. Meanwhile, if the interrupt event happened in this tim

Re: [PATCH v4 1/3] dt-bindings: display: panel: Add compatible for KD110N11-51IE and 2082109QFH040022-50E

2025-01-23 Thread Doug Anderson
Hi, On Wed, Jan 22, 2025 at 10:48 PM Langyan Ye wrote: > > KINGDISPLAY KD110N11-51IE and STARRY 2082109QFH040022-50E are > 10.95-inch WUXGA TFT LCD panels, which fits in nicely with the > existing panel-boe-tv101wum-nl6 driver. Hence, we add a new > compatible with panel specific config. FWIW, t

Re: [PATCH v4 2/3] drm/panel: boe-tv101wum-nl6: support for kingdisplay-kd110n11-51ie MIPI-DSI panel

2025-01-23 Thread Doug Anderson
Hi, On Wed, Jan 22, 2025 at 10:48 PM Langyan Ye wrote: > > The kingdisplay-kd110n11-51ie is a 10.95" TFT panel. > which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. > From the datasheet, MIPI needs to keep the LP11 state before the > lcm_reset pin is pulled high, so increase lp

Re: [PATCH v2 5/5] kci-gitlab: docs: Add images

2025-01-23 Thread Nicolas Dufresne
Le jeudi 23 janvier 2025 à 07:46 -0800, Linus Torvalds a écrit : > On Thu, 23 Jan 2025 at 05:56, Vignesh Raman > wrote: > > > > Documentation/ci/gitlab-ci/images/drm-vkms.png | Bin 0 -> 73810 bytes > > .../ci/gitlab-ci/images/job-matrix.png | Bin 0 -> 2 bytes > > .../ci/gitlab-ci/

Re: [PATCH v4 0/1] Maintenence of devcoredump <-> GuC-Err-Capture plumbing

2025-01-23 Thread Teres Alexis, Alan Previn
On Tue, 2025-01-21 at 18:15 -0500, Vivi, Rodrigo wrote: > On Tue, Jan 21, 2025 at 11:09:34AM -0800, Alan Previn wrote: > > > A 'series' of 1 patch is not a series. Cover letter is not needed. > > However, this patch is the size of a series and it should be > split. I'm really surprised that some

[PATCH] MAINTAINERS: Remove Noralf Trønnes as driver maintainer

2025-01-23 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes Remove myself as maintainer for gud, mi0283qt, panel-mipi-dbi and repaper. My fatigue illness has finally closed the door on doing development of even moderate complexity so it's sad to let this go. Signed-off-by: Noralf Trønnes --- MAINTAINERS | 12 1 file ch

[GIT PULL] fbdev fixes and cleanups for v6.14-rc1

2025-01-23 Thread Helge Deller
Hi Linus, please pull three fixes and 9 cleanup patches for fbdev for this merge window. This series prevents a possible crash and one memory leak in omapfb and fixes possible misbehaviour in vga16fb. Thanks, Helge The following c

  1   2   >