Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

2025-01-06 Thread 林睿祥

Re: [PATCH 1/4] drm/msm/dsi: Drop redundant NULL-ifying of clocks on error paths

2025-01-06 Thread Abhinav Kumar
On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote: dsi_clk_init(), which gets the clocks, is called only through platform driver probe and its failure is a failure of the probe. Therefore NULL-ifying specific clocks is pointless and redundant - the PTR_ERR value stored there won't be used/deref

Re: [PATCH 2/4] drm/msm/dsi: Simplify with dev_err_probe()

2025-01-06 Thread Abhinav Kumar
On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote: dsi_clk_init() and msm_dsi_host_init() are called only from platform dsi_get_config() as well? OR you didnt want to explicitly mention that since its called from msm_dsi_host_init(). driver probe function, so using dev_err_probe is both ap

[PATCH] drm/connector: hdmi: Handle NULL display mode in state check helper

2025-01-06 Thread Cristian Ciocaltea
drm_atomic_helper_connector_hdmi_check() helper makes use of connector_state_get_mode() to obtain a drm_display_mode pointer, but it doesn't validate it, which may lead to a NULL pointer dereference in some cases, i.e. unloading a DRM module: [ 1002.910414] Unable to handle kernel NULL pointer der

Re: [PATCH] drm/panel: xinpeng-xpp055c272: transition to mipi_dsi wrapped functions

2025-01-06 Thread Doug Anderson
Hi, On Mon, Dec 30, 2024 at 2:10 AM wrote: > > > static int xpp055c272_unprepare(struct drm_panel *panel) > > { > > struct xpp055c272 *ctx = panel_to_xpp055c272(panel); > > struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > > - int ret; > > - > > - ret = mipi_ds

Re: [PATCH 3/4] drm/msm/dsi: Minor whitespace and style cleanup

2025-01-06 Thread Abhinav Kumar
On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote: Cleanup few obvious kernel coding style violations: missing or unnecessary braces in 'if-else', unnecessary break lines, incorrect breaking of long function declarations, unnecessary 'else' after a 'return'. No functional impact expected. Sign

Re: [PATCH v4 07/17] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode

2025-01-06 Thread Damon Ding
Hi Dmitry, On 2024/12/30 20:45, Dmitry Baryshkov wrote: On Thu, Dec 26, 2024 at 02:33:03PM +0800, Damon Ding wrote: Add basic support for RBR/HBR/HBR2 link rates, and the voltage swing and pre-emphasis configurations of each link rate have been verified according to the eDP 1.3 requirements.

Re: [PATCH 4/4] drm/msm/dsi: Drop unnecessary -ENOMEM message

2025-01-06 Thread Abhinav Kumar
On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote: Kernel core already prints detailed report about memory allocation failures, so drivers should not have their own error messages. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/dsi/dsi_host.c | 4 +--- 1 file changed, 1 insertio

Re: [PATCH 0/4] drm/msm/dpu: enable CDM for all supported platforms

2025-01-06 Thread Abhinav Kumar
On 12/23/2024 8:25 PM, Dmitry Baryshkov wrote: Enable CDM block on all the platforms where it is supposed to be present. Notably, from the platforms being supported by the DPU driver it is not enabled for SM6115 (DPU 6.3), QCM2290 (DPU 6.5) and SM6375 (DPU 6.9) Thanks for enabling it, but c

Re: [PATCH] drm/msm/dpu: Add writeback support for SM6150

2025-01-06 Thread Abhinav Kumar
f_count = ARRAY_SIZE(sdm845_vbif), --- base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 change-id: 20250106-add-writeback-support-for-sm6150-ba7657196ea8 Best regards,

[PATCH 2/4] drm/msm/dsi: Simplify with dev_err_probe()

2025-01-06 Thread Krzysztof Kozlowski
dsi_clk_init() and msm_dsi_host_init() are called only from platform driver probe function, so using dev_err_probe is both appropriate and beneficial: - Properly marks device deferred probe status, - Avoids dmesg flood on probe deferrals, - Already incorporates printing ERR value, - Shows devic

Re: [PATCH] drm/bridge: adv7511: Switch to atomic operations

2025-01-06 Thread Jesse Van Gavere
Hello Dmitry, > The patch LGTM, but the commit message needs some work. Why/how does > TIDSS require bridges to use atomic ops? In hindsight that indeed could've been worded better, the approach here was as a stepping stone to implementing the input bus formats, which is what TIDSS needs, so I'll

Re: AW: [PATCH] drm/amdgpu: Enable runtime modification of gpu_recovery parameter with validation

2025-01-06 Thread Simona Vetter
On Fri, Jan 03, 2025 at 08:21:43AM +, Koenig, Christian wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Shuai, > > setting gpu_recovery=0 is not even remotely related to RAS. If that > option affects RAS behavior in any way then that is a bug. > > The purpose of sett

[PATCH v2] drm/bridge: adv7511: Switch to atomic operations

2025-01-06 Thread Jesse Van Gavere
Use the atomic version of enable/disable. To support bridges where bus format negotiation is needed such as TIDSS we need to implement atomic_get_input_bus_fmts, prepare the driver for this by switching the existing operations to it's atomic variants. Signed-off-by: Jesse Van Gavere --- Changes

Re: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf

2025-01-06 Thread Simona Vetter
On Thu, Jan 02, 2025 at 09:39:51AM -0400, Jason Gunthorpe wrote: > On Thu, Dec 19, 2024 at 11:04:54AM +0100, Christian König wrote: > > > > Based on all the above, I think we can conclude that since dma_buf_put() > > > does not directly (or synchronously) call the f_op->release() handler, a > > >

Re: [PATCH v3 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2025-01-06 Thread Abel Vesa
On 25-01-03 20:09:42, Dmitry Baryshkov wrote: > On Fri, Jan 03, 2025 at 02:58:17PM +0200, Abel Vesa wrote: > > LTTPRs operating modes are defined by the DisplayPort standard and the > > generic framework now provides a helper to switch between them, which > > is handling the explicit disabling of n

Re: [PATCH v6 5/8] drm: writeback: Create an helper for drm_writeback_connector initialization

2025-01-06 Thread Maxime Ripard
On Mon, 30 Dec 2024 19:37:35 +0100, Louis Chauvet wrote: > As the old drm and the new drmm variants of drm_writeback_connector > requires almost the same initialization, create an internal helper to do > most of the initialization work. > > Signed-off-by: Louis Chauvet > > [ ... ] Reviewed-by:

Re: [PATCH v6 6/8] drm: writeback: Add missing cleanup in case of initialization failure

2025-01-06 Thread Maxime Ripard
On Mon, Dec 30, 2024 at 07:37:36PM +0100, Louis Chauvet wrote: > The current implementation of drm_writeback_connector initialization does > not properly clean up all resources in case of failure (allocated > properties and possible_encoders). Add this cleaning in case of failure. > > Signed-off-b

Re: [PATCH v2 2/2] drm/buddy: Add a testcase to verify the multiroot fini

2025-01-06 Thread Paneer Selvam, Arunpravin
Hi Matthew, Ping? Regards, Arun. On 12/26/2024 12:31 PM, Arunpravin Paneer Selvam wrote: - Added a testcase to verify the multiroot force merge fini. - Added a new field in_use to track the mm freed status. v2:(Matthew) - Add kunit_fail_current_test() when WARN_ON is true. Signed-off-by:

Re: [PATCH v3 0/6] Support for GPU ACD feature on Adreno X1-85

2025-01-06 Thread Akhil P Oommen
On Sun, Jan 05, 2025 at 04:55:42PM -0800, Rob Clark wrote: > fwiw, I did see some perf boost (was mainly looking at gfxbench aztec > ruins vk high/normal, and also a separate mesa MR that fixes some LRZ > issues with turnip, so I don't remember how much boost was related to > which offhand).. I've

Re: [PATCH v2 1/7] kernel/cgroup: Add "dmem" memory accounting cgroup

2025-01-06 Thread Michal Koutný
Hello. On Wed, Dec 04, 2024 at 02:44:01PM +0100, Maarten Lankhorst wrote: > +bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state > *limit_pool, > + struct dmem_cgroup_pool_state *test_pool, > + bool ignore_low,

Re: [REGRESSION][BISECTED] Re: 6.12.7 stable new error: event xe_bo_move has unsafe dereference of argument 4

2025-01-06 Thread Steven Rostedt
On Sat, 04 Jan 2025 15:09:10 -0500 Genes Lists wrote: > On Sat, 2025-01-04 at 18:43 +0100, Andrea Amorosi wrote: > > Hi to all, > > > > I've just updated my archlinux to |6.12.8-arch1-1 and I still get the > > same issue:| > > > > > Right - 6.12.8 (and Arch build of same) does not have Steve

Re: [PATCH v2] drm/ci: uprev IGT

2025-01-06 Thread Helen Mae Koike Fornazier
On Tue, 17 Dec 2024 13:06:52 -0300 Vignesh Raman wrote --- > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman vignesh.ra...@collabora.com> Applied to drm-ci misc. Thanks Helen > --- > > v1: > - Pipeline link - > https://

Re: [PATCH v1 2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()

2025-01-06 Thread Darrick J. Wong
On Sun, Dec 29, 2024 at 01:58:19PM +0100, Andrey Albershteyn wrote: > On 2024-12-18 16:35:21, Darrick J. Wong wrote: > > On Tue, Dec 17, 2024 at 11:58:12PM +0100, Mirsad Todorovac wrote: > > > The source static analysis tool gave the following advice: > > > > > > ./fs/xfs/libxfs/xfs_dir2.c:382:15-

[PATCH 1/4] drm/msm/dsi: Drop redundant NULL-ifying of clocks on error paths

2025-01-06 Thread Krzysztof Kozlowski
dsi_clk_init(), which gets the clocks, is called only through platform driver probe and its failure is a failure of the probe. Therefore NULL-ifying specific clocks is pointless and redundant - the PTR_ERR value stored there won't be used/dereferenced afterwards. What's more, variant-specific clo

[PATCH 3/4] drm/msm/dsi: Minor whitespace and style cleanup

2025-01-06 Thread Krzysztof Kozlowski
Cleanup few obvious kernel coding style violations: missing or unnecessary braces in 'if-else', unnecessary break lines, incorrect breaking of long function declarations, unnecessary 'else' after a 'return'. No functional impact expected. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/m

[PATCH 4/4] drm/msm/dsi: Drop unnecessary -ENOMEM message

2025-01-06 Thread Krzysztof Kozlowski
Kernel core already prints detailed report about memory allocation failures, so drivers should not have their own error messages. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/dsi/dsi_host.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/d

[PATCH 0/4] drm/msm/dsi: Minor cleanups

2025-01-06 Thread Krzysztof Kozlowski
/dsi: Drop unnecessary -ENOMEM message drivers/gpu/drm/msm/dsi/dsi_host.c | 158 - 1 file changed, 68 insertions(+), 90 deletions(-) --- base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 change-id: 20250106-drm-msm-cleanups-ddacf1fc3ba5 Best regards

[PULL] drm-misc-next

2025-01-06 Thread Maxime Ripard
Hi, Here's the (last, probably) drm-misc-next PR that covers what has been merged during the holidays season. Maxime drm-misc-next-2025-01-06: drm-misc-next for 6.14: UAPI Changes: - Clarify drm memory stats documentation Cross-subsystem Changes: Core Changes: - sched: Documentation fixes,

Re:Re: [PATCH v8 8/9] dt-bindings: display: vop2: Add rk3576 support

2025-01-06 Thread Andy Yan
Hi Rob, At 2025-01-04 00:34:49, "Rob Herring" wrote: >On Tue, Dec 31, 2024 at 05:07:51PM +0800, Andy Yan wrote: >> From: Andy Yan >> >> Add vop found on rk3576, the main difference between rk3576 and the >> previous vop is that each VP has its own interrupt line. >> >> Signed-off-by: Andy Yan

Re: [PATCH 09/22] iommu: sun50i: make reset control optional

2025-01-06 Thread Joerg Roedel
On Fri, Dec 27, 2024 at 04:37:56PM +0530, Parthiban Nallathambi wrote: > A133/A100 SoC doesn't have reset control from the CCU. Get reset > control line optionally. > > Signed-off-by: Parthiban Nallathambi > --- > drivers/iommu/sun50i-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH 44/45] arm64: dts: qcom: add mst support for pixel stream clk for DP0

2025-01-06 Thread Bjorn Andersson
On Thu, Dec 05, 2024 at 08:32:15PM -0800, Abhinav Kumar wrote: > From: Yongxing Mou > I'd expect "sa8775p" in the subject prefix. > Populate the pixel clock for stream 1 for DP0 for sa8775p DP controller. Please write your commit messages in the style expressed in https://docs.kernel.org/proce

Re: [PATCH 03/45] drm/msm/dp: fix the intf_type of MST interfaces

2025-01-06 Thread Bjorn Andersson
On Thu, Dec 05, 2024 at 08:31:34PM -0800, Abhinav Kumar wrote: > Interface type of MST interfaces is currently INTF_NONE. > Fix this to INTF_DP. > Wouldn't it make sense to introduce this later in the series, once the implementation would actually handle this case? Or could/should we have left th

Re: [PATCH] drm/panel: ebbg-ft8719: transition to mipi_dsi wrapped functions

2025-01-06 Thread Doug Anderson
Hi, On Sun, Jan 5, 2025 at 8:11 PM Tejas Vipin wrote: > > Changes the ebbg-ft8719 panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 67 ++- > 1 file changed, 16 insertions(+),

Re: [PATCH 00/45] drm/msm/dp: Add MST support for MSM chipsets

2025-01-06 Thread Bjorn Andersson
On Thu, Dec 05, 2024 at 08:31:31PM -0800, Abhinav Kumar wrote: Please discuss with and reply to Dmitry's questions/feedback on the list, so that it's possible for others to join the discussion. Regards, Bjorn > Add support for Multi-stream transport for MSM chipsets that allow > a single instanc

Re: [PATCH] drm/msm/dpu: Add writeback support for SM6150

2025-01-06 Thread Dmitry Baryshkov
On Mon, Jan 06, 2025 at 02:39:09PM +0800, Fange Zhang wrote: > On the SM6150 platform there is WB_2 block. Add it to the SM6150 catalog. > > Signed-off-by: Fange Zhang > --- > A followup patch to add writeback configuration for the SM6150 catalog > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu

Re: [PATCH 00/45] drm/msm/dp: Add MST support for MSM chipsets

2025-01-06 Thread Abhinav Kumar
Hi Bjorn / Dmitry Happy New Year ! On 1/6/2025 5:06 PM, Bjorn Andersson wrote: On Thu, Dec 05, 2024 at 08:31:31PM -0800, Abhinav Kumar wrote: Please discuss with and reply to Dmitry's questions/feedback on the list, so that it's possible for others to join the discussion. Regards, Bjorn Sor

Re: [PATCH] drm/i915: Add debug print about hw config table size

2025-01-06 Thread John Harrison
On 12/24/2024 11:10, Daniele Ceraolo Spurio wrote: On 12/24/2024 10:13 AM, John Harrison wrote: On 12/23/2024 15:20, Daniele Ceraolo Spurio wrote: On 12/20/2024 5:19 PM, john.c.harri...@intel.com wrote: From: John Harrison Add debug info to help investigate a very rare bug: https://gitlab.

Re: [PATCH v2] drm/msm/dpu: correct LM pairing for SM6150

2025-01-06 Thread Abhinav Kumar
On 12/17/2024 4:35 AM, Dmitry Baryshkov wrote: The SM6150 platform doesn't have 3DMux (MERGE_3D) block, so it can not split the screen between two LMs. Drop lm_pair fields as they don't make sense for this platform. Suggested-by: Abhinav Kumar Fixes: cb2f9144693b ("drm/msm/dpu: Add SM6150 su

Re: [PATCH v3 3/6] drm/msm/adreno: Add module param to disable ACD

2025-01-06 Thread Akhil P Oommen
On 12/31/2024 4:02 PM, Konrad Dybcio wrote: > On 30.12.2024 10:11 PM, Akhil P Oommen wrote: >> Add a module param to disable ACD which will help to quickly rule it >> out for any GPU issues. >> >> Signed-off-by: Akhil P Oommen >> --- > > Is that something useful during internal development, or do

Re: [PATCH] drm/panel: xinpeng-xpp055c272: transition to mipi_dsi wrapped functions

2025-01-06 Thread Tejas Vipin
On 1/7/25 5:37 AM, Doug Anderson wrote: > Hi, > > On Mon, Dec 30, 2024 at 2:10 AM wrote: >> >>> static int xpp055c272_unprepare(struct drm_panel *panel) >>> { >>> struct xpp055c272 *ctx = panel_to_xpp055c272(panel); >>> struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev)

Re: [PATCH] drm/panel: xinpeng-xpp055c272: transition to mipi_dsi wrapped functions

2025-01-06 Thread Doug Anderson
Hi, On Mon, Jan 6, 2025 at 8:21 PM Tejas Vipin wrote: > > >>> - ret = xpp055c272_init_sequence(ctx); > >>> - if (ret < 0) { > >>> - dev_err(ctx->dev, "Panel init sequence failed: %d\n", ret); > >>> - goto disable_iovcc; > >>> - } > >>> - > >>> - ret = mipi_

Re: [PATCH] drm/msm/dpu: Add writeback support for SM6150

2025-01-06 Thread fange zhang
f_count = ARRAY_SIZE(sm6150_intf),   .intf = sm6150_intf,   .vbif_count = ARRAY_SIZE(sdm845_vbif), --- base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 change-id: 20250106-add-writeback-support-for-sm6150-ba7657196ea8 Best regards,

Re: [PATCH v2 0/3] Add HDMI support for rk3576

2025-01-06 Thread Heiko Stuebner
On Tue, 31 Dec 2024 17:44:16 +0800, Andy Yan wrote: > RK3576 HDMI TX Controller is very similar to that of RK3588, but with > some control bits for IO and interrupts status scattered across different > GRF. > > PATCH 1/3 is add platform ctrl callback for IO setting and interrupts > status handin

Re: [PATCH v4 1/4] drm: bridge: dw_hdmi: Add flag to indicate output port is optional

2025-01-06 Thread Marek Vasut
On 1/6/25 8:05 AM, Laurent Pinchart wrote: On Mon, Jan 06, 2025 at 03:48:52AM +0100, Marek Vasut wrote: On 1/6/25 12:22 AM, Laurent Pinchart wrote: Hi Marek, Hi, Thank you for the patch. On Sun, Jan 05, 2025 at 08:06:03PM +0100, Marek Vasut wrote: Add a flag meant purely to work around br

[PATCH v2] vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64

2025-01-06 Thread Christian Kujau
Now that VirtualBox is able to run as a host on arm64 (e.g. the Apple M3 processors) we can enable VBOXSF_FS (and in turn VBOXGUEST) for this architecture. Tested with various runs of bonnie++ and dbench on an Apple MacBook Pro with the latest Virtualbox 7.1.4 r165100 installed. Signed-off-by:

Re: [PATCH v2] vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64

2025-01-06 Thread Greg Kroah-Hartman
On Mon, Jan 06, 2025 at 04:32:05PM +0100, Christian Kujau wrote: > Now that VirtualBox is able to run as a host on arm64 (e.g. the Apple M3 > processors) we can enable VBOXSF_FS (and in turn VBOXGUEST) for this > architecture. Tested with various runs of bonnie++ and dbench on an Apple > MacBook

Re: [PATCH v2] vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64

2025-01-06 Thread Hans de Goede
Hi, On 6-Jan-25 4:32 PM, Christian Kujau wrote: > Now that VirtualBox is able to run as a host on arm64 (e.g. the Apple M3 > processors) we can enable VBOXSF_FS (and in turn VBOXGUEST) for this > architecture. Tested with various runs of bonnie++ and dbench on an Apple > MacBook Pro with the la

Re: [PATCH 3/6] drm/syncobj: Do not allocate an array to store zeros

2025-01-06 Thread Michel Dänzer
On 2025-01-02 20:44, Tvrtko Ursulin wrote: > > "vkgears -present-mailbox" average framerate: > > Before: 21410.1089 > After: 21609.7225 > > With a disclaimer that measuring with vkgears feels a bit variable, > nevertheless it did not look like noise. That's ~1% difference. IME the frame ra

Re: [PATCH v2] drm/bridge: adv7511: Switch to atomic operations

2025-01-06 Thread Dmitry Baryshkov
On Mon, 6 Jan 2025 at 14:11, Jesse Van Gavere wrote: > > Use the atomic version of enable/disable. > > To support bridges where bus format negotiation is needed such as TIDSS we > need to implement atomic_get_input_bus_fmts, prepare the driver for this by > switching the existing operations to it'

Re: [PATCH] drm/panel: ebbg-ft8719: transition to mipi_dsi wrapped functions

2025-01-06 Thread neil . armstrong
On 06/01/2025 05:11, Tejas Vipin wrote: Changes the ebbg-ft8719 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 67 ++- 1 file changed, 16 insertions(+), 51 deletions(-) diff --git

Re: [PATCH 0/3] drm/i915/gvt: Deadcoding

2025-01-06 Thread Zhenyu Wang
On Sun, Dec 22, 2024 at 12:20:40AM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > Remove a bunch of long unused functions from > the gvt code. > > Signed-off-by: Dr. David Alan Gilbert > > > Dr. David Alan Gilbert (3): > drm/i915/gvt: Remove intel_gvt_ggtt_h2g<->index

Re: [PATCH 0/3] drm/i915/gvt: Deadcoding

2025-01-06 Thread Zhenyu Wang
On Sun, Dec 22, 2024 at 12:25:09AM +, Dr. David Alan Gilbert wrote: > Note: zhen...@linux.intel.com's address bounces: > yeah, I've left Intel so can't use that box any more, looks Rodrigo hasn't queue up my address change patch yet. Rodrigo?

Re: [PATCH RESEND 09/22] iommu: sun50i: make reset control optional

2025-01-06 Thread Philipp Zabel
On Fr, 2024-12-27 at 18:30 +0530, Parthiban Nallathambi wrote: > A133/A100 SoC doesn't have reset control from the CCU. Get reset > control line optionally. > > Signed-off-by: Parthiban Nallathambi > --- > drivers/iommu/sun50i-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re:Re: [PATCH 1/3] drm/rockchip: dw_hdmi_qp: Add platform ctrl callback

2025-01-06 Thread Andy Yan
Hi Heiko, At 2025-01-02 19:51:58, "Heiko Stübner" wrote: >Hi Andy, > >Am Mittwoch, 25. Dezember 2024, 11:37:29 CET schrieb Andy Yan: >> From: Andy Yan >> >> There are some control bits for IO and interrupts status scattered >> across different GRF on differt SOC. >> Add platform callback for t

Re:Re: [PATCH 3/3] drm/rockchip: Add basic RK3576 HDMI output support

2025-01-06 Thread Andy Yan
Hi Heiko, At 2025-01-02 19:56:55, "Heiko Stübner" wrote: >Am Mittwoch, 25. Dezember 2024, 11:37:31 CET schrieb Andy Yan: >> From: Andy Yan >> >> The HDMI on RK3576 shares the same IP block (PHY and Controller) >> with rk3588. >> However, there are some control bits scattered in different GRF. >

Re: [PATCH v3] drm/ast: Support timings, 1280x720/1280x960/1600x900

2025-01-06 Thread Thomas Zimmermann
Hi Jamie Am 25.12.24 um 01:32 schrieb Jammy Huang: In this patch, 3 new timings are added into support list. If you want to have new timings, 1280x720 and 1280x960 on DisplayPort, your dp-fw should be newer than version, 20240502. Thank you for the patch. What happens if the firmware is not

Re: [PATCH 2/2] drm/i2c: move TDA drivers under drivers/gpu/drm/bridge

2025-01-06 Thread Hans Verkuil
On 06/01/2025 00:20, Laurent Pinchart wrote: > (CC'ing Hans Verkuil) > > On Mon, Jan 06, 2025 at 12:52:55AM +0200, Dmitry Baryshkov wrote: >> On Sun, Dec 15, 2024 at 02:38:05PM +0200, Laurent Pinchart wrote: >>> Hi Dmitry, >>> >>> Thank you for the patch. >>> >>> On Sun, Dec 15, 2024 at 01:09:08PM

Re: [PATCH 0/2] Add support for AM62L DSS

2025-01-06 Thread Tomi Valkeinen
Hi, On 31/12/2024 11:04, Devarsh Thakkar wrote: This adds support for DSS subsystem present in TI's AM62L SoC which supports single display pipeline with DPI output which is also routed to DSI Tx controller within the SoC. Devarsh Thakkar (2): dt-bindings: display: ti,am65x-dss: Add support

Re: [PATCH 2/2] drm/tidss: Add support for AM62L display subsystem

2025-01-06 Thread Tomi Valkeinen
Hi, On 31/12/2024 11:04, Devarsh Thakkar wrote: Enable display for AM62L DSS [1] which supports only a single display pipeline using a single overlay manager, single video port and a single video lite pipeline which does not support scaling. The output of video port is routed to SoC boundary vi

Re: [PATCH 1/3] drm/rockchip: dw_hdmi_qp: Add platform ctrl callback

2025-01-06 Thread Heiko Stübner
Am Montag, 6. Januar 2025, 09:35:26 CET schrieb Andy Yan: > > Hi Heiko, > > At 2025-01-02 19:51:58, "Heiko Stübner" wrote: > >Hi Andy, > > > >Am Mittwoch, 25. Dezember 2024, 11:37:29 CET schrieb Andy Yan: > >> From: Andy Yan > >> > >> There are some control bits for IO and interrupts status sc

Re: [PATCH v2 2/2] drm/buddy: Add a testcase to verify the multiroot fini

2025-01-06 Thread Matthew Auld
Hey, On 06/01/2025 12:37, Paneer Selvam, Arunpravin wrote: Hi Matthew, Ping? Just got back from time off. I already slapped an r-b here: https://lore.kernel.org/dri-devel/aa27455c-04b8-494c-a3b5-c4385a774...@intel.com/ Regards, Arun. On 12/26/2024 12:31 PM, Arunpravin Paneer Selvam wrot

Re: [PATCH v6 4/8] drm: writeback: Introduce cleanup function

2025-01-06 Thread Louis Chauvet
On 06/01/25 - 10:43, Maxime Ripard wrote: > On Mon, Dec 30, 2024 at 07:37:34PM +0100, Louis Chauvet wrote: > > Currently there is no cleanup function for writeback connectors. To allows > > implementation of drmm variant of writeback connector, create a cleanup > > function that can be used to prop

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-06 Thread Dmitry Baryshkov
On Mon, 6 Jan 2025 at 10:55, Maxime Ripard wrote: > > On Mon, Jan 06, 2025 at 12:47:07AM +0200, Dmitry Baryshkov wrote: > > On Sat, Dec 14, 2024 at 03:37:04PM +0200, Dmitry Baryshkov wrote: > > > While working on the generic mode_valid() implementation for the HDMI > > > Connector framework I noti

Re: [PATCH 4/5] clk: Add flag to prevent frequency changes when walking subtrees

2025-01-06 Thread Maxime Ripard
On Mon, Dec 30, 2024 at 05:22:56PM -0800, Stephen Boyd wrote: > Quoting Miquel Raynal (2024-12-23 10:43:13) > > Hi Maxime, > > > > On 17/12/2024 at 13:47:53 +01, Maxime Ripard wrote: > > > > > On Thu, Nov 21, 2024 at 06:41:14PM +0100, Miquel Raynal wrote: > > >> There are mainly two ways to chan

Re: [PATCH] vbox: arm64 support for vboxguest

2025-01-06 Thread Hans de Goede
Hi Christian, Thank you for your patch. On 15-Dec-24 8:52 PM, Christian Kujau wrote: > My last email[0] still had "RFC" in the subject line, but no comments were > received. So, in an attempt of stupi^W boldness, this is the same patch > again, with RFC removed and ready for mainline, maybe? >

Re: [PATCH v4 13/17] drm/bridge: analogix_dp: Convert &analogix_dp_device.aux into a pointer

2025-01-06 Thread Dmitry Baryshkov
On Mon, 6 Jan 2025 at 13:04, Damon Ding wrote: > > Hi Dmitry, > > On 2024/12/30 21:35, Dmitry Baryshkov wrote: > > On Thu, Dec 26, 2024 at 02:33:09PM +0800, Damon Ding wrote: > >> With the previous patch related to the support of getting panel from > >> the DP AUX bus, the &analogix_dp_device.aux

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-06 Thread Thomas Zimmermann
Hi, Thanks for the info. Am 06.01.25 um 08:03 schrieb Binbin Zhou: [...] Could you point to the exact call that fails within simpledrm? If we use simpledrm directly, the following error occurs: [8.289823] simple-framebuffer simple-framebuffer.0: [drm] *ERROR* could not acquire memory ran

[PULL] dmem cgroup

2025-01-06 Thread Maxime Ripard
Hi, Here's a drm-next PR for the new "dmem" cgroup Maarten and I worked on. Given that it's only user for now is DRM, Tejun agreed to merge it through DRM. This is based on the series sent by Maarten here: https://lore.kernel.org/all/20241204134410.1161769-1-...@lankhorst.se/ The three last patc

Re: [PATCH v2 3/3] drm/stm: dsi: use drm_mode_validate_mode() helper function

2025-01-06 Thread Raphael Gallais-Pou
On 11/25/24 14:49, Sean Nyekjaer wrote: > When using the DSI interface via DSI2LVDS bridge, it seems a bit harsh to > reguire the requested and the actual px clock to be within 50Hz. A typical > LVDS display requires the px clock to be within +-10%. In case for HDMI .5% > tolerance is required. S

Re: [PATCH v2 1/3] drm/modes: introduce drm_mode_validate_mode() helper function

2025-01-06 Thread Raphael Gallais-Pou
On 11/25/24 14:49, Sean Nyekjaer wrote: > Check if the required pixel clock is in within .5% range of the > desired pixel clock. > This will match the requirement for HDMI where a .5% tolerance is allowed. > > Signed-off-by: Sean Nyekjaer > --- > drivers/gpu/drm/drm_modes.c | 34 +++

Re: [PATCH v5 2/2] Documentation/gpu: Add fdinfo meanings of drm-*-internal memory tags

2025-01-06 Thread Adrián Martínez Larumbe
On 03.01.2025 10:49, Tvrtko Ursulin wrote: > On 02/01/2025 22:18, Adrián Martínez Larumbe wrote: > > On 02.01.2025 21:59, Tvrtko Ursulin wrote: > > > > > > On 18/12/2024 18:18, Adrián Martínez Larumbe wrote: > > > > From: Adrián Larumbe > > > > > > > > A previous commit enabled display of driver

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-06 Thread Maxime Ripard
On Mon, Jan 06, 2025 at 02:24:00PM +0200, Dmitry Baryshkov wrote: > On Mon, 6 Jan 2025 at 12:39, Maxime Ripard wrote: > > > > Hi, > > > > Most of these comments affect your earlier patches, but let's work on > > the API-level view. > > > > On Tue, Dec 31, 2024 at 11:39:58AM +0100, Luca Ceresoli wr

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-06 Thread Harry Wentland
On 2025-01-06 04:45, Dmitry Baryshkov wrote: > On Mon, 6 Jan 2025 at 10:55, Maxime Ripard wrote: >> >> On Mon, Jan 06, 2025 at 12:47:07AM +0200, Dmitry Baryshkov wrote: >>> On Sat, Dec 14, 2024 at 03:37:04PM +0200, Dmitry Baryshkov wrote: While working on the generic mode_valid() implement

Re: [PATCH v6 7/8] drm: writeback: Create drmm variants for drm_writeback_connector initialization

2025-01-06 Thread Louis Chauvet
On 06/01/25 - 14:04, Maxime Ripard wrote: > On Mon, Dec 30, 2024 at 07:37:37PM +0100, Louis Chauvet wrote: > > To allows driver to only use drmm objects, add helper to create > > drm_writeback_connectors with automated lifetime management. > > > > Signed-off-by: Louis Chauvet > > --- > > drivers

Re: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf

2025-01-06 Thread Jason Gunthorpe
On Mon, Jan 06, 2025 at 01:05:08PM +0100, Simona Vetter wrote: > On Thu, Jan 02, 2025 at 09:39:51AM -0400, Jason Gunthorpe wrote: > > On Thu, Dec 19, 2024 at 11:04:54AM +0100, Christian König wrote: > > > > > > Based on all the above, I think we can conclude that since dma_buf_put() > > > > does n

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-06 Thread Dmitry Baryshkov
On Mon, 6 Jan 2025 at 12:39, Maxime Ripard wrote: > > Hi, > > Most of these comments affect your earlier patches, but let's work on > the API-level view. > > On Tue, Dec 31, 2024 at 11:39:58AM +0100, Luca Ceresoli wrote: > > + * When using refcounted mode, the driver should allocate ``struct > > +

Re: [PATCH 0/5] clk: Fix simple video pipelines on i.MX8

2025-01-06 Thread Maxime Ripard
On Mon, Dec 23, 2024 at 07:59:02PM +0100, Miquel Raynal wrote: > Hello, > > >> >> [After applying PATCH "clk: imx: clk-imx8mp: Allow LDB serializer clock > >> >> reconfigure parent rate"] > >> >> > >> >> This is a commit from Marek, which is, I believe going in the right > >> >> direction, so I

Re: [PATCH v4 0/4] Fix ycbcr_420_allowed inconsistency for HDMI bridges

2025-01-06 Thread Maxime Ripard
On Tue, 24 Dec 2024 20:22:40 +0200, Cristian Ciocaltea wrote: > Bridges with DRM_BRIDGE_OP_HDMI set in drm_bridge->ops are expected to > rely on drm_bridge->supported_formats to advertise the supported > colorspaces, including HDMI_COLORSPACE_YUV420. > > However, when drm_bridge_connector gets ini

Re: [PATCH v4 1/4] drm: bridge: dw_hdmi: Add flag to indicate output port is optional

2025-01-06 Thread Laurent Pinchart
On Mon, Jan 06, 2025 at 04:36:26PM +0100, Marek Vasut wrote: > On 1/6/25 8:05 AM, Laurent Pinchart wrote: > > On Mon, Jan 06, 2025 at 03:48:52AM +0100, Marek Vasut wrote: > >> On 1/6/25 12:22 AM, Laurent Pinchart wrote: > >>> Hi Marek, > >> > >> Hi, > >> > >>> Thank you for the patch. > >>> > >>> O

[PATCH v2 05/10] dt-bindings: display/lvds-codec: add ti,sn65lvds822

2025-01-06 Thread Ahmad Fatoum
Add compatible strings for TI SN65LVDS822, a FlatLink LVDS receiver. Acked-by: Rob Herring (Arm) Signed-off-by: Ahmad Fatoum --- v1 -> v2: - Add Rob's Acked-by To: Andrzej Hajda (maintainer:DRM DRIVERS FOR BRIDGE CHIPS) To: Neil Armstrong (maintainer:DRM DRIVERS FOR BRIDGE CHIPS) To: Robe

[PATCH v2 00/10] arm64: dts: imx8mp-skov: flesh out device trees

2025-01-06 Thread Ahmad Fatoum
When the Skov device trees were added a year ago, there were no upstream bindings yet for many parts of the display pipeline. This has changed now, so this series fleshes the display pipeline parts out and adds some more fixes/enhancements that have accrued in the meantime. --- Changes in v2: - A

Re: [PATCH] drm/amd/display: Increase sanitizer frame larger than limit when compile testing with clang

2025-01-06 Thread Alex Deucher
Applied. Thanks! On Thu, Dec 19, 2024 at 6:46 PM Nathan Chancellor wrote: > > Commit 24909d9ec7c3 ("drm/amd/display: Overwriting dualDPP UBF values > before usage") added a new warning in dml2/display_mode_core.c when > building allmodconfig with clang: > > drivers/gpu/drm/amd/amdgpu/../displa

Re: [PATCH] nouveau/fence: handle cross device fences properly.

2025-01-06 Thread Ben Skeggs
On 7/1/25 15:58, Dave Airlie wrote: From: Dave Airlie If we have two nouveau controlled devices and one passes a dma-fence to the other, when we hit the sync path it can cause the second device to try and put a sync wait in it's pushbuf for the seqno of the context on the first device. Since

Re: [PATCH v20 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2025-01-06 Thread Alexander Stein
Hi Sandor, thanks for the updates. Am Dienstag, 17. Dezember 2024, 07:51:42 CET schrieb Sandor Yu: > The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge > driver and Cadence HDP-TX PHY(HDMI/DP) driver for Freescale i.MX8MQ. > > The patch set compose of DRM bridge drivers and PHY d

Re: [PATCH v4 2/2] i2c: i2c-qcom-geni: Add Block event interrupt support

2025-01-06 Thread Mukesh Kumar Savaliya
On 12/17/2024 10:34 PM, Jyothi Kumar Seerapu wrote: The I2C driver gets an interrupt upon transfer completion. When handling multiple messages in a single transfer, this results in N interrupts for N messages, leading to significant software interrupt latency. To mitigate this latency, utiliz

[PATCH] nouveau/fence: handle cross device fences properly.

2025-01-06 Thread Dave Airlie
From: Dave Airlie If we have two nouveau controlled devices and one passes a dma-fence to the other, when we hit the sync path it can cause the second device to try and put a sync wait in it's pushbuf for the seqno of the context on the first device. Since fence contexts are vmm bound, check the

[PATCH] [RFC] nouveau: hack fix for regression from 6.2

2025-01-06 Thread Dave Airlie
From: Dave Airlie I recently got a regression report for RHEL 8.10 with a multi-card GP106 setup. This led me down a rabbit hole of a few problems, I've sent the cross-fence device fix but this is also needed to make things work properly. Hopefully I can at least work out how to restrict this to

Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

2025-01-06 Thread 林睿祥

Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

2025-01-06 Thread Krzysztof Kozlowski
On 07/01/2025 03:42, Jason-JH Lin (林睿祥) wrote: >> >> Before proceeding with this header further, please answer to above - >> why >> interrupt numbers, MMIO addresses and some other values appearing in >> DTS >> are not used like "binding headers". > > Because interrupt numbers and MMIO addresses a

Re: [PATCH 2/4] drm/msm/dsi: Simplify with dev_err_probe()

2025-01-06 Thread Krzysztof Kozlowski
On 07/01/2025 03:56, Abhinav Kumar wrote: > > > On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote: >> dsi_clk_init() and msm_dsi_host_init() are called only from platform > > dsi_get_config() as well? OR you didnt want to explicitly mention that > since its called from msm_dsi_host_init(). > As

Re: AW: [PATCH] drm/amdgpu: Enable runtime modification of gpu_recovery parameter with validation

2025-01-06 Thread Shuai Xue
在 2025/1/3 16:21, Koenig, Christian 写道: [AMD Official Use Only - AMD Internal Distribution Only] Hi Shuai, setting gpu_recovery=0 is not even remotely related to RAS. If that option affects RAS behavior in any way then that is a bug. The purpose of setting gpu_recovery=0 is to disable rese

Re: [PATCH v4 1/2] dmaengine: qcom: gpi: Add GPI Block event interrupt support

2025-01-06 Thread Mukesh Kumar Savaliya
On 12/17/2024 10:34 PM, Jyothi Kumar Seerapu wrote: GSI hardware generates an interrupt for each transfer completion. For multiple messages within a single transfer, this results in N interrupts for N messages, leading to significant software interrupt latency. To mitigate this latency, utili

Re: [PATCH v2 1/3] dt-bindings: gpu: mali-utgard: Add st, stih410-mali compatible

2025-01-06 Thread Patrice CHOTARD
On 10/6/24 22:42, Alain Volmat wrote: > ST STiH410 SoC has a Mali400. Add a compatible for it. > > Signed-off-by: Alain Volmat > --- > Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm

[PATCH 1/7] drm/syncobj: Remove unhelpful helper

2025-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Helper which fails to consolidate the code and instead just forks into two copies of the code based on a boolean parameter is not very helpful or readable. Lets just remove it and proof in the pudding is the net smaller code. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/d

[PATCH 2/7] drm/syncobj: Do not allocate an array to store zeros when waiting

2025-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When waiting on syncobjs the current code allocates a temporary array only to fill it up with all zeros. We can avoid that by relying on the allocated entry array already being zero allocated. For the timeline mode we can fetch the timeline point values as we populate the e

[PATCH 3/7] drm/syncobj: Avoid one temporary allocation in drm_syncobj_array_find

2025-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Drm_syncobj_array_find() helper is used from many userspace ioctl entry points with the task of looking up userspace handles to internal objects. We can easily avoid one temporary allocation by making it read the handles as it is looking them up. Signed-off-by: Tvrtko Ursul

[PATCH 4/7] drm/syncobj: Use put_user in drm_syncobj_query_ioctl

2025-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since the query loop is using copy_to_user() to write out a single u64 at a time it feels more natural (and is a tiny bit more compact) to replace it with put_user(). Access_ok() check is added to the input checking for an early bailout in case of a bad buffer passed in. Si

[PATCH 6/7] drm/syncobj: Add a fast path to drm_syncobj_array_wait_timeout

2025-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Running the Cyberpunk 2077 benchmark we can observe that waiting on DRM sycobjs is relatively hot, but the 96% of the calls are for a single object. (~4% for two points, and never more than three points. While a more trivial workload like vkmark under Plasma is even more skew

[PATCH 7/7] drm/syncobj: Add a fast path to drm_syncobj_array_find

2025-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Running the Cyberpunk 2077 benchmark we can observe that the lookup helper is relatively hot, but the 97% of the calls are for a single object. (~3% for two points, and never more than three points. While a more trivial workload like vkmark under Plasma is even more skewed to

  1   2   >