[PATCH v4.19-v6.1] drm/amdgpu: Using uninitialized value *size when calling

2024-08-29 Thread Vamsi Krishna Brahmajosyula
From: Jesse Zhang [ Upstream commit 88a9a467c548d0b3c7761b4fd54a68e70f9c0944 ] Initialize the size before calling amdgpu_vce_cs_reloc, such as case 0x0301. V2: To really improve the handling we would actually need to have a separate value of 0x.(Christian) Signed-off-by: Jesse Zh

[PULL] drm-intel-fixes

2024-08-29 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-fixes towards v6.11-rc6. Fix for USB type-C docks, backlight fix for Lenovo Yoga Tab 3 2G version and ARL GuC firmware version correction. Regards, Joonas *** drm-intel-fixes-2024-08-29: - Fix #11195: The external display connect via USB type-C dock stays b

[PATCH] drm/i915/gem: Remove duplicate 'unlikely()' usage

2024-08-29 Thread Kunwu Chan
From: Kunwu Chan nested unlikely() calls, IS_ERR already uses unlikely() internally Signed-off-by: Kunwu Chan --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm

Re: [Letux-kernel] [PATCHv2 0/6] drm/omap: hdmi: improve hdmi4 CEC, add CEC for hdmi5

2024-08-29 Thread Hans Verkuil
On 28/08/2024 21:41, H. Nikolaus Schaller wrote: > Hi all, > >> Am 28.08.2024 um 16:14 schrieb Hans Verkuil : >> >> On 28/08/2024 15:57, Tomi Valkeinen wrote: >>> Hi, >>> >>> On 25/08/2024 23:31, H. Nikolaus Schaller wrote: Hi, CEC features are useful to e.g. control HDMI monitor standby

Re: [PATCH 1/5] fbdev/efifb: Use stack memory for screeninfo structs

2024-08-29 Thread Thomas Weißschuh
On 2024-08-28 19:42:51+, Helge Deller wrote: > On 8/27/24 17:25, Thomas Weißschuh wrote: > > These variables are only used inside efifb_probe(). > > Afterwards they are using memory unnecessarily. > > Did you check if this change really saves some memory? Nope... > With your change, the comp

Re: [PATCH] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-29 Thread Boris Brezillon
On Wed, 28 Aug 2024 18:37:41 +0100 Mihail Atanassov wrote: > On 28/08/2024 18:27, Boris Brezillon wrote: > > On Wed, 28 Aug 2024 18:07:03 +0200 > > Boris Brezillon wrote: > > > >> On Wed, 28 Aug 2024 14:22:51 +0100 > >> Mihail Atanassov wrote: > >> > >>> Hi Boris, > >>> > >>> On 28/08/2024

Re: [PATCH] drm/amdgpu: fix OLAND card ip_init failed during kdump caputrue kernel boot

2024-08-29 Thread Lu Yao
On 2024/8/22 22:05, Mario Limonciello wrote: > On 7/23/2024 04:42, Lu Yao wrote: >> [Why] >> When running kdump test on a machine with R7340 card, a hang is caused due >> to the failure of 'amdgpu_device_ip_init()', error message as follows: >> >>'[drm:amdgpu_device_ip_init [amdgpu]] *ERROR* hw

RE: [1/5] drm: Introduce sharpness mode property

2024-08-29 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Nemesa > Garg > Sent: Monday, July 8, 2024 1:39 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Garg, Nemesa > Subject: [1/5] drm: Introduce sharpness mode property > > Introduces the new crtc property "S

Re: [PATCH 4/6] drm/tegra: convert to struct drm_edid

2024-08-29 Thread Thierry Reding
On Thu, Aug 22, 2024 at 08:42:50PM GMT, Jani Nikula wrote: > Prefer the struct drm_edid based functions for reading the EDID and > updating the connector. > > Signed-off-by: Jani Nikula > > --- > > Cc: Thierry Reding > Cc: Mikko Perttunen > Cc: Jonathan Hunter > Cc: linux-te...@vger.kernel.o

Re: [RFC PATCH 04/28] mm/migrate: Add migrate_device_vma_range

2024-08-29 Thread Daniel Vetter
On Tue, Aug 27, 2024 at 07:48:37PM -0700, Matthew Brost wrote: > Add migrate_device_vma_range which prepares an array of pre-populated > device pages for migration and issues a MMU invalidation. > > Cc: Andrew Morton > Signed-off-by: Matthew Brost > --- > include/linux/migrate.h | 3 +++ > mm/

RE: [v4 2/5] drm/i915/display: Compute the scaler filter coefficients

2024-08-29 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Nemesa > Garg > Sent: Monday, July 8, 2024 1:39 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Garg, Nemesa > Subject: [v4 2/5] drm/i915/display: Compute the scaler filter coefficients > > The sharpness

[PATCH] Revert "drm/tegra: gr3d: Convert into dev_pm_domain_attach|detach_list()"

2024-08-29 Thread Thierry Reding
From: Thierry Reding This reverts commit f790b5c09665cab0d51dfcc84832d79d2b1e6c0e. An updated version of patch was applied to the PM tree. Sorry for the mixup. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/gr3d.c | 46 ++-- 1 file changed, 33 insertion

Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-29 Thread Mary Guillemard
On Wed, Aug 28, 2024 at 11:09:09AM +0100, Mihail Atanassov wrote: > Do you have a link you can share with the userspace side of things? Assuming > userland has been reviewed and is ready for merging, and the small nitpick > above fixed, > > Reviewed-by: Mihail Atanassov > > -- > Mihail Atanasso

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-08-29 Thread Thomas Hellström
Hi, Matt. Some initial design comments / questions: On Tue, 2024-08-27 at 19:48 -0700, Matthew Brost wrote: > This patch introduces support for GPU Shared Virtual Memory (SVM) in > the > Direct Rendering Manager (DRM) subsystem. SVM allows for seamless > sharing of memory between the CPU and GPU

[PATCH V4] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-08-29 Thread Carlos Song
Add eDMA mode support for LPI2C. There are some differences between TX DMA mode and RX DMA mode. LPI2C MTDR register is Controller Transmit Data Register. When lpi2c send data, it is tx cmd register and tx data fifo. When lpi2c receive data, it is just a rx cmd register. LPI2C MRDR register is Con

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-08-29 Thread Christian König
Am 28.08.24 um 18:06 schrieb Daniel Vetter: On Tue, Aug 27, 2024 at 07:48:56PM -0700, Matthew Brost wrote: Migration is implemented with range granularity, with VRAM backing being a VM private TTM BO (i.e., shares dma-resv with VM). The lifetime of the TTM BO is limited to when the SVM range is

Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-29 Thread Jani Nikula
On Wed, 28 Aug 2024, Harry Wentland wrote: > On 2024-08-28 09:58, Alex Deucher wrote: >> On Wed, Aug 28, 2024 at 9:53 AM Jani Nikula wrote: >>> >>> On Wed, 28 Aug 2024, Daniel Vetter wrote: On Mon, Aug 12, 2024 at 03:23:12PM +0300, Jani Nikula wrote: > Instead of just smashing jiffies i

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-08-29 Thread Christian König
Am 28.08.24 um 19:25 schrieb Mihail Atanassov: Hello all, This series implements a mechanism to expose Mali CSF GPUs' queue ringbuffers directly to userspace, along with paraphernalia to allow userspace to control job synchronisation between the CPU and GPU. The goal of these changes is to allo

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-08-29 Thread Daniel Vetter
On Tue, Aug 27, 2024 at 07:48:38PM -0700, Matthew Brost wrote: > This patch introduces support for GPU Shared Virtual Memory (SVM) in the > Direct Rendering Manager (DRM) subsystem. SVM allows for seamless > sharing of memory between the CPU and GPU, enhancing performance and > flexibility in GPU c

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-08-29 Thread Thomas Hellström
Hi, Christian, On Thu, 2024-08-29 at 11:24 +0200, Christian König wrote: > ... > > > - Unified eviction is required (SVM VRAM and TTM BOs need to be > > > able to > > >    evict each other). > > So core mm handles this by just roughly equally shrinking > > everything. > > Seems to work, and it

Re: [PATCH] drm: panel-orientation-quirks: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-08-29 Thread Jani Nikula
On Sun, 25 Aug 2024, Hans de Goede wrote: > There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it > turns out that the 2G version has a DMI product name of > "CHERRYVIEW D1 PLATFORM" where as the 4G version has > "CHERRYVIEW C0 PLATFORM". The sys-vendor + product-version check are

Re: [PATCH -next] drm/msm: Use devm_platform_ioremap_resource_byname()

2024-08-29 Thread Dmitry Baryshkov
On Wed, Aug 28, 2024 at 04:48:49PM GMT, Jinjie Ruan wrote: > platform_get_resource_byname() and devm_ioremap_resource() can be > replaced by devm_platform_ioremap_resource_byname(), which can > simplify the code logic a bit, No functional change here. NAK. platform_get_resource_byname gets mdss_p

Re: [RFC PATCH 24/28] drm/xe: Basic SVM BO eviction

2024-08-29 Thread Daniel Vetter
On Tue, Aug 27, 2024 at 07:48:57PM -0700, Matthew Brost wrote: > Wire xe_bo_move to GPUSVM migration to SRAM with trylocking of mmap > lock. > > Signed-off-by: Matthew Brost > --- > drivers/gpu/drm/xe/xe_bo.c | 35 +++- > drivers/gpu/drm/xe/xe_bo_types.h | 3 ++

Re: [PATCH v4 4/5] udmabuf: udmabuf_create codestyle cleanup

2024-08-29 Thread Dan Carpenter
/20240822084342.1574914-5-link%40vivo.com patch subject: [PATCH v4 4/5] udmabuf: udmabuf_create codestyle cleanup config: x86_64-randconfig-161-20240829 (https://download.01.org/0day-ci/archive/20240829/202408291101.waf552sw-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue

[PATCH 00/21] drm/msm: Support quad pipe with dual-DSI

2024-08-29 Thread Jun Nie
mit: 9651fbfb684e7a1288dbae3bf1f15cd484c0217a change-id: 20240829-sm8650-v6-11-hmd-pocf-mdss-quad-upstream-8-d2d6b3eb1d57 Best regards, -- Jun Nie

[PATCH 01/21] drm/msm/dsi: add support to DSI CTRL v2.8.0

2024-08-29 Thread Jun Nie
From: Jonathan Marek Add support to DSI CTRL v2.8.0 with priority support Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 185d7de0bf376..

[PATCH 02/21] drm/msm/dsi: fix DSC width for the bonded DSI case

2024-08-29 Thread Jun Nie
From: Jonathan Marek For the bonded DSI case, DSC pic_width and timing calculations should use the width of a single panel instead of the total combined width. Bonded DSI can be used to drive a single panel having two input channels, or to drive two panels with a input channel on every panel tha

[PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-08-29 Thread Jun Nie
Data width for dsc engine is aligned with pipe, not with whole screen width. Because the width may be halved in DSI bonded case. The dsc width is not related to the timing with back front porch in later stage, so update dsc timing earlier. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_

[PATCH 04/21] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2024-08-29 Thread Jun Nie
From: Jonathan Marek MSM display controller support multiple slice to be sent in a single DSC packet. Add a dsc_slice_per_pkt field to mipi_dsi_device struct and support this field in msm mdss driver. Note that the removed "pkt_per_line = slice_per_intf * slice_per_pkt" comment is incorrect. Si

[PATCH 05/21] drm/msm/dpu: polish log for resource allocation

2024-08-29 Thread Jun Nie
Add resource allocation type info. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c index 15b42a6683639..

[PATCH 06/21] drm/msm/dpu: Add utility to get mixer number

2024-08-29 Thread Jun Nie
Add utility to get mixer number via CRTC handler Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 5 + 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/di

[PATCH 07/21] drm/msm/dpu: Support dynamic DSC number

2024-08-29 Thread Jun Nie
Do not assume DSC number as 2. Because there are 4 DSC in quad pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dp

[PATCH 08/21] drm/msm/dpu: decide right side per last bit

2024-08-29 Thread Jun Nie
in case of multiple mixer pairs Signed-off-by: Jun Nie Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index a

[PATCH 09/21] drm/msm/dpu: request more mixer for 4K+ DSC case

2024-08-29 Thread Jun Nie
request more mixer for the case that hdisplay exceeding 4096 and DSC enabled. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/driver

[PATCH 10/21] drm/msm/dpu: fix lm number counter for quad-pipe

2024-08-29 Thread Jun Nie
Add the case to reserve multiple pair mixer for high resolution Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 8 +++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dp

[PATCH 11/21] drm/msm/dpu: Support 4 mixers at most

2024-08-29 Thread Jun Nie
Support 4 mixers case with increasing array size and checking the usage case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 3 ++- drivers/gpu/drm

[PATCH 12/21] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2024-08-29 Thread Jun Nie
Up to now the driver has been using encoder to allocate hardware resources. Switch it to use CRTC id so that mixer number can be known in dpu_plane_virtual_assign_resources() via CRTC id for sspp alloation. Because the mixer allocation is done in drm_atomic_helper_check_modeset() as part of CRTC o

[PATCH 13/21] drm/msm/dpu: Support quad pipe in header files

2024-08-29 Thread Jun Nie
Support 4 pipes and their configs at most. They are for 2 SSPP and their multi-rect mode. Because one SSPP can co-work with 2 mixer at most, 2 pair of mixer are needed for 2 SSPP in quad- pipe case. So 2 mixer configs are needed in quad-pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/d

[PATCH 14/21] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-08-29 Thread Jun Nie
Support quad-pipe in SSPP checking with unified method Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 108 ++ 1 file changed, 51 insertions(+), 57 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/

[PATCH 15/21] drm/msm/dpu: support plane splitting in quad-pipe case

2024-08-29 Thread Jun Nie
Clip plane into SSPPs per left and right half screen per ROI if topology is quad pipe. Then split the split rectangle by half if the clip width still exceed limit. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 97 ++- 1 file changed, 71 insert

[PATCH 16/21] drm/msm/dpu: support SSPP assignment for quad-pipe case

2024-08-29 Thread Jun Nie
Support SSPP assignment for quad-pipe case with unified method Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 58 +-- 1 file changed, 25 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/m

[PATCH 17/21] drm/msm/dpu: setup pipes with 2 set of stage config

2024-08-29 Thread Jun Nie
The first 2 fields in multirect_index and stage array are for the first SSPP and its multi-rect. And the later 2 fields are for the 2nd SSPP and its multi-rect. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 76 +++- 1 file changed, 55 insertion

[PATCH 18/21] drm/msm/dpu: blend pipes by left and right

2024-08-29 Thread Jun Nie
Blend pipes by left and right. The first 2 pipes are for left half screen and the later 2 pipes are for right in quad pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 13 +++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 +++--- drivers/gpu/drm

[PATCH 19/21] drm/msm/dpu: bind correct pingpong for quad pipe

2024-08-29 Thread Jun Nie
There are 2 interface and 4 PP in quad pipe. Map the 2nd interface to 3rd PP instead of the 2nd PP. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

[PATCH 20/21] drm/msm/dpu: support quad pipe in general operations

2024-08-29 Thread Jun Nie
Support quad pipe in general operations with unified method. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 87 +-- 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm

[PATCH 21/21] drm/msm/dpu: revise debug info to support quad pipe

2024-08-29 Thread Jun Nie
Unify debug info to support dual pipe and quad pipe Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 16 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 35 +-- 2 files changed, 21 insertions(+), 30 deletions(-) diff --git a/drivers/g

TTM pinning and LRU lists

2024-08-29 Thread Thomas Hellström
Hi, Christian, I noticed that calling ttm_bo_pin() doesn't seem to move the resource to the pinned list, but keeping it on its manager's LRU. Is it the driver's responsibility to call ttm_bo_move_to_lru_tail() to move it to the pinned list after pinning? /Thomas

Re: [PATCH 01/21] drm/msm/dsi: add support to DSI CTRL v2.8.0

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > From: Jonathan Marek > > Add support to DSI CTRL v2.8.0 with priority support Proper description is missing > > Signed-off-by: Jun Nie Several tags are missing here. Also, how is this patch related to quadpipe? > --- > drivers/gpu/drm/msm/ds

Re: [PATCH 02/21] drm/msm/dsi: fix DSC width for the bonded DSI case

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > From: Jonathan Marek > > For the bonded DSI case, DSC pic_width and timing calculations should use > the width of a single panel instead of the total combined width. What is a "single panel"? Please rephrase the commit message so that it reads log

Re: [PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > Data width for dsc engine is aligned with pipe, not with whole screen > width. Because the width may be halved in DSI bonded case. Can't really parse this. > > The dsc width is not related to the timing with back front porch in > later stage, so u

Re: [PATCH 1/2] drm/panel: visionox-vtdr6130: switch to mipi_dsi wrapped functions

2024-08-29 Thread Neil Armstrong
On 28/08/2024 18:32, Doug Anderson wrote: Hi, On Wed, Aug 28, 2024 at 9:03 AM Neil Armstrong wrote: Make usage of the new _multi() mipi_dsi functions instead of the deprecated macros, improving error handling and printing. bloat-o-meter gives a 12% gain on arm64: Function

Re: [PATCH v2] drm/panel: novatek-nt35950: transition to mipi_dsi wrapped functions

2024-08-29 Thread neil . armstrong
On 28/08/2024 21:26, Doug Anderson wrote: Hi, On Wed, Aug 28, 2024 at 11:26 AM Tejas Vipin wrote: Changes the novatek-nt35950 panel to use multi style functions for improved error handling. Reviewed-by: Neil Armstrong Signed-off-by: Tejas Vipin --- Changes in v2: - Style changes

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-08-29 Thread Daniel Vetter
On Thu, Aug 29, 2024 at 11:53:58AM +0200, Thomas Hellström wrote: > But as Sima pointed out in private communication, exhaustive eviction > is not really needed for faulting to make (crawling) progress. > Watermarks and VRAM trylock shrinking should suffice, since we're > strictly only required to

Re: [PATCH 04/21] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > From: Jonathan Marek > > MSM display controller support multiple slice to be sent in a single DSC > packet. This is not MSM-specific. It is allowed per the standard. > Add a dsc_slice_per_pkt field to mipi_dsi_device struct and > support this fie

Re: [PATCH 05/21] drm/msm/dpu: polish log for resource allocation

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > Add resource allocation type info. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 23 +++ > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c

Re: [PATCH 06/21] drm/msm/dpu: Add utility to get mixer number

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > Add utility to get mixer number via CRTC handler > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +++ > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 5 + > 2 files changed, 12 insertions(+) > > diff --git a/dr

Re: [PATCH 07/21] drm/msm/dpu: Support dynamic DSC number

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > Do not assume DSC number as 2. Because there are 4 DSC in > quad pipe case. Please expand the commit message. You prefer brevity, but your comments lack clarifications. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder

Re: [PATCH 09/21] drm/msm/dpu: request more mixer for 4K+ DSC case

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > request more mixer for the case that hdisplay exceeding 4096 > and DSC enabled. This doesn't seem to match the code. And it misses the _reason_ to do it. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 24 +++

Re: [PATCH 10/21] drm/msm/dpu: fix lm number counter for quad-pipe

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > Add the case to reserve multiple pair mixer for high resolution I think you already know what is missing here. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c

Re: [PATCH 0/2] drm/panel: annual cleanup of visionox vtdr6130 driver

2024-08-29 Thread Neil Armstrong
Hi, On Wed, 28 Aug 2024 18:03:38 +0200, Neil Armstrong wrote: > Switch to _multi() dsi functions and devm_regulator_bulk_get_const() > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/2] drm/panel: visionox-vtdr6130: switch to mipi_dsi wrapped functio

Re: [PATCH v2] drm/panel: novatek-nt35950: transition to mipi_dsi wrapped functions

2024-08-29 Thread Neil Armstrong
Hi, On Wed, 28 Aug 2024 23:52:10 +0530, Tejas Vipin wrote: > Changes the novatek-nt35950 panel to use multi style functions for > improved error handling. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/panel: novatek-nt35950: transition to

Re: [PATCH] drm/panel: nv3051d: Transition to mipi_dsi_dcs_write_seq_multi

2024-08-29 Thread Neil Armstrong
Hi, On Tue, 27 Aug 2024 20:55:04 +0530, Abhishek Tamboli wrote: > Replace deprecated 'mipi_dsi_dcs_write_seq()' macro > to 'mipi_dsi_dcs_write_seq_multi' macro in > panel_nv3051d_init_sequence function. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

Re: [PATCH 13/21] drm/msm/dpu: Support quad pipe in header files

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > Support 4 pipes and their configs at most. They are for 2 SSPP > and their multi-rect mode. Because one SSPP can co-work with > 2 mixer at most, 2 pair of mixer are needed for 2 SSPP in quad- > pipe case. So 2 mixer configs are needed in quad-pipe c

Re: [PATCH 14/21] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:21, Jun Nie wrote: > > Support quad-pipe in SSPP checking with unified method > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 108 > ++ > 1 file changed, 51 insertions(+), 57 deletions(-) > > diff --git a/drive

Re: [PATCH 4/6] drm/tegra: convert to struct drm_edid

2024-08-29 Thread Jani Nikula
On Thu, 29 Aug 2024, Thierry Reding wrote: > On Thu, Aug 22, 2024 at 08:42:50PM GMT, Jani Nikula wrote: >> Prefer the struct drm_edid based functions for reading the EDID and >> updating the connector. >> >> Signed-off-by: Jani Nikula >> >> --- >> >> Cc: Thierry Reding >> Cc: Mikko Perttunen

Re: [PATCH 0/6] drm: conversions to struct drm_edid

2024-08-29 Thread Jani Nikula
On Thu, 22 Aug 2024, Jani Nikula wrote: > The umerged patches from [1] and then some. > > BR, > Jani. > > [1] https://lore.kernel.org/r/cover.1715691257.git.jani.nik...@intel.com > > Jani Nikula (6): > drm/sti/sti_hdmi: convert to struct drm_edid > drm/tegra: convert to struct drm_edid > drm

Re: [PATCH 18/21] drm/msm/dpu: blend pipes by left and right

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:21, Jun Nie wrote: > > Blend pipes by left and right. The first 2 pipes are for > left half screen and the later 2 pipes are for right in quad > pipe case. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 13 +++-- > drivers/gpu/d

Re: [PATCH v2 09/12] dt-bindings: watchdog: Add rockchip,rk3576-wdt compatible

2024-08-29 Thread Heiko Stübner
Hi Guenter, Am Dienstag, 27. August 2024, 21:38:35 CEST schrieb Guenter Roeck: > On 8/27/24 00:20, Heiko Stübner wrote: > > Am Samstag, 24. August 2024, 18:44:29 CEST schrieb Guenter Roeck: > >> On Fri, Aug 23, 2024 at 10:52:36AM -0400, Detlev Casanova wrote: > >>> It is compatible with the other

Re: [PATCH RFC 2/2] pmdomain: ti-sci: Support retaining PD boot time state

2024-08-29 Thread Tomi Valkeinen
Hi Ulf, On 03/05/2024 16:45, Ulf Hansson wrote: + Abel, Saravanna, Stephen On Mon, 15 Apr 2024 at 19:17, Tomi Valkeinen wrote: On 15/04/2024 19:00, Tomi Valkeinen wrote: Add a new flag, TI_SCI_PD_KEEP_BOOT_STATE, which can be set in the dts when referring to power domains. When this flag is

Re: [PATCH 20/21] drm/msm/dpu: support quad pipe in general operations

2024-08-29 Thread Dmitry Baryshkov
On Thu, 29 Aug 2024 at 13:21, Jun Nie wrote: > > Support quad pipe in general operations with unified method. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 87 > +-- > 1 file changed, 47 insertions(+), 40 deletions(-) > > diff --git a

Re: [PATCH] drm/meson: switch to a managed drm device

2024-08-29 Thread Neil Armstrong
Hi, On 28/08/2024 13:04, Anastasia Belova wrote: Switch to a managed drm device to cleanup some error handling and make future work easier. Fix dereference of NULL in meson_drv_bind_master by removing drm_dev_put(drm) before meson_encoder_*_remove where drm dereferenced. Please send the fix s

Re: [PATCH 00/21] drm/msm: Support quad pipe with dual-DSI

2024-08-29 Thread Dmitry Baryshkov
--- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 19 +- > drivers/gpu/drm/msm/dsi/dsi.h| 3 +- > drivers/gpu/drm/msm/dsi/dsi_host.c | 54 ++-- > drivers/gpu/drm/msm/dsi/dsi_manager.c| 2 +- > include/drm/drm_mipi_dsi.h

Re: [PATCH 1/4] drm/sched: add optional errno to drm_sched_start()

2024-08-29 Thread Alex Deucher
On Mon, Aug 26, 2024 at 8:35 AM Christian König wrote: > > The current implementation of drm_sched_start uses a hardcoded > -ECANCELED to dispose of a job when the parent/hw fence is NULL. > This results in drm_sched_job_done being called with -ECANCELED for > each job with a NULL parent in the pe

[PATCH v5 01/10] drm/v3d: Fix the MMU flush order

2024-08-29 Thread Maíra Canal
We must first flush the MMU cache and then, flush the TLB, not the other way around. Currently, we can see a race condition between the MMU cache and the TLB when running multiple rendering processes at the same time. This is evidenced by MMU errors triggered by the IRQ. Fix the MMU flush order by

[PATCH v5 02/10] drm/v3d: Flush the MMU before we supply more memory to the binner

2024-08-29 Thread Maíra Canal
We must ensure that the MMU is flushed before we supply more memory to the binner, otherwise we might end up with invalid MMU accesses by the GPU. Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_drv.h | 1

[PATCH v5 00/10] drm/v3d: Enable Big and Super Pages

2024-08-29 Thread Maíra Canal
This series introduces support for big and super pages in V3D. The V3D MMU has support for 64KB and 1MB pages, called big pages and super pages, which are currently not used. Therefore, this patchset has the intention to enable big and super pages in V3D. The advantage of enabling big and super pag

[PATCH v5 03/10] drm/v3d: Fix return if scheduler initialization fails

2024-08-29 Thread Maíra Canal
If the scheduler initialization fails, GEM initialization must fail as well. Therefore, if `v3d_sched_init()` fails, free the DMA memory allocated and return the error value in `v3d_gem_init()`. Signed-off-by: Maíra Canal Reviewed-by: Iago Toral Quiroga --- drivers/gpu/drm/v3d/v3d_gem.c | 3 ++-

[PATCH v5 04/10] drm/gem: Create a drm_gem_object_init_with_mnt() function

2024-08-29 Thread Maíra Canal
For some applications, such as applications that uses huge pages, we might want to have a different mountpoint, for which we pass mount flags that better match our usecase. Therefore, create a new function `drm_gem_object_init_with_mnt()` that allow us to define the tmpfs mountpoint where the GEM

[PATCH v5 05/10] drm/v3d: Introduce gemfs

2024-08-29 Thread Maíra Canal
Create a separate "tmpfs" kernel mount for V3D. This will allow us to move away from the shmemfs `shm_mnt` and gives the flexibility to do things like set our own mount options. Here, the interest is to use "huge=", which should allow us to enable the use of THP for our shmem-backed objects. Signe

[PATCH v5 06/10] drm/gem: Create shmem GEM object in a given mountpoint

2024-08-29 Thread Maíra Canal
Create a function `drm_gem_shmem_create_with_mnt()`, similar to `drm_gem_shmem_create()`, that has a mountpoint as a argument. This function will create a shmem GEM object in a given tmpfs mountpoint. This function will be useful for drivers that have a special mountpoint with flags enabled. Sign

[PATCH v5 07/10] drm/v3d: Reduce the alignment of the node allocation

2024-08-29 Thread Maíra Canal
Currently, we are using an alignment of 128 kB to insert a node, which ends up wasting memory as we perform plenty of small BOs allocations (<= 4 kB). We require that allocations are aligned to 128Kb so for any allocation smaller than that, we are wasting the difference. This implies that we canno

[PATCH v5 08/10] drm/v3d: Support Big/Super Pages when writing out PTEs

2024-08-29 Thread Maíra Canal
The V3D MMU also supports 64KB and 1MB pages, called big and super pages, respectively. In order to set a 64KB page or 1MB page in the MMU, we need to make sure that page table entries for all 4KB pages within a big/super page must be correctly configured. In order to create a big/super page, we n

[PATCH v5 09/10] drm/v3d: Use gemfs/THP in BO creation if available

2024-08-29 Thread Maíra Canal
Although Big/Super Pages could appear naturally, it would be quite hard to have 1MB or 64KB allocated contiguously naturally. Therefore, we can force the creation of large pages allocated contiguously by using a mountpoint with "huge=within_size" enabled. Therefore, as V3D has a mountpoint with "h

[PATCH v5 10/10] drm/v3d: Add modparam for turning off Big/Super Pages

2024-08-29 Thread Maíra Canal
Add a modparam for turning off Big/Super Pages to make sure that if an user doesn't want Big/Super Pages enabled, it can disabled it by setting the modparam to false. Signed-off-by: Maíra Canal Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/v3d/v3d_drv.c | 7 +++ drivers/gpu/drm/v3d/v3d_

Re: [PATCH 3/3] drm/vkms: Add documentation

2024-08-29 Thread Louis Chauvet
Le 19/08/24 - 17:07, José Expósito a écrit : > Hi Louis, > > Thanks for this patch, adding some minor review comments: > > > Add documentation around vkms_output and its initialization. > > > > Signed-off-by: Louis Chauvet > > --- > > drivers/gpu/drm/vkms/vkms_drv.h| 81 > > ++

Re: [PATCH v2] drm/vkms: Add documentation

2024-08-29 Thread Louis Chauvet
Le 27/08/24 - 19:49, José Expósito a écrit : > Hi Louis, > > > Add documentation around vkms_output and its initialization. > > > > Signed-off-by: Louis Chauvet > > --- > > This series does not introduce functionnal changes, only some > > documentation and renaming to clarify the code. > > --- >

[PATCH v3] drm/vkms: Add documentation

2024-08-29 Thread Louis Chauvet
Add documentation around vkms_output and its initialization. Add some documentation on pixel conversion functions. Update of outdated comments for pixel_write functions. Signed-off-by: Louis Chauvet --- This series does not introduce functionnal changes, only some documentation and renaming to cl

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-08-29 Thread Steven Price
Hi Christian, Mihail should be able to give more definitive answers, but I think I can answer your questions. On 29/08/2024 10:40, Christian König wrote: > Am 28.08.24 um 19:25 schrieb Mihail Atanassov: >> Hello all, >> >> This series implements a mechanism to expose Mali CSF GPUs' queue >> ringb

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-08-29 Thread Ketil Johnsen
On 29/08/2024 11:40, Christian König wrote: Am 28.08.24 um 19:25 schrieb Mihail Atanassov: Hello all, This series implements a mechanism to expose Mali CSF GPUs' queue ringbuffers directly to userspace, along with paraphernalia to allow userspace to control job synchronisation between the CPU a

Re: drm: renesas: shmobile: Add drm_panic support

2024-08-29 Thread Geert Uytterhoeven
Hi Sui, On Wed, May 29, 2024 at 1:31 PM Sui Jingfeng wrote: > On 5/27/24 21:34, Geert Uytterhoeven wrote: > > Add support for the drm_panic module, which displays a message on > > the screen when a kernel panic occurs. > > > > Signed-off-by: Geert Uytterhoeven > > Reviewed-by: Jocelyn Falempe >

Re: [PATCH v2] drm: rcar-du: Fix memory leak in rcar_du_vsps_init()

2024-08-29 Thread Laurent Pinchart
On Wed, Aug 28, 2024 at 07:21:32AM +, Biju Das wrote: > On Tuesday, August 27, 2024 11:23 PM, Laurent Pinchart wrote: > > Subject: Re: [PATCH v2] drm: rcar-du: Fix memory leak in rcar_du_vsps_init() > > > > Hi Biju, > > > > On Tue, Aug 27, 2024 at 04:43:12PM +, Biju Das wrote: > > > Hi La

Re: [PATCH] drm: renesas: shmobile: Add drm_panic support

2024-08-29 Thread Geert Uytterhoeven
On Thu, May 30, 2024 at 10:33 AM Dmitry Baryshkov wrote: > On Thu, 30 May 2024 at 11:16, Jocelyn Falempe wrote: > > On 29/05/2024 15:33, Laurent Pinchart wrote: > > > On Wed, May 29, 2024 at 04:28:44PM +0300, Dmitry Baryshkov wrote: > > >> On Wed, May 29, 2024 at 12:55:06PM +0300, Laurent Pinchar

[PULL] drm-xe-fixes

2024-08-29 Thread Rodrigo Vivi
Hi Dave and Sima, A quiet week this time. Thanks, Rodrigo. drm-xe-fixes-2024-08-29: - Invalidate media_gt TLBs (Brost) - Fix HWMON i1 power setup write command (Karthik) The following changes since commit 5be63fc19fcaa4c236b307420483578a56986a37: Linux 6.11-rc5 (2024-08-25 19:07:11 +1200) a

[PULL] drm-intel-next

2024-08-29 Thread Rodrigo Vivi
Hi Sima and Dave, Here goes our last PR of drm-intel-next towards 6.12. Most of it is display related clean-up towards intel_display isolation. But there are 2 cases that worth mention. 1. Xe core changes for BMG. BMG requires, by design, 64k memory size alignment for scanout buffers using compr

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-08-29 Thread Christian König
Am 29.08.24 um 11:53 schrieb Thomas Hellström: Hi, Christian, On Thu, 2024-08-29 at 11:24 +0200, Christian König wrote: ... - Unified eviction is required (SVM VRAM and TTM BOs need to be able to    evict each other). So core mm handles this by just roughly equally shrinking everything. S

Re: [PATCH] Revert "drm/tegra: gr3d: Convert into dev_pm_domain_attach|detach_list()"

2024-08-29 Thread Ulf Hansson
On Thu, 29 Aug 2024 at 11:09, Thierry Reding wrote: > > From: Thierry Reding > > This reverts commit f790b5c09665cab0d51dfcc84832d79d2b1e6c0e. An updated > version of patch was applied to the PM tree. Sorry for the mixup. > > Signed-off-by: Thierry Reding If not too late, feel free to add: Ack

Re: TTM pinning and LRU lists

2024-08-29 Thread Christian König
Hi Thomas, that got removed at some point because it cause a problem, but I really can't remember what it was. Need to dig through the git logs and mailing list. I wouldn't mind adding it back, IIRC removing it was one of those temporary workarounds which became a long term solution because

[PULL] drm-misc-next

2024-08-29 Thread Thomas Zimmermann
Hi Dave, Sima, here's the PR for drm-misc-next for this week. There's one major change where DRM can now use minor device numbers up to the limit set by MINORBITS. Best regards Thomas drm-misc-next-2024-08-29: drm-misc-next for v6.12: UAPI Changes: devfs: - support device numbers up to MINORBI

[PULL] drm-misc-fixes

2024-08-29 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-08-29: A revert for a previous TTM commit causing stuttering, 3 fixes for vmwgfx related to buffer operations, a fix for video/aperture with non-VGA primary devices, and a preemption status fix for v3d The following changes since

Re: [PATCH v8] drm/mediatek: dsi: Add dsi per-frame lp code for mt8188

2024-08-29 Thread Chun-Kuang Hu
Hi, Shuijing: Shuijing Li 於 2024年8月26日 週一 下午2:07寫道: > > Adding the per-frame lp function of mt8188, which can keep HFP in HS and > reduce the time required for each line to enter and exit low power. > Per Frame LP: > |<--One Active Frame>| > --___

  1   2   >