On 28/08/2024 21:41, H. Nikolaus Schaller wrote: > Hi all, > >> Am 28.08.2024 um 16:14 schrieb Hans Verkuil <hverkuil-ci...@xs4all.nl>: >> >> On 28/08/2024 15:57, Tomi Valkeinen wrote: >>> Hi, >>> >>> On 25/08/2024 23:31, H. Nikolaus Schaller wrote: >>>> Hi, >>>> CEC features are useful to e.g. control HDMI monitor standby. >>>> >>>> But I wonder what happened to this series? >>>> >>>> I could find some reviewed-by: and acked-by: in [1] but it wasn't merged >>>> upstream >>>> for unidentifiable reasons. >>>> >>>> We apparently had merged this series some years ago into our LetuxOS >>>> distro kernel >>>> and now we found it to be broken (NULL dereference) at least for omap5uevm >>>> (and likely Pyra Handheld) after rebasing to v6.11-rc (it was already >>>> broken >>>> since v6.9-rc1). Fixes were not difficult, but it would be better if it >>>> were >>>> part of upstream. >>> >>> There was a v3: >>> >>> 20210428132545.1205162-1-hverkuil-ci...@xs4all.nl > > [A clickable link is here: > https://lore.kernel.org/linux-media/20210428132545.1205162-1-hverkuil-ci...@xs4all.nl/ > ] > > Ah, I see. It wasn't sent to linux-omap so I didn't recognise/find it in my > mails > or omap-patchwork. > > >>> I see there was a concern from Laurent in: >>> >>> yljmzix71mcqn...@pendragon.ideasonboard.com > > Well, he didn't reject it although he had concerns, but I am not experienced > with what > he is talking about for a proper solution... > >>> >>> And we need an ack from the bridge maintainers for the drm_bridge parts. >>> But the series is three years old, so I think someone would have to rebase >>> on top of mainline and re-test and re-send first. >> >> I never really followed up with this. I still have the hardware, it is >> primarily >> time. And also that for me this is quite low priority since I don't use >> omap5. >> >> If someone wants to refresh this series and post it, then I would have no >> problem >> with it. > > A far as I see it just needs a rebase - I guess on linux-next (or drm-misc?) > and some > compile fixes I already have implemented for our distro kernel. > > So if you agree I could work on it, test on omap4&5 and submit a v4 and hope > that you > can jump in and support for the discussion. I would keep you (Hans) as commit > author > and just add a signed-off: and tested-by:
That would be fine. For what it is worth, the last version I have is this one from 3 years ago: https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=omap-bridge-cec I haven't looked at it since. Regards, Hans > > But I will also need some time... > > BR and thanks, > Nikolaus >