[PATCH 0/1] Filter modes according to hardware capability

2024-01-16 Thread Hsiao Chien Sung
From: Hsiao Chien Sung This series is based on mediatek-drm-next branch of kernel/git/chunkuang.hu/linux.git Hsiao Chien Sung (1): drm/mediatek: Filter modes according to hardware capability drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 + drivers/gpu/drm/mediatek/mtk_disp_ovl.c |

[PATCH 1/1] drm/mediatek: Filter modes according to hardware capability

2024-01-16 Thread Hsiao Chien Sung
From: Hsiao Chien Sung We found that there is a stability issue on MT8188 when connecting an external monitor in 2560x1440@144Hz mode. Checked with the designer, there is a function called hardware prefetch that is triggered by VSYNC and ended before VDE (during VBP). If duration of VBP is too sh

[PATCH 00/42] Fix coccicheck warnings

2024-01-16 Thread Li Zhijian
make coccicheck COCCI=$PWD/scripts/coccinelle/api/device_attr_show.cocci` complians some warnnings as following[1]: Not sure if someone had tried these fixes, feel free to ignore this patch set if we have come to a *NOT-FIX* conclusion before :) This patch set also fix a few snprintf() beside coc

[PATCH] drm/ttm: only use DMA32 if needed for dummy_read_page

2024-01-16 Thread Yangyu Chen
Some platforms may not have any memory in ZONE_DMA32 and use IOMMU to allow 32-bit-DMA-only device to work. Forcing GFP_DMA32 on dummy_read_page will fail in such platforms. Only use DMA32 when it must to get the bug resolved. Signed-off-by: Yangyu Chen --- drivers/gpu/drm/ttm/ttm_device.c | 7 +

[PATCH 41/42] drivers/video/fbdev/uvesafb: Convert snprintf to sysfs_emit

2024-01-16 Thread Li Zhijian
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). > ./drivers/video/fbdev/uvesafb.c:1549:8-16:

RE: [PATCH v2 2/2] gpu: drm: bridge: cadence: Add a driver and platform ops for StarFive JH7110 SoC

2024-01-16 Thread Shengyang Chen
Hi, Philipp Thanks for review and comment. > -Original Message- > From: Philipp Zabel > Sent: 2024年1月9日 17:08 > To: Shengyang Chen ; > devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org > Cc: andrzej.ha...@intel.com; neil.armstr...@linaro.org; rf...@kernel.org; > laurent.pinch..

RE: [PATCH v2 1/2] dt-bindings: display: bridge: cdns: Add properties to support StarFive JH7110 SoC

2024-01-16 Thread Shengyang Chen
Hi, Krzysztof Thanks for review and comment. > -Original Message- > From: Krzysztof Kozlowski > Sent: 2024年1月11日 5:06 > To: Shengyang Chen ; > devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org > Cc: andrzej.ha...@intel.com; neil.armstr...@linaro.org; rf...@kernel.org; > laurent

Re: [PATCH 0/2] drm/bridge: sii902x: Crash fixes

2024-01-16 Thread Neil Armstrong
Hi, On Wed, 03 Jan 2024 15:31:06 +0200, Tomi Valkeinen wrote: > Two small fixes to sii902x for crashes. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) [1/2] drm/bridge: sii902x: Fix probing race issue https://cgit.freedesktop.org/drm/drm-mi

Re: [PATCH] drm/panel: novatek-nt36672e: Include

2024-01-16 Thread neil . armstrong
On 16/01/2024 08:18, Ritesh Kumar wrote: Include instead of to fix below compilation errors: drivers/gpu/drm/panel/panel-novatek-nt36672e.c:564:14: error: implicit declaration of function 'of_device_get_match_data' ctx->desc = of_device_get_match_data(dev); ^ drivers/gpu/drm

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

2024-01-16 Thread Devarsh Thakkar
Hi Conor, Thanks for the review. On 15/01/24 21:47, Conor Dooley wrote: > On Mon, Jan 15, 2024 at 06:27:15PM +0530, Devarsh Thakkar wrote: >> TI keystone display subsystem present in AM65 and other SoCs such as AM62 > > Do all 3 SoCs supported by this binding (am625 am62a7 am65x) have this > com

RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support

2024-01-16 Thread Shengyang Chen
Hi, Neil Thanks for your comment. > -Original Message- > From: neil.armstr...@linaro.org > Sent: 2024年1月9日 19:19 > To: Shengyang Chen ; > devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org > Cc: quic_jessz...@quicinc.com; s...@ravnborg.org; airl...@gmail.com; > dan...@ffwll.ch;

Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support

2024-01-16 Thread neil.armstr...@linaro.org
On 16/01/2024 10:32, Shengyang Chen wrote: Hi, Neil Thanks for your comment. -Original Message- From: neil.armstr...@linaro.org Sent: 2024年1月9日 19:19 To: Shengyang Chen ; devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org Cc: quic_jessz...@quicinc.com; s...@ravnborg.org; airl

RE: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel

2024-01-16 Thread Shengyang Chen
Hi, Conor Thanks for comment. > -Original Message- > From: Conor Dooley > Sent: 2024年1月10日 0:32 > To: Shengyang Chen > Cc: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > neil.armstr...@linaro.org; quic_jessz...@quicinc.com; s...@ravnborg.org; > airl...@gmail.com; dan...@

RE: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel

2024-01-16 Thread Shengyang Chen
> -Original Message- > From: neil.armstr...@linaro.org > Sent: 2024年1月10日 17:06 > To: Conor Dooley ; Shengyang Chen > > Cc: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > quic_jessz...@quicinc.com; s...@ravnborg.org; airl...@gmail.com; > dan...@ffwll.ch; maarten.lankho..

Re: [DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

2024-01-16 Thread Conor Dooley
On Tue, Jan 16, 2024 at 02:48:53PM +0530, Devarsh Thakkar wrote: > Hi Conor, > > Thanks for the review. > > On 15/01/24 21:44, Conor Dooley wrote: > > On Mon, Jan 15, 2024 at 06:27:16PM +0530, Devarsh Thakkar wrote: > >> This adds common1 register space for AM62x and AM65x SoC's which are using >

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

2024-01-16 Thread Conor Dooley
On Tue, Jan 16, 2024 at 02:43:25PM +0530, Devarsh Thakkar wrote: > Hi Conor, > > Thanks for the review. > > On 15/01/24 21:47, Conor Dooley wrote: > > On Mon, Jan 15, 2024 at 06:27:15PM +0530, Devarsh Thakkar wrote: > >> TI keystone display subsystem present in AM65 and other SoCs such as AM62 >

RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support

2024-01-16 Thread Shengyang Chen
Hi, Stefan Thanks for your comment and suggestion. > -Original Message- > From: Stefan Wahren > Sent: 2024年1月10日 1:22 > To: neil.armstr...@linaro.org; Shengyang Chen > ; devicet...@vger.kernel.org; > dri-devel@lists.freedesktop.org > Cc: quic_jessz...@quicinc.com; s...@ravnborg.org; airl

Re: [PATCH] drm/ttm: only use DMA32 if needed for dummy_read_page

2024-01-16 Thread Christian König
Am 16.01.24 um 08:24 schrieb Yangyu Chen: Some platforms may not have any memory in ZONE_DMA32 and use IOMMU to allow 32-bit-DMA-only device to work. Forcing GFP_DMA32 on dummy_read_page will fail in such platforms. Only use DMA32 when it must to get the bug resolved. Well that makes no sense.

Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async

2024-01-16 Thread Pekka Paalanen
On Tue, 16 Jan 2024 01:51:57 -0300 André Almeida wrote: > Hi, > > AMD hardware can do more on the async flip path than just the primary plane, > so > to lift up the current restrictions, this patchset allows drivers to write > their > own check for planes for async flips. Hi, what's the user

Re: [PATCH 0/2] drm/bridge: sii902x: Crash fixes

2024-01-16 Thread Aradhya Bhatia
On 03/01/24 19:01, Tomi Valkeinen wrote: > Two small fixes to sii902x for crashes. > > Signed-off-by: Tomi Valkeinen > --- > Tomi Valkeinen (2): > drm/bridge: sii902x: Fix probing race issue > drm/bridge: sii902x: Fix audio codec unregistration Stress-tested kernel boot on SK-AM62

RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support

2024-01-16 Thread Shengyang Chen
Hi, Dave Thanks for your comment > -Original Message- > From: Dave Stevenson > Sent: 2024年1月10日 1:29 > To: neil.armstr...@linaro.org > Cc: Shengyang Chen ; > devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > quic_jessz...@quicinc.com; s...@ravnborg.org; airl...@gmail.com; >

[PATCH v2 1/7] drm/ci: arm64.config: Enable CONFIG_DRM_ANALOGIX_ANX7625

2024-01-16 Thread Vignesh Raman
Enable CONFIG_DRM_ANALOGIX_ANX7625 in the arm64 defconfig to get display driver probed on the mt8183-kukui-jacuzzi-juniper machine. arch/arm64/configs/defconfig has CONFIG_DRM_ANALOGIX_ANX7625=m, but drm-ci don't have initrd with modules, so add CONFIG_DRM_ANALOGIX_ANX7625=y in CI arm64 config. S

[PATCH v2 3/7] drm/ci: mediatek: Add job to test panfrost and powervr GPU driver

2024-01-16 Thread Vignesh Raman
For mediatek mt8173, the GPU driver is powervr and for mediatek mt8183, the GPU driver is panfrost. So add support in drm-ci to test panfrost and powervr GPU driver for mediatek SOCs and update xfails. Powervr driver was merged in linux kernel, but there's no mediatek support yet. So disable the mt

[PATCH v2 5/7] drm/ci: meson: Add job to test panfrost GPU driver

2024-01-16 Thread Vignesh Raman
For amlogic meson SOC the GPU driver is panfrost. So add support in drm-ci to test panfrost driver for amlogic meson SOC and update xfails. Signed-off-by: Vignesh Raman --- v2: - Add panfrost GPU jobs for amlogic meson SOC with new xfails. --- drivers/gpu/drm/ci/test.yml

[PATCH v2 0/7] drm/ci: Add support for GPU and display testing

2024-01-16 Thread Vignesh Raman
Some ARM SOCs have a separate display controller and GPU, each with different drivers. For mediatek mt8173, the GPU driver is powervr, and the display driver is mediatek. In the case of mediatek mt8183, the GPU driver is panfrost, and the display driver is mediatek. With rockchip rk3288/rk3399, the

[PATCH v2 6/7] drm/ci: rockchip: Rename existing job

2024-01-16 Thread Vignesh Raman
For rockchip rk3288 and rk3399, the display driver is rockchip. Currently, in drm-ci for rockchip, only the display driver is tested. So rename the rockchip job to indicate that display driver is tested. Rename the name of xfail files for rockchip (rk3288 and rk3399), to include information about

[PATCH v2 7/7] drm/ci: rockchip: Add job to test panfrost GPU driver

2024-01-16 Thread Vignesh Raman
For rockchip rk3288 and rk3399, the GPU driver is panfrost. So add support in drm-ci to test panfrost driver for rockchip SOC and update xfails. Signed-off-by: Vignesh Raman --- v2: - Add panfrost GPU jobs for rockchip SOC with new xfails. --- drivers/gpu/drm/ci/test.yml |

[PATCH v2 2/7] drm/ci: mediatek: Rename exisitng job

2024-01-16 Thread Vignesh Raman
For mediatek mt8173 and mt8183, the display driver is mediatek. Currently, in drm-ci for mediatek, only the display driver is tested. So rename the mediatek job to indicate that display driver is tested. Rename the name of xfail files for mediatek (mt8173 and mt8183), to include information about

[PATCH v2 4/7] drm/ci: meson: Rename exisitng job

2024-01-16 Thread Vignesh Raman
For Amlogic Meson SOC the display driver is meson. Currently, in drm-ci for meson, only the display driver is tested. So rename the meson job to indicate that display driver is tested. Rename the name of xfail files for meson (g12b), to include information about the tested driver and update xfails

RE: [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display mode for waveshare 7inch touchscreen panel

2024-01-16 Thread Shengyang Chen
Hi, Jessica Thanks for your comment and review > -Original Message- > From: Jessica Zhang > Sent: 2024年1月10日 2:26 > To: Shengyang Chen ; > devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org > Cc: neil.armstr...@linaro.org; s...@ravnborg.org; airl...@gmail.com; > dan...@ffwll.ch;

Re: Rework TTMs busy handling

2024-01-16 Thread Christian König
Am 12.01.24 um 13:51 schrieb Christian König: Hi guys, just a gentle ping on this. Zack any more comments for the VMWGFX parts? Thanks, Christian. same as the last time. Things I've changed: Implemented the requirements from Zack to correctly fill in the busy placements for VMWGFX. Renam

RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support

2024-01-16 Thread Shengyang Chen
Hi, Neil > -Original Message- > From: neil.armstr...@linaro.org > Sent: 2024年1月16日 17:34 > To: Shengyang Chen ; > devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org > Cc: quic_jessz...@quicinc.com; s...@ravnborg.org; airl...@gmail.com; > dan...@ffwll.ch; maarten.lankho...@linux.i

[PULL] drm-xe-next-fixes

2024-01-16 Thread Thomas Hellström
Hi Maintainers, Various fixes for the Xe driver, as described below, for -rc1. Thanks, Thomas The following changes since commit 315acff5196f4e2f84a2a2d093000e0c6b0b4d1c: drm/xe: Fix warning on impossible condition (2023-12-26 12:53:26 -0500) are available in the Git repository at: https

End of 4.14 autosel? Re: [PATCH AUTOSEL 4.14 3/6] drm/crtc: Fix uninit-value bug in drm_mode_setcrtc

2024-01-16 Thread Pavel Machek
Hi! > > > From: Ziqi Zhao > > > > > > [ Upstream commit 3823119b9c2b5f9e9b760336f75bc989b805cde6 ] > > > > > > The connector_set contains uninitialized values when allocated with > > > kmalloc_array. However, in the "out" branch, the logic assumes that any > > > element in connector_set would b

Re: [PATCH v7 2/9] drm/panic: Add a drm panic handler

2024-01-16 Thread Jocelyn Falempe
On 12/01/2024 14:31, Daniel Vetter wrote: On Thu, Jan 04, 2024 at 05:00:46PM +0100, Jocelyn Falempe wrote: This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer()

[PATCH][next] drm/nouveau/fifo/gk104: remove redundant variable ret

2024-01-16 Thread Colin Ian King
The variable ret is being assigned a value but it isn't being read afterwards. The assignment is redundant and so ret can be removed. Cleans up clang scan build warning: warning: Although the value stored to 'ret' is used in the enclosing expression, the value is never actually read from 'ret' [de

Re: [PATCH v2 2/7] drm/ci: mediatek: Rename exisitng job

2024-01-16 Thread Daniel Stone
Hi Vignesh, On Tue, 16 Jan 2024 at 09:55, Vignesh Raman wrote: > Rename the name of xfail files for mediatek (mt8173 and mt8183), > to include information about the tested driver and update xfails > accordingly. Since the correct driver name is passed from the job to > test gpu and display driver

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-16 Thread Sebastian Wick
On Mon, Jan 15, 2024 at 04:05:52PM +, Andri Yngvason wrote: > From: Werner Sembach > > Add a new general drm property "force color format" which can be used > by userspace to tell the graphics driver which color format to use. I don't like the "force" in the name. This just selects the color

Re: [PATCH v3] drm/ci: add tests on vkms

2024-01-16 Thread Vignesh Raman
Hi Helen, On 15/01/24 20:54, Helen Koike wrote: diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml index 084e3ff8e3f4..4b636d39734c 100644 --- a/drivers/gpu/drm/ci/gitlab-ci.yml +++ b/drivers/gpu/drm/ci/gitlab-ci.yml @@ -108,6 +108,7 @@ stages:     - rockchip     -

[PATCH v2 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema

2024-01-16 Thread Dharma Balasubiramani
Converted the text bindings to YAML and validated them individually using following commands $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ changelogs are available in respective patches. Dharma Bal

[PATCH v2 2/3] dt-bindings: atmel, hlcdc: convert pwm bindings to json-schema

2024-01-16 Thread Dharma Balasubiramani
Convert device tree bindings for Atmel's HLCDC PWM controller to YAML format. Signed-off-by: Dharma Balasubiramani --- changelog v1 -> v2 - Remove the explicit copyrights. - Modify title (not include words like binding/driver). - Modify description actually describing the hardware and not the dri

[PATCH v2 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema

2024-01-16 Thread Dharma Balasubiramani
Convert the existing DT binding to DT schema of the Atmel's HLCDC display controller. Signed-off-by: Dharma Balasubiramani --- changelog v1 -> v2 - Remove the explicit copyrights. - Modify filename like compatible. - Modify title (drop words like binding/driver). - Modify description actually des

[PATCH v2 3/3] dt-bindings: mfd: atmel, hlcdc: Convert to DT schema format

2024-01-16 Thread Dharma Balasubiramani
Convert the atmel,hlcdc binding to DT schema format. Adjust the clock-names property to clarify that the LCD controller expects one of these clocks (either sys_clk or lvds_pll_clk to be present but not both) along with the slow_clk and periph_clk. This alignment with the actual hardware requiremen

Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async

2024-01-16 Thread André Almeida
Hi Pekka, Em 16/01/2024 06:45, Pekka Paalanen escreveu: On Tue, 16 Jan 2024 01:51:57 -0300 André Almeida wrote: Hi, AMD hardware can do more on the async flip path than just the primary plane, so to lift up the current restrictions, this patchset allows drivers to write their own check for p

Re: [DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

2024-01-16 Thread Devarsh Thakkar
Hi Conor, Thanks for the review. On 15/01/24 21:44, Conor Dooley wrote: > On Mon, Jan 15, 2024 at 06:27:16PM +0530, Devarsh Thakkar wrote: >> This adds common1 register space for AM62x and AM65x SoC's which are using >> TI's Keystone display hardware and supporting it as described in >> Documenta

Re: [PATCH] drm/ttm: only use DMA32 if needed for dummy_read_page

2024-01-16 Thread Yangyu Chen
On 1/16/24 17:45, Christian König wrote: Am 16.01.24 um 08:24 schrieb Yangyu Chen: Some platforms may not have any memory in ZONE_DMA32 and use IOMMU to allow 32-bit-DMA-only device to work. Forcing GFP_DMA32 on dummy_read_page will fail in such platforms. Only use DMA32 when it must to get

Re: [PATCH][next] drm/nouveau/fifo/gk104: remove redundant variable ret

2024-01-16 Thread Dan Carpenter
On Tue, Jan 16, 2024 at 11:16:09AM +, Colin Ian King wrote: > The variable ret is being assigned a value but it isn't being > read afterwards. The assignment is redundant and so ret can be > removed. > > Cleans up clang scan build warning: > warning: Although the value stored to 'ret' is used

Re: [PATCH 0/4] KVM: Honor guest memory types for virtio GPU devices

2024-01-16 Thread Jason Gunthorpe
On Tue, Jan 16, 2024 at 04:05:08AM +, Tian, Kevin wrote: > > From: Tian, Kevin > > Sent: Tuesday, January 16, 2024 8:46 AM > > > > > From: Jason Gunthorpe > > > Sent: Tuesday, January 16, 2024 12:31 AM > > > > > > On Tue, Jan 09, 2024 at 10:11:23AM +0800, Yan Zhao wrote: > > > > > > > > Well,

[PATCH 0/1] drm/ttm: allocate dummy_read_page without DMA32 on fail

2024-01-16 Thread Yangyu Chen
Some platforms may not have any memory below 4GB address space, but the kernel defines ZONE_DMA32 on their ISA. Thus these platforms will have an empty DMA32 zone, resulting ttm failing when alloc_page with GFP_DMA32 flag. However, we can't directly allocate dummy_read_page without GFP_DMA32 as som

[PATCH 1/1] drm/ttm: allocate dummy_read_page without DMA32 on fail

2024-01-16 Thread Yangyu Chen
Some platforms may not have any memory in ZONE_DMA32 and use IOMMU to allow 32-bit-DMA-only device to work. Forcing GFP_DMA32 on dummy_read_page will fail on such platforms. Retry after fail will get this works on such platforms. Signed-off-by: Yangyu Chen --- drivers/gpu/drm/ttm/ttm_device.c |

[PATCH 00/10] drm: drm debug and error logging improvements

2024-01-16 Thread Jani Nikula
This is resend and more patches on top of [1]. I don't think I've changed anything since then. BR, Jani. [1] https://patchwork.freedesktop.org/series/126873/ Jani Nikula (10): drm/print: make drm_err_printer() device specific by using drm_err() drm/print: move enum drm_debug_category etc. e

[PATCH 01/10] drm/print: make drm_err_printer() device specific by using drm_err()

2024-01-16 Thread Jani Nikula
With few users for drm_err_printer(), it's still feasible to convert it to be device specific. Use drm_err() under the hood. While at it, make the prefix optional. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 7 ++- drivers/gpu/drm/i915/gt/selftest_e

[PATCH 02/10] drm/print: move enum drm_debug_category etc. earlier in drm_print.h

2024-01-16 Thread Jani Nikula
Avoid forward declarations in subsequent changes, but separate this movement to an independent change. Signed-off-by: Jani Nikula --- include/drm/drm_print.h | 190 1 file changed, 95 insertions(+), 95 deletions(-) diff --git a/include/drm/drm_print.h b/

[PATCH 03/10] drm/print: add drm_dbg_printer() for drm device specific printer

2024-01-16 Thread Jani Nikula
We've lacked a device specific debug printer. Add one. Take category into account too. __builtin_return_address(0) is inaccurate here, so don't use it. If necessary, we can later pass __func__ to drm_dbg_printer() by wrapping it inside a macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm

[PATCH 04/10] drm/dp_mst: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-01-16 Thread Jani Nikula
Prefer the device specific debug printer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 23 +++ 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topo

[PATCH 05/10] drm/mode: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-01-16 Thread Jani Nikula
Prefer the device specific debug printer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_mode_config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c index 8525ef851540..48fd2d67f352 100644 --- a/driv

[PATCH 09/10] drm/xe: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-01-16 Thread Jani Nikula
Prefer the device specific debug printer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/xe_gt.c | 2 +- drivers/gpu/drm/xe/xe_gt_topology.c | 4 +++- drivers/gpu/drm/xe/xe_reg_sr.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_gt.c

[PATCH 06/10] drm/dp: switch drm_dp_vsc_sdp_log() to struct drm_printer

2024-01-16 Thread Jani Nikula
Use the existing drm printer infrastructure instead of local macros. Signed-off-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_helper.c | 17 +--- .../drm/i915/display/intel_crtc_state_dump.c | 5 ++-- drivers/gpu/drm/i915/display/intel_display.c | 27 +-- in

[PATCH 07/10] drm/i915: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-01-16 Thread Jani Nikula
Prefer the device specific debug printer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_driver.c | 3 ++- drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c| 3 ++- drivers/gpu/drm/i915/gt/intel_reset.c | 3 ++- drivers/gpu/drm/i915/gt/intel_workaround

[PATCH 08/10] drm/i915: use drm_printf() with the drm_err_printer intead of pr_err()

2024-01-16 Thread Jani Nikula
There's already a related drm_printer. Use it to preserve the context instead of a separate pr_err(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 6 +++--- drivers/gpu/drm/i915/selftests/i915_active.c| 4 ++-- 2 files changed, 5 insertions(+), 5 d

[PATCH 10/10] drm: remove drm_debug_printer in favor of drm_dbg_printer

2024-01-16 Thread Jani Nikula
Convert the remaining drm_debug_printer users over to drm_dbg_printer, as it can handle the cases without struct drm_device pointer, and also provides drm debug category and prefix support. Remove drm_debug_printer altogether. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_modeset_lock.c |

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-16 Thread Andri Yngvason
Hi Sebastian, þri., 16. jan. 2024 kl. 11:42 skrifaði Sebastian Wick : > > On Mon, Jan 15, 2024 at 04:05:52PM +, Andri Yngvason wrote: > > From: Werner Sembach > > > > Add a new general drm property "force color format" which can be used > > by userspace to tell the graphics driver which color

Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async

2024-01-16 Thread Pekka Paalanen
On Tue, 16 Jan 2024 08:50:59 -0300 André Almeida wrote: > Hi Pekka, > > Em 16/01/2024 06:45, Pekka Paalanen escreveu: > > On Tue, 16 Jan 2024 01:51:57 -0300 > > André Almeida wrote: > > > >> Hi, > >> > >> AMD hardware can do more on the async flip path than just the primary > >> plane, so >

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-16 Thread Sebastian Wick
On Tue, Jan 16, 2024 at 01:13:13PM +, Andri Yngvason wrote: > Hi Sebastian, > > þri., 16. jan. 2024 kl. 11:42 skrifaði Sebastian Wick > : > > > > On Mon, Jan 15, 2024 at 04:05:52PM +, Andri Yngvason wrote: > > > From: Werner Sembach > > > > > > Add a new general drm property "force color

Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async

2024-01-16 Thread André Almeida
+ Joshua Em 16/01/2024 10:14, Pekka Paalanen escreveu: On Tue, 16 Jan 2024 08:50:59 -0300 André Almeida wrote: Hi Pekka, Em 16/01/2024 06:45, Pekka Paalanen escreveu: On Tue, 16 Jan 2024 01:51:57 -0300 André Almeida wrote: Hi, AMD hardware can do more on the async flip path than just

[RFC PATCH 0/3] Add display sharing support in tidss

2024-01-16 Thread Devarsh Thakkar
This adds display sharing support in tidss display driver along with an example overlay devicetree file using which can be used to enable display sharing on AM62x devices with device manager core i.e. R5F expected to run a custom firmware which supports corresponding display sharing configuration.

[RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-01-16 Thread Devarsh Thakkar
Display subsystem present in TI Keystone family of devices supports sharing of display between multiple hosts as it provides separate register space (common* region) for each host to programming display controller and also a unique interrupt line for each host. This adds support for display sharin

[RFC PATCH 1/3] dt-bindings: display: ti, am65x-dss: Add support for display sharing mode

2024-01-16 Thread Devarsh Thakkar
Add support for using TI Keystone DSS hardware present in display sharing mode. TI Keystone DSS hardware supports partitioning of resources between multiple hosts as it provides separate register space and unique interrupt line to each host. The DSS hardware can be used in shared mode in such a w

[RFC PATCH 3/3] arm64: dts: ti: k3-am62x: Add overlay to use DSS in display sharing mode

2024-01-16 Thread Devarsh Thakkar
This overlay needs to be used with display sharing supported device manager firmware only. Remote core running this firmware has write access to "common" register space, VIDL pipeline, OVR1 overlay and VP1 videoport. The processing core running Linux is provided write access to VID pipeline and "

Re: [DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

2024-01-16 Thread Rob Herring
On Tue, Jan 16, 2024 at 02:48:53PM +0530, Devarsh Thakkar wrote: > Hi Conor, > > Thanks for the review. > > On 15/01/24 21:44, Conor Dooley wrote: > > On Mon, Jan 15, 2024 at 06:27:16PM +0530, Devarsh Thakkar wrote: > >> This adds common1 register space for AM62x and AM65x SoC's which are using >

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-16 Thread Andri Yngvason
þri., 16. jan. 2024 kl. 13:29 skrifaði Sebastian Wick : > > On Tue, Jan 16, 2024 at 01:13:13PM +, Andri Yngvason wrote: [...] > > şri., 16. jan. 2024 kl. 11:42 skrifaği Sebastian Wick > > : > > > > > > On Mon, Jan 15, 2024 at 04:05:52PM +, Andri Yngvason wrote: > > > > From: Werner Sembach

Re: [PATCH 00/33] spi: get rid of some legacy macros

2024-01-16 Thread Mark Brown
On Mon, Jan 15, 2024 at 09:12:46PM +0100, Uwe Kleine-König wrote: > In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"") > some functions were renamed. Further some compat defines were introduced > to map the old names to the new ones. > Patch #18 and #19 touch the same driver,

Re: [PATCH] drm/ttm: only use DMA32 if needed for dummy_read_page

2024-01-16 Thread Christian König
Am 16.01.24 um 12:27 schrieb Yangyu Chen: On 1/16/24 17:45, Christian König wrote: Am 16.01.24 um 08:24 schrieb Yangyu Chen: Some platforms may not have any memory in ZONE_DMA32 and use IOMMU to allow 32-bit-DMA-only device to work. Forcing GFP_DMA32 on dummy_read_page will fail in such platf

Re: [PATCH 1/1] drm/ttm: allocate dummy_read_page without DMA32 on fail

2024-01-16 Thread Christian König
Am 16.01.24 um 14:02 schrieb Yangyu Chen: Some platforms may not have any memory in ZONE_DMA32 and use IOMMU to allow 32-bit-DMA-only device to work. Forcing GFP_DMA32 on dummy_read_page will fail on such platforms. Retry after fail will get this works on such platforms. Signed-off-by: Yangyu Ch

Re: [PATCH 00/33] spi: get rid of some legacy macros

2024-01-16 Thread Uwe Kleine-König
Hello Mark, On Tue, Jan 16, 2024 at 02:40:39PM +, Mark Brown wrote: > On Mon, Jan 15, 2024 at 09:12:46PM +0100, Uwe Kleine-König wrote: > > > In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"") > > some functions were renamed. Further some compat defines were introduced >

Re: [3/3] ASoC: hdmi-codec: drop drm/drm_edid.h include

2024-01-16 Thread Jani Nikula
On Fri, 12 Jan 2024, "Sarha, Jyri" wrote: > Reviewed-by: > > Thanks, > The including of drm_edid.h in hdmi-codec.h is a relic from my pre > upstreaming version of hdmi-codec. I don't think it was ever needed > in any upsteam version. Thanks for the reviews and acks, pushed to drm-misc-next, even

QAIC reset failure

2024-01-16 Thread Baruch Siach
Hi qaic driver maintainers, I am testing an A100 device on arm64 platform. Kernel version is current Linus master as of commit 052d534373b7. The driver is unable to reset the device properly. [ 137.706765] pci :01:00.0: enabling device ( -> 0002) [ 137.712528] pci :02:00.0: enabling

[PATCH v2] drm/xe/guc: Add GuC based register capture for error capture

2024-01-16 Thread Zhanjun Dong
Port GuC based register capture for error capture from i915 to Xe. There are 3 parts in this commit: . Prepare for capture registers There is a bo create at guc ads init time, that is very early and engine map is not ready, make it hard to calculate the capture buffer size, new functio

[PATCH] drm/xe/guc: Add register defines for GuC based register capture

2024-01-16 Thread Zhanjun Dong
Add registers defines and list of registers for GuC based error state capture. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/xe/Kconfig | 11 +++ drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/regs/xe_engine_regs.h | 12 +++ drivers/gpu/drm/xe/regs/xe_gt_r

[PATCH] drm/xe/guc: Plumb GuC-capture into dev coredump

2024-01-16 Thread Zhanjun Dong
Add xe_hw_engine_snapshot_from_capture to take snapshot from capture node list. Add data struct to map register to a snapshot field, although all field is mapped now, which means the offset could be optimized, while in the future, depends on system configuration, the field might not be consecutive.

[PATCH] drm/xe/guc: Pre-allocate output nodes for extraction

2024-01-16 Thread Zhanjun Dong
Pre-allocate a fixed number of empty nodes up front (at the time of ADS registration) that we can consume from or return to an internal cached list of nodes. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/xe/xe_guc_capture.c | 83 + 1 file changed, 83 insertions(+)

[PATCH] drm/xe/guc: Add capture size check in GuC log buffer

2024-01-16 Thread Zhanjun Dong
The capture-nodes is included in GuC log buffer, add the size check for capture region in the whole GuC log buffer. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/xe/xe_gt_printk.h | 3 + drivers/gpu/drm/xe/xe_guc_fwif.h | 48 +++ drivers/gpu/drm/xe/xe_guc_log.c | 179

[PATCH] drm/xe/guc: Update GuC ADS size for error capture

2024-01-16 Thread Zhanjun Dong
Update GuC ADS size allocation to include space for the lists of error state capture register descriptors. Then, populate GuC ADS with the lists of registers we want GuC to report back to host on engine reset events. This list should include global, engine-class and engine-instance registers for e

[PATCH] drm/xe/guc: Expose dss per group for GuC error capture

2024-01-16 Thread Zhanjun Dong
Expose helper for dss per group of mcr, GuC error capture feature need this info to prepare buffer required. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/xe/xe_gt_mcr.c | 4 ++-- drivers/gpu/drm/xe/xe_gt_mcr.h | 1 + drivers/gpu/drm/xe/xe_gt_topology.c | 3 --- driver

[PATCH] drm/xe/guc: Check sizing of guc_capture output

2024-01-16 Thread Zhanjun Dong
Add capture output size check function to provide a reasonable minimum size for error capture region before allocating the shared buffer. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/xe/xe_guc_capture.c | 76 + 1 file changed, 76 insertions(+) diff --git a/drivers

[PATCH] drm/xe/guc: Add XE_LP steered register lists

2024-01-16 Thread Zhanjun Dong
Add the ability for runtime allocation and freeing of steered register list extentions that depend on the detected HW config fuses. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/xe/xe_guc_capture.c | 187 +++- 1 file changed, 185 insertions(+), 2 deletions(-) diff --gi

[PATCH] drm/xe/guc: Extract GuC error capture lists on G2H notification

2024-01-16 Thread Zhanjun Dong
Upon the G2H Notify-Err-Capture event, parse through the GuC Log Buffer (error-capture-subregion) and generate one or more capture-nodes. A single node represents a single "engine- instance-capture-dump" and contains at least 3 register lists: global, engine-class and engine-instance. An internal l

Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel

2024-01-16 Thread Conor Dooley
On Tue, Jan 16, 2024 at 09:40:21AM +, Shengyang Chen wrote: > Hi, Conor > > Thanks for comment. > > > -Original Message- > > From: Conor Dooley > > Sent: 2024年1月10日 0:32 > > To: Shengyang Chen > > Cc: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > > neil.armstr...@li

Re: [PATCH v2] drm/xe/guc: Add GuC based register capture for error capture

2024-01-16 Thread Dong, Zhanjun
Please ignore this patch The patch is for Xe upstream, sent to wrong ML. Regards, Zhanjun On 2024-01-16 12:12 p.m., Zhanjun Dong wrote: Port GuC based register capture for error capture from i915 to Xe. There are 3 parts in this commit: . Prepare for capture registers There is a bo creat

[PATCH v2 2/5] drm/xe/mmio: Cast to u64 when printing

2024-01-16 Thread Lucas De Marchi
resource_size_t uses %pa format in printk since the size varies depending on build options. However to keep the io_size/physical_size addition in the same call we can't pass the address without adding yet another variable in these function. Simply cast it to u64 and keep using %llx. Fixes: 286089c

[PATCH v2 5/5] drm/xe: Enable 32bits build

2024-01-16 Thread Lucas De Marchi
Now that all the issues with 32bits are fixed, enable it again. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig index 1b57ae38210d..1b0ef91a5d2c 100644 --- a/

[PATCH v2 0/5] Fix 32bit build

2024-01-16 Thread Lucas De Marchi
A few fixes when building xe with ARCH=i386. Changes from v1: the first patch disabling 32b builds is already merged. These are the real fixes to get it building again. Lucas De Marchi (5): drm/xe: Use _ULL for u64 division drm/xe/mmio: Cast to u64 when printing drm/xe/display: Avoid callin

[PATCH v2 4/5] drm/xe: Fix cast on trace variable

2024-01-16 Thread Lucas De Marchi
Cast the pointer to unsigned long and let it be implicitly extended to u64. This fixes the build on 32bits arch. Cc: Matthew Brost Cc: Niranjana Vishwanathapura Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/xe_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 1/5] drm/xe: Use _ULL for u64 division

2024-01-16 Thread Lucas De Marchi
Use DIV_ROUND_UP_ULL() so it also works on 32bit build. Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs") Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/xe_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_device.c b

[PATCH v2 3/5] drm/xe/display: Avoid calling readq()

2024-01-16 Thread Lucas De Marchi
readq() is not available in 32bits. iosys-map already has the logic in place to use read u64 in all cases, so simply add a helper variable for using that. Fixes: 44e694958b95 ("drm/xe/display: Implement display support") Signed-off-by: Lucas De Marchi --- .../gpu/drm/xe/compat-i915-headers/gem/i

[PATCH] drm/tests: mm: Call drm_mm_print in drm_test_mm_debug

2024-01-16 Thread Michał Winiarski
The original intent behind the test was to sanity check whether calling the debug iterator (drm_mm_print) doesn't cause any problems. Unfortunately - this call got accidentally removed during KUnit transition. Restore it. Signed-off-by: Michał Winiarski --- drivers/gpu/drm/tests/drm_mm_test.c |

Re: [PATCH v2 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema

2024-01-16 Thread Conor Dooley
Yo, On Tue, Jan 16, 2024 at 05:07:58PM +0530, Dharma Balasubiramani wrote: > Convert the existing DT binding to DT schema of the Atmel's HLCDC display > controller. > > Signed-off-by: Dharma Balasubiramani > --- > changelog > v1 -> v2 > - Remove the explicit copyrights. > - Modify filename like

Re: [PATCH v2 2/3] dt-bindings: atmel, hlcdc: convert pwm bindings to json-schema

2024-01-16 Thread Conor Dooley
On Tue, Jan 16, 2024 at 05:07:59PM +0530, Dharma Balasubiramani wrote: > Convert device tree bindings for Atmel's HLCDC PWM controller to YAML > format. > > Signed-off-by: Dharma Balasubiramani > --- > changelog > v1 -> v2 > - Remove the explicit copyrights. > - Modify title (not include words li

Re: [PATCH v2 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-01-16 Thread Conor Dooley
On Tue, Jan 16, 2024 at 05:08:00PM +0530, Dharma Balasubiramani wrote: > Convert the atmel,hlcdc binding to DT schema format. > > Adjust the clock-names property to clarify that the LCD controller expects > one of these clocks (either sys_clk or lvds_pll_clk to be present but not > both) along wit

Re: [PATCH 00/10] Make PCI's devres API more consistent

2024-01-16 Thread Bjorn Helgaas
On Mon, Jan 15, 2024 at 03:46:11PM +0100, Philipp Stanner wrote: > ... > pci: add new set of devres functions > pci: deprecate iomap-table functions > pci: warn users about complicated devres nature > pci: devres: make devres region requests consistent > pci: move enabled status bit to p

  1   2   >