Pre-allocate a fixed number of empty nodes up front (at the
time of ADS registration) that we can consume from or return to
an internal cached list of nodes.

Signed-off-by: Zhanjun Dong <zhanjun.d...@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_capture.c | 83 +++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_guc_capture.c 
b/drivers/gpu/drm/xe/xe_guc_capture.c
index 319e606eeb2a..52f1bacc08ff 100644
--- a/drivers/gpu/drm/xe/xe_guc_capture.c
+++ b/drivers/gpu/drm/xe/xe_guc_capture.c
@@ -479,6 +479,8 @@ xe_guc_capture_getlistsize(struct xe_guc *guc, u32 owner, 
u32 type, u32 classid,
        return guc_capture_getlistsize(guc, owner, type, classid, size, false);
 }
 
+static void guc_capture_create_prealloc_nodes(struct xe_guc *guc);
+
 int
 xe_guc_capture_getlist(struct xe_guc *guc, u32 owner, u32 type, u32 classid, 
void **outptr)
 {
@@ -497,6 +499,12 @@ xe_guc_capture_getlist(struct xe_guc *guc, u32 owner, u32 
type, u32 classid, voi
                return cache->status;
        }
 
+       /*
+        * ADS population of input registers is a good
+        * time to pre-allocate cachelist output nodes
+        */
+       guc_capture_create_prealloc_nodes(guc);
+
        ret = xe_guc_capture_getlistsize(guc, owner, type, classid, &size);
        if (ret) {
                cache->is_valid = true;
@@ -896,6 +904,30 @@ guc_capture_get_prealloc_node(struct xe_guc *guc)
 
        return found;
 }
+static struct __guc_capture_parsed_output *
+guc_capture_alloc_one_node(struct xe_guc *guc)
+{
+       struct __guc_capture_parsed_output *new;
+       int i;
+
+       new = kzalloc(sizeof(*new), GFP_KERNEL);
+       if (!new)
+               return NULL;
+
+       for (i = 0; i < GUC_CAPTURE_LIST_TYPE_MAX; ++i) {
+               new->reginfo[i].regs = kcalloc(guc->capture->max_mmio_per_node,
+                                              sizeof(struct guc_mmio_reg), 
GFP_KERNEL);
+               if (!new->reginfo[i].regs) {
+                       while (i)
+                               kfree(new->reginfo[--i].regs);
+                       kfree(new);
+                       return NULL;
+               }
+       }
+       guc_capture_init_node(guc, new);
+
+       return new;
+}
 
 static struct __guc_capture_parsed_output *
 guc_capture_clone_node(struct xe_guc *guc, struct __guc_capture_parsed_output 
*original,
@@ -937,6 +969,57 @@ guc_capture_clone_node(struct xe_guc *guc, struct 
__guc_capture_parsed_output *o
        return new;
 }
 
+static void
+__guc_capture_create_prealloc_nodes(struct xe_guc *guc)
+{
+       struct __guc_capture_parsed_output *node = NULL;
+       int i;
+
+       for (i = 0; i < PREALLOC_NODES_MAX_COUNT; ++i) {
+               node = guc_capture_alloc_one_node(guc);
+               if (!node) {
+                       xe_gt_warn(guc_to_gt(guc), "Register capture 
pre-alloc-cache failure\n");
+                       /* dont free the priors, use what we got and cleanup at 
shutdown */
+                       return;
+               }
+               guc_capture_add_node_to_cachelist(guc->capture, node);
+       }
+}
+
+static int
+guc_get_max_reglist_count(struct xe_guc *guc)
+{
+       int i, j, k, tmp, maxregcount = 0;
+
+       for (i = 0; i < GUC_CAPTURE_LIST_INDEX_MAX; ++i) {
+               for (j = 0; j < GUC_CAPTURE_LIST_TYPE_MAX; ++j) {
+                       for (k = 0; k < GUC_MAX_ENGINE_CLASSES; ++k) {
+                               if (j == GUC_CAPTURE_LIST_TYPE_GLOBAL && k > 0)
+                                       continue;
+
+                               tmp = guc_cap_list_num_regs(guc->capture, i, j, 
k);
+                               if (tmp > maxregcount)
+                                       maxregcount = tmp;
+                       }
+               }
+       }
+       if (!maxregcount)
+               maxregcount = PREALLOC_NODES_DEFAULT_NUMREGS;
+
+       return maxregcount;
+}
+
+static void
+guc_capture_create_prealloc_nodes(struct xe_guc *guc)
+{
+       /* skip if we've already done the pre-alloc */
+       if (guc->capture->max_mmio_per_node)
+               return;
+
+       guc->capture->max_mmio_per_node = guc_get_max_reglist_count(guc);
+       __guc_capture_create_prealloc_nodes(guc);
+}
+
 static int
 guc_capture_extract_reglists(struct xe_guc *guc, struct __guc_capture_bufstate 
*buf)
 {
-- 
2.34.1

Reply via email to