Hi, Philipp
Thanks for review and comment.
> -----Original Message-----
> From: Philipp Zabel <p.za...@pengutronix.de>
> Sent: 2024年1月9日 17:08
> To: Shengyang Chen <shengyang.c...@starfivetech.com>;
> devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org
> Cc: andrzej.ha...@intel.com; neil.armstr...@linaro.org; rf...@kernel.org;
> laurent.pinch...@ideasonboard.com; jo...@kwiboo.se;
> jernej.skra...@gmail.com; maarten.lankho...@linux.intel.com;
> mrip...@kernel.org; tzimmerm...@suse.de; airl...@gmail.com;
> dan...@ffwll.ch; robh...@kernel.org; krzysztof.kozlowski...@linaro.org;
> conor...@kernel.org; tomi.valkei...@ideasonboard.com; r-raviku...@ti.com;
> aford...@gmail.com; rdun...@infradead.org;
> u.kleine-koe...@pengutronix.de; bbrezil...@kernel.org; Changhuang Liang
> <changhuang.li...@starfivetech.com>; Keith Zhao
> <keith.z...@starfivetech.com>; Jack Zhu <jack....@starfivetech.com>;
> linux-ker...@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] gpu: drm: bridge: cadence: Add a driver and
> platform ops for StarFive JH7110 SoC
>
> On Di, 2024-01-09 at 15:25 +0800, Shengyang Chen wrote:
> > +static int cdns_dsi_get_reset(struct device *dev, struct cdns_dsi
> > +*dsi) {
> > + dsi->dpi_rst = devm_reset_control_get(dev, "dpi");
> > + if (IS_ERR(dsi->dpi_rst))
> > + return PTR_ERR(dsi->dpi_rst);
>
> Please use devm_reset_control_get_exclusive() directly.
>
> Also, consider using devm_reset_control_bulk_get_exclusive() instead, to
> control "dpi"/"apb"/"txesc" resets together - if the hardware can handle
> deasserting in reversed order.
>
ok, will follow up this issue.
> > +
> > + dsi->apb_rst = devm_reset_control_get(dev, "apb");
> > + if (IS_ERR(dsi->apb_rst))
> > + return PTR_ERR(dsi->apb_rst);
> > +
> > + dsi->txesc_rst = devm_reset_control_get(dev, "txesc");
> > + if (IS_ERR(dsi->txesc_rst))
> > + return PTR_ERR(dsi->txesc_rst);
> > +
> > + dsi->txbytehs_rst = devm_reset_control_get(dev, "txbytehs");
> > + if (IS_ERR(dsi->txbytehs_rst))
> > + return PTR_ERR(dsi->txbytehs_rst);
> > +
> > + return 0;
> > +}
>
> regards
> Philipp
thanks.
Best Regards,
Shengyang
