Re: [PATCH v2 1/3] dt-bindings: add fannal vendor prefix

2023-06-06 Thread Krzysztof Kozlowski
On 05/06/2023 17:35, Paulo Pavacic wrote: > Fannal is a one-stop-solution provider for touch displays in industrial > application, committed to delivering a variety of professional high-quality > products and technical services globally. > > Website: www.fannal.com > > Signed-off-by: Paulo Pavaci

Re: [PATCH v2 2/3] dt-bindings: display: panel: add fannal,c3004

2023-06-06 Thread Krzysztof Kozlowski
On 05/06/2023 17:35, Paulo Pavacic wrote: > Added fannal to vendor-prefixes and dt bindings for Fannal C3004. > Fannal C3004 is a 480x800 MIPI DSI Panel which requires > DCS initialization sequences with certain delays between certain > commands. > +#include > +dsi { > +#address-

Re: [PATCH v2 3/3] drm/panel-fannal-c3003: Add fannal c3004 DSI panel

2023-06-06 Thread Krzysztof Kozlowski
On 05/06/2023 17:35, Paulo Pavacic wrote: > Fannal C3004 is a 480x800 display made by fannal that requires > DCS initialization sequences. > > Signed-off-by: Paulo Pavacic > --- > v3 changelog: > - using generic mipi_dsi_dcs_write_seq This is marked as v2? > - removed success prints > - rem

Re: [PATCH V3 1/3] dt-bindings: panel: Add Anbernic RG353V-V2 panel compatible

2023-06-06 Thread Frank Oltmanns
Hi Chris, hi Guido, On 2023-04-26 at 16:54:46 +0200, Guido Günther wrote: > Hi Chris, > could you check if these two modifications by Frank of the init sequence > > > https://lore.kernel.org/dri-devel/20230211171748.36692-2-fr...@oltmanns.dev/ > > https://lore.kernel.org/dri-devel/2023021

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl/gsc: Add a gsc_info debugfs

2023-06-06 Thread kernel test robot
Hi Daniele, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Daniele-Ceraolo-Spurio/drm-i915-gsc-fixes-and-updates-for-GSC-memory-allocation/20230606-102510 base: git

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Thomas Zimmermann
Hi Am 05.06.23 um 22:19 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Thomas Zimmermann Sent: Monday, June 5, 2023 10:48 AM To: dan...@ffwll.ch; javi...@redhat.com; s...@ravnborg.org; del...@gmx.de; geert+rene...@glider.be; l...@kernel.org; daniel.thomp...@lin

Re: [PATCH 18/30] fbdev/radeonfb: Use hardware device as backlight parent

2023-06-06 Thread Thomas Zimmermann
Hi Am 06.06.23 um 07:28 schrieb Dan Carpenter: On Mon, Jun 05, 2023 at 04:48:00PM +0200, Thomas Zimmermann wrote: Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev

Re: WARNING: CPU: 5 PID: 1464 at drivers/gpu/drm/ttm/ttm_bo.c:326 ttm_bo_release+0x27e/0x2d0 [ttm]

2023-06-06 Thread Thomas Zimmermann
Hi Am 05.06.23 um 18:36 schrieb Deucher, Alexander: [...] [ 17.217468] Call Trace: [ 17.217470] [ 17.217472] ? __warn+0x97/0x160 [ 17.217476] ? ttm_bo_release+0x27e/0x2d0 [ttm] [ 17.217481] ? report_bug+0x1ec/0x200 [ 17.217487] ? handle_bug+0x3c/0x70 [ 17.217490] ? exc_inval

Re: [PATCH v2 3/3] drm/panel-fannal-c3003: Add fannal c3004 DSI panel

2023-06-06 Thread Paulo Pavacic
Hello Krzysztof, uto, 6. lip 2023. u 09:14 Krzysztof Kozlowski napisao je: > > On 05/06/2023 17:35, Paulo Pavacic wrote: > > Fannal C3004 is a 480x800 display made by fannal that requires > > DCS initialization sequences. > > > > Signed-off-by: Paulo Pavacic > > --- > > > v3 changelog: > > - us

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Dan Carpenter
On Tue, Jun 06, 2023 at 09:24:48AM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.06.23 um 22:19 schrieb Ruhl, Michael J: > > > -Original Message- > > > From: dri-devel On Behalf Of > > > Thomas Zimmermann > > > Sent: Monday, June 5, 2023 10:48 AM > > > To: dan...@ffwll.ch; javi...@redhat

[PATCH] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-06 Thread Su Hui
Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") Signed-off-by: Su Hui --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-

Re: [Intel-gfx] [PATCH v15 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Joonas Lahtinen
Quoting Yang, Fei (2023-06-06 09:51:06) > >> On 31/05/2023 18:10, fei.y...@intel.com wrote: > >>> From: Fei Yang > >>> > >>> To comply with the design that buffer objects shall have immutable > >>> cache setting through out their life cycle, {set, get}_caching ioctl's > >>> are no longer supported

Re: [PATCH 0/5] drm/ssd130x: A few enhancements and cleanups

2023-06-06 Thread Thomas Zimmermann
Hi Javierm, I've read through the patches and they look correct to me. Reviewed-by: Thomas Zimmermann But I had one question about the page size. You round up to multiples of page_size in several places. That could lead to an out-of-bounds access. Do you need to allocate GEM buffers to be mu

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl/gsc: Add a gsc_info debugfs

2023-06-06 Thread kernel test robot
Hi Daniele, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Daniele-Ceraolo-Spurio/drm-i915-gsc-fixes-and-updates-for-GSC-memory-allocation/20230606-102510 base: git

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Thomas Zimmermann
Hi Am 06.06.23 um 09:49 schrieb Dan Carpenter: On Tue, Jun 06, 2023 at 09:24:48AM +0200, Thomas Zimmermann wrote: Hi Am 05.06.23 um 22:19 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Thomas Zimmermann Sent: Monday, June 5, 2023 10:48 AM To: dan...@ffwll.ch

Re: [PATCH v1 1/1] backlight: hx8357: Convert to agnostic GPIO API

2023-06-06 Thread Daniel Thompson
On Mon, Jun 05, 2023 at 07:07:24PM +0300, Andy Shevchenko wrote: > On Mon, Mar 20, 2023 at 01:54:26PM +0200, Andy Shevchenko wrote: > > On Fri, Mar 17, 2023 at 09:53:40PM +0100, Linus Walleij wrote: > > > On Fri, Mar 17, 2023 at 7:51 PM Andy Shevchenko > > > wrote: > > > > > > > The of_gpio.h is g

[PATCH v7 2/8] drm/bridge: tfp410: Set input_bus_flags in atomic_check

2023-06-06 Thread Aradhya Bhatia
From: Nikhil Devshatwar input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Implement atomic_check hook for

[PATCH v7 5/8] drm/bridge: sii902x: Support format negotiation hooks

2023-06-06 Thread Aradhya Bhatia
With new connector model, sii902x will not create the connector, when DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and SoC driver will rely on format negotiation to setup the encoder format. Support format negotiations hooks in the drm_bridge_funcs. Use helper functions for state management. Input forma

[PATCH v7 1/8] drm/bridge: tfp410: Support format negotiation hooks

2023-06-06 Thread Aradhya Bhatia
From: Nikhil Devshatwar With new connector model, tfp410 will not create the connector and SoC driver will rely on format negotiation to setup the encoder format. Support format negotiations hooks in the drm_bridge_funcs. Use helper functions for state management. Input format is the one select

[PATCH v7 0/8] drm/tidss: Use new connector model for tidss

2023-06-06 Thread Aradhya Bhatia
Hi all, I have picked up this long standing series from Nikhil Devshatwar[1]. This series moves the tidss to using new connectoe model, where the SoC driver (tidss) creates the connector and all the bridges are attached with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR. It also now creates bridge to s

[PATCH v7 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

2023-06-06 Thread Aradhya Bhatia
From: Nikhil Devshatwar input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Signed-off-by: Nikhil Devshatwa

[PATCH v7 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-06-06 Thread Aradhya Bhatia
From: Nikhil Devshatwar With new connector model, mhdp bridge will not create the connector and SoC driver will rely on format negotiation to setup the encoder format. Support minimal format negotiations hooks in the drm_bridge_funcs. Complete format negotiation can be added based on EDID data.

[PATCH v7 6/8] drm/bridge: sii902x: Set input_bus_flags in atomic_check

2023-06-06 Thread Aradhya Bhatia
input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Implement atomic_check hook for the same. Signed-off-by:

[PATCH v7 8/8] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable

2023-06-06 Thread Aradhya Bhatia
From: Nikhil Devshatwar When removing the tidss driver, there is a warning reported by kernel about an unhandled interrupt for mhdp driver. [ 43.238895] irq 31: nobody cared (try booting with the "irqpoll" option) ... [snipped backtrace] [ 43.330735] handlers: [ 43.333020] [<5367c4

[PATCH v7 7/8] drm/tidss: Update encoder/bridge chain connect model

2023-06-06 Thread Aradhya Bhatia
With the new encoder/bridge chain model, the display controller driver is required to create a drm_connector entity instead of asking the bridge to do so during drm_bridge_attach. Moreover, the controller driver should create a drm_bridge entity to negotiate bus formats and a 'simple' drm_encoder e

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl/gsc: Add a gsc_info debugfs

2023-06-06 Thread kernel test robot
Hi Daniele, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Daniele-Ceraolo-Spurio/drm-i915-gsc-fixes-and-updates-for-GSC-memory-allocation/20230606-102510 base: git

[PATCH] drm/msm/dpu: tidy up some error checking

2023-06-06 Thread Dan Carpenter
The "vsync_hz" variable is unsigned int so it can't be less than zero. The dpu_kms_get_clk_rate() function used to return a u64 but I previously changed it to return an unsigned long and zero on error so it matches clk_get_rate(). Change the "vsync_hz" type to unsigned long as well and change the

Re: [PATCH v7 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-06-06 Thread Neil Armstrong
On 06/06/2023 10:21, Aradhya Bhatia wrote: From: Nikhil Devshatwar With new connector model, mhdp bridge will not create the connector and SoC driver will rely on format negotiation to setup the encoder format. Support minimal format negotiations hooks in the drm_bridge_funcs. Complete format

Re: [PATCH v7 1/8] drm/bridge: tfp410: Support format negotiation hooks

2023-06-06 Thread Neil Armstrong
On 06/06/2023 10:21, Aradhya Bhatia wrote: From: Nikhil Devshatwar With new connector model, tfp410 will not create the connector and SoC driver will rely on format negotiation to setup the encoder format. Support format negotiations hooks in the drm_bridge_funcs. Use helper functions for stat

Re: [PATCH] drm/i915: Fix a VMA UAF for multi-gt platform

2023-06-06 Thread Nirmoy Das
On 6/5/2023 10:27 PM, Andi Shyti wrote: Hi Nirmoy, On Mon, Jun 05, 2023 at 10:10:21PM +0200, Nirmoy Das wrote: Ensure correct handling of closed VMAs on multi-gt platforms to prevent Use-After-Free. Currently, when GT0 goes idle, closed VMAs that are exclusively added to GT0's closed_vma link

Re: [PATCH v7 0/8] drm/tidss: Use new connector model for tidss

2023-06-06 Thread Neil Armstrong
Hi, On 06/06/2023 10:21, Aradhya Bhatia wrote: Hi all, I have picked up this long standing series from Nikhil Devshatwar[1]. This series moves the tidss to using new connectoe model, where the SoC driver (tidss) creates the connector and all the bridges are attached with the flag DRM_BRIDGE_AT

[PATCH v16 0/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Andi Shyti
From: Fei Yang This series introduce a new extension for GEM_CREATE, 1. end support for set caching ioctl [PATCH 1/2] 2. add set_pat extension for gem_create [PATCH 2/2] v2: drop one patch that was merged separately commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function") v3: rebased on

[PATCH v16 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Andi Shyti
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a def

Re: [Intel-gfx] [PATCH] drm/i915: Use the fdinfo helper

2023-06-06 Thread Tvrtko Ursulin
On 05/06/2023 23:07, Andi Shyti wrote: Hi Tvrtko, On Mon, Jun 05, 2023 at 01:32:24PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use the common fdinfo helper for printing the basics. Remove now unused client id allocation code. Signed-off-by: Tvrtko Ursulin Cc: Rob Clark looks go

Re: [PATCH] drm/i915/selftests: Add some missing error propagation

2023-06-06 Thread Tvrtko Ursulin
On 05/06/2023 14:47, Andi Shyti wrote: Hi Tvrtko, Add some missing error propagation in live_parallel_switch. To avoid needlessly burdening the various backport processes, note I am not marking it as a fix against any patches and not copying stable since it is debug/selftests only code. wh

Re: [Intel-gfx] [PATCH] drm/i915: Implement fdinfo memory stats printing

2023-06-06 Thread Tvrtko Ursulin
On 05/06/2023 23:22, Andi Shyti wrote: Hi Tvrtko, On Mon, Jun 05, 2023 at 03:37:20PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we w

Re: [PATCH v7 0/8] drm/tidss: Use new connector model for tidss

2023-06-06 Thread Aradhya Bhatia
Hi Neil, Thank you for reviewing the previous patches! On 06-Jun-23 14:37, Neil Armstrong wrote: > Hi, > > On 06/06/2023 10:21, Aradhya Bhatia wrote: >> Hi all, >> >> I have picked up this long standing series from Nikhil Devshatwar[1]. >> >> This series moves the tidss to using new connectoe mo

Re: [PATCH v7 0/8] drm/tidss: Use new connector model for tidss

2023-06-06 Thread neil . armstrong
On 06/06/2023 11:46, Aradhya Bhatia wrote: Hi Neil, Thank you for reviewing the previous patches! On 06-Jun-23 14:37, Neil Armstrong wrote: Hi, On 06/06/2023 10:21, Aradhya Bhatia wrote: Hi all, I have picked up this long standing series from Nikhil Devshatwar[1]. This series moves the tid

Re: [PATCH v2 2/3] dt-bindings: display: panel: add fannal,c3004

2023-06-06 Thread Paulo Pavacic
Hello Krzysztof, uto, 6. lip 2023. u 09:10 Krzysztof Kozlowski napisao je: > > On 05/06/2023 17:35, Paulo Pavacic wrote: > > Added fannal to vendor-prefixes and dt bindings for Fannal C3004. > > Fannal C3004 is a 480x800 MIPI DSI Panel which requires > > DCS initialization sequences with certain

[PATCH v17 0/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Andi Shyti
From: Fei Yang This series introduce a new extension for GEM_CREATE, 1. end support for set caching ioctl [PATCH 1/2] 2. add set_pat extension for gem_create [PATCH 2/2] v2: drop one patch that was merged separately commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function") v3: rebased on

[PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Andi Shyti
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a def

Re: [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Tvrtko Ursulin
On 06/06/2023 11:00, Andi Shyti wrote: From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object cr

Re: [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Andi Shyti
On Tue, Jun 06, 2023 at 11:10:04AM +0100, Tvrtko Ursulin wrote: > > On 06/06/2023 11:00, Andi Shyti wrote: > > From: Fei Yang > > > > To comply with the design that buffer objects shall have immutable > > cache setting through out their life cycle, {set, get}_caching ioctl's > > are no longer su

Re: [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-06 Thread Sui Jingfeng
Hi, On 2023/6/6 10:06, Sui Jingfeng wrote: Originally, I also want to express the opinion. Originally,  I want to express the same opinion as you told me. Because vga_iostate_to_str() function is taking unsigned int parameter. so, I think, using 'unsigned int *' type as the third parameter

Re: [PATCH] Revert "drm/msm/dp: set self refresh aware based on PSR support"

2023-06-06 Thread Linux regression tracking #adding (Thorsten Leemhuis)
On 05.06.23 12:18, Johan Hovold wrote: > On Mon, Jun 05, 2023 at 01:05:36PM +0300, Dmitry Baryshkov wrote: >> On Mon, 5 Jun 2023 at 13:02, Johan Hovold wrote: > >>> Virtual terminals are still broken with 6.4-rc5 on the Lenovo ThinkPad >>> X13s two weeks after I reported this, and there has be

Re: [Nouveau] [PATCH v2] drm/nouveau: bring back blit subchannel for pre nv50 GPUs

2023-06-06 Thread Karol Herbst
On Fri, May 26, 2023 at 5:21 PM Ilia Mirkin wrote: > > On Fri, May 26, 2023 at 5:11 AM Karol Herbst wrote: > > > > 1ba6113a90a0 removed a lot of the kernel GPU channel, but method 0x128 > > was important as otherwise the GPU spams us with `CACHE_ERROR` messages. > > > > We use the blit subchannel

[PATCH 3/3] fbdev/hitfb: Use NULL for pointers

2023-06-06 Thread Thomas Zimmermann
Replace integer constants with NULL. Resolves the following warnings: ../drivers/video/fbdev/hitfb.c:447:23: warning: Using plain integer as NULL pointer ../drivers/video/fbdev/hitfb.c:465:23: warning: Using plain integer as NULL pointer Signed-off-by: Thomas Zimmermann --- drivers/video/fbde

[PATCH 0/3] fbdev/hitfb: Various fixes

2023-06-06 Thread Thomas Zimmermann
Fix a number of minor warnings in the hitfb driver. I discovered them while working on bb47f218fd01 ("fbdev/hitfb: Cast I/O offset to address"). Thomas Zimmermann (3): fbdev/hitfb: Declare hitfb_blank() as static fbdev/hitfb: Fix integer-to-pointer cast fbdev/hitfb: Use NULL for pointers d

[PATCH 1/3] fbdev/hitfb: Declare hitfb_blank() as static

2023-06-06 Thread Thomas Zimmermann
Fixes the following warnings: ../drivers/video/fbdev/hitfb.c:186:5: warning: no previous prototype for 'hitfb_blank' [-Wmissing-prototypes] 186 | int hitfb_blank(int blank_mode, struct fb_info *info) | ^~~ ../drivers/video/fbdev/hitfb.c:186:5: warning: symbol 'hitfb_blank' wa

[PATCH 2/3] fbdev/hitfb: Fix integer-to-pointer cast

2023-06-06 Thread Thomas Zimmermann
Fix the type casting from unsigned long to char __iomem *. Resolves the following warning: ../drivers/video/fbdev/hitfb.c:411:27: warning: incorrect type in assignment (different address spaces) ../drivers/video/fbdev/hitfb.c:411:27:expected char [noderef] __iomem *screen_base ../drivers/vid

Re: [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-06 Thread Andi Shyti
Hi Sui, On Tue, Jun 06, 2023 at 06:27:05PM +0800, Sui Jingfeng wrote: > Hi, > > On 2023/6/6 10:06, Sui Jingfeng wrote: > > Originally, I also want to express the opinion. > > > Originally,  I want to express the same opinion as you told me. > > Because vga_iostate_to_str() function is taking u

Re: [Intel-gfx] [PATCH] drm/i915: Implement fdinfo memory stats printing

2023-06-06 Thread Tvrtko Ursulin
On 06/06/2023 10:47, Tvrtko Ursulin wrote: On 05/06/2023 23:22, Andi Shyti wrote: Hi Tvrtko, On Mon, Jun 05, 2023 at 03:37:20PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver speci

Re: [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Joonas Lahtinen
Quoting Andi Shyti (2023-06-06 13:18:06) > On Tue, Jun 06, 2023 at 11:10:04AM +0100, Tvrtko Ursulin wrote: > > > > On 06/06/2023 11:00, Andi Shyti wrote: > > > From: Fei Yang > > > > > > To comply with the design that buffer objects shall have immutable > > > cache setting through out their life

Re: [Freedreno] [PATCH] drm/msm/dpu: re-introduce dpu core revision to the catalog

2023-06-06 Thread Dmitry Baryshkov
On Tue, 6 Jun 2023 at 05:35, Abhinav Kumar wrote: > > > > On 6/5/2023 6:03 PM, Dmitry Baryshkov wrote: > > On 06/06/2023 03:55, Abhinav Kumar wrote: > >> > >> > >> On 6/3/2023 7:21 PM, Dmitry Baryshkov wrote: > >>> On 31/05/2023 21:25, Abhinav Kumar wrote: > > > On 5/31/2023 3:07 AM

Re: [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Andi Shyti
> > > > To comply with the design that buffer objects shall have immutable > > > > cache setting through out their life cycle, {set, get}_caching ioctl's > > > > are no longer supported from MTL onward. With that change caching > > > > policy can only be set at object creation time. The current cod

Re: [PATCH v9 0/8] drm: Remove usage of deprecated DRM_* macros

2023-06-06 Thread Jani Nikula
On Tue, 06 Jun 2023, Siddh Raman Pant wrote: > This patchset aims to remove usages of deprecated DRM_* macros from the > files residing in drivers/gpu/drm root. > > In process, I found out that NULL as first argument of drm_dbg_* wasn't > working, but it was listed as the alternative in deprecatio

Re: [RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-06-06 Thread Iddamsetty, Aravind
On 05-06-2023 22:17, Alex Deucher wrote: > Adding the relevant AMD folks for RAS. We currently expose RAS via > sysfs, but also have an event interface in KFD which may be somewhat > similar to this. > > If we were to converge on a common RAS interface, would we want to > look at any commonali

RE: [PATCH 0/3] fbdev/hitfb: Various fixes

2023-06-06 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Tuesday, June 6, 2023 6:41 AM >To: del...@gmx.de; david.lai...@aculab.com >Cc: linux-fb...@vger.kernel.org; Thomas Zimmermann >; dri-devel@lists.freedesktop.org; linux- >s...@vger.kernel.org >Subject: [PATCH 0/3] f

Re: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR

2023-06-06 Thread Stanislaw Gruszka
On Thu, May 25, 2023 at 09:45:19PM -0700, Randy Dunlap wrote: > Drivers that use the gen_pool*() family of functions should > select GENERIC_ALLOCATOR to prevent build errors like these: > > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined r

[PATCH v6 01/12] dt-bindings: display/msm: dsi-controller-main: Add SM6350

2023-06-06 Thread Konrad Dybcio
Add the DSI host found on SM6350. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Docume

[PATCH v6 02/12] dt-bindings: display/msm: dsi-controller-main: Add SM6375

2023-06-06 Thread Konrad Dybcio
Add the DSI host found on SM6375. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Docume

[PATCH v6 00/12] SM63(50|75) DPU support

2023-06-06 Thread Konrad Dybcio
v5 -> v6: - Drop unnecessary items: level in bindings - Use INTF_SC7180_MASK for 6375 to avoid enabling DPU_INTF_DATA_COMPRESS on DPU6 - Pick up tags v5: https://lore.kernel.org/r/20230411-topic-straitlagoon_mdss-v5-0-998b4d2f7...@linaro.org v4 -> v5: - Rebase on next-20230522 (drop regdma, drop

[PATCH v6 03/12] dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375

2023-06-06 Thread Konrad Dybcio
SC7180, SM6350 and SM6375 use a rather similar hw setup for DPU, with the main exception being that the last one requires an additional throttle clock. It is not well understood yet, but failing to toggle it on makes the display hardware stall and not output any frames. Document SM6350 and SM6375

[PATCH v6 05/12] dt-bindings: display/msm: Add SM6375 MDSS

2023-06-06 Thread Konrad Dybcio
Document the SM6375 MDSS. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6375-mdss.yaml | 215 + 1 file changed, 215 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml b/Documentation/devicetree/bindings/dis

[PATCH v6 07/12] drm/msm: mdss: Add SM6350 support

2023-06-06 Thread Konrad Dybcio
Add support for MDSS on SM6350. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index e8c93731a

[PATCH v6 04/12] dt-bindings: display/msm: Add SM6350 MDSS

2023-06-06 Thread Konrad Dybcio
Document the SM6350 MDSS. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6350-mdss.yaml | 213 + 1 file changed, 213 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml b/Documentation/devicetree/bindings/dis

[PATCH v6 06/12] drm/msm/dpu: Add SM6350 support

2023-06-06 Thread Konrad Dybcio
Add SM6350 support to the DPU1 driver to enable display output. It's worth noting that one entry dpu_qos_lut_entry was trimmed off: {.fl = 0, .lut = 0x0011223344556677 }, due to the lack of support for selecting between portrait and landscape LUT settings (for danger and safe LUTs) and no full s

[PATCH v6 10/12] iommu/arm-smmu-qcom: Sort the compatible list alphabetically

2023-06-06 Thread Konrad Dybcio
It got broken at some point, fix it up. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-

[PATCH v6 12/12] iommu/arm-smmu-qcom: Add SM6350 DPU compatible

2023-06-06 Thread Konrad Dybcio
From: Konrad Dybcio Add the SM6350 DPU compatible to clients compatible list, as it also needs the workarounds. Signed-off-by: Konrad Dybcio Acked-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH v6 11/12] iommu/arm-smmu-qcom: Add SM6375 DPU compatible

2023-06-06 Thread Konrad Dybcio
Add the SM6375 DPU compatible to clients compatible list, as it also needs the workarounds. Acked-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/dr

[PATCH v6 08/12] drm/msm/dpu: Add SM6375 support

2023-06-06 Thread Konrad Dybcio
Add basic SM6375 support to the DPU1 driver to enable display output. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 139 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c |

[PATCH v6 09/12] drm/msm: mdss: Add SM6375 support

2023-06-06 Thread Konrad Dybcio
Add support for MDSS on SM6375. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 4e3a5f0c303c..0564

Re: [PATCH] accel/ivpu: Reserve all non-command bo's using DMA_RESV_USAGE_BOOKKEEP

2023-06-06 Thread Stanislaw Gruszka
On Thu, Apr 13, 2023 at 08:38:10AM +0200, Stanislaw Gruszka wrote: > Use DMA_RESV_USAGE_BOOKKEEP reservation for buffer objects, except for > command buffers for which we use DMA_RESV_USAGE_WRITE (since VPU can > write to command buffer context save area). > > Fixes: 0ec8671837a6 ("accel/ivpu: Fix

Re: [PATCH v9 1/8] Revert "drm: mipi-dsi: Convert logging to drm_* functions."

2023-06-06 Thread Laurent Pinchart
Hi Siddh, Thank you for the patch. On Tue, Jun 06, 2023 at 04:15:15PM +0530, Siddh Raman Pant wrote: > This reverts commit 1040e424353f5f4d39f6f3aa8723eb3bd6ea6446. > > It used an incorrect way to use drm_* functions. Only drm_device ptrs > should be passed, but the mentioned commit passed mipi_

Re: [PATCH v9 1/8] Revert "drm: mipi-dsi: Convert logging to drm_* functions."

2023-06-06 Thread Jani Nikula
On Tue, 06 Jun 2023, Laurent Pinchart wrote: > Hi Siddh, > > Thank you for the patch. > > On Tue, Jun 06, 2023 at 04:15:15PM +0530, Siddh Raman Pant wrote: >> This reverts commit 1040e424353f5f4d39f6f3aa8723eb3bd6ea6446. >> >> It used an incorrect way to use drm_* functions. Only drm_device ptrs

[PATCH] drm/amdgpu: display/Kconfig: replace leading spaces with tab

2023-06-06 Thread Sui Jingfeng
This patch replace the leading spaces with tab, make them keep aligned with the rest of the config options. No functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/amd/display/Kconfig | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu

Re: [PATCH 2/2] accel/ivpu: Do not use mutex_lock_interruptible

2023-06-06 Thread Stanislaw Gruszka
Hi On Fri, Jun 02, 2023 at 11:30:31AM -0600, Jeffrey Hugo wrote: > On 5/25/2023 4:38 AM, Stanislaw Gruszka wrote: > > If we get signal when waiting for the mmu->lock we do not invalidate > > current MMU configuration what might result on undefined behavior. > > "that might result in" > > > Addit

Re: [PATCH 2/2] drm/amd/display: mark dml314's UseMinimumDCFCLK() as noinline_for_stack

2023-06-06 Thread Alex Deucher
Series is: Acked-by: Alex Deucher On Mon, Jun 5, 2023 at 2:30 PM Hamza Mahfooz wrote: > > clang reports: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_mode_vba_314.c:3892:6: > error: stack frame size (2632) exceeds limit (2048) in > 'dml314_ModeSupportAndSystemConfigurationFull

Re: [Intel-xe] [RFC 1/5] drm/netlink: Add netlink infrastructure

2023-06-06 Thread Tomer Tayar
On 05/06/2023 20:18, Iddamsetty, Aravind wrote: > > On 04-06-2023 22:37, Tomer Tayar wrote: >> On 26/05/2023 19:20, Aravind Iddamsetty wrote: >>> Define the netlink commands and attributes that can be commonly used >>> across by drm drivers. >>> >>> Signed-off-by: Aravind Iddamsetty >>> --- >>>

Re: [PATCH v9 2/8] drm/print: Fix and add support for NULL as first argument in drm_* macros

2023-06-06 Thread Laurent Pinchart
Hi Siddh, Thank you for the patch. On Tue, Jun 06, 2023 at 04:15:16PM +0530, Siddh Raman Pant wrote: > Comments say macros DRM_DEBUG_* are deprecated in favor of > drm_dbg_*(NULL, ...), but they have broken support for it, > as the macro will result in `(NULL) ? (NULL)->dev : NULL`. What's the p

[PATCH v3 0/3] drm/panel: add fannal c3004 panel

2023-06-06 Thread Paulo Pavacic
Fannal C3004 is a 2 lane MIPI DSI 480x800 panel which requires initialization with DSI DCS commands. After few initialization commands delay is required. Paulo Pavacic (3): dt-bindings: add fannal vendor prefix dt-bindings: display: panel: add fannal,c3004 drm/panel-fannal-c3004: Add fannal

[PATCH v3 1/3] dt-bindings: add fannal vendor prefix

2023-06-06 Thread Paulo Pavacic
Fannal is a one-stop-solution provider for touch displays in industrial application, committed to delivering a variety of professional high-quality products and technical services globally. Website: www.fannal.com Signed-off-by: Paulo Pavacic --- Documentation/devicetree/bindings/vendor-prefixe

[PATCH v3 2/3] dt-bindings: display: panel: add fannal,c3004

2023-06-06 Thread Paulo Pavacic
Added fannal to vendor-prefixes and dt bindings for Fannal C3004. Fannal C3004 is a 480x800 MIPI DSI Panel which requires DCS initialization sequences with certain delays between certain commands. Signed-off-by: Paulo Pavacic --- v4 changelog: - add spaces between properties v3 changelog: - r

[PATCH v3 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel

2023-06-06 Thread Paulo Pavacic
Fannal C3004 is a 480x800 display made by fannal that requires DCS initialization sequences. Signed-off-by: Paulo Pavacic --- v4 changelog: - formatting and style changes - change community room v3 changelog: - using generic mipi_dsi_dcs_write_seq - removed success prints - removed some comm

Re: [PATCH v9 3/8] drm: Remove usage of deprecated DRM_INFO

2023-06-06 Thread Laurent Pinchart
Hi Siddh, Thank you for the patch. On Tue, Jun 06, 2023 at 04:15:17PM +0530, Siddh Raman Pant wrote: > drm_print.h says DRM_INFO is deprecated in favor of drm_info(). > > Signed-off-by: Siddh Raman Pant > --- > drivers/gpu/drm/drm_client_modeset.c | 2 +- > drivers/gpu/drm/drm_connector.c

[PATCH] drm/lima: fix sched context destroy

2023-06-06 Thread Erico Nunes
The drm sched entity must be flushed before finishing, to account for jobs potentially still in flight at that time. Lima did not do this flush until now, so switch the destroy call to the drm_sched_entity_destroy() wrapper which will take care of that. This fixes a regression on lima which starte

Re: [PATCH v9 7/8] drm: Remove usage of deprecated DRM_DEBUG_DRIVER

2023-06-06 Thread Laurent Pinchart
Hi Siddh, Thank you for the patch. On Tue, Jun 06, 2023 at 04:15:21PM +0530, Siddh Raman Pant wrote: > drm_print.h says DRM_DEBUG_DRIVER is deprecated. > Thus, use newer drm_dbg_driver(). > > Also fix the deprecation comment in drm_print.h which > mentions drm_dbg() instead of drm_dbg_driver().

Re: [PATCH v9 4/8] drm: Remove usage of deprecated DRM_NOTE

2023-06-06 Thread Laurent Pinchart
Hi Siddh, Thank you for the patch. On Tue, Jun 06, 2023 at 04:15:18PM +0530, Siddh Raman Pant wrote: > drm_print.h says DRM_NOTE is deprecated in favor of drm_notice(). > > Signed-off-by: Siddh Raman Pant With the commit message fixed as mentioned in the review of an earlier patch in this seri

Re: [PATCH v3 1/3] dt-bindings: add fannal vendor prefix

2023-06-06 Thread Krzysztof Kozlowski
On 06/06/2023 16:07, Paulo Pavacic wrote: > Fannal is a one-stop-solution provider for touch displays in industrial > application, committed to delivering a variety of professional high-quality > products and technical services globally. > > Website: www.fannal.com > > Signed-off-by: Paulo Pavaci

Re: [PATCH v3 2/3] dt-bindings: display: panel: add fannal,c3004

2023-06-06 Thread Krzysztof Kozlowski
On 06/06/2023 16:07, Paulo Pavacic wrote: > Added fannal to vendor-prefixes and dt bindings for Fannal C3004. > Fannal C3004 is a 480x800 MIPI DSI Panel which requires > DCS initialization sequences with certain delays between certain > commands. > > Signed-off-by: Paulo Pavacic > --- > v4 change

Re: [PATCH v9 5/8] drm: Remove usage of deprecated DRM_ERROR

2023-06-06 Thread Laurent Pinchart
Hi Siddh, Thank you for the patch. On Tue, Jun 06, 2023 at 04:15:19PM +0530, Siddh Raman Pant wrote: > drm_print.h says DRM_ERROR is deprecated in favor of drm_err(). > > Signed-off-by: Siddh Raman Pant > --- > drivers/gpu/drm/drm_bridge.c | 8 > drivers/gpu/drm/drm_bufs.c

Re: [PATCH v3 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel

2023-06-06 Thread Krzysztof Kozlowski
On 06/06/2023 16:07, Paulo Pavacic wrote: > Fannal C3004 is a 480x800 display made by fannal that requires > DCS initialization sequences. > > Signed-off-by: Paulo Pavacic > --- > v4 changelog: > - formatting and style changes Are you sure? I see other changes - removal of some code, handling e

Re: [PATCH v9 3/8] drm: Remove usage of deprecated DRM_INFO

2023-06-06 Thread Laurent Pinchart
On Tue, Jun 06, 2023 at 08:08:27PM +0530, Siddh Raman Pant wrote: > On Tue, 06 Jun 2023 19:53:22 +0530, Laurent Pinchart wrote: > > Hi Siddh, > > > > Thank you for the patch. > > Anytime :) > > > Any plan to remove it from drivers as well ? If not you should mention > > in the commit message (pr

Re: [PATCH v9 2/8] drm/print: Fix and add support for NULL as first argument in drm_* macros

2023-06-06 Thread Laurent Pinchart
On Tue, Jun 06, 2023 at 08:04:39PM +0530, Siddh Raman Pant wrote: > On Tue, 06 Jun 2023 19:35:12 +0530, Laurent Pinchart wrote: > > Hi Siddh, > > > > Thank you for the patch. > > Anytime :) > > > On Tue, Jun 06, 2023 at 04:15:16PM +0530, Siddh Raman Pant wrote: > > > Comments say macros DRM_DEBU

[PATCH 1/1] drm/bridge: Silence error messages upon probe deferral

2023-06-06 Thread Alexander Stein
When -EPROBE_DEFER is returned do not raise an error, but silently return this error instead. Fixes error like this: [drm:drm_bridge_attach] *ERROR* failed to attach bridge /soc@0/bus@3080/mipi-dsi@30a0 to encoder None-34: -517 [drm:drm_bridge_attach] *ERROR* failed to attach bridge /soc@

Re: [PATCH 2/2] accel/ivpu: Do not use mutex_lock_interruptible

2023-06-06 Thread Jeffrey Hugo
On 6/6/2023 7:44 AM, Stanislaw Gruszka wrote: Hi On Fri, Jun 02, 2023 at 11:30:31AM -0600, Jeffrey Hugo wrote: On 5/25/2023 4:38 AM, Stanislaw Gruszka wrote: If we get signal when waiting for the mmu->lock we do not invalidate current MMU configuration what might result on undefined behavior.

Re: [PATCH v2 2/3] dt-bindings: display: panel: add fannal,c3004

2023-06-06 Thread Krzysztof Kozlowski
On 06/06/2023 11:53, Paulo Pavacic wrote: >>> +#include >>> +dsi { >>> +#address-cells = <1>; >>> +#size-cells = <0>; >>> +panel@0 { >>> +compatible = "fannal,c3004"; >>> +reg = <0>; >>> +pinctrl-0 = <&pinctrl_mipi_dsi_rst>; >>> +

Re: [PATCH v2 3/3] drm/panel-fannal-c3003: Add fannal c3004 DSI panel

2023-06-06 Thread Krzysztof Kozlowski
On 06/06/2023 09:36, Paulo Pavacic wrote: >>> + >>> + if (IS_ERR(panel_data->reset)) { >>> + ret = PTR_ERR(panel_data->reset); >>> + dev_err(dev, >>> + "error: probe: get reset GPIO: (%d) Check the fdt\n", >>> + ret); >> >> return

Re: [PATCH v9 6/8] drm: Remove usage of deprecated DRM_DEBUG

2023-06-06 Thread Laurent Pinchart
Hi Siddh, Thank you for the patch. On Tue, Jun 06, 2023 at 04:15:20PM +0530, Siddh Raman Pant wrote: > drm_print.h says DRM_DEBUG is deprecated in favor of drm_dbg_core(). > > Signed-off-by: Siddh Raman Pant > --- > drivers/gpu/drm/drm_agpsupport.c | 4 +- > drivers/gpu/drm/drm_bufs.c

Re: [PATCH v9 8/8] drm: Remove usage of deprecated DRM_DEBUG_KMS

2023-06-06 Thread Laurent Pinchart
Hi Siddh, Thank you for the patch. On Tue, Jun 06, 2023 at 04:15:22PM +0530, Siddh Raman Pant wrote: > drm_print.h says DRM_DEBUG_KMS is deprecated in favor of > drm_dbg_kms(). > --- > drivers/gpu/drm/drm_client_modeset.c | 112 +++ > drivers/gpu/drm/drm_color_mgmt.c

  1   2   3   >