Re: [PATCH 07/14] drm/mgag200: Replace simple-KMS with regular atomic helpers

2023-04-26 Thread Thomas Zimmermann
Hi Am 26.04.23 um 01:39 schrieb ker...@linuxace.com: I'm not sure if this information is useful, but we have found one system which works with the 6.1 kernel. I grabbed the lspci output from a working and non-working system, pasted below. Same kernel and same distro. BAD Dell R815 AMD 0a:03.0

Re: [PATCH v3 17/21] drm/msm/dpu: Describe TEAR interrupt registers for DSI interfaces

2023-04-26 Thread Marijn Suijten
On 2023-04-26 03:05:12, Dmitry Baryshkov wrote: > On 26/04/2023 02:06, Marijn Suijten wrote: > > All SoCs since DPU 5.0.0 have the tear interrupt registers moved out of > > the PINGPONG block and into the INTF block. Wire up the IRQ register > > masks in the interrupt table for enabling, reading a

Re: [PATCH v3 17/21] drm/msm/dpu: Describe TEAR interrupt registers for DSI interfaces

2023-04-26 Thread Dmitry Baryshkov
On 26/04/2023 10:16, Marijn Suijten wrote: On 2023-04-26 03:05:12, Dmitry Baryshkov wrote: On 26/04/2023 02:06, Marijn Suijten wrote: All SoCs since DPU 5.0.0 have the tear interrupt registers moved out of the PINGPONG block and into the INTF block. Wire up the IRQ register masks in the interr

[lvc-project] [PATCH] drm/radeon: remove useless conditions

2023-04-26 Thread Igor Artemiev
Comparisons of 'table' and 'vddc_sclk_table' with NULL are useless since 'table' and 'vddc_sclk_table' are initialized by an addresses and cannot be NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Igor Artemiev --- drivers/gpu/drm/radeon/kv_dpm.c | 22

RE: [PATCH 07/14] drm/mgag200: Replace simple-KMS with regular atomic helpers

2023-04-26 Thread kernel
I'm not sure if this information is useful, but we have found one system which works with the 6.1 kernel. I grabbed the lspci output from a working and non-working system, pasted below. Same kernel and same distro. BAD Dell R815 AMD 0a:03.0 VGA compatible controller: Matrox Electronics Systems

RE: [PATCH 07/14] drm/mgag200: Replace simple-KMS with regular atomic helpers

2023-04-26 Thread kernel
On Tue, Apr 25, 2023 at 8:03 AM Thomas Zimmermann wrote: > You cannot really revert it, as it's too old already. But could you > please try the latest developer tree from > > git://anongit.freedesktop.org/drm/drm-tip > > The branch is drm-tip. Maybe the bug has been fixed meanwhile. If this

Re: [PATCH] drm/probe_helper: fix the warning reported when calling drm_kms_helper_poll_disable during suspend

2023-04-26 Thread zongmin zhou
On Sun, 2023-04-23 at 22:51 +0200, Janne Grunau wrote: > On 2023-04-20 23:07:01 +0300, Dmitry Baryshkov wrote: > > On Thu, 20 Apr 2023 at 23:01, Janne Grunau wrote: > > > > > > On 2023-03-28 10:31:29 +0800, Zongmin Zhou wrote: > > > > When drivers call drm_kms_helper_poll_disable from > > > > the

Re: [PATCH v1] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-04-26 Thread kernel test robot
e' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Arseniy-Krasnov/mtd-rawnand-macronix-OTP-access-for-MX30LFxG18AC/20230426-153143 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git

[PATCH] accel/habanalabs: Make use of rhashtable

2023-04-26 Thread Cai Huoqing
Using rhashtable to accelerate the search for userptr by address, instead of using a list. Preferably, the lookup complexity of a hash table is O(1). This patch will speedup the method hl_userptr_is_pinned by rhashtable_lookup_fast. Signed-off-by: Cai Huoqing --- .../habanalabs/common/command_

Re: [1/6] fbdev: Return number of bytes read or written

2023-04-26 Thread Sui Jingfeng
Hi, The whole patch set is tested with fbdev of IGT, on LoongArch with drm/radeon and efifb driver. Test results say SUCCESS. Tested-by: Sui Jingfeng On 2023/4/25 22:28, Thomas Zimmermann wrote: Always return the number of bytes read or written within the framebuffer. Only return an errno c

Re: [2/6] fbdev: Use screen_buffer in fb_sys_{read,write}()

2023-04-26 Thread Sui Jingfeng
Tested-by: Sui Jingfeng On 2023/4/25 22:28, Thomas Zimmermann wrote: Use info->screen_buffer when reading and writing framebuffers in system memory. It's the correct pointer for this address space. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbd

Re: [3/6] fbdev: Don't re-validate info->state in fb_ops implementations

2023-04-26 Thread Sui Jingfeng
Tested-by: Sui Jingfeng On 2023/4/25 22:28, Thomas Zimmermann wrote: The file-op entry points fb_read() and fb_write() verify that info->state has been set to FBINFO_STATE_RUNNING. Remove the same test from the implementations of struct fb_ops.{fb_read,fb_write}. Signed-off-by: Thomas Zimmerm

Re: [PATCH] drm/amdgpu: Mark contexts guilty for any reset type

2023-04-26 Thread Michel Dänzer
On 4/25/23 21:11, Marek Olšák wrote: > The last 3 comments in this thread contain arguments that are false and were > specifically pointed out as false 6 comments ago: Soft resets are just as > fatal as hard resets. There is nothing better about soft resets. If the VRAM > is lost completely, tha

Re: [PATCH 07/14] drm/mgag200: Replace simple-KMS with regular atomic helpers

2023-04-26 Thread Thomas Zimmermann
Am 26.04.23 um 09:01 schrieb Thomas Zimmermann: Hi Am 26.04.23 um 01:39 schrieb ker...@linuxace.com: I'm not sure if this information is useful, but we have found one system which works with the 6.1 kernel.  I grabbed the lspci output from a working and non-working system, pasted below.  Sam

Re: [4/6] fbdev: Validate info->screen_{base, buffer} in fb_ops implementations

2023-04-26 Thread Sui Jingfeng
Tested-by: Sui Jingfeng On 2023/4/25 22:28, Thomas Zimmermann wrote: Push the test for info->screen_base from fb_read() and fb_write() into the implementations of struct fb_ops.{fb_read,fb_write}. In cases where the driver operates on info->screen_buffer, test this field instead. Signed-off-by

Re: [5/6] fbdev: Move CFB read and write code into helper functions

2023-04-26 Thread Sui Jingfeng
Tested-by: Sui Jingfeng On 2023/4/25 22:28, Thomas Zimmermann wrote: Move the existing CFB read and write code for I/O memory into the new helpers fb_cfb_read() and fb_cfb_write(). Make them the default fp_ops. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martin

Re: [6/6] drm/fb-helper: Use fb_{cfb,sys}_{read, write}()

2023-04-26 Thread Sui Jingfeng
Tested-by: Sui Jingfeng On 2023/4/25 22:28, Thomas Zimmermann wrote: Implement DRM fbdev helpers for reading and writing framebuffer memory with the respective fbdev functions. Removes duplicate code. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/dr

Re: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-26 Thread Christian König
Am 26.04.23 um 02:48 schrieb Chia-I Wu: Good catch, but you need some commit message here. Something like "Need to hold the lock while iterating the idr to make sure no context is destroyed." should be sufficient. Apart from that looks good to me. Regards, Christian. Signed-off-by: Chia-I

Re: [PATCH 0/6] drm,fbdev: Use fbdev's I/O helpers

2023-04-26 Thread Sui Jingfeng
Hi, The whole patch set is tested with fbdev of IGT, on LoongArch with drm/radeon and efifb driver. Test results say SUCCESS. On 2023/4/25 22:28, Thomas Zimmermann wrote: Make fbdev's built-in helpers for reading and writing I/O and system memory available to DRM. Replace DRM's internal helpe

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-26 Thread Tvrtko Ursulin
On 26/04/2023 07:24, fei.y...@intel.com wrote: From: Fei Yang The first three patches in this series are taken from https://patchwork.freedesktop.org/series/116868/ These patches are included here because the last patch has dependency on the pat_index refactor. This series is focusing on uAP

[PATCH v4 0/3] drm/vkms: Add support for multiple pipes

2023-04-26 Thread Marius Vlad
With multiple pipe available we can perform management of outputs at a more granular level, such that we're able to turn off or on several outputs at a time, or combinations that arise from doing that. The Weston project use VKMS when running its test suite in CI, and we have now uses cases which

[PATCH v4 1/3] vkms: Pass the correct bitmask for possible crtcs

2023-04-26 Thread Marius Vlad
In preparation of having multiple pipelines we need to able to choose the correct encoder/connectors/crtc combination so pass also the index as a bitmask as possible CRTCs for the encoder. Signed-off-by: Marius Vlad --- drivers/gpu/drm/vkms/vkms_output.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v4 3/3] Documentation/gpu/vkms.rst: Added a note about plane migration

2023-04-26 Thread Marius Vlad
And remove the run-time configuration comment regarding needing first more than 1 pipe. Signed-off-by: Marius Vlad --- Documentation/gpu/vkms.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index 49db221c0f52..c

[PATCH v4 2/3] vkms: Add support for multiple pipes

2023-04-26 Thread Marius Vlad
This adds support for creating multiple virtual pipes, in case one would need to display multiple independent things on different outputs. We use a module parameter to specify how many to create, defaulting to just one with the possibility of specifying a maximum of 4 possible pipes. This is of

Re: [PATCH v2 2/3] vkms: Add support for multiple pipes

2023-04-26 Thread Marius Vlad
Hi, On 4/25/23 14:46, Maíra Canal wrote: On 4/25/23 04:44, Marius Vlad wrote: Hello, On 4/21/23 15:53, Maíra Canal wrote: On 4/21/23 04:05, Marius Vlad wrote: Hi Maíra, Thanks a lot for taking a look! On Thu, Apr 20, 2023 at 01:47:59PM -0300, Maíra Canal wrote: Hi Marius, Thanks for the

Re: [PATCH 1/3] drm/ttm: Helper function to get TTM mem limit

2023-04-26 Thread Christian König
Am 26.04.23 um 03:52 schrieb Mukul Joshi: Add a helper function to get TTM memory limit. This is needed by KFD to set its own internal memory limits. Signed-off-by: Mukul Joshi Reviewed-by: Christian König for the series. --- drivers/gpu/drm/ttm/ttm_tt.c | 6 ++ include/drm/ttm/ttm_

Re: [PATCH v2] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-26 Thread Christian König
Am 26.04.23 um 08:17 schrieb Chia-I Wu: mgr->ctx_handles should be protected by mgr->lock. v2: improve commit message Signed-off-by: Chia-I Wu Cc: sta...@vger.kernel.org Please don't manually CC sta...@vger.kernel.org while sending patches out, let us maintainers push that upstream with the

[PATCH] drm/amd/display: set variable custom_backlight_curve0 storage-class-specifier to static

2023-04-26 Thread Tom Rix
smatch reports drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:119:31: warning: symbol 'custom_backlight_curve0' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/di

Re: [PATCH] accel/habanalabs: Make use of rhashtable

2023-04-26 Thread Cai Huoqing
On 26 4月 23 17:28:02, Cai Huoqing wrote: > Using rhashtable to accelerate the search for userptr by address, > instead of using a list. > > Preferably, the lookup complexity of a hash table is O(1). > > This patch will speedup the method > hl_userptr_is_pinned by rhashtable_lookup_fast. > > Sign

Re: [PATCH 0/6] drm,fbdev: Use fbdev's I/O helpers

2023-04-26 Thread Thomas Zimmermann
Am 26.04.23 um 12:33 schrieb Sui Jingfeng: Hi, The whole patch set is tested with fbdev of IGT, on LoongArch with drm/radeon and efifb driver. Test results say SUCCESS. Thanks a lot. On 2023/4/25 22:28, Thomas Zimmermann wrote: Make fbdev's built-in helpers for reading and writing I/O

Re: [PATCH RESEND v3 0/9] Add gamma lut support for mt8195

2023-04-26 Thread AngeloGioacchino Del Regno
Il 12/09/22 03:29, Jason-JH.Lin ha scritto: Since the gamma_set_common() function for previous SoC, such as mt8173 and mt8183, is designed for 9bit-to-10bit conversion. mt8195 is using 10bit-to-12bit conversion, which is not compatible with the previous function. Thus, need to update the functi

Re: BUG: KASAN: null-ptr-deref in drm_sched_job_cleanup+0x96/0x290 [gpu_sched]

2023-04-26 Thread Christian König
Sending that once more from my mailing list address since AMD internal servers are blocking the mail. Regards, Christian. Am 26.04.23 um 13:48 schrieb Christian König: WTF? I own you a beer! I've fixed exactly that problem during the review process of the cleanup patch and because of this di

Re: IOCTL feature detection (Was: Re: [Intel-gfx] [PATCH 8/8] drm/i915: Allow user to set cache at BO creation)

2023-04-26 Thread Daniel Vetter
On Tue, Apr 25, 2023 at 04:41:54PM +0300, Joonas Lahtinen wrote: > (+ Faith and Daniel as they have been involved in previous discussions) > > Quoting Jordan Justen (2023-04-24 20:13:00) > > On 2023-04-24 02:08:43, Tvrtko Ursulin wrote: > > > > > > Being able to "list" supported extensions sounds

Re: [PATCH RESEND v3 6/9] drm/mediatek: Add gamma support different bank_size for other SoC

2023-04-26 Thread AngeloGioacchino Del Regno
Il 12/09/22 03:30, Jason-JH.Lin ha scritto: Add multiple bank support for mt8195. If bank size is 0 which means no bank support. Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 45 +-- 1 file changed, 26 insertions(+), 19 deletions(-) diff --g

Re: [PATCH v2 0/7] Allow dynamic allocation of software IO TLB bounce buffers

2023-04-26 Thread Greg Kroah-Hartman
On Wed, Apr 26, 2023 at 02:15:20PM +0200, Petr Tesařík wrote: > Hi, > > On Wed, 19 Apr 2023 12:03:52 +0200 > Petr Tesarik wrote: > > > From: Petr Tesarik > > > > The goal of my work is to provide more flexibility in the sizing of > > SWIOTLB. > > > > The software IO TLB was designed with thes

Re: [PATCH v2 0/7] Allow dynamic allocation of software IO TLB bounce buffers

2023-04-26 Thread Greg Kroah-Hartman
On Wed, Apr 26, 2023 at 02:44:39PM +0200, Petr Tesařík wrote: > Hi Greg, > > On Wed, 26 Apr 2023 14:26:36 +0200 > Greg Kroah-Hartman wrote: > > > On Wed, Apr 26, 2023 at 02:15:20PM +0200, Petr Tesařík wrote: > > > Hi, > > > > > > On Wed, 19 Apr 2023 12:03:52 +0200 > > > Petr Tesarik wrote: > >

Re: [PATCH v3 0/3] drm/vkms: Add support for multiple pipes

2023-04-26 Thread Marius Vlad
Hi Brandon, Xie, Thanks for reaching out, and for the heads-up. I need to take a closer look, but by glancing over it, using configFS would be really awesome. Think we could really benefit from having that in our CI and being able to customize the entire pipeline. I'm totally for that. It lo

[PATCH 0/5] fbdev: Move framebuffer I/O helpers to

2023-04-26 Thread Thomas Zimmermann
Fbdev provides helpers for framebuffer I/O, such as fb_readl(), fb_writel() or fb_memcpy_to_fb(). The implementation of each helper depends on the architecture. It's still all located in fbdev's main header file . Move all of it into each archtecture's , with shared code in . The first patch a sim

[PATCH 2/5] ipu-v3: Include

2023-04-26 Thread Thomas Zimmermann
The code uses readl() and writel(). Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann --- drivers/gpu/ipu-v3/ipu-prv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/ipu-v3/ipu-prv.h b/drivers/gpu/ipu-v3/ipu-prv.h index 291ac1bab66d..d4621b1ea7f1

[PATCH 4/5] fbdev: Include via

2023-04-26 Thread Thomas Zimmermann
Fbdev's main header file, , includes to get declarations for I/O helper functions. From these declaratons, later defines framebuffer I/O helpers, such as fb_{read,write}[bwlq]() or fb_memset(). The framebuffer I/O helpers depend on the system architecture and will therefore be moved into . Prepar

[PATCH 5/5] fbdev: Move framebuffer I/O helpers into

2023-04-26 Thread Thomas Zimmermann
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), in the architecture's header file or the generic one. The general solution is to use regular I/O functions, such as __raw_readb() or memset_io(). This has been the most-common case so far. The implementations for arc, ia64, l

[PATCH 3/5] fbdev: Include in various drivers

2023-04-26 Thread Thomas Zimmermann
The code uses writel() and similar I/O-memory helpers. Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/arcfb.c | 1 + drivers/video/fbdev/aty/atyfb.h | 2 ++ drivers/video/fbdev/wmt_ge_rops.c | 2 ++ 3 files changed, 5 insertions(

[PATCH 1/5] fbdev/matrox: Remove trailing whitespaces

2023-04-26 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++--- drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/matrox/matroxfb_accel.c

Re: [PATCH v1] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-04-26 Thread kernel test robot
e' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Arseniy-Krasnov/mtd-rawnand-macronix-OTP-access-for-MX30LFxG18AC/20230426-153143 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git

Re: [PATCH] drm/probe_helper: fix the warning reported when calling drm_kms_helper_poll_disable during suspend

2023-04-26 Thread Dmitry Baryshkov
On Wed, 26 Apr 2023 at 12:09, zongmin zhou wrote: > > On Sun, 2023-04-23 at 22:51 +0200, Janne Grunau wrote: > > On 2023-04-20 23:07:01 +0300, Dmitry Baryshkov wrote: > > > On Thu, 20 Apr 2023 at 23:01, Janne Grunau wrote: > > > > > > > > On 2023-03-28 10:31:29 +0800, Zongmin Zhou wrote: > > > >

Re: [PATCH v1] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-04-26 Thread kernel test robot
e' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Arseniy-Krasnov/mtd-rawnand-macronix-OTP-access-for-MX30LFxG18AC/20230426-153143 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git

Re: [PATCH 2/6] fbdev: Use screen_buffer in fb_sys_{read,write}()

2023-04-26 Thread Thomas Zimmermann
Hi Am 25.04.23 um 18:35 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Use info->screen_buffer when reading and writing framebuffers in system memory. It's the correct pointer for this address space. Maybe can expand the explanation a little bit with something like this? "The

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

2023-04-26 Thread Thomas Zimmermann
patch link: https://lore.kernel.org/r/20230425142846.730-6-tzimmermann%40suse.de patch subject: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions config: riscv-randconfig-s033-20230423 (https://download.01.org/0day-ci/archive/20230426/202304261317.qaewarcb-...@intel.com/config

Re: [PATCH 2/2] modules/firmware: add a new option to denote a firmware group to choose one.

2023-04-26 Thread Alex Deucher
On Wed, Apr 26, 2023 at 12:31 AM Dave Airlie wrote: > > From: Dave Airlie > > This adds a tag that will go into the module info, only one firmware from > the group given needs to be available for this driver to work. This allows > dracut to avoid adding in firmware that aren't needed. > > This ju

[PATCH V3 2/3] drm/panel: st7703: Rename CMD_UNKNOWN_C6 to CMD_SETECO

2023-04-26 Thread Chris Morgan
From: Chris Morgan A later revision of the datasheet for the ST7703 refers to this command as "SETECO". Signed-off-by: Chris Morgan Reviewed-by: Guido Günther --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu

[PATCH V3 0/3] drm/panel: Add Anbernic RG353V-V2 Panel

2023-04-26 Thread Chris Morgan
From: Chris Morgan Add the NewVision NV3051D panel as found on the second revision of the RG353V. The underlying LCD panel itself is unknown (ST7703 is the controller IC). Changes from V2: - Rebased patch series (to address removal of dsi_dcs_write_seq custom macro). Changes from V1: - Spl

[PATCH V3 3/3] drm/panel: st7703: Add Anbernic RG353V-V2 Panel Support

2023-04-26 Thread Chris Morgan
From: Chris Morgan The Anbernic RG353V-V2 is a 5 inch panel used in a new revision of the Anbernic RG353V handheld gaming device. Add support for it. Unfortunately it appears this controller is not able to support 120hz or 100hz mode like the first revision panel. Signed-off-by: Chris Morgan R

[PATCH V3 1/3] dt-bindings: panel: Add Anbernic RG353V-V2 panel compatible

2023-04-26 Thread Chris Morgan
From: Chris Morgan The Anbernic RG353V-V2 panel is a 3.5 inch 640x480 MIPI-DSI LCD panel. It's based on the ST7703 LCD controller just like rocktech,jh057n00900. It's used in a 2nd revision of the Anbernic RG353V handheld gaming device. Like the first revision of the RG353V the control chip is kn

Re: [PATCH 1/6] fbdev: Return number of bytes read or written

2023-04-26 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: > Always return the number of bytes read or written within the > framebuffer. Only return an errno code if framebuffer memory > was not touched. This is the semantics required by POSIX and > makes fb_read() and fb_write() compati

Re: [PATCH 2/6] fbdev: Use screen_buffer in fb_sys_{read,write}()

2023-04-26 Thread Geert Uytterhoeven
On Tue, Apr 25, 2023 at 6:36 PM Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > > Use info->screen_buffer when reading and writing framebuffers in > > system memory. It's the correct pointer for this address space. > > > > Maybe can expand the explanation a little bit with somethi

Re: [PATCH 3/6] fbdev: Don't re-validate info->state in fb_ops implementations

2023-04-26 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: > The file-op entry points fb_read() and fb_write() verify that > info->state has been set to FBINFO_STATE_RUNNING. Remove the same > test from the implementations of struct fb_ops.{fb_read,fb_write}. > > Signed-off-by: Thomas Zi

Re: [PATCH 4/6] fbdev: Validate info->screen_{base, buffer} in fb_ops implementations

2023-04-26 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: > Push the test for info->screen_base from fb_read() and fb_write() into > the implementations of struct fb_ops.{fb_read,fb_write}. In cases where > the driver operates on info->screen_buffer, test this field instead. > > Signed

Re: [PATCH V3 1/3] dt-bindings: panel: Add Anbernic RG353V-V2 panel compatible

2023-04-26 Thread Guido Günther
Hi Chris, could you check if these two modifications by Frank of the init sequence https://lore.kernel.org/dri-devel/20230211171748.36692-2-fr...@oltmanns.dev/ https://lore.kernel.org/dri-devel/20230213123238.76889-2-fr...@oltmanns.dev/ work for your panel too? Cheers, -- Guido On Wed, Ap

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

2023-04-26 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: > Move the existing CFB read and write code for I/O memory into > the new helpers fb_cfb_read() and fb_cfb_write(). Make them the > default fp_ops. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/vid

Re: [PATCH 1/6] fbdev: Return number of bytes read or written

2023-04-26 Thread Thomas Zimmermann
Hi Am 26.04.23 um 16:41 schrieb Geert Uytterhoeven: Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: Always return the number of bytes read or written within the framebuffer. Only return an errno code if framebuffer memory was not touched. This is the semantics required by

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

2023-04-26 Thread Thomas Zimmermann
Hi Am 26.04.23 um 17:01 schrieb Geert Uytterhoeven: Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: Move the existing CFB read and write code for I/O memory into the new helpers fb_cfb_read() and fb_cfb_write(). Make them the default fp_ops. No functional changes. Signed-

Re: [PATCH 3/6] fbdev: Don't re-validate info->state in fb_ops implementations

2023-04-26 Thread Thomas Zimmermann
Hi Am 26.04.23 um 16:49 schrieb Geert Uytterhoeven: Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: The file-op entry points fb_read() and fb_write() verify that info->state has been set to FBINFO_STATE_RUNNING. Remove the same test from the implementations of struct fb_op

Re: [PATCH 6/6] drm/fb-helper: Use fb_{cfb,sys}_{read, write}()

2023-04-26 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: > Implement DRM fbdev helpers for reading and writing framebuffer > memory with the respective fbdev functions. Removes duplicate > code. > > Signed-off-by: Thomas Zimmermann Thanks for your patch! > --- a/drivers/gpu/drm/drm_

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

2023-04-26 Thread Geert Uytterhoeven
Hi Thomas, On Wed, Apr 26, 2023 at 5:06 PM Thomas Zimmermann wrote: > Am 26.04.23 um 17:01 schrieb Geert Uytterhoeven: > > On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann > > wrote: > >> Move the existing CFB read and write code for I/O memory into > >> the new helpers fb_cfb_read() and fb_cf

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-26 Thread Yang, Fei
> On 26/04/2023 07:24, fei.y...@intel.com wrote: >> From: Fei Yang >> >> The first three patches in this series are taken from >> https://patchwork.freedesktop.org/series/116868/ >> These patches are included here because the last patch >> has dependency on the pat_index refactor. >> >> This serie

Keyword Review - Re: BUG: KASAN: null-ptr-deref in drm_sched_job_cleanup+0x96/0x290 [gpu_sched]

2023-04-26 Thread Christian König
WTF? I own you a beer! I've fixed exactly that problem during the review process of the cleanup patch and because of this didn't considered that the code is still there. It also explains why we don't see that in our testing. @Mikhail can you test that patch with drm-misc-next? Thanks, Christ

Re: [PATCH] drm/amdgpu: Mark contexts guilty for any reset type

2023-04-26 Thread Marek Olšák
Perhaps I should clarify this. There are GL and Vulkan features that if any app uses them and its shaders are killed, the next IB will hang. One of them is Draw Indirect - if a shader is killed before storing the vertex count and instance count in memory, the next draw will hang with a high probabi

Re: [PATCH v1 1/5] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-26 Thread Kuogee Hsieh
On 4/20/2023 4:54 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Signed-off-by: Kuogee Hsieh ---   drivers/gpu/drm/msm/Makefile   |   1 +   drivers/gpu/drm/msm/d

RE: [PATCH 2/3] drm/amdgpu: Set GTT size equal to TTM mem limit

2023-04-26 Thread Joshi, Mukul
[AMD Official Use Only - General] > -Original Message- > From: Chen, Guchun > Sent: Wednesday, April 26, 2023 2:00 AM > To: Joshi, Mukul ; amd-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org > Cc: Joshi, Mukul ; Kuehling, Felix > ; Koenig, Christian > Subject: RE: [PATCH 2

[PATCHv2 2/3] drm/amdgpu: Set GTT size equal to TTM mem limit

2023-04-26 Thread Mukul Joshi
Use the helper function in TTM to get TTM mem limit and set GTT size to be equal to TTL mem limit. Signed-off-by: Mukul Joshi Reviewed-by: Christian König --- v1->v2: - Remove AMDGPU_DEFAULT_GTT_SIZE_MB as well as it is unused. drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/

Re: [PATCH v3 06/21] drm/msm/dpu: Use V2 DITHER PINGPONG sub-block in SM8[34]50/SC8280XP

2023-04-26 Thread Abhinav Kumar
On 4/25/2023 4:05 PM, Marijn Suijten wrote: According to downstream sources this DITHER sub-block sits at an offset of 0xe0 with version 0x2. The PP_BLK_DITHER macro is _not_ used as downstream still says the size of the PINGPONG block is 0xd4 and not 0. the PINGPONG block size is 0x0

[PATCH] drm/i915/guc: Set wedged if enable guc communication failed

2023-04-26 Thread Zhanjun Dong
Add err code check for enable_communication on resume path. When resume failed, we can no longer use the GPU, marking the GPU as wedged. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 7 ++- drivers/gpu/drm/i915/gt/intel_reset.c | 19 --- drivers/gp

Re: [PATCH v10 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2023-04-26 Thread Doug Anderson
Hi, On Wed, Apr 19, 2023 at 8:43 AM Mark Yacoub wrote: > > Hi all, > This is v10 of the HDCP patches. The patches are authored by Sean Paul. > I rebased and addressed the review comments in v6-v10. > > Main change in v10 is handling the kernel test bot warnings. > > Patches 1-4 focus on moving th

Re: IOCTL feature detection (Was: Re: [Intel-gfx] [PATCH 8/8] drm/i915: Allow user to set cache at BO creation)

2023-04-26 Thread Teres Alexis, Alan Previn
On Wed, 2023-04-26 at 13:52 +0200, Daniel Vetter wrote: > On Tue, Apr 25, 2023 at 04:41:54PM +0300, Joonas Lahtinen wrote: > > (+ Faith and Daniel as they have been involved in previous discussions) > > Quoting Jordan Justen (2023-04-24 20:13:00) > > > On 2023-04-24 02:08:43, Tvrtko Ursulin wrote:

Re: [PATCH] drm/amd/display: set variable custom_backlight_curve0 storage-class-specifier to static

2023-04-26 Thread Hamza Mahfooz
On 4/26/23 07:18, Tom Rix wrote: smatch reports drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:119:31: warning: symbol 'custom_backlight_curve0' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by:

Re: [PATCH 1/5] drm/i915/guc: Don't capture Gen8 regs on Xe devices

2023-04-26 Thread John Harrison
On 4/25/2023 10:55, Teres Alexis, Alan Previn wrote: On Thu, 2023-04-06 at 15:26 -0700, Harrison, John C wrote: From: John Harrison A pair of pre-Xe registers were being included in the Xe capture list. GuC was rejecting those as being invalid and logging errors about them. So, stop doing it.

Re: [PATCH] drm/amd/display: Correctly initialize some memory in get_available_dsc_slices()

2023-04-26 Thread Hamza Mahfooz
On 4/25/23 03:53, Christophe JAILLET wrote: The intent here is to clear the 'available_slices' buffer before setting some values in it. This is an array of int, so in order to fully initialize it, we must clear MIN_AVAILABLE_SLICES_SIZE * sizeof(int) bytes. Compute the right length of the buffe

Re: [Intel-gfx] [PATCH 4/5] drm/i915/guc: Capture list clean up - 3

2023-04-26 Thread John Harrison
On 4/25/2023 12:05, Teres Alexis, Alan Previn wrote: On Thu, 2023-04-06 at 15:26 -0700,john.c.harri...@intel.com wrote: From: John Harrison Fix Xe_LP name. Signed-off-by: John Harrison alan:snip -/* GEN9/XE_LPD - Render / Compute Per-Engine-Instance */ +/* GEN8+ Render / Compute Per-Engin

Re: [Intel-gfx] [PATCH 4/5] drm/i915/guc: Capture list clean up - 3

2023-04-26 Thread John Harrison
On 4/26/2023 10:29, John Harrison wrote: On 4/25/2023 12:05, Teres Alexis, Alan Previn wrote: On Thu, 2023-04-06 at 15:26 -0700,john.c.harri...@intel.com wrote: From: John Harrison Fix Xe_LP name. Signed-off-by: John Harrison alan:snip -/* GEN9/XE_LPD - Render / Compute Per-Engine-Instan

mainline build failure due to 322458c2bb1a ("drm/ttm: Reduce the number of used allocation orders for TTM pages")

2023-04-26 Thread Sudip Mukherjee (Codethink)
Hi All, The latest mainline kernel branch fails to build powerpc allmodconfig with the error: drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified 'global_write_combined' at file scope 73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER]; |

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Capture list clean up - 2

2023-04-26 Thread John Harrison
On 4/25/2023 11:54, Teres Alexis, Alan Previn wrote: On Thu, 2023-04-06 at 15:26 -0700, john.c.harri...@intel.com wrote: From: John Harrison Don't use 'xe_lp*' prefixes for register lists that are common with Gen8. alan:snip @@ -177,32 +177,32 @@ static const struct __guc_mmio_reg_descr

Re: IOCTL feature detection (Was: Re: [Intel-gfx] [PATCH 8/8] drm/i915: Allow user to set cache at BO creation)

2023-04-26 Thread Ceraolo Spurio, Daniele
On 4/26/2023 9:48 AM, Teres Alexis, Alan Previn wrote: On Wed, 2023-04-26 at 13:52 +0200, Daniel Vetter wrote: On Tue, Apr 25, 2023 at 04:41:54PM +0300, Joonas Lahtinen wrote: (+ Faith and Daniel as they have been involved in previous discussions) Quoting Jordan Justen (2023-04-24 20:13:00)

Re: [PATCH v8 6/8] drm/i915/uapi/pxp: Add a GET_PARAM for PXP

2023-04-26 Thread Teres Alexis, Alan Previn
On Thu, 2023-04-20 at 22:34 -0700, Teres Alexis, Alan Previn wrote: > Because of the additional firmware, component-driver and > initialization depedencies required on MTL platform before a > PXP context can be created, UMD calling for PXP creation as a > way to get-caps can take a long time. An ac

[PATCH 6/6] drm/i915/guc: Capture list clean up - 5

2023-04-26 Thread John . C . Harrison
From: John Harrison Rename the 'default_' register list prefix to 'gen8_' as that is the more accurate name. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/g

Re: mainline build failure due to 322458c2bb1a ("drm/ttm: Reduce the number of used allocation orders for TTM pages")

2023-04-26 Thread Linus Torvalds
On Wed, Apr 26, 2023 at 10:44 AM Sudip Mukherjee (Codethink) wrote: > > drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified > 'global_write_combined' at file scope >73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER]; > | ^~~~

[GIT PULL] fbdev fixes and updates for v6.4-rc1

2023-04-26 Thread Helge Deller
Hi Linus, please pull the fbdev updates for v6.4-rc1. Nothing really exiting in here. The majority of lines changed is due to Uwe's preparation patches to change the return value of the .remove() callback to void. Thanks! Helge The following changes since commit e8d018dd0257f744ca50a729e3d042

[PATCH] drm/syncobj: Add deadline support for syncobj waits

2023-04-26 Thread Rob Clark
From: Rob Clark Add a new flag to let userspace provide a deadline as a hint for syncobj and timeline waits. This gives a hint to the driver signaling the backing fences about how soon userspace needs it to compete work, so it can addjust GPU frequency accordingly. An immediate deadline can be

[PATCH v2 net-next 0/6] Brcm ASP 2.0 Ethernet controller

2023-04-26 Thread Justin Chen
v2 - Updates to yaml dt documentation - Replace a couple functions with helper functions - Minor formatting fixes - Fix a few WoL issues Add support for the Broadcom ASP 2.0 Ethernet controller which is first introduced with 72165. Add support for 74165 10/100 inte

[PATCH v2 net-next 1/6] dt-bindings: net: brcm, unimac-mdio: Add asp-v2.0

2023-04-26 Thread Justin Chen
The ASP 2.0 Ethernet controller uses a brcm unimac. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml b/Doc

[PATCH v2 net-next 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-04-26 Thread Justin Chen
From: Florian Fainelli Add a binding document for the Broadcom ASP 2.0 Ethernet controller. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- .../devicetree/bindings/net/brcm,asp-v2.0.yaml | 145 + 1 file changed, 145 insertions(+) create mode 100644 Docu

[PATCH v2 net-next 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165

2023-04-26 Thread Justin Chen
From: Florian Fainelli 74165 is a 16nm process SoC with a 10/100 integrated Ethernet PHY, utilize the recently defined 16nm EPHY macro to configure that PHY. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen Reviewed-by: Andrew Lunn --- drivers/net/phy/bcm7xxx.c | 1 + include/linux

[PATCH v2 net-next 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support

2023-04-26 Thread Justin Chen
Add mdio compat string for ASP 2.0 ethernet driver. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen Reviewed-by: Andrew Lunn --- drivers/net/mdio/mdio-bcm-unimac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mdio/mdio-bcm-unimac.c b/drivers/net/mdio/mdio-bcm-u

[PATCH v2 net-next 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-04-26 Thread Justin Chen
Add support for the Broadcom ASP 2.0 Ethernet controller which is first introduced with 72165. This controller features two distinct Ethernet ports that can be independently operated. This patch supports: - Wake-on-LAN using magic packets - basic ethtool operations (link, counters, message level)

[PATCH v2 net-next 6/6] MAINTAINERS: ASP 2.0 Ethernet driver maintainers

2023-04-26 Thread Justin Chen
Add maintainers entry for ASP 2.0 Ethernet driver. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4fc57dfd5fd0..24cbe1c0fc06 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -41

Re: mainline build failure due to 322458c2bb1a ("drm/ttm: Reduce the number of used allocation orders for TTM pages")

2023-04-26 Thread Christian König
Am 26.04.23 um 20:30 schrieb Linus Torvalds: On Wed, Apr 26, 2023 at 10:44 AM Sudip Mukherjee (Codethink) wrote: drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified 'global_write_combined' at file scope 73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER];

Re: [PATCH v3 06/21] drm/msm/dpu: Use V2 DITHER PINGPONG sub-block in SM8[34]50/SC8280XP

2023-04-26 Thread Marijn Suijten
On 2023-04-26 09:24:19, Abhinav Kumar wrote: > > > On 4/25/2023 4:05 PM, Marijn Suijten wrote: > > According to downstream sources this DITHER sub-block sits at an offset > > of 0xe0 with version 0x2. The PP_BLK_DITHER macro is _not_ used as > > downstream still says the size of the PINGPONG

Re: [PATCH v3 06/21] drm/msm/dpu: Use V2 DITHER PINGPONG sub-block in SM8[34]50/SC8280XP

2023-04-26 Thread Abhinav Kumar
On 4/26/2023 12:08 PM, Marijn Suijten wrote: On 2023-04-26 09:24:19, Abhinav Kumar wrote: On 4/25/2023 4:05 PM, Marijn Suijten wrote: According to downstream sources this DITHER sub-block sits at an offset of 0xe0 with version 0x2. The PP_BLK_DITHER macro is _not_ used as downstream s

[PATCH 2/4] drm/msm/dpu: remove DPU_DSPP_IGC handling in dspp flush

2023-04-26 Thread Abhinav Kumar
Inverse gamma correction blocks (IGC) are not used today so lets remove the usage of DPU_DSPP_IGC in the dspp flush to make it easier to remove IGC from the catalog. We can add this back when IGC is properly supported in DPU with one of the standard DRM properties. Signed-off-by: Abhinav Kumar -

[PATCH 3/4] drm/msm/dpu: remove GC related code from dpu catalog

2023-04-26 Thread Abhinav Kumar
Since Gamma Correction (GC) block is currently unused, drop related code from the dpu hardware catalog otherwise this becomes a burden to carry across chipsets in the catalog. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Link: https://lore.kernel.org/r/20230421224721.12738-2-quic_a

[PATCH 1/4] drm/msm/dpu: remove DPU_DSPP_GC handling in dspp flush

2023-04-26 Thread Abhinav Kumar
Gamma correction blocks (GC) are not used today so lets remove the usage of DPU_DSPP_GC in the dspp flush to make it easier to remove GC from the catalog. We can add this back when GC is properly supported in DPU with one of the standard DRM properties. Signed-off-by: Abhinav Kumar Reviewed-by:

  1   2   >