Re: [PATCH 3/6] fbdev: Don't re-validate info->state in fb_ops implementations

[Thomas Zimmermann]

Hi

Am 26.04.23 um 16:49 schrieb Geert Uytterhoeven:

Hi Thomas,

On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann <tzimmerm...@suse.de> wrote:

The file-op entry points fb_read() and fb_write() verify that
info->state has been set to FBINFO_STATE_RUNNING. Remove the same
test from the implementations of struct fb_ops.{fb_read,fb_write}.

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>

Thanks for your patch!

  drivers/video/fbdev/core/fb_sys_fops.c | 6 ------
  drivers/video/fbdev/sm712fb.c          | 6 ------

Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>

But there are several other fbdev drivers to fix:
drivers/media/pci/ivtv/ivtvfb.c
drivers/video/fbdev/broadsheetfb.c
drivers/video/fbdev/hecubafb.c
drivers/video/fbdev/metronomefb.c

Best regards
Thomas

Ok, I'll go through the various patches in this patchset and check if they need to be done elsewhere as well.

Gr{oetje,eeting}s,

                         Geert

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

OpenPGP_signature
Description: OpenPGP digital signature