Re: [PATCH v3 0/6] arm64: dts: qcom: sm8350: enable GPU on the HDK board

2023-02-10 Thread Neil Armstrong
On 09/02/2023 14:38, Dmitry Baryshkov wrote: Add A660 device to the Qualcomm SM8350 platform and enable it for the sm8350-hdk board. Unfortunately while adding the GPU & related devices I noticed that DT nodes on SM8350 are greatly out of the adress sorting order, so patches 2-4 reorder DT nodes

Re: [PATCH v11 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-02-10 Thread Pin-yen Lin
On Thu, Feb 9, 2023 at 9:58 PM Rob Herring wrote: > > On Wed, Feb 8, 2023 at 10:00 PM Pin-yen Lin wrote: > > > > Hi Rob, > > > > Thanks for the review. > > > > On Wed, Feb 8, 2023 at 4:52 AM Rob Herring wrote: > > > > > > On Sat, Feb 04, 2023 at 09:30:38PM +0800, Pin-yen Lin wrote: > > > > ITE I

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

2023-02-10 Thread Pekka Paalanen
On Thu, 9 Feb 2023 13:27:02 -0100 Melissa Wen wrote: > On 01/31, Pekka Paalanen wrote: > > On Mon, 9 Jan 2023 14:38:09 -0100 > > Melissa Wen wrote: > > > > > On 01/09, Melissa Wen wrote: > > > > Hi, > > > > > > > > After collecting comments in different places, here is a second version > >

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-10 Thread Pekka Paalanen
On Thu, 09 Feb 2023 17:03:19 + Simon Ser wrote: > On Thursday, February 9th, 2023 at 17:38, Joshua Ashton > wrote: > > > > I mean, the strings are the uAPI, not the integers, right? > > > > Both are uAPI these days. > > Yes. The integers are uAPI, if you change them you'll break libli

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-10 Thread Pekka Paalanen
On Thu, 9 Feb 2023 15:10:38 +0200 Ville Syrjälä wrote: > On Thu, Feb 09, 2023 at 01:58:55PM +0200, Pekka Paalanen wrote: > > On Wed, 8 Feb 2023 23:10:16 +0200 > > Ville Syrjala wrote: > > > > > From: Ville Syrjälä > > > > > > Add a new immutable plane property by which a plane can advertis

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-10 Thread Simon Ser
On Friday, February 10th, 2023 at 10:37, Pekka Paalanen wrote: > On Thu, 09 Feb 2023 17:03:19 + > Simon Ser cont...@emersion.fr wrote: > > > On Thursday, February 9th, 2023 at 17:38, Joshua Ashton jos...@froggi.es > > wrote: > > > > > > I mean, the strings are the uAPI, not the integers,

Re: linux-next: duplicate patch in the drm-misc-fixes tree

2023-02-10 Thread Thomas Zimmermann
Hi Am 10.02.23 um 01:08 schrieb David Airlie: On Fri, Feb 10, 2023 at 9:47 AM Stephen Rothwell wrote: Hi all, The following commit is also in the drm-fixes tree as a different commit (but the same patch): 94d8b6572a1f ("nvidiafb: detect the hardware support before removing console.") T

Re: [PATCH v2] fbdev: Fix invalid page access after closing deferred I/O devices

2023-02-10 Thread Thomas Zimmermann
Am 29.01.23 um 09:28 schrieb Takashi Iwai: When a fbdev with deferred I/O is once opened and closed, the dirty pages still remain queued in the pageref list, and eventually later those may be processed in the delayed work. This may lead to a corruption of pages, hitting an Oops. This patch ma

[PATCH] drm/amd/display: Remove duplicate/repeating expressions

2023-02-10 Thread Deepak R Varma
Remove duplicate or repeating expressions in the if condition evaluation. Issue identified using doubletest.cocci Coccinelle semantic patch. Signed-off-by: Deepak R Varma --- .../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c| 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) d

[PATCH] drm/amd/display: Remove duplicate/repeating expression

2023-02-10 Thread Deepak R Varma
Remove duplicate or repeating expressions in the if condition evaluation. Issue identified using doubletest.cocci Coccinelle semantic patch. Signed-off-by: Deepak R Varma --- .../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH v2] fbdev: Fix invalid page access after closing deferred I/O devices

2023-02-10 Thread Thomas Zimmermann
Added to drm-misc-fixes. Am 29.01.23 um 09:28 schrieb Takashi Iwai: When a fbdev with deferred I/O is once opened and closed, the dirty pages still remain queued in the pageref list, and eventually later those may be processed in the delayed work. This may lead to a corruption of pages, hitting

Re: [PATCH v3 0/6] arm64: dts: qcom: sm8350: enable GPU on the HDK board

2023-02-10 Thread Dmitry Baryshkov
address) > > - Rebased on top of latest Bjorn's tree > > Can you specify which tree and commit ? > > I tried next-20230207, next-20230208 & next-20230209 and patch 2 doesn't > apply. It was crafted on top of Bjorn's tree and as such it applies on top of 20230210

[PATCH v2 2/5] arm64: dts: qcom: sm8350: switch to combo usb3/dp phy

2023-02-10 Thread Neil Armstrong
The first QMP PHY is an USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 40 1 file changed, 13 insertions(+), 27 del

[PATCH v2 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS

2023-02-10 Thread Neil Armstrong
Switch the QMP PHY to the newly documented USB3/DP Combo PHY bindings at [1] and add the DP controller nodes. The DP output is shared with the USB3 SuperSpeed lanes and is usually connected to an USB-C port which Altmode is controlled by the PMIC Glink infrastructure in discution at [2] & [3]. DT

[PATCH v2 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-10 Thread Neil Armstrong
The SM8450 & SM350 shares the same DT TX IP version, use the SM8350 compatible as fallback for SM8450. Signed-off-by: Neil Armstrong --- .../bindings/display/msm/dp-controller.yaml| 25 +- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/Documentation/d

[PATCH v2 3/5] arm64: dts: qcom: sm8350: add dp controller

2023-02-10 Thread Neil Armstrong
Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 82 +++- 1 file changed, 80 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/q

[PATCH v2 5/5] arm64: dts: qcom: sm8450: add dp controller

2023-02-10 Thread Neil Armstrong
Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 84 ++-- 1 file changed, 81 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/q

[PATCH v2 4/5] arm64: dst: qcom: sm8450: switch to usb3/dp combo phy

2023-02-10 Thread Neil Armstrong
The QMP PHY is a USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 41 1 file changed, 14 insertions(+), 27 deletions(

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-02-10 Thread Laurent Pinchart
Hello Pin-yen, On Fri, Feb 10, 2023 at 03:38:00PM +0800, Pin-yen Lin wrote: > On Tue, Feb 7, 2023 at 11:21 PM Laurent Pinchart wrote: > > On Tue, Feb 07, 2023 at 06:30:36PM +0800, Pin-yen Lin wrote: > > > On Tue, Feb 7, 2023 at 6:25 PM Laurent Pinchart wrote: > > > > On Tue, Feb 07, 2023 at 06:07:

Re: [Cc: drm-misc folks] Re: [Intel-gfx] [CI 1/4] drm/i915/dp_mst: Add the MST topology state for modesetted CRTCs

2023-02-10 Thread Jani Nikula
On Thu, 09 Feb 2023, Lyude Paul wrote: > On Tue, 2023-02-07 at 14:59 +0200, Imre Deak wrote: >> Hi all, >> >> On Mon, Feb 06, 2023 at 01:48:53PM +0200, Imre Deak wrote: >> > Add the MST topology for a CRTC to the atomic state if the driver >> > needs to force a modeset on the CRTC after the encod

Re: [PATCH] drm: Disable dynamic debug as broken

2023-02-10 Thread Jani Nikula
On Tue, 07 Feb 2023, Greg Kroah-Hartman wrote: > On Tue, Feb 07, 2023 at 04:33:37PM +0200, Jani Nikula wrote: >> From: Ville Syrjälä >> >> CONFIG_DRM_USE_DYNAMIC_DEBUG breaks debug prints for (at least modular) >> drm drivers. The debug prints can be reinstated by manually frobbing >> /sys/modul

Re: [PATCH v2 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-10 Thread Krzysztof Kozlowski
On 10/02/2023 11:34, Neil Armstrong wrote: > The SM8450 & SM350 shares the same DT TX IP version, use the > SM8350 compatible as fallback for SM8450. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/5] arm64: dts: qcom: sm8350: switch to combo usb3/dp phy

2023-02-10 Thread Konrad Dybcio
On 10.02.2023 11:34, Neil Armstrong wrote: > The first QMP PHY is an USB3/DP combo phy, switch to the newly > documented bindings and register the clocks to the GCC > and DISPCC controllers. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 40 > ---

Re: [PATCH 1/4] drm/gem-vram: handle NULL bo->resource in move callback

2023-02-10 Thread Christian König
Am 08.02.23 um 15:53 schrieb Matthew Auld: The ttm BO now initially has NULL bo->resource, and leaves the driver the handle that. However it looks like we forgot to handle that for ttm_bo_move_memcpy() users, like with vram-gem, since it just silently returns zero. This seems to then trigger warn

Re: [PATCH v3 3/6] arm64: dts: qcom: sm8350: move more nodes to correct place

2023-02-10 Thread Konrad Dybcio
On 9.02.2023 14:38, Dmitry Baryshkov wrote: > Continue ordering DT nodes by their address. Move RNG, UFS, system NoC > and SLPI nodes to the proper position. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sm8350.dtsi | 314

Re: [PATCH v2 2/5] arm64: dts: qcom: sm8350: switch to combo usb3/dp phy

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 12:34, Neil Armstrong wrote: The first QMP PHY is an USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Signed-off-by: Neil Armstrong With the following few nits fixed: Reviewed-by: Dmitry Baryshkov --- arch

Re: [PATCH v3 0/6] arm64: dts: qcom: sm8350: enable GPU on the HDK board

2023-02-10 Thread neil . armstrong
Can you specify which tree and commit ? I tried next-20230207, next-20230208 & next-20230209 and patch 2 doesn't apply. It was crafted on top of Bjorn's tree and as such it applies on top of 20230210 without any issues. Ack, will rebase my DP stuff on that, Thanks, Neil

Re: [PATCH v2 3/5] arm64: dts: qcom: sm8350: add dp controller

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 12:34, Neil Armstrong wrote: Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 82 +++- 1 file changed, 80 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boo

Re: [PATCH v3 4/6] arm64: dts: qcom: sm8350: finish reordering nodes

2023-02-10 Thread Konrad Dybcio
On 9.02.2023 14:38, Dmitry Baryshkov wrote: > Finish reordering DT nodes by their address. Move PDC, tsens, AOSS, > SRAM, SPMI and TLMM nodes to the proper position. > > Signed-off-by: Dmitry Baryshkov > --- [...] > + phys = <&mdss_dsi1_phy>; > + > +

Re: [PATCH v3 5/6] arm64: dts: qcom: sm8350: add GPU, GMU, GPU CC and SMMU nodes

2023-02-10 Thread Konrad Dybcio
On 9.02.2023 14:38, Dmitry Baryshkov wrote: > Add device nodes required to enable GPU on the SM8350 platform. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 178 +++ > 1 file changed, 178 insertions(+) > > diff --git a/arch/arm64/bo

Re: [PATCH v3 4/6] arm64: dts: qcom: sm8350: finish reordering nodes

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 13:09, Konrad Dybcio wrote: On 9.02.2023 14:38, Dmitry Baryshkov wrote: Finish reordering DT nodes by their address. Move PDC, tsens, AOSS, SRAM, SPMI and TLMM nodes to the proper position. Signed-off-by: Dmitry Baryshkov --- [...] + phys = <&md

Re: [PATCH v3 4/6] arm64: dts: qcom: sm8350: finish reordering nodes

2023-02-10 Thread Konrad Dybcio
On 10.02.2023 12:12, Dmitry Baryshkov wrote: > On 10/02/2023 13:09, Konrad Dybcio wrote: >> >> >> On 9.02.2023 14:38, Dmitry Baryshkov wrote: >>> Finish reordering DT nodes by their address. Move PDC, tsens, AOSS, >>> SRAM, SPMI and TLMM nodes to the proper position. >>> >>> Signed-off-by: Dmitr

Re: [PATCH v3 5/6] arm64: dts: qcom: sm8350: add GPU, GMU, GPU CC and SMMU nodes

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 13:10, Konrad Dybcio wrote: On 9.02.2023 14:38, Dmitry Baryshkov wrote: Add device nodes required to enable GPU on the SM8350 platform. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 178 +++ 1 file changed, 178 insertions(

Re: [PATCH v2 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 12:34, Neil Armstrong wrote: Switch the QMP PHY to the newly documented USB3/DP Combo PHY bindings at [1] and add the DP controller nodes. The DP output is shared with the USB3 SuperSpeed lanes and is usually connected to an USB-C port which Altmode is controlled by the PMIC Glink

[PATCH v4 1/2] dt-bindings: display: imx: Describe drm binding for fsl, imx-lcdc

2023-02-10 Thread Uwe Kleine-König
Modify the existing (fb-like) binding to support the drm-like binding in parallel. Signed-off-by: Uwe Kleine-König --- .../bindings/display/imx/fsl,imx-lcdc.yaml| 46 ++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/i

[PATCH v4 0/2] drm/imx/lcdc: Implement DRM driver for imx25

2023-02-10 Thread Uwe Kleine-König
Hello, Changes since v3: - Don't use drm_of_find_panel_or_bridge, rely on panel-bridges instead (Sam) - Add support for XRGB (Sam) - Make sure Kconfig + Makefile are added to the patch (*sigh*) (Philipp) - Rebase on a newer tree (which involves among others changes for 8ab59da26bc0 ("d

[PATCH v4 2/2] drm/imx/lcdc: Implement DRM driver for imx25

2023-02-10 Thread Uwe Kleine-König
From: Marian Cichy Add support for the LCD Controller found on i.MX21 and i.MX25. It targets to be a drop in replacement for the imx-fb driver. Signed-off-by: Marian Cichy [ukl: Rebase to a newer kernel version, various smaller fixes and improvements] Signed-off-by: Uwe Kleine-König --- driv

Re: [Intel-gfx] [PATCH 1/2] drm/print: Add drm_dbg_ratelimited

2023-02-10 Thread Andi Shyti
Hi, > can any of the DRM maintainers please check and eventually ack > this patch? I renew my request for an ack from any of the drm maintainers. This patch has been already reviewd. If it's OK I can take it into the drm-intel-gt-next branch. Thanks, Andi > On Tue, Jan 17, 2023 at 12:53:49PM +

Re: [PATCH v4 2/2] drm/imx/lcdc: Implement DRM driver for imx25

2023-02-10 Thread Laurent Pinchart
On Fri, Feb 10, 2023 at 12:31:16PM +0100, Uwe Kleine-König wrote: > From: Marian Cichy > > Add support for the LCD Controller found on i.MX21 and i.MX25. > > It targets to be a drop in replacement for the imx-fb driver. > > Signed-off-by: Marian Cichy > [ukl: Rebase to a newer kernel version,

Re: [Nouveau] [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-02-10 Thread Christian König
Am 07.02.23 um 11:50 schrieb Danilo Krummrich: On 2/7/23 10:35, Christian König wrote: [SNIP] Just to have it all in place, the example I gave was:  - two virtually contiguous buffers A and B  - binding 1 mapped to A with BO offset 0  - binding 2 mapped to B with BO offset length(A) What I

Re: Try to address the drm_debugfs issues

2023-02-10 Thread Christian König
Am 09.02.23 um 19:48 schrieb Maxime Ripard: On Thu, Feb 09, 2023 at 04:52:54PM +0100, Christian König wrote: Am 09.02.23 um 15:19 schrieb Maxime Ripard: On Thu, Feb 09, 2023 at 03:06:10PM +0100, Christian König wrote: Am 09.02.23 um 14:06 schrieb Maíra Canal: On 2/9/23 09:13, Christian König

Re: Try to address the drm_debugfs issues

2023-02-10 Thread Maxime Ripard
On Fri, Feb 10, 2023 at 01:07:39PM +0100, Christian König wrote: > Am 09.02.23 um 19:48 schrieb Maxime Ripard: > > On Thu, Feb 09, 2023 at 04:52:54PM +0100, Christian König wrote: > > > Am 09.02.23 um 15:19 schrieb Maxime Ripard: > > > > On Thu, Feb 09, 2023 at 03:06:10PM +0100, Christian König wro

Re: [PATCH v2 4/5] arm64: dst: qcom: sm8450: switch to usb3/dp combo phy

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 12:34, Neil Armstrong wrote: The QMP PHY is a USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 41

Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()

2023-02-10 Thread Javier Martinez Canillas
On 2/6/23 19:47, Javier Martinez Canillas wrote: > Hello Lina, > > On 2/5/23 13:51, Asahi Lina wrote: >> Other functions touching shmem->sgt take the pages lock, so do that here >> too. drm_gem_shmem_get_pages() & co take the same lock, so move to the >> _locked() variants to avoid recursive locki

Re: [Nouveau] [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-02-10 Thread Danilo Krummrich
On 2/10/23 12:50, Christian König wrote: Am 07.02.23 um 11:50 schrieb Danilo Krummrich: On 2/7/23 10:35, Christian König wrote: However, I still don't see why we would want to merge over buffer boundaries, because ultimately we'll end up splitting such a merged mapping later on anyway on

[RFC v2 0/5] Waitboost drm syncobj waits

2023-02-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it. Problem i

[RFC 3/5] drm/i915: Waitboost external waits

2023-02-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Userspace waits coming via the drm_syncobj route have so far been bypassing the waitboost mechanism. Use the previously added dma-fence wait tracking API and apply the same waitboosting logic which applies to other entry points. This should fix the perfomance regressions ex

[RFC 1/5] dma-fence: Track explicit waiters

2023-02-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Track how many callers are explicity waiting on a fence to signal and allow querying that via new dma_fence_wait_count() API. This provides infrastructure on top of which generic "waitboost" concepts can be implemented by individual drivers. Wait-boosting is any reactive act

[RFC 2/5] drm/syncobj: Mark syncobj waits as external waiters

2023-02-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the previously added dma-fence tracking of explicit waiters. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_syncobj.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 0c

[RFC 4/5] drm/i915: Mark waits as explicit

2023-02-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the previously added dma-fence API to mark the direct i915 waits as explicit. This has no significant effect apart from following the new pattern. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_request.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[RFC 5/5] drm/i915: Wait boost requests waited upon by others

2023-02-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added dma-fence API to apply waitboost not only requests which have been marked with I915_WAIT_PRIORITY by i915, but which may be waited upon by others (such as for instance buffer sharing in multi-GPU scenarios). Signed-off-by: Tvrtko Ursulin --- drivers/gpu

Re: Try to address the drm_debugfs issues

2023-02-10 Thread Christian König
Am 10.02.23 um 13:18 schrieb Maxime Ripard: [SNIP] Well you don't seem to understand what I'm talking about. I would certainly like you to stop making those kind of statements. Apart from creating unnecessary tension, they don't bring anything to the discussion. Sorry for saying that. It was

Re: [1/2] drm/msm/dpu: fix clocks settings for msm8998 SSPP blocks

2023-02-10 Thread Dmitry Baryshkov
On 24/01/2023 11:59, Marijn Suijten wrote: On 2023-01-15 14:41:42, Dmitry Baryshkov wrote: DMA2 and DMA3 planes on msm8998 should use corresponding DMA2 and DMA3 clocks rather than CURSOR0/1 clocks (which are used for the CURSOR planes). Correct corresponding SSPP declarations. Fixes: 94391a14f

Re: [PATCH v2 5/5] drm/v3d: Use drm_sched_job_add_syncobj_dependency()

2023-02-10 Thread Melissa Wen
On 02/09, Maíra Canal wrote: > As v3d_job_add_deps() performs the same steps as > drm_sched_job_add_syncobj_dependency(), replace the open-coded > implementation in v3d in order to simply use the DRM function. > > Signed-off-by: Maíra Canal > --- > drivers/gpu/drm/v3d/v3d_gem.c | 22

[PATCH v2] drm/msm/dpu: disable features unsupported by QCM2290

2023-02-10 Thread Dmitry Baryshkov
QCM2290 doesn't seem to support reg-dma, UBWC and CSC. Drop corresponding features being incorrectly enabled for qcm2290. Cc: Loic Poulain Fixes: 5334087ee743 ("drm/msm: add support for QCM2290 MDSS") Signed-off-by: Dmitry Baryshkov --- Changes since v1: - Reenabled CDP, exclusion rectangles an

Re: [PATCH v4 1/2] dt-bindings: display: imx: Describe drm binding for fsl,imx-lcdc

2023-02-10 Thread Rob Herring
On Fri, 10 Feb 2023 12:31:15 +0100, Uwe Kleine-König wrote: > Modify the existing (fb-like) binding to support the drm-like binding in > parallel. > > Signed-off-by: Uwe Kleine-König > --- > .../bindings/display/imx/fsl,imx-lcdc.yaml| 46 ++- > 1 file changed, 45 insertions

[PATCH] drm/i915/gt: Make sure that errors are propagated through request chains

2023-02-10 Thread Andi Shyti
Currently, for operations like memory clear or copy for big chunks of memory, we generate multiple requests executed in a chain. But if one of the requests generated fails we would not know it to unless it happens to the last request, because errors are not properly propagated. For this we need t

[PATCH] drm/msm/dpu: set DPU_MDP_PERIPH_0_REMOVED for sc8280xp

2023-02-10 Thread Dmitry Baryshkov
The SC8280XP also has a black hole at the top of MDP_TOP region. Set corresponding bit to disable access to that region. Fixes: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- 1 file changed, 1 insertion(

Re: [PATCH v2 3/5] arm64: dts: qcom: sm8350: add dp controller

2023-02-10 Thread Neil Armstrong
On 10/02/2023 12:08, Dmitry Baryshkov wrote: On 10/02/2023 12:34, Neil Armstrong wrote: Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong ---   arch/arm64/boot/dts/qcom/sm8350.dtsi | 82 +++-   1 file changed, 80 insertions(+

Re: [PATCH] drm/msm/dpu: set DPU_MDP_PERIPH_0_REMOVED for sc8280xp

2023-02-10 Thread Neil Armstrong
On 10/02/2023 15:15, Dmitry Baryshkov wrote: The SC8280XP also has a black hole at the top of MDP_TOP region. Set corresponding bit to disable access to that region. Fixes: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_h

Re: [PATCH v2 3/5] arm64: dts: qcom: sm8350: add dp controller

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 16:18, Neil Armstrong wrote: On 10/02/2023 12:08, Dmitry Baryshkov wrote: On 10/02/2023 12:34, Neil Armstrong wrote: Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong ---   arch/arm64/boot/dts/qcom/sm8350.dtsi | 82 +

[PATCH] drm/v3d: New debugfs end-points to query GPU usage stats.

2023-02-10 Thread Jose Maria Casanova Crespo
Two new debugfs interfaces are implemented to expose the usage stats of the GPU scheduling queues. - gpu_usage: exposes the total runtime since boot of each of the 5 scheduling queues available at V3D (BIN, RENDER, CSD, TFU, CACHE_CLEAN). So if the interface is queried at two different points of t

[PATCH v3 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS

2023-02-10 Thread Neil Armstrong
Switch the QMP PHY to the newly documented USB3/DP Combo PHY bindings at [1] and add the DP controller nodes. The DP output is shared with the USB3 SuperSpeed lanes and is usually connected to an USB-C port which Altmode is controlled by the PMIC Glink infrastructure in discution at [2] & [3]. DT

[PATCH v3 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-10 Thread Neil Armstrong
The SM8450 & SM350 shares the same DT TX IP version, use the SM8350 compatible as fallback for SM8450. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/display/msm/dp-controller.yaml| 25 +- 1 file changed, 15 insertions(+), 10 deletion

[PATCH v3 2/5] arm64: dts: qcom: sm8350: switch to combo usb3/dp phy

2023-02-10 Thread Neil Armstrong
The first QMP PHY is an USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Reviewed-by: Dmitry Baryshkov Tested-by: Dmitry Baryshkov #SM8350-HDK Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 42 ++

[PATCH v3 4/5] arm64: dts: qcom: sm8450: switch to usb3/dp combo phy

2023-02-10 Thread Neil Armstrong
The QMP PHY is a USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 42 +--- 1 file changed, 15 insertions(+), 27 deletions(

[PATCH v3 3/5] arm64: dts: qcom: sm8350: add dp controller

2023-02-10 Thread Neil Armstrong
Add the Display Port controller subnode to the MDSS node. Tested-by: Dmitry Baryshkov #SM8350-HDK Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 79 1 file changed, 79 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi

[PATCH v3 5/5] arm64: dts: qcom: sm8450: add dp controller

2023-02-10 Thread Neil Armstrong
Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 79 1 file changed, 79 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2023-02-10 Thread Janusz Krzysztofik
Hi Isabella, On Monday, 19 September 2022 22:55:44 CET Isabella Basso wrote: > Hi, Janusz, > > > Am 09/09/2022 um 12:18 PM schrieb Janusz Krzysztofik > > : > > > > ... > > > > Anyway, related to my comment about naming that function a parser, I think > > the > > best approach would be for th

Re: [PATCH v3] drm/ast: Fix start address computation

2023-02-10 Thread Jocelyn Falempe
On 10/02/2023 01:33, Jammy Huang wrote: On 2023/2/9 下午 05:55, Thomas Zimmermann wrote: Am 09.02.23 um 10:44 schrieb Jocelyn Falempe: During the driver conversion to shmem, the start address for the scanout buffer was set to the base PCI address. In most cases it works because only the lower

Re: [PATCH v3 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 16:44, Neil Armstrong wrote: The SM8450 & SM350 shares the same DT TX IP version, use the SM8350 compatible as fallback for SM8450. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/display/msm/dp-controller.yaml| 25 +-

Re: [PATCH v3 3/5] arm64: dts: qcom: sm8350: add dp controller

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 16:44, Neil Armstrong wrote: Add the Display Port controller subnode to the MDSS node. Tested-by: Dmitry Baryshkov #SM8350-HDK Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 79 1 file changed, 79 insertions(+) R

Re: [PATCH v3 4/5] arm64: dts: qcom: sm8450: switch to usb3/dp combo phy

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 16:44, Neil Armstrong wrote: The QMP PHY is a USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 42 +---

Re: [PATCH] drm/amd/display: Remove duplicate/repeating expression

2023-02-10 Thread Harry Wentland
On 2/10/23 05:11, Deepak R Varma wrote: > Remove duplicate or repeating expressions in the if condition > evaluation. Issue identified using doubletest.cocci Coccinelle semantic > patch. > > Signed-off-by: Deepak R Varma Reviewed-by: Harry Wentland Harry > --- > .../gpu/drm/amd/display/dc/dm

Re: [PATCH v3 5/5] arm64: dts: qcom: sm8450: add dp controller

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 16:44, Neil Armstrong wrote: Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 79 1 file changed, 79 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm845

Re: [PATCH v3 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-10 Thread Neil Armstrong
On 10/02/2023 16:16, Dmitry Baryshkov wrote: On 10/02/2023 16:44, Neil Armstrong wrote: The SM8450 & SM350 shares the same DT TX IP version, use the SM8350 compatible as fallback for SM8450. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong ---   .../bindings/display/msm/dp-contr

Re: [PATCH v3 5/5] arm64: dts: qcom: sm8450: add dp controller

2023-02-10 Thread Neil Armstrong
On 10/02/2023 16:24, Dmitry Baryshkov wrote: On 10/02/2023 16:44, Neil Armstrong wrote: Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong ---   arch/arm64/boot/dts/qcom/sm8450.dtsi | 79   1 file changed, 79 insertions(+

Re: [PATCH v3 5/5] arm64: dts: qcom: sm8450: add dp controller

2023-02-10 Thread Dmitry Baryshkov
On 10/02/2023 17:28, Neil Armstrong wrote: On 10/02/2023 16:24, Dmitry Baryshkov wrote: On 10/02/2023 16:44, Neil Armstrong wrote: Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong ---   arch/arm64/boot/dts/qcom/sm8450.dtsi | 79 +

Re: [PATCH 1/3] drm/msm/adreno: Add Adreno A690 support

2023-02-10 Thread Rob Clark
On Tue, Feb 7, 2023 at 7:41 PM Bjorn Andersson wrote: > > From: Bjorn Andersson > > Introduce support for the Adreno A690, found in Qualcomm SC8280XP. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 120 ++

Re: [RFC] drm/msm/adreno: Balance pm_runtime enable

2023-02-10 Thread Rob Clark
On Fri, Feb 3, 2023 at 10:12 AM Bjorn Andersson wrote: > > When any of the components in the mdss hierarchy fails to bind, > previously bound components are being unbound again. > > One such case happens when the DP controller fails to find its bridge or > panel, where adreno_unbind() will be invo

[PATCH 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-02-10 Thread Jianhua Lu
Novatek NT36523 is a display driver IC that can drive DSI panel. It is also present in the csot and boe video mode panels. It is found in Xiaomi Mi Pad 5 series. Signed-off-by: Jianhua Lu --- .../display/panel/novatek,nt36523.yaml| 101 ++ 1 file changed, 101 insertions(+

[PATCH 2/2] drm/panel: Add driver for Novatek NT36523

2023-02-10 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 Display Driver IC, including support for the csot and boe panels right now, found in Xiaomi Mi Pad 5 series. Signed-off-by: Jianhua Lu --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 9

Re: error: 'const struct dc_dsc_config' has no member named 'is_frl'

2023-02-10 Thread Alex Deucher
On Thu, Feb 9, 2023 at 11:38 PM Randy Dunlap wrote: > > Hi, > > The 'is_frl' struct field is conditional: > > #if defined(CONFIG_DRM_AMD_DC_DCN) > bool is_frl; /* indicate if DSC is applied based on HDMI FRL sink's > capability */ > #endif > > so code that uses it should be careful, other

Re: [PATCH] drm/v3d: New debugfs end-points to query GPU usage stats.

2023-02-10 Thread kernel test robot
Hi Jose, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.2-rc7 next-20230210] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH] drm: Disable dynamic debug as broken

2023-02-10 Thread jim . cromie
On Tue, Feb 7, 2023 at 10:21 AM Jani Nikula wrote: > > From: Ville Syrjälä > > CONFIG_DRM_USE_DYNAMIC_DEBUG breaks debug prints for (at least modular) > drm drivers. The debug prints can be reinstated by manually frobbing > /sys/module/drm/parameters/debug after the fact, but at that point the >

[PATCH v5 2/2] drm/imx/lcdc: Implement DRM driver for imx25

2023-02-10 Thread Uwe Kleine-König
From: Marian Cichy Add support for the LCD Controller found on i.MX21 and i.MX25. It targets to be a drop in replacement for the imx-fb driver. Signed-off-by: Marian Cichy [ukl: Rebase to a newer kernel version, various smaller fixes and improvements] Signed-off-by: Uwe Kleine-König --- driv

[PATCH v5 0/2] drm/imx/lcdc: Implement DRM driver for imx25

2023-02-10 Thread Uwe Kleine-König
Hello, Changes since v4: - Explicitly handle the connector and pass DRM_BRIDGE_ATTACH_NO_CONNECTOR to drm_bridge_attach (Laurent) - Fix binding syntax hopfully makeing Rob's dt-checker bot happy - Resort #includes alphabetically A big thanks to Philipp who (again!) was a great help to get

[PATCH v5 1/2] dt-bindings: display: imx: Describe drm binding for fsl, imx-lcdc

2023-02-10 Thread Uwe Kleine-König
Modify the existing (fb-like) binding to support the drm-like binding in parallel. Signed-off-by: Uwe Kleine-König --- .../bindings/display/imx/fsl,imx-lcdc.yaml| 46 ++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/i

Re: [PATCH] drm/amd/display: Remove duplicate/repeating expression

2023-02-10 Thread Deepak R Varma
On Fri, Feb 10, 2023 at 10:22:00AM -0500, Harry Wentland wrote: > On 2/10/23 05:11, Deepak R Varma wrote: > > Remove duplicate or repeating expressions in the if condition > > evaluation. Issue identified using doubletest.cocci Coccinelle semantic > > patch. > > > > Signed-off-by: Deepak R Varma

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-02-10 Thread Linux regression tracking (Thorsten Leemhuis)
On 08.02.23 09:48, Chris Clayton wrote: > > I'm assuming that we are not going to see a fix for this regression before > 6.2 is released. Yeah, looks like it. That's unfortunate, but happens. But there is still time to fix it and there is one thing I wonder: Did any of the nouveau developers l

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-02-10 Thread Karol Herbst
On Fri, Feb 10, 2023 at 7:35 PM Linux regression tracking (Thorsten Leemhuis) wrote: > > On 08.02.23 09:48, Chris Clayton wrote: > > > > I'm assuming that we are not going to see a fix for this regression before > > 6.2 is released. > > Yeah, looks like it. That's unfortunate, but happens. But t

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-02-10 Thread Linux regression tracking (Thorsten Leemhuis)
On 10.02.23 20:01, Karol Herbst wrote: > On Fri, Feb 10, 2023 at 7:35 PM Linux regression tracking (Thorsten > Leemhuis) wrote: >> >> On 08.02.23 09:48, Chris Clayton wrote: >>> >>> I'm assuming that we are not going to see a fix for this regression before >>> 6.2 is released. >> >> Yeah, looks

Re: [PATCH] drm/amd/display: Remove duplicate/repeating expressions

2023-02-10 Thread Harry Wentland
On 2/10/23 05:00, Deepak R Varma wrote: > Remove duplicate or repeating expressions in the if condition > evaluation. Issue identified using doubletest.cocci Coccinelle semantic > patch. > > Signed-off-by: Deepak R Varma Reviewed-by: Harry Wentland Harry > --- > .../gpu/drm/amd/display/dc/dm

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

2023-02-10 Thread Harry Wentland
On 2/10/23 04:28, Pekka Paalanen wrote: > On Thu, 9 Feb 2023 13:27:02 -0100 > Melissa Wen wrote: > >> On 01/31, Pekka Paalanen wrote: >>> On Mon, 9 Jan 2023 14:38:09 -0100 >>> Melissa Wen wrote: >>> On 01/09, Melissa Wen wrote: > Hi, > > After collecting comments in diff

Re: [PATCH v5 2/2] drm/imx/lcdc: Implement DRM driver for imx25

2023-02-10 Thread Uwe Kleine-König
Hello, On Fri, Feb 10, 2023 at 07:00:14PM +0100, Uwe Kleine-König wrote: > + ret = drm_bridge_attach(&lcdc->pipe.encoder, lcdc->bridge, NULL, > DRM_BRIDGE_ATTACH_NO_CONNECTOR); > + if (ret) > + return dev_err_probe(drm->dev, ret, "Cannot attach bridge\n"); > + > + lcdc->co

Re: [PATCH v2] drm/msm/dpu: disable features unsupported by QCM2290

2023-02-10 Thread Abhinav Kumar
On 2/10/2023 5:50 AM, Dmitry Baryshkov wrote: QCM2290 doesn't seem to support reg-dma, UBWC and CSC. Drop corresponding features being incorrectly enabled for qcm2290. Cc: Loic Poulain Fixes: 5334087ee743 ("drm/msm: add support for QCM2290 MDSS") Signed-off-by: Dmitry Baryshkov --- Changes

Re: [PATCH] drm/msm/dpu: set DPU_MDP_PERIPH_0_REMOVED for sc8280xp

2023-02-10 Thread Abhinav Kumar
On 2/10/2023 6:15 AM, Dmitry Baryshkov wrote: The SC8280XP also has a black hole at the top of MDP_TOP region. Set corresponding bit to disable access to that region. Fixes: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/d

Re: [PATCH 00/24 v2] Documentation: correct lots of spelling errors (series 1)

2023-02-10 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 8 Feb 2023 23:13:36 -0800 you wrote: > Correct many spelling errors in Documentation/ as reported by codespell. > > Maintainers of specific kernel subsystems are only Cc-ed on their > respective patches,

[PATCH v2] drm/msm/dpu: set DPU_MDP_PERIPH_0_REMOVED for sc8280xp

2023-02-10 Thread Dmitry Baryshkov
The SC8280XP also has a black hole at the top of MDP_TOP region. Set corresponding bit to disable access to that region. Fixes: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP") Reviewed-by: Abhinav Kumar Reviewed-by: Neil Armstrong Signed-off-by: Dmitry Baryshkov --- Changes since v1: rebase o

[PATCH 00/43] drm/msm/dpu: rework HW catalog

2023-02-10 Thread Dmitry Baryshkov
This huge series attempts to restructure the DPU HW catalog into a manageable and reviewable data set. First 3 patches clean up the catalog a bit. Then the next batch of 13 + 5 patches split the hw catalog entries into per-SoC files. Next 14 patches rework catalog entries, mostly targeting QSEED

  1   2   >