Re: [PATCH 13/23] drm/rockchip: Make use of the helper component_compare_dev

2022-02-14 Thread Heiko Stübner
Am Montag, 14. Februar 2022, 07:08:09 CET schrieb Yong Wu: > Use the common compare helper from component. > > Cc: Sandy Huang > Cc: "Heiko St¨¹bner" > Cc: linux-rockc...@lists.infradead.org > Signed-off-by: Yong Wu Acked-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-14 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Feb 10, 2022 at 4:24 PM Thomas Zimmermann wrote: > Fbdev's deferred I/O sorts all dirty pages by default, which incurs a > significant overhead. Make the sorting step optional and update the few > drivers that require it. Use a FIFO list by default. > > Sorting pages by memory

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-14 Thread Thomas Zimmermann
Hi Am 14.02.22 um 09:05 schrieb Geert Uytterhoeven: Hi Thomas, On Thu, Feb 10, 2022 at 4:24 PM Thomas Zimmermann wrote: Fbdev's deferred I/O sorts all dirty pages by default, which incurs a significant overhead. Make the sorting step optional and update the few drivers that require it. Use a

Re: [PATCH v12 1/5] drm: improve drm_buddy_alloc function

2022-02-14 Thread Matthew Auld
On Mon, 14 Feb 2022 at 06:32, Christian König wrote: > > Am 13.02.22 um 09:52 schrieb Arunpravin: > > - Make drm_buddy_alloc a single function to handle > >range allocation and non-range allocation demands > > > > - Implemented a new function alloc_range() which allocates > >the requested

[PATCH v3] drm/mediatek: allow commands to be sent during video mode

2022-02-14 Thread Julien STEPHAN
Mipi dsi panel drivers can use mipi_dsi_dcs_{set,get}_display_brightness() to request backlight changes. This can be done during panel initialization (dsi is in command mode) or afterwards (dsi is in Video Mode). When the DSI is in Video Mode, all commands are rejected. Detect current DSI mode i

Re: [PATCH v5 2/6] drm/format-helper: Add drm_fb_xrgb8888_to_mono_reversed()

2022-02-14 Thread Javier Martinez Canillas
Hello Geert, Thanks for your feedback. On 2/12/22 16:54, Geert Uytterhoeven wrote: [snip] >> + >> + for (i = start; i < end; i++) { >> + unsigned int x = xb * 8 + i; >> + >> + byte >>= 1; >> + if (src[x] >> 7) >> +

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-14 Thread Lukas Wunner
On Mon, Feb 14, 2022 at 09:34:26AM +0200, Mika Westerberg wrote: > On Fri, Feb 11, 2022 at 03:45:46PM -0600, Bjorn Helgaas wrote: > > My expectation is that "USB" (like "PCI" and "PCIe") tells me > > something about how a device is electrically connected and how > > software can operate it. It doe

Re: [PATCH] drm/doc: Clarify what ioctls can be used on render nodes

2022-02-14 Thread Pekka Paalanen
On Wed, 9 Feb 2022 11:57:27 -0700 Jeffrey Hugo wrote: > The documentation for render nodes indicates that only "PRIME-related" > ioctls are valid on render nodes, but the documentation does not clarify > what that means. If the reader is not familiar with PRIME, they may > beleive this to be onl

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Thomas Zimmermann
Hi Am 11.02.22 um 16:41 schrieb Andy Shevchenko: [...] IMO *always* prefer a for loop over while or do-while. The for (i = 0; i < N; i++) is such a strong paradigm in C. You instantly know how many times you're going to loop, at a glance. Not so with with the alternatives, which should be used

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-14 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Feb 14, 2022 at 9:28 AM Thomas Zimmermann wrote: > Am 14.02.22 um 09:05 schrieb Geert Uytterhoeven: > > On Thu, Feb 10, 2022 at 4:24 PM Thomas Zimmermann > > wrote: > >> Fbdev's deferred I/O sorts all dirty pages by default, which incurs a > >> significant overhead. Make the

Re: [PATCH v12 1/5] drm: improve drm_buddy_alloc function

2022-02-14 Thread Christian König
Am 14.02.22 um 09:36 schrieb Matthew Auld: On Mon, 14 Feb 2022 at 06:32, Christian König wrote: Am 13.02.22 um 09:52 schrieb Arunpravin: - Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which

Re: [PATCH v3] drm/mediatek: allow commands to be sent during video mode

2022-02-14 Thread AngeloGioacchino Del Regno
Il 14/02/22 09:47, Julien STEPHAN ha scritto: Mipi dsi panel drivers can use mipi_dsi_dcs_{set,get}_display_brightness() to request backlight changes. This can be done during panel initialization (dsi is in command mode) or afterwards (dsi is in Video Mode). When the DSI is in Video Mode, all c

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Pekka Paalanen
On Fri, 11 Feb 2022 19:27:12 +0200 Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 06:25:17PM +0200, Jani Nikula wrote: > > On Fri, 11 Feb 2022, Andy Shevchenko > > wrote: > > > On Fri, Feb 11, 2022 at 02:05:56PM +0200, Jani Nikula wrote: > > >> On Fri, 11 Feb 2022, Thomas Zimmermann wrot

[PATCH v4] drm/mediatek: allow commands to be sent during video mode

2022-02-14 Thread Julien STEPHAN
Mipi dsi panel drivers can use mipi_dsi_dcs_{set,get}_display_brightness() to request backlight changes. This can be done during panel initialization (dsi is in command mode) or afterwards (dsi is in Video Mode). When the DSI is in Video Mode, all commands are rejected. Detect current DSI mode i

[PATCH 01/11] drm/ttm: fix resource manager size type and description

2022-02-14 Thread Christian König
That are not pages any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_resource.c | 6 +++--- include/drm/ttm/ttm_resource.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c index

[PATCH 04/11] drm/ttm: add resource iterator v2

2022-02-14 Thread Christian König
Instead of duplicating that at different places add an iterator over all the resources in a resource manager. v2: add lockdep annotation and kerneldoc Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen Reviewed-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 41 ++-

[PATCH 05/11] drm/radeon: remove resource accounting

2022-02-14 Thread Christian König
Use the one provided by TTM instead. Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/radeon/radeon.h| 2 -- drivers/gpu/drm/radeon/radeon_kms.c| 7 -- drivers/gpu/drm/radeon/radeon_object.c | 30 +++--- drivers/gpu/drm/radeon

[PATCH 02/11] drm/ttm: add common accounting to the resource mgr v3

2022-02-14 Thread Christian König
It makes sense to have this in the common manager for debugging and accounting of how much resources are used. v2: cleanup kerneldoc a bit v3: drop the atomic, update counter under lock instead Signed-off-by: Christian König Reviewed-by: Huang Rui (v1) Tested-by: Bas Nieuwenhuizen --- drivers

[PATCH 06/11] drm/amdgpu: remove GTT accounting v2

2022-02-14 Thread Christian König
This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. v2: fix size checking as well Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 49 +--

[PATCH 03/11] drm/ttm: move the LRU into resource handling v3

2022-02-14 Thread Christian König
This way we finally fix the problem that new resource are not immediately evict-able after allocation. That has caused numerous problems including OOM on GDS handling and not being able to use TTM as general resource manager. v2: stop assuming in ttm_resource_fini that res->bo is still valid. v3:

[PATCH 09/11] drm/amdgpu: drop amdgpu_gtt_node

2022-02-14 Thread Christian König
We have the BO pointer in the base structure now as well. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 49 - include/drm/ttm/ttm_resource.h | 8 2 files changed, 2

[PATCH 08/11] drm/amdgpu: remove VRAM accounting v2

2022-02-14 Thread Christian König
This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. v2: fix size checking as well Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gp

[PATCH 10/11] drm/ttm: allow bulk moves for all domains

2022-02-14 Thread Christian König
Not just TT and VRAM. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/ttm/ttm_resource.c | 52 +- include/drm/ttm/ttm_device.h | 2 -- include/drm/ttm/ttm_resource.h | 4 +-- 3 files changed, 17

[PATCH 07/11] drm/amdgpu: remove PL_PREEMPT accounting

2022-02-14 Thread Christian König
This is provided by TTM now. Signed-off-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c | 62 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 7 +-- 2 files changed, 6 insertions(+), 63 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_preemp

[PATCH 11/11] drm/ttm: rework bulk move handling v2

2022-02-14 Thread Christian König
Instead of providing the bulk move structure for each LRU update set this as property of the BO. This should avoid costly bulk move rebuilds with some games under RADV. v2: some name polishing, add a few more kerneldoc words. v3: add some lockdep Signed-off-by: Christian König Tested-by: Bas Nie

Re: [PATCH 01/11] drm/ttm: fix resource manager size type and description

2022-02-14 Thread Christian König
Hi guys, crap I once more forgot the cover letter, but this set should be pretty straight forward by now. Please review and comment, Christian. Am 14.02.22 um 10:34 schrieb Christian König: That are not pages any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_resource.c

[PATCH 5.10 065/116] drm/panel: simple: Assign data from panel_dpi_probe() correctly

2022-02-14 Thread Greg Kroah-Hartman
From: Christoph Niedermaier [ Upstream commit 6df4432a5eca101b5fd80fbee41d309f3d67928d ] In the function panel_simple_probe() the pointer panel->desc is assigned to the passed pointer desc. If function panel_dpi_probe() is called panel->desc will be updated, but further on only desc will be eval

Re: [PATCH v4] drm/mediatek: allow commands to be sent during video mode

2022-02-14 Thread AngeloGioacchino Del Regno
Il 14/02/22 10:27, Julien STEPHAN ha scritto: Mipi dsi panel drivers can use mipi_dsi_dcs_{set,get}_display_brightness() to request backlight changes. This can be done during panel initialization (dsi is in command mode) or afterwards (dsi is in Video Mode). When the DSI is in Video Mode, all c

Re: [PATCH v4 0/10] clk: Improve clock range handling

2022-02-14 Thread Laurent Pinchart
Hi Maxime and Stephen, We have recently posted a driver for the BCM2711 Unicam CSI-2 receiver (see [1]) which is a perfect candidate for this API, as it needs a minimum rate for the VPU clock. Any chance we can get this series merged ? :-) [1] https://lore.kernel.org/linux-media/20220208155027.8

[PATCH 5.15 105/172] drm/panel: simple: Assign data from panel_dpi_probe() correctly

2022-02-14 Thread Greg Kroah-Hartman
From: Christoph Niedermaier [ Upstream commit 6df4432a5eca101b5fd80fbee41d309f3d67928d ] In the function panel_simple_probe() the pointer panel->desc is assigned to the passed pointer desc. If function panel_dpi_probe() is called panel->desc will be updated, but further on only desc will be eval

[PATCH 5.16 125/203] drm/panel: simple: Assign data from panel_dpi_probe() correctly

2022-02-14 Thread Greg Kroah-Hartman
From: Christoph Niedermaier [ Upstream commit 6df4432a5eca101b5fd80fbee41d309f3d67928d ] In the function panel_simple_probe() the pointer panel->desc is assigned to the passed pointer desc. If function panel_dpi_probe() is called panel->desc will be updated, but further on only desc will be eval

[RFC v2 0/5] Add data flow metering support for HDMI2.1

2022-02-14 Thread Vandita Kulkarni
The below patches add support for data flow metering as mentioned in the section 6.5.6 FRL data flow metering of HDMI 2.1 specification. Add functions to calclulate the DFM parameters for the given frl config, which is further used to evaluate the data flow metering requirement as specified in the

[RFC v2 2/5] drm/hdmi21: Add non dsc frl capacity computation helpers

2022-02-14 Thread Vandita Kulkarni
Add helper functions for computing non dsc frl link characteristics Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 396 +++ 1 file changed, 396 insertions(+) create mode 100644 drivers/gpu/drm/drm_frl_dfm_helper.c diff --git a/drivers/gpu/drm

[RFC v2 3/5] drm/hdmi21: Add helpers to verify non-dsc DFM requirements

2022-02-14 Thread Vandita Kulkarni
Add helpers to compute DFM variables and to verify if the DFM requirements are met or not in non dsc cases. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 161 +++ include/drm/drm_frl_dfm_helper.h | 2 + 2 files changed, 163 insertions(+)

[RFC v2 1/5] drm/hdmi21: Define frl_dfm structure

2022-02-14 Thread Vandita Kulkarni
Define frl_dfm structure to hold frl characteristics needed for frl capacity computation in order to meet the data flow metering requirement. Signed-off-by: Vandita Kulkarni --- include/drm/drm_frl_dfm_helper.h | 124 +++ 1 file changed, 124 insertions(+) create mode

[RFC v2 5/5] drm/hdmi21: Add frl_dfm_helper to Makefile

2022-02-14 Thread Vandita Kulkarni
Add the new frl_dfm_helper file to drm Makefile Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 8675c2af7ae1..81fe3df8bfda 100644 --- a/drivers/gpu/drm/Ma

[RFC v2 4/5] drm/hdmi21: Add support for DFM calculation with DSC

2022-02-14 Thread Vandita Kulkarni
From: Ankit Nautiyal Add helper functions for calculating FRL capacity and DFM requirements with given compressed bpp. Signed-off-by: Ankit Nautiyal Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 297 +++ include/drm/drm_frl_dfm_helper.h

Re: [PATCH] drivers: fbtft: Refactor backlight logic

2022-02-14 Thread Andy Shevchenko
On Sat, Feb 12, 2022 at 12:27:39PM +0800, qianfangui...@163.com wrote: > From: qianfan Zhao > > Control led gpios by using GPIO_ACTIVE flags, don't detect the polarity > by reading the gpio value when probe. ... > + enum gpiod_flags flags = GPIOD_OUT_HIGH; > + > + /* request and turn on

Re: [PATCH 06/23] drm/ingenic: Make use of the helper component_compare_of

2022-02-14 Thread Paul Cercueil
Hi, Le lun., févr. 14 2022 at 14:08:02 +0800, Yong Wu a écrit : Use the common compare helper from component. Cc: Paul Cercueil Cc: linux-m...@vger.kernel.org Signed-off-by: Yong Wu Acked-by: Paul Cercueil Cheers, -Paul --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 7 +-- 1 fil

Re: [PATCH v7 0/7] drm/lsdc: add drm driver for loongson display controller

2022-02-14 Thread Sui Jingfeng
On 2022/2/14 13:54, Jiaxun Yang wrote: 在 2022/2/13 14:16, Sui Jingfeng 写道: There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge chip, the DC is a PCI device in those chips. It has two display pipes but with only one hardware cursor. Each way has a DVO interface which

Re: [PATCH v3 1/2] drm/panel: Add inx Himax8279d MIPI-DSI LCD panel driver

2022-02-14 Thread AngeloGioacchino Del Regno
Il 13/02/22 07:31, Hsin-Yi Wang ha scritto: From: xiazhengqiao Add STARRY 2081101QFH032011-53G 10.1" WUXGA TFT LCD panel Signed-off-by: xiazhengqiao Signed-off-by: Hsin-Yi Wang I have no way of testing this driver but the code itself looks good to me, so, strictly for the code: Reviewed-b

Re: [PATCH] drivers: fbtft: Add property 'keep-bootlogo'

2022-02-14 Thread Andy Shevchenko
On Sat, Feb 12, 2022 at 01:37:11PM +0800, qianfangui...@163.com wrote: > From: qianfan Zhao > > Keep the logo draw by bootloader Please, Cc to fbdev maintainer. Personally I'm not sure we want this from maintenance perspective, but I understand what you want to achieve with it. -- With Best Re

Re: [PATCH v7 1/7] drm/lsdc: add drm driver for loongson display controller

2022-02-14 Thread Maxime Ripard
On Sun, Feb 13, 2022 at 10:16:43PM +0800, Sui Jingfeng wrote: > From: suijingfeng > > There is a display controller in loongson's LS2K1000 SoC and LS7A1000 > bridge chip, the DC is a PCI device in those chips. It has two display > pipes but with only one hardware cursor. Each way has a DVO interf

Re: [PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-14 Thread Paul Cercueil
Hi, Le sam., févr. 12 2022 at 16:50:49 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie We have to make sure that - JZ_LCD_OSDC_ALPHAEN is set - plane f0 is disabled and not seen from user-space Actually it will still be seen from user-space, but it won't be possible to use it. So

Re: [PATCH v3 1/2] drm/panel: Add inx Himax8279d MIPI-DSI LCD panel driver

2022-02-14 Thread Hsin-Yi Wang
On Mon, Feb 14, 2022 at 6:10 PM AngeloGioacchino Del Regno wrote: > > Il 13/02/22 07:31, Hsin-Yi Wang ha scritto: > > From: xiazhengqiao > > > > Add STARRY 2081101QFH032011-53G 10.1" WUXGA TFT LCD panel > > > > Signed-off-by: xiazhengqiao > > Signed-off-by: Hsin-Yi Wang > > I have no way of tes

Re: [PATCH v15 6/7] drm/ingenic: dw-hdmi: make hot plug detection work for CI20

2022-02-14 Thread Paul Cercueil
Hi Nikolaus, Le sam., févr. 12 2022 at 16:50:54 +0100, H. Nikolaus Schaller a écrit : There is no hpd-gpio installed on the CI20 board HDMI connector. Hence there is no hpd detection by the connector driver and we have to enable polling by the dw-hdmi driver. We need to set .poll_enabled but

Re: [PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-14 Thread H. Nikolaus Schaller
Hi Paul, > Am 14.02.2022 um 11:13 schrieb Paul Cercueil : > > Hi, > > Le sam., févr. 12 2022 at 16:50:49 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> We have to make sure that >> - JZ_LCD_OSDC_ALPHAEN is set >> - plane f0 is disabled and not seen from user-space > > Actua

Re: [PATCH v15 2/7] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-14 Thread Paul Cercueil
Hi, Le sam., févr. 12 2022 at 16:50:50 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig DRM_INGE

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Andy Shevchenko
On Mon, Feb 14, 2022 at 11:17:11AM +0200, Pekka Paalanen wrote: > On Fri, 11 Feb 2022 19:27:12 +0200 > Andy Shevchenko wrote: > > On Fri, Feb 11, 2022 at 06:25:17PM +0200, Jani Nikula wrote: > > > On Fri, 11 Feb 2022, Andy Shevchenko > > > wrote: > > > > On Fri, Feb 11, 2022 at 02:05:56PM +020

Re: [PATCH 01/11] drm/ttm: fix resource manager size type and description

2022-02-14 Thread Matthew Auld
On Mon, 14 Feb 2022 at 09:34, Christian König wrote: > > That are not pages any more. "Leave the man->size units as driver defined." > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/ttm_resource.c | 6 +++--- > include/drm/ttm/ttm_resource.h | 2 +- > 2 files changed, 4 inser

Re: [PATCH 02/11] drm/ttm: add common accounting to the resource mgr v3

2022-02-14 Thread Matthew Auld
On Mon, 14 Feb 2022 at 09:34, Christian König wrote: > > It makes sense to have this in the common manager for debugging and > accounting of how much resources are used. > > v2: cleanup kerneldoc a bit > v3: drop the atomic, update counter under lock instead > > Signed-off-by: Christian König > R

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Andy Shevchenko
On Mon, Feb 14, 2022 at 10:03:53AM +0100, Thomas Zimmermann wrote: > Am 11.02.22 um 16:41 schrieb Andy Shevchenko: ... > > > IMO *always* prefer a for loop over while or do-while. > > > > > > The for (i = 0; i < N; i++) is such a strong paradigm in C. You > > > instantly know how many times you'

Re: [PATCH v7 1/7] drm/lsdc: add drm driver for loongson display controller

2022-02-14 Thread Sui Jingfeng
On 2022/2/14 18:10, Maxime Ripard wrote: On Sun, Feb 13, 2022 at 10:16:43PM +0800, Sui Jingfeng wrote: From: suijingfeng There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge chip, the DC is a PCI device in those chips. It has two display pipes but with only one hardwa

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Simon Ser
On Monday, February 14th, 2022 at 11:38, Andy Shevchenko wrote: > > > > IMO *always* prefer a for loop over while or do-while. > > > > > > > > The for (i = 0; i < N; i++) is such a strong paradigm in C. You > > > > instantly know how many times you're going to loop, at a glance. Not so > > > > w

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Geert Uytterhoeven
Hi Andy, On Mon, Feb 14, 2022 at 11:39 AM Andy Shevchenko wrote: > On Mon, Feb 14, 2022 at 10:03:53AM +0100, Thomas Zimmermann wrote: > > Am 11.02.22 um 16:41 schrieb Andy Shevchenko: > > > > IMO *always* prefer a for loop over while or do-while. > > > > > > > > The for (i = 0; i < N; i++) is suc

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-14 Thread Mika Westerberg
On Mon, Feb 14, 2022 at 09:52:02AM +0100, Lukas Wunner wrote: > On Mon, Feb 14, 2022 at 09:34:26AM +0200, Mika Westerberg wrote: > > On Fri, Feb 11, 2022 at 03:45:46PM -0600, Bjorn Helgaas wrote: > > > My expectation is that "USB" (like "PCI" and "PCIe") tells me > > > something about how a device

Re: [PATCH 05/11] drm/radeon: remove resource accounting

2022-02-14 Thread Matthew Auld
On Mon, 14 Feb 2022 at 09:34, Christian König wrote: > > Use the one provided by TTM instead. > > Signed-off-by: Christian König > Tested-by: Bas Nieuwenhuizen > --- > drivers/gpu/drm/radeon/radeon.h| 2 -- > drivers/gpu/drm/radeon/radeon_kms.c| 7 -- > drivers/gpu/drm/radeon/

[syzbot] inconsistent lock state in sync_timeline_debug_remove

2022-02-14 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:f4bc5bbb5fef Merge tag 'nfsd-5.17-2' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10fc74c270 kernel config: https://syzkaller.appspot.com/x/.config?x=266de9da75c71a45 das

Re: [PATCH v15 2/7] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-14 Thread H. Nikolaus Schaller
Hi Paul, > Am 14.02.2022 um 11:24 schrieb Paul Cercueil : > > Hi, > > Le sam., févr. 12 2022 at 16:50:50 +0100, H. Nikolaus Schaller > a écrit : >> +static void ingenic_dw_hdmi_cleanup(void *data) >> +{ >> +struct dw_hdmi *hdmi = (struct dw_hdmi *)data; >> + >> +dw_hdmi_remove(hdmi);

Re: [PATCH 06/11] drm/amdgpu: remove GTT accounting v2

2022-02-14 Thread Matthew Auld
On Mon, 14 Feb 2022 at 09:34, Christian König wrote: > > This is provided by TTM now. > > Also switch man->size to bytes instead of pages and fix the double > printing of size and usage in debugfs. > > v2: fix size checking as well > > Signed-off-by: Christian König > Tested-by: Bas Nieuwenhuizen

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-14 Thread Mika Westerberg
On Mon, Feb 14, 2022 at 01:11:05PM +0200, Mika Westerberg wrote: > > > It is used to identify "tunneled" ports (whether PCIe, USB 3.x or > > > DisplayPort). Tunnels are created by software (in Linux it is the > > > Thunderbolt driver) and are dynamic in nature. The USB4 links go over > > > USB Type

Re: [PATCH 07/11] drm/amdgpu: remove PL_PREEMPT accounting

2022-02-14 Thread Matthew Auld
On Mon, 14 Feb 2022 at 09:34, Christian König wrote: > > This is provided by TTM now. > > Signed-off-by: Christian König Reviewed-by: Matthew Auld

Re: [PATCH 08/11] drm/amdgpu: remove VRAM accounting v2

2022-02-14 Thread Matthew Auld
On Mon, 14 Feb 2022 at 09:34, Christian König wrote: > > This is provided by TTM now. > > Also switch man->size to bytes instead of pages and fix the double > printing of size and usage in debugfs. > > v2: fix size checking as well > > Signed-off-by: Christian König > Tested-by: Bas Nieuwenhuizen

Re: [PATCH v15 2/7] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-14 Thread Paul Cercueil
Le lun., févr. 14 2022 at 12:02:53 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 14.02.2022 um 11:24 schrieb Paul Cercueil : Hi, Le sam., févr. 12 2022 at 16:50:50 +0100, H. Nikolaus Schaller a écrit : +static void ingenic_dw_hdmi_cleanup(void *data) +{ + struct dw_hd

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Thomas Zimmermann
Hi Am 14.02.22 um 11:38 schrieb Andy Shevchenko: On Mon, Feb 14, 2022 at 10:03:53AM +0100, Thomas Zimmermann wrote: Am 11.02.22 um 16:41 schrieb Andy Shevchenko: ... IMO *always* prefer a for loop over while or do-while. The for (i = 0; i < N; i++) is such a strong paradigm in C. You insta

Re: [PATCH 1/2] edid: parse DRM VESA dsc bpp target

2022-02-14 Thread Jani Nikula
Subject prefix should be drm/edid. On Sun, 13 Feb 2022, Yaroslav Bolyukin wrote: > As per DisplayID v2.0 Errata E9 spec Please be more elaborate about the changes. You also need to update drm_reset_display_info(). BR, Jani. > Signed-off-by: Yaroslav Bolyukin > --- > drivers/gpu/drm/drm_ed

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-02-14 Thread Thorsten Leemhuis
[TLDR: I'm adding the regression report below to regzbot, the Linux kernel regression tracking bot; all text you find below is compiled from a few templates paragraphs you might have encountered already already from similar mails.] Hi, this is your Linux kernel regression tracker speaking. CCin

Re: [PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-14 Thread Paul Cercueil
Hi, Le lun., févr. 14 2022 at 11:19:40 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 14.02.2022 um 11:13 schrieb Paul Cercueil : Hi, Le sam., févr. 12 2022 at 16:50:49 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie We have to make sure that - JZ_LCD_OSDC_ALPHAEN is

Re: [PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-14 Thread H. Nikolaus Schaller
Hi Paul, > Am 14.02.2022 um 13:29 schrieb Paul Cercueil : > > Hi, > > Le lun., févr. 14 2022 at 11:19:40 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 14.02.2022 um 11:13 schrieb Paul Cercueil : >>> Hi, >>> Le sam., févr. 12 2022 at 16:50:49 +0100, H. Nikolaus Schaller >>> a écr

Re: [PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-14 Thread Paul Cercueil
Hi, Le lun., févr. 14 2022 at 13:33:25 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 14.02.2022 um 13:29 schrieb Paul Cercueil : Hi, Le lun., févr. 14 2022 at 11:19:40 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 14.02.2022 um 11:13 schrieb Paul Cercueil : Hi, Le sam.,

Re: [PATCH 20/23] ASoC: codecs: wcd938x: Make use of the helper component_compare/release_of

2022-02-14 Thread Mark Brown
On Mon, Feb 14, 2022 at 02:08:16PM +0800, Yong Wu wrote: > Use the common compare/release helpers from component. What's the story with dependencies here? I've just got this one patch with no cover letter... signature.asc Description: PGP signature

Re: [PATCH 20/23] ASoC: codecs: wcd938x: Make use of the helper component_compare/release_of

2022-02-14 Thread AngeloGioacchino Del Regno
Il 14/02/22 13:40, Mark Brown ha scritto: On Mon, Feb 14, 2022 at 02:08:16PM +0800, Yong Wu wrote: Use the common compare/release helpers from component. What's the story with dependencies here? I've just got this one patch with no cover letter... Hello Mark, I agree, the cover letter shoul

Re: [PATCH v7 1/4] drm/bridge: anx7625: send DPCD command to downstream

2022-02-14 Thread Robert Foss
On Sun, 13 Feb 2022 at 11:34, Hsin-Yi Wang wrote: > > From: Xin Ji > > Send DPCD command to downstream before anx7625 power down, > let downstream monitor enter into standby mode. > > Signed-off-by: Xin Ji > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hsin-Yi Wang > --- > v3->v4: > Use common D

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Ville Syrjälä
On Mon, Feb 14, 2022 at 01:12:48PM +0100, Thomas Zimmermann wrote: > Hi > > Am 14.02.22 um 11:38 schrieb Andy Shevchenko: > > On Mon, Feb 14, 2022 at 10:03:53AM +0100, Thomas Zimmermann wrote: > >> Am 11.02.22 um 16:41 schrieb Andy Shevchenko: > > > > ... > > > IMO *always* prefer a for loo

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Thomas Zimmermann
Hi Am 14.02.22 um 13:47 schrieb Ville Syrjälä: On Mon, Feb 14, 2022 at 01:12:48PM +0100, Thomas Zimmermann wrote: Hi Am 14.02.22 um 11:38 schrieb Andy Shevchenko: On Mon, Feb 14, 2022 at 10:03:53AM +0100, Thomas Zimmermann wrote: Am 11.02.22 um 16:41 schrieb Andy Shevchenko: ... IMO *alw

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Ville Syrjälä
On Mon, Feb 14, 2022 at 01:54:59PM +0100, Thomas Zimmermann wrote: > Hi > > Am 14.02.22 um 13:47 schrieb Ville Syrjälä: > > On Mon, Feb 14, 2022 at 01:12:48PM +0100, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 14.02.22 um 11:38 schrieb Andy Shevchenko: > >>> On Mon, Feb 14, 2022 at 10:03:53AM +0

Re: [PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-14 Thread H. Nikolaus Schaller
> Am 14.02.2022 um 13:36 schrieb Paul Cercueil : > > Hi, > > Le lun., févr. 14 2022 at 13:33:25 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 14.02.2022 um 13:29 schrieb Paul Cercueil : >>> Hi, >>> Le lun., févr. 14 2022 at 11:19:40 +0100, H. Nikolaus Schaller >>> a écrit : >>

Re: [PATCH 02/11] drm/ttm: add common accounting to the resource mgr v3

2022-02-14 Thread Christian König
Am 14.02.22 um 11:34 schrieb Matthew Auld: On Mon, 14 Feb 2022 at 09:34, Christian König wrote: It makes sense to have this in the common manager for debugging and accounting of how much resources are used. v2: cleanup kerneldoc a bit v3: drop the atomic, update counter under lock instead Sig

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-14 Thread Thomas Zimmermann
Hi Am 14.02.22 um 10:05 schrieb Geert Uytterhoeven: Hi Thomas, On Mon, Feb 14, 2022 at 9:28 AM Thomas Zimmermann wrote: Am 14.02.22 um 09:05 schrieb Geert Uytterhoeven: On Thu, Feb 10, 2022 at 4:24 PM Thomas Zimmermann wrote: Fbdev's deferred I/O sorts all dirty pages by default, which inc

Re: [PATCH 06/11] drm/amdgpu: remove GTT accounting v2

2022-02-14 Thread Christian König
Am 14.02.22 um 12:10 schrieb Matthew Auld: On Mon, 14 Feb 2022 at 09:34, Christian König wrote: This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. v2: fix size checking as well Signed-off-by: Christian König

[PATCH v6 0/6] drm: Add driver for Solomon SSD130x OLED displays

2022-02-14 Thread Javier Martinez Canillas
This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. Using the DRM fbdev emulation, all the tests from Geert Uytterhoeven repo (https://git.kernel.org/pub/scm/linux/kernel/git/geert/fbtest.git) passes.

[PATCH v6 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Javier Martinez Canillas
Pull the per-line conversion logic into a separate helper function. This will allow to do line-by-line conversion in other helpers that convert to a gray8 format. Suggested-by: Thomas Zimmermann Signed-off-by: Javier Martinez Canillas Reviewed-by: Thomas Zimmermann Reviewed-by: Andy Shevchenko

[PATCH v6 4/6] drm/solomon: Add SSD130x OLED displays I2C support

2022-02-14 Thread Javier Martinez Canillas
The ssd130x driver only provides the core support for these devices but it does not have any bus transport logic. Add a driver to interface over I2C. Signed-off-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko --- (no changes since v5) Changes in v5: - Add Andy Shevchenko's Reviewed-b

[PATCH v6 2/6] drm/format-helper: Add drm_fb_xrgb8888_to_mono_reversed()

2022-02-14 Thread Javier Martinez Canillas
Add support to convert from XR24 to reversed monochrome for drivers that control monochromatic display panels, that only have 1 bit per pixel. The function does a line-by-line conversion doing an intermediate step first from XR24 to 8-bit grayscale and then to reversed monochrome. The drm_fb_gray

[PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-02-14 Thread Javier Martinez Canillas
This adds a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon OLED display controllers. It's only the core part of the driver and a bus specific driver is needed for each transport interface supported by the display controllers. Signed-off-by: Javier Martinez Canillas --- Changes in

[PATCH v6 5/6] MAINTAINERS: Add entry for Solomon SSD130x OLED displays DRM driver

2022-02-14 Thread Javier Martinez Canillas
To make sure that tools like the get_maintainer.pl script will suggest to Cc me if patches are posted for this driver. Also include the Device Tree binding for the old ssd1307fb fbdev driver since the new DRM driver was made compatible with the existing binding. Signed-off-by: Javier Martinez Can

[PATCH v6 6/6] dt-bindings: display: ssd1307fb: Add myself as binding co-maintainer

2022-02-14 Thread Javier Martinez Canillas
The ssd130x DRM driver also makes use of this Device Tree binding to allow existing users of the fbdev driver to migrate without the need to change their Device Trees. Add myself as another maintainer of the binding, to make sure that I will be on Cc when patches are proposed for it. Suggested-by

Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-14 Thread Andy Shevchenko
On Mon, Feb 14, 2022 at 01:12:48PM +0100, Thomas Zimmermann wrote: > Am 14.02.22 um 11:38 schrieb Andy Shevchenko: > > On Mon, Feb 14, 2022 at 10:03:53AM +0100, Thomas Zimmermann wrote: > > > Am 11.02.22 um 16:41 schrieb Andy Shevchenko: ... > > > > > IMO *always* prefer a for loop over while or

Re: [PATCH 02/11] drm/ttm: add common accounting to the resource mgr v3

2022-02-14 Thread Matthew Auld
On Mon, 14 Feb 2022 at 13:23, Christian König wrote: > > Am 14.02.22 um 11:34 schrieb Matthew Auld: > > On Mon, 14 Feb 2022 at 09:34, Christian König > > wrote: > >> It makes sense to have this in the common manager for debugging and > >> accounting of how much resources are used. > >> > >> v2: c

Re: [PATCH v2] drm/bridge: anx7625: Fix overflow issue on reading EDID

2022-02-14 Thread Robert Foss
On Thu, 10 Feb 2022 at 11:38, Pin-Yen Lin wrote: > > The length of EDID block can be longer than 256 bytes, so we should use > `int` instead of `u8` for the `edid_pos` variable. > > Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") > Signed-off-by: Pin-Yen Lin > Reviewed

Re: [PATCH 02/11] drm/ttm: add common accounting to the resource mgr v3

2022-02-14 Thread Christian König
Am 14.02.22 um 15:29 schrieb Matthew Auld: On Mon, 14 Feb 2022 at 13:23, Christian König wrote: Am 14.02.22 um 11:34 schrieb Matthew Auld: On Mon, 14 Feb 2022 at 09:34, Christian König wrote: It makes sense to have this in the common manager for debugging and accounting of how much resources

[PATCH] drm/nouveau/bios: Use HWSQ entry 1 for PowerBook6,1

2022-02-14 Thread Icenowy Zheng
On PowerBook6,1 (PowerBook G4 867 12") HWSQ entry 0 (which is currently always used by nouveau) fails, but the BIOS declares 2 HWSQ entries and entry 1 works. Add a quirk to use HWSQ entry 1. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/nouveau/nouveau_bios.c | 7 +++ 1 file changed, 7

Re: [PATCH] drm/nouveau/bios: Use HWSQ entry 1 for PowerBook6,1

2022-02-14 Thread Ilia Mirkin
I'm not saying this is wrong, but could you file a bug at gitlab.freedesktop.org/drm/nouveau/-/issues and include the VBIOS (/sys/kernel/debug/dri/0/vbios.rom)? That would make it easier to review the full situation. On Mon, Feb 14, 2022 at 11:03 AM Icenowy Zheng wrote: > > On PowerBook6,1 (Power

Re: [PATCH 04/11] drm/ttm: add resource iterator v2

2022-02-14 Thread Felix Kuehling
Am 2022-02-14 um 04:34 schrieb Christian König: Instead of duplicating that at different places add an iterator over all the resources in a resource manager. v2: add lockdep annotation and kerneldoc Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen Reviewed-by: Daniel Vetter ---

Re: [PATCH 07/11] drm/amdgpu: remove PL_PREEMPT accounting

2022-02-14 Thread Felix Kuehling
Am 2022-02-14 um 04:34 schrieb Christian König: This is provided by TTM now. Signed-off-by: Christian König This patch is Reviewed-by: Felix Kuehling --- .../gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c | 62 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 7 +-- 2

Re: [PATCH v8 00/10] vgaarb: Rework default VGA device selection

2022-02-14 Thread Bjorn Helgaas
On Tue, Feb 01, 2022 at 04:46:33PM +0100, Maarten Lankhorst wrote: > Hey, >   > Op 31-01-2022 om 23:23 schreef Bjorn Helgaas: > > [+to Maarten, Maxime, Thomas; beginning of thread: > > https://lore.kernel.org/r/20220106000658.243509-1-helg...@kernel.org] > > > > On Wed, Jan 05, 2022 at 06:06:48PM -

Re: [PATCH 1/9] dt-bindings: Add arm,mali-valhall compatible

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > From the kernel's perspective, pre-CSF Valhall is more or less > compatible with Bifrost, although they differ to userspace. Add a > compatible for Valhall to the existing Bifrost bindings documentation. >

Re: [PATCH 2/9] drm/panfrost: Handle HW_ISSUE_TTRX_2968_TTRX_3162

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > Add handling for the HW_ISSUE_TTRX_2968_TTRX_3162 quirk. Logic ported > from kbase. kbase lists this workaround as used on Mali-G57. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Steven Price > ---

Re: [PATCH 3/9] drm/panfrost: Constify argument to has_hw_issue

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > Logically, this function is free of side effects, so any pointers it > takes should be const. Needed to avoid a warning in the next patch. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Steven Price

Re: [PATCH 4/9] drm/panfrost: Handle HW_ISSUE_TTRX_3076

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > Some Valhall GPUs require resets when encountering bus faults due to > occlusion query writes. Add the issue bit for this and handle it. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Steven Price (al

  1   2   >