Re: [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-19 Thread Jani Nikula
On Tue, 18 Jan 2022, Lucas De Marchi wrote: > Add some helpers under lib/string_helpers.h so they can be used > throughout the kernel. When I started doing this there were 2 other > previous attempts I know of, not counting the iterations each of them > had: > > 1) https://lore.kernel.org/all/2019

Re: [PATCH] mgag200 fix memmapsl configuration in GCTL6 register

2022-01-19 Thread Thomas Zimmermann
Hi Am 18.01.22 um 20:06 schrieb Lyude Paul: We should probably Cc: sta...@vger.kernel.org this as well, see: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for more info. As well, some useful tools for adding the appropriate Fixes: tags: https://drm.pages.freedesktop.

[PATCH] drm/panel: Add missing pm_rumtime_resume_and_get

2022-01-19 Thread Yongzhi Liu
pm_runtime_put_autosuspend() and pm_runtime_put_sync_suspend() will decrease the rumtime PM counter even when it returns an error. Thus a pairing decrement is needed to prevent refcount leak. Fix this by adding pm_runtime_resume_and_get() on error handling path. Signed-off-by: Yongzhi Liu --- dr

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Greg Kroah-Hartman
On Tue, Jan 18, 2022 at 07:50:38PM -0600, Rob Herring wrote: > The 'phandle-array' type is a bit ambiguous. It can be either just an > array of phandles or an array of phandles plus args. Many schemas for > phandle-array properties aren't clear in the schema which case applies > though the descript

Re: [PATCH 1/2] drm/msm: add support for QCM2290 MDSS

2022-01-19 Thread Loic Poulain
Hi Dmitry, On Tue, 18 Jan 2022 at 19:02, Dmitry Baryshkov wrote: > > On 18/01/2022 18:47, Loic Poulain wrote: > > Add compatibility for QCM2290 display subsystem, including > > required entries in DPU hw catalog. > > > > Signed-off-by: Loic Poulain > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu

Re: [PATCH v2] phy: dphy: Correct clk_pre parameter

2022-01-19 Thread Neil Armstrong
Hi, On 19/01/2022 03:37, Liu Ying wrote: > The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE > parameter's unit is Unit Interval(UI) and the minimum value is 8. Also, > kernel doc of the 'clk_pre' member of struct phy_configure_opts_mipi_dphy > mentions that it should be in UI

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-19 Thread Pekka Paalanen
On Tue, 18 Jan 2022 10:53:52 +0100 Gerd Hoffmann wrote: > On Tue, Jan 18, 2022 at 10:33:23AM +0200, Pekka Paalanen wrote: > > On Mon, 17 Jan 2022 19:47:39 +0100 > > Sven Schnelle wrote: > > > > > I also tested the speed on my Thinkpad X1 with Intel graphics, and there > > > a dmesg with 919 l

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Thomas Zimmermann
Hi Zack Am 17.01.22 um 19:03 schrieb Zack Rusin: From: Zack Rusin When sysfb_simple is enabled loading vmwgfx fails because the regions are held by the platform. In that case remove_conflicting*_framebuffers only removes the simplefb but not the regions held by sysfb. I don't understand this

[RFC] How to add hardware rotation, scaling etc to a DRM/KMS driver

2022-01-19 Thread Daniel Palmer
Hi all, I've copied and pasted my way to mostly working DRM/KMS driver for a low cost ARM SoC (Sigmastar SSD202D). The hardware is 2D only. One of the devices that uses this SoC has the screen upside down so it needs the screen rotated. The hardware doesn't have bits that change the scan out dire

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-19 Thread Andi Shyti
Hi Joonas, > > > The GT has its own properties and in sysfs they should be grouped > > > in the 'gt/' directory. > > > > > > Create a 'gt/' directory in sysfs which will contain gt0...gtN > > > directories related to each tile configured in the GPU. Move the > > > power management files inside th

Re: [PATCH v3 00/10] drm: Make drivers to honour the nomodeset parameter

2022-01-19 Thread Javier Martinez Canillas
On 12/22/21 09:28, Javier Martinez Canillas wrote: > The nomodeset kernel command line parameter is used to prevent the KMS/DRM > drivers to be registered/probed. But only a few drivers implement support > for this and most DRM drivers just ignore it. > > This patch series is a v3 to make DRM driv

Re: (subset) [PATCH] drm/vc4: Fix deadlock on DSI device attach error

2022-01-19 Thread Maxime Ripard
On Tue, 18 Jan 2022 01:51:26 +0100, Padmanabha Srinivasaiah wrote: > DSI device attach to DSI host will be done with host device's lock > held. > > Un-registering host in "device attach" error path (ex: probe retry) > will result in deadlock with below call trace and non operational > DSI display.

Re: [PATCH v2] phy: dphy: Correct clk_pre parameter

2022-01-19 Thread Neil Armstrong
On 19/01/2022 09:40, Neil Armstrong wrote: > Hi, > > On 19/01/2022 03:37, Liu Ying wrote: >> The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE >> parameter's unit is Unit Interval(UI) and the minimum value is 8. Also, >> kernel doc of the 'clk_pre' member of struct phy_configu

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Thomas Zimmermann
Hi Am 19.01.22 um 03:15 schrieb Zack Rusin: On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: Hello Zack, On 1/17/22 19:03, Zack Rusin wrote: From: Zack Rusin When sysfb_simple is enabled loading vmwgfx fails because the regions are held by the platform. In that case remove

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Andy Shevchenko
On Wednesday, January 19, 2022, Lucas De Marchi wrote: > There are a few implementations of yesno() in the tree. Consolidate them > in include/linux/string_helpers.h. Quite a few users of open coded > yesno() could later be converted to the new function: > > $ git grep '?\s*"yes"\s*' | wc -l > 2

Re: [PATCH v7 5/8] drm/mediatek: dpi: Add dpintf support

2022-01-19 Thread CK Hu
Hi, Guillaume: On Fri, 2021-12-17 at 16:08 +0100, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann > > dpintf is the displayport interface hardware unit. This unit is > similar > to dpi and can reuse most of the code. > > This patch adds support for mt8195-dpintf to this dpi driver. M

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Sakari Ailus
Hi Lucas, On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct > tomoyo_io_buffer *head, > case 3: > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) > tomoyo_io_printf(head, " gran

Re: [PATCH 2/3] lib/string_helpers: Add helpers for enable[d]/disable[d]

2022-01-19 Thread Andy Shevchenko
On Wednesday, January 19, 2022, Lucas De Marchi wrote: > Follow the yes/no logic and add helpers for enabled/disabled and > enable/disable - those are not so common throughout the kernel, > but they give a nice way to reuse the strings to log things as > enabled/disabled or enable/disable. > > Si

Re: [PATCH] drm/selftests: Select DRM_DP_HELPER

2022-01-19 Thread Javier Martinez Canillas
Hello Thomas, On 1/18/22 16:44, Thomas Zimmermann wrote: > Resolve warnings about non-existing symbols by selecting DRM_DP_HELPER. > > Signed-off-by: Thomas Zimmermann > Fixes: adb9d5a2cc77 ("drm/dp: Move DisplayPort helpers into separate helper > module") > Reported-by: kernel test robot > Cc

Re: [PATCH] drm/msm: Fix include statements for DisplayPort

2022-01-19 Thread Javier Martinez Canillas
On 1/18/22 16:44, Thomas Zimmermann wrote: > Update the include statements for DisplayPort helpers. The header > files are in the dp/ subdirectory. > > Signed-off-by: Thomas Zimmermann > Fixes: 5b529e8d9c38 ("drm/dp: Move public DisplayPort headers into dp/") > Reported-by: kernel test robot > C

Re: [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-19 Thread Andy Shevchenko
On Wednesday, January 19, 2022, Lucas De Marchi wrote: > Add some helpers under lib/string_helpers.h so they can be used > throughout the kernel. When I started doing this there were 2 other > previous attempts I know of, not counting the iterations each of them > had: > > 1) https://lore.kernel.

Re: [PATCH] drm/edid: Support type 7 timings

2022-01-19 Thread Jani Nikula
On Wed, 19 Jan 2022, Yaroslav Bolyukin wrote: > Per VESA DisplayID Standard v2.0: Type VII Timing – Detailed Timing Data > > Definitions were already provided as type I, but not used Thanks for the patch. Functionally I think it looks correct, and something we'll want. I do have some nitpicks tho

Re: [PATCH 2/3] lib/string_helpers: Add helpers for enable[d]/disable[d]

2022-01-19 Thread Lucas De Marchi
On Wed, Jan 19, 2022 at 11:20:38AM +0200, Andy Shevchenko wrote: On Wednesday, January 19, 2022, Lucas De Marchi wrote: Follow the yes/no logic and add helpers for enabled/disabled and enable/disable - those are not so common throughout the kernel, but they give a nice way to reuse the strings

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Geert Uytterhoeven
Hi Rob, On Wed, Jan 19, 2022 at 2:50 AM Rob Herring wrote: > The 'phandle-array' type is a bit ambiguous. It can be either just an > array of phandles or an array of phandles plus args. Many schemas for > phandle-array properties aren't clear in the schema which case applies > though the descrip

Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-19 Thread Guangming . Cao
On Fri, 2022-01-14 at 17:17 -0800, John Stultz wrote: > On Fri, Jan 14, 2022 at 4:04 AM Guangming.Cao > wrote: > > > > On Fri, 2022-01-14 at 08:16 +0100, Christian König wrote: > > > Am 14.01.22 um 00:26 schrieb John Stultz: > > > > On Thu, Jan 13, 2022 at 5:05 AM Christian König > > > > wrote:

Re: [PATCH v2] phy: dphy: Correct clk_pre parameter

2022-01-19 Thread Liu Ying
Hi Neil, On Wed, 2022-01-19 at 10:11 +0100, Neil Armstrong wrote: > On 19/01/2022 09:40, Neil Armstrong wrote: > > Hi, > > > > On 19/01/2022 03:37, Liu Ying wrote: > > > The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE > > > parameter's unit is Unit Interval(UI) and the minim

Re: [PATCH v2] phy: dphy: Correct clk_pre parameter

2022-01-19 Thread Neil Armstrong
Hi, On 19/01/2022 11:01, Liu Ying wrote: > Hi Neil, > > On Wed, 2022-01-19 at 10:11 +0100, Neil Armstrong wrote: >> On 19/01/2022 09:40, Neil Armstrong wrote: >>> Hi, >>> >>> On 19/01/2022 03:37, Liu Ying wrote: The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE param

[PATCH v2] mgag200 fix memmapsl configuration in GCTL6 register

2022-01-19 Thread Jocelyn Falempe
On some servers with MGA G200_SE_A (rev 42), booting with Legacy BIOS, the hardware hangs when using kdump and kexec into the kdump kernel. This happens when the uncompress code tries to write "Decompressing Linux" to the VGA Console. It can be reproduced by writing to the VGA console (0xB8000) af

Re: [PATCH v2 1/2] drm/panel: Add inx Himax8279d MIPI-DSI LCD panel driver

2022-01-19 Thread Hsin-Yi Wang
On Fri, Jan 7, 2022 at 8:22 PM xiazhengqiao wrote: > > Add STARRY 2081101QFH032011-53G 10.1" WUXGA TFT LCD panel > > Signed-off-by: xiazhengqiao > Tested-by: Hsin-Yi Wang Reviewed-by: Hsin-Yi Wang > --- > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Ulf Hansson
On Wed, 19 Jan 2022 at 02:50, Rob Herring wrote: > > The 'phandle-array' type is a bit ambiguous. It can be either just an > array of phandles or an array of phandles plus args. Many schemas for > phandle-array properties aren't clear in the schema which case applies > though the description usual

Re: [PATCH v2] phy: dphy: Correct clk_pre parameter

2022-01-19 Thread Neil Armstrong
Hi, On 19/01/2022 11:11, Neil Armstrong wrote: > Hi, > > On 19/01/2022 11:01, Liu Ying wrote: >> Hi Neil, >> >> On Wed, 2022-01-19 at 10:11 +0100, Neil Armstrong wrote: >>> On 19/01/2022 09:40, Neil Armstrong wrote: Hi, On 19/01/2022 03:37, Liu Ying wrote: > The D-PHY specifica

Re: [PATCH] drm/etnaviv: Add missing pm_runtime_put

2022-01-19 Thread Lucas Stach
Am Dienstag, dem 18.01.2022 um 06:16 -0800 schrieb Yongzhi Liu: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code, thus a matching decrement is needed > on the error handling path to keep the counter balanced. > Instead of adding more error handli

[PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon

2022-01-19 Thread Helge Deller
This series reverts two patches which disabled scrolling acceleration in fbcon/fbdev. Those patches introduced a regression for fbdev-supported graphic cards because of the performance penalty by doing screen scrolling by software instead of using hardware acceleration. Console scrolling accelerat

[PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Helge Deller
This reverts commit 39aead8373b3c20bb5965c024dfb51a94e526151. Revert this patch. This patch started to introduce the regression that all hardware acceleration of more than 35 existing fbdev drivers were bypassed and thus fbcon console output for those was dramatically slowed down by factor of 10

[PATCH 1/2] Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)"

2022-01-19 Thread Helge Deller
This reverts commit b3ec8cdf457e5e63d396fe1346cc788cf7c1b578. Revert this patch. This and the previous patch introduced the regression that all hardware acceleration of more than 35 existing fbdev drivers were bypassed and thus fbcon console output for those was dramatically slowed down by factor

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Greg Kroah-Hartman
On Wed, Jan 19, 2022 at 12:08:39PM +0100, Helge Deller wrote: > This reverts commit 39aead8373b3c20bb5965c024dfb51a94e526151. > > Revert this patch. This patch started to introduce the regression that > all hardware acceleration of more than 35 existing fbdev drivers were > bypassed and thus fbco

Re: [PATCH v5, 15/15] media: mtk-vcodec: support stateless VP9 decoding

2022-01-19 Thread AngeloGioacchino Del Regno
Il 17/01/22 10:40, Yunfei Dong ha scritto: Add support for VP9 decoding using the stateless API, as supported by MT8192. And the drivers is lat and core architecture. Signed-off-by: Yunfei Dong Signed-off-by: George Sun --- drivers/media/platform/mtk-vcodec/Makefile|1 + .../mtk-vco

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Greg Kroah-Hartman
On Wed, Jan 19, 2022 at 12:22:55PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 19, 2022 at 12:08:39PM +0100, Helge Deller wrote: > > This reverts commit 39aead8373b3c20bb5965c024dfb51a94e526151. > > > > Revert this patch. This patch started to introduce the regression that > > all hardware acc

[PATCH v9 2/6] drm: improve drm_buddy_alloc function

2022-01-19 Thread Arunpravin
- Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation and memory alignment logic from i915 drive

[PATCH v9 3/6] drm: implement top-down allocation method

2022-01-19 Thread Arunpravin
Implemented a function which walk through the order list, compares the offset and returns the maximum offset block, this method is unpredictable in obtaining the high range address blocks which depends on allocation and deallocation. for instance, if driver requests address at a low specific range,

[PATCH v9 4/6] drm: implement a method to free unused pages

2022-01-19 Thread Arunpravin
On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim - replace input argument name 'actual_siz

[PATCH v9 5/6] drm/amdgpu: move vram inline functions into a header

2022-01-19 Thread Arunpravin
Move shared vram inline functions and structs into a header file Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 51 1 file changed, 51 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h diff --git a/drivers/gpu/drm/a

[PATCH v9 6/6] drm/amdgpu: add drm buddy support to amdgpu

2022-01-19 Thread Arunpravin
- Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc (..., GFP_KERNEL) in drm_buddy_alloc() function - lock drm_buddy_block_trim() function as it calls

[PATCH] drm/etnaviv: Fix runtime PM imbalance on error

2022-01-19 Thread Yongzhi Liu
pm_runtime_get_sync() will increase the rumtime PM counter even it returns an error. Thus a pairing decrement is needed to prevent refcount leak. Fix this by replacing this API with pm_runtime_resume_and_get(), which will not change the runtime PM counter on error. Signed-off-by: Yongzhi Liu ---

Re: Re: [PATCH] drm/etnaviv: Add missing pm_runtime_put

2022-01-19 Thread 刘永志
> -原始邮件- > 发件人: "Lucas Stach" > 发送时间: 2022-01-19 18:51:20 (星期三) > 收件人: "Yongzhi Liu" , linux+etna...@armlinux.org.uk, > christian.gmei...@gmail.com, airl...@linux.ie, dan...@ffwll.ch, > etna...@lists.freedesktop.org > 抄送: dri-devel@lists.freedesktop.org, linux-ker...@vger.kernel.org > 主题

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Geert Uytterhoeven
Hi Greg, On Wed, Jan 19, 2022 at 12:28 PM Greg Kroah-Hartman wrote: > On Wed, Jan 19, 2022 at 12:22:55PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Jan 19, 2022 at 12:08:39PM +0100, Helge Deller wrote: > > > This reverts commit 39aead8373b3c20bb5965c024dfb51a94e526151. > > > > > > Revert this p

Re: [PATCH v5, 15/15] media: mtk-vcodec: support stateless VP9 decoding

2022-01-19 Thread AngeloGioacchino Del Regno
Il 19/01/22 12:28, AngeloGioacchino Del Regno ha scritto: Il 17/01/22 10:40, Yunfei Dong ha scritto: Add support for VP9 decoding using the stateless API, as supported by MT8192. And the drivers is lat and core architecture. Signed-off-by: Yunfei Dong Signed-off-by: George Sun ---   drivers/m

Re: [PATCH v2] phy: dphy: Correct clk_pre parameter

2022-01-19 Thread Guido Günther
Hi, On Wed, Jan 19, 2022 at 10:37:14AM +0800, Liu Ying wrote: > The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE > parameter's unit is Unit Interval(UI) and the minimum value is 8. Also, > kernel doc of the 'clk_pre' member of struct phy_configure_opts_mipi_dphy > mentions tha

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Georgi Djakov
On 19.01.22 3:50, Rob Herring wrote: The 'phandle-array' type is a bit ambiguous. It can be either just an array of phandles or an array of phandles plus args. Many schemas for phandle-array properties aren't clear in the schema which case applies though the description usually describes it. T

[Bug 215499] AMDGPU: Tahiti flagged as "[drm] Unsupported asic. Remove me when IP discovery init is in place."

2022-01-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215499 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH v2] mgag200 fix memmapsl configuration in GCTL6 register

2022-01-19 Thread Thomas Zimmermann
Hi, Am 19.01.22 um 11:29 schrieb Jocelyn Falempe: On some servers with MGA G200_SE_A (rev 42), booting with Legacy BIOS, the hardware hangs when using kdump and kexec into the kdump kernel. This happens when the uncompress code tries to write "Decompressing Linux" to the VGA Console. It can be

[PATCH v2] drm/bridge: dw-hdmi: use safe format when first in bridge chain

2022-01-19 Thread Neil Armstrong
When the dw-hdmi bridge is in first place of the bridge chain, this means there is no way to select an input format of the dw-hdmi HW component. Since introduction of display-connector, negotiation was broken since the dw-hdmi negotiation code only worked when the dw-hdmi bridge was in last positi

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Helge Deller
Hello Greg, On 1/19/22 12:47, Geert Uytterhoeven wrote: > On Wed, Jan 19, 2022 at 12:28 PM Greg Kroah-Hartman > wrote: >> On Wed, Jan 19, 2022 at 12:22:55PM +0100, Greg Kroah-Hartman wrote: >>> On Wed, Jan 19, 2022 at 12:08:39PM +0100, Helge Deller wrote: This reverts commit 39aead8373b3c20b

[PATCH 1/2] drm/bridge: dw-hdmi: filter safe formats when first in bridge chain

2022-01-19 Thread Neil Armstrong
If the dw-bridge is in the first position in the bridge chain, this means there is no way to set the encoder output bus format. In this case, this makes sure we only return the default format as return of the get_input_bus_fmts() callback, limiting possible output formats of dw-hdmi to what the dw

[PATCH 2/2] drm/bridge: dw-hdmi: filter out YUV output formats when DVI

2022-01-19 Thread Neil Armstrong
When the display is not an HDMI sink, only the RGB output format is valid. Thus stop returning YUV output formats when sink is not HDMI. Fixes: 6c3c719936da ("drm/bridge: synopsys: dw-hdmi: add bus format negociation") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

Re: [PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon

2022-01-19 Thread Geert Uytterhoeven
Hi Helge, On Wed, Jan 19, 2022 at 12:10 PM Helge Deller wrote: > This series reverts two patches which disabled scrolling acceleration in > fbcon/fbdev. Those patches introduced a regression for fbdev-supported graphic > cards because of the performance penalty by doing screen scrolling by softwa

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Sven Schnelle
Hi Greg, Greg Kroah-Hartman writes: > On Wed, Jan 19, 2022 at 12:22:55PM +0100, Greg Kroah-Hartman wrote: >> On Wed, Jan 19, 2022 at 12:08:39PM +0100, Helge Deller wrote: >> > This reverts commit 39aead8373b3c20bb5965c024dfb51a94e526151. >> > >> > Revert this patch. This patch started to intro

Re: [PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon

2022-01-19 Thread Sven Schnelle
Helge Deller writes: > This series reverts two patches which disabled scrolling acceleration in > fbcon/fbdev. Those patches introduced a regression for fbdev-supported graphic > cards because of the performance penalty by doing screen scrolling by software > instead of using hardware acceleratio

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Greg Kroah-Hartman
On Wed, Jan 19, 2022 at 02:01:44PM +0100, Sven Schnelle wrote: > Hi Greg, > > Greg Kroah-Hartman writes: > > > On Wed, Jan 19, 2022 at 12:22:55PM +0100, Greg Kroah-Hartman wrote: > >> On Wed, Jan 19, 2022 at 12:08:39PM +0100, Helge Deller wrote: > >> > This reverts commit 39aead8373b3c20bb5965c0

[PATCH 2/4] dma-buf: warn about dma_fence_array container rules

2022-01-19 Thread Christian König
It's not allowed to nest another dma_fence container into a dma_fence_array or otherwise we can run into recursion. Warn about that when we create a dma_fence_array. Signed-off-by: Christian König --- drivers/dma-buf/dma-fence-array.c | 13 + 1 file changed, 13 insertions(+) diff -

[PATCH 1/4] dma-buf: consolidate dma_fence subclass checking

2022-01-19 Thread Christian König
Consolidate the wrapper functions to check for dma_fence subclasses in the dma_fence header. This makes it easier to document and also check the different requirements for fence containers in the subclasses. Signed-off-by: Christian König --- include/linux/dma-fence-array.h | 15 +

[PATCH 4/4] dma-buf: warn about containers in dma_resv object

2022-01-19 Thread Christian König
Drivers should not add containers as shared fences to the dma_resv object, instead each fence should be added individually. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv

[PATCH 3/4] dma-buf: Warn about dma_fence_chain container rules

2022-01-19 Thread Christian König
Chaining of dma_fence_chain objects is only allowed through the prev fence and not through the contained fence. Warn about that when we create a dma_fence_chain. Signed-off-by: Christian König --- drivers/dma-buf/dma-fence-chain.c | 8 1 file changed, 8 insertions(+) diff --git a/driv

heads-up for fbdev pull request

2022-01-19 Thread Helge Deller
This is just a heads-up, that I'm planning to send a pull request for fbdev fixes to Linus later today. Nothing really important - just fixes for various fbdev drivers. It has been a few days in for-next and no DRM parts are touched. Changelog is below, and it can be pulled from: http://git.kern

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Thomas Zimmermann
Hi Zack Am 19.01.22 um 10:13 schrieb Thomas Zimmermann: Hi Am 19.01.22 um 03:15 schrieb Zack Rusin: On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: Hello Zack, On 1/17/22 19:03, Zack Rusin wrote: From: Zack Rusin When sysfb_simple is enabled loading vmwgfx fails because

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Linus Torvalds
On Wed, Jan 19, 2022 at 2:29 PM Helge Deller wrote: > > >> > >> Ah, no, that was just the soft scrollback code I was thinking of, which > > Right. > That was commit 973c096f6a85 and it was about vgacon, not fbcon. No, fbcon had some bug too, although I've paged out the details. See commit 5014547

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Helge Deller
On 1/19/22 15:01, Linus Torvalds wrote: > On Wed, Jan 19, 2022 at 2:29 PM Helge Deller wrote: >> Ah, no, that was just the soft scrollback code I was thinking of, which >> >> Right. >> That was commit 973c096f6a85 and it was about vgacon, not fbcon. > > No, fbcon had some bug too, althou

Re: [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-19 Thread Jani Nikula
On Wed, 19 Jan 2022, Petr Mladek wrote: > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: >> Add some helpers under lib/string_helpers.h so they can be used >> throughout the kernel. When I started doing this there were 2 other >> previous attempts I know of, not counting the iterations each of

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Zack Rusin
On Wed, 2022-01-19 at 10:13 +0100, Thomas Zimmermann wrote: > Hi > > Am 19.01.22 um 03:15 schrieb Zack Rusin: > > On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: > > > Hello Zack, > > > > > > On 1/17/22 19:03, Zack Rusin wrote: > > > > From: Zack Rusin > > > > > > > > When sy

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds wrote: > > On Wed, Jan 19, 2022 at 2:29 PM Helge Deller wrote: > > > > >> > > >> Ah, no, that was just the soft scrollback code I was thinking of, which > > > > Right. > > That was commit 973c096f6a85 and it was about vgacon, not fbcon. > > No, fbcon

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Thomas Zimmermann
Hi Am 19.01.22 um 15:24 schrieb Zack Rusin: On Wed, 2022-01-19 at 10:13 +0100, Thomas Zimmermann wrote: Hi Am 19.01.22 um 03:15 schrieb Zack Rusin: On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: Hello Zack, On 1/17/22 19:03, Zack Rusin wrote: From: Zack Rusin When sys

Re: [PATCH v2] mgag200 fix memmapsl configuration in GCTL6 register

2022-01-19 Thread Thomas Zimmermann
Hi Am 19.01.22 um 13:21 schrieb Thomas Zimmermann: Appears to be working on my test machine. But please rune scripts/checkpatch.pl on the patch before sending it. I get several errors WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #98:     0: Enable

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Steven Rostedt
On Wed, 19 Jan 2022 11:15:08 +0200 Andy Shevchenko wrote: > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } > > > > Perhaps keep it on 4 lines? Yes, yes/no is short, but if we add others > (enable/disable) it will not be possible to keep on one line. And hence > style

Re: [PATCH] dma-buf: cma_heap: Fix mutex locking section

2022-01-19 Thread Daniel Vetter
On Tue, Jan 04, 2022 at 03:35:45PM +0800, Weizhao Ouyang wrote: > Fix cma_heap_buffer mutex locking critical section to protect vmap_cnt > and vaddr. > > Fixes: a5d2d29e24be ("dma-buf: heaps: Move heap-helper logic into the > cma_heap implementation") > Signed-off-by: Weizhao Ouyang > --- > dri

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Sven Schnelle
Daniel Vetter writes: > On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds > wrote: > Irrespective of this code being buggy or not buggy I think the bigger > pictures, and really the reason I want to see as much code ditched > from the fbdev/fbcon stack as we possible can, are very clear: > > - it's

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Steven Rostedt
On Wed, 19 Jan 2022 11:18:59 +0200 Sakari Ailus wrote: > On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct > > tomoyo_io_buffer *head, > > case 3: > > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) >

Re: [PATCH v4 3/4] drm/bridge: anx7625: Support reading edid through aux channel

2022-01-19 Thread Robert Foss
On Tue, 18 Jan 2022 at 10:20, Hsin-Yi Wang wrote: > > Support reading edid through aux channel if panel is connected to aux > bus. Extend anx7625_aux_dpcd_trans() to implement aux transfer function: > > 1. panel is populated in devm_of_dp_aux_populate_ep_devices(), so move >anx7625_parse_dt()

Re: [PATCH 6/7] drm: Document fdinfo format specification

2022-01-19 Thread Daniel Vetter
On Thu, Jan 06, 2022 at 04:55:35PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Proposal to standardise the fdinfo text format as optionally output by DRM > drivers. > > Idea is that a simple but, well defined, spec will enable generic > userspace tools to be written while at the same

Re: [PATCH RESEND] drm/doc: Fix TTM acronym

2022-01-19 Thread Daniel Vetter
On Fri, Jan 07, 2022 at 07:02:30PM +0100, José Expósito wrote: > The TTM acronym is defined for the first time in the documentation as > "Translation Table Maps". Afterwards, "Translation Table Manager" is > used as definition. > > Fix the first definition to avoid confusion. > > Signed-off-by: J

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Zack Rusin
On Wed, 2022-01-19 at 15:00 +0100, Thomas Zimmermann wrote: > Hi Zack > > Am 19.01.22 um 10:13 schrieb Thomas Zimmermann: > > Hi > > > > Am 19.01.22 um 03:15 schrieb Zack Rusin: > > > On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: > > > > Hello Zack, > > > > > > > > On 1/17/2

Re: [PATCH v2] drm/selftests/test-drm_dp_mst_helper: Fix memory leak in sideband_msg_req_encode_decode

2022-01-19 Thread Daniel Vetter
On Sat, Jan 08, 2022 at 05:58:12PM +0100, José Expósito wrote: > Avoid leaking the "out" variable if it is not possible to allocate > the "txmsg" variable. > > Fixes: 09234b88ef55 ("drm/selftests/test-drm_dp_mst_helper: Move > 'sideband_msg_req_encode_decode' onto the heap") > Addresses-Coverity-

[PATCH v5 1/4] drm/bridge: anx7625: send DPCD command to downstream

2022-01-19 Thread Hsin-Yi Wang
From: Xin Ji Send DPCD command to downstream before anx7625 power down, let downstream monitor enter into standby mode. Signed-off-by: Xin Ji Signed-off-by: Hsin-Yi Wang --- v3->v4: Use common DP_AUX_NATIVE_READ/WRITE Previously in: https://patchwork.kernel.org/project/dri-devel/patch/1f36f8b

[PATCH v5 2/4] drm/bridge: anx7625: Convert to use devm_kzalloc

2022-01-19 Thread Hsin-Yi Wang
Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory handled by driver detach. Signed-off-by: Hsin-Yi Wang Reviewed-by: Xin Ji --- v2->v3: remove kfree() in anx7625_i2c_remove(). --- drivers/gpu/drm/bridge/analogix/anx7625.c | 10 +++--- 1 file changed, 3 insertions(+), 7 de

[PATCH v5 3/4] drm/bridge: anx7625: Support reading edid through aux channel

2022-01-19 Thread Hsin-Yi Wang
Support reading edid through aux channel if panel is connected to aux bus. Extend anx7625_aux_dpcd_trans() to implement aux transfer function: 1. panel is populated in devm_of_dp_aux_populate_ep_devices(), so move anx7625_parse_dt() after. 2. Use pm runtime autosuspend since aux transfer functi

[PATCH v5 4/4] dt-bindings: drm/bridge: anx7625: Add aux-bus node

2022-01-19 Thread Hsin-Yi Wang
List panel under aux-bus node if it's connected to anx7625's aux bus. Signed-off-by: Hsin-Yi Wang Reviewed-by: Xin Ji --- .../display/bridge/analogix,anx7625.yaml| 17 + 1 file changed, 17 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/anal

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Helge Deller
On 1/19/22 15:34, Daniel Vetter wrote: > On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds > wrote: >> >> On Wed, Jan 19, 2022 at 2:29 PM Helge Deller wrote: >>> > > Ah, no, that was just the soft scrollback code I was thinking of, which >>> >>> Right. >>> That was commit 973c096f6a85 and it

[PATCH v2 1/4] drm/msm/adreno: Add support for Adreno 8c Gen 3

2022-01-19 Thread Akhil P Oommen
Add support for "Adreno 8c Gen 3" gpu along with the necessary speedbin support. Signed-off-by: Akhil P Oommen --- Changes in v2: - Fix a bug in adreno_cmp_rev() drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 21 ++ drivers/gpu/drm/msm/adreno/adreno_device.c | 34

[PATCH v2 2/4] arm64: dts: qcom: sc7280: Support gpu speedbin

2022-01-19 Thread Akhil P Oommen
Add the speedbin fuse and the required opps to support gpu sku. Signed-off-by: Akhil P Oommen --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280.dtsi | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/ar

[PATCH v2 3/4] drm/msm/adreno: Expose speedbin to userspace

2022-01-19 Thread Akhil P Oommen
Expose speedbin through MSM_PARAM_CHIP_ID parameter to help userspace identify the sku. Signed-off-by: Akhil P Oommen --- Changes in v2: - Use SKU in chipid PARAM only in new targets (Rob) drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)

[PATCH v2 4/4] drm/msm/adreno: Update the name of 7c3 gpu

2022-01-19 Thread Akhil P Oommen
Update the name in the gpulist for 7c3 gpu as per the latest recommendation. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/driv

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Arnaud POULIQUEN
Hello Rob, On 1/19/22 2:50 AM, Rob Herring wrote: > The 'phandle-array' type is a bit ambiguous. It can be either just an > array of phandles or an array of phandles plus args. Many schemas for > phandle-array properties aren't clear in the schema which case applies > though the description usuall

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Rob Herring
On Wed, Jan 19, 2022 at 4:35 AM Vladimir Oltean wrote: > > On Tue, Jan 18, 2022 at 07:50:38PM -0600, Rob Herring wrote: > > The 'phandle-array' type is a bit ambiguous. It can be either just an > > array of phandles or an array of phandles plus args. Many schemas for > > phandle-array properties a

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Rob Herring
On Wed, Jan 19, 2022 at 9:22 AM Arnaud POULIQUEN wrote: > > Hello Rob, > > On 1/19/22 2:50 AM, Rob Herring wrote: > > The 'phandle-array' type is a bit ambiguous. It can be either just an > > array of phandles or an array of phandles plus args. Many schemas for > > phandle-array properties aren't

Re: [RESEND] drm: panel-orientation-quirks: Add quirk for the 1Netbook OneXPlayer

2022-01-19 Thread Daniel Vetter
On Thu, Jan 13, 2022 at 08:06:20AM +0800, Raymond Jay Golo wrote: > The 1Netbook OneXPlayer uses a panel which has been mounted > 90 degrees rotated. Add a quirk for this. > > Signed-off-by: Raymond Jay Golo Applied to drm-misc-next-fixes, should show pu in the merge window still for -rc1. -Dani

Re: [PATCH v5 4/4] dt-bindings: drm/bridge: anx7625: Add aux-bus node

2022-01-19 Thread Robert Foss
Hey Hsin-Yi, While I can review this patch, I don't have the authority to merge it since it is outside the scope of my maintainership. Rob Herring, Daniel Vetter or David Airlie would have to Ack this patch. On Wed, 19 Jan 2022 at 16:18, Hsin-Yi Wang wrote: > > List panel under aux-bus node if i

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Thomas Zimmermann
Hi Am 19.01.22 um 16:05 schrieb Sven Schnelle: Daniel Vetter writes: On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds wrote: Irrespective of this code being buggy or not buggy I think the bigger pictures, and really the reason I want to see as much code ditched from the fbdev/fbcon stack as we

Re: [PATCH v5 1/4] drm/bridge: anx7625: send DPCD command to downstream

2022-01-19 Thread Robert Foss
On Wed, 19 Jan 2022 at 16:17, Hsin-Yi Wang wrote: > > From: Xin Ji > > Send DPCD command to downstream before anx7625 power down, > let downstream monitor enter into standby mode. > > Signed-off-by: Xin Ji > Signed-off-by: Hsin-Yi Wang Hsin-Yi: Can you supply a r-b tag to this patch if it look

Re: fbdev: Garbage collect fbdev scrolling acceleration

2022-01-19 Thread Daniel Vetter
On Thu, Jan 13, 2022 at 10:46:03PM +0100, Sven Schnelle wrote: > Helge Deller writes: > > > I may have missed some discussions, but I'm objecting against this patch: > > > > b3ec8cdf457e5 ("fbdev: Garbage collect fbdev scrolling acceleration, > > part 1 (from TODO list)") > > > > Can we plea

[PATCH] drm/bridge: Add missing pm_runtime_put_sync

2022-01-19 Thread Yongzhi Liu
pm_runtime_get_sync() will increase the rumtime PM counter even it returns an error. Thus a pairing decrement is needed to prevent refcount leak. Fix this by replacing this API with pm_runtime_resume_and_get(), which will not change the runtime PM counter on error. Besides, a matching decrement is

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 4:06 PM Sven Schnelle wrote: > > Daniel Vetter writes: > > > On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds > > wrote: > > Irrespective of this code being buggy or not buggy I think the bigger > > pictures, and really the reason I want to see as much code ditched > > from

  1   2   3   >