Hello Rob,
On 1/19/22 2:50 AM, Rob Herring wrote:
> The 'phandle-array' type is a bit ambiguous. It can be either just an
> array of phandles or an array of phandles plus args. Many schemas for
> phandle-array properties aren't clear in the schema which case applies
> though the description usually describes it.
>
> The array of phandles case boils down to needing:
>
> items:
> maxItems: 1
>
> The phandle plus args cases should typically take this form:
>
> items:
> - items:
> - description: A phandle
> - description: 1st arg cell
> - description: 2nd arg cell
>
> With this change, some examples need updating so that the bracketing of
> property values matches the schema.
>
> Cc: Damien Le Moal <damien.lem...@opensource.wdc.com>
> Cc: Herbert Xu <herb...@gondor.apana.org.au>
> Cc: "David S. Miller" <da...@davemloft.net>
> Cc: Chun-Kuang Hu <chunkuang...@kernel.org>
> Cc: Philipp Zabel <p.za...@pengutronix.de>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> Cc: Vinod Koul <vk...@kernel.org>
> Cc: Georgi Djakov <dja...@kernel.org>
> Cc: Thomas Gleixner <t...@linutronix.de>
> Cc: Marc Zyngier <m...@kernel.org>
> Cc: Joerg Roedel <j...@8bytes.org>
> Cc: Lee Jones <lee.jo...@linaro.org>
> Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> Cc: Jingoo Han <jingooh...@gmail.com>
> Cc: Pavel Machek <pa...@ucw.cz>
> Cc: Mauro Carvalho Chehab <mche...@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlow...@canonical.com>
> Cc: Jakub Kicinski <k...@kernel.org>
> Cc: Wolfgang Grandegger <w...@grandegger.com>
> Cc: Marc Kleine-Budde <m...@pengutronix.de>
> Cc: Andrew Lunn <and...@lunn.ch>
> Cc: Vivien Didelot <vivien.dide...@gmail.com>
> Cc: Florian Fainelli <f.faine...@gmail.com>
> Cc: Vladimir Oltean <olte...@gmail.com>
> Cc: Kalle Valo <kv...@kernel.org>
> Cc: Viresh Kumar <vire...@kernel.org>
> Cc: Stephen Boyd <sb...@kernel.org>
> Cc: Kishon Vijay Abraham I <kis...@ti.com>
> Cc: Linus Walleij <linus.wall...@linaro.org>
> Cc: "Rafael J. Wysocki" <raf...@kernel.org>
> Cc: Kevin Hilman <khil...@kernel.org>
> Cc: Ulf Hansson <ulf.hans...@linaro.org>
> Cc: Sebastian Reichel <s...@kernel.org>
> Cc: Mark Brown <broo...@kernel.org>
> Cc: Mathieu Poirier <mathieu.poir...@linaro.org>
> Cc: Daniel Lezcano <daniel.lezc...@linaro.org>
> Cc: Zhang Rui <rui.zh...@intel.com>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: Thierry Reding <thierry.red...@gmail.com>
> Cc: Jonathan Hunter <jonath...@nvidia.com>
> Cc: Sudeep Holla <sudeep.ho...@arm.com>
> Cc: Geert Uytterhoeven <geert+rene...@glider.be>
> Cc: linux-...@vger.kernel.org
> Cc: linux-cry...@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaeng...@vger.kernel.org
> Cc: linux...@vger.kernel.org
> Cc: io...@lists.linux-foundation.org
> Cc: linux-l...@vger.kernel.org
> Cc: linux-me...@vger.kernel.org
> Cc: net...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-wirel...@vger.kernel.org
> Cc: linux-...@lists.infradead.org
> Cc: linux-g...@vger.kernel.org
> Cc: linux-ri...@lists.infradead.org
> Cc: linux-remotep...@vger.kernel.org
> Cc: alsa-de...@alsa-project.org
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Rob Herring <r...@kernel.org>
> ---
[...]
> .../bindings/remoteproc/st,stm32-rproc.yaml | 33 ++++++--
[...]
> diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> index b587c97c282b..be3d9b0e876b 100644
> --- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> @@ -29,17 +29,22 @@ properties:
>
> st,syscfg-holdboot:
> description: remote processor reset hold boot
> - - Phandle of syscon block.
> - - The offset of the hold boot setting register.
> - - The field mask of the hold boot.
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> - maxItems: 1
> + items:
> + - items:
> + - description: Phandle of syscon block
> + - description: The offset of the hold boot setting register
> + - description: The field mask of the hold boot
>
> st,syscfg-tz:
> description:
> Reference to the system configuration which holds the RCC trust zone
> mode
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> - maxItems: 1
> + items:
> + - items:
> + - description: Phandle of syscon block
> + - description: FIXME
> + - description: FIXME
- description: The offset of the trust zone setting register
- description: The field mask of the trust zone state
>
> interrupts:
> description: Should contain the WWDG1 watchdog reset interrupt
> @@ -93,20 +98,32 @@ properties:
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> description: |
> Reference to the system configuration which holds the remote
> - maxItems: 1
> + items:
> + - items:
> + - description: Phandle of syscon block
> + - description: FIXME
> + - description: FIXME
- description: The offset of the power setting register
- description: The field mask of the PDDS selection
>
> st,syscfg-m4-state:
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> description: |
> Reference to the tamp register which exposes the Cortex-M4 state.
> - maxItems: 1
> + items:
> + - items:
> + - description: Phandle of syscon block with the tamp register
> + - description: FIXME
> + - description: FIXME
- description: The offset of the tamp register
- description: The field mask of the Cortex-M4 state
>
> st,syscfg-rsc-tbl:
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> description: |
> Reference to the tamp register which references the Cortex-M4
> resource table address.
> - maxItems: 1
> + items:
> + - items:
> + - description: Phandle of syscon block with the tamp register
> + - description: FIXME
> + - description: FIXME
- description: The offset of the tamp register
- description: The field mask of the Cortex-M4 resource table address
Please tell me if you prefer that I fix this in a dedicated patch.
Thanks,
Arnaud
