Re: [PATCH] drm/vgem: Restore mmap functionality

2021-07-12 Thread Thomas Zimmermann
Hi Am 09.07.21 um 16:43 schrieb Daniel Vetter: On Fri, Jul 9, 2021 at 1:47 PM Thomas Zimmermann wrote: Commit 375cca1cfeb5 ("drm/vgem: Implement mmap as GEM object function") accidentally removed the actual mmap functionality from vgem. Restore the original implementation and VMA flags. Ah

Re: [PATCH v4] drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

2021-07-12 Thread Ville Syrjälä
On Thu, May 20, 2021 at 02:58:20PM +0800, Kai-Heng Feng wrote: > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > to discrete GFX after S3. This is not desirable, because userspace will > treat connected display as a new one, losing display settings. > > The expected behav

[PATCH 5.13 407/800] drm/i915: Merge fix for "drm: Switch to %p4cc format modifier"

2021-07-12 Thread Greg Kroah-Hartman
From: Stephen Rothwell [ Upstream commit e3c2f1870af43fc95f6fe141537f5142c5fe4717 ] Signed-off-by: Stephen Rothwell Signed-off-by: Thomas Zimmermann Fixes: 92f1d09ca4ed ("drm: Switch to %p4cc format modifier") Cc: Sakari Ailus Cc: Petr Mladek Cc: Andy Shevchenko Cc: dri-devel@lists.freedesk

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-12 Thread Pekka Paalanen
On Fri, 9 Jul 2021 18:23:26 +0200 Raphael Gallais-Pou wrote: > On 7/9/21 10:04 AM, Pekka Paalanen wrote: > > On Wed, 7 Jul 2021 08:48:47 + > > Raphael GALLAIS-POU - foss wrote: > > > >> Some display controllers can be programmed to present non-black colors > >> for pixels not covered by an

Aw: Re: Re: Re: BUG: MTK DRM/HDMI broken on 5.13 (mt7623/bpi-r2)

2021-07-12 Thread Frank Wunderlich
Hi, HDMI is broken again in 5.14-rc1 (of course i have applied my patch [1]) now i've got a NULL pointer dereference [ 21.883641] PC is at mtk_dpi_bridge_atomic_check+0x38/0x78 [ 21.889158] LR is at drm_atomic_bridge_chain_check+0x150/0x30c "dpi" is not set correctly in mtk_dpi_bridge_atom

[PATCH 1/1] fbmem: Do not delete the mode that is still in use

2021-07-12 Thread Zhen Lei
The execution of fb_delete_videomode() is not based on the result of the previous fbcon_mode_deleted(). As a result, the mode is directly deleted, regardless of whether it is still in use, which may cause UAF. == BUG: KASAN: use-after

Re: [PATCH] drm/bridge: dw-mipi-dsi: Find the possible DSI devices

2021-07-12 Thread Robert Foss
Reviewed-by: Robert Foss

Re: [PATCH v3 07/20] drm/panfrost: use scheduler dependency tracking

2021-07-12 Thread Steven Price
On 08/07/2021 18:37, Daniel Vetter wrote: > Just deletes some code that's now more shared. > > Note that thanks to the split into drm_sched_job_init/arm we can now > easily pull the _init() part from under the submission lock way ahead > where we're adding the sync file in-fences as dependencies.

Re: [PATCH 2/2] drm/ttm: Fix COW check

2021-07-12 Thread Christian König
Am 10.07.21 um 02:29 schrieb Felix Kuehling: On 2021-07-09 3:37 p.m., Christian König wrote: Am 09.07.21 um 21:31 schrieb Felix Kuehling: On 2021-07-09 2:38 a.m., Christian König wrote: Am 08.07.21 um 21:36 schrieb Alex Deucher: From: Felix Kuehling KFD Thunk maps invisible VRAM BOs with

Re: [PATCH 1/1] drm/ttm: Fix COW check

2021-07-12 Thread Christian König
Am 10.07.21 um 02:28 schrieb Felix Kuehling: KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. is_cow_mapping returns true for these mappings. Add a check for vm_flags & VM_WRITE to avoid mmap failures on private read-only or PROT_NONE mappings. v2: protect against mprotect making a

Re: [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Thomas Zimmermann
Am 26.06.21 um 18:51 schrieb Rajeev Nandan: Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and register a backlight for those panels in drm_panel to simplify the panel driver

Re: [PATCH] drm/ingenic: Convert to Linux IRQ interfaces

2021-07-12 Thread Thomas Zimmermann
Hi Am 10.07.21 um 12:04 schrieb Paul Cercueil: Hi, Le sam., juil. 10 2021 at 08:33:47 +0200, Sam Ravnborg a écrit : Hi Thomas, On Tue, Jul 06, 2021 at 09:44:09AM +0200, Thomas Zimmermann wrote:  Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's  IRQ helpers are mostly usefu

Re: [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Thomas Zimmermann
Hi Am 12.07.21 um 11:41 schrieb Thomas Zimmermann: Am 26.06.21 um 18:51 schrieb Rajeev Nandan: Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and register a backlight for t

[PATCH] drm/mediatek: mtk-dpi: Set out_fmt from config if not the last bridge

2021-07-12 Thread Hsin-Yi Wang
atomic_get_output_bus_fmts() is only called when the bridge is the last element in the bridge chain. If mtk-dpi is not the last bridge, the format of output_bus_cfg is MEDIA_BUS_FMT_FIXED, and mtk_dpi_dual_edge() will fail to write correct value to regs. Fixes: ec8747c52434 ("drm/mediatek: dpi: A

Re: [PATCH] include/uapi/drm: fix spelling mistakes in header files

2021-07-12 Thread Karol Herbst
On Sat, Jul 3, 2021 at 11:00 AM Simon Ser wrote: > > Reviewed-by: Simon Ser > > But this this touches a lot of different drivers, not sure we can just > merge this via drm-misc-next? > > In any case, please ping me again in a week if this hasn't been merged > by then. > As long as it doesn't tou

Re: [PATCH v3] drm/panfrost:fix the exception name always "UNKNOWN"

2021-07-12 Thread Steven Price
On 08/07/2021 08:34, ChunyouTang wrote: > From: ChunyouTang > > The exception_code in register is only 8 bits,So if > fault_status in panfrost_gpu_irq_handler() don't > (& 0xFF),it can't get correct exception reason. > > and it's better to show all of the register value > to custom,so it's bette

Re: [PATCH] video: backlight: Drop maximum brightness override for brightness zero

2021-07-12 Thread Daniel Thompson
On Fri, Jul 09, 2021 at 03:53:16PM +0200, Noralf Trønnes wrote: > > > Den 09.07.2021 15.26, skrev Marek Vasut: > > The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper > > in backlight.c") says that gpio-backlight uses brightness as power state. > > This has been fixed since

Re: [PATCH] fbcon: garbage collect fbdev scrolling acceleration

2021-07-12 Thread Geert Uytterhoeven
Hi Hamza, On Fri, Jul 9, 2021 at 11:28 PM Hamza Mahfooz wrote: > On Fri, Jul 9 2021 at 09:49:02 AM +0200, Geert Uytterhoeven > wrote: > > Bummer, more code to revert to re-enable acceleration in the _56_ > > fbdev drivers using acceleration (some of them unusable without), > > despite commit 39a

Re: [PATCH 2/2] drm/ttm, drm/i915: Update ttm_move_memcpy for async use

2021-07-12 Thread Christian König
Am 28.06.21 um 13:21 schrieb Thomas Hellström: On 6/24/21 9:30 PM, Thomas Hellström wrote: The buffer object argument to ttm_move_memcpy was only used to determine whether the destination memory should be cleared only or whether we should copy data. Replace it with a "clear" bool, and update

Re: [PATCH] dma-buf/sync_file: Don't leak fences on merge failure

2021-07-12 Thread Christian König
Sorry for the vacation and sick leave induced delay. I've just pushed this to drm-misc-fixes. Thanks, Christian. Am 24.06.21 um 21:43 schrieb Jason Ekstrand: I don't have drm-misc access. Mind pushing? On Thu, Jun 24, 2021 at 12:59 PM Christian König wrote: Am 24.06.21 um 19:47 schrieb Jas

Re: [PATCH] drm/shmobile: Convert to Linux IRQ interfaces

2021-07-12 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Jul 6, 2021 at 9:49 AM Thomas Zimmermann wrote: > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > don't benefit from using it. > > Signed-off-by: Thomas Zimmermann Thanks for your patch!

Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-12 Thread Dafna Hirschfeld
Hi On 10.07.21 15:24, Frank Wunderlich wrote: From: Frank Wunderlich HDMI output was broken on mt7623/BPI-R2 in 5.13 because function for special output selection (mtk_mmsys_ddp_sout_sel) was dropped. This function wrote 3 registers at one time and so it is not compatible with the array-approa

Re: [PATCH 0/4] vkms: Switch to shadow-buffered plane state

2021-07-12 Thread Sumera Priyadarsini
On Mon, Jul 5, 2021 at 1:16 PM Thomas Zimmermann wrote: > > Vkms copies each plane's framebuffer into the output buffer; essentially > using a shadow buffer. DRM provides struct drm_shadow_plane_state, which > handles the details of mapping/unmapping shadow buffers into memory for > active planes.

[PATCH 0/8] Per client engine busyness

2021-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Same old work but now rebased and series ending with some DRM docs proposing the common specification which should enable nice common userspace tools to be written. For the moment I only have intel_gpu_top converted to use this and that seems to work okay. Tvrtko Ursulin (8

[PATCH 1/8] drm/i915: Explicitly track DRM clients

2021-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Tracking DRM clients more explicitly will allow later patches to accumulate past and current GPU usage in a centralised place and also consolidate access to owning task pid/name. Unique client id is also assigned for the purpose of distinguishing/ consolidating between multi

[PATCH 2/8] drm/i915: Update client name on context create

2021-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some clients have the DRM fd passed to them over a socket by the X server. Grab the real client and pid when they create their first context and update the exposed data for more useful enumeration. To enable lockless access to client name and pid data from the following pat

[PATCH 4/8] drm/i915: Track runtime spent in closed and unreachable GEM contexts

2021-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As contexts are abandoned we want to remember how much GPU time they used (per class) so later we can used it for smarter purposes. As GEM contexts are closed we want to have the DRM client remember how much GPU time they used (per class) so later we can used it for smarter

[PATCH 3/8] drm/i915: Make GEM contexts track DRM clients

2021-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If we make GEM contexts keep a reference to i915_drm_client for the whole of their lifetime, we can consolidate the current task pid and name usage by getting it from the client. v2: Don't bother supporting selftests contexts from debugfs. (Chris) v3 (Lucas): Finish construc

[PATCH 5/8] drm/i915: Track all user contexts per client

2021-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We soon want to start answering questions like how much GPU time is the context belonging to a client which exited still using. To enable this we start tracking all context belonging to a client on a separate list. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamse

[RFC 8/8] drm: Document fdinfo format specification

2021-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Proposal to standardise the fdinfo text format as optionally output by DRM drivers. Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM. i91

[PATCH 6/8] drm/i915: Track context current active time

2021-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Track context active (on hardware) status together with the start timestamp. This will be used to provide better granularity of context runtime reporting in conjunction with already tracked pphwsp accumulated runtime. The latter is only updated on context save so does not g

[RFC 7/8] drm/i915: Expose client engine utilisation via fdinfo

2021-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Similar to AMD commit 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for i915. Example of the output: pos:0 flags: 012 mnt_id: 21 drm-driver:

[PATCH v2] drm/vgem: Restore mmap functionality

2021-07-12 Thread Thomas Zimmermann
Commit 375cca1cfeb5 ("drm/vgem: Implement mmap as GEM object function") accidentally removed the actual mmap functionality from vgem. Restore the original implementation by restoring the vm_pgoff in the mmap code. Fixes access to unmapped memory: [ 106.591744] BUG: KASAN: vmalloc-out-of-bounds i

Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-12 Thread Frank Wunderlich
> Gesendet: Montag, 12. Juli 2021 um 13:50 Uhr > Von: "Dafna Hirschfeld" > An: "Frank Wunderlich" , linux-media...@lists.infradead.org > Cc: "Frank Wunderlich" , "Matthias Brugger" > , "CK Hu" , > linux-arm-ker...@lists.infradead.org, linux-ker...@vger.kernel.org, "Enric > Balletbo Serra" , "Da

Re: [PATCH 0/4] vkms: Switch to shadow-buffered plane state

2021-07-12 Thread Thomas Zimmermann
Hi Am 12.07.21 um 13:56 schrieb Sumera Priyadarsini: On Mon, Jul 5, 2021 at 1:16 PM Thomas Zimmermann wrote: Vkms copies each plane's framebuffer into the output buffer; essentially using a shadow buffer. DRM provides struct drm_shadow_plane_state, which handles the details of mapping/unmappi

Re: [PATCH 01/12] drm/mgag200: Select clock in PLL update functions

2021-07-12 Thread Thomas Zimmermann
Hi Am 09.07.21 um 20:50 schrieb Sam Ravnborg: Hi Thomas, On Mon, Jul 05, 2021 at 02:45:04PM +0200, Thomas Zimmermann wrote: Put the clock-selection code into each of the PLL-update functions to make them select the correct pixel clock. The pixel clock for video output was not actually set bef

Re: [PATCH] dma-buf/sync_file: Don't leak fences on merge failure

2021-07-12 Thread Jason Ekstrand
No worries. Thanks for pushing! On Mon, Jul 12, 2021 at 6:37 AM Christian König wrote: > > Sorry for the vacation and sick leave induced delay. > > I've just pushed this to drm-misc-fixes. > > Thanks, > Christian. > > Am 24.06.21 um 21:43 schrieb Jason Ekstrand: > > I don't have drm-misc access.

Re: [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Doug Anderson
Hi, On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > +EDP_DISPLAY_CTL_CAP_SIZE); > > This creates a cyclic dependency between drm_kms_helper-ko and drm.ko. > drm_panel.c is in the latter, wh

Re: [PATCH 02/12] drm/mgag200: Return errno codes from PLL compute functions

2021-07-12 Thread Thomas Zimmermann
Hi Am 09.07.21 um 20:53 schrieb Sam Ravnborg: On Mon, Jul 05, 2021 at 02:45:05PM +0200, Thomas Zimmermann wrote: Return -EINVAL if there's no PLL configuration for the given pixel clock. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 4 ++-- 1 file changed, 2

Re: [Intel-gfx] [PATCH v2] drm/i915: Add TTM offset argument to mmap.

2021-07-12 Thread Jason Ekstrand
On Fri, Jul 9, 2021 at 6:41 AM Maarten Lankhorst wrote: > > This is only used for ttm, and tells userspace that the mapping type is > ignored. This disables the other type of mmap offsets when discrete > memory is used, so fix the selftests as well. > > Document the struct as well, so it shows up

Re: [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-07-12 Thread Will Deacon
On Tue, Jul 06, 2021 at 12:59:57PM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Jul 06, 2021 at 05:57:21PM +0100, Will Deacon wrote: > > On Tue, Jul 06, 2021 at 10:46:07AM -0400, Konrad Rzeszutek Wilk wrote: > > > On Tue, Jul 06, 2021 at 04:05:13PM +0200, Christoph Hellwig wrote: > > > > On Tue, J

Re: [PATCH 04/12] drm/mgag200: Split PLL setup into compute and update functions

2021-07-12 Thread Thomas Zimmermann
Hi Am 09.07.21 um 21:12 schrieb Sam Ravnborg: Ho Thomas, On Mon, Jul 05, 2021 at 02:45:07PM +0200, Thomas Zimmermann wrote: The _set_plls() functions compute a pixel clock's PLL values and program the hardware accordingly. This happens during atomic commits. For atomic modesetting, it's bette

Re: [PATCH v5] Documentation: gpu: Mention the requirements for new properties

2021-07-12 Thread Daniel Vetter
On Fri, Jul 09, 2021 at 12:08:14PM +0300, Pekka Paalanen wrote: > On Fri, 9 Jul 2021 10:02:28 +0200 > Daniel Vetter wrote: > > > On Fri, Jul 09, 2021 at 10:24:44AM +0300, Pekka Paalanen wrote: > > > On Tue, 6 Jul 2021 18:12:44 +0200 > > > Maxime Ripard wrote: > > > > > > > New KMS properties

Re: [PATCH 06/12] drm/mgag200: Store values (not bits) in struct mgag200_pll_values

2021-07-12 Thread Thomas Zimmermann
Hi Am 10.07.21 um 09:06 schrieb Sam Ravnborg: Hi Thomas, On Mon, Jul 05, 2021 at 02:45:09PM +0200, Thomas Zimmermann wrote: The fields in struct mgag200_pll_values currently hold the bits of each register. Store the PLL values instead and let the PLL-update code figure out the bits for each re

Re: [Intel-gfx] [PATCH v2] drm/i915: Add TTM offset argument to mmap.

2021-07-12 Thread Daniel Vetter
On Mon, Jul 12, 2021 at 08:47:24AM -0500, Jason Ekstrand wrote: > On Fri, Jul 9, 2021 at 6:41 AM Maarten Lankhorst > wrote: > > > > This is only used for ttm, and tells userspace that the mapping type is > > ignored. This disables the other type of mmap offsets when discrete > > memory is used, so

Re: [PATCH] drm/vgem: Restore mmap functionality

2021-07-12 Thread Daniel Vetter
On Mon, Jul 12, 2021 at 09:09:24AM +0200, Thomas Zimmermann wrote: > Hi > > Am 09.07.21 um 16:43 schrieb Daniel Vetter: > > On Fri, Jul 9, 2021 at 1:47 PM Thomas Zimmermann > > wrote: > > > > > > Commit 375cca1cfeb5 ("drm/vgem: Implement mmap as GEM object function") > > > accidentally removed

RE: [PATCH v2] drm/dp: follow DP link CTS spec to read link status back

2021-07-12 Thread Lee, Shawn C
On Wed, 08 Jul 2021, Lee Shawn C wrote: >On Wed, 07 Jul 2021, 4:14 p.m, Jani Nikula wrote: >>On Wed, 07 Jul 2021, Lee Shawn C wrote: >>> Refer to DP link CTS 1.2/1.4 spec, the following test case request >>> source read DPCD 200h - 205h to get latest link status from sink. >>> >>> (4.3.2.4) H

Re: [PATCH 06/12] drm/mgag200: Store values (not bits) in struct mgag200_pll_values

2021-07-12 Thread Sam Ravnborg
Hi Thomas, > As I mention, struct mgag200_pll_values should store the PLL values. But the > individual compute and set functions for each hardware revision mess this up > completely. Sometimes they use 'function values' sometimes they use > 'register values'. If you'd try to debug a failed modeset

Re: [PATCH] drm/of: free the right object

2021-07-12 Thread Daniel Vetter
On Fri, Jul 09, 2021 at 10:07:17PM +0200, Julia Lawall wrote: > There is no need to free a NULL value. Instead, free the object > that is leaking due to the iterator. > > The semantic patch that finds this problem is as follows: > > // > @@ > expression x,e; > identifier f; > @@ > x = f(...);

Re: [PATCH 0/4] vkms: Switch to shadow-buffered plane state

2021-07-12 Thread Sumera Priyadarsini
On Mon, Jul 12, 2021 at 6:53 PM Thomas Zimmermann wrote: > > Hi > > Am 12.07.21 um 13:56 schrieb Sumera Priyadarsini: > > On Mon, Jul 5, 2021 at 1:16 PM Thomas Zimmermann > > wrote: > >> > >> Vkms copies each plane's framebuffer into the output buffer; essentially > >> using a shadow buffer. DRM

Re: [PATCH 1/2] drm/i915: Don't allow setting I915_CONTEXT_PARAM_VM twice

2021-07-12 Thread Daniel Vetter
On Sat, Jul 10, 2021 at 04:24:46PM -0500, Jason Ekstrand wrote: > Allowing setting it multiple times brings no real utility to the API, no > userspace relies on it, and it does make i915 a tiny bit more > complicated. Let's disallow it for now unless someone comes up with a > compelling reason to

Re: [Intel-gfx] [PATCH v2] drm/i915: Add TTM offset argument to mmap.

2021-07-12 Thread Jason Ekstrand
On Mon, Jul 12, 2021 at 9:12 AM Daniel Vetter wrote: > > On Mon, Jul 12, 2021 at 08:47:24AM -0500, Jason Ekstrand wrote: > > On Fri, Jul 9, 2021 at 6:41 AM Maarten Lankhorst > > wrote: > > > > > > This is only used for ttm, and tells userspace that the mapping type is > > > ignored. This disables

Re: [PATCH 2/2] drm/i915/uapi: Add docs about immutability of engine sets and VMs

2021-07-12 Thread Daniel Vetter
On Sat, Jul 10, 2021 at 04:24:47PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > Cc: Daniel Vetter > --- > include/uapi/drm/i915_drm.h | 39 ++--- > 1 file changed, 28 insertions(+), 11 deletions(-) > > diff --git a/include/uapi/drm/i915_drm.h b/

Re: [PATCH 1/1] fbmem: Do not delete the mode that is still in use

2021-07-12 Thread Daniel Vetter
On Mon, Jul 12, 2021 at 04:55:44PM +0800, Zhen Lei wrote: > The execution of fb_delete_videomode() is not based on the result of the > previous fbcon_mode_deleted(). As a result, the mode is directly deleted, > regardless of whether it is still in use, which may cause UAF. > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Add TTM offset argument to mmap.

2021-07-12 Thread Daniel Vetter
On Mon, Jul 12, 2021 at 09:31:13AM -0500, Jason Ekstrand wrote: > On Mon, Jul 12, 2021 at 9:12 AM Daniel Vetter wrote: > > > > On Mon, Jul 12, 2021 at 08:47:24AM -0500, Jason Ekstrand wrote: > > > On Fri, Jul 9, 2021 at 6:41 AM Maarten Lankhorst > > > wrote: > > > > > > > > This is only used for

Re: [PATCH 1/8] drm/i915: Explicitly track DRM clients

2021-07-12 Thread Daniel Vetter
On Mon, Jul 12, 2021 at 01:17:12PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Tracking DRM clients more explicitly will allow later patches to > accumulate past and current GPU usage in a centralised place and also > consolidate access to owning task pid/name. > > Unique client id i

Re: [PATCH v3] drm/mediatek: adjust rdma fifo threshold calculate formula

2021-07-12 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月11日 週日 下午2:54寫道: > > the orginal formula will caused rdma fifo threshold config overflow > and no one could come out a solution for all SoC, > set threshold to 70% of max fifo size to make sure it will > not overflow, and 70% is a empirical value Applied to

[PATCH v2] drm/dp: Move panel DP AUX backlight support to drm_dp_helper

2021-07-12 Thread Douglas Anderson
We were getting a depmod error: depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper It looks like the rule is that drm_kms_helper can call into drm, but drm can't call into drm_kms_helper. That means we've got to move the DP AUX backlight support into drm_dp_helper. NOTE: as

Re: [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Doug Anderson
Hi, On Mon, Jul 12, 2021 at 6:39 AM Doug Anderson wrote: > > Hi, > > On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > > +EDP_DISPLAY_CTL_CAP_SIZE); > > > > This creates a cyclic depende

Re: [Intel-gfx] [PATCH v2] drm/i915: Add TTM offset argument to mmap.

2021-07-12 Thread Jason Ekstrand
On Mon, Jul 12, 2021 at 9:38 AM Daniel Vetter wrote: > > On Mon, Jul 12, 2021 at 09:31:13AM -0500, Jason Ekstrand wrote: > > On Mon, Jul 12, 2021 at 9:12 AM Daniel Vetter wrote: > > > > > > On Mon, Jul 12, 2021 at 08:47:24AM -0500, Jason Ekstrand wrote: > > > > On Fri, Jul 9, 2021 at 6:41 AM Maar

Re: [RFC PATCH 08/17] dt-bindings: display: bridge: Add Samsung MIPI DSIM bridge

2021-07-12 Thread Rob Herring
On Sun, Jul 04, 2021 at 02:32:21PM +0530, Jagan Teki wrote: > Samsing MIPI DSIM bridge can be found on Exynos and NXP's > i.MX8M Mini and Nano SoC's. > > This dt-bindings replaces legacy exynos_dsim.txt. > > Used the example node from latest Exynos SoC instead of > the one used in legacy exynos_d

Re: [PATCH] drm/dp: Move panel DP AUX backlight support to drm_dp_helper

2021-07-12 Thread Doug Anderson
Hi, On Sat, Jul 10, 2021 at 3:29 AM wrote: > > > @@ -209,18 +208,11 @@ static inline int > > of_drm_get_panel_orientation(const struct device_node *np, > > #if IS_ENABLED(CONFIG_DRM_PANEL) && > > (IS_BUILTIN(CONFIG_BACKLIGHT_CLASS_DEVICE) || \ > > (IS_MODULE(CONFIG_DRM) && IS_MODULE(CONFIG

re: drm/i915/ttm Initialize the ttm device and memory managers

2021-07-12 Thread Colin Ian King
Hi, Static analysis with Coverity on linux-next has found a potential issue in drivers/gpu/drm/i915/selftests/intel_memory_region.c in function igt_mock_fill - the problematic commit is as follows: commit d148738923fdb5077089e48ec1e6008100d0 Author: Thomas Hellström Date: Wed Jun 2 10:38:0

Re: [RFC PATCH 08/17] dt-bindings: display: bridge: Add Samsung MIPI DSIM bridge

2021-07-12 Thread Jagan Teki
On Mon, Jul 12, 2021 at 8:43 PM Rob Herring wrote: > > On Sun, Jul 04, 2021 at 02:32:21PM +0530, Jagan Teki wrote: > > Samsing MIPI DSIM bridge can be found on Exynos and NXP's > > i.MX8M Mini and Nano SoC's. > > > > This dt-bindings replaces legacy exynos_dsim.txt. > > > > Used the example node f

Re: [PATCH v2, 1/3] drm/mediatek: Separate aal module

2021-07-12 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月12日 週一 上午9:03寫道: > > mt8183 aal has no gamma function Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu > -

Re: [PATCH v2, 2/3] drm/mediatek: add mt8183 aal support

2021-07-12 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月12日 週一 上午9:03寫道: > > This patch add mt8183 private data Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu >

Re: [PATCH 0/2] Add "BACKGROUND_COLOR" drm property

2021-07-12 Thread Raphael Gallais-Pou
On 7/9/21 11:23 AM, Simon Ser wrote: > On Friday, July 9th, 2021 at 11:09, Raphael Gallais-Pou > wrote: > >> We don't usually test with piglit and igt-gpu-tools. Instead, modetest >> utility of the libdrm is used quite often (as is it the case in order to >> test this property). > Just to make

Re: [PATCH 1/8] drm/i915: Explicitly track DRM clients

2021-07-12 Thread Tvrtko Ursulin
On 12/07/2021 15:42, Daniel Vetter wrote: On Mon, Jul 12, 2021 at 01:17:12PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Tracking DRM clients more explicitly will allow later patches to accumulate past and current GPU usage in a centralised place and also consolidate access to owning t

[PATCH] drm/of: free the iterator object on failure

2021-07-12 Thread Steven Price
When bailing out due to the sanity check the iterator value needs to be freed because the early return prevents for_each_child_of_node() from doing the dereference itself. Fixes: 4ee48cc5586b ("drm: of: Fix double-free bug") Signed-off-by: Steven Price --- drivers/gpu/drm/drm_of.c | 4 +++- 1 fi

Re: [PATCH 1/8] drm/i915: Explicitly track DRM clients

2021-07-12 Thread Daniel Vetter
On Mon, Jul 12, 2021 at 04:51:42PM +0100, Tvrtko Ursulin wrote: > > On 12/07/2021 15:42, Daniel Vetter wrote: > > On Mon, Jul 12, 2021 at 01:17:12PM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Tracking DRM clients more explicitly will allow later patches to > > > accumula

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-12 Thread Harry Wentland
On 2021-07-12 4:03 a.m., Pekka Paalanen wrote: > On Fri, 9 Jul 2021 18:23:26 +0200 > Raphael Gallais-Pou wrote: > >> On 7/9/21 10:04 AM, Pekka Paalanen wrote: >>> On Wed, 7 Jul 2021 08:48:47 + >>> Raphael GALLAIS-POU - foss wrote: >>> Some display controllers can be programmed to p

Re: [PATCH] drm/fourcc: Add modifier definitions for Arm Fixed Rate Compression

2021-07-12 Thread Liviu Dudau
On Thu, Jul 01, 2021 at 06:07:09PM +0100, Normunds Rieksts wrote: > Arm Fixed Rate Compression (AFRC) is a proprietary fixed rate image > compression protocol and format. > It is designed to provide guaranteed bandwidth and memory footprint > reductions in graphics and media use-cases. > > This pa

Re: [PATCH v2 1/2] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI

2021-07-12 Thread Rob Herring
On Wed, 07 Jul 2021 14:03:22 +0200, Benjamin Gaignard wrote: > Define a new compatible for rk3568 HDMI. > This version of HDMI hardware block needs two new clocks hclk_vio and hclk > to provide phy reference clocks. > > Signed-off-by: Benjamin Gaignard > --- > version 2: > - Add the clocks needed

Re: drm/i915/ttm Initialize the ttm device and memory managers

2021-07-12 Thread Matthew Auld
On Mon, 12 Jul 2021 at 16:17, Colin Ian King wrote: > > Hi, > > Static analysis with Coverity on linux-next has found a potential issue > in drivers/gpu/drm/i915/selftests/intel_memory_region.c in function > igt_mock_fill - the problematic commit is as follows: > > commit d148738923fdb5077089e48ec

Re: [PATCH] drm/fourcc: Add modifier definitions for Arm Fixed Rate Compression

2021-07-12 Thread Simon Ser
Thanks a lot for the documentation, I appreciate the effort.

Re: [PATCH] drm/of: free the iterator object on failure

2021-07-12 Thread Laurent Pinchart
Hi Steven, Thank you for the patch. On Mon, Jul 12, 2021 at 04:57:58PM +0100, Steven Price wrote: > When bailing out due to the sanity check the iterator value needs to be > freed because the early return prevents for_each_child_of_node() from > doing the dereference itself. > > Fixes: 4ee48cc55

Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-12 Thread Frank Wunderlich
Hi, it turns out that problem is the read+or of the new value i reverted my patch and changed reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val; writel_relaxed(reg, mmsys->regs + routes[i].addr); to writel_relaxed(routes[i].val, mmsys->regs + routes[i].addr); and it works too,

Re: [PATCH 1/2 v3] drm/panel: Add DT bindings for Samsung LMS380KF01

2021-07-12 Thread Rob Herring
On Thu, 08 Jul 2021 01:43:14 +0200, Linus Walleij wrote: > This adds device tree bindings for the Samsung Mobile Displays > LMS380KF01 RGB DPI display panel. > > Cc: devicet...@vger.kernel.org > Cc: phone-de...@vger.kernel.org > Cc: Douglas Anderson > Cc: Noralf Trønnes > Signed-off-by: Linus Wa

Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-12 Thread Dafna Hirschfeld
Hi, On 12.07.21 19:16, Frank Wunderlich wrote: Hi, it turns out that problem is the read+or of the new value i reverted my patch and changed reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val; writel_relaxed(reg, mmsys->regs + routes[i].addr); to writel_relaxed(routes[i].val,

Re: [PATCH 17/47] drm/i915/guc: Extend deregistration fence to schedule disable

2021-07-12 Thread John Harrison
On 7/9/2021 20:36, Matthew Brost wrote: On Fri, Jul 09, 2021 at 03:59:11PM -0700, John Harrison wrote: On 6/24/2021 00:04, Matthew Brost wrote: Extend the deregistration context fence to fence whne a GuC context has scheduling disable pending. Cc: John Harrison Signed-off-by: Matthew Brost -

Re: [PATCH 16/47] drm/i915/guc: Disable engine barriers with GuC during unpin

2021-07-12 Thread John Harrison
On 7/9/2021 20:00, Matthew Brost wrote: On Fri, Jul 09, 2021 at 03:53:29PM -0700, John Harrison wrote: On 6/24/2021 00:04, Matthew Brost wrote: Disable engine barriers for unpinning with GuC. This feature isn't needed with the GuC as it disables context scheduling before unpinning which guarant

Re: [PATCH 0/4] vkms: Switch to shadow-buffered plane state

2021-07-12 Thread Thomas Zimmermann
Hi Am 12.07.21 um 16:26 schrieb Sumera Priyadarsini: On Mon, Jul 12, 2021 at 6:53 PM Thomas Zimmermann wrote: Hi Am 12.07.21 um 13:56 schrieb Sumera Priyadarsini: On Mon, Jul 5, 2021 at 1:16 PM Thomas Zimmermann wrote: Vkms copies each plane's framebuffer into the output buffer; essentia

Re: [PATCH 23/47] drm/i915/guc: Update GuC debugfs to support new GuC

2021-07-12 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Update GuC debugfs to support the new GuC structures. Signed-off-by: John Harrison Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 22 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 3 ++ .../gpu/drm/i915/

Re: [PATCH 24/47] drm/i915/guc: Add several request trace points

2021-07-12 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Add trace points for request dependencies and GuC submit. Extended existing request trace points to include submit fence value,, guc_id, Excessive punctuation. Or maybe should say 'fence value, tail, guc_id'? With that fixed: Reviewed-by: John Harrison

Re: [PATCH 25/47] drm/i915: Add intel_context tracing

2021-07-12 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Add intel_context tracing. These trace points are particular helpful when debugging the GuC firmware and can be enabled via CONFIG_DRM_I915_LOW_LEVEL_TRACEPOINTS kernel config option. Cc: John Harrison Signed-off-by: Matthew Brost --- drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 16/47] drm/i915/guc: Disable engine barriers with GuC during unpin

2021-07-12 Thread Daniel Vetter
On Mon, Jul 12, 2021 at 7:57 PM John Harrison wrote: > > On 7/9/2021 20:00, Matthew Brost wrote: > > On Fri, Jul 09, 2021 at 03:53:29PM -0700, John Harrison wrote: > >> On 6/24/2021 00:04, Matthew Brost wrote: > >>> Disable engine barriers for unpinning with GuC. This feature isn't > >>> needed wi

Re: [PATCH 27/47] drm/i915: Track 'serial' counts for virtual engines

2021-07-12 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: From: John Harrison The serial number tracking of engines happens at the backend of request submission and was expecting to only be given physical engines. However, in GuC submission mode, the decomposition of virtual to physical engines does not happen

[PATCH] drm/mediatek: Test component initialization earlier in the function mtk_drm_crtc_create

2021-07-12 Thread Dafna Hirschfeld
The initialization is currently tested in a later stage in the function for no reason. In addition, the test '!comp' will never fail since comp is set with the '&' operator. Instead, test if a comp was not initialized by testing "!comp->dev". Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/m

Re: [PATCH 28/47] drm/i915: Hold reference to intel_context over life of i915_request

2021-07-12 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Hold a reference to the intel_context over life of an i915_request. Without this an i915_request can exist after the context has been destroyed (e.g. request retired, context closed, but user space holds a reference to the request from an out fence). In th

Re: [PATCH 29/47] drm/i915/guc: Disable bonding extension with GuC submission

2021-07-12 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Update the bonding extension to return -ENODEV when using GuC submission as this extension fundamentally will not work with the GuC submission interface. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gem/i915_gem_

Re: [PATCH 02/16] drm/i915/guc/slpc: Initial definitions for slpc

2021-07-12 Thread Belgaumkar, Vinay
On 7/10/2021 7:27 AM, Michal Wajdeczko wrote: Hi Vinay, On 10.07.2021 03:20, Vinay Belgaumkar wrote: Add macros to check for slpc support. This feature is currently supported for gen12+ and enabled whenever guc submission is enabled/selected. please try to use consistent names across all p

Re: Linux 5.14-rc1

2021-07-12 Thread Linus Torvalds
On Mon, Jul 12, 2021 at 12:08 AM Jon Masters wrote: > > I happened to be installing a Fedora 34 (x86) VM for something and did a > test kernel compile that hung on boot. Setting up a serial console I get > the below backtrace from ttm but I have not had chance to look at it. It's a NULL pointer i

Re: [PATCH 30/47] drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbs

2021-07-12 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: With GuC virtual engines the physical engine which a request executes and completes on isn't known to the i915. Therefore we can't attach a request to a physical engines breadcrumbs. To work around this we create a single breadcrumbs per engine class when

Re: Linux 5.14-rc1

2021-07-12 Thread Christian König
Hi guys, Am 12.07.21 um 21:14 schrieb Linus Torvalds: On Mon, Jul 12, 2021 at 12:08 AM Jon Masters wrote: I happened to be installing a Fedora 34 (x86) VM for something and did a test kernel compile that hung on boot. Setting up a serial console I get the below backtrace from ttm but I have no

[PATCH 0/3] drm/amdgpu: modernize virtual display feature

2021-07-12 Thread Ryan Taylor
The amdgpu vkms interface provides a virtual KMS interface for several use cases: devices without display hardware, platforms where the actual display hardware is not useful (e.g., servers), SR-IOV virtual functions, device emulation/simulation, and device bring up prior to display hardware being u

[PATCH 1/3] drm/amdgpu: create amdgpu_vkms

2021-07-12 Thread Ryan Taylor
Modify the VKMS driver into an api that dce_virtual can use to create virtual displays that obey drm's atomic modesetting api. Signed-off-by: Ryan Taylor --- drivers/gpu/drm/amd/amdgpu/Makefile | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.

[PATCH 2/3] drm/amdgpu: cleanup dce_virtual

2021-07-12 Thread Ryan Taylor
Remove obsolete functions and variables from dce_virtual. Signed-off-by: Ryan Taylor --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 568 +-- 1 file changed, 3 insertions(+), 565 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/

[PATCH 3/3] drm/amdgpu: replace dce_virtual with amdgpu_vkms

2021-07-12 Thread Ryan Taylor
Move dce_virtual into amdgpu_vkms and update all references to dce_virtual with amdgpu_vkms. Signed-off-by: Ryan Taylor --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 195 drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.h | 3 - dr

Re: [PATCH 1/1] drm: bridge: Mark deprecated operations in drm_bridge_funcs

2021-07-12 Thread Sam Ravnborg
Hi Laurent, On Sat, Jul 10, 2021 at 11:46:24PM +0300, Laurent Pinchart wrote: > Hi Sam, > > Thank you for the patch. > > On Sat, Jul 10, 2021 at 10:42:40AM +0200, Sam Ravnborg wrote: > > drm_bridge_funcs includes several duplicated operations as atomic > > variants has been added over time. > >

Re: [PATCH 31/47] drm/i915/guc: Reset implementation for new GuC interface

2021-07-12 Thread John Harrison
On 6/24/2021 00:05, Matthew Brost wrote: Reset implementation for new GuC interface. This is the legacy reset implementation which is called when the i915 owns the engine hang check. Future patches will offload the engine hang check to GuC but we will continue to maintain this legacy path as a fa

  1   2   >