[PATCH -next] drm/vc4: hdmi: Fix PM reference leak in vc4_hdmi_encoder_pre_crtc_co()

2021-05-24 Thread Zou Wei
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/gpu/drm/vc4/vc

[PATCH -next] drm/bridge: cdns: Fix PM reference leak in cdns_dsi_transfer()

2021-05-24 Thread Zou Wei
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/gpu/drm/bridge

Re: [RFC PATCH 01/13] drm/dsc: Add dsc pps header init function

2021-05-24 Thread Vinod Koul
On 21-05-21, 17:29, Daniel Vetter wrote: > On Fri, May 21, 2021 at 06:19:30PM +0530, Vinod Koul wrote: > > We required a helper to create and set the dsc_dce_header, so add the > > dsc_dce_header and API drm_dsc_dsi_pps_header_init > > > > Signed-off-by: Vinod Koul > > --- > > drivers/gpu/drm/dr

Re: [RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters

2021-05-24 Thread Vinod Koul
On 21-05-21, 09:42, Bjorn Andersson wrote: > On Fri 21 May 07:49 CDT 2021, Vinod Koul wrote: > > > DSC enables streams to be compressed before we send to panel. This > > requires DSC enabled encoder and a panel to be present. So we add this > > information in board DTS and find if DSC can be enabl

[PATCH] drm/amdgpu: fix typo

2021-05-24 Thread nswdhpyhwt
From: "tony.huang_cp" change 'interupt' to 'interrupt' Signed-off-by: tony.huang_cp --- drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c b/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c index 284447d..6c

Re: [PATCH 09/11] drm/omap: Follow implicit fencing in prepare_fb

2021-05-24 Thread Tomi Valkeinen
On 21/05/2021 12:09, Daniel Vetter wrote: I guess no one ever tried running omap together with lima or panfrost, not even sure that's possible. Anyway for consistency, fix this. Signed-off-by: Daniel Vetter Cc: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_plane.c | 3 +++ 1 file changed,

Re: [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default

2021-05-24 Thread Tomi Valkeinen
On 21/05/2021 12:09, Daniel Vetter wrote: No need to set it explicitly. Signed-off-by: Daniel Vetter Cc: Laurentiu Palcu Cc: Lucas Stach Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Philipp Zabel Cc: Paul Cercueil Cc: Chun-Kuang Hu

Re: i915 gvt broke drm-tip; Fix ASAP

2021-05-24 Thread Jani Nikula
On Mon, 24 May 2021, Zhenyu Wang wrote: > On 2021.05.22 21:19:38 +0200, Thomas Zimmermann wrote: >> Hi, >> >> after creating drm-tip today as part of [1], building drm-tip is now broken >> with the error message shown below. >> >> Some register constants appear to be missing from the GVT code. P

Re: [PATCH 0/2] allow the sysfb support to be used in non-x86 arches

2021-05-24 Thread Ard Biesheuvel
Hello Javier, On Fri, 21 May 2021 at 21:29, Javier Martinez Canillas wrote: > > The x86 architecture platform has a Generic System Framebuffers (sysfb) > support, that register a system frambuffer platform devices. It either > registers a "simple-framebuffer" for the simple{fb,drm} drivers or leg

Re: [RFC PATCH 05/97] drm/i915/guc: use probe_error log for CT enablement failure

2021-05-24 Thread Michal Wajdeczko
On 06.05.2021 21:13, Matthew Brost wrote: > From: Daniele Ceraolo Spurio > > We have a couple of failure injection points in the CT enablement path, > so we need to use i915_probe_error() to select the appropriate log level. > A new macro (CT_PROBE_ERROR) has been added to the set of CT loggin

[PATCH] drm: bridge: cdns-mhdp8546: Fix inconsistent indenting

2021-05-24 Thread Jiapeng Chong
Eliminate the follow smatch warning: drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:2143 cdns_mhdp_bridge_atomic_reset() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 +- 1 file changed, 1 in

[PATCH] drm/amdgpu: remove unreachable code

2021-05-24 Thread Jiapeng Chong
In the function amdgpu_uvd_cs_msg(), every branch in the switch statement will have a return, so the code below the switch statement will not be executed. Eliminate the follow smatch warning: drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:845 amdgpu_uvd_cs_msg() warn: ignoring unreachable code. Reporte

Re: [Intel-gfx] [PATCH 0/7] Per client engine busyness

2021-05-24 Thread Tvrtko Ursulin
On 20/05/2021 09:35, Tvrtko Ursulin wrote: On 19/05/2021 19:23, Daniel Vetter wrote: On Wed, May 19, 2021 at 6:16 PM Tvrtko Ursulin wrote: On 18/05/2021 10:40, Tvrtko Ursulin wrote: On 18/05/2021 10:16, Daniel Stone wrote: Hi, On Tue, 18 May 2021 at 10:09, Tvrtko Ursulin wrote: I was

Re: [RFC PATCH 07/97] drm/i915/guc: Remove sample_forcewake h2g action

2021-05-24 Thread Michal Wajdeczko
On 06.05.2021 21:13, Matthew Brost wrote: > From: Rodrigo Vivi > > This action is no-op in the GuC side for a few versions already > and it is getting entirely removed soon, in an upcoming version. > > Time to remove before we face communication issues. > > Cc: Vinay Belgaumkar > Signed-of

Re: [PATCH 0/2] allow the sysfb support to be used in non-x86 arches

2021-05-24 Thread Javier Martinez Canillas
Hello Ard, On 5/24/21 12:24 PM, Ard Biesheuvel wrote: [snip] >> Since this touches both arch/{x86,arm,arm64,riscv} and drivers/firmware, I >> don't know how it should be merged. But I didn't find a way to split these. >> > > We could merge this via the EFI tree without too much risk of > confli

Re: [RFC PATCH 30/97] drm/i915/uc: turn on GuC/HuC auto mode by default

2021-05-24 Thread Michal Wajdeczko
On 06.05.2021 21:13, Matthew Brost wrote: > From: Daniele Ceraolo Spurio > > This will enable HuC loading for Gen11+ by default if the binaries > are available on the system. GuC submission still requires explicit > enabling by the user. > > Signed-off-by: Daniele Ceraolo Spurio > Signed-off

[PATCH v18 3/4] dt-bindings: msm: dsi: add yaml schemas for DSI PHY bindings

2021-05-24 Thread Krishna Manikandan
Add YAML schema for the device tree bindings for DSI PHY. Signed-off-by: Krishna Manikandan Reviewed-by: Bjorn Andersson Reviewed-by: Stephen Boyd Reviewed-by: Rob Herring --- Changes in v1: - Merge dsi-phy.yaml and dsi-phy-10nm.yaml (Stephen Boyd) - Remove qcom,dsi-phy-regulator-ldo-mod

[PATCH v18 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings

2021-05-24 Thread Krishna Manikandan
MSM Mobile Display Subsystem (MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for DPU device tree bindings. Signed-off-by: Krishna Manikandan Reviewed-by: Rob Herring Reviewed-by: Bjorn Andersson Reviewed-by: Stephen Boyd --- Changes in v2: - Changed dpu

[PATCH v18 2/4] dt-bindings: msm: dsi: add yaml schemas for DSI bindings

2021-05-24 Thread Krishna Manikandan
Add YAML schema for the device tree bindings for DSI Signed-off-by: Krishna Manikandan Reviewed-by: Bjorn Andersson Reviewed-by: Stephen Boyd --- Changes in v1: - Separate dsi controller bindings to a separate patch (Stephen Boyd) - Merge dsi-common-controller.yaml and dsi-controller-ma

[PATCH v18 4/4] dt-bindings: msm/dp: Add bindings of MSM DisplayPort controller

2021-05-24 Thread Krishna Manikandan
Add bindings for Snapdragon DisplayPort controller driver. Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah Signed-off-by: Kuogee Hsieh Signed-off-by: Krishna Manikandan Reviewed-by: Bjorn Andersson Reviewed-by: Rob Herring Reviewed-by: Stephen Boyd ---

Re: [PATCH] dt-bindings: display: ssd1307fb: Convert to json-schema

2021-05-24 Thread Maxime Ripard
Hi On Tue, May 18, 2021 at 04:49:45PM +0200, Geert Uytterhoeven wrote: > On Tue, May 18, 2021 at 4:33 PM Maxime Ripard wrote: > > On Tue, May 18, 2021 at 09:51:31AM +0200, Geert Uytterhoeven wrote: > > > Convert the Solomon SSD1307 Framebuffer Device Tree binding > > > documentation to json-schem

Re: [PATCH 0/4] drm/vc4: Add support for the BCM2711 VEC

2021-05-24 Thread Maxime Ripard
On Thu, May 20, 2021 at 05:03:40PM +0200, Maxime Ripard wrote: > Hi, > > The composite output in the BCM2711 is dealt using the VEC. While the earlier > SoCs were properly supported, it wasn't functional on the BCM2711. Add the > needed support from the RPi downstream kernel. > > Maxime Applied

Re: [PATCH v2] drm/exynos: Use pm_runtime_resume_and_get() to replace open coding

2021-05-24 Thread Inki Dae
21. 5. 22. 오전 12:31에 Daniel Vetter 이(가) 쓴 글: > On Fri, May 21, 2021 at 05:06:06PM +0800, Tian Tao wrote: >> use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and >> pm_runtime_put_noidle. > > It would be good to explain why: Apparently get_sync increments the > refcount even if it

Re: [RFC PATCH 35/97] drm/i915/guc: Improve error message for unsolicited CT response

2021-05-24 Thread Michal Wajdeczko
On 06.05.2021 21:13, Matthew Brost wrote: > Improve the error message when a unsolicited CT response is received by > printing fence that couldn't be found, the last fence, and all requests > with a response outstanding. > > Signed-off-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/inte

RE: [drm-rerere PATCH] nightly.conf: drop amd branches from drm-tip

2021-05-24 Thread Jani Nikula
On Wed, 19 May 2021, "Deucher, Alexander" wrote: > [AMD Public Use] > >> -Original Message- >> From: Jani Nikula >> Sent: Wednesday, May 19, 2021 4:50 AM >> To: dim-to...@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; >> jani.nik...@intel.co

Re: [PATCH AUTOSEL 5.12 5/5] tty: vt: always invoke vc->vc_sw->con_resize callback

2021-05-24 Thread Greg KH
On Tue, May 18, 2021 at 07:45:59AM +0200, Greg KH wrote: > On Mon, May 17, 2021 at 06:35:24PM -0700, Linus Torvalds wrote: > > On Mon, May 17, 2021 at 6:09 PM Sasha Levin wrote: > > > > > > From: Tetsuo Handa > > > > > > [ Upstream commit ffb324e6f874121f7dce5bdae5e05d02baae7269 ] > > > > So I t

RE: [drm-rerere PATCH] nightly.conf: drop amd branches from drm-tip

2021-05-24 Thread Jani Nikula
On Mon, 24 May 2021, Jani Nikula wrote: > On Wed, 19 May 2021, "Deucher, Alexander" wrote: >> [AMD Public Use] >> >>> -Original Message- >>> From: Jani Nikula >>> Sent: Wednesday, May 19, 2021 4:50 AM >>> To: dim-to...@lists.freedesktop.org >>> Cc: dri-devel@lists.freedesktop.org; intel-

[PATCH v3] drm/exynos: Use pm_runtime_resume_and_get() to replace open coding

2021-05-24 Thread Tian Tao
use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and pm_runtime_put_noidle to avoid continuing to increase the refcount when pm_runtime_get_sync fails. Signed-off-by: Tian Tao Reviewed-by: Daniel Vetter --- v2: drop unnecessary change about if condition. v3: update the commit messa

Re: [PATCH v2] drm/exynos: Use pm_runtime_resume_and_get() to replace open coding

2021-05-24 Thread tiantao (H)
在 2021/5/24 20:05, Inki Dae 写道: 21. 5. 22. 오전 12:31에 Daniel Vetter 이(가) 쓴 글: On Fri, May 21, 2021 at 05:06:06PM +0800, Tian Tao wrote: use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and pm_runtime_put_noidle. It would be good to explain why: Apparently get_sync increments th

Re: [RFC PATCH 36/97] drm/i915/guc: Add non blocking CTB send function

2021-05-24 Thread Michal Wajdeczko
On 06.05.2021 21:13, Matthew Brost wrote: > Add non blocking CTB send function, intel_guc_send_nb. In order to > support a non blocking CTB send function a spin lock is needed to spin lock was added in 16/97 > protect the CTB descriptors fields. Also the non blocking call must not > update the

Re: [PATCH v4 00/12] drm/vc4: hdmi: Support the 4k @ 60Hz modes

2021-05-24 Thread Maxime Ripard
On Fri, May 07, 2021 at 05:05:03PM +0200, Maxime Ripard wrote: > Hi, > > Here is a series that enables the higher resolutions on the HDMI0 Controller > found in the BCM2711 (RPi4). > > In order to work it needs a few adjustments to config.txt, most notably to > enable the enable_hdmi_4kp60 option

Re: [PATCH 0/2] clk: Implement a clock request API

2021-05-24 Thread Maxime Ripard
Hi Stephen, Mike, On Mon, May 03, 2021 at 10:32:21AM +0200, Maxime Ripard wrote: > Hi Stephen, > > On Fri, Apr 30, 2021 at 01:59:39PM -0700, Stephen Boyd wrote: > > Quoting Maxime Ripard (2021-04-13 03:13:18) > > > Hi, > > > > > > This is a follow-up of the discussion here: > > > https://lore.ke

Re: [RFC PATCH 37/97] drm/i915/guc: Add stall timer to non blocking CTB send function

2021-05-24 Thread Michal Wajdeczko
On 06.05.2021 21:13, Matthew Brost wrote: > Implement a stall timer which fails H2G CTBs once a period of time > with no forward progress is reached to prevent deadlock. > > Also update to ct_write to return -EDEADLK rather than -EPIPE on a > corrupted descriptor. broken descriptor is really s

Re: KASAN errors with vc4 DRM on Raspberry Pi 4

2021-05-24 Thread Maxime Ripard
Hi Marc, On Mon, May 24, 2021 at 12:01:27PM +0200, Marc Haber wrote: > Hi, > > when running a current (5.12.6) Linux kernel on a Raspberry Pi 4 which > has KASAN enablen, upon (manual) loading of the vc4 module, the > following appears in dmesg: > > [ 27.713689] rc rc0: vc4 as /devices/platfor

[PATCH 2/2] drm/vc4: hdmi: Convert to gpiod

2021-05-24 Thread Maxime Ripard
The new gpiod interface takes care of parsing the GPIO flags and to return the logical value when accessing an active-low GPIO, so switching to it simplifies a lot the driver. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 24 +++- drivers/gpu/drm/vc4/vc4_h

[PATCH 1/2] drm/vc4: hdmi: Fix error path of hpd-gpios

2021-05-24 Thread Maxime Ripard
If the of_get_named_gpio_flags call fails in vc4_hdmi_bind, we jump to the err_unprepare_hsm label. That label will then call pm_runtime_disable and put_device on the DDC device. We just retrieved the DDC device, so the latter is definitely justified. However at that point we still haven't called

[PATCH] drm/vc4: hdmi: Rely on interrupts to handle hotplug

2021-05-24 Thread Maxime Ripard
DRM currently polls for the HDMI connector status every 10s, which can be an issue when we connect/disconnect a display quickly or the device on the other end only issues a hotplug pulse (for example on EDID change). Switch the driver to rely on the internal controller logic for the BCM2711/RPi4.

[PATCH -next] media: staging: tegra-vde: Fix error return code in tegra_vde_probe()

2021-05-24 Thread Wei Yongjun
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: dc8276b78917 ("staging: media: tegra-vde: use pm_runtime_resume_and_get()") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/staging/media/tegra-vde/vde.c | 3

[PATCH -next] drm/amdgpu: fix error return code in amdgpu_acpi_init()

2021-05-24 Thread Wei Yongjun
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 77bf762f8b30 ("drm/amdgpu/acpi: unify ATCS handling (v3)") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 5 - 1 file

Re: [PATCH -next] media: staging: tegra-vde: Fix error return code in tegra_vde_probe()

2021-05-24 Thread Dmitry Osipenko
24.05.2021 16:35, Wei Yongjun пишет: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: dc8276b78917 ("staging: media: tegra-vde: use > pm_runtime_resume_and_get()") > Reported-by: Hulk Robot > Signed-off-by: Wei Yong

[PATCH v9 00/10] Add support for SVM atomics in Nouveau

2021-05-24 Thread Alistair Popple
This is a repost of the previous series to rebase on v5.13-rc2 and to address comments. Outside of some code comment updates the primary change was to split the renaming of migrate_pgmap_owner into a separate patch and to further simplify the handling of device exclusive entries in copy_pte_range(

[PATCH v9 01/10] mm: Remove special swap entry functions

2021-05-24 Thread Alistair Popple
Remove multiple similar inline functions for dealing with different types of special swap entries. Both migration and device private swap entries use the swap offset to store a pfn. Instead of multiple inline functions to obtain a struct page for each swap entry type use a common function pfn_swap

[PATCH v9 02/10] mm/swapops: Rework swap entry manipulation code

2021-05-24 Thread Alistair Popple
Both migration and device private pages use special swap entries that are manipluated by a range of inline functions. The arguments to these are somewhat inconsitent so rework them to remove flag type arguments and to make the arguments similar for both read and write entry creation. Signed-off-by

[PATCH v9 03/10] mm/rmap: Split try_to_munlock from try_to_unmap

2021-05-24 Thread Alistair Popple
The behaviour of try_to_unmap_one() is difficult to follow because it performs different operations based on a fairly large set of flags used in different combinations. TTU_MUNLOCK is one such flag. However it is exclusively used by try_to_munlock() which specifies no other flags. Therefore rather

[PATCH v9 04/10] mm/rmap: Split migration into its own function

2021-05-24 Thread Alistair Popple
Migration is currently implemented as a mode of operation for try_to_unmap_one() generally specified by passing the TTU_MIGRATION flag or in the case of splitting a huge anonymous page TTU_SPLIT_FREEZE. However it does not have much in common with the rest of the unmap functionality of try_to_unma

[PATCH v9 05/10] mm: Rename migrate_pgmap_owner

2021-05-24 Thread Alistair Popple
MMU notifier ranges have a migrate_pgmap_owner field which is used by drivers to store a pointer. This is subsequently used by the driver callback to filter MMU_NOTIFY_MIGRATE events. Other notifier event types can also benefit from this filtering, so rename the 'migrate_pgmap_owner' field to 'owne

[PATCH v9 06/10] mm/memory.c: Allow different return codes for copy_nonpresent_pte()

2021-05-24 Thread Alistair Popple
Currently if copy_nonpresent_pte() returns a non-zero value it is assumed to be a swap entry which requires further processing outside the loop in copy_pte_range() after dropping locks. This prevents other values being returned to signal conditions such as failure which a subsequent change requires

[PATCH v9 08/10] mm: Selftests for exclusive device memory

2021-05-24 Thread Alistair Popple
Adds some selftests for exclusive device memory. Signed-off-by: Alistair Popple Acked-by: Jason Gunthorpe Tested-by: Ralph Campbell Reviewed-by: Ralph Campbell --- lib/test_hmm.c | 124 +++ lib/test_hmm_uapi.h| 2 + tools/testing/s

[PATCH v9 09/10] nouveau/svm: Refactor nouveau_range_fault

2021-05-24 Thread Alistair Popple
Call mmu_interval_notifier_insert() as part of nouveau_range_fault(). This doesn't introduce any functional change but makes it easier for a subsequent patch to alter the behaviour of nouveau_range_fault() to support GPU atomic operations. Signed-off-by: Alistair Popple Reviewed-by: Ben Skeggs

[PATCH v9 07/10] mm: Device exclusive memory access

2021-05-24 Thread Alistair Popple
Some devices require exclusive write access to shared virtual memory (SVM) ranges to perform atomic operations on that memory. This requires CPU page tables to be updated to deny access whilst atomic operations are occurring. In order to do this introduce a new swap entry type (SWP_DEVICE_EXCLUSIV

[PATCH v9 10/10] nouveau/svm: Implement atomic SVM access

2021-05-24 Thread Alistair Popple
Some NVIDIA GPUs do not support direct atomic access to system memory via PCIe. Instead this must be emulated by granting the GPU exclusive access to the memory. This is achieved by replacing CPU page table entries with special swap entries that fault on userspace access. The driver then grants th

Re: [PATCH -next] media: staging: tegra-vde: Fix error return code in tegra_vde_probe()

2021-05-24 Thread Dmitry Osipenko
24.05.2021 16:27, Dmitry Osipenko пишет: > 24.05.2021 16:35, Wei Yongjun пишет: >> Fix to return a negative error code from the error handling >> case instead of 0, as done elsewhere in this function. >> >> Fixes: dc8276b78917 ("staging: media: tegra-vde: use >> pm_runtime_resume_and_get()") >> Re

Re: [RFC PATCH 38/97] drm/i915/guc: Optimize CTB writes and reads

2021-05-24 Thread Michal Wajdeczko
On 06.05.2021 21:13, Matthew Brost wrote: > CTB writes are now in the path of command submission and should be > optimized for performance. Rather than reading CTB descriptor values > (e.g. head, tail, size) which could result in accesses across the PCIe size was removed from the descriptor in

Re: [PATCH -next] media: staging: tegra-vde: Fix error return code in tegra_vde_probe()

2021-05-24 Thread weiyongjun (A)
24.05.2021 16:27, Dmitry Osipenko пишет: 24.05.2021 16:35, Wei Yongjun пишет: Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: dc8276b78917 ("staging: media: tegra-vde: use pm_runtime_resume_and_get()") Reported-by: Hu

Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec

2021-05-24 Thread Maxime Ripard
Hi, On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > Hi, > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place, > it's missing a few controls to be able to provide HBR passthrough. This series > adds more infrastructure for the drivers, and leverages it

Re: [Intel-gfx] [RFC PATCH 39/97] drm/i915/guc: Increase size of CTB buffers

2021-05-24 Thread Michal Wajdeczko
On 06.05.2021 21:13, Matthew Brost wrote: > With the introduction of non-blocking CTBs more than one CTB can be in > flight at a time. Increasing the size of the CTBs should reduce how > often software hits the case where no space is available in the CTB > buffer. > > Cc: John Harrison > Signe

Re: [RFC PATCH 40/97] drm/i915/guc: Module load failure test for CT buffer creation

2021-05-24 Thread Michal Wajdeczko
On 06.05.2021 21:13, Matthew Brost wrote: > From: John Harrison > > Add several module failure load inject points in the CT buffer creation > code path. > > Signed-off-by: John Harrison > Signed-off-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 > 1 file

[PATCH AUTOSEL 5.12 56/63] drm/amd/display: Disconnect non-DP with no EDID

2021-05-24 Thread Sasha Levin
From: Chris Park [ Upstream commit 080039273b126eeb0185a61c045893a25dbc046e ] [Why] Active DP dongles return no EDID when dongle is connected, but VGA display is taken out. Current driver behavior does not remove the active display when this happens, and this is a gap between dongle DTP and dong

[PATCH AUTOSEL 5.12 57/63] drm/amd/amdgpu: fix refcount leak

2021-05-24 Thread Sasha Levin
From: Jingwen Chen [ Upstream commit fa7e6abc75f3d491bc561734312d065dc9dc2a77 ] [Why] the gem object rfb->base.obj[0] is get according to num_planes in amdgpufb_create, but is not put according to num_planes [How] put rfb->base.obj[0] in amdgpu_fbdev_destroy according to num_planes Signed-off-

[PATCH AUTOSEL 5.12 58/63] drm/amdgpu: Fix a use-after-free

2021-05-24 Thread Sasha Levin
From: xinhui pan [ Upstream commit 1e5c37385097c35911b0f8a0c67ffd10ee1af9a2 ] looks like we forget to set ttm->sg to NULL. Hit panic below [ 1235.844104] general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b7b4b: [#1] SMP DEBUG_PAGEALLOC NOPTI [ 1235.989074] Call Tra

[PATCH AUTOSEL 5.12 60/63] drm/amdgpu: stop touching sched.ready in the backend

2021-05-24 Thread Sasha Levin
From: Christian König [ Upstream commit a2b4785f01280a4291edb9fda69032fc2e4bfd3f ] This unfortunately comes up in regular intervals and breaks GPU reset for the engine in question. The sched.ready flag controls if an engine can't get working during hw_init, but should never be set to false duri

[PATCH AUTOSEL 5.12 59/63] drm/amd/amdgpu: fix a potential deadlock in gpu reset

2021-05-24 Thread Sasha Levin
From: Lang Yu [ Upstream commit 9c2876d56f1ce9b6b2072f1446fb1e8d1532cb3d ] When amdgpu_ib_ring_tests failed, the reset logic called amdgpu_device_ip_suspend twice, then deadlock occurred. Deadlock log: [ 805.655192] amdgpu :04:00.0: amdgpu: ib ring test failed (-110). [ 806.290952] [drm]

[PATCH AUTOSEL 5.10 55/62] drm/amd/display: Disconnect non-DP with no EDID

2021-05-24 Thread Sasha Levin
From: Chris Park [ Upstream commit 080039273b126eeb0185a61c045893a25dbc046e ] [Why] Active DP dongles return no EDID when dongle is connected, but VGA display is taken out. Current driver behavior does not remove the active display when this happens, and this is a gap between dongle DTP and dong

[PATCH AUTOSEL 5.10 56/62] drm/amd/amdgpu: fix refcount leak

2021-05-24 Thread Sasha Levin
From: Jingwen Chen [ Upstream commit fa7e6abc75f3d491bc561734312d065dc9dc2a77 ] [Why] the gem object rfb->base.obj[0] is get according to num_planes in amdgpufb_create, but is not put according to num_planes [How] put rfb->base.obj[0] in amdgpu_fbdev_destroy according to num_planes Signed-off-

[PATCH AUTOSEL 5.10 58/62] drm/amd/amdgpu: fix a potential deadlock in gpu reset

2021-05-24 Thread Sasha Levin
From: Lang Yu [ Upstream commit 9c2876d56f1ce9b6b2072f1446fb1e8d1532cb3d ] When amdgpu_ib_ring_tests failed, the reset logic called amdgpu_device_ip_suspend twice, then deadlock occurred. Deadlock log: [ 805.655192] amdgpu :04:00.0: amdgpu: ib ring test failed (-110). [ 806.290952] [drm]

[PATCH AUTOSEL 5.10 59/62] drm/amdgpu: stop touching sched.ready in the backend

2021-05-24 Thread Sasha Levin
From: Christian König [ Upstream commit a2b4785f01280a4291edb9fda69032fc2e4bfd3f ] This unfortunately comes up in regular intervals and breaks GPU reset for the engine in question. The sched.ready flag controls if an engine can't get working during hw_init, but should never be set to false duri

[PATCH AUTOSEL 5.10 57/62] drm/amdgpu: Fix a use-after-free

2021-05-24 Thread Sasha Levin
From: xinhui pan [ Upstream commit 1e5c37385097c35911b0f8a0c67ffd10ee1af9a2 ] looks like we forget to set ttm->sg to NULL. Hit panic below [ 1235.844104] general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b7b4b: [#1] SMP DEBUG_PAGEALLOC NOPTI [ 1235.989074] Call Tra

[PATCH AUTOSEL 5.4 49/52] drm/amd/display: Disconnect non-DP with no EDID

2021-05-24 Thread Sasha Levin
From: Chris Park [ Upstream commit 080039273b126eeb0185a61c045893a25dbc046e ] [Why] Active DP dongles return no EDID when dongle is connected, but VGA display is taken out. Current driver behavior does not remove the active display when this happens, and this is a gap between dongle DTP and dong

[PATCH AUTOSEL 5.4 52/52] drm/amd/amdgpu: fix a potential deadlock in gpu reset

2021-05-24 Thread Sasha Levin
From: Lang Yu [ Upstream commit 9c2876d56f1ce9b6b2072f1446fb1e8d1532cb3d ] When amdgpu_ib_ring_tests failed, the reset logic called amdgpu_device_ip_suspend twice, then deadlock occurred. Deadlock log: [ 805.655192] amdgpu :04:00.0: amdgpu: ib ring test failed (-110). [ 806.290952] [drm]

[PATCH AUTOSEL 5.4 50/52] drm/amd/amdgpu: fix refcount leak

2021-05-24 Thread Sasha Levin
From: Jingwen Chen [ Upstream commit fa7e6abc75f3d491bc561734312d065dc9dc2a77 ] [Why] the gem object rfb->base.obj[0] is get according to num_planes in amdgpufb_create, but is not put according to num_planes [How] put rfb->base.obj[0] in amdgpu_fbdev_destroy according to num_planes Signed-off-

[PATCH AUTOSEL 5.4 51/52] drm/amdgpu: Fix a use-after-free

2021-05-24 Thread Sasha Levin
From: xinhui pan [ Upstream commit 1e5c37385097c35911b0f8a0c67ffd10ee1af9a2 ] looks like we forget to set ttm->sg to NULL. Hit panic below [ 1235.844104] general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b7b4b: [#1] SMP DEBUG_PAGEALLOC NOPTI [ 1235.989074] Call Tra

[PATCH AUTOSEL 4.19 23/25] drm/amd/display: Disconnect non-DP with no EDID

2021-05-24 Thread Sasha Levin
From: Chris Park [ Upstream commit 080039273b126eeb0185a61c045893a25dbc046e ] [Why] Active DP dongles return no EDID when dongle is connected, but VGA display is taken out. Current driver behavior does not remove the active display when this happens, and this is a gap between dongle DTP and dong

[PATCH AUTOSEL 4.19 24/25] drm/amd/amdgpu: fix refcount leak

2021-05-24 Thread Sasha Levin
From: Jingwen Chen [ Upstream commit fa7e6abc75f3d491bc561734312d065dc9dc2a77 ] [Why] the gem object rfb->base.obj[0] is get according to num_planes in amdgpufb_create, but is not put according to num_planes [How] put rfb->base.obj[0] in amdgpu_fbdev_destroy according to num_planes Signed-off-

[PATCH AUTOSEL 4.19 25/25] drm/amdgpu: Fix a use-after-free

2021-05-24 Thread Sasha Levin
From: xinhui pan [ Upstream commit 1e5c37385097c35911b0f8a0c67ffd10ee1af9a2 ] looks like we forget to set ttm->sg to NULL. Hit panic below [ 1235.844104] general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b7b4b: [#1] SMP DEBUG_PAGEALLOC NOPTI [ 1235.989074] Call Tra

[PATCH AUTOSEL 4.14 21/21] drm/amdgpu: Fix a use-after-free

2021-05-24 Thread Sasha Levin
From: xinhui pan [ Upstream commit 1e5c37385097c35911b0f8a0c67ffd10ee1af9a2 ] looks like we forget to set ttm->sg to NULL. Hit panic below [ 1235.844104] general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b7b4b: [#1] SMP DEBUG_PAGEALLOC NOPTI [ 1235.989074] Call Tra

[PATCH AUTOSEL 4.9 19/19] drm/amdgpu: Fix a use-after-free

2021-05-24 Thread Sasha Levin
From: xinhui pan [ Upstream commit 1e5c37385097c35911b0f8a0c67ffd10ee1af9a2 ] looks like we forget to set ttm->sg to NULL. Hit panic below [ 1235.844104] general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b7b4b: [#1] SMP DEBUG_PAGEALLOC NOPTI [ 1235.989074] Call Tra

[PATCH AUTOSEL 4.4 16/16] drm/amdgpu: Fix a use-after-free

2021-05-24 Thread Sasha Levin
From: xinhui pan [ Upstream commit 1e5c37385097c35911b0f8a0c67ffd10ee1af9a2 ] looks like we forget to set ttm->sg to NULL. Hit panic below [ 1235.844104] general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b7b4b: [#1] SMP DEBUG_PAGEALLOC NOPTI [ 1235.989074] Call Tra

Re: [RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters

2021-05-24 Thread Bjorn Andersson
On Mon 24 May 02:30 CDT 2021, Vinod Koul wrote: > On 21-05-21, 09:42, Bjorn Andersson wrote: > > On Fri 21 May 07:49 CDT 2021, Vinod Koul wrote: > > > > > DSC enables streams to be compressed before we send to panel. This > > > requires DSC enabled encoder and a panel to be present. So we add thi

Re: [PATCH v7 00/10] drm: Fix EDID reading on ti-sn65dsi86 by introducing the DP AUX bus

2021-05-24 Thread Doug Anderson
Hi, On Fri, May 21, 2021 at 4:07 PM Lyude Paul wrote: > > For patches 5, and 6: > > Reviewed-by: Lyude Paul > > This week got really busy so I wasn't able to look at the rest of them, but > next > week is going to be a lot less busy so I should be able to look at them then Thanks for your revi

[Bug 213201] New: [KAVERI] memory leak - unreferenced object 0xffff8881700cf988 (size 56)

2021-05-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213201 Bug ID: 213201 Summary: [KAVERI] memory leak - unreferenced object 0x8881700cf988 (size 56) Product: Drivers Version: 2.5 Kernel Version: 5.13-rc3 Hardware: All

[Bug 213201] [KAVERI] memory leak - unreferenced object 0xffff8881700cf988 (size 56)

2021-05-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213201 --- Comment #1 from Erhard F. (erhar...@mailbox.org) --- Created attachment 296969 --> https://bugzilla.kernel.org/attachment.cgi?id=296969&action=edit kernel .config (5.13-rc3, AMD A10 PRO-7800B) -- You may reply to this email to add a commen

Re: [Intel-gfx] [RFC 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-05-24 Thread Tvrtko Ursulin
On 21/05/2021 17:48, Matthew Brost wrote: On Fri, May 21, 2021 at 01:00:54PM +0100, Tvrtko Ursulin wrote: [snip] + * enables parallel submission across multiple engine classes. In this case each + * context's logical engine mask indicates where that context can placed. It is + * implied in

Re: [PATCH v7 04/15] swiotlb: Add restricted DMA pool initialization

2021-05-24 Thread Konrad Rzeszutek Wilk
On Tue, May 18, 2021 at 02:48:35PM +0800, Claire Chang wrote: > I didn't move this to a separate file because I feel it might be > confusing for swiotlb_alloc/free (and need more functions to be > non-static). > Maybe instead of moving to a separate file, we can try to come up with > a better namin

Re: [PATCH 1/3] drm/msm/dp: Simplify aux irq handling code

2021-05-24 Thread khsieh
On 2021-05-07 14:25, Stephen Boyd wrote: We don't need to stash away 'isr' in the aux structure to pass to two functions. Let's use a local variable instead. And we can complete the completion variable in one place instead of two to simplify the code. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc:

Re: [PATCH 2/3] drm/msm/dp: Shrink locking area of dp_aux_transfer()

2021-05-24 Thread khsieh
On 2021-05-07 14:25, Stephen Boyd wrote: We don't need to hold the lock to inspect the message we're going to transfer, and we don't need to clear the busy flag either. Take the lock later and bail out earlier if conditions aren't met. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh

Re: [PATCH v7 05/15] swiotlb: Add a new get_io_tlb_mem getter

2021-05-24 Thread Konrad Rzeszutek Wilk
On Tue, May 18, 2021 at 02:51:52PM +0800, Claire Chang wrote: > Still keep this function because directly using dev->dma_io_tlb_mem > will cause issues for memory allocation for existing devices. The pool > can't support atomic coherent allocation so we need to distinguish the > per device pool and

Re: [PATCH v7 01/15] swiotlb: Refactor swiotlb init functions

2021-05-24 Thread Konrad Rzeszutek Wilk
> > do the set_memory_decrypted()+memset(). Is this okay or should > > swiotlb_init_io_tlb_mem() add an additional argument to do this > > conditionally? > > I'm actually not sure if this it okay. If not, will add an additional > argument for it. Any observations discovered? (Want to make sure my

Re: [PATCH 3/3] drm/msm/dp: Handle aux timeouts, nacks, defers

2021-05-24 Thread khsieh
On 2021-05-07 14:25, Stephen Boyd wrote: Let's look at the irq status bits after a transfer and see if we got a nack or a defer or a timeout, instead of telling drm layers that everything was fine, while still printing an error message. I wasn't sure about NACK+DEFER so I lumped all those various

Re: [Intel-gfx] [PATCH v3 07/12] drm, drm/i915: Move the memcpy_from_wc functionality to core drm

2021-05-24 Thread Matthew Auld
On Fri, 21 May 2021 at 16:33, Thomas Hellström wrote: > > Memcpy from wc will be used as well by TTM memcpy. > Move it to core drm, and make the interface do the right thing > even on !X86. > > Cc: Christian König > Cc: Daniel Vetter > Cc: Dave Airlie > Signed-off-by: Thomas Hellström > ---

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-24 Thread Jason Ekstrand
On Sat, May 22, 2021 at 3:05 PM Daniel Stone wrote: > > Hi, > > On Thu, 20 May 2021 at 20:00, Jason Ekstrand wrote: > > In the Vulkan world, this is useful for dealing with the out-fence from > > vkQueuePresent. Current Linux window-systems (X11, Wayland, etc.) all > > rely on dma-buf implicit s

[Bug 208573] Black screen on boot if two displays plugged in with NAVI 10

2021-05-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208573 --- Comment #14 from Alex Deucher (alexdeuc...@gmail.com) --- Can you bisect? https://www.kernel.org/doc/html/latest/admin-guide/bug-bisect.html -- You may reply to this email to add a comment. You are receiving this mail because: You are watch

Re: [PATCH -next] drm/amdgpu: fix error return code in amdgpu_acpi_init()

2021-05-24 Thread Alex Deucher
On Mon, May 24, 2021 at 9:25 AM Wei Yongjun wrote: > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. I don't see any other cases in this function where we return an error. It could arguably be made a void. All of these APCI m

Re: [Intel-gfx] [PATCH v3 07/12] drm, drm/i915: Move the memcpy_from_wc functionality to core drm

2021-05-24 Thread Thomas Hellström
On Mon, 2021-05-24 at 17:45 +0100, Matthew Auld wrote: > On Fri, 21 May 2021 at 16:33, Thomas Hellström > wrote: > > > > Memcpy from wc will be used as well by TTM memcpy. > > Move it to core drm, and make the interface do the right thing > > even on !X86. > > > > Cc: Christian König > > Cc: Da

Re: [PATCH v3 08/12] drm/ttm: Use drm_memcpy_from_wc_dbm for TTM bo moves

2021-05-24 Thread Matthew Auld
On Fri, 21 May 2021 at 16:33, Thomas Hellström wrote: > > Use fast wc memcpy for reading out of wc memory for TTM bo moves. > > Cc: Dave Airlie > Cc: Christian König > Cc: Daniel Vetter > Signed-off-by: Thomas Hellström > --- > drivers/gpu/drm/ttm/ttm_bo_util.c | 9 - > 1 file changed

[PATCH] drm/panel: panel-simple: Fix proper bpc for ytc700tlag_05_201c

2021-05-24 Thread Jagan Teki
ytc700tlag_05_201c panel support 8 bpc not 6 bpc as per recent testing in i.MX8MM platform. Fix it. Signed-off-by: Jagan Teki --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/pane

Re: [RFC PATCH 37/97] drm/i915/guc: Add stall timer to non blocking CTB send function

2021-05-24 Thread Matthew Brost
On Mon, May 24, 2021 at 02:58:12PM +0200, Michal Wajdeczko wrote: > > > On 06.05.2021 21:13, Matthew Brost wrote: > > Implement a stall timer which fails H2G CTBs once a period of time > > with no forward progress is reached to prevent deadlock. > > > > Also update to ct_write to return -EDEADLK

[Bug 213201] [KAVERI] memory leak - unreferenced object 0xffff8881700cf988 (size 56)

2021-05-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213201 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH v3 08/12] drm/ttm: Use drm_memcpy_from_wc_dbm for TTM bo moves

2021-05-24 Thread Thomas Hellström
On Mon, 2021-05-24 at 19:16 +0100, Matthew Auld wrote: > On Fri, 21 May 2021 at 16:33, Thomas Hellström > wrote: > > > > Use fast wc memcpy for reading out of wc memory for TTM bo moves. > > > > Cc: Dave Airlie > > Cc: Christian König > > Cc: Daniel Vetter > > Signed-off-by: Thomas Hellström

Re: [Intel-gfx] [RFC PATCH 39/97] drm/i915/guc: Increase size of CTB buffers

2021-05-24 Thread Matthew Brost
On Mon, May 24, 2021 at 03:43:11PM +0200, Michal Wajdeczko wrote: > > > On 06.05.2021 21:13, Matthew Brost wrote: > > With the introduction of non-blocking CTBs more than one CTB can be in > > flight at a time. Increasing the size of the CTBs should reduce how > > often software hits the case whe

Re: [PATCH] drm/amdgpu: remove unreachable code

2021-05-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 24, 2021 at 6:47 AM Jiapeng Chong wrote: > > In the function amdgpu_uvd_cs_msg(), every branch in the switch > statement will have a return, so the code below the switch statement > will not be executed. > > Eliminate the follow smatch warning: > > drivers/gpu/

  1   2   >